They're infallible in practice and always `NS_OK`. (This stems from
`AddVarCacheNoAssignment()` always returning `NS_OK`.)
As a result, the commit removes lots of unnecessary checks.
Differential Revision: https://phabricator.services.mozilla.com/D39804
--HG--
extra : moz-landing-system : lando
Fix for the Bug 1536744 removed abiliti for nsIProtocolHandler to parse URLs of the
custom protocols & broke libdweb. In order to fix followup change for Bug 1559356 introduced a
whitelist for dweb: and dat: protocols to parse those as nsIStandardURLs. This change extends
whitelist with ipfs: ipns: ssb: schemes and ext+ prefix scheme.
This would allow Bug 1271553 to progress until better more general solution can be implemnted.
Differential Revision: https://phabricator.services.mozilla.com/D39463
--HG--
extra : moz-landing-system : lando
Sometimes we don't have origin like OCSP requests, or a fetch issues from web extension.
We should not send `Origin:`
Spec doesn't specify how to treat other protocol like moz-extension.
IMO we should also prevent sending `Origin:` to keep web-compat.
Differential Revision: https://phabricator.services.mozilla.com/D39595
--HG--
extra : moz-landing-system : lando
This patch fixes a bug in ipv4NetworkId where we wrongly hashed IP address instead of MAC address. It also simplifies getMac function. MAC address must be 6 bytes long. If it's not it's probably an error and we must not use it.
Differential Revision: https://phabricator.services.mozilla.com/D39349
--HG--
extra : moz-landing-system : lando
Does it matter how nsIMIMEService is obtained? I wouldn't think so, tests continue
to pass with this change, and this will allow me to move ahead with running
xpcshell against geckoview.
Differential Revision: https://phabricator.services.mozilla.com/D39512
--HG--
extra : moz-landing-system : lando
This requires replacing inclusions of it with inclusions of more specific prefs
files.
The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.
Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.
Differential Revision: https://phabricator.services.mozilla.com/D39138
--HG--
extra : moz-landing-system : lando
From the log, I found that the intermittent crash happened because SocketProcessBridgeParent's message loop is destroyed before the IPC channel is closed. Before this patch, the only way to close the IPC channel between SocketProcessBridgeParent and SocketProcessBridgeChild is relying on "content-child-shutdown" notification in child process. If socket process gets terminated before "content-child-shutdown", the IPC channel is never closed.
So, this patch tries to close the IPC channel at SocketProcessChild::CleanUp if the channel is not closed.
Differential Revision: https://phabricator.services.mozilla.com/D38287
--HG--
extra : moz-landing-system : lando
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.
This patch adds annotations to the new failures that show up after part 1.
Differential Revision: https://phabricator.services.mozilla.com/D38726
--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
Johann Hofmann
Ciure Andrei
Nicholas Nethercote
Mihai Alexandru Michis
Irakli Gozalishvili
Thomas Nguyen
Junior Hsu
Andrea Marchesini
Michal Novotny
Dragana Damjanovic
Csoregi Natalia
Tom Schuster
Bogdan Tara
Geoff Brown
Kannan Vijayan
Christoph Walcher
Kris Maglione
Kershaw Chang
Andreea Pavel
ffxbld
Abdoulaye O. Ly
Boris Zbarsky
Benjamin
Eugen Sawin
sagudev
Honza Bambas