Recording events involved asking whether they should go in the event ping or
not, and also whether we hit the limit for how many are allowed in a ping.
These values are stored in prefs which aren't terribly accessible off the main
thread, even if the event recording is.
Both of these prefs have been set in stone in their default values for over two
years now, so we can safely remove them and their scaffolding. Huzzah!
Differential Revision: https://phabricator.services.mozilla.com/D96102
Automatic update from web-platform-tests
[wpt] Minor tweaks for MojoJS setup process
* Also catch OSError when checking the version of Chrome or chromedriver
and produce more meaningful errors.
* Treat Canary the same as Nightly, since we don't have official Canary
build on Linux (where we archive mojojs.zip).
--
wpt-commits: 85ffb5bed019282a8963d73937cdc38bf24920d0
wpt-pr: 26432
Automatic update from web-platform-tests
[scroll-animations] Handle implicit 'auto' offsets correctly
We currently don't handle that case where start/end offsets are
nullptr correctly. In this case they should behave as 'auto'. Possibly
a regression from the scrollOffsets implementation.
Fixed: 1145916
Bug: 1074052
Change-Id: Ib97e1157b957dc2de4393688967694fc9b0de736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520836
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824632}
--
wpt-commits: 2691c36dd92b6b5b8570626ab98d4e828b4e0043
wpt-pr: 26413
Automatic update from web-platform-tests
Missing value default for <animateTransform> 'type' is 'translate'
Also make sure dynamic changes are reflected earlier by calling
AnimationAttributeChanged() when the parsed attribute value changes.
Previously it would only refresh when moving to the next value range, or
otherwise invalidating animation state.
Fixed: 1145548
Change-Id: I8ff82c02e6bf8e3cb82ef4d21e2381cbc99bcd3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520783
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824818}
--
wpt-commits: ef0435de07a7035997e1329ab5e3fb60f3f43fcc
wpt-pr: 26421
Automatic update from web-platform-tests
Use paragraph base direction always for trailing spaces runs.
As per Unicode UAX#9 L1.4, line trailing whitespaces should always have
the direction of the paragraph no matter the direction they had before
line breaking.
To accomplish that, in inline layout algorithm CreateLine, when an
NGInlineItemResult is only trailing spaces, we ignore the bidi
level coming from the NGInlineItem, and just use the base direction
of the line.
This should fix the case of an LTR line with trailing space and
pre-wrap in an RTL line that would end up putting the trailing
space to the right of the last LTR line instead of to the left of
the line.
This fixes css/css-text/white-space/eol-spaces-bidi-002.html with
width of 7 characters. It is still not fixing the case for 8
characters.
Bug: 316409, 1142926
Change-Id: Iab220f79ba0b2526fd51d5341363cc8e9087e133
--
wpt-commits: 8641da2f1ea9a6b3346ac8fdae66c88b2a2ed9db
wpt-pr: 26410
Automatic update from web-platform-tests
Encoding: add tests for GBK and gb18030
These tests come from https://bugs.webkit.org/show_bug.cgi?id=218380.
--
wpt-commits: 3c9820d1cc5d9d2627c26ef1268b6d54a35adf22
wpt-pr: 26385
Automatic update from web-platform-tests
Remove zcorpan as suggested_reviewers in some directories
--
wpt-commits: a8fe47c7dce315b104123d56c29ab272c21c7f9c
wpt-pr: 26428
Automatic update from web-platform-tests
[Canvas new API] Add textRendering to Canvas new API
Add new attribute textRendering to canvas context 2d. Developers can
now choose between auto, optimizeSpeed, optimizeLegibility and
geometricPrecision for textRendering.
Bug: 1144620
Change-Id: I2420967849b1080b667cf6803a8edecc06327297
--
wpt-commits: 68512623f6b74070955634b7c256b9debc743250
wpt-pr: 26368
Automatic update from web-platform-tests
[input] Test some edge-cases for valueAsNumber with type number (#26426)
--
wpt-commits: 36ff3198676718b4af5d55c5e6c1ec8c51a2a0d6
wpt-pr: 26426
Automatic update from web-platform-tests
[css-text] Handling trailing ideographic spaces as regular spaces
The CSS Text 3 specification states on its 'Phase II: Trimming and
Positioning' section:
https://www.w3.org/TR/css-text-3/#white-space-phase-2
3- A sequence at the end of a line of collapsible spaces is removed, as
well as any trailing U+1680 OGHAM SPACE MARK whose white-space property
is normal, nowrap, or pre-line.
4- If there remains any sequence of white space and/or and/or other space
separators, at the end of a line: If white-space is set to pre-wrap, the
UA must hang this sequence. It may also visually collapse the character
advance widths of any that would otherwise overflow.
Summarizing, other space separator are not considered as collapsible
spaces and should be hang, or broken in case of 'break-spaces', according
to the value of the 'white-space' property.
This CL tries to implement such behavior, since we were not considering
this kind of spaces in the hanging/collapsing logic.
For now this change affects LayoutNG only, but it'll be implemented for
Legacy in a different CL.
Bug: 972952
Change-Id: Idb0aff05f7f423f5b62f5169177c0240917435a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687411
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#824597}
--
wpt-commits: 9c959d8835a582e864215eda9fe0e42086b046bf
wpt-pr: 18799
Automatic update from web-platform-tests
Change declarative Shadow DOM fragment parsing to be opt-in
This CL implements most of the suggestions from [1], which effectively
block declarative Shadow DOM from being used by any fragment parser
entry point, unless an explicit opt-in is toggled.
The opt-ins include:
- DOMParser.allowDeclarativeShadowDom = true;
- HTMLTemplateElement.allowDeclarativeShadowDom = true;
- XMLHttpRequest.allowDeclarativeShadowDom = true;
- DocumentFragment.allowDeclarativeShadowDom = true;
- Document.allowDeclarativeShadowDom = true; // For innerHTML
- A new <iframe> sandbox flag: allow-declarative-shadow-dom
This mitigates the potential client-side XSS sanitizer bypass detailed
in the explainer and at [1]. Assuming these changes are functional,
and mitigate the issue, this new behavior will be folded into the
spec PRs at [2] and [3]. But given the security implications of the
existing code, I'd like to get this landed first.
[1] https://github.com/whatwg/dom/issues/912#issue-733465826
[2] https://github.com/whatwg/html/pull/5465
[3] https://github.com/whatwg/dom/pull/892
Bug: 1042130
Change-Id: I088f28f63078a0d26e354a4442494c0132b47ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513525
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824591}
--
wpt-commits: b13461b9a46b46eb1b092a58bde2b10418e7a73d
wpt-pr: 26398
Automatic update from web-platform-tests
Layout shift detection for fixed position
With paint properties geometry mapping, we can already correctly detect
layout shift of fixed-position elements because the viewport scroll
offset doesn't exist in the paint property chain of fixed-position
elements.
Also removed the unnecessary layout viewport clip because it's already
applied in LocalToAncestorClipRect to the LayoutView property tree
state.
Change-Id: I0d77bb4fc828b495536b03f8674d8cab35d0f8bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520330
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824480}
--
wpt-commits: 3a36f4adb22464404bf9a48b5a4d4d4a9210ee03
wpt-pr: 26419
Automatic update from web-platform-tests
Let sticky elements be layout shift roots
This makes PaintInvalidator to detect shifts of descendants of
a sticky ancestor based on the offset from the ancestor instead of the
LayoutView.
Bug: 1145078
Change-Id: I2887dd29e5ab7e7ad843d27673ad567775d4ecc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519360
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824473}
--
wpt-commits: d64a0cd5bc104899051140e7e35e232aa692f85b
wpt-pr: 26403
Automatic update from web-platform-tests
[css-flex] Fix transferred size suggestion for stretched items
Before this, Blink required flex items to have a definite _computed_
cross size to enable transferred size suggestions in automatic minimum
size computations. But a definite preferred cross size is sufficient,
which allows for definite cross sizes via stretching to be used for
transferred size suggestions.
Bug: 1132627
Change-Id: I0c6c0117159000f98bca29e722aaf7c7ddee5251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520082
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824467}
--
wpt-commits: e463526c30a7af8517d92f2645b55624f06e3d9f
wpt-pr: 26409
Automatic update from web-platform-tests
[Critical-CH] Add check for unsafe HTTP methods
According to the Client Hint Reliability ietf draft
https://tools.ietf.org/html/draft-davidben-http-client-hint-reliability#section-3
> If the request did not use a safe method (Section 4.2.1 of
[RFC7231]), ignore the Critical-CH header and continue processing
the response as usual.
Also added a WPT to make sure.
Bug: 1127313
Change-Id: I82682077dfa51a4aa7204a973c192379cd6588c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508711
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824434}
--
wpt-commits: 49ea137684bf2172d8a899ee6f32d39999efa495
wpt-pr: 26347
This patch takes care of a case where a talos result line is written on two lines rather than one. The reason for why it's being written on two lines needs to be investigated in the future. There doesn't seem to be any hidden characters in the lines so it's likely related to `dump` or the `MozillaFileLogger`.
Differential Revision: https://phabricator.services.mozilla.com/D96120