- access key to the "Create in" button
- clicking on the label should focus the control next to it.
- Change the order of the focus with tab: the name field, the menulist field and then the expander.
- renaming some entities to respect the interCaps convention
Some cleanup, use of "class" instead of "id" for the "open in tabs" menuitem and menuseparator, because the latter are supposed to be unique in the document.
Bug 210910: Right-clicking a file within a bookmarks folder in the bookmarks menu or toolbar makes that folder inaccessible
I added the bm command controller to the menubar bookmark menu, to deal with hidden bookmarks toolbar.
- selecting a folder in the tree selects the menulist selectedItem if it is already in the dropdown
- unselect it if the folder is not in it
- make sure that a row is always selected.
- ensure that the row of a folder selected in the menulist is visible when the tree is expanded.
- cleanup, consolidate logic
- getParent: returns the (first) parent of a resource.
- getParentChain: returns a nsIArray of containers from NC:BookmarksTopRoot down to the parent of the resource.
Featuring an expandable tree and a dropdown menu containing the last used folders.
The 'new folder' functionality has not been included, yet.
Thanks to bz for the help on nsCOMArrays.
PrintUtils.printPreview(enterPPCallback, exitPPCallback) where the optional callback functions are called just before entering and after exiting PP mode
- disable all short keys in PP mode except ctrl-W and fix bug 178485 and bug 215277. Now clicking the close window icon actually closes the window.
- global vars gPrintSettingsAreGlobal, gSavePrintSettings, gPrintSettings, gOldCloseHandler, gInPrintPreviewMode, gWebProgress are removed.
- A lot of cleanup.
- enhance dumpOBJ debug routine to deal with null and properties not accessible that trigger an error
- enclose all the debug routine by a #ifdef DEBUG
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).