Andrew Osmond
f5baf0eea6
Bug 1632259 - Refactor WebRender configuration logic in gfxPlatform to be testable. r=jrmuizel
...
We have encountered issues when rolling out WebRender because the
configuration logic is quite complicated. It would serve us well to have
it in a form that we can easily test. This patch does said refactor, as
well as adds an initial set of tests.
Differential Revision: https://phabricator.services.mozilla.com/D72027
2020-05-04 01:01:53 +00:00
Geoff Brown
b987f3b775
Bug 1630774 - Skip some gfx crashtests on android webrender; r=jmaher
...
Update crashtest expectations to avoid troublesome wr_moz2d_render_cb crashes more effectively.
Differential Revision: https://phabricator.services.mozilla.com/D72966
2020-04-28 22:49:28 +00:00
Stefan Hindli
d66d0256bb
Bug 1630774 - Disabled 1325159-1.html and 1317403-1.html on Android r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D72526
2020-04-25 10:04:47 +00:00
Andrew Osmond
1a32712543
Bug 1622220 - Add UnpremultiplyRow and extend SwizzleRow. r=lsalzman
...
UnpremultiplyRow will be used in the image encoders to reverse
premultiplication. SwizzleRow needs to support copying (no swizzling)
and swapping RGB/BGR.
Differential Revision: https://phabricator.services.mozilla.com/D66743
--HG--
extra : moz-landing-system : lando
2020-04-08 12:50:40 +00:00
Botond Ballo
400b5015cc
Bug 1627482 - Fix non-unified build errors in gfx/tests. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D69733
--HG--
extra : moz-landing-system : lando
2020-04-05 03:50:23 +00:00
Nicolas Silva
258b9dbb37
Bug 1626209 - Adjust reftest fuzziness. r=kats
...
Differential Revision: https://phabricator.services.mozilla.com/D69384
--HG--
extra : moz-landing-system : lando
2020-04-02 14:57:34 +00:00
Markus Stange
6b7047492f
Bug 1595038 - Make sure that TransformAndClipBounds returns an empty clipped rect when the clip itself is already empty. r=kip
...
The test added in this changeset is already fixed by the no-normalization change, but there are probably cases that require the explicit check that this patch adds.
When we were still normalizing the plane normals, the TransformAndClipBounds call in the added test was returning (1023.999878, 1023.999878, 0.000061, 0.000122).
Depends on D68703
Differential Revision: https://phabricator.services.mozilla.com/D68704
--HG--
extra : moz-landing-system : lando
2020-04-02 04:00:53 +00:00
Markus Stange
70151209d3
Bug 1595038 - Stop normalizing the plane normals, in order reduce error from floating point inaccuracies. r=kip
...
For example, if the clipping rectangle has aClip.X() == 1024, then the normal for the clipping plane induced by the left edge of the clip will now be (1, 0, 0, -1024) rather than (0.0009765620343390458, 0, 0, -0.9999995231631829).
This change is mathematically valid:
- The dot products computed from these vectors become multiplied by planeNormal.Length() (compared to before this patch).
- The sign of the dot products is not affected, so the "intersection with plane" check is not affected:
`if ((nextDot >= 0.0) != (prevDot >= 0.0)) {`
- The value of the dot products is only used to compute `t`, as follows:
`F t = -prevDot / (nextDot - prevDot);`
Here, the length now appears both in the numerator and in the denominator, canceling itself out.
As a result from this change, the existing tests no longer require integer nudging in order to pass.
Depends on D68702
Differential Revision: https://phabricator.services.mozilla.com/D68703
--HG--
extra : moz-landing-system : lando
2020-04-01 01:06:23 +00:00
Nicolas Silva
7c89bf3c58
Bug 1617050 - Take shadow offsets into account when clipping a primitive. r=gw
...
Differential Revision: https://phabricator.services.mozilla.com/D68230
--HG--
extra : moz-landing-system : lando
2020-03-31 09:37:57 +00:00
Botond Ballo
6a4407c26e
Bug 1621803 - Fix additional bugs in Matrix4x4Flagged::operator*(Matrix4x4). r=bas
...
Differential Revision: https://phabricator.services.mozilla.com/D66505
--HG--
extra : moz-landing-system : lando
2020-03-25 15:22:14 +00:00
Mihai Alexandru Michis
b0060ff6a8
Backed out changeset 70b7dcfea394 (bug 1622220) for causing failures in gfx/2d/Swizzle.cpp
...
CLOSED TREE
2020-03-13 15:07:13 +02:00
Andrew Osmond
acdd6810d2
Bug 1622220 - Add UnpremultiplyRow and extend SwizzleRow. r=lsalzman
...
UnpremultiplyRow will be used in the image encoders to reverse
premultiplication. SwizzleRow needs to support copying (no swizzling)
and swapping RGB/BGR.
Differential Revision: https://phabricator.services.mozilla.com/D66743
--HG--
extra : moz-landing-system : lando
2020-03-13 11:35:12 +00:00
Andrew Osmond
964c6a2c3f
Bug 1616444 - Ensure gradients are properly color managed with WebRender. r=jrmuizel
...
Differential Revision: https://phabricator.services.mozilla.com/D66087
--HG--
extra : moz-landing-system : lando
2020-03-09 17:11:54 +00:00
Andrew Osmond
91b071ed14
Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel
...
gfx::Color is currently misused in many places. The DrawTargets expect
the color space to be in device space, e.g. what we are actually going
to draw using. Everything sitting above generally deals with sRGB, as
specified in CSS. Sometimes we missed the conversion from sRGB to device
space when issuing draw calls, and similarly sometimes we converted the
color to device space twice.
This patch splits the type in two. sRGBColor and DeviceColor now
represent sRGB and device color spaces respectively. DrawTarget only
accepts DeviceColor, and one can get a DeviceColor from an sRGBColor via
the ToDeviceColor helper API. The reftests now pass with color
management enabled for everything (e.g. CSS) instead of just tagged
raster images.
There will be a follow up patch to enable color management everywhere by
default on all supported platforms.
Differential Revision: https://phabricator.services.mozilla.com/D64771
--HG--
extra : moz-landing-system : lando
2020-03-09 14:16:17 +00:00
Andrew Osmond
4831a6bd0e
Bug 1616030 - Fix SwizzleRow for big endian systems. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D65797
--HG--
extra : moz-landing-system : lando
2020-03-06 20:04:18 +00:00
Jonathan Kew
e1a0b48294
Bug 1620125 - Don't assume mVerticalMetrics has necessarily been initialized before DrawOneGlyph is called. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D65567
--HG--
extra : moz-landing-system : lando
2020-03-05 18:07:17 +00:00
Simon Giesecke
dce1e48caf
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel
...
Differential Revision: https://phabricator.services.mozilla.com/D65288
--HG--
extra : moz-landing-system : lando
2020-03-04 15:39:20 +00:00
Glenn Watson
10c752a7ab
Bug 1615091 - Fix panic in resolve_split_planes with invalid transform. r=nical
...
Differential Revision: https://phabricator.services.mozilla.com/D63033
--HG--
extra : moz-landing-system : lando
2020-02-17 14:37:34 +00:00
Glenn Watson
1b40eb8660
Bug 1615141 - Fix panic in picture cache dependency building. r=Bert
...
Differential Revision: https://phabricator.services.mozilla.com/D62851
--HG--
extra : moz-landing-system : lando
2020-02-14 00:30:02 +00:00
pbz
70e1dba79e
Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D55811
--HG--
extra : moz-landing-system : lando
2020-01-16 14:38:40 +00:00
Andrew Osmond
bb4bf3f608
Bug 1600911 - Implement AVX variant of QCMS ICCv2 algorithm. r=jrmuizel
...
Our performance gtests indicate anywhere from 10-20% reduction in
execution time based on the SSE2 version. Where it fell in the range
depended on the platform, but presumably that is related to the hardware
selected by treeherder. llvm-mca suggested it should be closer to 20%
on modern hardware (skylake).
Differential Revision: https://phabricator.services.mozilla.com/D55642
--HG--
extra : moz-landing-system : lando
2019-12-17 19:22:36 +00:00
Oana Pop Rus
661db3a39f
Backed out 7 changesets (bug 1432856) for build bustages failures in nsWindow.h on a CLOSED TREE
...
Backed out changeset 3d08c3cce533 (bug 1432856)
Backed out changeset 49d03dd89b17 (bug 1432856)
Backed out changeset 62fc84c8ce99 (bug 1432856)
Backed out changeset a8a4fa63f5b2 (bug 1432856)
Backed out changeset c81f3d5b9bf3 (bug 1432856)
Backed out changeset 8351a8b1d96a (bug 1432856)
Backed out changeset a303b775a51b (bug 1432856)
2019-12-16 23:53:35 +02:00
pbz
e03ecc2171
Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D55811
--HG--
extra : moz-landing-system : lando
2019-12-16 21:06:11 +00:00
Csoregi Natalia
c6abd544c4
Backed out changeset 5483da347be3 (bug 1600911) for bustage on transform-avx.cpp. CLOSED TREE
2019-12-13 21:39:14 +02:00
Andrew Osmond
9e59ec2b0d
Bug 1600911 - Implement AVX variant of QCMS ICCv2 algorithm. r=jrmuizel
...
Our performance gtests indicate anywhere from 10-20% reduction in
execution time based on the SSE2 version. Where it fell in the range
depended on the platform, but presumably that is related to the hardware
selected by treeherder. llvm-mca suggested it should be closer to 20%
on modern hardware (skylake).
Differential Revision: https://phabricator.services.mozilla.com/D55642
--HG--
extra : moz-landing-system : lando
2019-12-13 18:26:22 +00:00
Emma Malysz
c502777f53
Bug 1597847, rename remaining misc xul files from within /view, /gfx, /extensions, and /testing to .xhtml format r=marionette-reviewers,bgrins,whimboo,gbrown
...
Differential Revision: https://phabricator.services.mozilla.com/D54035
--HG--
rename : extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xul => extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xhtml
rename : gfx/tests/crashtests/593526.xul => gfx/tests/crashtests/593526.xhtml
rename : testing/marionette/chrome/test.xul => testing/marionette/chrome/test.xhtml
rename : testing/marionette/chrome/test2.xul => testing/marionette/chrome/test2.xhtml
rename : testing/marionette/chrome/test_dialog.xul => testing/marionette/chrome/test_dialog.xhtml
rename : testing/marionette/chrome/test_nested_iframe.xul => testing/marionette/chrome/test_nested_iframe.xhtml
rename : testing/marionette/reftest.xul => testing/marionette/reftest.xhtml
rename : testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xul => testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xhtml
rename : testing/mochitest/browser-harness.xul => testing/mochitest/browser-harness.xhtml
rename : testing/mochitest/chrome/test_chromeGetTestFile.xul => testing/mochitest/chrome/test_chromeGetTestFile.xhtml
rename : testing/mochitest/chrome/test_sample.xul => testing/mochitest/chrome/test_sample.xhtml
rename : testing/mochitest/chrome/test_sanityEventUtils.xul => testing/mochitest/chrome/test_sanityEventUtils.xhtml
rename : testing/mochitest/chrome/test_sanityException.xul => testing/mochitest/chrome/test_sanityException.xhtml
rename : testing/mochitest/chrome/test_sanityException2.xul => testing/mochitest/chrome/test_sanityException2.xhtml
rename : testing/mochitest/chrome/test_sanityManifest.xul => testing/mochitest/chrome/test_sanityManifest.xhtml
rename : testing/mochitest/chrome/test_sanityManifest_pf.xul => testing/mochitest/chrome/test_sanityManifest_pf.xhtml
rename : testing/mochitest/chrome/test_tasks_skip.xul => testing/mochitest/chrome/test_tasks_skip.xhtml
rename : testing/mochitest/chrome/test_tasks_skipall.xul => testing/mochitest/chrome/test_tasks_skipall.xhtml
rename : testing/mochitest/harness.xul => testing/mochitest/harness.xhtml
rename : testing/talos/talos/pageloader/chrome/pageloader.xul => testing/talos/talos/pageloader/chrome/pageloader.xhtml
rename : view/crashtests/382756-1.xul => view/crashtests/382756-1.xhtml
rename : view/crashtests/38589-1.xul => view/crashtests/38589-1.xhtml
extra : moz-landing-system : lando
2019-12-02 19:16:22 +00:00
Brian Grinstead
432c1a8641
Bug 1587142 - Remove miscellaneous XBL tests r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D50652
--HG--
extra : moz-landing-system : lando
2019-10-25 21:53:33 +00:00
Sylvestre Ledru
7c309095ea
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D49056
--HG--
extra : moz-landing-system : lando
2019-10-21 14:13:44 +00:00
Botond Ballo
a980b29c49
Bug 1589204 - Fix a bug in Matrix4x4Flagged::operator*. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D49486
--HG--
extra : moz-landing-system : lando
2019-10-16 21:01:16 +00:00
Brendan Dahl
237d762715
Bug 1510785 - Skip all XBL related tests when XBL is disabled. r=bzbarsky
...
XBL will be disabled on android, so these tests must be skipped. Where possible
tests are copied to create shadow DOM tests.
Depends on D45615
Differential Revision: https://phabricator.services.mozilla.com/D45616
--HG--
rename : layout/inspector/tests/test_bug522601.xhtml => layout/inspector/tests/test_bug522601-shadow.xhtml
rename : layout/inspector/tests/test_bug609549.xhtml => layout/inspector/tests/test_bug609549-shadow.xhtml
rename : layout/reftests/bugs/334829-1a.xhtml => layout/reftests/bugs/334829-1a-shadow.xhtml
rename : layout/reftests/bugs/334829-1b.xhtml => layout/reftests/bugs/334829-1b-shadow.xhtml
rename : layout/reftests/bugs/386310-1b.html => layout/reftests/bugs/386310-1b-shadow.html
rename : layout/reftests/bugs/386310-1c.html => layout/reftests/bugs/386310-1c-shadow.html
rename : layout/reftests/bugs/386310-1d.html => layout/reftests/bugs/386310-1d-shadow.html
rename : layout/reftests/bugs/482592-1a.xhtml => layout/reftests/bugs/482592-1a-shadow.xhtml
rename : layout/reftests/bugs/482592-1b.xhtml => layout/reftests/bugs/482592-1b-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-1.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-1-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-2.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-appendmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-insertmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-ref2.xhtml => layout/reftests/dom/multipleinsertionpoints-ref2-shadow.xhtml
rename : layout/reftests/ib-split/insert-into-split-inline-5.html => layout/reftests/ib-split/insert-into-split-inline-5-shadow.html
extra : moz-landing-system : lando
2019-10-08 23:52:46 +00:00
Andrew Osmond
b1bffae1bc
Bug 1551088 - Part 4. Add gtests for PremultiplyRow and SwizzleRow. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D46447
--HG--
extra : moz-landing-system : lando
2019-10-02 13:37:26 +00:00
Hiroyuki Ikezoe
16081f5205
Bug 1547169 - A crash test by fuzzing. r=boris
...
Depends on D47566
Differential Revision: https://phabricator.services.mozilla.com/D47567
--HG--
extra : moz-landing-system : lando
2019-09-30 19:49:36 +00:00
Hiroyuki Ikezoe
1940fb41d3
Bug 1529149 - A crash test by fuzzing. r=boris
...
Depends on D47565
Differential Revision: https://phabricator.services.mozilla.com/D47566
--HG--
extra : moz-landing-system : lando
2019-09-30 19:49:32 +00:00
Andreea Pavel
9fd779e03f
Merge mozilla-central to autoland on a CLOSED TREE
2019-09-26 01:00:14 +03:00
Cosmin Sabou
6da90eb0b7
Backed out 9 changesets (bug 1551088) for causing Bug 1583848. a=backout
...
Backed out changeset d0ab25c226a7 (bug 1551088)
Backed out changeset 9ef391e20fa6 (bug 1551088)
Backed out changeset 3e6f25b21f8c (bug 1551088)
Backed out changeset 5d72c8de4daf (bug 1551088)
Backed out changeset f77c43bcc75b (bug 1551088)
Backed out changeset 9e954d6765de (bug 1551088)
Backed out changeset d90a571e581f (bug 1551088)
Backed out changeset 25a5f5563e9d (bug 1551088)
Backed out changeset bed9c93eeb2d (bug 1551088)
2019-09-25 18:42:48 +03:00
Ryan VanderMeulen
b12c4363fb
Bug 1577799 - Update OTS to 8.0.0. r=jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D44703
--HG--
rename : gfx/ots/src/cff_type2_charstring.cc => gfx/ots/src/cff_charstring.cc
rename : gfx/ots/src/cff_type2_charstring.h => gfx/ots/src/cff_charstring.h
rename : gfx/ots/tests/cff_type2_charstring_test.cc => gfx/ots/tests/cff_charstring_test.cc
extra : moz-landing-system : lando
2019-09-13 09:47:50 +00:00
Andrew Osmond
94b66bc792
Bug 1551088 - Part 4. Add gtests for PremultiplyRow and SwizzleRow. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D46447
--HG--
extra : moz-landing-system : lando
2019-09-24 20:42:44 +00:00
Oana Pop Rus
4f9a3f24ba
Backed out 8 changesets (bug 1551088) for causing reftest failures in SwizzleAVX2.cpp and SwizzleSSSE3.cpp on a CLOSED TREE
...
Backed out changeset b3760d42e3bf (bug 1551088)
Backed out changeset 222e856b5bc3 (bug 1551088)
Backed out changeset b259c9fb5ad6 (bug 1551088)
Backed out changeset 5fe283ceaa0b (bug 1551088)
Backed out changeset d4dadb6ef0bd (bug 1551088)
Backed out changeset 925e26e17abe (bug 1551088)
Backed out changeset a011360f5018 (bug 1551088)
Backed out changeset 229c3d631d2e (bug 1551088)
2019-09-24 18:12:39 +03:00
Andrew Osmond
c5c9ec107c
Bug 1551088 - Part 4. Add gtests for PremultiplyRow and SwizzleRow. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D46447
--HG--
extra : moz-landing-system : lando
2019-09-24 13:31:28 +00:00
Geoff Brown
b0e5901c93
Bug 1582884 - Enable some crashtests on Android; r=geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D46784
--HG--
extra : moz-landing-system : lando
2019-09-24 01:12:09 +00:00
Cosmin Sabou
69acba5002
Backed out 8 changesets (bug 1551088) for causing build bustages. CLOSED TREE
...
Backed out changeset 02d9dc4d39a5 (bug 1551088)
Backed out changeset d7684ca35c0d (bug 1551088)
Backed out changeset b061b1bf8281 (bug 1551088)
Backed out changeset 4760b8b22ffd (bug 1551088)
Backed out changeset 4685fc022257 (bug 1551088)
Backed out changeset 91300f9f99bb (bug 1551088)
Backed out changeset 6da767c8d55c (bug 1551088)
Backed out changeset ec69be661551 (bug 1551088)
2019-09-21 14:52:41 +03:00
Andrew Osmond
e203ac1b2f
Bug 1551088 - Part 4. Add gtests for PremultiplyRow and SwizzleRow. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D46447
--HG--
extra : moz-landing-system : lando
2019-09-20 19:17:06 +00:00
Andrew Osmond
ab39496ccc
Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
...
Differential Revision: https://phabricator.services.mozilla.com/D45539
--HG--
extra : moz-landing-system : lando
2019-09-14 16:16:59 +00:00
Ciure Andrei
a4046ec458
Backed out 6 changesets (bug 1574493) for causing nested-sticky-2.html to perma fail CLOSED TREE
...
Backed out changeset 358746636448 (bug 1574493)
Backed out changeset 34aef5498237 (bug 1574493)
Backed out changeset 1f88e2031c76 (bug 1574493)
Backed out changeset 07c588b5ea10 (bug 1574493)
Backed out changeset 0685e8d3510e (bug 1574493)
Backed out changeset 15d4390220c4 (bug 1574493)
2019-09-13 19:26:50 +03:00
Andrew Osmond
35a0f13ba2
Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
...
Differential Revision: https://phabricator.services.mozilla.com/D45539
--HG--
extra : moz-landing-system : lando
2019-09-13 14:03:28 +00:00
Ciure Andrei
8c3feea58a
Backed out 6 changesets (bug 1574493) for causing nested-sticky-1.html to perma fail CLOSED TREE
...
Backed out changeset fdc25a90b0ef (bug 1574493)
Backed out changeset 0ce3c48c1f79 (bug 1574493)
Backed out changeset 326b9f96614b (bug 1574493)
Backed out changeset b0817c0aee77 (bug 1574493)
Backed out changeset 70d99c264df9 (bug 1574493)
Backed out changeset e5217ab4b668 (bug 1574493)
2019-09-13 16:17:47 +03:00
Andrew Osmond
4d96fe56c4
Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
...
Differential Revision: https://phabricator.services.mozilla.com/D45539
--HG--
extra : moz-landing-system : lando
2019-09-13 10:48:37 +00:00
Gurzau Raul
fe4bb6d539
Backed out 6 changesets (bug 1574493) for wrench failures at stacking-context-clip.yaml on a CLOSED TREE.
...
Backed out changeset 8a8736ac4e25 (bug 1574493)
Backed out changeset 4a3294e88823 (bug 1574493)
Backed out changeset 0c26ecdc1ddc (bug 1574493)
Backed out changeset 11257f7b3ad3 (bug 1574493)
Backed out changeset dcedc286ad9d (bug 1574493)
Backed out changeset 87f216e0753d (bug 1574493)
2019-09-12 18:34:07 +03:00
Andrew Osmond
ff567c5ddb
Bug 1574493 - Part 6. Add reftest annotations for newly failing/passing tests. r=jrmuizel,kvark
...
Differential Revision: https://phabricator.services.mozilla.com/D45539
--HG--
extra : moz-landing-system : lando
2019-09-12 12:42:52 +00:00
Markus Stange
9cd785e1c4
Bug 1578045 - Correctly return zero vertices if clipping plane 0 or 2 clip away the entire polygon. r=kip
...
This fixes a bug that was introduced three years ago in bug 1268854.
What happened was that the final pass over the polygon assumed that the current
polygon was living in plane[0]. But due to the double buffering, the "current"
polygon alternates between plane[0] and plane[1]. And bug 1268854 had introduced
an early exit so that we could hit the final pass at a time where the current,
now empty, polygon was in plane[1]. So we would incorrectly treat all 32 points
in plane[0] as part of the final polygon.
This bug was responsible for intermittently unreasonable numbers in CompositorOGL's fill
rate / overdraw overlay, and, since changeset cc84a0e9d5ddde198422f4f11ab6bf85f631d5f0,
also caused CompositorOGL to execute unnecessary draw calls.
Differential Revision: https://phabricator.services.mozilla.com/D44312
--HG--
extra : moz-landing-system : lando
2019-09-06 17:12:06 +00:00