These functions no longer perform any refcounting, so the existing names are
misleading.
MozReview-Commit-ID: LX55e0bUP8N
--HG--
extra : rebase_source : 89a3da577325286c1d31723acfd4153754f49703
This function captures a common usage pattern, generalizing the existing
IsMember() function.
MozReview-Commit-ID: 5Pt7kqyGD6Y
--HG--
extra : rebase_source : b03e4cc8f5a4a25da9236420f4b64493664b70e0
It seems silly to have a tiny utils class with a single function in its own
module. This patch moves it into nsStaticAtom.h/nsAtomTable.cpp. It also
renames nsAtomListUtils as nsStaticAtomUtils. Finally, it uses templates to
remove the need for the `aCount` parameter at callsites.
MozReview-Commit-ID: DvJVoZFv89c
--HG--
extra : rebase_source : 1f1dd27d56e46c71c30c10102ac6132a721e23d1
Instantbird referenced xul-windows-visible which is a app ID mapping for a signal sent to notify when the app is displayed.
Removed unused app ID of instantbird referring to xul-windows-visible and removed switch statement referring to xul-windows-visble.
--HG--
extra : rebase_source : d9f7fdea810f209b33b195907c38b58a365d9be3
This isn't strictly related, but I ran into it for the nth time while updating
tests, and I got fed up with having my tests fail with a useless numeric value
with no indication of where it came from.
MozReview-Commit-ID: 6OjgVYw7tNd
--HG--
extra : rebase_source : 259667d2a26ec4252a0f8a097ca35b3b702b17a0
extra : histedit_source : 492f541471b896a9a4b941baad2b14de8faf9113
The transforms for turning an nsIScriptError into a payload that Sentry
understands were getting a bit complex for a single function, so they're
refactored into a list of transform functions that are applied in sequence to
produce the payload. This will make it easier to manage adding new transforms to
the list.
Refactoring this revaled a problem with the test code: it assumed that listeners
for console messages were notified in order of registration (since it used a
temporary listener to determine when the rest of the listeners had been notified
of a message). Changing the async evaluation of the code broke the tests, so
they had to be refactored as well.
Without a way to know when all console listeners have been notified, we can't
assert that a message will not be received by BrowserErrorReporter. We do two
things to get around this:
- Where possible, call `observe` directly on the reporter instance.
- Add constructor params for registering and unregistering listeners so we can
test that logic without relying on messages being received or not.
MozReview-Commit-ID: EEH6IROOuHD
--HG--
extra : rebase_source : a5af344c86e9756d4dbef761e4a6060515c87a61
extra : histedit_source : 5491c7359d2989a2735ec6d39de372154706c475
Now that WebExtensions run OOP in Windows by default, and we have no intention
of going back, there's no need to run an extra set of in-process tests for
them.
MozReview-Commit-ID: t8ryuuNFHe
--HG--
extra : amend_source : 90e006ca618206a943991b14cb11779baa7b8934
On investigation it turns out that no storage types are supported for chrome:// urls.
MozReview-Commit-ID: JZcQg5FvfvN
--HG--
extra : rebase_source : ea3ad83a5b81fb77fedf1ec4707294c45b6a5257
Calling into the Photon PageAction API to update a property is orders of
magnitude more expensive than the simple DOM-based updates we used previously.
To make matters worse, a lot of our caching was removed during the migration,
and the Photon API introduces a lot of duplicated work when selecting icons.
This patch caches the last known state for each property to avoid calling into
the Photon APIs to update each property more than necessary, and removes the
extraneous preferred icon size calculations that the Photon code already
duplicates.
MozReview-Commit-ID: LjPPxolmcd6
--HG--
extra : rebase_source : 70bce5b1460c93cc738999b1e167eb17a39259b1
The amount of computational complexity and garbage array/string/object
generation for each update to a pageAction property went up astronomically
with the migration of WebExtension page actions to the Photon API. This
resulted in non-trivial talos regression when Screenshots attempted to switch
back to the built-in pageAction API.
These changes fix most of the garbage generation, and reduce a lot of the
duplicated work for each update.
MozReview-Commit-ID: 4uPLnAesdU2
--HG--
extra : rebase_source : 3f723f3f35abf032cf12e02ce38552e21ea4827f
Also adds new crh locale and in-content prefs test fix.
MozReview-Commit-ID: DFs0s710wZ4
--HG--
extra : rebase_source : 7edf0d5401cdb8da9559d98fe7837d6f23889c85
The function was used through multiple tests so it makes sense
to have it in common.js.
We take this as an opportunity to unify the style of the tests, and
to make closeDebugger return a Promise.
MozReview-Commit-ID: 7y8dMNErYZp
--HG--
extra : rebase_source : 61fa671d0f6c31b68d9b94a388454d39446a12bf
The test was testing that the 3 messages we display when
evaluating a console.log (text of the input, evaluation result,
consoleAPI message) all had a timestamp in a 2000ms range.
This wasn't really what it should have been about, since the
original bugfix (for Bug 1405243), was only in Console.cpp (and
the fix is still up there).
So here we only assert that the timestamp in the ConsoleAPI packet
is between the moment the log was requested and the time we receive
the packet.
MozReview-Commit-ID: HikGCJGHXMy
--HG--
extra : rebase_source : beeec437f12592b2229c89a5ab9125cc66d1971e
extra : source : 041a5ee841a41db1afca180d6b67890622543123
Boris Zbarsky
Chris H-C
Nicholas Nethercote
Daisuke Akatsuka
Ryan Hunt
Ben Kelly
sreeise
Kris Maglione
Michael Kelly
Emilio Cobos Álvarez
Jon Coppeard
Steve Fink
Cosmin Sabou
Michael Ratcliffe
sotaro
Ed Lee
Nicolas Chevobbe