Граф коммитов

1762 Коммитов

Автор SHA1 Сообщение Дата
Edouard Oger e29fd6597a Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : cc4d0d3ca7d12b2f83b79fc7c5db9c05f77944cf
2017-09-20 13:16:19 -04:00
Sebastian Hengst 6c9c0c17e9 Backed out changeset 9ab9bde4021f (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:49:30 +02:00
Edouard Oger 27e4a543cc Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 23d246a20afd7069f095e29b2943851011813239
2017-09-20 13:16:19 -04:00
Sebastian Hengst 0b883eed0e Backed out changeset 97fdb9d392e5 (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:12:32 +02:00
Gijs Kruitbosch 8e37c2add4 Bug 1405643 - swap out overflow panel label to say 'menu' instead of 'panel', r=mkelly
MozReview-Commit-ID: DCEO6Snxxeu

--HG--
extra : rebase_source : f7238a1d28032524f67a8377d2752a3854de0cb7
2017-10-04 16:09:01 +01:00
Edouard Oger bc78c3795e Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 3172be8b46d44c50ea4f2c806771e10172057cf3
2017-09-20 13:16:19 -04:00
Gijs Kruitbosch d2d9cc5fb4 Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, r=mikedeboer
The third param of 'getTabsFragment' and 'getWindowsFragment' toggles whether the 'restore all' item
gets prefixed (true) or suffixed (false). The prefixed version doesn't get a separator, so this
seems like the simplest fix.

MozReview-Commit-ID: BzKWvndWUMp

--HG--
extra : rebase_source : 600af608c5c62ed000bec1778c05dcc75e7b8585
2017-10-03 19:29:36 +01:00
Jared Wein 5fde947458 Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs
MozReview-Commit-ID: JOsb2y2pzqz

--HG--
extra : rebase_source : d8471cdda0dfc114c2efe7e200ca3c4f25ecabb8
2017-10-02 23:30:29 -04:00
Gijs Kruitbosch c7a51be34d Bug 1402929 - add header to overflow panel in customize mode, r=mikedeboer
MozReview-Commit-ID: 7Z8Xk2X707J

--HG--
extra : rebase_source : 6422413079a4aeb0bf1e44ff39aaea58a2711166
2017-09-29 23:10:38 +01:00
Gijs Kruitbosch d9dae67b93 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp

--HG--
extra : rebase_source : 0a7865fcfd11eb5baca858cde71ea4e8b30d5afc
2017-09-29 17:55:50 +01:00
Maya Messinger 530424bf98 Bug 1396953 - fix flexible space widget disappearing when adding to toolbar r=Gijs
MozReview-Commit-ID: BuYzvBX439p

--HG--
extra : rebase_source : 2380bf5517da3982838e4c07dbc22a06c9f38465
2017-09-30 18:42:24 -04:00
Gijs Kruitbosch 49c8b259d5 Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
MozReview-Commit-ID: AqBwn9ovTjT

--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch f207243be7 Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
MozReview-Commit-ID: 4GxPEm119Yc

--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
2017-09-27 22:37:19 +01:00
Mike de Boer 882fa06e25 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j

--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
2017-09-29 13:51:51 +02:00
Sebastian Hengst e0196045d0 Backed out changeset 8855ba3f65ba (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-09-28 20:27:50 +02:00
Edouard Oger c602795751 Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 562023d6bfdb78aa2fad6c42948b57db8bc04f99
2017-09-20 13:16:19 -04:00
Sam Foster f933fa62ca Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs
MozReview-Commit-ID: I1pGXA3ecxT

--HG--
extra : rebase_source : ebfd4dbc2191a921ea04f0fcf56270ad945c3e37
2017-09-25 19:29:04 -07:00
Erica Wright a9e25e23df Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs
MozReview-Commit-ID: 5sQPsxVaVYz

--HG--
extra : rebase_source : 6eab6e7e9d65bc0b45dea6dac7daf3cd23fc6c77
2017-09-21 18:15:02 -04:00
Jonathan Kingston 3d183512ad Bug 1400812 - Removal of containers drawer icon. r=baku,dao
MozReview-Commit-ID: JK2tB0ITRqY

--HG--
extra : rebase_source : 26f534fe05e898d8b33cff1b629a84a5c6ae4dff
2017-09-21 16:26:26 +01:00
Mike de Boer f7dd6d2d6d Bug 1401383 - remove anchor state after transition even if the transition is canceled, and always set main view as current, r=Gijs
We weren't removing the 'open' attribute from the anchor if the transition didn't complete.
This patch fixes this by moving the addition of 'open' into _transitionViews, and its removal into
_cleanupTransitionPhase.

MozReview-Commit-ID: TS0CcwsHVN

--HG--
extra : rebase_source : 1bdace324f22ee95002024fe68b572a16dd25aac
2017-09-21 22:18:07 +02:00
Mike de Boer 352843986a Bug 1402023 - Limit the 'Recent Activity' list in the Library to a maximum of 6 items. r=Gijs
MozReview-Commit-ID: AVHRKvAJjWe

--HG--
extra : rebase_source : 388488c561e6b8f180c918a25e43b7501a37e408
2017-09-21 18:25:41 +02:00
Doug Thayer cb1a8fb21a Bug 1399177 - Pull label out of description in update popups r=Gijs
The margin rules for labels mean that if the See what's new link
starts its own line, the alignment looks off. We could override this,
but matching the styling for "Learn more" links, which get their own
line, seemed the better option.

MozReview-Commit-ID: 4WK9QtRMUQs

--HG--
extra : rebase_source : d24d83094d5b4ca400fe77358a3c1c2635e033d0
2017-09-20 15:58:25 -07:00
Gijs Kruitbosch fda48d1b3f Bug 1401754 - print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p, r=dao
MozReview-Commit-ID: K4yQB6ejGRv

--HG--
extra : rebase_source : cdd730f7777ed609386469762f7620d6d4805d7e
2017-09-20 22:54:38 +01:00
Sebastian Hengst 7824630fde Backed out changeset 658b68ee4d0a (bug 1401383) for frequently failing browser-chrome's browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize.js, especially on Linux x64 asan. r=backout 2017-09-20 17:28:51 +02:00
Mike de Boer ecca1af556 Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs
MozReview-Commit-ID: IffDnXEqooR

--HG--
extra : rebase_source : 04344421e5152c1f7ba8959698ba7cff57448e15
2017-09-20 14:37:53 +02:00
Mike de Boer c0b0c75c02 Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
MozReview-Commit-ID: 44Q9NbKEJeC

--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
2017-09-20 14:25:58 +02:00
Gijs Kruitbosch b078909af6 Bug 1401383 - remove anchor state after transition even if the transition is canceled, and always set main view as current, r=mikedeboer
Prior to this change, showMainView set the 'current' attribute on a main view, but then _cleanupTransitionPhase() would remove it again.
This patch fixes that by calling showMainView *after* _cleanupTransitionPhase.

Separately, we weren't removing the 'open' attribute from the anchor if the transition didn't complete.
This patch fixes this by moving the addition of 'open' into _transitionViews, and its removal into
_cleanupTransitionPhase.

MozReview-Commit-ID: 24FYaxDVlga

--HG--
extra : rebase_source : 41bb5ffe29ca8e0ec9acc1793ae87d63d28e1f43
2017-09-19 23:53:59 +01:00
Andrew Halberstadt 7527e600f0 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : b78cbf7913fc1b0a27dfa085c38957e2bc2467d0
2017-08-22 16:56:02 -04:00
Mike de Boer f716107bf8 Bug 1354536 - Part 3 - When the Library view is shown, populate a new 'Recent Highlights' section with at most 12 items as in about:newtab. r=Gijs
MozReview-Commit-ID: Bs1RzL0uewH

--HG--
extra : rebase_source : 5efd60f237f9123ecf57e2da820851b703c2045e
2017-09-19 16:17:16 +02:00
Gijs Kruitbosch bad4eae2ab Bug 1399517 - remove CustomizableUI placements for old buttons to avoid saved state corruption, r=mikedeboer
MozReview-Commit-ID: 3XKPuz9KwlD

--HG--
extra : rebase_source : d3f6bc2bbb815158c78909ed83a6f7f15c7b43c0
2017-09-18 17:34:50 +01:00
Gijs Kruitbosch b7ec7b74c5 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ

--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
2017-09-18 16:36:46 +01:00
Drew Willcoxon de32f1dce3 Bug 1400024 - Clicks on Zoom label in Photon app menu shouldn't close the menu. r=Gijs
MozReview-Commit-ID: 6zHRb27RBGw

--HG--
extra : rebase_source : 8713582d948b81a5558c539ad1d910d1139fea2d
2017-09-18 13:13:13 -07:00
Gijs Kruitbosch 088853fcdf Bug 1399935 - use horizontal panel for downloads checkbox panel at all times, r=mak
Rather than using left-hand-side at all times (which can go over the edge of the window
in some cases) this uses left or right-hand-side panels, always opening towards the
center of the window.

MozReview-Commit-ID: EvjDmKR1G5A

--HG--
extra : rebase_source : 12046edc24b564e035dff68a5e34bce3ff5fd507
2017-09-17 23:31:06 +01:00
Gijs Kruitbosch 27050c2c34 Bug 1399486 - show downloads auto hide panel after changing the pref instead of before, r=mak
Note that we will no longer show the panel if you use the context menu to move the item in one
window and have customize mode open in the other. I don't think that edgecase matters.

MozReview-Commit-ID: 3dzGr3cs2oQ

--HG--
extra : rebase_source : cc5f528557e35e48b0bc06e58b92fdcb7ecfa6fe
2017-09-17 18:09:35 +01:00
Maya Messinger 1710134422 Bug 1387846 change print button command to print instead of print preview on all platforms r=Gijs
MozReview-Commit-ID: IIxhCx4N362

--HG--
extra : rebase_source : b920e3c9333df0b2ee9cda92880b5effb4922e45
2017-09-17 17:23:00 -04:00
Mark Banner e1b4d55203 Bug 1399968 - Ensure the inNavBar search pref really does get set correctly on startup. r=Gijs
Delay the initialisation of the pref until the toolbar has been initialised.

MozReview-Commit-ID: JxQajZ4wrCR

--HG--
extra : rebase_source : 42f936c5a3e6b7f8cdce1703d7d74883fc806d1c
2017-09-14 20:59:32 +01:00
Maya Messinger 11ffb95321 Bug 1398305 - reorder library dropdown items to spec r=Gijs
MozReview-Commit-ID: 912yc4MB5Ap

--HG--
extra : rebase_source : 8393ffa21314fc67784119b319abd0a73b6b3bcd
2017-09-14 11:37:22 -04:00
Gijs Kruitbosch 069f2c2997 Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy
MozReview-Commit-ID: HBfdW5vEZaD

--HG--
extra : rebase_source : 5058884698a2a2144b921a36abbe7c8c3a1fda52
2017-08-23 14:06:26 +01:00
Mike de Boer 4c850e0f21 Bug 1388180 - Update the overflow panel styling in Customize Mode and show the overflow button as in the opened state, but with a disabled looking icon. r=Gijs
MozReview-Commit-ID: 387PZ2jp1SS

--HG--
extra : rebase_source : 4b6e865d725d9aeb32b0de98b2cfdbb35d8f2349
2017-09-13 19:28:45 +02:00
Doug Thayer c06b48b5e7 Bug 1399172 - Add buttonhighlight to update doorhangers r=johannh
The highlight styling was recently added, causing update notification
buttons to both be styled as grey. This fixes that to style them as
blue again.

MozReview-Commit-ID: HDSA9NWBmIA

--HG--
extra : rebase_source : f9bbe50bb7115b1a2be6aff8fe930bf6c9844dbb
2017-09-12 10:08:01 -07:00
Johann Hofmann 0dbe3971c5 Bug 1349552 - Part 3 - Add a test for drag space in customize mode. r=nhnt11
MozReview-Commit-ID: AiqY1J5WwYo

--HG--
extra : rebase_source : 4fb5cea18653a05f17c80595b48c8f3aae9b0d2a
2017-09-10 20:39:21 +02:00
Johann Hofmann c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
2017-09-10 20:38:19 +02:00
Mike de Boer aa0c3dc278 Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
MozReview-Commit-ID: Dy6UppV3xDH

--HG--
extra : rebase_source : 1c970efaa0b7162450d79f37633afacaadc8d19e
2017-09-12 21:33:25 +02:00
Gijs Kruitbosch c3acd03b82 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv

--HG--
extra : rebase_source : 54333982cce1dcb7cb84331734f170d4d79fbc29
2017-09-11 18:54:48 +01:00
Gijs Kruitbosch 3f3bcb5b73 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1

--HG--
extra : rebase_source : fdb9b8d65745a57e3ac1ffa71cce10654032b177
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Kris Maglione e3f6c844ae Bug 1391707: Follow-up: Skip idle in more places that incorrectly expect strict timing. r=me CLOSED TREE
MozReview-Commit-ID: BbMB5qk4F4e
2017-09-11 21:26:04 -07:00
Zibi Braniecki 70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki 923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Sebastian Hengst 5c5d753509 Backed out changeset 20f6207757f3 (bug 1374749) for failing browser-chrome's browser/base/content/test/urlbar/browser_page_action_menu.js. r=backout 2017-09-08 19:42:22 +02:00
Mike de Boer dcde014112 Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
MozReview-Commit-ID: Dy6UppV3xDH

--HG--
extra : rebase_source : b473714a3de9ff34da8c936770d335b7e2ee01bd
2017-09-08 18:02:10 +02:00
Mike de Boer 02e344af23 Bug 1390336 - Disable panelview keyboard navigation using arrow keys in the overflow panel, because input boxes can be in there. r=Gijs
MozReview-Commit-ID: DxZv8JDp2Q2

--HG--
extra : rebase_source : b3bf90e60540a1b115a3bf2321fd4396863b5cce
2017-09-08 11:53:11 +02:00
Sebastian Hengst 6b5abf8cab merge mozilla-central to autoland. r=merge 2017-09-07 12:40:32 +02:00
Sebastian Hengst 8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
2017-09-06 13:09:27 +01:00
Zibi Braniecki 0e1ced7d71 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8

--HG--
extra : rebase_source : 2a1b660f6489c5aece8f8b25935ad5799779629d
2017-09-01 01:54:34 -07:00
Gijs Kruitbosch 81a14da14a Bug 1396966 - fix dnd in a test to work in small screens, r=mystor
MozReview-Commit-ID: 7xqfLc1M0PA

--HG--
extra : rebase_source : 12031eea1a7106a00a0d921825c71731fdf33ea4
2017-09-06 19:39:53 +01:00
Gijs Kruitbosch 8ec70a2c1b Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5

--HG--
extra : rebase_source : df62441169e07fb94e39f68a2b3e43f6ed7f464c
2017-09-06 10:02:44 +01:00
Mike de Boer df2fab0b05 Bug 1354532 - Part 3 - Ensure that the offscreen bounds check for panelviews does not cause temporary empty panels. r=Paolo
MozReview-Commit-ID: 8EACBXDekIW

--HG--
extra : rebase_source : d53f3461db931733a7d1e7722d0fa23ad659fa06
2017-09-06 17:21:24 +02:00
Mike de Boer 0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Sebastian Hengst 8aa94790d7 Backed out changeset 545712909b9b (bug 1354532) 2017-09-06 16:47:06 +02:00
Mike de Boer 781c585ac9 Bug 1354532 - Part 3 - Ensure that the offscreen bounds check for panelviews does not cause temporary empty panels. r=Paolo
MozReview-Commit-ID: 8EACBXDekIW

--HG--
extra : rebase_source : 6c067ddfbac4462f26600083c1b0ee2adea33d36
2017-09-06 16:23:08 +02:00
Mike de Boer bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Mark Hammond dd24896f66 Bug 1396085 - ensure the sync widget is always initialized and animate the sync spinner. r=Gijs
MozReview-Commit-ID: HcAuLZQ95EH

--HG--
extra : rebase_source : 662020814200e4b389d7a07d508a76de0dcd989e
2017-09-05 15:08:17 +10:00
Gijs Kruitbosch fd7064ce6b Bug 1374315 - fix CSS overflow:hidden in overflow panel and page action panel to fix rounded corners, r=mikedeboer
MozReview-Commit-ID: B5lHCaAMvyu

--HG--
extra : rebase_source : 4b0995e4ef6558ad418c8782f4bdfdf5cba1f91d
2017-08-15 13:03:33 +01:00
Steve Armand e46ff00709 Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
MozReview-Commit-ID: 5do3eoCEAMR

--HG--
extra : rebase_source : 5f692e474e1d7d173fcb4c9c08617f0fe489e443
2017-09-04 00:49:32 -04:00
Gijs Kruitbosch 50b63100b8 Bug 1393343 - move 'restore previous session' item into main menu and hide when auto-restore is enabled, r=mikedeboer
MozReview-Commit-ID: B3J9c936RL

--HG--
extra : rebase_source : 8c30211e59c40774c72f039eda515724cb193c0d
2017-08-25 11:40:49 +01:00
Edouard Oger d0c4b71df2 Bug 1380377 part 2 - Make sure sync-illustration.svg doesn't get loaded on startup. r=markh
MozReview-Commit-ID: KWWCniJPU44

--HG--
extra : rebase_source : ff733d8d04150d464d68ef0d03420fef8908f28b
2017-08-16 14:12:42 -04:00
Robert Strong 07b5b84c71 bug 1390032 - make it clear in the update doorhanger text that private browser windows and tabs are not restored. r=dothayer 2017-09-06 10:36:22 -07:00
Sebastian Hengst 43bc951ac7 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: ES9rKhiQo10
2017-09-01 10:38:51 +02:00
Florian Quèze 48761699cf Bug 1391704 - Avoid flickering while moving tabs across windows, r=mconley. 2017-09-01 00:42:31 +02:00
Gijs Kruitbosch e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch 58d91186ae Bug 1393133 - wait for the overflow button to be visible before activating it in tests, r=jaws
MozReview-Commit-ID: 58GGrPVufZ3

--HG--
extra : rebase_source : 325709623de03b4fd7e1414fff5bb42474194551
2017-08-24 17:25:24 +01:00
Gijs Kruitbosch c6da57415c Bug 1389625 - clean up subview headers now that we use the title of the view instead, r=adw
The panel-subview-header is always hidden in photon (sub)panels, and so we now never show it.
Removing it avoids having to readd the old label for the bookmarks view, remove some unused
strings, and I noticed that we accidentally left the PanelUI-sidebar container which is
unused since bug 1360282.

MozReview-Commit-ID: 4ProWA1sUUs

--HG--
extra : rebase_source : e887b156f450a62cf04228db13b8584810fdf5a0
2017-08-24 14:03:15 +01:00
Gijs Kruitbosch 3699f166ad Bug 1389625 - change bookmarks menu button label, r=adw
MozReview-Commit-ID: CNNbbfJTnlG

--HG--
extra : rebase_source : ade3148178c99955ba007ff341b4d0e997191aa2
2017-08-24 13:54:55 +01:00
Wes Kocher 4ea67d0e07 Backed out changeset e774700fe070 (bug 1392787) for build bustage a=backout CLOSED TREE
MozReview-Commit-ID: FRRUDa6rIuS
2017-08-24 13:58:52 -07:00
Andrew Halberstadt cae249f833 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : d907a5b2192687d86e3291a936c943948ed6793f
2017-08-22 16:56:02 -04:00
Gijs Kruitbosch db2aefdf08 Bug 1385042 - hide spacers and separators added by CUI in popup windows, r=nhnt11
MozReview-Commit-ID: BB1j6j1QdxU

--HG--
extra : rebase_source : b495bc2661b2b23eaa82b7d7d8cf7a7b46175f23
2017-08-23 13:12:21 +01:00
Gijs Kruitbosch 9303f5c082 Bug 1383913 - fix popuphiding listener for overflow panel to only 'count' the panel itself hiding, r=mixedpuppy
MozReview-Commit-ID: K2nvSimItyx

--HG--
extra : rebase_source : ac880fa1a927c1cfe974661e8d306a1c9d7cbebc
2017-08-23 14:42:57 +01:00
Blake Winton ad9fe7889e Bug 1392332 - Set the viewtype attribute correctly when going back to the main view. r=Gijs.
MozReview-Commit-ID: KMK4fQn5DwZ

--HG--
extra : rebase_source : bc06a9659112b6a74099c85e88c1cc636a625884
2017-08-21 13:09:37 -04:00
Jared Wein 6c68f6b603 Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs
MozReview-Commit-ID: 1EQxMcLJn9J

--HG--
extra : rebase_source : 884ddb84896bec96b4cc05d2d067e8e3a69603c7
2017-08-21 14:20:40 -04:00
Edouard Oger 5aca028c2c Bug 1392280 - Backout bug 1380377. r=mconley
MozReview-Commit-ID: AOD2ol0yzaC

--HG--
extra : rebase_source : f55cf56275ceb4dc5872e05dd2819dc46ed7f8bb
2017-08-22 11:07:47 -04:00
Gijs Kruitbosch ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Ricky Chien daac97d466 Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 9adc8231c896f93f7f262a09482b44a2875bd5fd
2017-08-21 17:48:18 +08:00
Sebastian Hengst 51133fbff6 Backed out changeset df8215261c7e (bug 1349689) on request from rchien. r=backout
--HG--
rename : browser/components/preferences/in-content/findInPage.js => browser/components/preferences/in-content-new/findInPage.js
rename : browser/components/preferences/in-content/searchResults.xul => browser/components/preferences/in-content-new/searchResults.xul
rename : browser/components/preferences/in-content/tests/browser_checkspelling.js => browser/components/preferences/in-content-new/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content/tests/browser_engines.js => browser/components/preferences/in-content-new/tests/browser_engines.js
rename : browser/components/preferences/in-content/tests/browser_layersacceleration.js => browser/components/preferences/in-content-new/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content/tests/browser_masterpassword.js => browser/components/preferences/in-content-new/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content/tests/browser_permissions_dialog.js => browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content/tests/browser_security-1.js => browser/components/preferences/in-content-new/tests/browser_security-1.js
rename : browser/components/preferences/in-content/tests/browser_security-2.js => browser/components/preferences/in-content-new/tests/browser_security-2.js
2017-08-31 16:58:32 +02:00
Ricky Chien 3ff2ff68ed Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 6f59261adcb6cd3098b3596c01c9165ad6bfc03c
2017-08-21 17:48:18 +08:00
Wes Kocher c043502159 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 7sFZmPUXSx6
2017-08-18 17:21:29 -07:00
Gijs Kruitbosch bdf83368d1 Bug 1391616 - make migration of existing hamburger panel contents actually work, r=jaws
MozReview-Commit-ID: 4YC4BWI10YW

--HG--
extra : rebase_source : e440a1008986a81674a72b033ddbd15a35453d26
2017-08-18 13:59:32 +01:00
Gijs Kruitbosch fea0af94d3 Bug 1382145 - update customize mode header to be clearer, r=abenson
MozReview-Commit-ID: ag8hELX4Zo

--HG--
extra : rebase_source : d315bc47fd10a6f99025c5853549f4a7c36d90de
2017-08-18 12:41:58 +01:00
Sebastian Hengst 38936d8d58 merge mozilla-central to autoland. r=merge a=backout on a CLOSED TREE 2017-08-17 19:32:20 +02:00
Sebastian Hengst e8c36327cd Backed out changeset 1e7bcce37cfc (bug 1374315) for frequently failing browser-chrome's browser_ext_browserAction_popup_resize.js. r=backout a=backout on a CLOSED TREE
MozReview-Commit-ID: 4jM1IqGW8u5
2017-08-17 19:31:10 +02:00
Gijs Kruitbosch b308974089 Bug 1366207 - remember previous view's selection when keyboard navigating panels, r=mikedeboer
MozReview-Commit-ID: 14U7hkrBbJq

--HG--
extra : rebase_source : c6a0439d253d38a776445793b235b93ba5873f48
2017-08-15 15:21:15 +01:00
Wes Kocher 366445521c Merge m-c to autoland, a=merge
MozReview-Commit-ID: DjSlrmDFfe3
2017-08-16 17:14:41 -07:00
Wes Kocher 9e13a44b54 Merge inbound to central, a=merge
MozReview-Commit-ID: GEfEDRZk5bo
2017-08-16 16:59:26 -07:00
Edouard Oger c2a083e14a Bug 1380377 - Make sure sync-illustration.svg doesn't get loaded on startup. r=markh
MozReview-Commit-ID: KWWCniJPU44

--HG--
extra : rebase_source : c33dcd253c1c00c85f42063fc84d1b6ef2b871ee
2017-08-16 14:12:42 -04:00
Mike de Boer 2859ef0a38 Backed out changeset a528b4400362 (bug 1382243) for causing bug 1390753.
MozReview-Commit-ID: 57KH3vQGeSe
2017-08-16 13:49:59 +02:00
Gijs Kruitbosch d0f97efd43 Bug 1390260 - remove old customize test, add test that checks it works in main window, r=mkaply
MozReview-Commit-ID: 9Tm8kLjxukB

--HG--
extra : rebase_source : a8d599d6e67151abdc2b65297b5cb5fcbc2dbea7
2017-08-15 17:42:16 +01:00
Gijs Kruitbosch 163ee80617 Bug 1390260 - make customize mode work in popup windows, r=mkaply
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
2017-08-15 12:02:11 +01:00
Gijs Kruitbosch 8aa9c66d0c Bug 1374315 - fix CSS overflow:hidden in overflow panel and page action panel to fix rounded corners, r=mikedeboer
MozReview-Commit-ID: B5lHCaAMvyu

--HG--
extra : rebase_source : 0eb5ac61a7eb2082d501a95919d06c49bcbb1c08
2017-08-15 13:03:33 +01:00
Sebastian Hengst ad97051e47 Backed out changeset fb0d8aeff611 (bug 1390260) for failing mochitest browser_bug422590.js. r=backout 2017-08-15 17:13:15 +02:00
Drew Willcoxon 3c27aee62b Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV

--HG--
extra : rebase_source : f87650ab8c09f7a313cda9b7ec73ee1e20d6fe34
2017-08-16 10:13:15 -07:00
Gijs Kruitbosch 426e66c658 Bug 1390260 - make customize mode work in popup windows, r=mkaply
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
2017-08-15 12:02:11 +01:00
Mike de Boer 25583e0eda Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs
MozReview-Commit-ID: GqbUMbuvYoO

--HG--
extra : rebase_source : 09f489b9b558a9b8dfc0aecbf1ab863d816ee43b
2017-08-15 13:34:41 +02:00
Gijs Kruitbosch a06ede1bf2 Bug 1382243 - Refactor panelmultiview code to reduce complexity and length of functions, r=mikedeboer
While this creates several methods with just 1 callsite, given the previous length of the
showSubView method (230 lines), it seems wise to split this up and to try to reduce the
nesting, as well as making it easier to reason about what happens if we hide the panel
mid-transition.

MozReview-Commit-ID: 9Vf4p4fVBSs

--HG--
extra : rebase_source : f21ca55eaeb4bda49ba51f2694ecb5620f47e941
2017-08-04 11:33:55 +02:00
Stone Shih 1b13c3deba Bug 1351148 Part8: Revise browser_1008559_anchor_undo_restore.js to continue the test after processing the mouse event. r=smaug.
MozReview-Commit-ID: BYF94RsKhR6
2017-07-16 12:38:13 +08:00
Sebastian Hengst 56c035fa36 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 4cZJ3qFjvPY
2017-08-12 23:49:21 +02:00
Gijs Kruitbosch 7c9b10befb Bug 1389285 - check that clicking history items actually works, r=mikedeboer
MozReview-Commit-ID: 2WKqYaO8Iht

--HG--
extra : source : bff4d1e4243f2c1472d9339aa7060be4c819b637
2017-08-11 14:05:48 +01:00
Gijs Kruitbosch 0cdb4b5cfa Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : transplant_source : %BD%9E%A3%87%9C%DEl%97%93%AFyc%2A%AA%BF%08%DE%B2b%86
2017-08-10 23:04:54 +01:00
Gijs Kruitbosch 6ff153a8b2 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao
MozReview-Commit-ID: EsH3lv8QXfJ

--HG--
extra : rebase_source : 20325d2b014abf9687c83eae3cda267eeda078eb
2017-08-12 11:56:22 +01:00
Andrew Halberstadt d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda 0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher cff9e9b197 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher 936a9461f6 Merge inbound to m-c a=merge
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Sebastian Hengst 6081d7a11e Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout a=merge
MozReview-Commit-ID: AHOsaTvCWms

--HG--
extra : source : 5475c7748903350a91842046eeb614880738b83e
2017-08-10 20:02:44 +02:00
Gijs Kruitbosch 12b877d713 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : 1bf36537326b86fff6e3db814908cb64aaad3e57
2017-08-09 18:02:36 +01:00
Gijs Kruitbosch 35bd3646b1 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : 9d07a961de011395366f2736eab62e5bbcbcd19d
2017-08-10 23:04:54 +01:00
Mike Taylor 71e035473c Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=Gijs
MozReview-Commit-ID: BCXVJChZ0mt

--HG--
extra : rebase_source : 6c7dec5932e804f620f8af53d91f5d3e0961ef05
2017-08-04 15:35:18 -05:00
Gijs Kruitbosch ad0e178cad Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : e3ef4468299adfd0b874ba2f44a034c2655ecd6f
2017-08-10 23:04:54 +01:00
Dão Gottwald 2c29c9f69a Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
MozReview-Commit-ID: 2deeujcHYUM

--HG--
extra : rebase_source : 90e8c1f1c90655d3e38560b588af82da64fdc2a5
2017-08-10 09:17:48 +02:00
Kris Maglione 0ecfcbc93e Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj

--HG--
extra : rebase_source : 15761873b91efaf1d338b6361bf7168ab4348e0d
2017-08-09 13:03:36 -07:00
Andrew Halberstadt f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
2017-08-10 14:48:21 -04:00
Sebastian Hengst e5aac1d087 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout 2017-08-10 20:02:44 +02:00
Gijs Kruitbosch b584e361b6 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer
MozReview-Commit-ID: 6bOoRIfttEy

--HG--
extra : rebase_source : d7748809abe4ee617d0cb1a9d66a3e88728ecc63
2017-08-09 14:04:21 +01:00
Gijs Kruitbosch ce10833235 Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD

--HG--
extra : rebase_source : 819e27885148deb588c057c4e811371a87f1d2fc
2017-08-07 19:10:40 +01:00
Michael Kohler 674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Carsten "Tomcat" Book 0f16d437cc merge mozilla-inbound to mozilla-central a=merge 2017-08-08 13:18:14 +02:00
Kris Maglione 3c361e6c6d Bug 1387902: Don't attempt to localize browserAction widget properties. r=Gijs
We spend a lot of time at startup generating exception objects while trying to
retrieve nonexistent localized properties from string bundles. Since extension
widget values will never be localized this way, we should skip the string
bundle lookup entirely.

MozReview-Commit-ID: L9r59bf2Dgf

--HG--
extra : rebase_source : 04eb6f9a78215d0268d2eaee7f94fd5b4cff498b
2017-08-06 16:34:31 -07:00
Sebastian Hengst ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler 45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Dão Gottwald ee6b05b899 Bug 1387602 - Update customize mode favicon. r=Gijs
MozReview-Commit-ID: 7gin0zuJTN0

--HG--
extra : rebase_source : 7b1d2394e32f4ed5763bc9562a6e7e87bdbf2c74
2017-08-04 23:00:00 +02:00
Sam Foster bae82564b3 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y

--HG--
extra : rebase_source : 77895818356b1b366e93c6a8c508ae2b74dbca5c
2017-07-27 11:07:23 -07:00
Gijs Kruitbosch 1409e6926f Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw
MozReview-Commit-ID: FqUFNrSufvQ

--HG--
extra : rebase_source : 91e20d260e2fc227b153366aab09e37fbe99ef57
2017-08-01 19:55:41 +01:00
Gijs Kruitbosch 2b8e704244 Bug 1354117 - remove old panel code from panelUI and CSS, r=jaws
MozReview-Commit-ID: G6a9ybDxqki

--HG--
extra : rebase_source : 6b2ec759d40d120842de9be9945fb27cda494745
2017-08-01 19:59:38 +01:00
Gijs Kruitbosch f1b0d2d8c3 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws
MozReview-Commit-ID: IwKUWMTagCK

--HG--
extra : rebase_source : e6c54f3b5d6115574f22f31380a4a07601776d1c
2017-08-02 11:51:58 +01:00
Gijs Kruitbosch 45b4d7f5f4 Bug 1354117 - remove old panel code from CustomizableUI, add migration, r=jaws
MozReview-Commit-ID: 8kTETHR1P7X

--HG--
extra : rebase_source : 8eadae4ff04c153be7670154afe5f5005306136a
2017-08-01 12:56:48 +01:00
Gijs Kruitbosch 03a486b23d Bug 1354117 - fix telemetry and a number of tests that flip photon prefs, r=johannh
MozReview-Commit-ID: 7ynaIQm22eS

--HG--
extra : rebase_source : 703ceae16cbf521de2fa1689668c68f1f06f682a
2017-08-01 20:15:48 +01:00
Gijs Kruitbosch c4fb9878e0 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB

--HG--
extra : rebase_source : 4df42939aa06ec10b7f86c3c2e4fe75160c7e7bd
2017-08-01 12:45:55 +01:00
Gijs Kruitbosch beb6be4934 Bug 1354117 - Update various other customizableui tests for photon, r=adw
There are no more help/quit buttons in the panel that shows up in customize mode,
and there are no more hyphenation quirks in items in the panel, so those tests
have been removed. The remaining tests are updated to test the correct panels.

MozReview-Commit-ID: LiUWejjZC7c

--HG--
rename : browser/components/customizableui/test/browser_photon_customization_context_menus.js => browser/components/customizableui/test/browser_customization_context_menus.js
extra : rebase_source : 49cef6ebeee140aefdb7a90d64b48c0da8179dc1
2017-08-01 15:46:58 +01:00
Gijs Kruitbosch 277d122161 Bug 1354117 - fix or remove tests that drag items to the panel, r=adw
The new panel doesn't have placeholders, or a distinction between wide and
narrow widgets, so those tests can just be removed.

MozReview-Commit-ID: D61AjwMbabG

--HG--
extra : rebase_source : 662a74e50ea05c5a4c5fdee476cae10fc9862775
2017-07-31 18:26:38 +01:00
Gijs Kruitbosch 8216336ee8 Bug 1354117 - update panel button tests for photon, r=adw
MozReview-Commit-ID: 94mIvlOenCg

--HG--
extra : rebase_source : 165971d09f4bf5129aafcf2d6c1e11c1315cd6a1
2017-08-01 11:33:26 +01:00
Gijs Kruitbosch 1ad503ecf6 Bug 1354117 - update customize mode button state test, r=johannh
Again, this test is mostly useless now, so I would also be fine with just removing it.

MozReview-Commit-ID: BwOGQ5pwSQd

--HG--
extra : rebase_source : 1e5b961e4f0f9f17d0aee3e6cd3aeb1d6bc75741
2017-07-31 21:10:14 +01:00
Gijs Kruitbosch cf5f0b7624 Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh
MozReview-Commit-ID: CeSGIQrDPpw

--HG--
extra : rebase_source : 11a15f98fe7b4fc8fa26152ad5e5e43551cc8a3b
2017-07-31 21:52:06 +01:00
Gijs Kruitbosch e01119f316 Bug 1354117 - remove panel-specific styling and associated code, include closemenu in styling in overflow panel, r=johannh
MozReview-Commit-ID: 4EgZP0Huo80

--HG--
extra : rebase_source : 50373c85510d4cc3eb22ede813552bd70f5ee156
2017-07-27 16:27:05 +01:00
Jared Wein 76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Gijs Kruitbosch 31718d41ae Bug 1387182 - fix border (empty space) compensation when dragging items in customize mode in RTL, r=jaws
MozReview-Commit-ID: AblsJGmu5zm

--HG--
extra : rebase_source : 96b595132989f4cb43986430094864289debeac1
2017-08-07 12:14:19 +01:00
Gijs Kruitbosch 768b0621d1 Bug 1385083 - history panel should actually list history, r=mikedeboer
MozReview-Commit-ID: G98QMcmASv0

--HG--
extra : rebase_source : 4a8e533d21d0a4a1d464f1e5f546c82c81fce37f
2017-08-07 15:24:49 +01:00
Julian Descottes a3fb1d41fb Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;r=Gijs
MozReview-Commit-ID: 9piucVkS0Y9

--HG--
extra : rebase_source : bea3a2a6c02fa7689b0b2437567dfb91d03701a0
2017-08-03 14:04:54 +02:00
UK992 04a7b8f7ca Bug 1363485 - Update tests r=dao
MozReview-Commit-ID: 4epuVQVCJPH

--HG--
extra : rebase_source : aef306464344009feb0e28295a0159cc9aab19ad
2017-07-30 20:39:55 +02:00
UK992 3f1f818fff Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA

--HG--
extra : rebase_source : 88433e9470e2ccaec6ac8c58c6c96c75bef8acaa
2017-06-29 19:09:43 +02:00
UK992 b52599b66d Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW

--HG--
extra : rebase_source : 4c156a92a59ddb073d9ef743a986e7da2b8a034b
2017-06-29 01:09:05 +02:00
Erica Wright e2a35da326 Bug 1378016 - Fix keyboard navigation and selection on 'recent bookmarks'. r=Gijs
MozReview-Commit-ID: GJ7vRPz8zuo

--HG--
extra : rebase_source : b8a212cd174f81994e3cdb5adc4226b5dfc531d3
2017-07-31 09:47:19 -04:00
Sebastian Hengst e087fbd0e2 Backed out changeset 1e6aea26ec16 (bug 1363485) for failing browser_urlbar_search_reflows.js on OSX debug with e10s and Windows. r=backout 2017-08-02 16:26:03 +02:00
Sebastian Hengst a01cc8cc44 Backed out changeset 69063acda8eb (bug 1363485) 2017-08-02 16:25:05 +02:00
Sebastian Hengst 4f5ee61f5b Backed out changeset f3e224764ca8 (bug 1363485) 2017-08-02 16:24:54 +02:00
Rajesh Kathiriya 48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
UK992 4d606a1288 Bug 1363485 - Update tests r=dao
MozReview-Commit-ID: 4epuVQVCJPH

--HG--
extra : rebase_source : aef306464344009feb0e28295a0159cc9aab19ad
2017-07-30 20:39:55 +02:00
UK992 95d1e58557 Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA

--HG--
extra : rebase_source : 88433e9470e2ccaec6ac8c58c6c96c75bef8acaa
2017-06-29 19:09:43 +02:00
UK992 bbf2a7da44 Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW

--HG--
extra : rebase_source : 4c156a92a59ddb073d9ef743a986e7da2b8a034b
2017-06-29 01:09:05 +02:00
Jared Wein 18b59c778a Bug 1383689 - Remove uninterruptible reflow at setToolbarButtonHeightProperty@resource://gre/modules/BrowserUtils.jsm. r=Gijs
MozReview-Commit-ID: 9WoXQ1nMWTZ

--HG--
extra : rebase_source : cdee661cd33d0aa06aceda7fa3a37b0c78ee3123
2017-08-01 15:33:01 -04:00
Shane Caraveo 1fe5a3a13e Bug 1388902 remove socialapi share, r=florian
MozReview-Commit-ID: Kcjugf3Ql6y

--HG--
extra : rebase_source : 8f82fa6beabfa89916bbc97ec799c6e5d6b3ff18
2017-08-16 08:54:21 -07:00
Sebastian Hengst 804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya 22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Drew Willcoxon bafcf94652 Bug 1374477 - Add a new test for Photon page actions, along with some related code changes. r=Gijs
MozReview-Commit-ID: ADaEnEiGFvX

--HG--
extra : rebase_source : 0c7e8b3d5244eb9c3def5dac0c9a2bf3b830f4f7
2017-07-29 20:25:14 -07:00
Gijs Kruitbosch 45b153fcd7 Bug 1380274 - add an anchor to the definition of the overflow panel area, r=jaws
MozReview-Commit-ID: EezQr2JP1JH

--HG--
extra : rebase_source : 4f874a51694451fc09242a7d759cae78b92acc4f
2017-07-27 14:16:08 +01:00
Gijs Kruitbosch 4d02b42e8a Bug 1378807 - make search bar shortcut work in the permanent overflow panel, r=bwinton
MozReview-Commit-ID: HLdegoy2525

--HG--
extra : rebase_source : 8442a0b0e1f5cdb76870f7e70252506d96a900cc
2017-07-27 15:00:38 +01:00
Carsten "Tomcat" Book 61867d079e Backed out changeset 0ee0458b1452 (bug 1351148) 2017-07-28 09:20:08 +02:00
Gijs Kruitbosch b05b8580d3 Bug 1383458 - disable pin to overflow / move to panel for flexible spacers (and other special items), r=jaws
MozReview-Commit-ID: 4eeKLsjPi6I

--HG--
extra : rebase_source : d3ba424dc044c6278d5b8aad809d1ca2becfbfbe
2017-07-26 17:28:47 +01:00
Blake Winton f5c1d1fe64 Bug 1354097 - Style and add a customize button to the overflow panel. r=Gijs, ui-r=shorlander.
MozReview-Commit-ID: 7bNQcVgb7wf

--HG--
extra : rebase_source : 55a6ca4f6d741dc0d398ef4a9a83ef63c1fe5345
2017-07-17 10:18:40 -04:00
Mike de Boer 9c16099969 Bug 1354533 - Update the History panelview when it's shown inside the new Library panel. r=mak
This patch changes the history-panelmenu widget with the following:
 - Move the Recently Closed Tabs and Recently Closed Windows lists into their own
   respective (nested) subview,
 - Add a Recent History header to list of history items,
 - Extend the list of Recent History items to be max 42 items long,
 - Share more code with Bookmarks panel,
 - Generalizes panelview event dispatching to always support customizable widgets.

MozReview-Commit-ID: 4sBR6llIvxG

--HG--
extra : rebase_source : 2758dd643cd504448ee1f19296670a588bf56069
2017-07-21 15:07:23 +02:00
Sebastian Hengst 78b9ef353f merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: Lanp1XedkmZ
2017-07-23 11:27:03 +02:00
Florian Quèze 5aa184f945 Bug 1381853 - lazy load panelUI.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Jared Wein 1e2bf53f24 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster
MozReview-Commit-ID: ERE1FnTuIWF

--HG--
extra : rebase_source : 7ab56c4ccaf12a1ce72801197414013bc0e70ead
2017-07-20 12:31:06 -04:00
Wes Kocher 61354cf6c0 Merge m-c to autoland, a=merge CLOSED TREE
MozReview-Commit-ID: 9pPsy8McMun
2017-07-21 18:18:35 -07:00
Wes Kocher 051dc17e6c Merge inbound to central, a=merge CLOSED TREE
MozReview-Commit-ID: GYc8r8gnS0j
2017-07-21 18:12:55 -07:00
Dão Gottwald 2ee97c338a Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
MozReview-Commit-ID: 72S5zENy1gX

--HG--
extra : rebase_source : bdecd5c216638da9e83787150cffa970ae8da059
2017-07-21 14:11:15 +02:00
Stone Shih 428440a473 Bug 1351148 Part8: Revise browser_1008559_anchor_undo_restore.js to continue the test after processing the mouse event. r=smaug.
MozReview-Commit-ID: BYF94RsKhR6
2017-07-16 12:38:13 +08:00
Johann Hofmann 39ffb53fce Bug 1371219 - Increase margin of main menu items when accessed through touch. r=mikedeboer
MozReview-Commit-ID: 9gjxxc6O5YS

--HG--
extra : rebase_source : 71cec7055786687a23325ec667d59a2e630f5c57
2017-07-20 16:45:02 +02:00
Johann Hofmann 3eac596d72 Bug 1371219 - Add an inputSource attribute to XULCommandEvent. r=smaug
In the frontend we need to know if XUL buttons in the toolbar were
triggered by a touch event, so we're passing on the inputSource
in the command event.

MozReview-Commit-ID: DMvgZULk9hT

--HG--
extra : rebase_source : c455c8ec77e439bf02c1e3e8d34a36e1fb5e3bd0
2017-07-20 17:45:56 +02:00
Wes Kocher 6dbec35ae2 Backed out changeset 320f9642bcef (bug 1381991) because it blocks backing out 1355922 a=backout
MozReview-Commit-ID: 7gM0DJkbVwW
2017-07-21 00:36:04 -07:00
Jared Wein 78ddbc6ee8 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster
MozReview-Commit-ID: ERE1FnTuIWF

--HG--
extra : rebase_source : 7ab56c4ccaf12a1ce72801197414013bc0e70ead
2017-07-20 12:31:06 -04:00
Jared Wein 716e6429c4 Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r=sfoster
MozReview-Commit-ID: 2LQrWDxrTny

--HG--
extra : rebase_source : 6e0ccf341e84970d7897b2d27c23e0ea7a7361bf
2017-07-20 10:53:45 -04:00
Jared Wein 733ab5250f Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed. r=Gijs
MozReview-Commit-ID: DGR3mo01vXP

--HG--
extra : rebase_source : dbf5d63cbb888ffb4441485309ca854f34d0a613
2017-07-20 09:35:50 -04:00
Gijs Kruitbosch 9a1b681338 Bug 1354086 - fix leaks caused by transitionend listeners that hang around, r=mikedeboer
MozReview-Commit-ID: DvvoAURmxH2

--HG--
extra : rebase_source : bda2a635043d0a82a1588b1e20a93ed983f7da27
2017-07-19 15:36:44 +01:00
Gijs Kruitbosch 71b41e6520 Bug 1354086 - update styling of normal toolbar buttons in the overflow panel, r=mikedeboer
MozReview-Commit-ID: 9JFz7zfmduk

--HG--
extra : rebase_source : b826611218b93228da626a2e5dd91934f27a5bc3
2017-07-05 19:31:39 +01:00
Gijs Kruitbosch 5b530597e8 Bug 1354086 - switch overflow panel to using a photonpanelmultiview, allowing webextension views to specify their own size, r=mikedeboer
MozReview-Commit-ID: 1uHEKXsO8vh

--HG--
extra : rebase_source : f33e277e77a09a10cb0ea3db412d293ef61a5f19
2017-07-19 21:23:46 +01:00
Gijs Kruitbosch 0676c41d50 Bug 1336839 - switch to BTU to avoid intermittents, r=sfoster
MozReview-Commit-ID: 4Zg88qY5B5I

--HG--
extra : rebase_source : 767bc22fa1c7b078dfa3c3e7de1f4c770ace0538
2017-07-17 15:15:10 +01:00
Johann Hofmann d5983f0183 Bug 1379123 - Sort UI density options by density. r=dao
MozReview-Commit-ID: JibzseS8LEN

--HG--
extra : rebase_source : d2813c714a04a150fb6c344235908239682fabd4
2017-07-13 14:59:45 +02:00
Gijs Kruitbosch 8e183f6784 Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop
MozReview-Commit-ID: 4k4VdBa4HCt
2017-07-11 13:13:35 -07:00
Wes Kocher e06435f389 Backed out changeset 051284a3564e (bug 1366813) for apparently causing autophone tests to frequently fail a=backout
MozReview-Commit-ID: 9GUFY9VAGW3

--HG--
extra : rebase_source : 84e593e1870b9ad3559487371d0c692d63e3ad6e
2017-07-11 12:39:26 -07:00
Gijs Kruitbosch 8681f1b118 Bug 1366813 - add a flexible space item in customize mode in photon, r=mossop
MozReview-Commit-ID: 4k4VdBa4HCt

--HG--
extra : rebase_source : 320c57ea37c94eecf01db9220f473a256ce5ac87
2017-07-10 23:34:12 +01:00
Gijs Kruitbosch 4a1523e31c Bug 1378427 - move context menus around, fix flickering in dynamic portion of the overflow menu for photon, r=jaws
Apparently the hover state of the combined buttons does not interact well with the menus unless they
share the same containing popup/panel. We broke that condition in bug 1354078. The expedient thing
is to simply move the popup back, and move it back and forth if/when the photon pref is flipped.
When removing the pref, we can simplify this by always putting the menu in the overflow panel.

I also noticed that we use the toolbar context menu in the dynamic portion of the overflow panel.
This has the same problem, and to fix it I switched us to using the same (panel) context menu in
the photon case. Doing this in the non-photon case won't help because the context menu will be in
a separate panel (namely the old hamburger panel) entirely.

MozReview-Commit-ID: 4neHMukTzHA

--HG--
extra : rebase_source : e9f18996383eb7e249dc17b0dc1a84bb6ce3f11d
2017-07-07 15:54:13 +01:00
Paolo Amadini dace1e001b Bug 1377793 - Fix scrolling in the non-Photon main menu on Windows. r=Gijs
This is a follow-up to the previous patch, required because on Windows we cannot measure the full height of the main view until it is visible.

MozReview-Commit-ID: 2pfYwMLPYIb

--HG--
extra : rebase_source : 0391a619f551b5e100688ea231d12ac26e0868c8
2017-07-09 16:05:03 +01:00
Rajesh Kathiriya 881bce09ea Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
MozReview-Commit-ID: RT5QTipaOW

--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
2017-07-04 21:30:18 +05:30
Mike de Boer 56204d90bb Bug 1378794 - Dispatch the 'ViewHide' event on the correct, current panelview when a temporary panel is destroyed. r=Gijs
MozReview-Commit-ID: HXjGJJGChUz

--HG--
extra : rebase_source : 87d899d4aa6871f4a9b8bf031adc8673699dcb81
2017-07-06 18:47:59 +02:00
Wes Kocher bbb26fe90e Merge inbound to central, a=merge
MozReview-Commit-ID: 2nFzji7su8C
2017-07-06 16:10:49 -07:00
Sebastian Hengst 7f761bf821 Backed out changeset f3fc2ea88f60 (bug 1378794) for failing browser/components/extensions/test/browser/browser_ext_popup_corners.js. r=backout 2017-07-06 18:33:55 +02:00
Mike de Boer e8b2ce52aa Bug 1378794 - Dispatch the 'ViewHide' event on the correct, current panelview when a temporary panel is destroyed. r=Gijs
MozReview-Commit-ID: HXjGJJGChUz

--HG--
extra : rebase_source : 6f8cbc26a210cdd8e7d719cdfab9216d05b45cf4
2017-07-06 16:36:24 +02:00
Mike de Boer 7c75a303b6 Bug 1378790 - Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed. r=Gijs
MozReview-Commit-ID: JcAUwLClq7M

--HG--
extra : rebase_source : 004bfd1962f52e910226fb3ff2a4ad83eb93e425
2017-07-06 16:30:07 +02:00
Adolfo Jayme Barrientos ad49ded05b Bug 1376097 - Use ellipsis in hamburger menu’s Print command. r=dao
MozReview-Commit-ID: GCxBLJrmxfm
2017-07-05 22:22:50 -05:00
Paolo Amadini ef0d210719 Bug 1377793 - Fix scrolling in the non-Photon main menu. r=Gijs
MozReview-Commit-ID: 88IsXDvYjyK

--HG--
extra : rebase_source : 4601c2ba6f848ceeeac5db26cfe6621bf7e15a6e
2017-07-05 16:28:58 +01:00
Gijs Kruitbosch dbd7fca428 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : a039936a4c8e416c16171cacf73dab781d77ab50
2017-06-28 17:50:43 +01:00
Carsten "Tomcat" Book 8e3fa527c9 merge mozilla-inbound to mozilla-central a=merge 2017-07-04 10:48:33 +02:00
Wes Kocher 5226f27e3e Merge m-c to inbound, a=merge
MozReview-Commit-ID: 7LPTKLiLUcj
2017-07-03 17:37:38 -07:00
Frederik Braun 56838ddb04 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8.
MozReview-Commit-ID: 7cTNL5jMtRw
2017-07-03 20:07:02 +01:00
Gijs Kruitbosch 9477477b99 Bug 1377139 - blur back button on use like other keyboard nav buttons, r=mikedeboer
MozReview-Commit-ID: 9VFy1Q3kqzk

--HG--
extra : rebase_source : 62ed45b471b1672da666253ef1c7ee538247ecc0
2017-06-30 22:00:54 +01:00
Jared Wein 9b5a5d0a20 Bug 1375152 - Implement animation for pinning items to the overflow menu. r=dao
This animation can be disabled if the toolkit.cosmeticAnimations.enabled pref is set to false.

MozReview-Commit-ID: DtsrI8YflYn

--HG--
extra : rebase_source : 066dc736dc75489bf6ad787811d4ae34f03ed24f
2017-06-28 15:32:34 -07:00
Johann Hofmann d63352edc4 Bug 1350210 - Part 3 - Add uidensity icons and only show uidensity settings in Photon. r=nhnt11
MozReview-Commit-ID: 6uI2oeQk8hw

--HG--
extra : rebase_source : e8aa4141f294433ab6f070f3d0e4fe4c42e073ea
2017-06-29 22:41:03 -07:00
Johann Hofmann 6c2c2a8876 Bug 1350210 - Part 2 - Add a test for UI density settings in customize mode. r=jaws
MozReview-Commit-ID: CxL0CNpg3A9

--HG--
extra : rebase_source : 367bd560b09f8b2fd3edab415af95ebcb3162c26
2017-06-29 10:14:46 -07:00
Johann Hofmann e57999a689 Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws
MozReview-Commit-ID: C0g6aFPW2pX

--HG--
extra : rebase_source : 9802bba188043c04796cf13e0741396ec1447a8d
2017-06-27 18:50:34 +02:00
Gijs Kruitbosch 707bacec3b Bug 1376098 - remove page setup item from hamburger panel, r=dao
MozReview-Commit-ID: 8gzsCCboN7w

--HG--
extra : rebase_source : 173254b8af6b170c3cdc6d3222501bd1dc34b9d6
2017-06-30 18:40:25 +01:00
Mike de Boer 702aa1332c Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak
This patch changes the Recent Bookmarks flow in browser-places.js to use the new
PlacesPanelview to provide a rich view that support drag and drop and context
actions.
A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ',
which is a shortcut for searching bookmarks using the Awesomebar.

MozReview-Commit-ID: 1XlO8HMKEJs

--HG--
extra : rebase_source : 59cdf8a24341eb5df55511c5be83ebee8787aad5
2017-06-29 17:57:25 -07:00
Mike de Boer b4756f63f5 Bug 1354159 - Part 2 - Introduce a new Places view type, PlacesPanelview, which can visualize query results inside panelview nodes. r=Gijs,mak
MozReview-Commit-ID: Ft1RC7dsqKD

--HG--
extra : rebase_source : e9448ee073b5341efc63496ae6504a764ee43f30
2017-06-29 17:57:24 -07:00
Gijs Kruitbosch 4733223aad Bug 1354123 - remove customize mode transition, r=jaws
MozReview-Commit-ID: 7j9HWxci7oB

--HG--
extra : rebase_source : 75cbd832c8e0c8138457c47d1c8fff73c8cb3f56
2017-06-28 13:17:46 +01:00
Gijs Kruitbosch cab2177430 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 8c552cf17c081e5988bea46aa207e8578cd93273
2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book 25f9160fc3 Backed out changeset cbf0368eea83 (bug 1373016) for unused whitelist entry: chrome://browser/skin/customizableui/customize-illustration-rtl@2x.png - 2017-06-29 16:21:39 +02:00
Gijs Kruitbosch dba5fdab48 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : acc57eb6347a5017077358e84c5803719f3331ef
2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book 20d1412289 Backed out changeset 5de26737d215 (bug 1373016) for failure like missing chrome://browser/skin/customizableui/info-icon-customizeTip@2x.png referenced from chrome://browser/skin/browser.css 2017-06-29 13:36:16 +02:00
Gijs Kruitbosch 319029e2fd Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 0041e8c8c58d67d887bd77789936a5d79f750675
2017-06-28 16:55:44 +01:00
Carsten "Tomcat" Book c611ab2870 Backed out changeset bdcdd4d23c77 (bug 1373016) for bustage 2017-06-29 12:34:23 +02:00
Gijs Kruitbosch 5074857da8 Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws
MozReview-Commit-ID: GhQoSgPXL9q

--HG--
extra : rebase_source : 69e18f84fd97a47c17d0a259efc5a59d5f7868f1
2017-06-28 16:55:44 +01:00
Gijs Kruitbosch 5ad2e194d6 Bug 1354145 - Make customize mode deal with drops in the padding around the panel contents, r=mikedeboer
MozReview-Commit-ID: BCi7odA3sth

--HG--
extra : rebase_source : 48bb1784fe745236d3ad55f833e64c19cadf68aa
2017-06-28 23:46:15 +01:00
Gijs Kruitbosch f9f590ca0f Bug 1354145 - set photon-structure attribute on root, update palette/panel icon sizes and layout, r=mikedeboer
MozReview-Commit-ID: 2LhIhI480Yb

--HG--
extra : rebase_source : 33714f81db749ee2e7624b9c3e0a63dded6042ca
2017-06-27 21:47:30 +01:00
Gijs Kruitbosch d75dc0848a Bug 1373968 - size overflow panel appropriately in customize mode and align arrow with overflow button, r=mikedeboer
MozReview-Commit-ID: FV0TKuD0saa

--HG--
extra : rebase_source : 3c03da6e59105b5ace19c9a64bfc178246bd5d92
2017-06-23 14:29:00 +01:00
Brian Grinstead 54aa0a0210 Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs
MozReview-Commit-ID: Kaobl1Ox2QZ

--HG--
extra : rebase_source : c9979bb5da2cdbf61553394c87f57adac64a3257
2017-06-28 10:15:48 -07:00
Gijs Kruitbosch dd070a9e91 Bug 1352120 - move the bookmarks star into the url bar, r=mak
MozReview-Commit-ID: Ka5Wn2hrb1P

--HG--
extra : rebase_source : e22d25295066386c4becc1a430b78aaa9c40ae4f
2017-06-23 17:35:59 +01:00
Gijs Kruitbosch ba15653cdf Bug 1374691 - don't instantiate the panelmultiview and panelview bindings until necessary, r=florian,mconley
MozReview-Commit-ID: L0P1eKxRf3A

--HG--
extra : rebase_source : dc37f06c10b5723bc929179042e7bc4f9d663f21
2017-06-22 09:11:45 +01:00
Carsten "Tomcat" Book 259377b6ab merge mozilla-inbound to mozilla-central a=merge 2017-06-26 13:25:51 +02:00
Gijs Kruitbosch 9979c0a382 Bug 1371236 - don't try to open the overflow panel when in customize mode, r=jaws
MozReview-Commit-ID: H2mOlOkUNLG

--HG--
extra : rebase_source : 584b60ce942bebfa1336ff862d78bef2483ac140
2017-06-22 14:12:24 +01:00
Gijs Kruitbosch 2f0942c636 Bug 1373972 - update overflow chevron state when resetting, r=jaws
MozReview-Commit-ID: IO6fEMHeowT

--HG--
extra : rebase_source : 83eea9bc69872a16e071d26c2479c46811b66b39
2017-06-22 14:13:37 +01:00
Florian Quèze 721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Carsten "Tomcat" Book 2a387535b8 Backed out changeset a6d7647024de (bug 1369729) for reflow issues 2017-06-23 15:48:54 +02:00
Gijs Kruitbosch 70c55f0619 Bug 1369729 - use descriptionheightworkaround for sync panel, r=Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : ebc990e44e7025e90a0a0415df6ce102ba4ba8f0
2017-06-19 16:06:01 +01:00
Sebastian Hengst 7648740589 Backed out changeset c0772946156f (bug 1369729) for failing browser-chrome's browser_appmenu_reflows.js with unexpected uninterruptible reflow. r=backout 2017-06-23 12:53:23 +02:00
Gijs Kruitbosch 28f0bb0532 Bug 1369729 - use descriptionheightworkaround for sync panel, r=Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : bfe13f52ec729a24ac53854b67d4613fd47b52bb
2017-06-19 16:06:01 +01:00
Florian Quèze 7375dcec46 Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop. 2017-06-22 12:51:43 +02:00
Wes Kocher ac0fd2038c Merge inbound to m-c a=merge
MozReview-Commit-ID: 3LXFVwSoMvs
2017-06-21 17:58:17 -07:00
Brian Grinstead 4bc8228f27 Bug 1364238 - Add the sidebar button into the default toolbar set;r=Gijs
MozReview-Commit-ID: 7Z0ukSPu6pL

--HG--
extra : rebase_source : d6a48f28ccf3c89c211529b24e6a88c8018ee3ef
2017-06-20 08:42:28 -07:00
Carsten "Tomcat" Book 1738a7f508 Backed out changeset f10d7fb82ded (bug 1236512) 2017-06-20 14:30:31 +02:00
Paolo Amadini 10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
Edgar Chen d59436c212 Bug 1236512 - Part 5: Wait docshell has been activated again after entering fullscreen mode in panelUINotifications test; r=Gijs 2017-06-16 16:07:01 +08:00
Edgar Chen 39bbd04ec4 Bug 1236512 - Part 5: Wait docshell has been activated again after entering fullscreen mode in panelUINotifications test; r=Gijs 2017-06-16 16:07:01 +08:00
Mike de Boer f7e1f14006 Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
2017-06-16 15:41:57 +02:00
Gijs Kruitbosch 11890dd7b5 Bug 1365663 - update synced tabs panel view iconography and alignment, r=mikedeboer
This also adds the icons in non-photon. They seem to work fine there, so I don't think this is a problem.

MozReview-Commit-ID: GkvT3i2jnD1

--HG--
extra : rebase_source : 80d33d329b5740328aa82dd5401475264700e57a
2017-06-16 13:58:12 +01:00
Sebastian Hengst be35e9d97b Backed out changeset af176d040fad (bug 1370580) for frequently failing browser_ext_sidebarAction.js on Linux debug. r=backout a=backout
MozReview-Commit-ID: AwnMjAQTdmC
2017-06-17 23:18:55 +02:00
Mike de Boer 5df9078641 Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
2017-06-16 15:41:57 +02:00
Sebastian Hengst a4809151b2 Backed out changeset d6be7dc56cc5 (bug 1370580) for failing test-oop-extensions/browser_ext_browserAction_popup_resize.js. r=backout 2017-06-15 19:24:39 +02:00
Mike de Boer 5704197fbf Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : f142e3dbba0d70effe129dad43f139e494070d82
2017-06-15 12:49:18 +02:00
Gijs Kruitbosch 6810627a3a Bug 1371311 - make full screen button hide the panel when clicked, r=mikedeboer
MozReview-Commit-ID: AhlzH9PoPK8

--HG--
extra : rebase_source : 57a959074157ecb71985dd506cc2cf74b21315c3
2017-06-14 13:09:09 +01:00