Mark Banner
26f043124f
Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D184780
2023-07-31 13:05:44 +00:00
Stanca Serban
65e766744a
Backed out 2 changesets (bug 1845252) for causing mochitests failures in browser_fxa_web_channel.js. CLOSED TREE
...
Backed out changeset d58bbd55cb35 (bug 1845252)
Backed out changeset 683a87892126 (bug 1845252)
2023-07-28 21:29:30 +03:00
Mark Banner
b08a8b3acd
Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D184780
2023-07-28 17:30:39 +00:00
Niklas Baumgardner
9ab7b37e1c
Bug 1844171 - Refactor screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-27 16:15:02 +00:00
Sebastian Hengst
92e3e4e7e5
Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE
...
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
2023-07-26 21:24:18 +02:00
Gregory Pappas
3eac12bbd7
Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Niklas Baumgardner
4b0d1b06cc
Bug 1844171 - Refactor screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-26 15:37:45 +00:00
Mathew Hodson
21cd613492
Bug 1564391 - Rename internal uses of `mozInputSource`. r=emilio,pip-reviewers,tabbrowser-reviewers,dao,kpatenio
...
This allows us to deprecate `mozInputSource` for the Web while
avoiding console warnings for internal uses, which now use the
ChromeOnly `inputSource` attribute.
Differential Revision: https://phabricator.services.mozilla.com/D183643
2023-07-26 09:27:45 +00:00
Marco Bonardo
93119159bf
Bug 1844150 - Don't add moz-anno:favicon to local protocols. r=daisuke,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D184376
2023-07-25 16:37:14 +00:00
Karl Tomlinson
3c7b40d1d7
Bug 1842962 allow audio output with double click on speaker name r=pbz
...
deviceIndex is removed from devices in simulateAudioOutputRequest() because
this is not used and not on nsIMediaDevice.
Differential Revision: https://phabricator.services.mozilla.com/D184056
2023-07-25 04:44:33 +00:00
Gavin Suntop
2eb394113c
Bug 1842877 - Remove old experiment code from Reader Mode r=desktop-theme-reviewers,thecount
...
Differential Revision: https://phabricator.services.mozilla.com/D183291
2023-07-19 18:49:12 +00:00
Abhishek Madan
f17537f997
Bug 1748138 - Modified cache checks to account for partition key taken from content process. r=anti-tracking-reviewers,timhuang,mconley a=reland
...
Differential Revision: https://phabricator.services.mozilla.com/D183190
2023-07-13 19:20:38 +00:00
Cristina Horotan
9d049ade00
Backed out changeset 93efae7712c8 (bug 1748138) for causing bc failures at browser_devices_get_user_media_in_xorigin_frame.js
2023-07-14 06:36:57 +03:00
Abhishek Madan
bc8c520207
Bug 1748138 - Modified cache checks to account for partition key taken from content process. r=anti-tracking-reviewers,timhuang,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D183190
2023-07-13 19:20:38 +00:00
Karl Tomlinson
8647ebdf7d
Bug 1800286 use a richlistbox for speaker selection r=pbz,desktop-theme-reviewers,dao
...
Setting the selectedItem of a richlistbox to null is a no-op and leaves
previous state remaining, so the selectedIndex is explicitly set instead of
depending on connectedCallback() to do so.
Differential Revision: https://phabricator.services.mozilla.com/D182318
2023-07-12 01:35:45 +00:00
Karl Tomlinson
64a1b53c61
Bug 1800286 use MozMenuList.appendItem() r=pbz
...
This will permit sharing code for a RichListBox.appendItem() call in a
subsequent patch.
Depends on D182316
Differential Revision: https://phabricator.services.mozilla.com/D182317
2023-07-12 01:35:44 +00:00
Karl Tomlinson
bd1995d530
Bug 1800286 move some repeated prompt set-up to listDevices() r=pbz
...
Differential Revision: https://phabricator.services.mozilla.com/D182316
2023-07-12 01:35:44 +00:00
Gijs Kruitbosch
e3c02a0ba0
Bug 1842141 - fix page style no style menu checked state after reloads or same-origin navigations, r=mconley
...
The issue here is that authorStyleDisabledDefault persists on the BrowsingContext.
This means it stays set/unset if the BC navigates same-origin (including
reloads). But the actor was keeping its own copy, on the actor, and the actor
gets destroyed in those circumstances, leading to the frontend and the internal
state no longer being in sync.
This patch addresses this by no longer keeping our own state and just reading
the browsingcontext's field directly.
This is a tiny bit hackish because technically, whether this is the 'default'
is not the same as whether the author style is actually disabled, but in
practice the child actor always sets the two at the same time, and it is
the simpler fix (vs. trying to mirror state to the parent some more).
Differential Revision: https://phabricator.services.mozilla.com/D183188
2023-07-11 22:36:31 +00:00
Dale Harvey
3650d1d639
Bug 1121903 - Use encodeURIComponent for keyword url encoding. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D181697
2023-06-23 13:31:16 +00:00
Tooru Fujisawa
09135083e3
Bug 1839276 - Update moz.build with Files() sections to use sys.mjs for already-migrated files. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D181426
2023-06-20 08:17:53 +00:00
Katherine Patenio
130ce23c4c
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f
Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
...
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
James Teow
f568003e7e
Bug 1833495 - Check if an ad is well above the possible viewable window - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D181179
2023-06-19 14:03:16 +00:00
Jan-Ivar Bruaroey
25b9e9c08d
Bug 1838505 - Add a media.getdisplaymedia.previews.enabled pref to turn off previews in the screen sharing prompt. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D180997
2023-06-14 20:15:33 +00:00
Karandeep
7cb8d5c951
Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D180229
2023-06-12 18:03:52 +00:00
James Teow
ce144701bb
Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r=scunnane
...
Differential Revision: https://phabricator.services.mozilla.com/D180346
2023-06-08 19:55:51 +00:00
Alexandre Lissy
25a528496c
Bug 1432719 - Notify user on speechd errors r=eeejay,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D176532
2023-06-06 06:28:14 +00:00
Iulian Moraru
17b7804de7
Backed out changeset 4720a9935e8e (bug 1432719) as per dev's request. CLOSED TREE
2023-06-05 15:52:52 +03:00
Alexandre Lissy
8afed64ccc
Bug 1432719 - Notify user on speechd errors r=eeejay,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D176532
2023-06-05 11:32:39 +00:00
Rob Wu
3c0c3a2676
Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
...
This patch was generated as follows:
Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.
The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.
1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.
Commands:
```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^ # and verify that the removed lines are ok.
git commit -va # one last review to verify correctness of whole patch.
git rebase -i HEAD~3 # drop the WIP + reverted commit, pick only the last.
```
`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.
Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
CanadaHonk
cfda91bc2b
Bug 1836170
- Rename ChromeOnly URL.isValidURL r=geckoview-reviewers,emilio,m_kato
...
Renamed chrome only URL.isValidURL to URL.isValidObjectURL for the name
to better match existing object/blob URL functions and to be less
confusing with new URL.canParse.
No tests for this function exist since it's chrome only (todo?) :'(
Differential Revision: https://phabricator.services.mozilla.com/D179641
2023-06-02 18:27:12 +00:00
James Teow
b7663bfe8c
Bug 1835321 - Allow any link on SERPs that don't match an ad expression to be considered a non-ad - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D179367
2023-06-01 02:13:18 +00:00
Saira Abdulla
9691ab4a5f
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
James Teow
e4f466f766
Bug 1834100 - Use timing distribution for categorizing components in SearchSERPTelemetryChild - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D179116
2023-05-31 14:24:34 +00:00
James Teow
457573b4b5
Bug 1834701 - Refactor SearchSERPTelemetry to have more isolation of page data - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D178911
2023-05-31 14:24:34 +00:00
Iulian Moraru
90b739a400
Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
...
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Niklas Baumgardner
1c305eb10b
Bug 1834554 - Update PiP telemetry. r=pip-reviewers,kpatenio
...
Depends on D175048
Differential Revision: https://phabricator.services.mozilla.com/D178864
2023-05-30 22:07:26 +00:00
Mark Banner
8b4f426ecf
Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
James Teow
26e159243e
Bug 1835125
- Check for missing components instead of providerInfo - r=scunnane
...
Differential Revision: https://phabricator.services.mozilla.com/D179125
2023-05-26 05:46:01 +00:00
Mark Banner
130a655906
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
James Teow
78b8147915
Bug 1833877 - Don't check page for components related to the impression if components don't exist - r=scunnane
...
Differential Revision: https://phabricator.services.mozilla.com/D178445
2023-05-19 02:09:57 +00:00
Neil Deakin
a1a01c30e5
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D177112
2023-05-18 23:03:34 +00:00
Cristian Tuns
6121d44e9f
Backed out changeset 8813323684b7 (bug 1830911) for causing bc failures in browser_topsites_contextMenu_options.js CLOSED TREE
2023-05-18 11:36:20 -04:00
Neil Deakin
96d3a208d9
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D177112
2023-05-18 14:38:27 +00:00
Pushpanjali
235f25ea9c
Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D173390
2023-05-18 12:21:12 +00:00
Abhishek Madan
ba1d4a0dfc
Bug 1831363 - Converted SitePermissions.jsm to ES modules and all of its corresponding references. r=pbz
...
Differential Revision: https://phabricator.services.mozilla.com/D177380
2023-05-17 14:45:26 +00:00
James Teow
e8a5e0a2b8
Bug 1832863 - Use getAttribute instead of href property - r=scunnane
...
Differential Revision: https://phabricator.services.mozilla.com/D178052
2023-05-16 22:03:46 +00:00