a0633180f9
Bug 1885179 - single accumulation API integration r=TravisLong,cookie-reviewers,valentin,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D204433
2024-03-19 13:37:15 +00:00
cb44fc4f7b
Bug 1860033 - removeCookiesFromExactHost by serialized baseDomain for IPv6 cookies. r=pbz,cookie-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D202196
2024-03-07 13:24:24 +00:00
b1d6f2eeb8
Bug 1770944 - Remove other references to inBrowserElement, r=cookie-reviewers,valentin,janv,decoder
...
Depends on D183230
Differential Revision: https://phabricator.services.mozilla.com/D189490
2024-03-07 13:04:23 +00:00
d39e78a02e
Bug 1883435 - Don't include GleanMetrics.h from Document.h. r=chutten,necko-reviewers,valentin
...
In bug 1883435 comment 2 chutten mentions that including
nsGlobalWindowInner.h from GleanMetrics.h causes a stylo build failure.
This is because nsGlobalWindowInner.h itself brings a bunch of DOM
bindings template soup that bindgen isn't great at dealing with.
That can be fixed in various ways. However, there is a simpler fix,
which is not including GleanMetrics at all.
It's trivial to do, and given it's a massive autogenerated file, and
Document.h is a very common header, it's worth doing this if only for
build times.
Fix a bunch of unused includes while at it.
Differential Revision: https://phabricator.services.mozilla.com/D203625
2024-03-05 17:54:14 +00:00
d87184a011
Bug 1864896: Autofix unused function arguments (netwerk). r=kershaw,cookie-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D202975
2024-03-01 20:52:28 +00:00
790c008f43
Bug 1880026 - Support accessing multiple cookie jars for cookie service. r=edgul,cookie-reviewers
...
This patch changes the cookie service to support accessing multiple
cookie jars under different originAttributes. This is needed in order to
support accesing unpartitioned and partitioned cookie jars for a given
document.
Differential Revision: https://phabricator.services.mozilla.com/D201968
2024-02-29 09:58:57 +00:00
7eae8c1064
Backed out 16 changesets (bug 1770944) as req by asuth.
...
Backed out changeset 61af32f40777 (bug 1770944)
Backed out changeset 4ff0c45db93b (bug 1770944)
Backed out changeset 8a217eff7bcd (bug 1770944)
Backed out changeset 6435f48c96bf (bug 1770944)
Backed out changeset 0d2432765ca0 (bug 1770944)
Backed out changeset 58e02566db85 (bug 1770944)
Backed out changeset 0a8c4c2460ee (bug 1770944)
Backed out changeset 9416bafd9982 (bug 1770944)
Backed out changeset 79de4f83fe2e (bug 1770944)
Backed out changeset 63ac518aceb0 (bug 1770944)
Backed out changeset 14952f872b77 (bug 1770944)
Backed out changeset f65e0967ad75 (bug 1770944)
Backed out changeset bd53c42038f7 (bug 1770944)
Backed out changeset 36c378ba8212 (bug 1770944)
Backed out changeset 9ba54ab06348 (bug 1770944)
Backed out changeset fb5a54b3cbe9 (bug 1770944)
2024-02-23 21:11:08 +02:00
bb8df1117c
Bug 1770944 - Remove other references to inBrowserElement, r=cookie-reviewers,valentin,janv,decoder
...
Depends on D183230
Differential Revision: https://phabricator.services.mozilla.com/D189490
2024-02-22 10:13:15 +00:00
15d140ddbc
Bug 1873921 - Stop sending third-party cookies except cookies with partitioned attribute in partitioned contexts - r=timhuang,cookie-reviewers
...
Tiny diff to do it.
Also fixes Bug 1873995 when adding testing
Differential Revision: https://phabricator.services.mozilla.com/D201266
2024-02-21 14:30:44 +00:00
0c20eae48d
Backed out changeset bee573c664c9 (bug 1873921) for bc failures on browser_partitionedCookies. CLOSED TREE
2024-02-20 22:38:54 +02:00
c619f46fdc
Bug 1873921 - Stop sending third-party cookies except cookies with partitioned attribute in partitioned contexts - r=timhuang,cookie-reviewers
...
Tiny diff to do it.
Also fixes Bug 1873995 when adding testing
Differential Revision: https://phabricator.services.mozilla.com/D201266
2024-02-20 19:34:20 +00:00
be27c149eb
Backed out 16 changesets (bug 1770944) for causing asan failures @ dom/base/InProcessBrowserChildMessageManager.cpp
...
Backed out changeset b73885731e73 (bug 1770944)
Backed out changeset 23d0dc98eb51 (bug 1770944)
Backed out changeset 15661e24d8e1 (bug 1770944)
Backed out changeset 97aa839dc200 (bug 1770944)
Backed out changeset 0d4318bf3239 (bug 1770944)
Backed out changeset be28bb62e9f3 (bug 1770944)
Backed out changeset 708b2671410e (bug 1770944)
Backed out changeset 0a138f3b56b9 (bug 1770944)
Backed out changeset 3a149ef794c2 (bug 1770944)
Backed out changeset 4b6ae7dd0e69 (bug 1770944)
Backed out changeset e3960ad85182 (bug 1770944)
Backed out changeset 9ea253525227 (bug 1770944)
Backed out changeset 1828b66c2f7c (bug 1770944)
Backed out changeset 55b0886f9025 (bug 1770944)
Backed out changeset a4197071d10a (bug 1770944)
Backed out changeset 9b18524f541e (bug 1770944)
2024-02-20 20:34:55 +02:00
981b9eb009
Bug 1770944 - Remove other references to inBrowserElement, r=cookie-reviewers,valentin,janv,decoder
...
Depends on D183230
Differential Revision: https://phabricator.services.mozilla.com/D189490
2024-02-20 16:53:24 +00:00
550505c7d8
Bug 1873626 - Restrict cookies with partitioned attribution to be used only in secure contexts. r=bvandersloot,cookie-reviewers,edgul
...
Differential Revision: https://phabricator.services.mozilla.com/D199231
2024-02-13 10:07:37 +00:00
5ae4b29108
Bug 1865749 - Update CookieServiceChild cookie list on storage access grant. r=cookie-reviewers,bvandersloot,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D199266
2024-02-09 17:28:06 +00:00
e82332be30
Backed out 2 changesets (bug 1865749) for causing mochitests failures.
...
Backed out changeset 967745446a3f (bug 1865749)
Backed out changeset 77f629fe7298 (bug 1865749)
2024-02-08 21:15:38 +02:00
0f0346928b
Bug 1865749 - Update CookieServiceChild cookie list on storage access grant. r=cookie-reviewers,bvandersloot,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D199266
2024-02-08 15:26:21 +00:00
a882785771
Bug 1877239 - Support partitioned attribute in cookie service. r=bvandersloot,cookie-reviewers,edgul
...
Differential Revision: https://phabricator.services.mozilla.com/D200288
2024-02-08 13:46:03 +00:00
6cd98ee53a
Bug 1873412 - Storing partitioned attribute in cookie db. r=bvandersloot,cookie-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D198984
2024-02-08 13:46:03 +00:00
d928aaeba8
Bug 1877848 - Fix some spelling errors in CookieService.cpp r=cookie-reviewers,edgul
...
Differential Revision: https://phabricator.services.mozilla.com/D200230
2024-01-31 22:57:48 +00:00
3c78905f47
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
51bb77759a
Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE
2024-01-27 00:15:22 +02:00
2434015dc5
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
a7c4ed310e
Bug 1691113 - Remove unused ancient cookie setting path requirement r=valentin,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D199283
2024-01-25 15:47:54 +00:00
e0a6aa9d15
Bug 1858366 - Only purge cookies in content process memory with same or older expiry. r=valentin,dveditz,cookie-reviewers
...
This will keep the content and parent process cookie lists in sync.
Depends on D197097
Differential Revision: https://phabricator.services.mozilla.com/D196963
2024-01-19 20:58:25 +00:00
0701fcede3
Bug 1858366 - Added notifications for updates to content-side cookie lists that were triggered by parent process. r=valentin,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D197097
2024-01-19 20:58:25 +00:00
57b9951a5d
Bug 1872896 - Add deprecation console message for cookies that are foreign and not Partitioned - r=timhuang,cookie-reviewers,anti-tracking-reviewers
...
In order to do this, I had to alter how we do third-party cookie blocking under CHIPS + TCP.
Before we performed the block in CheckPrefs, where we haven't parsed the cookie header (which can have multiple cookie lines) yet.
Instead, I added a new argument into CanSetCookie, which says if the cookie needs to be partitioned to be accepted (TCP && foreign && not unpartitioned).
Then inside of CanSetCookie, if that is set we warn in the console and drop the cookie if the CHIPS preference is set. The warning changes based on that pref too.
Differential Revision: https://phabricator.services.mozilla.com/D197711
2024-01-09 15:52:30 +00:00
8762fd6b11
Bug 1868390 - Have TCP block cookies by default behind a default-off preference - r=timhuang,cookie-reviewers,anti-tracking-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D195553
2023-12-12 19:00:01 +00:00
55cad8d48f
Bug 1847298: IPC constructor cleanup r=nika,padenot,dom-storage-reviewers,necko-reviewers,cookie-reviewers,asuth,Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D185472
2023-12-08 15:56:39 +00:00
80d2e9bb05
Bug 1865199 - Add telemetry to determine what percent of Set-Cookies are Partitioned - r=cookie-reviewers,timhuang
...
Depends on D194235
Differential Revision: https://phabricator.services.mozilla.com/D194236
2023-12-01 20:52:40 +00:00
7f0bebf3c1
Bug 1865199 - Parse partitioned attribute - r=cookie-reviewers,timhuang
...
Only parse the attribute so that we can do telemetry with it.
Differential Revision: https://phabricator.services.mozilla.com/D194235
2023-12-01 20:52:39 +00:00
524396df6f
Backed out 2 changesets (bug 1865199) for causing bc failures on browser_partitioned_telemetry.js CLOSED TREE
...
Backed out changeset 2ec416e3c7f7 (bug 1865199)
Backed out changeset 92f07e8c3190 (bug 1865199)
2023-12-01 18:06:23 +02:00
4d19aa5f22
Bug 1865199 - Add telemetry to determine what percent of Set-Cookies are Partitioned - r=cookie-reviewers,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D194236
2023-12-01 14:33:04 +00:00
e8bc824730
Bug 1865199 - Parse partitioned attribute - r=cookie-reviewers,timhuang
...
Only parse the attribute so that we can do telemetry with it.
Differential Revision: https://phabricator.services.mozilla.com/D194235
2023-12-01 14:33:04 +00:00
78ec0a76c6
Backed out 2 changesets (bug 1865199) for causing mochitests failures in browser_partitioned_telemetry.js. CLOSED TREE
...
Backed out changeset 1772dfe55a1e (bug 1865199)
Backed out changeset 42029f50de7d (bug 1865199)
2023-11-30 22:13:26 +02:00
ce0f4d0b47
Bug 1865199 - Add telemetry to determine what percent of Set-Cookies are Partitioned - r=cookie-reviewers,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D194236
2023-11-30 18:32:26 +00:00
152051d176
Bug 1865199 - Parse partitioned attribute - r=cookie-reviewers,timhuang
...
Only parse the attribute so that we can do telemetry with it.
Differential Revision: https://phabricator.services.mozilla.com/D194235
2023-11-30 18:32:26 +00:00
9d203b1d46
Bug 1859893 - batch 15 - migrate xpcshell.ini -> .toml. r=aryx,geckoview-reviewers,extension-reviewers,valentin,cookie-reviewers,pbz,owlish,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D194384
2023-11-24 14:41:35 +00:00
9fcf550bd8
Bug 1828942 - Added telemetry for cookie partition counting and purging for cookie jar size investigation. r=pbz,cookie-reviewers,valentin,bvandersloot
...
Differential Revision: https://phabricator.services.mozilla.com/D183544
2023-11-22 19:14:35 +00:00
9ade511ef2
Bug 1845938 - Change assertion to early return for GetBaseDomainFromHost failure. r=cookie-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D185928
2023-11-09 16:01:57 +00:00
27e306d932
Bug 1844815 - Added cookie db cleanup for old non-ipv4 urls with hostnames ending in a number. r=valentin,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D184520
2023-10-17 22:09:10 +00:00
0cb91fe33e
Bug 1855300 - convert .ini manifests to .toml: batch 11 remaining **/mochitest.ini r=jmaher,geckoview-reviewers,extension-reviewers,valentin,credential-management-reviewers,cookie-reviewers,sgalich,m_kato,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D190515
2023-10-13 02:32:24 +00:00
25c0d10932
Bug 1624819 - Remove TaskCategory and other quantum dom remnants. r=smaug,media-playback-reviewers,credential-management-reviewers,cookie-reviewers,places-reviewers,win-reviewers,valentin,mhowell,sgalich,alwu
...
Sorry this is not a particularly easy patch to review. But it should be
mostly straight-forward.
I kept Document::Dispatch mostly for convenience, but could be
cleaned-up too / changed by SchedulerGroup::Dispatch. Similarly maybe
that can just be NS_DispatchToMainThread if we add an NS_IsMainThread
check there or something (to preserve shutdown semantics).
Differential Revision: https://phabricator.services.mozilla.com/D190450
2023-10-10 08:51:12 +00:00
4c29c24344
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
99abb50b8d
Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.25). r=aryx,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D189221
2023-09-26 17:40:01 +00:00
e5762669e5
Bug 1854028 - Update BounceTrackingStorageObserver cookie check and remove nsICookieNotification isThirdPartyCookie. r=bvandersloot,cookie-reviewers,anti-tracking-reviewers,timhuang
...
For the BounceTrackingStorageObserver, instead of passing in a third-party flag
we can simply check if the changed cookie is partitioned or not.
Differential Revision: https://phabricator.services.mozilla.com/D188732
2023-09-21 14:42:32 +00:00
c9eda14998
Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D182373
2023-09-20 17:50:23 +00:00
67c904d08b
Bug 1839918 - Use PHttpChannel for SetCookies calls from child channels. r=bvandersloot,necko-reviewers,cookie-reviewers,valentin
...
Depends on D186045
Differential Revision: https://phabricator.services.mozilla.com/D186340
2023-09-18 11:55:10 +00:00
392e706ba1
Bug 1839918 - Create SetCookies variant for document.cookie on PWindowGlobal. r=bvandersloot,cookie-reviewers,valentin
...
Using PWindowGlobal for SetCookies calls from content to parent process means we can get
the BrowsingContext the cookies are set for. The current implementation in PCookieService
drops this relationship.
I'm leaving in the old SetCookies call for cases where the inner window is null. This
happens for some of the cookie tests.
Depends on D185303
Differential Revision: https://phabricator.services.mozilla.com/D186045
2023-09-18 11:55:09 +00:00
6e479f1af4
Bug 1839918 - Pass BrowsingContext ID and third-party flag through CookieService. r=bvandersloot,cookie-reviewers,edgul
...
Depends on D185302
Differential Revision: https://phabricator.services.mozilla.com/D185303
2023-09-18 11:55:09 +00:00
Perry McManis
Leander Schwarz
Artur Iunusov
Emilio Cobos Álvarez
Dave Townsend
Tim Huang
Narcis Beleuzu
Benjamin VanderSloot
Cosmin Sabou
Sandor Molnar
Paul Zuehlcke
Stanca Serban
Sean Feng
Tom Marble
Ed
Randell Jesup
Norisz Fay
Joel Maher
Sylvestre Ledru