Ideally this check will alert people that something is wrong with their
configuration. This check shouldn't normally be firing with our `mach
boostrap` setup, but if somebody chooses to install distribution
packages for some reason, this will at least prevent some problems.
People building without a compilation environment (artifact builds, l10n
builds) won't have a compiler available, let alone the bits to build
bindgen. We should limit our checks for bindgen-y things accordingly.
Prior to this patch, we had a not-so-great hack in place: the bit of
configure that determined bindgen config paths *and* the bit of
configure that returned various pieces of information about Stylo were
both guarded on --enable-stylo-build-bindgen. We should really only
have one place that depends on --enable-stylo-build-bindgen, and this
patch puts us in a place to do that, by making bindgen_config_paths
properly use a when= argument to determine when it needs to run.
This commit makes the `stylo` function entirely redundant, and said
function will be removed in the next patch.
stylo.build is just a copy of stylo_config.build, so we should use the
former to limit the number of duplicate concepts we have. Using
stylo_config consistently enables us to separate out what artifact
builds need vs. non-artifact builds.
On some systems, llvm-config may be installed, but not the files to
which it needs to refer. We should ensure that the values returned
actually make some sense.
--with-libclang-path is supposed to be a directory, and
--with-clang-path is supposed to be a file, but it was easy to pass a
directory for the latter, and it was easy to misinterpret the
documentation for --with-libclang-path as pointing to one of the
libraries themselves. Clearer documentation and additional checks
should help with this situation.
A number of places in JS need to drain the current thread's event queue,
which cannot be done with nsIThreadManager::spinEventLoopUntil, since we
need to not wait for an incoming event when attempting to process one.
(For Landing more OSX Nightly Support from date to central)
MozReview-Commit-ID: BeXoChssNjF
--HG--
extra : source : 9ee7ad587c736536e254a469ff5365637bf59c38
(For Landing more OSX Nightly Support from date to central)
MozReview-Commit-ID: FSbQZ1Fbdcs
--HG--
extra : source : c473197afe6f45e22a1c294e17a040b8d74d9f56
(For Landing more OSX Nightly Support from date to central)
MozReview-Commit-ID: F8Dl1502D4L
--HG--
extra : source : c347e7729caf65039f0b1eb828c32079612af806
This commit
- adds onboarding tour notification
- shows still not completed onboarding tour notifications in order
- opens target tour from tour notification for the target tour
MozReview-Commit-ID: AwLtwjoeARQ
--HG--
extra : rebase_source : 264531cf8aaf3f636faecf790a269d0166188f8a
There are a few places in services/ tests that import btoa and atob,
but this is not necessary, because those are both defined on the
XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds
like it didn't work at some point on B2G (see bug 937114) but that
isn't relevant any more. I want to fix this because the way these
properties are imported will break with shared JSM globals.
MozReview-Commit-ID: HoxqIS98p7B
--HG--
extra : rebase_source : 7800baee8ebc5e3ab3f52a62e30e5cde8d19876b
We also move some methods to protected so they are callable from ChannelMediaDecoder.
MozReview-Commit-ID: 6s9LKNkbJhX
--HG--
extra : rebase_source : 172ea88bc01552a90f5ef51db2b5af0ac5551c3b
extra : intermediate-source : a724333159c6b408e2fa68dba2d0a467f3c55940
extra : source : 03760e05ea8044b3404d29bb62205a2f62892d4b
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
https://bugzilla.mozilla.org/show_bug.cgi?id=1336891
Source-Repo: https://github.com/servo/servo
Source-Revision: daed0a51839112054036f220ba1a6f03a8325b9b
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 159aeb13c12e5420c2fef2498f843879e51a4ad6
Michael Layzell
Tobias Schneider
Nathan Froyd
Mason Chang
Lars T Hansen
Joel Maher
Bob Owen
steveck-chung
Hiroyuki Ikezoe
Andreas Farre
Justin Wood
Fischer.json
Andrew McCreight
JW Wang
Wes Kocher
Fernando Jiménez Moreno
Daosheng Mu
Benjamin Smedberg