The test requires to support allowing nested `execCommand` if we want to run
completely. From point of view of the purose of crashtests, we should allow
it for testing in more complicated situation. Therefore, this patch allows
it while the test is running by the pref.
Differential Revision: https://phabricator.services.mozilla.com/D125914
Bug 1728967 dropped it but dom.webidl.crosscontext_hasinstance.enabled is
`true` outside Nightly and needs to be set to `false` in this file for the test.
Differential Revision: https://phabricator.services.mozilla.com/D126358
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.
Differential Revision: https://phabricator.services.mozilla.com/D121512
Automatic update from web-platform-tests
Revert ScopedForcedUpdate Range changes
This reverts two patches:
http://crrev.com/919277http://crrev.com/919407
The first patch caused a memory regression, and the second patch is
based on it so it must also be reverted.
The memory regression probably won't be too hard to fix, but since it's
this close to the branch I'm just going to revert them.
Bug: 1236774
Fixed: 1247842
Change-Id: I5c5bb3c3a0a53ba4f6c2ba87a28f0b00fe6e0294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152055
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919874}
--
wpt-commits: 7368bcb6a3b8b393e5e83e36530ba14b6133eff3
wpt-pr: 30473
Automatic update from web-platform-tests
Improve breaking before nested multicols and their rows.
1. Avoid breaking inside an inner multicol fragment if there were
suboptimal breaks inside even if the inner multicol container didn't
break in the outer fragmentation context. multicol-nested-018.html,
multicol-nested-022.html and multicol-nested-023.html test this.
2. Properly constrain balanced column block-size to remaining space in
the outer fragmentainer. We used to let unbreakable content override
the remaining space, but this is wrong. This fixes
forced-break-too-short-column.html and
nested-short-first-row-extra-tall-line.html
Store break appeal in NGLayoutResult, rather than in NGBreakToken. The
reason is that we may have a violating break inside a fragment that
happened inside a nested fragmentation context, even if the fragment
doesn't necessarily break within the outer fragmentation context.
Also create a proper break token inside a nested multicol container if
there is none and we want to break before the first piece of column
content. Calling SetDidBreakSelf() manually, like we used to, confused
FinishFragmentation() into thinking that we were past the end of the
block-end content box of the multicol container. This is tested by
nested-with-padding.html Because of this change, the code in
PreviousInnerFragmentainerIndex() needed an update, to ignore this break
token, since break-before tokens don't have a sequence number.
Remove the has_violating_descendant_break flag, and use the break appeal
in the layout result instead. We had a column-balancing bug where where
we were missing break-inside:avoid violations, because such violations
don't affect the child's stored break appeal (the reason for this is
explained in further detail inside CalculateBreakAppealInside()).
Such violations were already propagated correctly to the builder's break
appeal, so now it just works. This is tested by
multicol-fill-balance-014.html . Also remove
LayoutNGBlockFragmentation-specific baselines for
moz-multicol3-column-balancing-break-inside-avoid-1.html because of
this, as we now render identically to the legacy engine.
This change fixes some existing tests. It also made
outer-column-break-after-inner-spanner-2.html render correctly, but not
according to the expectation, which was written for the legacy engine.
The legacy engine fails to push the block with the BR inside entirely to
the next outer fragmentainer. So replce it with a correct test:
multicol-nested-017.html
Bug: 829028
Change-Id: I13b2d95a0eb0407a82c8c24070a6dff4d2f620e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150413
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919825}
--
wpt-commits: 3d56f2cc3e241a413c6801597a5895eeb9c1dded
wpt-pr: 30420
Automatic update from web-platform-tests
Avoid suboptimal breaks inside a column row when appropriate.
Set a minimum appeal for breaks inside a nested multicol container, if
the row is past the block-start of the outer fragmentainer. If there's
content that breaks suboptimally (with a lower appeal than any previous
breaks), push such content ahead of us, so that it ends up in the next
outer fragmentainer. There may be more space there, so that the
suboptimal break may be avoided.
Propagate the lowest appeal among all column breaks to the multicol
fragment builder, so that an ancestor can decide to break before the
entire multicol container, if that would be better. This currently only
works if the multicol container itself breaks, since break appeal is
stored in the break tokens. A follow-up CL will fix this (by storing it
in NGLayoutResult instead), so that we'll also detect suboptimal breaks
inside a nested multicol container that didn't break in the outer
fragmentation context.
This doesn't fix any existing tests by itself, but will contribute to
it. A follow-up CL will fix some remaining problems, so that quite a few
existing tests will finally pass.
Bug: 829028
Change-Id: I4a09e2163aa194780be986f358283d4e8da9a115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149995
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919814}
--
wpt-commits: 8097f1959cf300cd423192fe36d00c05c58c066c
wpt-pr: 30419
Automatic update from web-platform-tests
Add FileSystemHandle::move() and FileSystemHandle::rename() methods
Currently, it is not possible to move or rename a file or directory
without creating a new file/directory, copying over data (recursively,
in the case of a directory), and removing the original.
This CL allows for the atomic moving of a file or directory on the
local file system without needing to duplicate data.
Moves to non-local file systems will are not guaranteed to be atomic
and will involve duplicating data.
PR: https://github.com/WICG/file-system-access/pull/317
Bug: 1140805
Change-Id: I774ed1d9616249b6ecc80783db48a7bfee915aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2984739
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919810}
--
wpt-commits: 72023078617ed82a4c707c7966fffe42b0f0e66a
wpt-pr: 29686
Automatic update from web-platform-tests
Update scroll-animation tests to be independent of scrollbar width
This patch addresses sources of test failures observed when implementing
a polyfill implementation of scroll timelines. Different platforms can
use different scrollbar widths, which leads to some changes in
expectations. By hiding the scrollbars, we have consistency across
platforms and avoid fractional scroll offsets.
Previous expectations may be the source of Mac failures.
Deferring possible re-enabling of Mac tests to a followup CL.
Bug: 1246372
Change-Id: I6b7ad072af495b23e4acf0654a210847de8cb78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149090
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919758}
--
wpt-commits: ef3d38ed29fcc2760eaf3af45d9eb8a0845522ff
wpt-pr: 30400
Automatic update from web-platform-tests
[Re-Factor Client Hints] (2) Fix the naming of (unlaunched) `lang` client hint
This change would be externally visible (changing `sec-ch-lang`
to `lang`), except that this client hint was never launched. The goal
is to remove the hint entirely, but a longer road is needed due to
the current code structure (see below).
This is a part of a series of CLs to re-factor the client hints code:
(1) Label hints with legacy names
(2) Fix the naming of (unlaunched) `lang` client hint
(3) Consolidate client hint name lists
(4) Migrate from array to map indexing for client hint names
(5) Remove (unlaunched) `lang` client hint
Bug: 1227043
Change-Id: Icb41198a5dcf03a9fc16b8822662faaa3951263c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149431
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919706}
--
wpt-commits: eb90781d3ec0766b56286dbb19ecb31dc2c8369d
wpt-pr: 30397
Automatic update from web-platform-tests
[css-pseudo] rework selection-decoration-*
--
fix selection-decoration-p5 for Safari on macOS
--
clean up incomplete comments and outdated flavour text
--
oops i forgot to save the flavour text in p5 test
--
rename and retitle tests, as not all are about decorations anymore
--
fix lints about broken match links and SUPPORT-WRONG-DIR
--
move asserts to titles, move intro comments to asserts
--
clarify comment about anti-aliasing in p1 ref
--
rename tests to more meaningful paths
--
wpt-commits: 5fcc0ca603cf8fd34f232577a4dcdb0ba50ddbe4, 9691182292c65a1dd857333c4fdcb9d6ea9ba46d, e4c4705d6340708b1fdf875b89d1d934ae9a8341, b8c1d52f15e65ec317e07c4937c16c039f384c6a, e6afd4de5651e5ca624d1e618321d408492fcc9b, caffde7c25b177aed3f0c64094e990dbffeab1aa, ad3b1ed34417c8f1fd265b2174b0688fdccb6a4d, 120d06ddf28b3cc279fe000cb6de9bce87586650, 3315aefc163746686c5469cf29ca7e658cb74141
wpt-pr: 30283
Automatic update from web-platform-tests
[anonymous_iframe] Add WPT for partitioned shared workers
This CL adds a test checking that anonymous iframes get partitioned
shared workers.
Bug: 1226469
Change-Id: Ic11085834b567ca178a952828f638b5243eae25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3148055
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919676}
--
wpt-commits: fcef8d84a9fe8d0eecb7b33fda7ac19ab6f88885
wpt-pr: 30395
Automatic update from web-platform-tests
Reland "Force DisplayLocks in <input type=image> layout APIs"
Original patch: http://crrev.com/919246
Revert patch: http://crrev.com/919305
The original patch's test was flaky because it didn't wait for the load
event when loading the image.
Unfortunately, it would seem that <input type=image> doesn't fire load
events within c-v:hidden subtrees like <img> does, which means that we
have no signal to wait for the image to load. I have filed a separate
issue for this, and will mark the test as timing out for now.
https://bugs.chromium.org/p/chromium/issues/detail?id=1247844
Bug: 1247417, 1247844
Fixed: 1247714
Change-Id: Ic76777857774cfa67d974e370358a1a720fa7025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149403
Commit-Queue: vmpstr <vmpstr@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919597}
--
wpt-commits: f48fd037ceb2b498e0e4e2dd5004c41cd78771f4
wpt-pr: 30412
Automatic update from web-platform-tests
Fix animation can see through problem
We found that for the animations that uses paint worklet infra,
which are background-color and custom property animations, we can
see through the browser window when there is one keyframe with
alpha < 1.
Investigation shows that the reason is that the contents_opaque_
in the LayerImpl isn't correctly set. This CL fixes the problem
and add tests.
Bug: 1244155, 1237234
Change-Id: Iecddfa2c335f65e1857a96ae7790eaa4e91952d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3132822
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919572}
--
wpt-commits: 35ca181a5e60c920f21c58333238e303e140bb9b
wpt-pr: 30268
Automatic update from web-platform-tests
Implement AppHistoryEntry's dispose event
At least, for renderer-initiated disposals. Browser-initiated
disposals are tracked in https://crbug.com/1241598.
This also doesn't work in bfcache cases, as described in
https://crbug.com/1241655. Those are more generally broken.
Bug: 1183545
Change-Id: Ife4f022909d266d20ae04a5e543286bd60ec9107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140225
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919557}
--
wpt-commits: 8a46b5efbe03b8ea2a687867ec23cc1279d4709e
wpt-pr: 30338
Automatic update from web-platform-tests
Added a text-shadow and text-orientation: upright test (#27770)
--
wpt-commits: f810df21e9e355b120d3ef338eb61b69e3dd2cc1
wpt-pr: 27770
Automatic update from web-platform-tests
URLPattern: Support pattern syntax in IPv6 hostnames.
This adds support for patterns that having matching syntax inside of
IPv6 address hostnames like:
new URLPattern({ hostname: '[:address]' });
This issue is discussed here:
https://github.com/WICG/urlpattern/issues/115
This CL also does a drive-by fix of a stale header reference in the
blink presubmit warnings.
Fixed: 1245998
Change-Id: I772258dc69c2b658ee4d7306b4f1975324624338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140140
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919392}
--
wpt-commits: 9ed05ce5db764a0c508090034ffbb7014ec2b639
wpt-pr: 30309
Automatic update from web-platform-tests
[block-in-inline] Propagate baselines from block-in-inline
Block-in-inline is the only case where a line box may have
different and optional first and last baselines.
This patch propagtes them from block-in-inline correctly.
Bug: 716930
Change-Id: I4eab225c7456ca31542a0187cb818568abafdb15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149290
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919385}
--
wpt-commits: 149d0e57f98a1aed6c24bc1d20a0f1deab8d675d
wpt-pr: 30402
Automatic update from web-platform-tests
Force DisplayLocks in <img> Layout APIs
Without this patch, width, height, x, and y return zero due to layout
being skipped for DisplayLocking.
Bug: 1247417
Change-Id: I29f34a20d49be03ac810186ca65983b6e43e4391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3145934
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919323}
--
wpt-commits: 00eaeb7210e73f6d24ebe64fc9aa1d5369992263
wpt-pr: 30382
Automatic update from web-platform-tests
Fix slow stylesheet test
Script blocking sheet does not need timeout since tests will not run
until the sheet loads anyway. Href on modified link should not need a
large delay since the test happens in the script immediately after
setting the href.
Bug: 1245034
Change-Id: Ieee7fd7137046b23a4c2f0039df982e9bec888c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3147711
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919307}
--
wpt-commits: bf08701d31681113efd536eaec0a3d294d16e413
wpt-pr: 30394
Automatic update from web-platform-tests
Force DisplayLocks when Range uses layout APIs
Selection and other Range APIs can use layout APIs of DisplayLocked
content in a way which causes DCHECKs due to the skipped layout. This
patch forces those DisplayLocks to get updated layout information.
Bug: 1236774
Change-Id: Ie6c36d748df08cb2a03125dbca0a666836bc3b3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3137417
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919277}
--
wpt-commits: e5604d49e2b4c0f19d01cdc1338aa5bfd39733b2
wpt-pr: 30297
Masayuki Nakano
Kimberly Sereduck
Sebastian Hengst
Ms2ger
Kershaw Chang
Alex Lopez
moz-wptsync-bot
Joey Arhar
Domenic Denicola
Morten Stenshorne
Austin Sullivan
Kevin Ellis
Ari Chivukula
Delan Azabani
Antonio Sartori
Koji Ishii
Olga Gerchikov
Xida Chen
Domenic Denicola
Gérard Talbot
Xiaocheng Hu
Ben Kelly
Rune Lillesveen
Juanmi Huertas