Gijs Kruitbosch
0377d8eece
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
...
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
our connections. It also tries to avoid waiting on other, non-DB operations
before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
kinto and ensuring they complete before the end of `profile-before-change`.
Any operations started after Services.startup.isShuttingDown (so after
quit/restart is initiated by the user) will throw. Operations started
beforehand are put in a set of operations, and remove themselves once
complete. We AsyncShutdown block on that set of operations completing.
Differential Revision: https://phabricator.services.mozilla.com/D66995
--HG--
extra : moz-landing-system : lando
2020-03-24 14:55:41 +00:00
Andreea Pavel
3550cada92
Backed out changeset 3b7ccffc0546 (bug 1598924) for permafailing bug 1621759 on a CLOSED TREE
2020-03-23 21:37:55 +02:00
Gijs Kruitbosch
457afaaba0
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
...
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
our connections. It also tries to avoid waiting on other, non-DB operations
before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
kinto and ensuring they complete before the end of `profile-before-change`.
Any operations started after Services.startup.isShuttingDown (so after
quit/restart is initiated by the user) will throw. Operations started
beforehand are put in a set of operations, and remove themselves once
complete. We AsyncShutdown block on that set of operations completing.
Differential Revision: https://phabricator.services.mozilla.com/D66995
--HG--
extra : moz-landing-system : lando
2020-03-23 16:35:08 +00:00
Mathieu Leplatre
24fcb6ab53
Bug 1620185 - Improve behaviour when signature is bad after retry r=glasserc
...
When the signature verification fails after retry we don't want to apply the changes, and if possible we want to leave the local data as it was before sync.
Differential Revision: https://phabricator.services.mozilla.com/D67139
--HG--
extra : moz-landing-system : lando
2020-03-17 20:24:01 +00:00
Mathieu Leplatre
fbd73a9215
Bug 1620185 - Simplify CanonicalJSON of records r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66750
--HG--
extra : moz-landing-system : lando
2020-03-17 20:22:32 +00:00
Mathieu Leplatre
aaf32a2504
Bug 1620185 - Remove usage of .openCollection() r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66632
--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:46 +00:00
Mathieu Leplatre
47e09d0ba8
Bug 1620185 - Remove usage of kinto.js collection instance r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66630
--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:05 +00:00
Mathieu Leplatre
76e09115f9
Bug 1620185 - Remove usage of kinto.js collection methods r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66629
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:38 +00:00
Mathieu Leplatre
fbc12fc39d
Bug 1620185 - Reuse code from signature failure retry r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66412
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:28 +00:00
Florian Quèze
2c3a1ae0be
Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
...
Differential Revision: https://phabricator.services.mozilla.com/D65747
--HG--
extra : moz-landing-system : lando
2020-03-11 14:22:06 +00:00
Daniel Varga
df858c9057
Backed out changeset 6aaa835ae0eb (bug 1620630) for causing xpcshell failures at osfile/tests/xpcshell/test_osfile_closed.js
...
CLOSED TREE
2020-03-10 21:08:48 +02:00
Florian Quèze
5345d6fcbb
Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
...
Differential Revision: https://phabricator.services.mozilla.com/D65747
--HG--
extra : moz-landing-system : lando
2020-03-10 17:04:10 +00:00
Mark Banner
2c4e35b0a6
Bug 1620218
- Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65509
--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mathieu Leplatre
9448fcafc5
Bug 1617133 - Report error names to Telemetry on Nightly r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64560
--HG--
extra : moz-landing-system : lando
2020-03-02 15:04:33 +00:00
Mathieu Leplatre
38a37caab2
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=tarek,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-25 15:29:48 +00:00
Mathieu Leplatre
2e479b39a0
Bug 1616637 - Generalize appinfo attribute in JEXL environments r=mythmon
...
Differential Revision: https://phabricator.services.mozilla.com/D63673
--HG--
extra : moz-landing-system : lando
2020-02-21 18:12:44 +00:00
Cosmin Sabou
db738a9933
Backed out changeset 78353ef17d0d (bug 1616052) for causing xpc crashes @mozilla::storage::Service::Observe.
...
CLOSED TREE
2020-02-21 20:18:26 +02:00
Mathieu Leplatre
71425f67b1
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=tarek,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-21 16:16:10 +00:00
Mathieu Leplatre
b26270876b
Bug 1597688 - Catch Remote Settings worker crashes r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D63161
--HG--
extra : moz-landing-system : lando
2020-02-19 17:40:54 +00:00
Daniel Varga
5ef32871a5
Backed out changeset 4d1cffb02095 (bug 1616052) for causing xpcshell failures at oolkit/components/url-classifier/tests/unit/test_features.js
...
CLOSED TREE
2020-02-19 23:02:45 +02:00
Mathieu Leplatre
39b0b08525
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-19 17:26:07 +00:00
Mathieu Leplatre
52cd30df2d
Bug 1616274 - Report offline error for attachments downloading r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63194
--HG--
extra : moz-landing-system : lando
2020-02-18 19:51:41 +00:00
Mathieu Leplatre
0ef9e2ed2f
Bug 1613923 - Do not synchronize if network is offline r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D62600
--HG--
extra : moz-landing-system : lando
2020-02-17 10:52:47 +00:00
Mathieu Leplatre
ccf760a4f8
Bug 1612712 - Add received polling timestamp in uptake events r=mythmon
...
Differential Revision: https://phabricator.services.mozilla.com/D62436
--HG--
extra : moz-landing-system : lando
2020-02-11 17:10:38 +00:00
Tooru Fujisawa
8a7e982608
Bug 1259822 - Part 2: Show property key in the error message when target object value is null or undefined. r=jorendorff
...
Differential Revision: https://phabricator.services.mozilla.com/D58104
--HG--
extra : moz-landing-system : lando
2020-01-11 05:10:54 +00:00
Mathieu Leplatre
7e8fc190b6
Bug 1601893 - Fix Remote Settings test about events on release r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D57761
--HG--
extra : moz-landing-system : lando
2019-12-19 15:03:31 +00:00
Mathieu Leplatre
a6d949c39b
Bug 1559132 - Add ability to download Remote Settings attachments as bytes r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D53812
--HG--
extra : moz-landing-system : lando
2019-11-25 16:13:52 +00:00
Mathieu Leplatre
280083669e
Bug 1597337 - Report download errors in uptake telemetry r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D53783
--HG--
extra : moz-landing-system : lando
2019-11-22 08:35:30 +00:00
Gijs Kruitbosch
734a4ade99
Bug 1597785 - fix review nits from bug 1594521, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D53861
--HG--
extra : moz-landing-system : lando
2019-11-19 21:44:10 +00:00
Gijs Kruitbosch
acafdba483
Bug 1594521 - avoid instantiating remote settings worker after shutdown, r=leplatrem,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D53751
--HG--
extra : moz-landing-system : lando
2019-11-19 15:14:07 +00:00
Mathieu Leplatre
5cb0d4bf75
Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36921
--HG--
extra : moz-landing-system : lando
2019-07-22 13:50:04 +00:00
Coroiu Cristina
6e3840ddec
Backed out changeset 7aa8180f36eb (bug 1563180) for ESlint failure
2019-07-06 19:43:30 +03:00
Mathieu Leplatre
4039e268d2
Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36921
--HG--
extra : moz-landing-system : lando
2019-07-06 16:05:12 +00:00
Victor Porof
9d673f1f0f
Bug 1561435 - Format services/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35930
--HG--
extra : source : 073567e8ded785e46382ba7e402d8da939a69d7b
2019-07-05 10:58:22 +02:00
Mathieu Leplatre
56afa0ab7c
Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35240
--HG--
extra : moz-landing-system : lando
2019-07-04 15:15:48 +00:00
Mathieu Leplatre
3e347218c9
Bug 1560451 - Fix duplicates in list of created on sync event r=glasserc
...
Depends on D36171
Differential Revision: https://phabricator.services.mozilla.com/D36182
--HG--
extra : moz-landing-system : lando
2019-06-27 13:40:24 +00:00
Mathieu Leplatre
0cf601cfff
Bug 1559158 - Improve performance of sync for large collections r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36171
--HG--
extra : moz-landing-system : lando
2019-06-27 13:25:57 +00:00
Noemi Erli
2e091fbe26
Backed out 2 changesets (bug 1559514) for failures in browser_CTP_plugins.js CLOSED TREE
...
Backed out changeset 157999f49345 (bug 1559514)
Backed out changeset f31cd670c9ac (bug 1559514)
2019-06-21 02:00:18 +03:00
Mathieu Leplatre
4fcd8eaee9
Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35240
--HG--
extra : moz-landing-system : lando
2019-06-20 19:02:31 +00:00
Mathieu Leplatre
5a828c9d6d
Bug 1559514 - Emit sync event when JSON dump is loaded from .get() r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35239
--HG--
extra : moz-landing-system : lando
2019-06-20 20:45:55 +00:00
Mathieu Leplatre
94be713565
Bug 1558812 - Upgrade kinto-offline-client to 12.4.3 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D34715
--HG--
extra : moz-landing-system : lando
2019-06-12 14:20:59 +00:00
Mathieu Leplatre
80c3d0b5ca
Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32769
--HG--
extra : moz-landing-system : lando
2019-06-03 10:02:13 +00:00
Mathieu Leplatre
921d7af3d5
Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32768
--HG--
extra : moz-landing-system : lando
2019-06-03 09:59:29 +00:00
Dorel Luca
5e31d37927
Backed out 2 changesets (bug 1553831) for XPCshell failure in services/settings/test/unit/test_remote_settings.js
...
Backed out changeset d03a51956262 (bug 1553831)
Backed out changeset 4f62dfaee27f (bug 1553831)
2019-05-31 14:43:50 +03:00
Mathieu Leplatre
365261e7d6
Bug 1553995 - Remote Settings should not throw with dummy server r=glasserc,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D32549
--HG--
extra : moz-landing-system : lando
2019-05-31 09:53:05 +00:00
Mathieu Leplatre
f4957e385f
Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
...
Depends on D32768
Differential Revision: https://phabricator.services.mozilla.com/D32769
--HG--
extra : moz-landing-system : lando
2019-05-30 19:48:49 +00:00
Mathieu Leplatre
13c9f8aeb9
Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32768
--HG--
extra : moz-landing-system : lando
2019-05-28 13:58:29 +00:00
Mathieu Leplatre
9871d095db
Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32484
--HG--
extra : moz-landing-system : lando
2019-05-27 07:35:45 +00:00
Narcis Beleuzu
b9bb66c9e0
Backed out changeset 204c7f42d427 (bug 1554178) for xpcshell failures on test_remote_settings.js . CLOSED TREE
2019-05-25 02:41:41 +03:00
Mathieu Leplatre
daebd4816c
Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32484
--HG--
extra : moz-landing-system : lando
2019-05-24 16:23:31 +00:00