Граф коммитов

61 Коммитов

Автор SHA1 Сообщение Дата
Drew Willcoxon c7e19ee271 Bug 1579334 - Properly limit remote tab matches in the quantumbar. r=mak
This is a narrow patch that simply adds a `maxMatches` param to `PlacesRemoteTabsAutocompleteProvider.getMatches`.

Differential Revision: https://phabricator.services.mozilla.com/D50019

--HG--
extra : moz-landing-system : lando
2019-10-22 15:22:48 +00:00
Edouard Oger a6c404619f Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D44485

--HG--
extra : moz-landing-system : lando
2019-09-10 18:23:31 +00:00
Victor Porof 9d673f1f0f Bug 1561435 - Format services/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35930

--HG--
extra : source : 073567e8ded785e46382ba7e402d8da939a69d7b
2019-07-05 10:58:22 +02:00
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner 691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Kris Maglione a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Marco Bonardo dbde0c7df9 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : 6f5ec9404f12eb988501df56c7ee264ade2b054c
2018-04-16 18:24:06 +02:00
Dorel Luca c4fec6222b Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo b00d20562d Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : e8a1adb7c1004eaefddc42d12048d445eecd6530
2018-04-16 18:24:06 +02:00
Amy Chan d494f855f6 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 19:22:38 -04:00
Gurzau Raul 50d002961a Backed out 2 changesets (bug 1446975) for failing xpcshell on sync/tests/unit/test_syncedtabs.js and browser-chrome failures e.g. test/urlbar/browser_page_action_menu.js on a CLOSED TREE
Backed out changeset 69653800c483 (bug 1446975)
Backed out changeset 44e3e7446b02 (bug 1446975)

--HG--
rename : browser/themes/shared/icons/device-phone.svg => browser/themes/shared/icons/device-mobile.svg
2018-04-13 01:28:22 +03:00
Amy Chan 711220e6e7 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 16:18:22 -04:00
Florian Quèze 682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou 9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione 6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Mark Hammond 57f9284cef Bug 1425987 - part 2: Cleanup Sync logging by rationalizing preference management. r=tcsc
MozReview-Commit-ID: CQ1vhahnQbc

--HG--
extra : rebase_source : 5456b3afcf2d2d3536b9b546dda67199af4e1bdd
2017-12-19 09:48:31 +11:00
Mark Hammond 6b3554dc84 Bug 1423067 - SyncedTabs.jsm now exports the loginFailed getter fixing an issue with the sidebar. r=eoger
MozReview-Commit-ID: AVjfXH1E9uw

--HG--
extra : rebase_source : 8ee64138f5604b12af1f4ffa0cabb73ab6ad5465
2017-12-05 14:46:53 +11:00
Edouard Oger 0648f86b7f Bug 1304898 - Include why in sync ping. r=tcsc
MozReview-Commit-ID: G9WnHhuWD7Z

--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
2017-11-15 17:10:45 -05:00
Mark Hammond 472098beec Bug 1386171 - log urls for synced tabs at trace level. r=eoger
MozReview-Commit-ID: 2veccAv2Bpn

--HG--
extra : rebase_source : 3487ad6937913c663bb81d7f6c99f1deca7d5af7
2017-08-11 14:26:29 +10:00
Edouard Oger 0943c36687 Bug 1210296 part 1 - Remove most event loop spinning from Sync. r=kitcambridge,markh,tcsc
MozReview-Commit-ID: 9RpgSgXykWt

--HG--
extra : rebase_source : 834df5b9b38a8332885a6c488f64215b550cad33
2017-06-05 18:50:07 -04:00
tiago 45fdbb5730 Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger
MozReview-Commit-ID: AciCTECtXJc

--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
2017-05-12 20:54:54 -03:00
Edouard Oger b3b3ff9cc5 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
Edouard Oger 1df337c9ce Bug 1361572 - Remove Task.jsm/Promise.jsm from services/. r=kitcambridge
MozReview-Commit-ID: BBIkpIkWIYc

--HG--
extra : rebase_source : a0f10b07bad20789e2d1c2c2bca133b32bf671aa
2017-05-02 19:29:33 -04:00
Sebastian Hengst 18253e3fa2 Backed out changeset 0a0138825fb5 (bug 1353571)
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
Edouard Oger c11e66021d Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
tiago c05723ef0c Bug 986501 - Avoid unnecessary compartments on Sync startup r=markh
MozReview-Commit-ID: 8Rr3JD4dfVy

--HG--
extra : rebase_source : b18f24229bbd1caf80d9f175a79c1fdb0aeccd0d
2017-04-13 20:36:08 -03:00
Florian Queze 4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst 159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst 738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze 3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Edouard Oger 54ace62c98 Bug 1244622 - Add "Show More/All" (tabs) buttons in the Synced Tabs menu. r=markh
MozReview-Commit-ID: 7z9fTVCDGgF

--HG--
extra : rebase_source : 99afed681759d8f65605f6c11a8b0c72e8012888
2017-02-06 16:31:31 -05:00
Jared Wein 7cb8b041fe Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : c6abc288124c1c47480cc73db8294195d8832fa2
2017-01-12 18:02:08 -05:00
Wes Kocher 20dc006d88 Backed out 14 changesets (bug 1330791) for various android failures a=backout
Backed out changeset eada8de7256f (bug 1330791)
Backed out changeset a3c656a9f3ca (bug 1330791)
Backed out changeset e0cbc754e841 (bug 1330791)
Backed out changeset 49d8016fab12 (bug 1330791)
Backed out changeset 53d4b83ccd22 (bug 1330791)
Backed out changeset b35cbfcd801f (bug 1330791)
Backed out changeset 25a6356de622 (bug 1330791)
Backed out changeset 46f9c247550d (bug 1330791)
Backed out changeset ef7356099bd3 (bug 1330791)
Backed out changeset a5fe483288db (bug 1330791)
Backed out changeset 4902107b7568 (bug 1330791)
Backed out changeset 5b2b2be2e389 (bug 1330791)
Backed out changeset 610ec89e98bb (bug 1330791)
Backed out changeset 631adda26a21 (bug 1330791)

MozReview-Commit-ID: GGUFW29U3TL
2017-01-17 17:06:36 -08:00
Jared Wein 42349d27b4 Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : 24dc56342d6b1a95df64c0c7c5a1819344cfe603
2017-01-12 18:02:08 -05:00
Jared Wein 65605f286e Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : cbfc8d4474b6c3d46eb21374e33fd3341403444f
2017-01-10 12:09:02 -05:00
Iris Hsiao 55313b4bc9 Backed out changeset 7e0a0bd74199 (bug 1330014) 2017-01-13 11:06:43 +08:00
Jared Wein 81cb5e57b9 Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : d783829bc7fced3044d0d076c4786a6957d29bb6
2017-01-10 12:09:02 -05:00
Sumit Tiwari ec358ae079 Bug 1292995 - Replace Iterator() with Object.{values,entries} in services/; r=gps
MozReview-Commit-ID: 3VEOjAJROld

--HG--
extra : rebase_source : 09102ed0ea8831adc1e6fd5973a290d16afcba03
2016-08-08 22:40:23 -04:00
Edouard Oger 78c5f8dca1 Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: LkGNdSF8Znm

--HG--
extra : transplant_source : qn%AA%7Ec%3AS%A7%A8%F4%E3%DE%00p%F7%00%3B%EC%1C%0C
2016-05-18 15:45:29 -07:00
Phil Ringnalda 74f134854f Back out e7c3a1d7ce27 (bug 1269348) on suspicion of causing failures in test_tab_store.js
CLOSED TREE
2016-05-17 23:20:47 -04:00
Edouard Oger 60cb7c8705 Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: GG34hPxDKcy
2016-05-17 14:15:32 -07:00