Граф коммитов

337 Коммитов

Автор SHA1 Сообщение Дата
Molly Howell 56e26df0c2 Bug 1790646 Part 2 - Switch to using the new string and remove the old one. r=pip-reviewers,fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D159290
2022-10-13 18:44:25 +00:00
Florian Quèze eb4bb28f8f Bug 1770947 - mark the associated browser inactive after closing a picture and picture window, r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D158791
2022-10-13 13:56:41 +00:00
Ben Hearsum 4ff2281d03 Bug 1791757: don't override PiP window icon for private browsing windows r=mconley
`nsWindow::Create` already sets this icon correctly for all Private Browsing windows (even `dialog` ones) - we need to make sure we're not overriding it.

I thought about tests for this, but ultimately the only change effected here is to a Windows HWND that we can't really verify anything on. We could (in theory anyways) mock out the call to `setWindowIconNoData` and check whether it was or was not called -- but I'm not sure if we typically do that for this sort of thing. I'd appreciate some guidance on this part.

Differential Revision: https://phabricator.services.mozilla.com/D158148
2022-10-04 14:41:46 +00:00
Mark Banner 8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner a9ba6e830d Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 21:47:50 +00:00
Marian-Vasile Laza 130adc5d9a Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner 3e99025d45 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 18:51:57 +00:00
Narcis Beleuzu 6c2d0d8cea Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner 05dcda5a7f Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 16:51:10 +00:00
Evan f71e1c1af2 Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157039
2022-09-23 18:11:48 +00:00
Ben Hearsum c71dcf9398 Bug 1791757: PiP windows opened by private browsing window use regular Firefox taskbar icon r=mconley
I didn't realize that PiP windows had taskbar icons when I dealt with the other chrome windows in https://bugzilla.mozilla.org/show_bug.cgi?id=1766636 -- the fix is essentially the same.

Differential Revision: https://phabricator.services.mozilla.com/D157849
2022-09-22 00:35:31 +00:00
Avery 0ddeec7e25 Bug 1788780 - Remove unused telemetry variables `lastScreenX` and `lastScreenY`. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D156479
2022-09-08 01:41:38 +00:00
janvi01 c39e6460d8 Bug 1779121 - Picture-in-Picture Seek buttons r=kpatenio,niklas,desktop-theme-reviewers,fluent-reviewers,sfoster,flod
Differential Revision: https://phabricator.services.mozilla.com/D152835
2022-09-01 18:33:10 +00:00
Janvi Bajoria 82a08acc5c Bug 1779127 - PIP fullscreen button r=kpatenio,niklas,desktop-theme-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152252
2022-08-11 17:08:17 +00:00
Janvi Bajoria 01898b809d Bug 1772339 - Hover states for PiP playback controls r=kpatenio,niklas,flod
Differential Revision: https://phabricator.services.mozilla.com/D149039
2022-08-03 13:46:20 +00:00
Mark Banner 7428be4a86 Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
kriswright ce99ca37e6 Bug 1781830 - Backout bug 1700674. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D153377
2022-08-01 17:10:24 +00:00
Florian Quèze 6d15c3f4b2 Bug 1742842 - Workaround known issues in tests that currently keep vsync enabled forever, r=mconley,webdriver-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D153204
2022-08-01 16:04:15 +00:00
Butkovits Atila 09b6bee447 Backed out 2 changesets (bug 1742842) for causing failures complaining about vsync. CLOSED TREE
Backed out changeset 82364f4b3520 (bug 1742842)
Backed out changeset b94a13888214 (bug 1742842)
2022-07-29 19:09:13 +03:00
Florian Quèze 2dcecd3dc8 Bug 1742842 - Workaround known issues in tests that currently keep vsync enabled forever, r=mconley.
Depends on D132055

Differential Revision: https://phabricator.services.mozilla.com/D153204
2022-07-29 15:31:19 +00:00
Tooru Fujisawa 54623364da Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Emilio Cobos Álvarez c84f2d6726 Bug 1765083 - Introduce FocusOptions.focusVisible. r=smaug,pip-reviewers
As per:

 * https://github.com/whatwg/html/issues/7830
 * https://github.com/whatwg/html/pull/8087

Replace the internal preventFocusRing with the new flag.

Differential Revision: https://phabricator.services.mozilla.com/D151326
2022-07-11 22:04:34 +00:00
Andreea Pavel 7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa 8cd6ed7409 Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa f3a8c52c53 Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Niklas Baumgardner 5489a7f8ad Bug 1778287 - Close subtitles settings panel when clicking PiP window for Windows. r=pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D151293
2022-07-08 20:51:21 +00:00
Niklas Baumgardner 7a5a191808 Bug 1778295 - Keep subtitles panel open when clicking button within. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D151142
2022-07-06 20:34:28 +00:00
Niklas Baumgardner f4a373dff5 Bug 1775040 - Hide subtitles button when video is emptied. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D150385
2022-07-06 17:30:29 +00:00
Niklas Baumgardner 7942504a18 Bug 1775043 - Hide subtitles setting panel when clicking on PiP window. r=pip-reviewers,mhowell
This only fixes the issue on macOS and Linux.

Differential Revision: https://phabricator.services.mozilla.com/D150802
2022-07-01 15:32:36 +00:00
Niklas Baumgardner 0e000cdf4c Bug 1775442 - Remove selection from subtitles settings panel when fullscreen change. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D150762
2022-06-30 21:14:33 +00:00
Niklas Baumgardner 0049c1fc67 Bug 1775334 - If subtitles settings is showing do not hide controls. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D150388
2022-06-30 14:41:59 +00:00
Molly Howell e53b4d427b Bug 1774688 - Update PIP explainer strings based on experiment results. r=pip-reviewers,fluent-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D150190
2022-06-23 22:25:04 +00:00
kriswright 4da0c6a7f8 Bug 1700674 - Add native full screen attribute to picture-in-picture r=pip-reviewers,mhowell
This adds the macos native fullscreen attribute to picture-in-picture windows so that when the pref is enabled, we view native fullscreen.

Depends on D149902

Differential Revision: https://phabricator.services.mozilla.com/D149903
2022-06-21 16:44:51 +00:00
Niklas Baumgardner c150518c01 Bug 1764120 - Subtitle font size settings in PiP window. r=pip-reviewers,desktop-theme-reviewers,mhowell,sfoster,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144754
2022-06-17 04:16:28 +00:00
criss 915e00a5a7 Backed out changeset c5ce4a2b9ddb (bug 1764120) for causing for causing mochitest failures on browser_fontSize_change.js. CLOSED TREE 2022-06-16 21:59:53 +03:00
Emilio Cobos Álvarez 6c24f16e7c Bug 1774495 - Avoid hitting minimum PiP width on Windows by using a smaller scale.
MANUAL PUSH: hopefully trivial orange fix CLOSED TREE
2022-06-16 20:41:42 +02:00
Niklas Baumgardner a64d340499 Bug 1764120 - Subtitle font size settings in PiP window. r=pip-reviewers,desktop-theme-reviewers,mhowell,sfoster,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144754
2022-06-16 17:49:35 +00:00
Emilio Cobos Álvarez 084ca332be Bug 1774495 - Fix PiP sliding calculations in HiDPI screens. r=mconley
This caused the test change in bug 1773813 to be backed out. I included the
test change here since it now covers both changes. Also, simplify some bits of
it a bit.

Differential Revision: https://phabricator.services.mozilla.com/D149447
2022-06-16 14:55:03 +00:00
Bogdan Szekely 916c5866ea Backed out changeset b616eb2e52ea (bug 1773813) for causing mochitest failures on browser_saveLastPiPLoc.js 2022-06-15 12:43:21 +03:00
Emilio Cobos Álvarez 63cf30a870 Bug 1773813 - Test. r=tnikkel,pip-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D149233
2022-06-15 08:17:59 +00:00
Karl Tomlinson 791c8f9b9b Bug 1745595 - wait for resize to complete before getting font size r=niklas
With https://phabricator.services.mozilla.com/D147728, this should also resolve
https://bugzilla.mozilla.org/show_bug.cgi?id=1766919 and
https://bugzilla.mozilla.org/show_bug.cgi?id=1766991

Differential Revision: https://phabricator.services.mozilla.com/D147730
2022-06-09 00:49:37 +00:00
Tooru Fujisawa 455845ee19 Bug 1772101 - Part 31: Use plain object for lazy getter in toolkit/components/pictureinpicture/. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D147972
2022-06-07 04:31:02 +00:00
Niklas Baumgardner eb0911cfc7 Bug 1768450 - Focus the window when PiP is fullscreened. r=pip-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D147211
2022-06-03 14:46:39 +00:00
Tooru Fujisawa c9c694b6b3 Bug 1610653 - Part 10: Do not use global this property assignment to define global variable in toolkit/components. r=Standard8,pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D144117
2022-05-30 15:19:39 +00:00
Katherine Patenio 419e2f8149 Bug 1764358 - remove pictureinpicture.move telemetry event. r=pip-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D145139
2022-05-03 20:49:21 +00:00
Mike Conley 71185850fb Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
Original patch by Guanlin Cheng <chenggu3@msu.edu>.

Differential Revision: https://phabricator.services.mozilla.com/D139742
2022-04-25 14:21:18 +00:00
Katherine Patenio c4f6478c5d Bug 1749795 - create documentation for adding and testing site-specific wrappers. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D142011
2022-04-22 20:46:11 +00:00
Hunter Jones 738d90142b Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D97847
2022-04-21 21:58:39 +00:00
Norisz Fay 88be59b607 Backed out 2 changesets (bug 1654054) for causing bc failures on browser_nimbusShowIconOnly.js
CLOSED TREE

Backed out changeset 2b6a67ada4d3 (bug 1654054)
Backed out changeset 2f9ad49eb131 (bug 1654054)
2022-04-21 22:53:22 +03:00