Tooru Fujisawa
a127747b14
Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D208979
2024-05-17 11:20:59 +00:00
Tamas Szentpeteri
86dcf9e3dc
Backed out 2 changesets (bug 1893402) for causing mochitest failures regarding nsGlobalWindowInner. CLOSED TREE
...
Backed out changeset e909b94c1280 (bug 1893402)
Backed out changeset beef636e1562 (bug 1893402)
2024-05-17 00:16:25 +03:00
Tooru Fujisawa
64388946b4
Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D208979
2024-05-16 15:40:41 +00:00
Randell Jesup
d542854faa
Bug 1356686 - Ensure that imgRequest::CheckListenerChain returns the correct value r=tnikkel
...
SVGs must be coded on MainThread because they need to access the LoadGroup,
etc, while other images can be decoded via the decode pool. This ensures
that CheckListenerChain() will return the right value for this instance.
Differential Revision: https://phabricator.services.mozilla.com/D203181
2024-03-19 17:27:23 +00:00
Sandor Molnar
a764c03b7c
Backed out 4 changesets (bug 1356686) for causing build bustages @ netwerk/protocol/http/HttpChannelChild.cpp CLOSED TREE
...
Backed out changeset 63dc52c69902 (bug 1356686)
Backed out changeset 6e9726c26d07 (bug 1356686)
Backed out changeset 3b150d676b31 (bug 1356686)
Backed out changeset 54754a50d992 (bug 1356686)
2024-03-19 08:29:08 +02:00
Randell Jesup
95c8ee2aa1
Bug 1356686 - Ensure that imgRequest::CheckListenerChain returns the correct value r=tnikkel
...
SVGs must be coded on MainThread because they need to access the LoadGroup,
etc, while other images can be decoded via the decode pool. This ensures
that CheckListenerChain() will return the right value for this instance.
Differential Revision: https://phabricator.services.mozilla.com/D203181
2024-03-18 20:04:01 +00:00
Sean Feng
539e32202b
Bug 1722322 - Implement LargestContentfulPaint r=emilio
...
Spec: https://w3c.github.io/largest-contentful-paint
Differential Revision: https://phabricator.services.mozilla.com/D151079
2023-11-02 20:53:36 +00:00
Sandor Molnar
a4163792c6
Backed out 7 changesets (bug 1722322) for causing bp-nu bustages
...
Backed out changeset 0ebd32e273b8 (bug 1722322)
Backed out changeset 7a75717f127c (bug 1722322)
Backed out changeset c2a6440a83d7 (bug 1722322)
Backed out changeset 9955756855bd (bug 1722322)
Backed out changeset 37fccb407777 (bug 1722322)
Backed out changeset f52b1f28f753 (bug 1722322)
Backed out changeset 0121c8cf5d2f (bug 1722322)
2023-11-02 21:27:24 +02:00
Sean Feng
611093989e
Bug 1722322 - Implement LargestContentfulPaint r=emilio
...
Spec: https://w3c.github.io/largest-contentful-paint
Differential Revision: https://phabricator.services.mozilla.com/D151079
2023-11-02 17:04:47 +00:00
sunil mayya
8ce40ef93d
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-27 13:30:11 +00:00
Narcis Beleuzu
722f6a1679
Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE
...
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
2023-10-24 13:16:40 +03:00
sunil mayya
1acfb3f11f
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-24 01:48:09 +00:00
Cristina Horotan
ea9336a2ca
Backed out 5 changesets (bug 1851992) for causing multiple failures
...
Backed out changeset d28399b3d947 (bug 1851992)
Backed out changeset 95e4df69007a (bug 1851992)
Backed out changeset fa61d4e76827 (bug 1851992)
Backed out changeset 79969d9eb5cd (bug 1851992)
Backed out changeset 03c17255f1af (bug 1851992)
2023-10-17 14:48:23 +03:00
sunil mayya
f350089afd
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-17 08:27:49 +00:00
Dan Robertson
2eb1b8240a
Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
...
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.
Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-28 03:56:57 +00:00
Butkovits Atila
d45dd05bf4
Backed out 2 changesets (bug 1655598) for causing Bug 1792435. a=backout
...
Backed out changeset 9eb3b3e7295b (bug 1655598)
Backed out changeset 052c6f05c623 (bug 1655598)
2022-09-27 12:37:10 +03:00
Dan Robertson
607672e1b4
Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
...
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.
Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-25 00:07:56 +00:00
Fabrice Desré
c50cb528fc
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
3ccd75af8d
Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD
2022-08-03 18:55:00 +03:00
Andreea Pavel
fdb7cb2ecd
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Andreea Pavel
89d63c91e6
Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE
2022-08-02 04:59:08 +03:00
Fabrice Desré
0f4ac7ad97
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Neil Deakin
6c927c11b6
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-06 10:00:52 +00:00
Noemi Erli
295eab376a
Backed out 14 changesets (bug 1746052) for causing build bustages in nsExternalHelperAppService.cpp CLOSED TREE
...
Backed out changeset bf46b0add531 (bug 1746052)
Backed out changeset 684b2aca10bb (bug 1746052)
Backed out changeset d4796eeeaf64 (bug 1746052)
Backed out changeset 5cf2378f6eb4 (bug 1746052)
Backed out changeset 2055ec1e9a57 (bug 1746052)
Backed out changeset 1398fc0669d2 (bug 1746052)
Backed out changeset 1f979899c843 (bug 1746052)
Backed out changeset 561a24801d4d (bug 1746052)
Backed out changeset 73e4689120f0 (bug 1746052)
Backed out changeset 9891f3b0229b (bug 1746052)
Backed out changeset 4c1ab30de0bd (bug 1746052)
Backed out changeset 108e14122e53 (bug 1746052)
Backed out changeset 1ee59c52578a (bug 1746052)
Backed out changeset 41fe77c5f4b2 (bug 1746052)
2022-05-05 23:13:33 +03:00
Neil Deakin
ffd18bceae
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-05 19:46:45 +00:00
Csoregi Natalia
7896e7e124
Backed out 13 changesets (bug 1746052) for causing failures on uriloader/exthandler/tests/. CLOSED TREE
...
Backed out changeset d19cc58e3cab (bug 1746052)
Backed out changeset 229edc158a2b (bug 1746052)
Backed out changeset b0ef7c68abcf (bug 1746052)
Backed out changeset 30de4b77f242 (bug 1746052)
Backed out changeset ebc6720fdab3 (bug 1746052)
Backed out changeset daccb796a093 (bug 1746052)
Backed out changeset 5b76d8d76b2b (bug 1746052)
Backed out changeset a698068d078f (bug 1746052)
Backed out changeset 73d17535d8d1 (bug 1746052)
Backed out changeset 94c95f004221 (bug 1746052)
Backed out changeset 1a389759585a (bug 1746052)
Backed out changeset c91230a8ea90 (bug 1746052)
Backed out changeset 7665f02c114e (bug 1746052)
2022-05-04 01:15:12 +03:00
Neil Deakin
976c5b23db
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-03 19:44:24 +00:00
Randell Jesup
12fddc66fd
Bug 1207753 - image thread-safety annotations r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D132641
2022-03-21 20:04:39 +00:00
Randell Jesup
fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
Randell Jesup
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
Randell Jesup
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Timothy Nikkel
6846d0c094
Bug 1755032. Fix data race on imgRequest::mInnerWindowId. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D138623
2022-02-14 10:00:40 +00:00
Emilio Cobos Álvarez
62550fa581
Bug 1709577 - Remove CORS_* constants from imgIRequest, use CORSMode instead. r=tnikkel
...
These don't have the same value, and is a bit confusing.
Differential Revision: https://phabricator.services.mozilla.com/D114352
2021-05-05 15:23:25 +00:00
Valentin Gosu
2756a257ad
Bug 1694662 - Remove appcache from imgRequest/imgLoader r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D106449
2021-04-30 07:20:21 +00:00
Sylvestre Ledru
bebb9f9181
Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
...
It is bringing some minor changes
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
Emilio Cobos Álvarez
6514cd85bf
Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel
...
This allows to print images that we'd otherwise reload.
Differential Revision: https://phabricator.services.mozilla.com/D85263
2020-07-30 08:55:24 +00:00
Honza Bambas
191a2becd0
Bug 1642140 - Image link-preloads: do not overprioritize, never set UrgentStart, always set LOAD_BACKGROUND, r=edgar,tnikkel+tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D77664
2020-06-02 20:28:30 +00:00
Timothy Nikkel
821ecf5a31
Bug 1640332. Move fields out of the bitfield that is accessed off main thread. r=aosmond
...
We don't access them off main thread so just move them out of the bitfield that is protected by the mutex.
Differential Revision: https://phabricator.services.mozilla.com/D76579
2020-05-26 02:06:00 +00:00
Edgar Chen
3f250fba44
Bug 1618295 - Make imgRequestProxy implement and use PreloaderBase to support the preload as speculative load feature; r=tnikkel,smaug,mayhemer
...
Depends on D72083
Differential Revision: https://phabricator.services.mozilla.com/D69860
2020-05-11 14:43:05 +00:00
Edgar Chen
40ade72706
Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D70387
--HG--
extra : moz-landing-system : lando
2020-04-10 21:14:49 +00:00
Noemi Erli
91e2985a09
Backed out changeset 27d94573975d (bug 1628727) for causing build bustages in imgRequest.cpp CLOSED TREE
2020-04-11 00:03:57 +03:00
Edgar Chen
4f03b7c3ce
Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D70387
--HG--
extra : moz-landing-system : lando
2020-04-10 00:00:12 +00:00
Chris Peterson
f749ec9f1f
Bug 1625828 - Replace MOZ_MUST_USE with [[nodiscard]] in image. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D68746
--HG--
extra : moz-landing-system : lando
2020-03-30 05:34:51 +00:00
Timothy Nikkel
c860a49663
Bug 1580820. Update the inner window id as well as the context (document) pointer on an imgRequest if we validate it for that document/inner window id. r=aosmond
...
If we just update the document pointer and not the inner window id then the request is unusable by any document since both the inner window id and the document pointer must match for it to be re-usable.
Differential Revision: https://phabricator.services.mozilla.com/D46121
--HG--
extra : moz-landing-system : lando
2019-09-17 13:16:19 +00:00
Thomas Nguyen
32ab8293ff
Bug 1528697 - Expose ReferrerPolicy.webidl and use referrerpolicy enum r=smaug
...
ReferrerPolicy gets tossed back and forth as a uint32_t and
ReferrerPolicy enum in header file. Expose ReferrerPolicyValues from
webidl file and use consistently in native code.
Differential Revision: https://phabricator.services.mozilla.com/D41954
--HG--
extra : moz-landing-system : lando
2019-08-21 13:24:45 +00:00
Tom Schuster
2c4cb96468
Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D41367
--HG--
extra : moz-landing-system : lando
2019-08-09 15:17:06 +00:00
Thomas Nguyen
db9e147a01
Bug 1566411 Use ReferrerInfo class in imgLoader.idl r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D38177
--HG--
extra : moz-landing-system : lando
2019-07-25 08:23:32 +00:00
Timothy Nikkel
64306c8162
Bug 1377457. Only apply locks to the image if SetHasImage has been called. r=aosmond
...
This was observed in an intermittent failure of image/test/mochitest/test_discardAnimatedImage.html. What happened was:
1) Document::MaybePreLoadImage was called for the images in the test.
2) imgRequest::OnDataAvailable is called on at least one of the images. This creates the RasterImage, so any proxy for this imgRequest will now return the image via GetImage(). imgRequest::OnDataAvailable also queues the FinishPreparingForNewPartRunnable back to the main thread to call OnImageAvailable on the progress tracker on the main thread.
3) We get the actual LoadImage calls for the images of the document. We create new proxies for the existing imgRequests. imgRequestProxy::Init calls mBehaviour->SetOwner(aOwner), which sets mOwnerHasImage to true because the progress tracker has an mImage (the one we created above).
4) We get a call to LockImage, this gets forwarded to the RasterImage because mOwnerHasImage is true and we can access the image.
5) The FinishPreparingForNewPartRunnable finally runs on the main thread. The OnImageAvailable notification from the progress tracker ends up in imgRequestProxy::SetHasImage. imgRequestProxy::SetHasImage applies our local count mLockCount to the RasterImage, even though we've already forwarded one of those LockImage calls to the image. LockImage calls are now unbalanced and the image will always remain locked.
The fix is simple. Only apply the Lock/Unlock calls if the FinishPreparingForNewPartRunnable has hit the main thread (ie ignore an image we can access until this happens).
Differential Revision: https://phabricator.services.mozilla.com/D29326
--HG--
extra : moz-landing-system : lando
2019-05-01 23:05:47 +00:00