Граф коммитов

97 Коммитов

Автор SHA1 Сообщение Дата
violet a524e7ef15 Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio
It turns out the `BuildPath()` method will still be exposed by DOM
API via `getTotalLength()`. So we need to fallback to `GetComputedStyleNoFlush()`
to handle display:none problem, and if the element doesn't even belong
to a document, we further fallback to 0.

`BuildPath()` being affected also means `GetStrokeWidth()`, etc. will also
be indirectly exposed to DOM API in some obscure cases. Let's add a utility
to handle the fallback.

Differential Revision: https://phabricator.services.mozilla.com/D33247

--HG--
extra : moz-landing-system : lando
2019-05-31 13:17:46 +00:00
violet d246402be3 Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr
Resolving length for inner <svg> is exactly the same as other ordinary
element. We should not pass the context to `GetAnimValue()`, otherwise
font-size will be obtained from the enclosing viewport of the inner
<svg> rather than the inner <svg> itself.

Differential Revision: https://phabricator.services.mozilla.com/D32657

--HG--
extra : moz-landing-system : lando
2019-05-27 06:46:53 +00:00
violet 92d63fc969 Bug 972041 - getCTM should account for CSS transform r=longsonr
We use nsSVGUtils::GetTransformMatrixInUserSpace to support
CSS transform in getCTM.

Differential Revision: https://phabricator.services.mozilla.com/D28969

--HG--
extra : moz-landing-system : lando
2019-04-27 08:42:51 +00:00
violet 510981c8fe Bug 1073207 - getScreenCTM should account for padding and border for outer svg r=longsonr
Differential Revision: https://phabricator.services.mozilla.com/D28488

--HG--
extra : moz-landing-system : lando
2019-04-23 18:15:57 +00:00
violet 60a266004c Bug 1342800 - ComputeSize should not treat iframe as object r=firefox-svg-reviewers,longsonr
We should not treat <iframe> as <object> for SVG, otherwise there will
be unexpected sizing and other webcompat problem (e.g. getScreenCTM).

It behaved correctly before, the change was introduced to solve a double
zooming problem (bug 843480) for <iframe>. Actually the zooming problem
can be solved by avoiding zooming when the window frame is an <iframe>.

Differential Revision: https://phabricator.services.mozilla.com/D28313

--HG--
extra : moz-landing-system : lando
2019-04-22 16:32:14 +00:00
Brian Grinstead 0d460e3432 Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27457

--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
violet a92c08d83f Bug 937268 - Should implement getBBox() for tspan r=longsonr
We implements getBBox for tspan. The implementation also has consistent
behavior as getBoundingClientRect.

Differential Revision: https://phabricator.services.mozilla.com/D27428

--HG--
extra : moz-landing-system : lando
2019-04-14 05:57:24 +00:00
Razvan Maries 32be493104 Backed out changeset ee2d5ba2854c (bug 937268) for perma fails on dom/svg/test/test_bbox.xhtml 2019-04-14 05:20:15 +03:00
violet c5fb22a443 Bug 937268 - Should implement getBBox() for tspan r=longsonr
We implements getBBox for tspan. The implementation also has consistent
behavior as getBoundingClientRect.

Differential Revision: https://phabricator.services.mozilla.com/D27428

--HG--
extra : moz-landing-system : lando
2019-04-13 14:48:13 +00:00
violet 2f70fdcb52 Bug 1426594 - Should convert rect from TransformFramePointToTextChild to device pixel r=longsonr
We need device pixel, but TransformFramePointToTextChild returns in css pixel,
thus a scaling is necessary.

Differential Revision: https://phabricator.services.mozilla.com/D27322

--HG--
extra : moz-landing-system : lando
2019-04-12 16:09:11 +00:00
Andreea Pavel f955a60145 Backed out changeset 78ed7f9d6566 (bug 1542530) for failing test_text_selection.html on a CLOSED TREE 2019-04-11 19:38:18 +03:00
Andrea Marchesini 07ce3681ac Bug 1542530 - Selection.toString() works correctly when text is selected together with a set of div+svg elements, r=mats
Differential Revision: https://phabricator.services.mozilla.com/D27064

--HG--
extra : moz-landing-system : lando
2019-04-11 14:13:24 +00:00
violet c0ca7d5cac Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr
We should use nsLayoutUtils::GetTransformToAncestor instead of
nsSVGUtils::GetUserToCanvasTM to get the transform matrix. Because the former
will also take CSS transform into account while the latter won't.

Differential Revision: https://phabricator.services.mozilla.com/D26441

--HG--
extra : moz-landing-system : lando
2019-04-08 04:39:23 +00:00
Narcis Beleuzu 8d78f21970 Backed out changeset 253e90f0ccf3 (bug 1541021) for mochitest failures on test_bounds.html 2019-04-07 19:50:14 +03:00
violet ea72deb0be Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr
We should use nsLayoutUtils::GetTransformToAncestor instead of
nsSVGUtils::GetUserToCanvasTM to get the transform matrix. Because the former
will also take CSS transform into account while the latter won't.

Differential Revision: https://phabricator.services.mozilla.com/D26441

--HG--
extra : moz-landing-system : lando
2019-04-07 14:11:39 +00:00
violet 38c5f25215 Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr
We also allow leading and trailing spaces for pair to be consistent with length,
number, etc.

Differential Revision: https://phabricator.services.mozilla.com/D25050

--HG--
extra : moz-landing-system : lando
2019-03-28 08:57:10 +00:00
Brindusan Cristian ddd1679c05 Backed out changeset 062344ad3eea (bug 1512745) for ESlint failure at test_pairParsing.html:31:5. 2019-03-28 08:56:08 +02:00
violet c51e044cf5 Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr
We also allow leading and trailing spaces for pair to be consistent with length,
number, etc.

Differential Revision: https://phabricator.services.mozilla.com/D25050

--HG--
extra : moz-landing-system : lando
2019-03-28 06:12:04 +00:00
championshuttler caa79f7f4b Bug 1508987 - Enable ESLint for dom/svg/ (Manual Changes). r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D22294

--HG--
extra : moz-landing-system : lando
2019-03-25 19:22:27 +00:00
championshuttler 9dc9ed699e Bug 1508987 - Enable ESLint for dom/svg/ (Automatic Changes). r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D22293

--HG--
extra : moz-landing-system : lando
2019-03-25 19:22:09 +00:00
violet 5cb2a2829c Bug 1512745 - Use nsWhitespaceTokenizer to ignore leading and trailing whitespace r=longsonr
Length attribute should allow leading and trailing whitespace per SVG2.

Differential Revision: https://phabricator.services.mozilla.com/D23628

--HG--
extra : moz-landing-system : lando
2019-03-27 08:52:33 +00:00
Emilio Cobos Álvarez f02f6a3545 Bug 1218257 - Use rust lengths for the SVG lengths. r=boris
As it turns out we need this to avoid losing precision both during painting and
during serialization.

This patch also changes to serialize `context-value` if it's the computed value.

I could keep the previous behavior, but it makes no sense to serialize the
initial value. We're the only ones to support this value anyway, and I couldn't
find a definition or spec for this.

Also update tests and expectations for:

 * New unexpected passes.
 * Always serializing the unit in getComputedStyle.
 * Calc and interpolation support.

Chrome also always serializes the unit in getComputedStyle, so I'm pretty sure
this is compatible with them. Chrome is inconsistent and keeps numbers in
specified style, but that's inconsistent with itself and with other quirky
lengths, so I updated the tests instead.

Differential Revision: https://phabricator.services.mozilla.com/D21819
2019-03-03 00:16:24 +01:00
longsonr 7072a2b798 Bug 1516551 - Part 2 rename nsSVGTransform to SVGTransform r=dholbert
--HG--
rename : dom/svg/nsSVGTransform.cpp => dom/svg/SVGTransform.cpp
rename : dom/svg/nsSVGTransform.h => dom/svg/SVGTransform.h
2018-12-29 09:15:40 +00:00
Tom Klein 4c5f52fbca Bug 1486952 - Update overflow on the correct svg frame(s) when the viewBox changes. r=jwatt
Bug 828240 switched the children only transform on an outer svg from applying to
each of the anonymous child's children to applying directly to the anonymous
child instead.  So now when the viewBox changes on an outer svg, we need to
update (just) the overflow of the anonymous child. The children only transform
on an inner svg still applies to the children of the inner svg, so we continue
updating those children in that case.

Hit testing uses overflows as part of the testing process, so was broken by the
lack of overflow updates.

Differential Revision: https://phabricator.services.mozilla.com/D5668

--HG--
extra : moz-landing-system : lando
2018-11-23 15:58:27 +00:00
Cosmin Sabou 1730bafe1d Backed out changeset 1c8f22180210 (bug 1486952) for mochitest failures on test_hit-testing-and-viewbox. CLOSED TREE 2018-11-21 18:57:56 +02:00
Tom Klein 416881eac9 Bug 1486952 - Update the overflow of the anonymous child when the viewBox changes. r=jwatt
Bug 828240 switched the children only transform from applying to each of the
anonymous child's children to applying directly to the anonymous child instead.
So now when the viewBox changes, we need to update (just) the overflow of the
anonymous child, where previously we were updating the overflows of each of the
children (which was having no effect I guess, since they no longer have the
child only transform applied to them).

Hit testing checks for hits using overflow, so was broken by the lack of
overflow update on the anonymous child (combined with the fact that the
anonymous child is now transformed by the children only transform).

Differential Revision: https://phabricator.services.mozilla.com/D5668

--HG--
extra : moz-landing-system : lando
2018-11-21 00:08:11 +00:00
Mark Banner b1c872942c Bug 1508980 - Add more .eslintrc.js files for dom/ and update .eslintignore. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D12529

--HG--
extra : moz-landing-system : lando
2018-11-21 14:27:27 +00:00
Julian Descottes 079a123093 Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 13:48:48 +00:00
Csoregi Natalia faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes b50a5ba4dc Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 11:09:48 +00:00
Robert Longson dad3e866c1 Bug 1396642 - support smaller viewBox coordinates at the expense of larger ones r=dholbert 2018-09-18 19:43:53 +01:00
Robert Longson 3116ab5e06 Bug 1479272 - remove svg.marker-improvements.enabled pref r=heycam 2018-07-31 21:45:29 +01:00
Robert Longson da1ac338dc Bug 1474284 - cope with degenerate bezier curves r=baz 2018-07-23 18:36:09 +01:00
Ting-Yu Lin 5f1b665033 Bug 1286882 - Make SVG basic shape elements unselectable. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D2038

--HG--
extra : moz-landing-system : lando
2018-07-13 18:01:48 +00:00
Daniel Holbert eb0a672707 Bug 1335266: In test_fragments.html, don't set iframe src attribute until *after* we've set up its load handler. r=longsonr
This will hopefully fix some intermittent timeouts that we're hitting in this
test. (The theory is that without this patch, maybe we're firing the iframe's
load event before we've set up the load handler.)

MozReview-Commit-ID: 183ogex73SX

--HG--
extra : rebase_source : a4daf9b87828725c25e728ad8bc86eb9004ca159
2018-03-21 10:50:19 -07:00
Robert Longson cfec2a2890 Bug 1446802 - use codespell -w -q4 to fix some spelling mistakes r=jwatt 2018-03-18 18:09:51 +00:00
Robert Longson 46c74e15ed Bug 1443685 - GetPointAtLength should not take into account the pathLength attribute r=dholbert 2018-03-09 04:35:37 +00:00
Masayuki Nakano cf83ee7bb4 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T

--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
2018-02-15 04:15:39 +09:00
Jonathan Watt 843da70a1a Bug 1436438 part 1 - Remove the tests that test SVG path data DOM interfaces. r=longsonr
MozReview-Commit-ID: 78yzAb6Khf1
2018-01-26 10:39:11 +00:00
Robert Longson c4391552bc Bug 1435568 - Remove SVGUnitTypes values from elements r=jwatt r=bkelly (DOM Peer) 2018-02-06 21:35:34 +00:00
Hiroyuki Ikezoe 8c0001196d Bug 1415787 - Wait for focus before proceeding test. r=daoshengmu
To process focus handling deterministic, we need to wait for focus before
proceeding test.

MozReview-Commit-ID: 78EWlA3QuWM

--HG--
extra : rebase_source : 6473b0e1d364f9d3f8a5c43f82ee25be54a478bf
2017-12-21 10:49:06 +09:00
Hiroyuki Ikezoe 1f9e96c9dc Bug 1415787 - Add two extra elements in the SVG element to avoid losing focus. r=daoshengmu
On MacOSX, more precisely if full keyboard access is not enabled on MacOSX,
we skip focusing link elements in SVG with tab key, so if there is no more
elements to be focused in the SVG, the focus will be moved outside the SVG.
To prevent this situation, there needs more focusable elements in the SVG.

MozReview-Commit-ID: HGGMjA0Asfw

--HG--
extra : rebase_source : 5f4b951f6dfcb7572cc947744365b0609d6c92f1
2017-12-21 10:49:05 +09:00
Robert Longson de99e463ac Bug 1420492 - avoid division by zero when constructing an nsSVGArcConverter r=dholbert 2017-12-10 22:43:23 +00:00
Jonathan Watt 4130888dfd Bug 1342951, part 4 - Add a version of SVGTextFrame::GetSubStringLength that can be used independantly of reflow, to avoid sync reflows. r=heycam
MozReview-Commit-ID: CJqUwF3rXP4
2017-09-02 22:22:54 +01:00
Sebastian Hengst 444f7c3600 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-08-31 14:39:13 +02:00
Jonathan Watt f7d98d6559 Bug 1395512 - Make dom/svg/test/test_text_2.html produce useful and non-inverted error messages. r=jfkthame
MozReview-Commit-ID: KJHRBmbbuBq
2017-08-10 12:47:20 +01:00
cku db228b8c69 Bug 1361639 - Part 2. Add test cases of calling getBBox on use element in test_bbox.xhtml. r=longsonr+218550
MozReview-Commit-ID: B2DetAVcQM6

--HG--
extra : rebase_source : 04d0eb757f22334def4389af5ffd9908af04d9d1
2017-08-30 11:22:43 +08:00
Robert Longson f055bf18d2 Bug 1369904 - Bounding box should not include control points. r=lsalzman 2017-06-14 06:34:01 +01:00
Dan Banner cdf987089d Bug 1107904 - Remove packed.js and references to it as it is unused. r=standard8
MozReview-Commit-ID: K5TLF92pHq4

--HG--
extra : rebase_source : 295bf325a07fa8ec4c55a8babf5418588308dca6
2017-04-12 11:10:00 +01:00
Aryeh Gregor b03daa975a Bug 1314388 - Remove SVGZoomEvent; r=longsonr,smaug
Some code in SVGSVGElement.cpp might be unnecessary now, but Robert said
to leave it for a followup.

MozReview-Commit-ID: 8PpRGeGrREJ
2017-04-04 15:36:22 +03:00