b5913e0b3d
Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : eeba14d732077ef2e412f4caca852de6b6b85f55
2015-02-02 14:48:58 -08:00
f325953043
Bug 1050035 (part 3) - Remove PL_NewDHashTable() and PL_DHashTableDestroy(). r=froydnj.
...
Because they are now just equivalent to |new PLDHashTable()| +
PL_DHashTableInit() and PL_DHashTableFinish(t) + |delete t|, respectively.
They're only used in a handful of places and obscure things more than they
clarify -- I only recently worked out exactly how they different from Init()
and Finish().
--HG--
extra : rebase_source : c958491447523becff3e01de45a5d2d227d1ecd3
2015-02-01 20:36:52 -08:00
3163cfc2c1
Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
...
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.
For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.
I'll do the trickier ones in subsequent patches.
--HG--
extra : rebase_source : ab37a7a30be563861ded8631771181aacf054fd4
2015-01-22 21:06:55 -08:00
097aa5a98e
Bug 1124973 (part 1) - Always use inheritance rather than composition for PLDHashTable entries. r=froydnj.
...
Because (a) this is how it's usually done, (b) it allows static_cast<> instead
of reinterpret_cast<>, and (c) it will make subsequent patches easier.
--HG--
extra : rebase_source : 76e67d4b6ec0e5dc898a8214b6a6b562f9e08380
2015-01-22 21:05:52 -08:00
8bd1f6f072
Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
...
This encapsulates most of the uses of PLDHashTable::ops.
--HG--
extra : rebase_source : 7760ce8e46a37e87dcfe590e809a21df01fe510f
2015-01-19 16:11:34 -08:00
bd573c9b9c
Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
...
Currently the setting of PLDHashTable::ops is very haphazard.
- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
null it themselves.
- In the fallible PLDHashTable::Init() function, if the entry storage
allocation fails we'll be left with a table that has |ops| set -- indicating
it's been initialized -- but has null entry storage. I'm not certain this can
cause problems but it feels unsafe, and some (but not all) callers of Init()
null it on failure.
- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
do this themselves.
This patch makes things simpler.
- It adds a constructor that zeroes |ops|.
- It modifies Init() so that it only sets |ops| once success is ensured.
- It zeroes |ops| in Finish().
- Finally, it removes all the now-unnecessary |ops| nulling done by the users
of PLDHashTable.
--HG--
extra : rebase_source : bb34979c218d152562a2f9c7e5215256c111cc5b
2015-01-19 16:01:24 -08:00
69fe655b04
Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
...
--HG--
extra : rebase_source : bc119bd0d3b6944e8c5a000950e0c4052cb70aef
2015-01-14 14:35:56 -08:00
e39f0adeca
Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
...
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
e9735966fa
Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
2015-01-14 14:35:56 -08:00
47221bc7f9
Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj.
...
--HG--
extra : rebase_source : b14dda8cdd5cd896d1e32950e38b2a9f7da4d99e
2015-01-13 19:02:35 -08:00
c7538c9776
Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
...
--HG--
extra : rebase_source : 24d10af3dbce3ada5252503bc80bb1a4e31bc1c9
2015-01-13 16:42:13 -08:00
ba8d4930bd
Bug 1120262 - Use new PL_DHashTable{Add,Remove} functions. r=nfroyd
2015-01-11 18:30:25 -06:00
aa7a06d2bb
Bug 1119257 - Mark virtual overridden functions as MOZ_OVERRIDE in rdf; r=bsmedberg
2015-01-12 16:31:45 -05:00
08eb0b4c91
Bug 1118415 - Mark virtual overridden functions as MOZ_OVERRIDE in rdf; r=bsmedberg
2015-01-12 16:30:33 -05:00
54b8e4e5e4
Bug 1110469 - Remove NS_OpenURI (r=sworkman)
2015-01-11 20:26:40 -08:00
411a94b05a
Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd
2015-01-05 20:27:28 -06:00
bc9f04611f
Bug 1116558 - Remove the code to handle shutdown-cleanse from the RDF code; r=bsmedberg
...
shutdown-cleanse has not been a thing for quite a while.
2015-01-02 17:54:35 -05:00
249ac81315
Bug 1110031 - Part 1: Mark more directories as FAIL_ON_WARNINGS. r=gps
2014-12-10 22:56:31 -08:00
e424225899
Bug 1107814 - Part 2: Mark some directories as FAIL_ON_WARNINGS conditionally for some compilers. r=gps
2014-12-04 01:11:14 -08:00
47c853314f
Bug 1077148 part 4 - Add and use new moz.build templates for Gecko programs and libraries. r=gps
...
There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.
Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.
Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.
2014-10-30 13:06:12 +09:00
cd2a7562b5
Bug 1063197 - Callsites of NS_NewInputStreamChannel in /rdf/ (r=bsmedberg)
2014-10-16 11:17:14 -07:00
d292ee73f1
Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester
2014-10-07 18:18:28 -04:00
f6b3cb92f9
Bug 1038756: Callsites creating a channel in /rdf/ (r=bsmedberg)
2014-09-21 09:44:27 -07:00
68de320099
Bug 1062529 - Split GetChannelPrincipal into GetChannelResultPrincipal and GetChannelURIPrincipal. r=bz
2014-08-06 16:05:40 -07:00
ed70c5f377
Bug 1041941 - Use templates for programs, simple programs, libraries and C++ unit tests. r=gps
2014-09-03 14:10:54 +09:00
486ea17099
Bug 1061049 - Fix some bad impliciti constructors in RDF; r=bsmedberg
...
--HG--
extra : rebase_source : 9a7ebf75d2f780b161602ceb6aecfdfe758f024d
2014-09-02 18:21:23 -04:00
d75ed5bf7f
bug 1059490 - mark more classes MOZ_FINAL r=froydnj
2014-08-27 14:26:48 -04:00
df1c26a45e
Bug 1057912 - Privatize most of PLDHashTable's fields. r=roc.
...
--HG--
extra : rebase_source : 0f55e70b63d9c191fbd9418cb1177ff534deeed9
2014-08-25 16:56:33 -07:00
c2e4425290
Bug 1057224 - Pass actual class name for rdf ctor counting. r=froydnj
...
We want to enforce valid names in these macros, so we need
to use a valid type name here.
2014-08-21 22:41:00 -07:00
68b266f440
Back out 2f60f94d4d3c and d06c2e71aca2 for cross-platform breakage.
2014-08-22 15:13:03 -07:00
fb07854a7d
Bug 1057224 - Pass actual class name for rdf ctor counting. r=nfroydnj
...
We want to enforce valid names in these macros, so we need
to use a valid type name here.
2014-08-21 22:41:00 -07:00
a7cf4142b4
Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
...
* * *
imported patch rm-dummy-params
--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
2014-08-06 06:31:21 -07:00
89777800f9
Bug 1047267 - Move remaining OS_LIBS and EXTRA_LIBS to moz.build. r=gps
...
* * *
Bug 1047267 - To fold with "Move remaining OS_LIBS and EXTRA_LIBS to moz.build"
2014-08-07 14:21:03 +09:00
f2ee770232
Bug 1048435: Stop RDF from whining at shutdown. r=mccr8
2014-08-04 16:51:20 -07:00
12c76f15f7
Bug 1042878 - part 2 - move MOZ_CAIRO_CFLAGS et al additions to C*FLAGS into moz.build; r=glandium
2014-07-24 11:55:33 -04:00
5f6ba110e6
Bug 1043802 - Remove TOOLS_DIRS and TEST_TOOLS_DIRS. r=gps
2014-07-29 08:55:55 +09:00
7cab62150a
Bug 1041936 part 2 - Directly use the static library "xul" to link into "xul-gtest" instead of having an intermediate library "xul" used by "xul-shared" and "xul-gtest". r=gps
2014-07-23 13:33:09 +09:00
95063176fa
Bug 1036894 part 9 - Replace all EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS with EXTRA_LIBS, OS_LIBS or OS_LDFLAGS, appropriately. r=gps
...
OS_LIBS for libraries that are not part of the gecko tree, EXTRA_LIBS for
libraries, such as NSPR, that are in the tree, but are not handled by
moz.build just yet. Those EXTRA_LIBS may also come from a system library.
However, in cases where the expanded variables are always empty for the
in-tree case, OS_LIBS is used (as for, e.g. MOZ_ZLIB_LIBS). OS_LDFLAGS is
used exclusively for non-library linker flags.
Always pass EXTRA_LIBS before OS_LIBS on linker command lines.
Forbid EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS in Makefiles.
2014-07-23 13:31:02 +09:00
5fab42fcaf
Bug 1036894 part 8 - Move most in-tree library linkage information to moz.build, as USE_LIBS. r=gps
2014-07-23 13:30:52 +09:00
622bf09730
Bug 1041864 - Remove LIBRARY_NAMEs that aren't used. r=mshal
2014-07-23 08:39:56 +09:00
bc5d6801bb
Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal
2014-07-23 08:37:51 +09:00
2864f7996a
Bug 1040774 - Flatten rdf/{base,datasource,util}/{idl,public,src}/ directories. r=pike
...
--HG--
rename : rdf/base/src/nsCompositeDataSource.cpp => rdf/base/nsCompositeDataSource.cpp
rename : rdf/base/src/nsContainerEnumerator.cpp => rdf/base/nsContainerEnumerator.cpp
rename : rdf/base/src/nsDefaultResourceFactory.cpp => rdf/base/nsDefaultResourceFactory.cpp
rename : rdf/base/idl/nsIRDFCompositeDataSource.idl => rdf/base/nsIRDFCompositeDataSource.idl
rename : rdf/base/idl/nsIRDFContainer.idl => rdf/base/nsIRDFContainer.idl
rename : rdf/base/idl/nsIRDFContainerUtils.idl => rdf/base/nsIRDFContainerUtils.idl
rename : rdf/base/public/nsIRDFContentSink.h => rdf/base/nsIRDFContentSink.h
rename : rdf/base/idl/nsIRDFDataSource.idl => rdf/base/nsIRDFDataSource.idl
rename : rdf/base/idl/nsIRDFDelegateFactory.idl => rdf/base/nsIRDFDelegateFactory.idl
rename : rdf/base/idl/nsIRDFInMemoryDataSource.idl => rdf/base/nsIRDFInMemoryDataSource.idl
rename : rdf/base/idl/nsIRDFInferDataSource.idl => rdf/base/nsIRDFInferDataSource.idl
rename : rdf/base/idl/nsIRDFLiteral.idl => rdf/base/nsIRDFLiteral.idl
rename : rdf/base/idl/nsIRDFNode.idl => rdf/base/nsIRDFNode.idl
rename : rdf/base/idl/nsIRDFObserver.idl => rdf/base/nsIRDFObserver.idl
rename : rdf/base/idl/nsIRDFPropagatableDataSource.idl => rdf/base/nsIRDFPropagatableDataSource.idl
rename : rdf/base/idl/nsIRDFPurgeableDataSource.idl => rdf/base/nsIRDFPurgeableDataSource.idl
rename : rdf/base/idl/nsIRDFRemoteDataSource.idl => rdf/base/nsIRDFRemoteDataSource.idl
rename : rdf/base/idl/nsIRDFResource.idl => rdf/base/nsIRDFResource.idl
rename : rdf/base/idl/nsIRDFService.idl => rdf/base/nsIRDFService.idl
rename : rdf/base/idl/nsIRDFXMLParser.idl => rdf/base/nsIRDFXMLParser.idl
rename : rdf/base/idl/nsIRDFXMLSerializer.idl => rdf/base/nsIRDFXMLSerializer.idl
rename : rdf/base/idl/nsIRDFXMLSink.idl => rdf/base/nsIRDFXMLSink.idl
rename : rdf/base/idl/nsIRDFXMLSource.idl => rdf/base/nsIRDFXMLSource.idl
rename : rdf/base/src/nsInMemoryDataSource.cpp => rdf/base/nsInMemoryDataSource.cpp
rename : rdf/base/src/nsNameSpaceMap.cpp => rdf/base/nsNameSpaceMap.cpp
rename : rdf/base/src/nsNameSpaceMap.h => rdf/base/nsNameSpaceMap.h
rename : rdf/base/src/nsRDFBaseDataSources.h => rdf/base/nsRDFBaseDataSources.h
rename : rdf/base/src/nsRDFContainer.cpp => rdf/base/nsRDFContainer.cpp
rename : rdf/base/src/nsRDFContainerUtils.cpp => rdf/base/nsRDFContainerUtils.cpp
rename : rdf/base/src/nsRDFContentSink.cpp => rdf/base/nsRDFContentSink.cpp
rename : rdf/base/src/nsRDFContentSinkAtomList.h => rdf/base/nsRDFContentSinkAtomList.h
rename : rdf/base/src/nsRDFService.cpp => rdf/base/nsRDFService.cpp
rename : rdf/base/src/nsRDFService.h => rdf/base/nsRDFService.h
rename : rdf/base/src/nsRDFXMLDataSource.cpp => rdf/base/nsRDFXMLDataSource.cpp
rename : rdf/base/src/nsRDFXMLParser.cpp => rdf/base/nsRDFXMLParser.cpp
rename : rdf/base/src/nsRDFXMLParser.h => rdf/base/nsRDFXMLParser.h
rename : rdf/base/src/nsRDFXMLSerializer.cpp => rdf/base/nsRDFXMLSerializer.cpp
rename : rdf/base/src/nsRDFXMLSerializer.h => rdf/base/nsRDFXMLSerializer.h
rename : rdf/base/public/rdf.h => rdf/base/rdf.h
rename : rdf/base/idl/rdfIDataSource.idl => rdf/base/rdfIDataSource.idl
rename : rdf/base/idl/rdfISerializer.idl => rdf/base/rdfISerializer.idl
rename : rdf/base/idl/rdfITripleVisitor.idl => rdf/base/rdfITripleVisitor.idl
rename : rdf/base/src/rdfTriplesSerializer.cpp => rdf/base/rdfTriplesSerializer.cpp
rename : rdf/base/src/rdfutil.cpp => rdf/base/rdfutil.cpp
rename : rdf/base/src/rdfutil.h => rdf/base/rdfutil.h
rename : rdf/datasource/src/nsFileSystemDataSource.cpp => rdf/datasource/nsFileSystemDataSource.cpp
rename : rdf/datasource/src/nsFileSystemDataSource.h => rdf/datasource/nsFileSystemDataSource.h
rename : rdf/datasource/public/nsILocalStore.h => rdf/datasource/nsILocalStore.h
rename : rdf/datasource/public/nsIRDFFTP.h => rdf/datasource/nsIRDFFTP.h
rename : rdf/datasource/src/nsLocalStore.cpp => rdf/datasource/nsLocalStore.cpp
rename : rdf/datasource/src/nsRDFBuiltInDataSources.h => rdf/datasource/nsRDFBuiltInDataSources.h
rename : rdf/util/src/Makefile.in => rdf/util/Makefile.in
rename : rdf/util/src/internal/moz.build => rdf/util/internal/moz.build
rename : rdf/util/src/nsRDFResource.cpp => rdf/util/nsRDFResource.cpp
rename : rdf/util/public/nsRDFResource.h => rdf/util/nsRDFResource.h
rename : rdf/util/src/objs.mozbuild => rdf/util/objs.mozbuild
2014-07-21 06:01:08 -07:00
d3f990ebdb
Bug 1040639 - Remove LIBS_DIR. r=mshal
2014-07-19 08:42:16 +09:00
54e47bf9de
Bug 1039161 - Remove rdf/tests/dsds. r=pike
2014-07-17 08:42:17 +09:00
1465e09a99
Bug 1037691 - Fix instances where refcounted classes expose a public destructor. r=ehsan,bent,mayhemer,jrmuizel
2014-07-15 11:37:45 -04:00
5a785eea6e
Bug 1028588 - Fix dangerous public destructors in rdf/ - r=bsmedberg
2014-06-30 18:11:50 -04:00
03da42e8b1
Backed out 4 changesets (bug 1028588) for build bustage
...
Backed out changeset 13a8bae671ca (bug 1028588)
Backed out changeset 19a19833f1d6 (bug 1028588)
Backed out changeset d5fae80054de (bug 1028588)
Backed out changeset 5942ad3859b8 (bug 1028588)
2014-06-30 15:50:19 -07:00
1068a93726
Bug 1028588 - Fix dangerous public destructors in rdf/ - r=bsmedberg
2014-06-30 18:11:50 -04:00
bb7664bd5c
Bug 1029981 - Observers should use MOZ_UTF16 to compare someData. r=nfroyd
2014-06-27 17:08:13 +09:00
a39cee4de3
Bug 741295 - Treat 'id' and 'class' as global attributes for all elements; r=bz
2014-05-30 09:36:53 +02:00
085f40aff8
Bug 869836 - Part 11: Use `Append('c')` instead of `AppendLiteral("c")`. r=ehsan
...
--HG--
extra : rebase_source : 08bcbfd804f1adcab40c7d59fa56deda1f6e0829
2014-05-26 21:54:58 +03:00
59b969f7f4
Bug 869836 - Part 8: Use `Append('c')` instead of `Append("c")`. r=ehsan
2014-05-22 06:48:52 +03:00
aea8617b92
Bug 869836 - Part 7: Use AppendLiteral instead of Append where possible. r=ehsan
2014-05-22 06:48:51 +03:00
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
7ac92ae5ea
Bug 900903 - Part 2: Change uses of numbered macros in nsCycleCollectionParticipant.h to the variadic variants. r=smaug
2014-04-25 12:49:00 -04:00
a7c5bc888a
Bug 996911. Make nsIDOMXUL*Element not inherit from nsIDOMXULElement, so we can make the latter noscript. r=smaug
2014-04-16 15:13:41 -04:00
fc018b8633
bug 987624 - ensure the nsRDFLog variable is declared if logging is enabled. r=bsmedberg
2014-03-31 11:53:07 +01:00
fe6c4e28d6
Bug 967364: Rename already_AddRefed::get to take. r=bsmedberg
2014-03-15 12:00:15 -07:00
0353960345
Bug 962608 - Make PL_DHashTableInit infallible by default. r=briansmith,bsmedberg,ehsan,froydnj,jduell,jfkthame,roc,smaug
2014-02-27 10:04:09 -08:00
73b8879e45
Bug 973142 - Get rid of the MOZILLA_INTERNAL_API makefile variable; r=glandium
...
It's just as easy to directly set the preprocessor macro in the moz.build
files. Using this variable doesn't really buy us anything.
This patch also removes unused code from rdf/tests/dsds.
2014-02-18 01:56:51 -05:00
620929b4d0
NO BUG - Fix sorted moz.build failure in rdf/tests/dsds/moz.build; r=me
2014-02-17 16:46:22 -08:00
56341318f9
Bug 772828 - Part b: use RESOURCE_FILES in moz.build instead of manual rules in Makefile.in; r=mshal
2013-11-05 13:37:54 -05:00
d91d200572
Bug 969757 - Remove the dead code in our tree which pretends to support OS/2; r=roc,mcmanus,gps,jorendorf,bsmedberg sr=bsmedberg
2014-02-10 17:57:01 -05:00
0a2389925b
Bug 957442: Drop "register" keyword from rdf/base/src/nsInMemoryDataSource.cpp since it's deprecated in C++11 and clang warns about it. r=bsmedberg
2014-01-08 09:00:50 -08:00
44ea965711
Bug 956449: Remove unused variable in ~RDFXMLDataSourceImpl() to fix build warning. r=bsmedberg
2014-01-06 11:33:36 -08:00
1b83407ce9
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
561cae4a0e
Bug 950130 - Move more INCLUDES / LOCAL_INCLUDES to moz.build; r=mshal
2013-12-31 10:06:11 +01:00
d43c55ca0e
bug 949821 - use MOZ_UTF16 more and NS_LITERAL_STRING less r=froydnj
2013-12-12 20:50:01 -05:00
9166bcd03a
Backed out changesets 5b48376ee2d8 and 2f478d634f23 (bug 943023) for bustage on a CLOSED TREE.
2013-12-10 15:25:55 -05:00
0421ca62bb
bug 943023 - unify some of toolkit/components/ and clean up the unification of rdf/ a tad r=ehsan
2013-11-25 14:28:06 -05:00
68b00083fd
Bug 713082 - Part 1: Remove unnecessary Util.h includes. r=Waldo
2013-12-08 21:52:33 -05:00
0ed28cd2b7
Bug 944961 - Build rdf in unified mode. r=bsmedberg
2013-11-30 21:42:59 -08:00
2fb3a52db7
Backed out changeset 58dbd2146e24 (bug 944961) for bustage.
2013-12-03 18:47:39 -05:00
31aa387350
Bug 944961 - Build rdf in unified mode. r=bsmedberg
...
--HG--
extra : rebase_source : 02d0dda613da55539f8fdb69ffd8c03e576e5ce9
2013-11-30 21:42:59 -08:00
919a5b3c9b
Bug 945245 - Fixed misc char16_t/wchar_t mismatches. r=ehsan
...
--HG--
extra : rebase_source : fcab74b295b513f4185cf9c12f31ebaddb7c8e0e
2013-12-03 16:09:50 +01:00
ae9e2ec930
Back out d84bce4e8f2c (bug 943023) because of build errors on a CLOSED TREE
2013-11-25 15:59:01 -08:00
87cdf162a3
bug 943023 - unify some of toolkit/components/ and rdf/ r=ehsan
2013-11-25 14:28:06 -05:00
1cdb070dd9
Bug 940170 - part 4 - constify PLDHashTableOps in miscellaneous other places; r=bz
2013-11-18 21:58:27 -05:00
2812d11fce
Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps
...
Landing on a CLOSED TREE.
2013-11-19 11:50:54 +09:00
e06d795c71
Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps
2013-11-19 11:48:10 +09:00
26bc04d200
Bug 939044 - Rename remaining MODULE definitions to XPIDL_MODULE. r=mshal
2013-11-19 11:47:43 +09:00
e80e877ab7
Bug 939044 - Remove most definitions of MODULE. r=mshal
2013-11-19 11:47:39 +09:00
ffe0380912
Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps
2013-11-19 11:47:14 +09:00
3dcc53299a
Bug 937526 - Cleanup unicharutil/util and rdf/util related things. r=gps
2013-11-16 13:37:54 +09:00
f6366dd338
Bug 935789, part 1: Kill most uses of prbit.h, r=ehsan
...
--HG--
extra : rebase_source : 4c44e60c72e0ece3cea7ed1cf79079bd2a1b6487
2013-11-12 18:22:38 -06:00
50e2fd01b1
Bug 935387 - Remove non recursed install targets. r=mshal
2013-11-07 10:37:45 +09:00
d2f6b7333c
Bug 914270 - Part 1: Simple/Automated moves. r=joey
2013-10-24 18:51:00 +01:00
b000a846c2
Bug 929905 - Consolidate sources in moz.build. r=gps
2013-10-25 08:23:05 +09:00
59a17d0f20
Bug 921492 - Make StrictOrderingOnAppendList use actual alphabetical sorting. r=mshal,r=gps
2013-10-24 08:05:43 +09:00
ae54ebd4e0
Bug 928046 - Remove the prtypes.h inclusion from rdfutil.h; r=bsmedberg
...
--HG--
extra : rebase_source : 196e5fee3215a32e7a13e1507fdc81ead89e72da
2013-10-18 20:34:57 -04:00
f4153f40d4
Bug 900980 - Part a: Move unconditional assignments to EXPORT_LIBRARY to moz.build; rs=gps
2013-10-03 09:11:13 +02:00
7bd3c0ae36
Bug 901990 - Part 2: Upgrade xpcshell manifests; r=ted
...
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell-unpack/head_unpack.js => toolkit/mozapps/extensions/test/xpcshell/head_unpack.js
2013-09-24 11:50:08 -07:00
f093a0dd48
Bug 914272 - Move IS_COMPONENT to mozbuild. r=joey
2013-09-19 17:29:32 -04:00
18d895f774
Bug 917086 - Disallow DIRS, PARALLEL_DIRS and TEST_DIRS under TOOL_DIRS and TEST_TOOL_DIRS, and adapt moz.build files accordingly. r=gps
...
Also mark TOOL_DIRS/TEST_TOOL_DIRS directories in backend.mk and recurse them normally instead of forcing make -C dir libs for them.
2013-09-19 07:43:02 +09:00
916782e929
Bug 865673 - Convert objs.mk to objs.mozbuild. r=gps
2013-08-30 09:09:06 -04:00
03e7828db2
Bug 910989. Remove nsTHashtable::Init, fallible allocation, and MT hashtables. r=ehsan,bsmedberg
...
--HG--
extra : rebase_source : 0787130b1814c74bfb38dc178de94022f0b2e64e
2013-09-02 20:41:57 +12:00
f8bc7fa754
Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps
2013-09-05 09:01:46 +09:00
e7b3869729
Bug 911428 - Fix -Wunused-variable warning in rdf/datasource/src/nsFileSystemDataSource.cpp. r=bsmedberg
2013-08-12 23:35:07 -07:00
3a103a7e9f
Bug 883284 - Part f: Move LIBXUL_LIBRARY into moz.build (p-z); r=glandium
2013-08-22 08:56:01 +02:00
a4ae239c93
Bug 901898 - Remove codesighs now that it's no longer run in automation; r=gps
2013-08-12 13:10:41 +01:00
e62a12b52f
bug 886526 - remove IS_COMPONENT and MODULE_NAME makefile vars for things in libxul r=bsmedberg r=glandium
2013-08-08 20:12:37 -04:00
2e729aa83d
Bug 881323 - Re-implement CycleCollectorParticipant with actual vtables, with constexpr to avoid static initializers. r=mccr8
2013-08-02 10:29:05 +09:00
521d66d83e
Bug 784739 - Switch from NULL to nullptr in storage/; r=ehsan
2013-07-31 11:44:58 -04:00
d467009d81
Bug 784739 - Switch from NULL to nullptr in rdf/; r=ehsan
2013-07-31 11:44:03 -04:00
108b7dd046
backout bug 886526 because it probably made us use a lot more memory to link on windows
2013-07-29 11:03:21 -04:00
bf89d8e11b
Bug 884061 - Part 3r: Use NS_DECL_THREADSAFE_ISUPPORTS in rdf/, r=bsmedberg
...
--HG--
extra : rebase_source : febfbb36e1c2bccf21f888e133f1e03451823b53
2013-07-18 21:24:14 -05:00
9edee6c454
Bug 895168 - Part 5: Stop using LL_EQ in the tree; r=jcranmer
...
--HG--
extra : rebase_source : 520ca54a0c974395d9b42c773686c66d46962d1c
2013-07-18 16:50:31 -04:00
513b1e2bf6
Bug 895168 - Part 1: Stop using LL_I2L in the tree; r=jcranmer
...
--HG--
extra : rebase_source : b66b363de4c4e132ef94181d2b7d8f008caa643a
2013-07-18 16:47:55 -04:00
b97d1767fc
Bug 892904 - Remove useless includes of config.mk. r=gps
2013-07-15 18:48:40 +09:00
f33ade0d68
bug 887483 - remove a bunch of useless assignments to FORCE_STATIC_LIB implied by LIBXUL_LIBRARY=1 r=mshal
2013-07-11 11:06:34 -04:00
b002b30b2a
bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan
...
--HG--
extra : rebase_source : 2a3b22425c14d6daedc91d62a652c34431acd2fb
2013-07-09 13:30:58 -04:00
4fda35a773
bug 886526 - disallow MODULE_NAME and IS_COMPONENT for makefiles in libxul r=bsmedberg
2013-06-25 11:15:21 -04:00
1a9e38cc24
Bug 888323 - Stop including prtime.h in nsrootidl.idl. r=ehsan
2013-07-04 00:56:26 +09:00
1d99822149
Backed out changeset d155557b651c (bug 888323) for bustage.
...
CLOSED TREE
2013-07-02 14:15:39 -04:00
c9b73ddb89
Bug 888323 - Stop including prtime.h in nsrootidl.idl. r=ehsan
2013-07-03 02:08:01 +09:00
11bcc1cd9e
Bug 875934 - Move LIBRARY_NAME to moz.build (batch #1 ); r=mshal
...
--HG--
extra : rebase_source : 385d3fd65475ffc18ee44ae088753649470e214b
2013-06-17 15:21:01 -04:00
5169c0a913
Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey CLOSED TREE
...
From 9e0ba7f425143f545eb6c4b26a9a96b5ade4d8e9 Mon Sep 17 00:00:00 2001
2013-04-23 17:54:15 -04:00
1b12175ba0
Bug 873629 - Remove 129 empty Makefile.in files; r=ted
2013-05-17 16:20:11 -07:00
0b00dc2f2d
Bug 873038 - Remove the old MSVC PGO exclusions across the tree; r=glandium
2013-05-16 11:16:30 -04:00
45c0af14f9
Bug 331566 - Change idl interfaces to use @throws instead of @return NS_. r=bsmedberg
2013-05-16 08:26:55 -04:00
26736a0ee2
bug 869143: phase2 cleanup for XPCSHELL_TEST conversion. r=mshal
2013-05-13 16:24:07 -04:00
8d90859ddb
Bug 862986 - Part 2a: Migrate PROGRAM from Makefile.in to moz.build. r=gps
2013-05-01 14:05:40 -04:00
cad945d3a7
Bug 824338 Fix typo in warning message in nsRDFXMLDataSource.cpp. r=Neil DONTBUILD as this doesn't change code.
2013-05-01 09:49:14 +01:00
8dd4074205
Backed out changesets c7937fb5f4bb and cf8db9b6bd61 (bug 862986) for bustage.
...
CLOSED TREE
2013-04-30 21:09:41 -04:00
7422d5ac7b
Bug 862986 - Part 2: Migrate PROGRAM from Makefile.in to moz.build. r=gps
2013-04-30 20:46:10 -04:00
b6cc74b921
Backed out changesets 64c7ba1d3d04 and 7e9d5bb4a9af (bug 862986) for test failures.
2013-04-30 10:08:38 -04:00
0baa2a32d6
Bug 862986 - Part 2: Migrate PROGRAM from Makefile.in to moz.build. r=gps
2013-04-30 09:08:31 -04:00
321d063783
bug 844655: Port XPCSHELL_TESTS to moz.build as XPCSHELL_TESTS_MANIFESTS
2013-04-29 14:49:00 -04:00
f0404a303a
Bug 859817 - Remove implicit conversions from raw pointer to already_AddRefed; r=Ms2ger
2013-04-22 14:15:59 +03:00
9c1f94b576
Bug 859817 - Make NS_NewAtom return already_AddRefed; r=bz
2013-04-22 14:13:22 +03:00
df7deac25b
Bug 846634 - Part 2: Move EXPORTS to moz.build; r=joey
2013-04-16 15:24:43 -04:00
839310031c
Bug 856238 - Remove unused includes of the obsolete nsISupportsArray and nsIEnumerator. r=Neil, r=bsmedberg
2013-04-08 14:35:31 -04:00
b0d7171a54
Bug 856455 - Make nsCOMArray::SetCapacity return void; r=bsmedberg
...
--HG--
extra : rebase_source : 38cdef904f9b7fc33bd3f41bd19b1778dfbd7990
2013-03-31 16:06:18 -04:00
72a717a860
Bug 855465 - Add emacs python mode comments to moz.build files; r=gps
2013-04-01 11:36:59 -07:00
43628a7867
Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot
2013-03-29 15:12:58 -07:00
334c0800cf
Bug 855465 - Add emacs python mode comments to moz.build files; r=gps
...
--HG--
extra : rebase_source : 004a756492323e1a049586e85b3be5037159df20
2013-03-29 13:56:18 -07:00
e3efc3a646
Bug 852534 - Remove GRE_MODULE from Makefile.in; r=gps
2013-03-21 08:41:00 -07:00
89e86f9b21
Bug 844654 - Part 3: Remove now empty Makefile.in files; rs=khuey
...
--HG--
extra : rebase_source : 8de9c7f68a953e574dda22f8c14c2b2ca60444f9
2013-03-19 18:49:07 -07:00
7ecea60097
Bug 844654 - Part 2: Move MODULE to moz.build; rs=gps
2013-03-19 11:47:00 -07:00
7d09ff18e0
Bug 844635 - Part 3: Remove empty Makefile.in files; r=glandium
2013-03-17 18:01:25 -07:00
de55b5242b
Merge mozilla-central into build-system
...
dom/interfaces/svg/Makefile.in and dom/media/Makefile.in had merge
conflicts. They were resolved by hand. The former needed 2 IDLs removed.
The latter had a context conflict for EXPORTS_NAMESPACES.
2013-03-12 13:04:55 -07:00
c865547d94
Bug 818246 - Part 4: Move XPIDLSRCS into moz.build (auto); rs=glandium
...
This is the result of running
|mach mozbuild-migrate --list XPIDLSRCS SDK_XPIDLSRCS XPIDL_SOURCES| and
reverting xpcom/sample/*.
2013-03-12 10:17:46 -07:00
4177a8b753
Bug 847248 (part 4) - Remove all uses of nsFixedSizeAllocator from rdf/. r=bz.
...
--HG--
extra : rebase_source : 0b8c23f48155ef89972452a74682283d2191d02c
2013-03-04 01:16:19 -08:00
5a169442b0
Bug 784841 - Part 18γ: Convert /rdf; r=glandium
2013-02-25 12:47:24 -08:00
c1b3c1ac36
Fix for bug 839529 (Remove various CC participants that don't do anything). r=smaug.
...
--HG--
extra : rebase_source : 8a272905c79396e7ae08aaaf83566ac450c45be0
2013-02-07 10:19:08 +00:00
618e5c1da4
Bug 819936 trivial followup: remove completely-unused 'nsresult rv' in InMemoryDataSource::GetAllResources. (DONTBUILD because just re-landing w/ fixed bug number)
2013-01-29 14:30:12 -08:00
3c58cf52af
backout 2620d0977696 because it landed w/ wrong bug number
2013-01-29 14:35:54 -08:00
525add8767
Bug 822289 trivial followup: remove completely-unused 'nsresult rv' in InMemoryDataSource::GetAllResources.
2013-01-29 14:30:12 -08:00
841f65e139
Bug 833099 - Disable PGO on rdf; a=me
2013-01-21 23:18:37 -05:00
b8998c4f77
Backed out changeset 2254b555a0af (bug 833099) because of PGO bustage
2013-01-21 18:34:34 -05:00
2de81b3441
Bug 833099 - Stop doing PGO on rdf; r+a=me
2013-01-21 17:21:09 -05:00
83bcbe0d6b
bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8
2013-01-12 07:40:33 -05:00
4ad1b6649d
Backed out changeset 66a7359f9be2 (bug 791546) because it broke the build
2013-01-03 18:36:16 -05:00
25d2ca6bd4
Bug 791546: Removes nsCRT::strcmp(const PRUnichar* s) from nsCRT.h and replaces it occurrences with NS_strcmp; r=bsmedberg
2012-12-24 08:47:18 +05:30
5a35c9fff1
bug 819936 - remove NS_NewArrayEnumerator overload for nsISupportsArray r=bz, bsmedberg
2012-12-09 05:04:21 -05:00
54792f2e4d
bug 820182 - remove nsISupportsArray::ElementAt() uses r=ehsan
2012-12-11 11:16:42 -05:00
c2eb04641e
bug 801466 - part 5 uriloader/ and rdf/ r=ehsan
2012-12-01 19:57:25 -05:00
986ee1a065
Bug 807437 - Eliminate redundant Traverse/Unlink CC macros - part 1: automatic changes - r=mccr8
2012-11-15 02:32:40 -05:00
6058811463
Bug 802706: Remove usage of NSPRFormatTime.h from tree; r=ehsan
2012-11-14 13:14:21 -06:00
ab48da6035
Backed out changeset da25394a8b55 (bug 802706) for build bustage
2012-11-14 13:24:12 -08:00
12202e6725
Bug 802706: Remove usage of NSPRFormatTime.h from tree; r=ehsan,wtc
2012-11-14 13:14:21 -06:00
d21a5d8004
Bug 792581 - part 23: Replace LL_INIT and LL_UDIVMOD macros. r=ehsan
2012-11-01 20:57:25 -04:00
ad50b9e765
Bug 795511: Removed usages of PR_BIT and PR_BITMASK from the tree; r=ehsan
2012-10-20 07:31:43 +05:30
9a21ea4912
Bug 794510: Part 6 - Fixups needed to build on Windows and Android and Mac OS X debug, plus shorten comment to be less than 80 columns; r=ehsan
2012-10-18 15:55:48 -04:00
220c75c473
Bug 794510: Part 3 - create NSPRFormatTime.h with temporarily undef'd NO_NSPR_10_SUPPORT for compatibility; r=ehsan
2012-10-11 13:16:29 -05:00
f99ff81019
Bug 801803 - nsresult as enum class creates warnings in test files r=ehsan
2012-10-15 17:12:50 -04:00
3ca8d029a6
Bug 792581 - part 16: Replace LL_L2UI macro with uint32_t cast. r=ehsan
2012-10-12 13:29:11 -04:00
ea5e17dc9c
Bug 792581 - part 15: Replace LL_L2I macro with int32_t cast. r=ehsan
2012-10-12 13:29:10 -04:00
2280fd1640
Bug 792581 - part 14 - Replace LL_SHL, LL_SHR, LL_USHR macros with bitwise operators. r=ehsan
2012-10-12 13:29:10 -04:00
d371ac7c39
Bug 792581 - part 11: Replace LL_MUL macro with multiplication operator. r=ehsan
2012-10-05 01:05:28 -04:00
ceaa3c8f60
Bug 792581 - part 9: Replace LL_ADD with mathematical plus operator. r=ehsan
2012-10-05 01:05:27 -04:00
ef64b29578
Bug 792581 - part 7 - Remove LL_AND macro with logical AND. r=ehsan
2012-10-05 01:05:27 -04:00
6f2fa28373
Bug 792581 - part 2: Replace LL_EQ macro with standard relation. r=ehsan
2012-10-03 10:13:18 -04:00
481e7dfb0b
Bug 791906: Replace NSPR integer limit constants with stdint ones; r=ehsan
2012-09-28 01:57:33 -05:00
1356f06137
Bug 784912 - nsIStreamListener.onDataAvailable should handle 64-bit offset. r=honza
2012-09-06 11:41:02 +09:00
65539ef89c
Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg
2012-09-01 22:35:17 -04:00
ab140edff0
Bug 785738 Part 4: Use PRTime where appropriate under rdf/. r=ehsan
2012-08-30 09:10:40 +02:00
3f08ff498e
Bug 785738 Part 3: use PRTime instead of int64_t where appropriate; r=ehsan
2012-08-30 09:10:35 +02:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
01a802da01
Bug 341604 - modify CheckMayLoad to allow sandboxed workers to load blob and data URIs r=jst
2012-08-20 11:34:33 -07:00
1dfc6b12e2
Bug 782614 - Don't return nsresult from main() (rdf/); r=bsmedberg
2012-08-07 20:17:27 +03:00
19d06abdb4
Bug 772272 - Remove do_load_httpd_js from xpcshell tests, Misc Folders, r=ted
...
Content, DOM, Image, JS, RDF, and URILoader folders
2012-08-14 10:06:17 -04:00
4e199a1679
Bug 780618 - Move all error codes to nsError.h; r=ehsan
2012-07-27 17:03:27 +03:00
15daadba69
Bug 215450: Allow uploading of files greater than 2gb in size. Involves making input streams 64-bit capable. Significant work done by Makoto Kato, finished by Honza Bambas. r=hbambas,bsmedberg,jdrew,sicking
2012-08-10 22:44:11 -04:00
5f4593aa2e
Bug 780387 - Part e: Stop using PRSize; r=bsmedberg
2012-08-09 09:10:11 +02:00
70d7c821af
Bug 774032 bonus - Use @DEPTH@ and @relativesrcdir@ in Makefile.in. r=ted
2012-08-04 20:26:44 +02:00
c81630fddb
Bug 777292 - Convert incorrect conversions to nsresult and fix named constants; r=ehsan
2012-07-27 16:59:29 +03:00
3ad40dbf10
Merge the nullptr conversion from mozilla-central into mozilla-inbound
2012-07-30 10:28:15 -04:00
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
587e4453db
Bug 777292 - Don't use |= on nsresult; r=ehsan
2012-07-27 17:03:08 +03:00
c5ea8e4936
Bug 772759 - Fix a few build warnings r=bsmedberg
2012-07-12 22:11:05 -07:00
d2ee12f6f9
Bug 763350 - Clean up some includes in content/ and dom/ r=smaug
2012-07-01 16:45:59 -07:00
970e60a384
Bug 767388 - Kill NS_DEBUG. r=bz.
...
--HG--
extra : rebase_source : d045208a26345712dbb4628c973c616cd9504f28
2012-06-25 20:59:42 +01:00
4e5eecb03d
Bug 763987 - Normalize autoconf.mk.in. r=ted
2012-06-20 09:00:48 +02:00
a93eb5a48f
Backout changeset 6984dace6afb (bug 763987) because of OSX opt jsreftest bustage
2012-06-20 10:55:59 +02:00
cd69374e33
Bug 763987 - Normalize autoconf.mk.in. r=ted
2012-06-20 09:00:48 +02:00
039891f691
Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (rdf parts); r=bsmedberg
...
--HG--
extra : rebase_source : f6017aa79ed6e43e1d5b3cd78854c25945726602
2012-06-12 23:42:36 -04:00
5cefea8480
Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=bsmedberg
2012-06-06 14:08:30 +12:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
eaa4878487
Bug 734847 part 2 - treewide changes resulting from the default-infallibility of hashtables; either remove useless result checks, or use the fallible version of APIs, depending on context, r=jlebar
...
--HG--
extra : rebase_source : 844b008c5167e6ca39a7ba9eeec8b30672938704
2012-05-18 13:30:49 -04:00
Nicholas Nethercote
Phil Ringnalda
Michael Pruett
Ehsan Akhgari
Christoph Kerschbaumer
Chris Peterson
Mike Hommey
Andrew Halberstadt
Trevor Saunders
Ralph Giles
Kyle Huey
Nathan Froyd
Birunthan Mohanathas
Benoit Girard
Benoit Jacob
Wes Kocher
Makoto Kato
Ms2ger
Boris Zbarsky
Jonathan Kew
Andrew McCreight
Gregory Szorc
Brian O'Keefe
Daniel Holbert
Ryan VanderMeulen
Jacek Caban
Matt Brubeck
Joshua Cranmer
Cykesiopka
Robert O'Callahan
Ed Morley
Olli Pettay
Masatoshi Kimura
Mike Shal
Maria Grazia Alastra
Joey Armstrong
ISHIKAWA, Chiaki
Aryeh Gregor
aceman
Kyle Machulis
Peter Van der Beken
Shriram Kunchanapalli
Isaac Aggrey
Andrew Quartey
Abhishek Potnis
Brian Smith
David Zbarsky
Randell Jesup
Landry Breuil
Ian Melven
Mark Capella
Honza Bambas
Jonathan Watt
Geoff Lankow
Gervase Markham
Benjamin Smedberg