On macOS, access keys are not visually observable.
On Linux and Windows, access keys are underlined.
Moreover, if intl.menuitems.alwaysappendaccesskeys is set, the access
key is always appended as "(X)", optionally preceded by a space, where X
is the uppercased version of the access key.
This commit updates the logic to not append a new "(X)" if this expected
suffix is already present at the end of the label.
Differential Revision: https://phabricator.services.mozilla.com/D3996
--HG--
extra : moz-landing-system : lando
the Mingw Clang build failed because a 3-argument form of wcstok could not
be found, despite it apparently being part of the C++ standard. Multiple
forms of header files were tried.
By comparison, wcstok_s is already used (e.g. widget/windows/WinUtils.cpp)
and does the correct thing. So change the functions over to that one.
Differential Revision: https://phabricator.services.mozilla.com/D4568
--HG--
extra : moz-landing-system : lando
The "menu-button" notification button type is unused, and the "menu" type is implemented using a normal button that opens a popup.
Differential Revision: https://phabricator.services.mozilla.com/D4530
--HG--
extra : rebase_source : b662ec12f98bbb6841aaf4682393bb0e29830e73
When `document.blockParsing()` is called, the nsIParser is suspended
until the document is unblocked. For about:blank documents, this is a
nsParser.
When a document is unblocked, nsParser::ContinueInterruptedParsingAsync
is invoked, which delegates its implementation to nsIContentSink, which
is a nsHTMLContentSink for about:blank documents. Due to a missing
implementation of nsHTMLContentSink::ContinueInterruptedParsingAsync,
the parser was never resumed, causing bug 1465388 and bug 1407501.
This patch fixes the problem, by implementing the required method (and
using a load blocker to ensure that the (about:blank) document does not
finish before the parser finishes).
This patch is tested through extension tests: Currently document_start
stylesheets always activate the parser blocker, and document_start
scripts trigger the parser blocker when the script has not been
preloaded yet (e.g. at the first run).
Before this patch, the test failed due to the assertion failure as
reported in the linked bugs. After this patch, the tests pass.
Differential Revision: https://phabricator.services.mozilla.com/D4352
--HG--
extra : moz-landing-system : lando
In the MinGW browser build job, we're going to use -fms-extensions,
which will tell clang to start processing these comments. Clang
cannot process them correctly (it's an upstream bug) but it doesn't
need to, because we include the libs we need in moz.build files.
So we exclude them for MinGW builds. mingw-clang gets them wrong and
mingw-gcc (which doesn't even work anymore on -central) ignored them.
In the future, with a llvm fix, we could clean up the moz.build
files and re-enable these comments.
Differential Revision: https://phabricator.services.mozilla.com/D3527
--HG--
extra : moz-landing-system : lando
libprio does not currently build with MSVC (since it only supports
C90 as a compiler), this is being worked on upstream at https://github.com/mozilla/libprio/issues/17
As we are almost certainly not going to ship Firefox build with MSVC anymore,
let's disable this to get it working on this Tier-2 platform.
Differential Revision: https://phabricator.services.mozilla.com/D4292
--HG--
extra : moz-landing-system : lando
Narcis Beleuzu
Brian Hackett
Mark Banner
shindli
arthur.iakab
Rob Wu
Arshad Kazmi
Tom Ritter
Carl Corcoran
Cosmin Sabou
Paolo Amadini
Alexander Surkov
Sebastian Hengst
Hiroyuki Ikezoe
Mike Hommey
Ehsan Akhgari
Margareta Eliza Balazs
Andreea Pavel
Ciure Andrei
Gijs Kruitbosch
Tiberius Oros
Robert Helmer