2116ab605f
Bug 1123151 (part 3) - Make PLDHashTable::ops private. r=froydnj.
...
This required adding a getter and a setter, but they're used sparingly.
--HG--
extra : rebase_source : 2a40e459de2a7a9e2bb6d65b046e4a920b212326
2015-01-19 16:34:44 -08:00
8bd1f6f072
Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
...
This encapsulates most of the uses of PLDHashTable::ops.
--HG--
extra : rebase_source : 7760ce8e46a37e87dcfe590e809a21df01fe510f
2015-01-19 16:11:34 -08:00
bd573c9b9c
Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
...
Currently the setting of PLDHashTable::ops is very haphazard.
- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
null it themselves.
- In the fallible PLDHashTable::Init() function, if the entry storage
allocation fails we'll be left with a table that has |ops| set -- indicating
it's been initialized -- but has null entry storage. I'm not certain this can
cause problems but it feels unsafe, and some (but not all) callers of Init()
null it on failure.
- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
do this themselves.
This patch makes things simpler.
- It adds a constructor that zeroes |ops|.
- It modifies Init() so that it only sets |ops| once success is ensured.
- It zeroes |ops| in Finish().
- Finally, it removes all the now-unnecessary |ops| nulling done by the users
of PLDHashTable.
--HG--
extra : rebase_source : bb34979c218d152562a2f9c7e5215256c111cc5b
2015-01-19 16:01:24 -08:00
6c486b0407
bug 1122100 - more MOZ_OVERRIDE in xpcomish stuff r=froydnj
2015-01-19 17:41:12 -05:00
fa5c39586f
Bug 1123121 - Mark all nsCOMPtr_helper classes as stack class; r=froydnj
2015-01-19 12:39:36 -05:00
955c49cc4a
Bug 1123009 - Make nsAppDirectoryEnumerator::mProvider an nsCOMPtr; r=froydnj
2015-01-19 12:38:17 -05:00
44e588d41b
Bug 1123006 - Mark FileData as stack class, and its data member as nsCOMPtr; r=froydnj
2015-01-19 12:37:48 -05:00
c2883dc571
Bug 1123003 - Clarify the ownership of xptiInterfaceInfo pointers in xptiprivate.h; r=froydnj
2015-01-19 12:37:07 -05:00
0c1e071a73
Bug 1123000 - Mark nsDiscriminatedUnion::mInterfaceValue as owning; r=froydnj
2015-01-19 10:00:33 -05:00
4f8f88a90d
Bug 1122999 - Mark the fOuter member defined by NS_DECL_AGGREGATED as unsafe; r=froydnj
2015-01-19 10:00:32 -05:00
f555db9bc7
Bug 1122991 - Mark findIndexOfClosure as stack class, and make its targetElement member a void*; r=froydnj
2015-01-19 10:00:32 -05:00
f1d08feef9
Bug 1122990 - Mark nsPropertiesParser as stack class, and make its mProps member a strong ref; r=froydnj
2015-01-19 10:00:31 -05:00
cfc3bde8b2
Bug 1123109 - Mark nsStaticAtom::mStringBuffer as non-owning; r=froydnj
2015-01-19 09:05:44 -05:00
f0e632186b
Bug 1123098 - Mark two members of nsCOMPtr_helper classes as non-owning; r=froydnj
2015-01-19 09:04:27 -05:00
614625066f
Bug 1122996 - Convert nsSupportsArrayEnumerator::mArray into an nsCOMPtr; r=froydnj
2015-01-19 09:03:56 -05:00
0cc0ba6ab4
Bug 1122995 - Clarify the lifetime rules applying to the permanent and non-permanent nsIATOM* members in nsAtomTable.cpp; r=froydnj
2015-01-19 09:03:10 -05:00
4302209514
Bug 1122986 - Mark nsQueryElementAt::mCollection as non-owning; r=froydnj
2015-01-19 09:00:25 -05:00
3bf8f8296a
Bug 1122989 - Remove nsIPersistentProperties::Subclass(); r=froydnj
...
This method is unused, and more importantly it causes us to store an
unsafe reference in nsPersistentProperties. It's best to remove it.
2015-01-19 08:59:01 -05:00
abb0caed63
Bug 1119006 - Remove files where code is still calling removed NS_OpenURI API (r=mcmanus)
2015-01-14 11:52:57 -08:00
aa32fa615f
Bug 1123110 - Clarify the ownership of several cycle collector members; r=mccr8
2015-01-18 18:43:02 -05:00
f561749154
Bug 1121826 - backout cc192030c28f - brackets shouldn't be automatically escaped in the Query r=mcmanus
2015-01-17 16:13:21 +02:00
5f39b00c79
Bug 1120047 - Fix glibc version check guards for and importing of __libc_stack_end. r=glandium
2015-01-17 15:02:01 +11:00
3337f70861
Bug 1122303 - nsIProcess::Run needs to handle EINTR on Mac (r=nfroyd)
2015-01-16 09:57:33 -08:00
78a7dc7fe9
Bug 1121202 - Add Lookup, Add, and Remove methods to PLDHashTable. r=njn
2015-01-15 18:01:28 -06:00
a58d13d7ba
Bug 1121202 - Remove unused PL_DHashTableOperate function. r=njn
2015-01-15 18:01:07 -06:00
e9788e3d05
Bug 1121829 - Support redirection of kernel32.dll for hooking function. r=dmajor
2015-01-16 23:07:09 +09:00
a479e9ccad
Bug 1121830 - DMD: add "num" property to blocks in the output. r=mccr8.
...
The new "num" property lets identical blocks be aggregated in the output. This
patch only uses the "num" property for dead blocks, because that's where the
greatest potential benefit lies, but it could be used for live blocks as well.
On one test case (a complex PDF file) running with --mode=cumulative
--sample-below=1 this patch had the following effects.
- Change in running speed was negligible.
- Compressed output file size dropped from 8.8 to 5.0 MB.
- Compressed output file size dropped from 297 to 50 MB.
- dmd.py runtime (without stack fixing) dropped from 30 to 8 seconds.
--HG--
extra : rebase_source : 46a32058cd5c31cd823fe3f1accb5e68bcd320f3
2015-01-15 20:38:38 -08:00
059cf96c41
Bug 1122337 - Mark DMD directories as FAIL_ON_WARNINGS. r=glandium.
...
The DEFINES and XPCOM_API changes are needed to get rid of "inconsistent dll
linkage" warnings on Windows builds.
--HG--
extra : rebase_source : 00756f51ebee85c70f65d51dbac17b4835262697
2015-01-15 21:17:18 -08:00
2e11419734
Bug 1060696 - Remove nsISupportsObsolete.h. r=froydnj
2015-01-16 07:34:51 +02:00
2f07a9ef3a
Bug 1060696 - Remove NS_INIT_ISUPPORTS. r=froydnj
2015-01-16 07:34:46 +02:00
da7c43b26b
Bug 1121451 - Fix 'truncation of constant value' warnings in nsINIParser.cpp. r=froydnj
2015-01-16 07:34:42 +02:00
5b86ecf80c
bug 1077549 - remove useless gcc version checks r=glandium
2015-01-15 21:30:05 -05:00
69fe655b04
Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
...
--HG--
extra : rebase_source : bc119bd0d3b6944e8c5a000950e0c4052cb70aef
2015-01-14 14:35:56 -08:00
27ab169068
Bug 1121304 (part 1, attempt 2) - Minor type clean-ups for PLDHashTable. r=froydnj.
...
--HG--
extra : rebase_source : cccc747bf900804a566853d8eb7f16cf82a26978
2015-01-14 14:35:45 -08:00
6a93d5c443
Bug 1107953 part 5. Add tests for promise rejections with content-side DOMExceptions, and fix the promise code so those tests actually pass. r=bholley
2015-01-15 17:39:02 -05:00
54e2e84910
Bug 1008091 - send network change events on FxOS and Linux, r=sworkman
2015-01-15 00:22:00 +01:00
e39f0adeca
Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
...
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
e9735966fa
Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
2015-01-14 14:35:56 -08:00
41dc319a7c
Bug 1121304 (part 1) - Minor type clean-ups for PLDHashTable. r=froydnj.
2015-01-14 14:35:45 -08:00
47221bc7f9
Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj.
...
--HG--
extra : rebase_source : b14dda8cdd5cd896d1e32950e38b2a9f7da4d99e
2015-01-13 19:02:35 -08:00
c7538c9776
Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
...
--HG--
extra : rebase_source : 24d10af3dbce3ada5252503bc80bb1a4e31bc1c9
2015-01-13 16:42:13 -08:00
ea66053341
Bug 1119776, Part 7: Avoid defining snprintf when MSVC provides it (other), r=bsmedberg
...
--HG--
extra : rebase_source : 3fc7e4e83f57252e15cf32846f23e497f8532ea5
2015-01-08 22:35:33 -08:00
56a443b1c1
Bug 1097452 - Use fallible allocation when setting the value of an <input> or <textarea> element; r=jst,froydnj
...
This patch handles most of the call sites for these allocations except
for a few where I added TODO comments with some information. Handling
those places may require reworking lots of code, so I prefer to not do
that here.
2015-01-14 17:31:41 -05:00
805b38ff92
Merge m-c to fx-team a=merge
2015-01-13 17:47:46 -08:00
36b059df69
bug 1096718 - - display time measured spent in each compartment r=billm,mossop
2015-01-13 17:38:05 -08:00
90455437ca
Bug 1120198 part 1 - Introduce nsTHashtable::SwapElements for a fast way to swap the elements of two hashtables. r=nfroyd
2015-01-13 14:44:33 +00:00
b988734748
Bug 1115061 - Ignore calls to BackgroundHangMonitor::Notify{Activity,Wait} when Telemetry is disabled. r=froydnj
2015-01-13 06:41:15 +02:00
7769fa7760
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2015-01-12 15:33:37 -05:00
bf312ad056
Bug 1120062 - Part 1: Remove most Nullptr.h includes. r=waldo
2015-01-11 11:34:52 +09:00
c2e9cb1c30
Bug 1113416 - Don't read stack labels inside hang monitor sighandler; r=nfroyd r=snorp
...
When we're inside the hang monitor's signal handler, we must not read any string labels. Doing so may result in on-demand decompression kicking in on Android, which may result in a deadlock.
2015-01-10 12:41:48 -05:00
Nicholas Nethercote
Trevor Saunders
Ehsan Akhgari
Christoph Kerschbaumer
Valentin Gosu
Cameron McCormack
Bill McCloskey
Michael Pruett
Makoto Kato
Birunthan Mohanathas
Boris Zbarsky
Daniel Stenberg
Phil Ringnalda
Brian Smith
Wes Kocher
Brad Lassey
Mats Palmgren
ffxbld
Masatoshi Kimura
Jim Chen