0694578bb0
Bug 1708422: part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Clearer.
Differential Revision: https://phabricator.services.mozilla.com/D115686
2021-05-26 10:04:36 +00:00
93ac6f9a56
Bug 1708422: part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug
...
Clearer and helps to simplify its caller.
Differential Revision: https://phabricator.services.mozilla.com/D115597
2021-05-26 10:04:35 +00:00
69c6a23516
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-26 09:27:21 +00:00
16a4c26f4c
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-26 09:27:20 +00:00
1fb3a73493
Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
...
Depends on D112597
Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-26 09:27:19 +00:00
40b6793a72
Bug 1700051: part 45) Remove outdated part of comment in <mozInlineSpellChecker.cpp>. r=smaug
...
Depends on D113300
Differential Revision: https://phabricator.services.mozilla.com/D113301
2021-05-25 10:08:15 +00:00
ae69b73075
Bug 1540037 - part 18: Move `ReplaceTextAsAction()` and `ReplaceSelectionAsSubAction()` to `EditorBase` r=m_kato
...
They are used by setting text value of `TextEditor` or replacing a misspelled
word with a new word in both `TextEditor` and `HTMLEditor`. Therefore,
they should be in the `EditorBase` rather than `TextEditor`.
Note that the path of the former case may be in a hot path. Therefore, we need
to keep redirecting to `TextEditor` for keeping the performance only in the
case.
Depends on D115785
Differential Revision: https://phabricator.services.mozilla.com/D115786
2021-05-25 04:26:14 +00:00
55db5ff457
Bug 1708422: part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug
...
Hides details.
Differential Revision: https://phabricator.services.mozilla.com/D115469
2021-05-20 13:00:01 +00:00
e74f6c42f1
Bug 1708422: part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115366
2021-05-20 09:03:30 +00:00
b05af40fa3
Bug 1708422: part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115352
2021-05-20 09:03:30 +00:00
e5983d6bde
Bug 1708422: part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114333
2021-05-20 09:03:29 +00:00
c080bbd4cc
Bug 1708422: part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114332
2021-05-20 09:03:28 +00:00
a89ff13783
Bug 1708422: part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114331
2021-05-20 09:03:28 +00:00
9c30eeb984
Bug 1708422: part 11) Remove unnecessary block scope in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114105
2021-05-20 09:03:28 +00:00
ddbcce9316
Bug 1708422: part 10) Factor `ShouldSpellCheckRange` out. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114104
2021-05-20 09:03:27 +00:00
882cc710a4
Bug 1708422: part 9) Declare `mozInlineSpellChecker::ShouldSpellCheckNode` `static`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114103
2021-05-20 09:03:27 +00:00
19a242b989
Bug 1708422: part 8) Move `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Simplifies `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`.
Differential Revision: https://phabricator.services.mozilla.com/D114102
2021-05-20 09:03:26 +00:00
a2355f8bc1
Bug 1708422: part 7) Annotate `mozInlineSpellChecker::SpellCheckerTimeSlice` as `MOZ_STACK_CLASS`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114101
2021-05-20 09:03:26 +00:00
92c6fda0fa
Bug 1708422: part 6) Change some pointer members of `mozInlineSpellChecker::SpellCheckerTimeSlice` to references. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114100
2021-05-20 09:03:26 +00:00
d99bbf18cb
Bug 1708422: part 5) Surround statements in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute` with curly braces. r=smaug
...
To match the style guide.
Differential Revision: https://phabricator.services.mozilla.com/D114099
2021-05-20 09:03:25 +00:00
4e3d4abbad
Bug 1708422: part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`. r=smaug
...
Should help to simplify it. Please read the following reviews before
commenting on this one.
Differential Revision: https://phabricator.services.mozilla.com/D114098
2021-05-20 09:03:25 +00:00
d488467816
Bug 1699480 - Back out permissions changes at AC's request, r=geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D115515
2021-05-19 18:07:28 +00:00
6b729f46ac
Backed out 2 changesets (bug 1653659) for causing failures at test_hunspell.js. CLOSED TREE
...
Backed out changeset 018859776d85 (bug 1653659)
Backed out changeset b187a1b158df (bug 1653659)
2021-05-18 04:05:15 +03:00
351efdd226
Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-17 18:19:27 +00:00
ff4369ad7c
Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-05-17 15:55:21 +00:00
ff7e90c539
Bug 1708422: part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114097
2021-05-17 13:46:59 +00:00
6bb805571d
Backed out 2 changesets (bug 1653659) for Mochitest failures in mochitest/events/test_focus_general.html. CLOSED TREE
...
Backed out changeset 523e4bc2aa47 (bug 1653659)
Backed out changeset fac526423ccb (bug 1653659)
2021-05-14 21:45:58 +03:00
a31d580731
Bug 1653659 - Part 3: Safely handle empty strings in RLBoxHunspell r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-14 13:30:48 +00:00
c46e217683
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-10 09:26:01 +00:00
6a64e4c3cf
Bug 1597751 - Import default permissions for privateBrowsing. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D98200
2021-05-06 17:46:32 +00:00
574bea557a
Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) for causing bustages in nsHttpChannelAuthProvider.cpp
...
CLOSED TREE
Backed out changeset 42561f42313d (bug 669675)
Backed out changeset 2aee05c2d6f3 (bug 1705659)
Backed out changeset ff4348e0a307 (bug 1705659)
Backed out changeset 897868e22c81 (bug 1705659)
Backed out changeset c808bf01dfe8 (bug 1705659)
Backed out changeset 5c13ec25cc2e (bug 1705659)
Backed out changeset 4337214c8846 (bug 1705659)
Backed out changeset 18d3a604336a (bug 1705659)
Backed out changeset 3af362aa2b25 (bug 1705659)
Backed out changeset 36eff14cf2ea (bug 1705659)
Backed out changeset 8af29f96ac77 (bug 1705659)
Backed out changeset eab68e8bea29 (bug 1705659)
Backed out changeset 05492b6578a9 (bug 1705659)
Backed out changeset 3259a8cb3db1 (bug 472823)
2021-05-06 17:37:17 +03:00
ec981ec694
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-06 13:17:23 +00:00
b690e62ff7
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-06 13:17:22 +00:00
3618a7ca40
Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
...
Depends on D112597
Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-06 13:17:21 +00:00
31acb9e00c
Backed out 2 changesets (bug 1708116) for causing xpcshell failures in test_udpsocket_offline.js and bc failures in browser_cookies_ipv6.js. CLOSED TREE
...
Backed out changeset 0c9b303226f1 (bug 1708116)
Backed out changeset e3be13d3c045 (bug 1708116)
2021-05-06 16:35:48 +03:00
301361bdfb
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-06 10:06:46 +00:00
f7b8c6b3d1
Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE
...
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
2021-05-04 18:41:36 +03:00
5ae9a468e0
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-04 14:05:59 +00:00
d5244623ea
Bug 1700051: part 51) Const-qualify `mozInlineSpellStatus::mCreatedRange`. r=smaug
...
Depends on D113758
Differential Revision: https://phabricator.services.mozilla.com/D113759
2021-04-30 07:47:30 +00:00
9de2425774
Bug 1700051: part 50) Add `aRange` to `mozInlineSpellStatus`'s constructor. r=smaug
...
Preparation to const-qualify `mozInlineSpellStatus::mCreatedRange`.
Differential Revision: https://phabricator.services.mozilla.com/D113758
2021-04-30 07:47:29 +00:00
ee42c2c184
Bug 1708422: part 2) Rename `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Clearer.
Differential Revision: https://phabricator.services.mozilla.com/D113780
2021-04-30 07:43:28 +00:00
1407f0e9c5
Bug 1708422: part 1) Factor `mozInlineSpellChecker::AddRangesForMisspelledWords` out. r=smaug
...
Abstracts details away.
Differential Revision: https://phabricator.services.mozilla.com/D113779
2021-04-30 07:43:28 +00:00
5d7b6d2db6
Bug 1700051: part 48) Slightly simplify `mozInlineSpellWordUtil::FindRealWordContaining`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113654
2021-04-29 09:40:53 +00:00
e817cf406f
Bug 1700051: part 47) Change `aWords` argument of `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to const reference. r=smaug
...
This separates checking from modification.
Differential Revision: https://phabricator.services.mozilla.com/D113517
2021-04-28 07:34:33 +00:00
734a2382c1
Bug 1700051: part 46) Const-qualify `mozInlineSpellStatus::mAnchorRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113489
2021-04-28 07:34:33 +00:00
2508edc4c5
Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi
...
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)
\# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D113294
2021-04-26 15:52:25 +00:00
ab4f8bcdcd
Bug 1700051: part 44) Reduce `mozInlineSpellStatus::PositionToCollapsedRange` to `static` method. r=smaug
...
Potentially, this changes behavior, but it shouldn't. Historically,
creating a `nsRange` needed the Document, but it doesn't anymore.
Differential Revision: https://phabricator.services.mozilla.com/D113300
2021-04-26 12:14:49 +00:00
ecf6017483
Bug 1700051: part 43) Const-qualify `mozInlineSpellStatus::PositionToCollapsedRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113103
2021-04-26 07:40:43 +00:00
cfb0e08cb4
Bug 1700051: part 42) Const-qualify `mozInlineSpellStatus::mOp`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113100
2021-04-26 07:40:08 +00:00
23d745343c
Bug 1700051: part 41) Const-qualify `mozInlineSpellStatus::mNewNavigationPositionOffset`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113099
2021-04-26 07:40:08 +00:00
44c7f6cb03
Bug 1700051: part 40) Const-qualify `mozInlineSpellStatus::mForceNavigationWordCheck`. r=smaug
...
Makes `mozInlineSpellStatus` slightly less confusing and always
initializes `mForceNavigationWordCheck`.
Differential Revision: https://phabricator.services.mozilla.com/D113098
2021-04-26 07:40:07 +00:00
8a9f37b534
Bug 1706716 green up mda, xpcshell, browser-chrome, reftest for apple silicon. r=necko-reviewers,extension-reviewers,preferences-reviewers,application-update-reviewers,zombie,ahal,bytesized
...
Differential Revision: https://phabricator.services.mozilla.com/D113001
2021-04-22 18:39:40 +00:00
df29e1a8f4
Bug 1706894: part 3) Change `MapDOMPositionToSoftTextOffset`'s argument to `const` reference. r=smaug
...
More efficient.
Depends on D113080
Differential Revision: https://phabricator.services.mozilla.com/D113081
2021-04-22 13:35:39 +00:00
25f87040f2
Bug 1706894: part 2) In `NodeOffsetRange` use `std::move` and return `const` references instead of copies. r=smaug
...
More efficient.
Depends on D113079
Differential Revision: https://phabricator.services.mozilla.com/D113080
2021-04-22 13:35:38 +00:00
1eccfda320
Bug 1706894: part 1) Use `std::move` in `DOMTextMapping`'s constructor. r=smaug
...
More efficient.
Differential Revision: https://phabricator.services.mozilla.com/D113079
2021-04-22 13:35:38 +00:00
11f3568a7e
Bug 1700051: part 39) Add logging when `SoftText::AdjustBeginAndBuildText` adjusts `mBegin.mOffset`. r=smaug
...
Depends on D112972
Differential Revision: https://phabricator.services.mozilla.com/D112973
2021-04-22 07:15:55 +00:00
3c01a158ee
Bug 1700051: part 38) Add more verbose logging to `mozInlineSpellStatus`. r=smaug
...
Helps to comprehend the program flow.
Differential Revision: https://phabricator.services.mozilla.com/D112972
2021-04-22 07:15:55 +00:00
ff55282cb1
Bug 1706613: part 2) Change `NS_ASSERTION`s to `MOZ_ASSERT`s in `mozInlineSpellWordUtil`. r=smaug
...
Depends on D112958
Differential Revision: https://phabricator.services.mozilla.com/D112959
2021-04-21 13:06:57 +00:00
d45f47b9a0
Bug 1706613: part 1) Change `NS_ASSERTION`s to `MOZ_ASSERT`s in `mozInlineSpellChecker`. r=smaug
...
Helps to detect violations during Try runs.
Differential Revision: https://phabricator.services.mozilla.com/D112958
2021-04-21 13:06:56 +00:00
1856c367b5
Bug 1700051: part 37) Reduce accessibility of `SoftText::mEnd` to `private`. r=smaug
...
Depends on D112732
Differential Revision: https://phabricator.services.mozilla.com/D112733
2021-04-21 07:40:35 +00:00
d514c2e238
Bug 1700051: part 36) Reduce accessibility of `SoftText::mBegin` to `private`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D112732
2021-04-21 07:40:34 +00:00
d44f4cc342
Bug 1700051: part 35) Reduce accessibility of `mSoftText.mDOMMapping` to `private`. r=smaug
...
Depends on D112551
Differential Revision: https://phabricator.services.mozilla.com/D112552
2021-04-20 07:49:13 +00:00
7198e709e8
Bug 1700051: part 34) Reduce accessibility of `mSoftText.mValue` to `private`. r=smaug
...
Depends on D112550
Differential Revision: https://phabricator.services.mozilla.com/D112551
2021-04-20 07:49:13 +00:00
8e5146d57b
Bug 1700051: part 33) Move `AdjustSoftBeginAndBuildSoftText` to `SoftText`. r=smaug
...
Depends on D112549
Differential Revision: https://phabricator.services.mozilla.com/D112550
2021-04-20 07:49:13 +00:00
5af84ee6ee
Bug 1700051: part 32) Move `InvalidateWords` to `SoftText`. r=smaug
...
It's clearer.
Differential Revision: https://phabricator.services.mozilla.com/D112549
2021-04-20 07:49:12 +00:00
c7077c610e
Bug 1700051: part 31.5) Move `mSoftTextDOMMapping` to `SoftText`. r=smaug
...
Depends on D112544
Differential Revision: https://phabricator.services.mozilla.com/D112545
2021-04-20 07:49:12 +00:00
12f19abd5f
Bug 1700051: part 31.4) Move `mSoftTextValid` to `SoftText`. r=smaug
...
Depends on D112543
Differential Revision: https://phabricator.services.mozilla.com/D112544
2021-04-20 07:49:11 +00:00
64c83abf72
Bug 1700051: part 31.3) Move `mSoftEnd` to `SoftText`. r=smaug
...
Depends on D112542
Differential Revision: https://phabricator.services.mozilla.com/D112543
2021-04-20 07:49:11 +00:00
f9be3581cf
Bug 1700051: part 31.2) Move `mSoftBegin` to `SoftText`. r=smaug
...
Depends on D112541
Differential Revision: https://phabricator.services.mozilla.com/D112542
2021-04-20 07:49:11 +00:00
1b13e1f445
Bug 1700051: part 31.1) Factor `SoftText` out. r=smaug
...
The `mSoft*` members belong together and will be moved to `SoftText` in
the following reviews.
Depends on D112540
Differential Revision: https://phabricator.services.mozilla.com/D112541
2021-04-20 07:49:10 +00:00
acff2bb77d
Bug 1700051: part 30) Narrow scope of `newOffset`. r=smaug
...
Presumably allows simplifying the code around it. See the following
review.
Differential Revision: https://phabricator.services.mozilla.com/D112540
2021-04-20 07:49:10 +00:00
70371eb59b
Bug 1700051: part 29) Refactor `TextNodeContainsDOMWordSeparator` to `FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
More descriptive and separates input- from output-arguments.
Differential Revision: https://phabricator.services.mozilla.com/D112180
2021-04-16 08:10:11 +00:00
2ac0000c8a
Bug 1700051: part 28) Refactor `WordSplitState<T>::GetDOMWordSeparatorOffset` to `WordSplitState<T>::FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
The method name is clearer and input and ouput are separated more
clearly.
Differential Revision: https://phabricator.services.mozilla.com/D112026
2021-04-15 08:38:42 +00:00
2357740bfb
Bug 1700051: part 27) Rename `mozInlineSpellWordUtil::BuildSoftText` to `mozInlineSpellWordUtil::AdjustSoftBeginAndBuildSoftText`. r=smaug
...
Ideally, the method itself should be refactored. I'll need to think
about how to properly do that. For now, the new name reflects more
clearly what the method does.
Depends on D110242
Differential Revision: https://phabricator.services.mozilla.com/D110243
2021-03-31 09:04:46 +00:00
74905cb822
Bug 1700051: part 26) Correct typo in comment of `mozInlineSpellWordUtil::BuildSoftText`. r=smaug
...
Depends on D110241
Differential Revision: https://phabricator.services.mozilla.com/D110242
2021-03-31 09:04:46 +00:00
c4cd5efacd
Bug 1700051: part 25) Change `mozInlineSpellWordUtil::BuildRealWords` to return the built words. r=smaug
...
Depends on D110240
Differential Revision: https://phabricator.services.mozilla.com/D110241
2021-03-31 09:04:45 +00:00
7814efb66a
Bug 1700051: part 24) Refactor `mozInlineSpellWordUtil::SplitDOMWord` to `mozInlineSpellWordUtil::SplitDOMWordAndAppendTo`. r=smaug
...
More explicit and preparation for further `const`-correctness.
Depends on D110090
Differential Revision: https://phabricator.services.mozilla.com/D110240
2021-03-31 08:33:09 +00:00
5cf3a4fde1
Bug 1700051: part 23) `const`-qualify more methods of `mozInlineSpellWordUtil`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D110090
2021-03-30 14:43:16 +00:00
8f90ed40d6
Bug 1700051: part 22) `const`-qualify some members of `mozInlineSpellStatus`. r=smaug
...
Depends on D110084
Differential Revision: https://phabricator.services.mozilla.com/D110085
2021-03-30 08:45:04 +00:00
76015c271a
Bug 1700051: part 21) Simplify `mozInlineSpellStatus`'s initialization. r=smaug
...
Depends on D110083
Differential Revision: https://phabricator.services.mozilla.com/D110084
2021-03-30 08:45:03 +00:00
a4864650c7
Bug 1700051: part 20) Merge `mozInlineSpellStatus`'s constructor and its `Init` method. r=smaug
...
Allows to `const`-qualify some members.
Differential Revision: https://phabricator.services.mozilla.com/D110083
2021-03-30 08:45:03 +00:00
b8bb3ce56e
Bug 1700051: part 19) `const`-qualify and rename `mozInlineSpellChecker::SpellCheckSelectionIsFull`. r=smaug
...
Depends on D109895
Differential Revision: https://phabricator.services.mozilla.com/D109896
2021-03-29 08:03:11 +00:00
217df64f78
Bug 1700051: part 18) Throw more `const` on `mozInlineSpellChecker`. r=smaug
...
Depends on D109882
Differential Revision: https://phabricator.services.mozilla.com/D109895
2021-03-29 08:03:11 +00:00
9fbe592b0f
Bug 1700051: part 17) Add `mozInlineSpellChecker::GetDisabledAsyncToken()`. r=smaug
...
Allows unfriending some class from `mozInlineSpellChecker`.
Depends on D109881
Differential Revision: https://phabricator.services.mozilla.com/D109882
2021-03-29 08:03:10 +00:00
2eaf6f3625
Bug 1700051: part 16) Qualify `mozInlineSpellWordUtil::GetRootNode` `const`. r=smaug
...
Depends on D109880
Differential Revision: https://phabricator.services.mozilla.com/D109881
2021-03-29 08:03:10 +00:00
4aabcc8b6a
Bug 1700051: part 15) Qualify `mozInlineSpellWordUtil::MakeRange` `const`. r=smaug
...
Depends on D109879
Differential Revision: https://phabricator.services.mozilla.com/D109880
2021-03-29 08:03:10 +00:00
c3a6b19580
Bug 1700051: part 14) Qualify `mozInlineSpellWordUtil::Init`'s argument `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109879
2021-03-29 08:03:09 +00:00
17b3805751
Bug 1700051: part 13) Reduce accessibility of `mozInlineSpellStatus`'s constructor to `private`. r=smaug
...
Prevents users of `mozInlineSpellStatus` forgetting to initialize it.
Differential Revision: https://phabricator.services.mozilla.com/D109748
2021-03-26 09:21:13 +00:00
14313e8270
Bug 1700051: part 12) Declare `mozInlineSpellStatus::mSpellChecker` `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109747
2021-03-26 09:21:12 +00:00
c15083e2e7
Bug 1700051: part 11) Change `mozInlineSpellStatus::InitForRange` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109746
2021-03-26 09:21:12 +00:00
7d02c05467
Bug 1700051: part 10) Change `mozInlineSpellStatus::InitForSelection` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109745
2021-03-26 09:21:11 +00:00
ad87ef090b
Bug 1700051: part 9) Change `mozInlineSpellStatus::CreateForNavigation` to return `Result<...,...>`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109744
2021-03-26 09:21:11 +00:00
5dde374aaf
Bug 1700051: part 8) Change `mozInlineSpellStatus::InitForNavigation` to static factory method. r=smaug
...
The next part changes its return type to `Result<..., nsresult>`.
Differential Revision: https://phabricator.services.mozilla.com/D109743
2021-03-26 09:21:11 +00:00
d38cbe5571
Bug 1700051: part 7) Change `mozInlineSpellStatus::CreateForEditorChange` to return `Result<..., ...>`. r=smaug
...
Separates input from output more clearly.
Differential Revision: https://phabricator.services.mozilla.com/D109742
2021-03-26 09:21:10 +00:00
daed84a8f4
Bug 1700051: part 6) Change `mozInlineSpellStatus::InitForEditorChange` to static factory method. r=smaug
...
Preparation so that some members of `mozInlineSpellStatus` can become
`const`-qualified.
The method's return value will be changed to
`Result<UniquePtr<mozInlineSpellStatus>, nsresult>>` in a separate
review.
Differential Revision: https://phabricator.services.mozilla.com/D109741
2021-03-26 09:21:10 +00:00
00a2d5f7d4
Bug 1675614 - Process spellcheck in chunks in the parent process, since it's also async. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D109692
2021-03-26 04:19:46 +00:00
cc730d05dd
Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108588
2021-03-24 17:56:50 +00:00
613e20d136
Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
0954ebd22d
Bug 708901 - Migrate to nsTHashSet in extensions/spellcheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109335
2021-03-24 17:56:49 +00:00
bf3ef3a71d
Bug 708901 - Migrate to nsTHashSet in extensions/permissions. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D109334
2021-03-24 17:56:49 +00:00
f54ee076ae
Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
...
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
e63cfd0e56
Bug 708901 - Migrate to nsTHashSet in extensions/spellcheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109335
2021-03-24 16:59:01 +00:00
d54c92f2e8
Bug 708901 - Migrate to nsTHashSet in extensions/permissions. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D109334
2021-03-24 16:59:01 +00:00
d1c07416d3
Bug 1700051: part 5) Correct typo. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109501
2021-03-24 10:12:00 +00:00
0be7d4c977
Bug 1700051: part 4) Add `GetOperation()` to `mozInlineSpellStatus`. r=smaug
...
Depends on D109310
Differential Revision: https://phabricator.services.mozilla.com/D109311
2021-03-24 10:12:00 +00:00
7563a8e16b
Bug 1700051: part 3) Add `GetCreatedRange()` to ` mozInlineSpellStatus`. r=smaug
...
Depends on D109309
Differential Revision: https://phabricator.services.mozilla.com/D109310
2021-03-24 10:12:00 +00:00
77b3add57e
Bug 1700051: part 2) Add `GetNoCheckRange()` to `mozInlineSpellStatus`. r=smaug
...
Depends on D109308
Differential Revision: https://phabricator.services.mozilla.com/D109309
2021-03-24 10:11:59 +00:00
3691a72cd6
Bug 1700051: part 1) Reduce accessibility of some members of `mozInlineSpellStatus` to `private`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109308
2021-03-24 10:11:59 +00:00
58f319b15f
Bug 1698786: part 7) Add more `MOZ_LOG`ging to `mozInlineSpellWordUtil`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109277
2021-03-24 08:15:52 +00:00
22d17f7692
Bug 1698786: part 6) Add some `const`-correctness to `mozInlineSpellWordUtil`. r=smaug
...
Depends on D109038
Differential Revision: https://phabricator.services.mozilla.com/D109269
2021-03-22 14:34:09 +00:00
915b67f69b
Bug 1698786: part 5) Change compile-time debug printfs to `MOZ_LOG` in `mozInlineSpellWordUtil`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109038
2021-03-22 08:17:38 +00:00
0169591f05
Bug 1698786: part 3) Add some logging to `mozSpellChecker`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D108623
2021-03-18 09:33:21 +00:00
0840574ecb
Bug 1698786: part 2) Change some compile-time dependent `printf`s to `MOZ_LOG` in `mozInlineSpellChecker. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D108622
2021-03-18 09:33:21 +00:00
b9621d6376
Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D108585
2021-03-17 15:49:46 +00:00
332b02d82f
Bug 1698786: part 1) Add some logging to `mozInlineSpellChecker`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D108621
2021-03-17 15:11:51 +00:00
896135cdcc
hg diff Bug 1695756 - Import the 'Adding a new word to the en-US dictionary' doc r=firefox-source-docs-reviewers,flod,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D106830
2021-03-02 13:25:44 +00:00
9af107a839
Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
92afde7986
Bug 1686616 - register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin
...
These services had their name added to components.conf:
* GfxInfo
* ThirdPartyUtil
* History
* HttpActivityDistributor
* UUIDGenerator
* ServiceWorkerManager
* PermissionManager
These services were added to componenets.conf under a different name:
* DirectoryService => Directory
* IOService => IO
* StringBundleService => StringBundle
* CacheStorageService => CacheStorage
* StreamTransportService => StreamTransport
* SocketTransportService => SocketTransport
These services weren't migrated to components.conf because only Rust
code uses them:
* RemoteAgent
* XULRuntime
* PrefService
These services weren't migrated to components.conf because they're unused:
* ToolkitChromeRegistry (used as ChromeRegistry)
* XULChromeRegistry (used as ChromeRegistry)
* Bits (completely unused)
These services were already available in components.conf but are still
used by rust code:
* URIFixup
These services weren't migrated because they will be handled in
subsequent patchsets:
* ObserverService
For the record, the following Services are being used by Rust code
and must remain until a Rust version of Components.h is written:
* RemoteAgent
* XULRuntime
* PrefService
* URIFixup
* ObserverService
* DirectoryService
* ThirdPartyUtil
Also the cocoa GfxInfo service was changed to use components.conf instead
of registering it at runtime, as all the other widgets were already doing
it this way.
Differential Revision: https://phabricator.services.mozilla.com/D105521
2021-02-18 13:26:28 +00:00
717d5d2aa5
Bug 1671768 - Part 4: Use MOZ_CAN_RUN_SCRIPT for Selection::RemoveAllRanges r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D103780
2021-02-03 21:52:48 +00:00
9862045082
Bug 1667276 - Part 2: Add BackgroundTasksManager to invoke task defined in JS. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D97512
2021-01-27 22:54:17 +00:00
89fe8f250d
Backed out 8 changesets (bug 1679440, bug 1682069, bug 1667276) for causing failure on test_crash_backgroundtask_moz_crash.js. CLOSED TREE
...
Backed out changeset f06504e3219f (bug 1682069)
Backed out changeset 4d325f68ea24 (bug 1679440)
Backed out changeset 9ab334e527a5 (bug 1667276)
Backed out changeset 1c8d51d2c90f (bug 1667276)
Backed out changeset 8d6f10d83c6b (bug 1667276)
Backed out changeset 62488ec634f9 (bug 1667276)
Backed out changeset 1dcb2d1be264 (bug 1667276)
Backed out changeset c673fff5bd85 (bug 1667276)
2021-01-27 22:17:17 +02:00
5548db0e56
Bug 1667276 - Part 2: Add BackgroundTasksManager to invoke task defined in JS. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D97512
2021-01-27 18:10:15 +00:00
0b28701943
Backed out 8 changesets (bug 1679440, bug 1682069, bug 1667276) for causing failures on browser_all_files_referenced.js. CLOSED TREE
...
Backed out changeset f1a65c9b3ca2 (bug 1682069)
Backed out changeset 310d2116faf7 (bug 1679440)
Backed out changeset f970ef0897cd (bug 1667276)
Backed out changeset 38c20196aabc (bug 1667276)
Backed out changeset 60c2f2dbc676 (bug 1667276)
Backed out changeset cf52687c4433 (bug 1667276)
Backed out changeset 74580a0f2633 (bug 1667276)
Backed out changeset ab6f830f6e75 (bug 1667276)
2021-01-26 06:49:04 +02:00
02c231aa60
Bug 1667276 - Part 2: Add BackgroundTasksManager to invoke task defined in JS. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D97512
2021-01-25 23:45:17 +00:00
83f9e8ca5b
Bug 1653659 - Part 2: Add support for Wasm sandboxing hunspell. r=firefox-build-system-reviewers,dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D86063
2021-01-14 20:12:19 +00:00
523d862fa2
Bug 1653659 - Part 1: Retrofit hunspell with RLBox for sandboxing r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D84007
2021-01-14 20:12:16 +00:00
d5d2b965d2
Bug 1685427 - Crash when authenticating using SPNEGO on macOS (ARM) r=spohl
...
Don't pragma pack gssapi structs on ARM64 to be consistent with macOS system gssapi.h header file.
Issue reported to reported to Apple and acknowledged.
Differential Revision: https://phabricator.services.mozilla.com/D102361
2021-01-20 01:29:16 +00:00
869d44f53c
Backed out 2 changesets (bug 1653659) for Build bustage in builds/worker/workspace/obj-build/dist/include/mozilla/rlbox/rlbox_type_traits.hpp. CLOSED TREE
...
Backed out changeset 783310e1f5b8 (bug 1653659)
Backed out changeset 876dfd999d65 (bug 1653659)
2021-01-14 22:09:18 +02:00
27b04de0f6
Bug 1653659 - Part 2: Add support for Wasm sandboxing hunspell. r=firefox-build-system-reviewers,dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D86063
2021-01-13 06:39:01 +00:00
7b30ceff66
Bug 1653659 - Part 1: Retrofit hunspell with RLBox for sandboxing r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D84007
2021-01-14 19:36:42 +00:00
af38ea2e99
Bug 1683176 - Make sure mAuthChannel is released on main thread r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D100243
2021-01-13 09:28:23 +00:00
50d34b6e87
Bug 1683176 - Call OnCredsGenerated when GetNextTokenCompleteEvent is canceled r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D100057
2021-01-13 09:27:58 +00:00
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
8f28b5cf01
Bug 1683540 - Make `extensions` buildable outside of `unified-build` environment. r=sg
...
Differential Revision: https://phabricator.services.mozilla.com/D100208
2021-01-04 14:18:58 +00:00
2978aa00a3
Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD
2020-12-28 00:43:51 +02:00
775cdec032
Bug 1684173 - Add newline character at end of files when missing r=sylvestre
...
Depends on D100443
Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
ddeba05428
Bug 1671764 - Part 1. Use ACString for dictionary language instead. r=masayuki
...
Actually, our locale service doesn't use UTF-16 for locale name and it will
be ASCII. Although dictionary name of spell checker is locale/language name,
it still uses UTF-16. To use locale API, I should replace it with `ACString`.
Differential Revision: https://phabricator.services.mozilla.com/D99336
2020-12-14 03:01:05 +00:00
1c53236b70
Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
486e6c4fae
Bug 1675329: Add an API for returning an exit code from the application. r=dthayer,necko-reviewers,dragana,nika
...
Callers can pass an exit code to nsIAppStartup::Quit and it will be returned from the process when
it exits.
Note that I have using uint16_t as the exit code because on Windows the exit code can be a uint and
elsewhere it is an int. A uint16_t will safely convert to either of those and no-one will ever need
more than 64k exit codes!
Differential Revision: https://phabricator.services.mozilla.com/D96857
2020-12-03 20:19:47 +00:00
aadb1612e7
Bug 1677529: Accurately describe why extra "malloc" import is needed r=glandium
...
To count hunspell memory calls, we hook into malloc calls with #defines.
Due to the way that the compiler imports and caches files, this
causes an implicit dependency on importing malloc before the hooks are
set.
Make this implicit dependency explicit and explain why it's there.
Differential Revision: https://phabricator.services.mozilla.com/D98081
2020-12-01 16:53:31 +00:00
d10d03d076
Bug 1676365 - Move SpinEventLoopUntil to separate header. r=#xpcom-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D96556
Depends on D96554
2020-11-23 16:10:41 +00:00
8924394252
Bug 1676363 - Remove dependency of nsTArray on nsCycleCollectionChild. r=#xpcom-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D96547
Depends on D96546
2020-11-23 16:09:49 +00:00
5bfbb2a572
Bug 1673931 - Avoid including Document.h from header files. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D95046
Depends on D95045
2020-11-23 16:07:43 +00:00
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
93595da8db
Backed out changeset d57553438d94 (bug 1675329) for causing bustages in nsAppShell. CLOSED TREE
2020-11-20 22:37:39 +02:00
a3cb03324e
Bug 1675329: Add an API for returning an exit code from the application. r=dthayer,necko-reviewers,dragana,nika
...
Callers can pass an exit code to nsIAppStartup::Quit and it will be returned from the process when
it exits.
Note that I have using uint16_t as the exit code because on Windows the exit code can be a uint and
elsewhere it is an int. A uint16_t will safely convert to either of those and no-one will ever need
more than 64k exit codes!
Differential Revision: https://phabricator.services.mozilla.com/D96857
2020-11-20 19:13:34 +00:00
35c7373e04
Bug 1675018 - Part 2 - Add PermissionManager::GetAllByTypeSince. r=timhuang
...
This function is a helper for clearing all storageAccessAPI permissions
that were modified after a certain date. We need to get them and filter
by principal to clear them.
Differential Revision: https://phabricator.services.mozilla.com/D96639
2020-11-17 22:24:55 +00:00
af42a4dbc7
Backed out 5 changesets (bug 1675018) for linting failure. CLOSED TREE
...
Backed out changeset 81e7fe361388 (bug 1675018)
Backed out changeset 7fe621a805eb (bug 1675018)
Backed out changeset 34fd482121f2 (bug 1675018)
Backed out changeset ee836c7f63d4 (bug 1675018)
Backed out changeset 0e09ce61e374 (bug 1675018)
2020-11-17 00:34:27 +02:00
70752f8763
Bug 1675018 - Part 2 - Add PermissionManager::GetAllByTypeSince. r=timhuang
...
This function is a helper for clearing all storageAccessAPI permissions
that were modified after a certain date. We need to get them and filter
by principal to clear them.
Differential Revision: https://phabricator.services.mozilla.com/D96639
2020-11-16 19:29:24 +00:00
774bada3e2
Bug 1676573 - Add support for named in-memory databases; r=asuth,dom-workers-and-storage-reviewers
...
Naming in-memory databases also allows cloning which is the primary goal of
this patch.
Differential Revision: https://phabricator.services.mozilla.com/D96527
2020-11-11 07:26:41 +00:00
02a7b4ebdf
Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
da1098d4aa
Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
...
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
c0cea3b0fa
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
8f82fc1396
Bug 1672918 - Add words to en-US dictionary
...
Differential Revision: https://phabricator.services.mozilla.com/D94558
2020-10-23 20:32:35 +00:00
b7133788f4
Bug 1647025 - Update the number of items in the dictionary
...
Differential Revision: https://phabricator.services.mozilla.com/D94460
2020-10-22 16:43:18 +00:00
c9ef3dc8e3
bug 1647025 - Add Juneteenth to the en_US dict r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D94415
2020-10-22 11:55:10 +00:00
1ff59cb7a3
Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE
2020-10-22 03:51:06 +03:00
50762dacab
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
ee59a97d81
Bug 1592922 - Account for possibility of sandbox when calling processLDAPValues. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D94340
2020-10-21 20:20:02 +00:00
04027a5656
Bug 1607131 - Make `beforeinput` event for `MozEditableElement.setUserInput()` not cancelable by default r=smaug
...
Blink and WebKit do not fire `beforeinput` event when user uses build-in
password manager and autocomplete. But the `inputType` value for this case,
`"insertReplacementText"` is defined as cancelable in the spec, and it's
actually cancelable when it's fired for correcting a word with built-in
spellchecker of them.
For making only our users' autocomplete and password manager not blocked by
web apps, we should make them not cancelable by default, but I think that we
should keep dispatching such non-cancelable `beforeinput` for conforming to
the standard unless we'd get a web-compat report for this.
Differential Revision: https://phabricator.services.mozilla.com/D93206
2020-10-20 00:13:43 +00:00
a1acf45525
Bug 1671749 - Remove workaround for MinGW from nsAuthSSPI destructor. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D93874
2020-10-19 14:44:44 +00:00
29ccb54ede
Bug 1641611 - PermissionManager should take the largest ID considering the expired permissions too, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D92887
2020-10-13 16:43:37 +00:00
de7bab0f06
Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
cfb8fb313f
Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg
...
This patch was generated by running:
```
perl -p -i \
-e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \
-e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \
$FILE
```
against every .cpp and .h in mozilla-central, and then fixing up the
inevitable errors that happen as a result of matching C++ expressions with
regexes. The errors fell into three categories:
1. Calling the convert functions with `std::string::c_str()`; these were
changed to simply pass the string instead, relying on implicit conversion
to `mozilla::Span`.
2. Calling the convert functions with raw pointers, which is not permitted
with the copy functions; these were changed to invoke `MakeStringSpan` first.
3. Other miscellaneous errors resulting from over-eager regexes and/or the
replacement not being type-aware. These changes were reverted.
Differential Revision: https://phabricator.services.mozilla.com/D88903
2020-09-02 09:54:37 +00:00
0c03ba166c
Bug 1658471 - Remove dom.security.featurePolicy.enabled. r=baku
...
We've shipped it on by default since 74 (bug 1617219).
Differential Revision: https://phabricator.services.mozilla.com/D86665
2020-08-12 10:57:04 +00:00
06b00d0bf4
Bug 1657582 - Add nsIDNSAddrRecord interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,dragana
...
This interface extends nsIDNSRecord and makes the DNS code more extensible
by allowing us to support more record types.
This change does require the consumer to be aware of the type they requested
and to QueryInterface to either nsIDNSAddrRecord for regular IP lookups,
or to nsIDNSByTypeRecord for other kinds of lookups.
Differential Revision: https://phabricator.services.mozilla.com/D86177
2020-08-12 10:49:39 +00:00
aaf012c1e2
Bug 1654803 - Fixing the crash issue in PermissionDelegateHandler::GetPermission(). r=baku
...
At very rare situations, we won't be able to get the top level window
context. Perhaps, it's the case that the window has been detached from
the dom tree while checking the permission. So, we need to check the top
level window context before we really use it.
Differential Revision: https://phabricator.services.mozilla.com/D85978
2020-08-12 07:53:35 +00:00
694b77183c
Backed out 2 changesets (bug 1657582) for test_DNSLookup.js failures CLOSED TREE
...
Backed out changeset 784122a5f5ab (bug 1657582)
Backed out changeset 0f17312b01ad (bug 1657582)
2020-08-12 11:18:06 +03:00
5eeaf52395
Bug 1657582 - Add nsIDNSAddrRecord interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,dragana
...
This interface extends nsIDNSRecord and makes the DNS code more extensible
by allowing us to support more record types.
This change does require the consumer to be aware of the type they requested
and to QueryInterface to either nsIDNSAddrRecord for regular IP lookups,
or to nsIDNSByTypeRecord for other kinds of lookups.
Differential Revision: https://phabricator.services.mozilla.com/D86177
2020-08-12 01:35:10 +00:00
571754630f
Bug 1657573: Change libhunspell's file access code to use function pointers r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D86173
2020-08-10 15:29:25 +00:00
7be797a434
Bug 1654098 - fix a few racist epithets missing 'exclude from suggestions' annotation, r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D86559
2020-08-10 15:21:20 +00:00
1e02318b49
Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
96f3e7e019
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
381fca9783
Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
...
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
032d2ac9d3
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
b13577d8e4
Bug 1613431 - Part 3: Handle synced setters return value. r=nika
...
Depends on D83646
Differential Revision: https://phabricator.services.mozilla.com/D83647
2020-07-31 13:37:13 +00:00
e3ebda1914
Bug 1223932 - delete guard object uses from the tree; r=jwalden
...
CLOSED TREE
We don't need these macros anymore, for two reasons:
1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
and friends.
2. clang now warns for the "temporary that should have been a declaration" case.
The extra requirements on class construction also show up during debug tests
as performance problems.
This change was automated by using the following sed script:
```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d
# Remove individual macros, carefully.
{
# We don't have to worry about substrings here because the closing
# parenthesis "anchors" the match.
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;
# Remove the longer identifier first.
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}
# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```
and running:
```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```
Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
a911a108d0
Backed out changeset ac9c811bc427 (bug 1223932) for causing spidermonkey rust failures.
...
CLOSED TREE
2020-07-30 18:23:21 +03:00
bec9f9b93a
Bug 1223932 - delete guard object uses from the tree; r=jwalden
...
We don't need these macros anymore, for two reasons:
1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
and friends.
2. clang now warns for the "temporary that should have been a declaration" case.
The extra requirements on class construction also show up during debug tests
as performance problems.
This change was automated by using the following sed script:
```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d
# Remove individual macros, carefully.
{
# We don't have to worry about substrings here because the closing
# parenthesis "anchors" the match.
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;
# Remove the longer identifier first.
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}
# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```
and running:
```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```
Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
8f54209ef6
Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D83413
2020-07-20 16:06:59 +00:00
fea9dab7f2
Bug 1651714 - Reduce expensive includes for TabMessageUtils.h. r=smaug
...
With these changes, on my Linux analysis with ClangBuildAnalyzer, the
top two expensive headers, DOMTypes.h and TabMessageUtils.h are no longer
among the 30 most expensive headers.
Differential Revision: https://phabricator.services.mozilla.com/D82935
2020-07-15 13:24:20 +00:00
a7153982e8
Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
93c5659e4a
Bug 1644896 - Reintroduce an EnsureReadCompleted() in PermissionManager, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D83465
2020-07-14 07:36:14 +00:00
5a7b4e2136
Bug 1644896 - Add the shutdown blocker during the PermissionManager::initDB, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83360
2020-07-14 07:23:57 +00:00
2aa62ff0f3
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 20:18:40 +00:00
e0ac748fab
Backed out 2 changesets (bug 1644896) for XPCshell failures on widget/headless/tests/test_headless.js. CLOSED TREE
...
Backed out changeset f501e7db25a8 (bug 1644896)
Backed out changeset 2d984add3abb (bug 1644896)
2020-07-13 23:11:40 +03:00
c14aa7655d
Bug 1644896 - Add the shutdown blocker during the PermissionManager::initDB, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83360
2020-07-13 17:48:30 +00:00
8a5c2d57b1
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 17:48:20 +00:00
51562a8355
Backed out changeset 73b12096811d (bug 1644896) for mochitest crashes CLOSED TREE
2020-07-13 12:32:28 +03:00
6955bc5543
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 08:23:27 +00:00
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
6a39211860
Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 21:42:25 +00:00
b355fcc4bf
Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE
...
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
2020-07-09 23:19:26 +03:00
d09458dc51
Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 17:59:16 +00:00
61e4a0be9b
Bug 1649729 - Get rid of MOZ_ACCESS_THREAD_BOUND macro. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D81843
2020-07-01 13:13:23 +00:00
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
788cd2c41f
Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81681
2020-06-30 18:34:51 +00:00
5b1b63de75
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-30 09:44:00 +00:00
adaed940e7
Backed out changeset 34d09061d827 (bug 1648134) for failures on test_permmanager_remove_add_update.js. CLOSED TREE
2020-06-29 20:43:54 +03:00
dc7bad122c
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-29 14:37:19 +00:00
1d1ef81356
Bug 1645997 - Use BrowsingContext to get the top-level window context in PermissionDelegateHandler.cpp r=baku
...
We used the Document::GetWindowContext() to get the window context
related to the doucment. But, this could return a nullptr if the
document is detached from the window or the docuemnt is destoried.
We move to use the BrowsingContext instead which won't return a nullptr
in these cases.
Differential Revision: https://phabricator.services.mozilla.com/D79897
2020-06-19 12:31:29 +00:00
d5b9be12ce
Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
f5adef2650
Bug 1587743 - Part 3: Using WindowContext to test delegated permissions. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D79134
2020-06-12 16:32:03 +00:00
8422436b6c
Bug 1587743 - Part 2: Removing mTopLevelPrincipal from the PermissionDelegateHandler. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D79133
2020-06-12 16:31:56 +00:00
eab7aa2b87
Bug 1587743 - Part 1: Pre-compute the delegated permissions for the top-level content and store it in the WindowContext. r=baku,nika
...
In order to delegate the permission to the top-level window, in this
patch, we pre-compute the permissions of the top-level context and set
them to the top-level WindowContext. So, the cross-origin iframe can
know the permission of the top-level window through the WindowContext.
Thus, the permission can be delegated in Fission.
Differential Revision: https://phabricator.services.mozilla.com/D79132
2020-06-12 16:31:49 +00:00
b1f63ced7e
Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi
...
Return NSTerminateCancel from applicationShouldTerminate when the user chooses to "Stay on Page".
Differential Revision: https://phabricator.services.mozilla.com/D78839
2020-06-09 18:20:36 +00:00
53b848ce2f
Bug 1644073 - Remove storageAccessAPI permission from preload list r=baku
...
We add storageAccessAPI permission to perload list in Bug 1499442.
In the recent ETP fission works, we have ensured that the user interaction
permission check can only happen either in the parent process or in the
content processes that load principal to check. This means we don't need
to preload it anymore.
Differential Revision: https://phabricator.services.mozilla.com/D78639
2020-06-08 11:24:05 +00:00
b8d216c8f6
Bug 1637553 - Reduce array copy in spell checker loop. r=masayuki
...
Actually, we always clone spell checker range array per IPC call into spell
check loop. But we can use `std::move` to reduce unnecessary copy.
Also, `mozInlineSpellWordUtil::GetNextWord` always returns NS_OK, so
this should use boolean value to know whether loop is done.
Differential Revision: https://phabricator.services.mozilla.com/D75111
2020-05-27 14:33:12 +00:00
89958b377a
Bug 1640605 - Remove IsInAnonymousSubtree / IsRootOfAnonymousSubtree. r=edgar
...
In favor of the NativeAnonymous versions which they forward to.
Done automatically with:
rg -l 'IsInAnonymousSubtree' | xargs sed -i 's/IsInAnonymousSubtree/IsInNativeAnonymousSubtree/g'
And removing the function definitions afterwards.
Differential Revision: https://phabricator.services.mozilla.com/D76681
2020-05-25 11:43:51 +00:00
badadf3f93
Bug 1596855 - Update browser_permmgr_sync.js for Fission. r=pbz
...
The test was updated to ensure that under Fission we're not syncing
all permission information to a "parent" content process, and instead
just to the specific iframe that needs it.
Differential Revision: https://phabricator.services.mozilla.com/D76103
2020-05-20 16:45:01 +00:00
68dab10ed9
Bug 1629274 - Fix Intermittent failure in test_permmanager_removeall.js, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D74590
2020-05-11 08:34:04 +00:00
8bc8cd34b1
Bug 1635693 - Ensure permissionManager DB connection is active only if the initialization completed, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D74385
2020-05-08 16:23:15 +00:00
011b59d595
Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
...
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.
This was done automatically with a new eslint rule that will be introduced in
the next commit. One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS. The rule will be disabled for that instance.
Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
6a983da8c3
Bug 1626570 - Improve handling of copying arrays in extensions/spellcheck. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D72319
2020-04-30 09:36:26 +00:00
38afb32dc5
Bug 1626555 - Make `dom/base` buildable outside of `unified-build` environment. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D69183
2020-04-29 09:02:05 +00:00
59f0df8747
Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 17:26:04 +00:00
ce17a27917
Backed out changeset b1f668b65e69 (bug 1627220) for causing xpcshell failures at extensions/permissions/test/unit/test_permmanager_expiration.js
...
CLOSED TREE
2020-04-27 17:49:53 +03:00
105e5e23f6
Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 11:40:53 +00:00
ea62971514
Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
...
***
Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-23 13:11:56 +00:00
b611a44386
Backed out changeset a2bff0eef797 (bug 1623417) for causing xpcshell failures in test_permmanager_matchesuri.js CLOSED TREE
2020-04-20 20:09:23 +03:00
bb11628699
Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
...
***
Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-20 15:59:44 +00:00
85532d60f8
Bug 1626076 - Make it possible to use DataStorage on socket process r=keeler,dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D68877
2020-04-20 09:41:58 +00:00
c0401ba16f
Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D65606
2020-04-20 09:53:40 +00:00
7be9697324
Bug 1629450 - reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku
...
Started failing following https://hg.mozilla.org/mozilla-central/rev/f1d9689ea300
Differential Revision: https://phabricator.services.mozilla.com/D70930
--HG--
extra : moz-landing-system : lando
2020-04-15 07:23:11 +00:00
7e719a42a0
Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku
...
After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.
Differential Revision: https://phabricator.services.mozilla.com/D70675
--HG--
extra : moz-landing-system : lando
2020-04-14 08:34:17 +00:00
68d9c71f19
Bug 1629273 - Fix intermittent failure in test_permmanager_load_invalid_entries.js, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70639
--HG--
extra : moz-landing-system : lando
2020-04-14 07:55:52 +00:00
98eff139c5
Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70164
--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:53 +00:00
9f0376cefe
Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70041
--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:30 +00:00
13481ea877
Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70040
--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-11 13:42:12 +00:00
a765ed14dd
Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69965
--HG--
extra : moz-landing-system : lando
2020-04-11 13:41:19 +00:00
5c1bc3ab01
Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69964
--HG--
extra : moz-landing-system : lando
2020-04-10 08:36:46 +00:00
d0bfec4f79
Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69963
--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-10 08:36:37 +00:00
b74e338c98
Backed out 6 changesets (bug 1363541) for perma failures. CLOSED TREE
...
Backed out changeset a775f6e9eb41 (bug 1363541)
Backed out changeset 9212bfd89eca (bug 1363541)
Backed out changeset bf41b0c139f6 (bug 1363541)
Backed out changeset aa7c6668b249 (bug 1363541)
Backed out changeset 9f413a8a47bb (bug 1363541)
Backed out changeset 827a9a2866bd (bug 1363541)
--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 11:31:20 +03:00
519961d263
Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70164
--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
4adbfbb4d0
Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70041
--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
b523b552a4
Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70040
--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
f78d7b4bd4
Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69965
--HG--
extra : moz-landing-system : lando
2020-04-10 06:36:03 +00:00
3961346cfc
Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69964
--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
2ab42cd711
Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69963
--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
d37de5ed78
Backed out 6 changesets (bug 1363541) for browser-chrome failures at browser/base/content/test/performance/browser_startup_mainthreadio.js on a CLOSED TREE
...
Backed out changeset 947073be919f (bug 1363541)
Backed out changeset 1f397b686c11 (bug 1363541)
Backed out changeset d2ba944a47a3 (bug 1363541)
Backed out changeset 80d4d1f0c921 (bug 1363541)
Backed out changeset 9d6b9052f413 (bug 1363541)
Backed out changeset aeaa10789071 (bug 1363541)
--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 01:00:15 +03:00
25ea79a516
Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70164
--HG--
extra : moz-landing-system : lando
2020-04-09 13:28:23 +00:00
3e892fdba4
Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70041
--HG--
extra : moz-landing-system : lando
2020-04-09 13:27:53 +00:00
8764c55c53
Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70040
--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 13:27:35 +00:00
f71aefda4e
Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69965
--HG--
extra : moz-landing-system : lando
2020-04-09 13:26:29 +00:00
cefe8accad
Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69964
--HG--
extra : moz-landing-system : lando
2020-04-09 13:25:56 +00:00
23b424cd70
Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D69963
--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 14:07:34 +00:00
b529c76594
Bug 1620594 - Part 6: Use AbstractThread::MainThread instead of SystemGroup::AbstractThread. r=nika
...
Depends on D67635
Differential Revision: https://phabricator.services.mozilla.com/D67636
--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:14 +00:00
63e21eec70
Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika
...
To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.
Depends on D64390
Differential Revision: https://phabricator.services.mozilla.com/D67631
--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:23 +00:00
Mirko Brodesser
Valentin Gosu
Masayuki Nakano
Dylan Roeh
Butkovits Atila
Deian Stefan
Dorel Luca
Paul Zuehlcke
Alexandru Michis
Brindusan Cristian
Sandor Molnar
Andi-Bogdan Postelnicu
Joel Maher
Matt Woodrow
Simon Giesecke
Csoregi Natalia
Sylvestre Ledru
Alexis Beingessner
Kagami Sascha Rosylight
Nick Alexander
Haik Aftandilian
Kershaw Chang
Kartik Gautam
Andi-Bogdan Postelnicu
Cosmin Sabou
Makoto Kato
Dave Townsend
Mitchell Hentges
Johann Hofmann
Jan Varga
Ricky Stewart
Bogdan Tara
Ekanan Ketunuti
Michael Kaply
Alex Henrie
Andrea Marchesini
Nathan Froyd
Emilio Cobos Álvarez
Tim Huang
shravanrn
Gijs Kruitbosch
Noemi Erli
Andreas Farre
Doug Thayer
Frederik Braun
Kris Maglione
Henri Sivonen
Dimi Lee
Ian Moody
Daniel Varga
Sebastian Streich
Magnus Melin
Razvan Maries
Coroiu Cristina