33caf18ccc
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ; r=manishearth,xidorn
...
MozReview-Commit-ID: LHT6Aa2ojlf
--HG--
extra : rebase_source : cad726aee8e14d7ae60b899a76fcd26edb608507
2016-10-28 06:17:20 +02:00
389406c473
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ; r=manishearth,xidorn
...
MozReview-Commit-ID: 7I7Z4q7mLtC
--HG--
extra : rebase_source : 23ce3fddb26424aa42aea93cfdf6fc123926fe18
2016-10-29 10:51:05 +02:00
9260566b60
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ; r=manishearth,xidorn
...
MozReview-Commit-ID: IA4bGLgRxd6
--HG--
extra : rebase_source : 6632c53a96df170e8604d65b351f7ee2717ec9ec
2016-10-23 22:41:49 +02:00
e7dddd42f0
Bug 1312173 - Convert NS_STYLE_USER_INPUT_* to an enum class; r=manishearth,xidorn
...
MozReview-Commit-ID: sYiJrZryrA
--HG--
extra : rebase_source : dbb7bae56bea6203176097af8de119cae0a6391c
2016-10-23 00:08:18 +02:00
2f279e5ef8
Bug 1306214 part 3 - Remove -moz-use-text-color from Gecko. r=heycam
...
MozReview-Commit-ID: EEYCB5jUH9L
--HG--
extra : rebase_source : ce6fcfdd573e1986a07fdae84106274bd2ae2495
2016-09-29 17:47:22 +10:00
c7624c8d0d
Bug 1299379 - Iterate Sides using an int32_t instead to avoid UBSan warning. r=dholbert
2016-09-11 15:49:50 +02:00
aad318e17a
Bug 1300337 - Replace None_ variants from nsStyleConsts.h with None; r=heycam,TYLin
...
MozReview-Commit-ID: CxHzbEzjLxT
--HG--
extra : rebase_source : 232f90b8b107f7fb49f47a29a4e493660b8a7d87
2016-09-04 00:16:58 +05:30
c6d0429830
Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. r=xidorn
...
After using enum class, a switch-case warning in CombineBreakType is caught.
This is one of such kind safty checks that we would like to gain.
Fix it by adding default case for switch-case in CombineBreakType.
MozReview-Commit-ID: BdS3LPN6qzX
--HG--
extra : rebase_source : 17f24a0d482ed6eb51b23e6942d0ac1c87375e0b
2016-09-07 10:20:17 +08:00
619cb14d87
Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz
...
The main renaming was generated with the following python script:
```
import sys
import re
CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)")
DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b")
def to_camel_case(ident):
return re.sub(CAMEL_CASE_REGEX,
lambda m: m.group(2) + m.group(3).lower(), ident)
def constant_to_enum(constant):
return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "")
def process_line(line):
return re.sub(DISPLAY_REGEX,
lambda m: constant_to_enum(m.group(1)), line)
lines = []
with open(sys.argv[1], "r") as f:
for line in f:
lines.append(process_line(line))
with open(sys.argv[1], "w") as f:
for line in lines:
f.write(line)
```
And the following shell commands:
```
find . -name '*.cpp' -exec python display.py {} \;
find . -name '*.h' -exec python display.py {} \;
```
MozReview-Commit-ID: 91xYCbLC2Vf
2016-09-01 20:41:17 -07:00
b41dc19d66
Bug 1297982 - Replace NS_STYLE_BOX_ORIENT_* with enum class; r=xidorn
...
MozReview-Commit-ID: GC0VRyHUM4V
--HG--
extra : rebase_source : eb43a793816101798d0d3bb9a56864519eb7a14a
2016-08-26 12:48:41 +05:30
294361b78a
Bug 1297982 - Replace NS_STYLE_BOX_DIRECTION_* with enum class; r=xidorn
...
MozReview-Commit-ID: H6Mr73864O2
--HG--
extra : rebase_source : a13a5d1ec0b0149da82bfdb3ea7ce22cd9ddfcd2
2016-08-26 12:47:09 +05:30
149cb6c819
Bug 1297982 - Replace NS_STYLE_BOX_DECORATION_BREAK_* with enum class; r=xidorn
...
MozReview-Commit-ID: 9Cli68UpKdz
--HG--
extra : rebase_source : aa43e54c5e5501cbfee29437c5fcfc0216823bd8
2016-08-26 12:44:32 +05:30
0589e4d8e2
Bug 1297982 - Replace NS_STYLE_BOX_PACK_* with enum class; r=xidorn
...
MozReview-Commit-ID: Cx20hOJbmad
--HG--
extra : rebase_source : 8a537ab49ee23c99ea7e8ba1a58bf3f487c53092
2016-08-26 12:41:54 +05:30
ca8ee9dc38
Bug 1297982 - Replace NS_STYLE_BOX_ALIGN_* with enum class; r=xidorn
...
MozReview-Commit-ID: EO8hXmXooft
--HG--
extra : rebase_source : ef1e01a373964d5cb7207f87e14e85a9a1dab7fd
2016-08-26 12:39:19 +05:30
0b438b8b77
Bug 1295895 - Correctly capitalize StyleFillRule; r=heycam
...
MozReview-Commit-ID: ZfHrllA9QV
--HG--
extra : rebase_source : d9b9303d21b3fb5977247ae403caabfd54d666f8
2016-08-17 12:13:26 +05:30
6519960758
Bug 1295177 - Convert STYLE_FILL_RULE_* to an enum class; r=xidorn
...
MozReview-Commit-ID: HnNFNyD4oVJ
--HG--
extra : rebase_source : 12dcee0023ec66a49ea2db673bb5ac85cd006c1e
2016-08-15 21:47:04 +05:30
2cfc61be79
Bug 1291667 - Removed unused variant 'MozNone' from StyleUserSelect enum class; r=heycam,manishearth
...
MozReview-Commit-ID: 53dJd2GYUdt
--HG--
extra : rebase_source : 406d58b113d3044eb9f48b02fdd0168494c22847
2016-08-10 21:43:34 +05:30
61b118d165
Bug 1291667 - Change NS_STYLE_USER_SELECT_* constants to enum classes; r=heycam,manishearth
...
MozReview-Commit-ID: IcDt3XYvdlj
--HG--
extra : rebase_source : ea426ac572b6adfc09fd9440e45a0c26adde4373
2016-08-10 21:42:21 +05:30
b8899e7e16
Bug 1293604 - Replace NS_STYLE_FLOAT_* with StyleFloat enum class. r=dbaron
...
MozReview-Commit-ID: 4K6TyIm6cs3
--HG--
extra : rebase_source : b6210815b7c03d5634fdddf8080a3da4e090d194
2016-08-09 17:32:54 +08:00
3e0b364f59
Bug 1288626 Part 8 - Add shape-outside support to style system. r=heycam
...
I have to move the definition of StyleBasicShape and StyleShapeSource prior to
where nsStyleDisplay::mShapeOutside is defined since the template struct need to
be fully defined before using as a member variable.
Use SetIdent() in CreatePrimitiveValueForBasicShapeOrURL() in
nsComputedDOMStyle.cpp per bug 1288626 comment 6.
MozReview-Commit-ID: 1KZS299CFul
--HG--
extra : rebase_source : d96276a1d514e1e42e1daf6f23e6bbfcb92d3bec
2016-07-22 15:40:01 +08:00
213646c667
Bug 1288626 Part 7 - Rename StyleClipShapeSizing to StyleClipPathGeometryBox. r=heycam
...
Change to geometry box to match the name in the spec.
https://drafts.fxtf.org/css-masking-1/#the-clip-path
MozReview-Commit-ID: 8jDTynCkJ4A
--HG--
extra : rebase_source : c2e165e320c1341012b32b48bfb03b3c9b4f56c5
2016-07-28 13:45:43 +08:00
4ad0c1bbe3
Bug 1288626 Part 5 - Rename StyleClipPathType to StyleShapeSourceType. r=heycam
...
StyleClipPathType will be generalized to StyleShapeSourceType to match this
change.
MozReview-Commit-ID: Igaad2EoSSt
--HG--
extra : rebase_source : 517d7b968e90f8f83e1223d33bd9d59000e034fd
2016-08-04 11:51:20 +08:00
d5b06eeac7
Bug 1288626 Part 2 - Use basic shape enum class defined in nsStyleConsts.h. r=heycam
...
Rename StyleBasicShape to StyleBasicShapeType in nsStyleConsts.h, and
replace the old enum nsStyleBasicShape::Type by the enum class
StyleBasicShapeType.
Also, replace NS_ASSERTION() by MOZ_ASSERT().
MozReview-Commit-ID: EuS4ZtYKsk6
--HG--
extra : rebase_source : b6cb68f91c545cef283c97de222111d3acb64b02
2016-07-27 17:59:33 +08:00
aa628b5054
Bug 720531 - Part 1. Implement space of border-image-repeat CSS property. r=dbaron
2016-07-12 21:50:00 +02:00
52b9ca33f3
Bug 1288383 - Replace NS_STYLE_USER_FOCUS_* with an enum class; r=heycam
...
MozReview-Commit-ID: A7BYcfsn1tI
--HG--
extra : rebase_source : b893331b173a306143e546f0d403ae25f827fae2
2016-07-25 11:56:40 +05:30
d78a51cbcc
Bug 1288383 - Replace NS_STYLE_FLOAT_EDGE_* with an enum class; r=heycam
...
MozReview-Commit-ID: FrH5kGWeXkL
--HG--
extra : rebase_source : 73c3446ba07f31f3fbfb6eca304ebe88cccf359a
2016-07-25 11:56:05 +05:30
b3653dd18e
Bug 1288383 - Replace NS_STYLE_BOX_SHADOW_* and NS_STYLE_BASIC_SHAPE_* with enum classes; r=heycam
...
MozReview-Commit-ID: EgC9rPNXbod
--HG--
extra : rebase_source : 8bd51a9bd776c02979093a0ec76cfc42bcee8ffd
2016-07-25 11:53:27 +05:30
f4dffe63a1
Bug 1288383 - Replace NS_STYLE_CLIP_PATH_* with an enum class; r=heycam
...
MozReview-Commit-ID: H6nwOybonF3
--HG--
extra : rebase_source : db3ab986f7708540219cefa18a21b4624a2dc27a
2016-07-25 11:52:34 +05:30
d4b9fb7cfb
Fix enum indentation; no bug.
...
MozReview-Commit-ID: 27Qpn9fG41U
2016-07-22 10:23:25 +08:00
8add405354
Bug 1287755 - Replace NS_STYLE_CLIP_SHAPE_SIZING_* with an enum class; r=heycam
...
MozReview-Commit-ID: KutLb8H9JOk
--HG--
extra : rebase_source : ae38fcb7ebc8c6d5a8c77c773c8706580e41040c
2016-07-20 11:12:42 +05:30
211af87d45
Bug 1261754 - Trivial follow-up to fix outdated documentation. r=me and DONTBUILD because NPOTB.
...
MozReview-Commit-ID: E5fmJ48Y0xH
2016-07-05 14:20:59 -04:00
c9de3d6a41
Bug 1283679 - fix misspelled mask-composite:subtract keyword. r=dbaron
...
MozReview-Commit-ID: 67UEtupOLoM
--HG--
extra : rebase_source : d5c27da11ae0be79ef551c70cfeb17dcf1c3db67
2016-07-04 11:17:13 +08:00
8c5af6b331
Bug 1282029 Part 2 - Update comments. r=dbaron
...
MozReview-Commit-ID: AB01qG99GeH
--HG--
extra : rebase_source : 333e0c02f9b6ef6daadd841cf4be2e35e72158c3
2016-06-24 17:47:33 +08:00
b0138383bd
Bug 1166728 - Remove support for "box-sizing: padding-box", per CSS WG resolution. r=dholbert r=mats
...
MozReview-Commit-ID: JClqoCUrm11
2016-06-18 23:03:30 +01:00
a045541027
Bug 548372 - Implement round and space values of background-repeat CSS property. r=dbaron
2016-05-06 02:16:00 +02:00
9b377bb0ef
Bug 955857 - Replace CSS word-wrap with overflow-wrap, and add it back as a CSS_PROP_ALIAS. r=dbaron
...
MozReview-Commit-ID: FiZJvm25rNN
--HG--
extra : rebase_source : c7b16fc302e5c7905beea98353faa960db0a9248
2016-05-23 20:27:21 -04:00
24bac18bf5
Bug 1273424 - Rename -moz-float-edge constants to be more consistent with keywords. r=bholley
2016-05-18 11:07:46 -07:00
4ca33888b2
Bug 1271869 - Rename NS_STYLE_TEXT_ALIGN_DEFAULT to NS_STYLE_TEXT_ALIGN_START. r=dholbert
2016-05-11 14:03:34 +10:00
e78be5f934
Bug 1270001 - Rename NS_STYLE_TEXT_TRANSFORM_FULLWIDTH to use underscores consistently. r=xidorn
...
This renaming helps with auto-generated code in stylo.
--HG--
extra : rebase_source : d11cf8190f7aa4a73bf63c55afc97043d7c9c159
2016-05-03 23:32:00 +02:00
cd6a2cb8f8
Bug 1266324 - Rename style const macro for unicode-bidi:bidi-override to be consistent with other style consts. r=jfkthame
2016-04-22 10:37:21 +10:00
d2552e50a5
Bug 759568 - Part 1. Parse background-clip:text; r=dholbert r=heycam
...
MozReview-Commit-ID: BPuQjWYvAuj
2016-04-14 16:28:06 +08:00
ff1d585b2e
Backed out changeset b68e6d1cf93a (bug 759568) for reftest failures
2016-04-14 08:57:57 +02:00
eb3d4dc948
Bug 759568 - Part 1. Parse background-clip:text; r=dholbert r=heycom
...
MozReview-Commit-ID: BPuQjWYvAuj
2016-04-14 12:45:37 +08:00
2a9bc780d3
Backed out changeset 7ec8bfb9bbd4 (bug 759568) for failures in test_all_shorthand.html and more. r=backout
2016-04-12 17:55:52 +02:00
a5da82483b
Bug 759568 - Part 1. Parse background-clip:text; r=dholbert r=heycom
...
MozReview-Commit-ID: BPuQjWYvAuj
2016-04-12 21:58:21 +08:00
910b79dd54
Bug 1209273 - Part 1: Support for adjust-color CSS property. r=dbaron
2016-03-08 09:25:24 -08:00
dc337845d1
Backed out changeset d5a9ff0ae110 (bug 1209273) for test failures in browser_rules_completion-new-property_02.js
2016-04-01 11:58:12 +02:00
af80c17051
Bug 1209273 - Part 1 - Support for color-adjust CSS property. r=dbaron
2016-03-10 10:51:00 +01:00
37e8c9d5cc
Bug 1236400 part 1: Add internal enum values to represent "display: -webkit-box" & "display: -webkit-inline-box". r=mats
...
These new enum values are added with same behavior as their modern flexbox
equivalents -- they're hooked up to NS_NewFlexContainerFrame, and they're
listed alongside the modern flexbox enums in 'switch' & 'if' statements.
There's one exception, which I call out with a comment at the end of the patch:
we don't treat -webkit-box the same as flexbox in IsFlexOrGridDisplayType(),
because that method is used to determine whether we should blockify
inline-level children of a flex/grid container, and we don't want to blockify
any children of a -webkit-box. (Instead, we want to wrap them in an anonymous
flex item. That happens in the next patch.)
MozReview-Commit-ID: 9BB4Ib2KpvE
2016-03-24 09:55:11 -07:00
4985b55721
Bug 1224424 - Replace mask-mode:auto keyword by mask-mode:match-source; r=dbaron
...
MozReview-Commit-ID: FKEJI1rHTIA
--HG--
extra : rebase_source : cdd72c6ae3b44e75d0f3415d99d3a897729a43fc
2016-02-25 17:31:47 +08:00
Adam Velebil
Xidorn Quan
Mats Palmgren
Manish Goregaokar
Jeremy Chen
Emilio Cobos Álvarez
Ravi Shankar
Ting-Yu Lin
Ting-Yu Lin
Ethan Lin
Manish Goregaokar
Cameron McCormack
Kartikaya Gupta
Astley Chen
Kyle Zentner
Lazar Sumar
Thomas Wisniewski
Keith Yeung
CJKu
Carsten "Tomcat" Book
Sebastian Hengst
Tobias Schneider
Daniel Holbert