This prevents the listener from being called after some necessary resources are
destroyed.
There is probably a better solution such as removing the listeners after a
successful run, but I'm unsure of the side effects. We know this solution works
because of precedent (bug 930160) so let's go with the quick & easy for now.
--HG--
extra : rebase_source : 9086ddc50a321f63503dd131dd2c78e73732d200
========
72353409b5
Author: Nick Alexander <nalexander@mozilla.com>
Date: Fri Jan 16 16:27:02 2015 -0800
Bug 1122829 - Part 5: Tighten vertically yet further; start with error view hidden and animate it in/out on v11+.
========
779b280ad9
Author: Nick Alexander <nalexander@mozilla.com>
Date: Fri Jan 16 11:58:04 2015 -0800
Bug 1122829 - Part 4: Tighten Getting Started vertically, and animate the icon in.
========
b92693f004
Author: Nick Alexander <nalexander@mozilla.com>
Date: Fri Jan 16 11:53:54 2015 -0800
Bug 1122829 - Part 3: Don't fill text right to the edges of the entry fields.
A little padding softens the edges, which looks better with the rounded
corners.
========
4db0e9e642
Author: Nick Alexander <nalexander@mozilla.com>
Date: Fri Jan 16 11:50:06 2015 -0800
Bug 1122829 - Part 2: Lower text sizes.
========
fcd7fc33b4
Author: Nick Alexander <nalexander@mozilla.com>
Date: Fri Jan 16 11:54:45 2015 -0800
Bug 1122829 - Part 1: Don't animate back presses between activities.
On modern devices (Android 4.4), this gives a smooth "click" back and
forth between Sign Up and Sign In.
========
e507a6816a
Author: Nick Alexander <nalexander@mozilla.com>
Date: Thu Jan 15 11:34:50 2015 -0800
Bug 1112725 - Avoid blue line on Next button in Create Account activity.
Something changed between Android 4.3 and Android 4.4 which folded the
RelativeLayout's marginBottom into the child calculations in some way.
This simple work-around moves the spacing out of the RelativeLayout and
into the marginTop of the control underneath. All other examples of
this pattern use the marginTop of the control underneath.
Test plan: manually tested on my
* 4.3 Samsung Galaxy S4; and
* 4.4 Google Nexus 5.
========
21c63a8d1a
Author: vivek <vivekb.balakrishnan@gmail.com>
Bug 1058806 - Part 4: Maintain magic year state across orientation changes.
========
da074438fe
Author: vivek <vivekb.balakrishnan@gmail.com>
Date: Fri Jan 16 16:46:47 2015 +0200
Bug 1058806 - Part 3: Maintain magic year across create -> sign in -> create loop.
========
982d692575
Author: vivek <vivekb.balakrishnan@gmail.com>
Date: Sat Dec 20 20:07:45 2014 +0200
Bug 1058806 - Part 2: Add date and month to UI.
========
15594d36c9
Author: vivek <vivekb.balakrishnan@gmail.com>
Date: Sat Dec 20 04:36:49 2014 +0200
Bug 1058806 - Part 1: Make age pass check consider date and month.
--HG--
extra : rebase_source : 11ab11c519461fa1be8d6dda34777620db05468d
This is a sad, but necessary, loss of generality that will cause the
Gradle configuration to lag behind the rest of the build system over
time. The existing Gradle build worked fine, but IDEA based IDEs can
not yet read build.gradle files containing arbitrary Groovy code. I
can find no alternative to including the values in the build.gradle
file directly. We will just try to keep them up to date.
The versions chosen (compileSdkVersion 21 and buildTools "21.1.1")
correspond to the current versions used on the buildbots. Changing
compileSdkVersion to an integer absolutely requires Gradle-Android
plugin version 1.0.0 or higher, which in turn mandates IntelliJ
version 14.0.3 EAP or higher.
I took the opportunity to update some settings and bump dependency
versions from v19 to v21 as well.
--HG--
extra : rebase_source : 7ada8da4dec7bd56ca3d276d833788d895e12e25
We previously used the *selected* tab, not the argument tab as we should have.
Also, the forward/back button state appeared incorrectly because a newly added
method made assumptions that BrowserToolbarNewTablet.cancelEdit would only be
called when we were in editing mode - fixed that by only doing that code while
we're still in editing mode.
Brian Nicholson
Michael Comella
dominique vincent
Phil Ringnalda
Andy Pusch
Brian O'Keefe
Jeff Muizelaar
Robin Ricard
Nick Alexander
Vivek Balakrishnan
Chenxia Liu
Mark Finkle
wesj
Carsten "Tomcat" Book
Margaret Leibovic
Richard Newman
Ryan VanderMeulen
Giovanny Andres Gongora Granada
Ganesh Sahukari
Jalpreet Singh Nanda
James Dearing
Allison Naaktgeboren
J. Ryan Stinnett