Jeff Muizelaar
d9f4daaff9
Bug 700773. qcms: cleanup up some integer types. r=bgirard
...
This fixes a couple of warnings in clang and makes things more consistent.
--HG--
extra : rebase_source : feac84090f270461a73de955902bc016b5835616
2011-11-08 15:43:33 -05:00
Yati Sagade
4426ead531
Bug 550969 - Fix white_point_from_temp to handle out of range input. r=jmuizelaar
2011-10-14 14:58:34 -04:00
Landry Breuil
712a60acbc
Bug 651444 - inttypes.h is needed on OpenBSD to get uintptr_t; r=jmuizelaar
2011-09-27 19:59:34 +01:00
Landry Breuil
521e9fa30c
Bug 651444 - Dont redefine intX_t types on OpenBSD; r=jmuizelaar
2011-09-20 17:32:18 +01:00
Jeff Muizelaar
186fdbec03
Bug 676747. qcms: Fix a warning about using the wrong function type. r=bgirard
...
--HG--
extra : rebase_source : 177b781ea8f8cc350283bd082cbd3600433c3f82
2011-08-05 09:49:45 -04:00
Benoit Girard
e6e07e47b0
Bug 674230 - Merge from qcms github branch v4; r=jmuizelaar
2011-07-27 10:11:19 -04:00
Jeff Muizelaar
05510f6c09
Bug 672280. qcms: Use C99-style flexible arrays. r=bgirard
...
This is in preparation for adding more of these for the
upcoming ICCv4 parsing.
2011-07-19 11:17:47 -04:00
Jeff Muizelaar
28b5f7d673
qcms: avoid unnecessary promotion to double. r=ehsan
2011-05-10 12:01:48 -04:00
Jeff Muizelaar
1eac9663aa
Bug 605179. qcms: revert build warning fixes. r=ehsan
...
0ec22e77aefc fixed some build warnings that no longer happen because pedantic is disabled.
2011-05-10 11:55:39 -04:00
Jeff Muizelaar
7d31ce1e77
Bug 648446. Remove -pedantic from CFLAGS in qcms. r=khuey
...
-pedantic causes warnings that we don't care about
2011-04-08 11:34:16 -07:00
Jeff Muizelaar
b9abe889a0
Bug 646321. qcms: Avoid implicit conversion to double. r=bjacob
...
The double literal will cause us to unnecessarily convert to double.
2011-04-07 16:59:12 -07:00
Makoto Kato
a63db003fb
Bug 613440. Make loading ICM profiles from non-ASCII paths work. r=jmuizelaar
2011-03-30 13:40:47 -04:00
Jeff Muizelaar
76b8dd5301
Bug 506207 - Check the return value of fread to make sure the readed data is valid; r,a=joe
2011-02-28 13:01:05 -08:00
Ms2ger
78236f0f98
Bug 605179 - Fix build warnings in gfx/; r=roc a=bsmedberg
...
--HG--
extra : rebase_source : f9bd24d5f4bc6124b431ce22e6ac72bd218dc208
2010-12-05 18:38:12 +00:00
Jacek Caban
7e554d4fdb
Bug 594769 - qcms fails to compile on mingw r=jmuizelaar a=joe
2010-10-14 21:00:22 +00:00
Benoit Girard
b7fb412e8b
Bug 575142 - qcms_transform_create should use transform_free. r=jmuizellar
2010-07-24 20:10:15 -04:00
Daniel Holbert
0a2d04e6df
Bug 503279: disable spammy 'missing initializer' warning in imported code within gfx. r=jrmuizel
2010-07-13 11:50:18 -07:00
Justin Wood
7404e635db
Bug 467051 - Introduce GLOBAL_DEPS to build system (gfx/cairo) r=vlad, feedback+=ted
...
--HG--
extra : rebase_source : 3dee9c67387cb9b72dd81da6d52ad996afa2bfae
2010-05-30 22:49:32 -04:00
Jacek Caban
425f7b166a
Bug 569475 - Fix qcms linking failure on mingw-w64. r=jmuizelaar
...
--HG--
extra : rebase_source : 07a082564d002faeaedc4fb57911ec9d64b605fd
2010-06-07 10:16:22 +02:00
Jeff Muizelaar
e6b3a462fa
Bug 548612. qcms: Reduce size of output lookup tables. r=bgirard
...
We currently use a larger output lookup table than we probably need. Switch to
a common define for the table size and lower it. The should also give a small
improvement to startup time because we have fewer lookup table entries to
compute.
2010-06-04 14:48:30 -04:00
Daniel Holbert
d2a1c857c0
Bug 561787: Add missing #include to iccread.c, to fix compile warnings about declarations of memcpy. r=roc
2010-04-28 23:13:13 -07:00
Michael Wu
e7503e900c
Bug 556405 - Support building qcms on Android, r=jrmuizel
2010-04-05 17:38:43 -07:00
Jeff Muizelaar
0d8421521c
Bug 550188. qcms: remove an empty loop that annoyed coverity. r=bgirard
2010-03-04 12:13:13 -05:00
Steve Snyder
9d5575fe90
qcms: Replace second green table release with release of blue table
...
Cut 'n' paste gone awry: green output table freed instead of blue.
That is, there exists a release for red, 2 releases for green, and none for
blue.
2010-02-18 15:21:11 -05:00
Makoto Kato
49b6a5ee05
Bug 536725 - Disable SSE1 code on Windows x64 r=jmuizelaar
2010-02-01 17:43:21 +09:00
Shailen
5acc0bfd81
Bug 523848 - qcms typedef clashes on AIX with <sys/types.h>. r=jmuizelaar, sr=roc
2010-01-20 11:21:19 +01:00
Ginn Chen
a4fbc88542
Bug 537070 qcms failed to build with -m64 on Solaris x86_64 r=jrmuizel
2010-01-06 15:02:04 +08:00
Ginn Chen
d8150c3a0f
Bug 522440 QCMS: Make sse/sse2 code built with Sun Studio 12 on Solaris r=jmuizelaar, ted.mielczarek
2009-11-20 14:15:39 +08:00
Jeff Muizelaar
50543d8818
Backout 8a790e81279e (bug 528322) because wince doesn't have powf.
...
The link error was obscured by other errors when I ran this on try...
2009-11-13 11:53:12 -05:00
Jeff Muizelaar
feb0e8dd5f
Bug 528322. qcms: Avoid unneeded precision during table creation. r=joe
...
Switch from pow() to powf() because it's faster and we don't need the
additional precision. Also avoid unnecessary conversion to and from doubles by
using float constants instead of doubles.
2009-11-13 10:14:13 -05:00
Jeff Muizelaar
0d2d8d41c8
Bug 488800. qcms: accept ICCv4 profiles. r=bobbyholley
...
ICCv4 profiles are a superset of ICCv2 so it shouldn't hurt us to accept them and
just treat them the same way we do ICCv2 profiles.
2009-10-02 17:57:25 -04:00
Steve Snyder
726ac89b07
Bug 512865. qcms: Improve SSE2 performance, add SSE support. r=jrmuizel
...
This patch greatly improves the performance of QCMS transformations on x86 &
x86_64 systems. Some notes:
0. On 32-bit x86 systems it does runtime selection between non-SIMD, SSE, and
SSE2 code paths.
1. On x86_64 systems the SSE2 code path is always taken. The non-SIMD and SSE
code paths are left intact, but contemporary versions of the GCC and MSVC
compilers will see that they cannot be reached and optimize them away.
2. The execution of the SSE2 code path is reduced by 67%, relative to the
original Intel/Microsoft formatted ASM code. The relative performance is seen
on a Pentium4 (Northwood) 2.4GHz CPU with DDR1 RAM.
3. The SSE code path provides a 80% reduction in execution time, relative to
the non-SIMD code path. The relative performance is seen on a Pentium3
(Coppermine) 1.26GHz CPU with SDRAM.
4. The code has been split out into separate files so that it can be built
with different cflags (-msse, and -msse2) when using gcc.
5. Try to land again, this time with __attribute__((__force_align_arg_pointer__))
to avoid crashes on linux.
2009-10-01 14:19:41 -04:00
Jeff Muizelaar
3f907e258a
Backed out changeset cb4f078cc8cb (bug 512865)
...
Was causing crashes on the leak test box.
2009-09-24 23:35:53 -04:00
Steve Snyder
7e089e6fae
Bug 512865. qcms: Improve SSE2 performance, add SSE support. r=jrmuizel
...
This patch greatly improves the performance of QCMS transformations on x86 &
x86_64 systems. Some notes:
0. On 32-bit x86 systems it does runtime selection between non-SIMD, SSE, and
SSE2 code paths.
1. On x86_64 systems the SSE2 code path is always taken. The non-SIMD and SSE
code paths are left intact, but contemporary versions of the GCC and MSVC
compilers will see that they cannot be reached and optimize them away.
2. The execution of the SSE2 code path is reduced by 67%, relative to the
original Intel/Microsoft formatted ASM code. The relative performance is seen
on a Pentium4 (Northwood) 2.4GHz CPU with DDR1 RAM.
3. The SSE code path provides a 80% reduction in execution time, relative to
the non-SIMD code path. The relative performance is seen on a Pentium3
(Coppermine) 1.26GHz CPU with SDRAM.
4. The code has been split out into separate files so that it can be built
with different cflags (-msse, and -msse2) when using gcc.
2009-09-24 11:58:24 -04:00
Vladimir Vukicevic
d4133284fb
Bug 504766. qcms: Fix unaligned reads in qcms. r=jrmuizel
...
Offsets are not guaranteed to be aligned, so don't assume that they are.
memcpy instead of just casting and dereferencing.
2009-09-08 11:36:28 -04:00
timeless@mozdev.org
aa0a779122
Bug 491195 fix warnings in qcms
...
mostly comparisons between unsigned and signed
also an incomplete initializer
and a warning about using C++ style variables
r=jrmuizel
2009-07-22 17:31:03 -05:00
Jeff Muizelaar
a5cefc0393
Bug 504888. qcms: Avoid integer overflow when checking buffer bounds. r=bobbyholley
...
Found by Chris Evans
2009-07-21 23:32:27 -04:00
Jeff Muizelaar
5f01b80d83
Bug 498245. Check that the profile is an RGB profile before checking if it's bogus. r=bholley
...
This avoids unitialized reads on non-RGB profiles.
2009-07-02 11:34:08 -04:00
Jeff Muizelaar
75e4ff4fd2
Bug 498245. Profiles with negative colorant tristiumlus values are bogus. r=bholley
...
Make sure we reject these profiles.
2009-07-02 11:34:06 -04:00
Jeff Muizelaar
f9b6997806
Bug 497363. qcms: Fix a memory leak when fread() fails. r=joedrew
...
Fixes a possible leak in qcms_profile_from_file() when fread()
can't read the entire profile.
2009-06-12 14:38:34 -04:00
Jeff Muizelaar
99d30c3bf9
Bug 497363. qcms: Add reference to the rationale for not correcting alpha. r=joedrew
2009-06-12 14:38:32 -04:00
Jeff Muizelaar
341c2ba4c7
Bug 497363. qcms: Use a minimum of 256 entries when calling invert_lut. r=joedrew
...
Makes the number of output entries produced by invert_lut() a parameter and
changes all callers to use a minimum of 256 entries when computing the inverse.
2009-06-12 14:38:30 -04:00
Jeff Muizelaar
da6dd3cda6
Color profile reading is broken on windows. b=492962 r=joe
...
The fix is to properly fopen() with "rb" instead of just "r", so that windows knows to treat it as a binary
2009-05-15 18:07:34 -04:00
Peter Weilbacher
8f59ba8025
Bug 488468: qcms build break with pre-4 GCCs (#if 0 commented text should be C/C++ commented), r=jmuizelaar
2009-04-23 19:38:11 +02:00
Jeff Muizelaar
a0d9e260b1
Bug 488955 - Fix linear gamma input tables, used in iCCP PNG testsuite images. r=joe
2009-04-22 13:49:09 -04:00
Jeff Muizelaar
90fcc20f84
Bug 488747 - Fix endian handling in qcms. r=joe
2009-04-21 22:22:29 -04:00
Jeff Muizelaar
dcd15d3bce
Bug 489133 - Handle bad cHRM chunks in PNGs. r=joe
2009-04-21 22:21:48 -04:00
Jeff Muizelaar
780d2ffe8c
Bug 489133 - Fix handling of bad whitepoints in PNGs. r=joe
2009-04-21 22:21:13 -04:00
Makoto Kato
784aeab18f
Bug 487900 - Enable SSE2 code for x86_64 in qcms. r=jmuizelaar
2009-04-15 22:14:03 +09:00
Ginn Chen
334cd17929
Bug 487765 - Fix qcms build problems on Solaris. r=jrmuizel
2009-04-14 11:25:31 -04:00