Mihai Alexandru Michis
33899422e7
Backed out 2 changesets (bug 1635235, bug 1635239) for causing Bug 1640583.
...
CLOSED TREE
Backed out changeset 97ecda13df18 (bug 1635239)
Backed out changeset c9f80397bbec (bug 1635235)
2020-05-25 16:43:03 +03:00
Lina Cambridge
53047a8297
Bug 1640528 - Allow extension storage to be enabled and disabled independently of add-ons. r=markh
...
By default, toggling the add-ons engine also toggles extension storage.
However, it's also possible to enable extension storage without add-ons
by setting an override pref. If the override pref is set, we'll treat
extension storage as an engine that can be toggled independently. If
it's not set, we'll ignore attempts to toggle the engine separately.
Differential Revision: https://phabricator.services.mozilla.com/D76635
2020-05-25 01:12:16 +00:00
Mark Banner
019b662f87
Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
...
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.
We do not check for updates - if something is removed, we'll wait until next startup before processing it.
Also adds lots of tests for canOverride as this seems a critical part to get right.
Differential Revision: https://phabricator.services.mozilla.com/D76473
2020-05-24 21:45:41 +00:00
Rob Wu
8c4c5239e9
Bug 1636158 - Document how to use attachment dumps in RemoteSettings r=leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D76159
2020-05-22 13:09:50 +00:00
Mathieu Leplatre
b25d0ae2e5
Bug 1639224 - Verify signature if local timestamp is in the future r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D76249
2020-05-22 00:27:06 +00:00
Mathieu Leplatre
8965849d47
Bug 1639684 - Report server_error on HTTP 5XX when polling for changes r=rdalal
...
Differential Revision: https://phabricator.services.mozilla.com/D76242
2020-05-21 23:59:58 +00:00
Lina Cambridge
400ff2f682
Bug 1639942 - Correctly register `Extension-Storage` engine alternatives. r=tcsc
...
Alternative engines are registered using the lowercased version of
the keys in the modules object. But `extension-storage` is hyphenated,
so we need to use `Extension-Storage` (not `ExtensionStorage`) as the
key name, to match the name of the engine and its collection.
Without the hyphen, we'll register the alternative as
`extensionstorage`, so it'll never be used because everything else
expects the engine to be called `extension-storage`.
Differential Revision: https://phabricator.services.mozilla.com/D76355
2020-05-21 18:55:37 +00:00
Sid Stamm
56c4be9954
Bug 1002724
- use resolvable URL in fxaccounts browser chrome tests. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75086
2020-05-21 17:33:32 +00:00
ffxbld
663946fddd
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D76324
2020-05-21 14:05:50 +00:00
Lina Cambridge
efbc79edbd
Bug 1639727 - Fix `trackRemainingChanges` in the tabs and prefs Sync engines. r=markh
...
This commit fixes two issues: moves `trackRemainingChanges` to the
engine, since that's where it defined (not on the store), and skips
setting `modified` if all records have been successfully uploaded.
Differential Revision: https://phabricator.services.mozilla.com/D76270
2020-05-21 07:13:12 +00:00
Vlad Filippov
de6e0f725b
Bug 1632557 - Add pref and logic for direct use of session tokens to provision OAuth tokens r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75204
2020-05-20 22:06:35 +00:00
Lina Cambridge
faf2fd15e4
Bug 1639018 - Change `TaskRunnable::dispatch` to take owned runnables. r=froydnj
...
This matches how the `Dispatch(already_AddRefed<nsIRunnable>)`
overloads work in C++: `Dispatch` takes ownership of the runnable, and
leaks it if dispatch fails—because the thread manager is shutting down,
for instance. This avoids a race where a runnable can be released on
either the owning or target thread.
Rust doesn't allow arbitrary `Self` types yet (see
rust-lang/rust#44874 ), so we need to change `dispatch` and
`dispatch_with_options` to be associated methods.
Differential Revision: https://phabricator.services.mozilla.com/D75858
2020-05-20 20:54:49 +00:00
Florian Quèze
3449d19a7e
Bug 1637637 - disable fast shutdown for the test_prefs_store.js and test_prefs_tracker.js tests where it crashes, r=gbrown.
...
Depends on D72407
Differential Revision: https://phabricator.services.mozilla.com/D76167
2020-05-20 16:35:51 +00:00
Vlad Filippov
cf78a3d737
Bug 1635937
- Enable 'identity.sync.useOAuthForSyncToken' pref for Nightly users r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75130
2020-05-19 21:32:50 +00:00
Vlad Filippov
a3a78de9e9
Bug 1637827 - Handle expired OAuth tokens while provisioning Sync tokens r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75630
2020-05-18 22:46:51 +00:00
Vlad Filippov
5bc4cabe33
Bug 1633641 - Provide a method to fetch an OAuth token and its key in a single operation. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D74534
2020-05-18 01:13:46 +00:00
Noemi Erli
c1cca03e21
Backed out 6 changesets (bug 1002724
) for failing in browser_fall_back_to_https.js CLOSED TREE
...
Backed out changeset e487b4cd9223 (bug 1002724
)
Backed out changeset 37473a8ba1fd (bug 1002724
)
Backed out changeset e868f1e0af0e (bug 1002724
)
Backed out changeset 1c57f8717b15 (bug 1002724
)
Backed out changeset 782808a05ff8 (bug 1002724
)
Backed out changeset c60c48d170e1 (bug 1002724
)
2020-05-18 19:22:19 +03:00
Sid Stamm
b45bfd711c
Bug 1002724
- use resolvable URL in fxaccounts browser chrome tests. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75086
2020-05-18 15:08:45 +00:00
Csoregi Natalia
179b0c82b2
Backed out 6 changesets (bug 1002724
) for bustage on nsDocShell.cpp. CLOSED TREE
...
Backed out changeset 56ba616e2644 (bug 1002724
)
Backed out changeset d481cf074d3b (bug 1002724
)
Backed out changeset da26540ecee5 (bug 1002724
)
Backed out changeset 01cbf611158a (bug 1002724
)
Backed out changeset b60ba645f1f4 (bug 1002724
)
Backed out changeset 4ebad0d2ca0a (bug 1002724
)
2020-05-18 16:06:55 +03:00
Sid Stamm
7697eda5ae
Bug 1002724
- use resolvable URL in fxaccounts browser chrome tests. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D75086
2020-05-15 18:42:15 +00:00
Edouard Oger
30060195fb
Bug 1631630 p2 - Implement FxAccounts rust-bridge. r=lina,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D71852
2020-05-16 01:07:31 +00:00
Noemi Erli
cac2780d42
Backed out 2 changesets (bug 1631630) for causing mass braoser chrome failures CLOSED TREE
...
Backed out changeset 9b8606a93c75 (bug 1631630)
Backed out changeset d57ea5d1921f (bug 1631630)
2020-05-16 02:16:33 +03:00
Edouard Oger
9b739cf68d
Bug 1631630 p2 - Implement FxAccounts rust-bridge. r=lina,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D71852
2020-05-15 20:13:36 +00:00
Mark Hammond
1b47bf54f2
Bug 1635352 (part 2) - Add TPS test for new extension-storage engine. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D74610
2020-05-15 01:30:21 +00:00
Mark Hammond
5de4cd6458
Bug 1635352 (part 1) - Add a new bridged extension-storage engine. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D74609
2020-05-15 01:30:14 +00:00
Mark Hammond
6e4d1af4af
Bug 1623245 - A new browser.storage.sync local storage implementation, pref'd off. r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D67273
2020-05-15 01:29:56 +00:00
ffxbld
9f539b6b93
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D75307
2020-05-14 14:04:23 +00:00
Lina Cambridge
390e79aba0
Bug 1637809 - Replace `try_fold` with `map` in Golden Gate. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D75226
2020-05-14 00:00:18 +00:00
Edouard Oger
6e8ef040d3
Bug 1637537 - Bump application-services and anyhow versions. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D75150
2020-05-13 18:36:56 +00:00
Michael Kaply
bd4fad19d2
Bug 1487529 - Don't sync addons prevented by policy. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D74889
2020-05-13 17:13:23 +00:00
Lina Cambridge
d2af2ad1c8
Bug 1636365 - Add more docs for `BridgedEngine`, and remove `BridgedTracker`. r=markh,rfkelly
...
Now that we have a `Tracker` base class without persistence, we can
have bridged engines subclass it directly.
Differential Revision: https://phabricator.services.mozilla.com/D74375
2020-05-13 03:56:55 +00:00
Lina Cambridge
6245c3b363
Bug 1636365 - Split out persistence from `Tracker` into `LegacyTracker`. r=markh,rfkelly
...
The tracker base class currently does two things: bump the score in
response to observer notifications, and store a list of changed IDs.
The bookmarks, form autofill, and now bridged trackers need to hack
around this to opt out of persistence, since they handle change
tracking in the storage layer.
This commit keeps the score logic in `Tracker`, but moves all the
persistence code into an intermediate `LegacyTracker` class, and
changes all engines that need persistence to inherit from it.
`ignoreAll` is more interesting. We want new-style stores to emit
observer notifications with change sources, so that the tracker knows
to ignore changes made by Sync. Ignoring all observer notifications
during a sync is a blunter version of this. But, not every new store
supports change sources, so we reimplement `ignoreAll` manually for
ones that don't.
Differential Revision: https://phabricator.services.mozilla.com/D74374
2020-05-13 03:56:53 +00:00
Lina Cambridge
c282dce0eb
Bug 804479 - Re-enable all Sync tests on debug builds. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D74980
2020-05-12 22:10:03 +00:00
Edouard Oger
e348b78f5f
Bug 1628068 p1 - Vendor viaduct crate. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D70256
2020-05-12 21:36:17 +00:00
Mark Banner
6212949ff5
Bug 1634562 - Fix default engines for okru and mailru distributions in certain regions. r=daleharvey
...
Yandex is default in these regions, so for okru-001 and mailru-001 we just turn that off.
Differential Revision: https://phabricator.services.mozilla.com/D73948
2020-05-12 16:42:58 +00:00
Mark Banner
9edd298c88
Bug 1635056 - Fix and prevent duplicate parameters in search queries for distribution engines. r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D73937
2020-05-12 16:42:58 +00:00
Mark Banner
0750ee867a
Bug 1630980 - Add more tests for search engine distributions in different locales and fix yandex.ua inclusion. r=daleharvey,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D72951
2020-05-12 16:42:40 +00:00
Mark Banner
6a4cc10797
Bug 1630980 - Add orders for distribution engines. r=daleharvey,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D72950
2020-05-12 16:42:18 +00:00
Mark Banner
abc975a9ac
Bug 1630980 - Remove orders for current engines, let them be alphabetical. r=daleharvey,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D72949
2020-05-12 16:42:10 +00:00
Mark Banner
71c4b59978
Bug 1630980 - Add default engine information for distribution engines to the modern search configuration. r=daleharvey,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D72948
2020-05-12 16:42:08 +00:00
Mark Hammond
0640090392
Bug 1637169 - Vendor new application-services. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D74817
2020-05-12 07:53:39 +00:00
Bogdan Tara
a823ee6545
Backed out 2 changesets (bug 1628068) for ViaductRequest.cpp related bustages CLOSED TREE
...
Backed out changeset 013a469557c1 (bug 1628068)
Backed out changeset dcda2ce7b7f9 (bug 1628068)
2020-05-12 00:44:58 +03:00
Edouard Oger
4e005845ab
Bug 1628068 p1 - Vendor viaduct crate. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D70256
2020-05-11 21:01:17 +00:00
Bogdan Tara
3df4970bcc
Backed out 2 changesets (bug 1628068) for ViaductRequest.cpp related bustages CLOSED TREE
...
Backed out changeset 928a5891c55d (bug 1628068)
Backed out changeset b6fe5d357bed (bug 1628068)
2020-05-11 23:52:47 +03:00
Edouard Oger
3dc0990bbf
Bug 1628068 p1 - Vendor viaduct crate. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D70256
2020-05-11 20:19:11 +00:00
Bogdan Tara
448d53548b
Backed out 2 changesets (bug 1628068) for ViaductRequest.cpp related bustages CLOSED TREE
...
Backed out changeset 1ea8f742ca69 (bug 1628068)
Backed out changeset 3aa2f99843e0 (bug 1628068)
2020-05-11 23:06:31 +03:00
Edouard Oger
8aebe42eda
Bug 1628068 p1 - Vendor viaduct crate. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D70256
2020-05-11 19:14:21 +00:00
Cosmin Sabou
b51ad59f7d
Backed out changeset 8f97a01a0a84 (bug 1543697) for causing bc failures on FxAccountsConfig.jsm. CLOSED TREE
2020-05-11 21:29:49 +03:00
ffxbld
f78dade689
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D74713
2020-05-11 17:44:03 +00:00
Vijay Budhram
3485e6263e
Bug 1543697 - Fix FxAccounts.config manage device promises r=eoger,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D27279
2020-05-11 17:05:32 +00:00