Jonathan Kew
d2e0daf015
Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert
2015-06-20 21:00:33 +01:00
Jonathan Kew
31469f3572
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
L. David Baron
2c5c24868e
Back out changesets ed293fc9596c and f18cb4c41578 (bug 1174700) for fatal assertions in all Windows debug reftest runs.
...
CLOSED TREE
Assertion failure: origKidNormalPosition.B(wm) == 0, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/layout/tables/nsTableRowFrame.cpp:861
TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/ua-style-sheet-size-1.html | application terminated with exit code 1
2015-06-20 22:41:07 -07:00
Jonathan Kew
cb44db0b95
Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert
2015-06-20 21:00:33 +01:00
Jonathan Kew
daf28cd1e7
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
Jonathan Kew
a3380043e5
Bug 1174507 - Replace the frame flag CONTAINS_RELATIVE_HEIGHT with CONTAINS_RELATIVE_BSIZE, and adjust callsites appropriately. r=dholbert
2015-06-18 07:33:50 +01:00
Jonathan Kew
84d9d4e6f1
Bug 1157569 - part 12 - Convert physical values from BCPropertyData to logical when returning from Get[Included]OuterBCBorder. r=roc
2015-06-17 11:03:25 +01:00
Mats Palmgren
479bf4c89b
Bug 1174450 part 9 - Remove the nsRenderingContext* param from Intrinsic*SizeOffsets methods since it's unused. r=jfkthame
2015-06-16 11:21:04 +00:00
Xidorn Quan
6e3fc0bd96
Bug 1171328 - Convert nsTableFrame::GetChildAreaOffset() and its friends to use LogicalMargin. r=dholbert
...
--HG--
extra : source : 5d48d96995a1b2fd4aefc463d0f2fb2d156e0406
2015-06-10 13:13:49 +12:00
Daniel Holbert
de95224fec
Bug 1169432 part 5: Use range-based 'for' loops when walking frame lists, in nsTableFrame. r=mats
2015-06-05 15:39:35 -07:00
Daniel Holbert
fff00b71d3
Bug 1169432 part 4: Convert NS_ASSERTION(false, ...) to NS_ERROR(...) in nsTableFrame. r=mats
2015-06-05 15:39:27 -07:00
Daniel Holbert
b864ce9764
Bug 1169432 part 3: Use nsTArray::Contains instead of nsTArray::IndexOf(), for brevity, in nsTableFrame. r=mats
2015-06-05 15:39:13 -07:00
Daniel Holbert
d19a227430
Bug 1169432 part 2: Refactor nsTableFrame::Init. r=mats
2015-06-05 15:39:06 -07:00
Simon Montagu
7f1b0db94c
Bug 1147834: Use abstract coordinates in nsHTMLReflowState, r=jfkthame
2015-06-04 03:43:02 -07:00
Daniel Holbert
7c9227860d
Bug 1167696 part 2: Remove nsTableReflowState's frame constructor-arg; get it from passed-in reflow state instead. r=mats
2015-05-25 19:43:50 -07:00
Daniel Holbert
98a086029d
Bug 1167696 part 1: Remove nsTableReflowState's unused constructor & nsPresContext arg. r=mats
2015-05-25 19:43:10 -07:00
Daniel Holbert
548da769cc
Bug 1167765: Misc whitespace cleanup in nsTableFrame.cpp. whitespace/rewrapping-only, no review, DONTBUILD
2015-05-22 14:23:44 -07:00
Xidorn Quan
64a7a40bf2
Bug 1159127 - Always redirect inserting col group frame to first-in-flow table frame. r=mats
...
--HG--
extra : source : 2f6fc7196b2bc0720035c3007bbafb63e2e974bd
2015-05-20 13:29:43 +12:00
Xidorn Quan
bf6ef0da30
Bug 1157569 part 12 - Remove useless m{Start,End}Side from BCMapCellInfo. r=roc
...
--HG--
extra : source : ac5101097059182858dc0f5d20fe0263b5d5ca7a
2015-05-04 19:09:25 +12:00
Xidorn Quan
1f8102a880
Bug 1157569 part 11 - Rename methods and fields in nsTableCellFrame from physicals to logicals. r=roc
...
--HG--
extra : source : fa5e5be043d1887ac62b8e2ab5b67366cf207058
2015-05-04 19:09:25 +12:00
Xidorn Quan
79661faf79
Bug 1157569 part 9 - Rename methods and fields in nsTableRowFrame from physicals to logicals. r=roc
...
--HG--
extra : source : ce0fb2e11506e7aafffd88ee628bf8485648de24
2015-05-04 19:09:25 +12:00
Xidorn Quan
a6a99c50ec
Bug 1157569 part 8 - Move some code in BCPaintBorderIterator::SetDamageArea for less computation. r=roc
...
--HG--
extra : source : ccac169ecb8651b6a9f598444f228bdf14866f2c
2015-05-04 19:09:25 +12:00
Xidorn Quan
df305b8624
Bug 1157569 part 7 - Rename methods and fields in nsTableColFrame from physicals to logicals. r=roc
...
--HG--
extra : source : 9f6e318183c92842dfe337aa6da9af62cfc45cd8
2015-05-04 19:09:25 +12:00
Xidorn Quan
ffd497f5a6
Bug 1157569 part 6 - Rename methods and fields in BCMapCellInfo from physicals to logicals. r=roc
...
--HG--
extra : source : 354bacf8949d29d8f44862b5b1b514da824d62ee
2015-05-04 19:09:25 +12:00
Xidorn Quan
ac14c15e2c
Bug 1157569 part 5 - Convert GetColorAndStyle, GetPaintStyleInfo, and CompareBorders in nsTableFrame to accept writing mode and logical side. r=roc
...
This changes behavior of border collapse on RTL tables, but it seems
that there is no test coverage on those cases, and those cases should
have been broken before, due to the mix of m{Start,End}side and
physical sides in the methods. Hence this change should be fine, as
long as we are going to fix it in later patches.
--HG--
extra : source : b9e8bf39a62add595d939ebd3714d7e6a690af22
2015-05-04 19:09:25 +12:00
Xidorn Quan
4a5f54af06
Bug 1157569 part 4 - Replace mTableIsLTR with mTableWM in BCMapCellInfo & BCPaintBorderIterator. r=roc
...
--HG--
extra : source : 7e56026f20086c4b1c705609562b9dc43ccb2b91
2015-05-04 19:09:25 +12:00
Xidorn Quan
38812d4032
Bug 1157569 part 3 - Merge two GetColorAndStyle functions in nsTableFrame. r=roc
...
--HG--
extra : source : a2eef88e064cefd04b14409ac78245dafffbee7f
2015-05-04 19:09:25 +12:00
Xidorn Quan
bd0cb193a2
Bug 1157569 part 2 - Convert output parameters of GetColorAndStyle/GetPaintStyleInfo in nsTableFrame to use pointers. r=roc
...
--HG--
extra : source : cea85dbc11f7ea58e2c64be5d619c847bdcb368c
2015-05-04 19:09:25 +12:00
Xidorn Quan
48d1d4f3e5
bug 1157569 part 1 - Rename BC_BORDER_{TOP,RIGHT,BOTTOM,LEFT}_HALF* to BC_BORDER_{START,END}_HALF*. r=roc
...
--HG--
extra : source : 5a1c4c8f584b89b2d65c43f325ffa4a070a4f7b6
2015-05-04 19:09:25 +12:00
Xidorn Quan
ef54b4b14f
Bug 1159990 - Add TableArea struct and replace nsIntRect with it for table damage area. r=roc
...
--HG--
extra : source : bdc7bf00559b80ae6a4f9c60848e34542f438218
2015-05-01 09:46:59 +12:00
Daniel Holbert
2557a4c19e
Bug 1155880
part 3: Rename nsTableFrame::GetColumnWidth to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:27 -07:00
Daniel Holbert
d4904872c9
Bug 1155880
part 2: Rename nsTableColFrame Get/Set/ResetFinalWidth methods to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:26 -07:00
Daniel Holbert
2f0de265e8
Bug 1155880
part 1: Rename nsITableLayoutStrategy::ComputeColumnWidths and associated comments to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:24 -07:00
Daniel Holbert
1e4637780c
Bug 1155798: Drop end-of-line whitespace from C++ files in layout/tables. (whitespace-only, no review, DONTBUILD)
2015-04-17 11:42:05 -07:00
Mats Palmgren
2f31bdf840
Bug 1143299 - Make frame insertion methods deal with aPrevFrame being on an overflow list. r=roc a=abillings
2015-04-11 00:21:06 +00:00
Mats Palmgren
ea742f35e6
Bug 1148833 part 4 - Fix indentation of some Reflow params (white-space changes only).
2015-03-29 22:38:40 +00:00
Mats Palmgren
ed9ed2d61a
Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc
2015-03-29 22:38:40 +00:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Xidorn Quan
69bd92ee0e
Bug 1145036 part 2 - Rename nsTableFrame::GetCellSpacingX/Y to GetCol/RowSpacing. r=roc
...
--HG--
extra : source : f499ce6fd4e7d007a053fb5dda47d32c698d71ce
2015-03-20 15:16:00 +11:00
Xidorn Quan
b4efb87d4a
Bug 1145036 part 1 - Rename mBorderSpacingX/Y to mBorderSpacingCol/Row. r=heycam
...
--HG--
extra : source : 4f0a5e14993dd26e4a25d5f05ea1ec274bebe4e6
2015-03-20 15:16:00 +11:00
Robert O'Callahan
3d3de907e0
Bug 1082249. Invalidate background-attachment:fixed table-part backgrounds when scrolled. r=mattwoodrow
...
--HG--
extra : rebase_source : 766292ba08aafee922c4d42d702167a08a62bb4f
2015-03-05 00:02:14 +13:00
L. David Baron
a1282d848c
Bug 992077 patch 4 - Stop using OverflowChangedTracker::CHILDREN_AND_PARENT_CHANGED for the overflow area updates dealing with absolutely positioned elements contained by relatively positioned table parts. r=mats
...
The old code here was also updating overflow areas on more frames than
needed. (Using CHILDREN_CHANGED on positionedPart itself causes test
failures because positionedPart's overflow area doesn't change in the
overflow updating process, so no overflow change is propagated to the
parent; it's the parent that actually needs the update.)
2015-02-16 16:34:29 +13:00
Seth Fowler
9bc6846579
Bug 1128769 (Part 4) - Record the last draw result when drawing CSS tables and use it to decide whether to sync decode. r=tn
2015-02-05 20:45:56 -08:00
Markus Stange
11cfcac596
Bug 1130817 - Refactor nsTablePainter a little. r=roc
...
This patch makes the following changes:
- Ownership of the col groups' TableBackgroundData has moved into the mColGroups array.
- nsStyleBorder instances for painting are created on the stack instead of in the allocation
arena of the pres context, so now we no longer need to call Destroy on them.
- Not having to call Destroy lets us get rid of a lot of destruction code.
- TableBackgroundData for the current row group and the current row no longer live in
member variables of nsTablePainter. They're now on the stack and get passed to the
methods that need them as usual.
- All methods now return void instead of nsresult.
- TableBackgroundData instances are no longer reused.
2015-02-08 01:35:58 -05:00
Seth Fowler
a271bba567
Bug 1128356 - Add template functions for common frame property destructors. r=dbaron
2015-02-04 15:22:27 -08:00
Seth Fowler
710bf88bca
Bug 35168 (Part 2) - Allow relative positioning of internal table objects. r=dbaron
2014-08-19 18:24:58 -07:00
Jonathan Kew
e117c33e3d
Bug 1077528 - part 1 - Provide physical and logical accessors for the m{HV}Resize flags in nsHTMLReflowState, and convert all flag users to the accessor methods. r=smontagu
2014-11-28 09:44:02 +00:00
Mats Palmgren
debd2f3e4d
Bug 907396 - Replace GetParentStyleContextFrame with GetParentStyleContext which can return frame-less display:contents style contexts. r=bzbarsky
2014-11-20 18:24:10 +00:00
Jonathan Kew
8412cec73a
Bug 1096260 - Convert flags parameter of nsIFrame::ComputeSize from uint32_t to a typed enum, and update callers accordingly. r=dholbert
2014-11-11 11:02:41 +00:00
Jonathan Watt
67d66c6dc4
Bug 1085167, part 1 - Feed the appUnitPerDevPixel value through to nsCSSRendering::DrawTableBorderSegment. r=mattwoodrow
...
--HG--
extra : rebase_source : 4ef83ee8f45915311c1f7379e06c77f40605c17c
2014-10-20 10:55:49 +01:00