This patch doesn't currently work. The test fails in two test cases. Right now the styles for a 'locked-off' psuedo class are still being applied.
MozReview-Commit-ID: DppYTmILpwy
* * *
[mq]: temp
MozReview-Commit-ID: 74iIOQumfrw
--HG--
extra : rebase_source : 276e694b61aaeb0cb55a963c793d58876a92546f
Ideally we would have used the GUID to join fields to build the compound key but because we show the uniqueId in the tree that would lead to an ugly user experience. As an
alternative we simply use e.g. db1 (default) as the uniqueId. This works as a unique key, is informative for the user and means minimal changes to tests.
MozReview-Commit-ID: I0XxTIoV33p
--HG--
extra : rebase_source : a8a9729ae639f68e849fc8239c36f451496847ad
This changes the behavior of the element picker so that when it is
cancelled the previously selected DOM node is re-scrolled into view.
Additionally the existing behavior of the keyboard shortcuts for the
element picker was broken when the devtools toolbox was docked. The main
content area was not being focused, so the keyboard shortcuts for the
element picker were not being used. When the toolbox is detached, the
focus event is still not fired, as it's not desirable to have the
content pop into view over the devtools.
Finally there is now an additional implementation of the Escape shortcut
when the devtools are focused. The console Escape shortcut is ignored
until the element picker has been disabled making disabling the element
picker consistent irrelevant of the context.
MozReview-Commit-ID: HxENmPBoTcD
--HG--
extra : rebase_source : 067b51d4c7324f2e59fc698dbd5bb01ad2b29205
Expose network throttling via the emulation actor, similar to other platform
features that RDM alters. This simplifies the client side since we can avoid
thinking about console clients, etc.
MozReview-Commit-ID: 3CNnJl6Ude8
This caching feature is no longer valid as the client-side database
will not necessarily be the same as the server since the DB is
only built on nightly.
MozReview-Commit-ID: 550EQmgO9O7
--HG--
extra : rebase_source : 8863a9b42a976c5b6a6b8d4a8e2481b50f2ffa86
This caching feature is no longer valid as the client-side database
will not necessarily be the same as the server since the DB is
only built on nightly.
MozReview-Commit-ID: 550EQmgO9O7
--HG--
extra : rebase_source : 9d924ea3a4c33995ab5db1e854404f4f181ecd41
The inspector actor now has a new method that can be used to pick a
color from the page. This method just instantiates the eye-dropper
highlighter and shows it on the page.
The method doesn't return the color because this requires user interaction.
Instead, it returns immediately and an event is sent later, when the user
has selected a color or escaped.
MozReview-Commit-ID: cjadLyNXQd
--HG--
extra : rebase_source : 392a3cbfce7b81518cd7e4c90a44bae17d96e8de
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
There are two leaks addressed in this commit:
1. The thread actor's `_debuggerSourcesSeen` set was never cleared. This set
exists only as a performance optimization to speed up `_addSource` in cases
where we've already added the source. Unfortunately, this set wasn't getting
cleared when we cleared debuggees out and it ended up keeping the
`Debugger.Source`, its referent, and transitively its referent's global alive. I
figured it was simpler to make it a `WeakSet` than to add it as a special case
in `ThreadActor.prototype._clearDebuggees` and manage the lifetimes by hand. I
think this fits well with its intended use as an ephemeral performance
optimization.
2. Due to a logic error, we were not clearing debuggees in the memory actor's
`Debugger` instance on navigations. This isn't really a "proper" leak, in that
if you forced a GC, the old debuggees would go away as `Debugger` holds them
weakly, however if there was no GC between navigations, then you could still see
the old windows (and everything they "retained") as roots in the snapshot. This
issue is straightforward to fix once identified: ensure that `_clearDebuggees`
is actually called on navigation.
Finally, this commit adds a test that we don't leak Window objects when devtools
are open and we keep refreshing a tab. When it fails, it prints out the leaking
window's retaining paths.
The sheetToUrl function in csscoverage is only used to create ids for the
csscoverage map of knownRules. Instead of asking the UI to format stylesheet
URLs using the same logic as the server, StyleEditor.jsm now sends the
stylesheet actor to create the report. The csscoverage actor can then compute
the stylesheet URL on the server.
MozReview-Commit-ID: GDtWhbi2ScW
--HG--
extra : rebase_source : bfc8dc7c680523ff8d67e8ffd5d1b1b7af862333
Paul Adenot
Sebastian Hengst
Michelangelo De Simone
Patrick Brosset
Wes Kocher
Jared Wein
Tim Nguyen
Julian Descottes
Michael Ratcliffe
Luca Greco
Ehsan Akhgari
Gabriel Luong
Phil Ringnalda
Xue Fuqiao
Greg Tatum
J. Ryan Stinnett
James Long
Jarda Snajdr
Matteo Ferretti
Tom Tromey
Benoit Chabod
Eddy Bruel
Fischer.json
Nick Fitzgerald
Jan Keromnes