51709b916b
Bug 1699040: Send properties as a part of status. r=jdescottes,devtools-backward-compat-reviewers
...
As we don't have to get the properties separately anymore, include the properties into the state.
Depends on D109846
Differential Revision: https://phabricator.services.mozilla.com/D109847
2021-03-29 08:21:31 +00:00
fc741f13a9
Bug 1685268 - [devtools] Enable Stylesheet resource server support for content toolbox. r=ochameau
...
Enabling the support for stylesheet resources highlighted some issue with the
current situation.
A couple server tests needed to instantiate a resource watcher to pass.
We also add a test case for link from inspector to stylesheet when doing a same
process navigation (we already had one for target switching).
Differential Revision: https://phabricator.services.mozilla.com/D106081
2021-03-26 09:46:33 +00:00
1d5f31821f
Backed out 5 changesets (bug 1685268) for causing failures on test_styles-applied.html. CLOSED TREE
...
Backed out changeset 331d6b2d6f1b (bug 1685268)
Backed out changeset 0068e7f023ce (bug 1685268)
Backed out changeset 830e139a73a0 (bug 1685268)
Backed out changeset 01de742151af (bug 1685268)
Backed out changeset 7a127a2cb052 (bug 1685268)
2021-03-26 10:03:26 +02:00
f78f40d9c8
Bug 1685268 - [devtools] Enable Stylesheet resource server support for content toolbox. r=ochameau
...
Enabling the support for stylesheet resources highlighted some issue with the
current situation.
A couple server tests needed to instantiate a resource watcher to pass.
We also add a test case for link from inspector to stylesheet when doing a same
process navigation (we already had one for target switching).
Differential Revision: https://phabricator.services.mozilla.com/D106081
2021-03-26 06:56:12 +00:00
743c2a228e
Bug 1699200 - [devtools] Create all commands via a CommandsFactory module. r=nchevobbe,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D109494
2021-03-25 16:02:32 +00:00
4356d88793
Bug 1698129 - Change the tabID sources from browsingContextId to browserId in the profiler r=nika,julienw
...
We have two parts in the codebase that we get the browsingContextId.
1) Inside the DOM code with profiler_register_page function whenever a
navigation happens.
2) Inside the profiler recording front-end when we start the profiler. That was
kept as activeBrowsingContextID, and now it's kept as activeTabID.
We are now changing these parts to keep the browserId instead so it directly
corresponds to the tabs. BrowsingContexts are replaced when there is a
cross-group navigation, but BrowserId is being preserved.
Differential Revision: https://phabricator.services.mozilla.com/D109281
2021-03-25 12:52:11 +00:00
f8b414e1c2
Bug 1698129 - Rename browsingContextID to tabID inside the profiler codebase r=julienw,gerald,devtools-backward-compat-reviewers
...
This patch is only about renaming the internals of the profiler codebase and
it doesn't touch any parts that requires a backwards compatibility or version
bump.
Differential Revision: https://phabricator.services.mozilla.com/D109280
2021-03-25 12:52:10 +00:00
ded026f627
Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
...
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.
Last but not least, I identified one case where we were using mochitest file for xpcshell tests!
Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
d43cb93f72
Bug 1700106 - [devtools] Remove the balanced-observers eslint disabling from DevTools mochitests. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D109476
2021-03-23 15:51:17 +00:00
71dcc33581
Bug 1698554 - [devtools] Improve error logging when a request fails with a custom exception. r=nchevobbe
...
Like BrowsingContextTargetActor.detach which was throwing { error: wrongState }
and we were logging "(void 0)" because error.message was undefined,
while error was the thrown JS object.
Differential Revision: https://phabricator.services.mozilla.com/D107986
2021-03-19 10:04:48 +00:00
ef448d774b
Bug 1699432 - [devtools] Destroy TabDescriptor instead of Target from toolbox and tests. r=nchevobbe,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D108577
2021-03-18 16:28:28 +00:00
1b1db8ad9c
Backed out 8 changesets (bug 1631451, bug 1698842) for xpcshell failures on test_breakpoint-25.js. CLOSED TREE
...
Backed out changeset 0d9035ed5c50 (bug 1698842)
Backed out changeset 55166c719cd2 (bug 1698842)
Backed out changeset 8cc10a259de1 (bug 1631451)
Backed out changeset bc9072114706 (bug 1631451)
Backed out changeset b5cb78fd1f61 (bug 1631451)
Backed out changeset da765754e3a8 (bug 1631451)
Backed out changeset d7a1c44ea37c (bug 1631451)
Backed out changeset 810bdfa0d899 (bug 1631451)
2021-03-18 02:35:30 +02:00
b6ea5cc58d
Bug 1631451 - [devtools] Destroy TabDescriptor instead of Target from toolbox and tests. r=nchevobbe,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D108577
2021-03-17 23:46:37 +00:00
4a9e835d61
Bug 1693491 - [devtools] Migrate TargetList to be a command r=nchevobbe,rpl
...
This changeset is incomplete and focus on places where we instantiate TargetList constructor
Differential Revision: https://phabricator.services.mozilla.com/D105611
2021-03-11 12:53:18 +00:00
01718819b8
Bug 1694906 - [devtools] Use descriptors instead of targets in all toolbox APIs r=ochameau,nchevobbe,rpl,perftest-reviewers,sparky
...
Depends on D107051
Differential Revision: https://phabricator.services.mozilla.com/D106426
2021-03-10 18:22:02 +00:00
e783ef6d6e
Backed out 5 changesets (bug 1694906) for dt failures on browser_target_list_frames.js . CLOSED TREE
...
Backed out changeset bd5cb6f8b41f (bug 1694906)
Backed out changeset c23343373584 (bug 1694906)
Backed out changeset 02428006de51 (bug 1694906)
Backed out changeset 284e000deded (bug 1694906)
Backed out changeset 3b5269fe0113 (bug 1694906)
2021-03-10 04:52:56 +02:00
0f66091841
Bug 1694906 - [devtools] Use descriptors instead of targets in all toolbox APIs r=ochameau,nchevobbe,rpl
...
Depends on D107051
Differential Revision: https://phabricator.services.mozilla.com/D106426
2021-03-09 20:50:42 +00:00
2b1e4e7669
Bug 1695929 - [devtools] Remove redundant TargetFrontMixin's close event, in favor of target-destroyed. r=jdescottes,nchevobbe
...
This is mostly used by tests and we do not really benefit from having two distinct events.
We are not using the fact that close is emitted immediately.
Differential Revision: https://phabricator.services.mozilla.com/D107062
2021-03-09 08:56:58 +00:00
72537078cb
Bug 1696766 - Added missing grid-template-* properties to inactive CSS rule checking properties invalid on non-grid containers. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D107399
2021-03-08 18:09:04 +00:00
30d171d273
Backed out 3 changesets (bug 1695929) for Devtool failures in devtools/client/shared/test/browser_dbg_listtabs-03.js. CLOSED TREE
...
Backed out changeset 0fb780c2319a (bug 1695929)
Backed out changeset c716d7eeb478 (bug 1695929)
Backed out changeset afd5ecd702da (bug 1695929)
2021-03-08 13:38:28 +02:00
e2b9d85ac5
Bug 1695929 - [devtools] Remove redundant TargetFrontMixin's close event, in favor of target-destroyed. r=jdescottes,nchevobbe
...
This is mostly used by tests and we do not really benefit from having two distinct events.
We are not using the fact that close is emitted immediately.
Differential Revision: https://phabricator.services.mozilla.com/D107062
2021-03-08 10:30:52 +00:00
c685a0eb54
Backed out changeset 59da0caf4b8e (bug 1694906) for causing browser-chrome failures in browser_ext_addon_debugging_netmonitor. CLOSED TREE
2021-03-03 12:40:50 +02:00
6e8574d4ad
Bug 1694906 - [devtools] Use descriptors instead of targets in all toolbox APIs r=ochameau,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D106426
2021-03-03 09:10:48 +00:00
05581ddca4
Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
b2eb620ed0
Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE
2021-03-02 20:18:21 +02:00
a0af9ea0a4
Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
54073a0009
Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe
...
Depends on D106037
Differential Revision: https://phabricator.services.mozilla.com/D106405
2021-02-25 18:02:54 +00:00
deaaf67f5f
Bug 1694140 - [devtools] Rename TargetFactory to TabTargetFactory and update filename r=ochameau
...
Depends on D106032
Differential Revision: https://phabricator.services.mozilla.com/D106037
2021-02-25 18:02:53 +00:00
39abcde940
Backed out 10 changesets (bug 1694140, bug 1694886, bug 1688688) for devtools failures on browser_CORS-console-warnings.js. CLOSED TREE
...
Backed out changeset 1b7367a27d9a (bug 1694886)
Backed out changeset d5a70a3143ad (bug 1694140)
Backed out changeset 74adaced5c0a (bug 1694140)
Backed out changeset 0b8f857e3f90 (bug 1694140)
Backed out changeset 45a8dc952aba (bug 1694140)
Backed out changeset 299f17e9cb6f (bug 1694140)
Backed out changeset 6beb9dd48ef3 (bug 1694140)
Backed out changeset 5f6688e8fe4c (bug 1694140)
Backed out changeset ae1fa0484c91 (bug 1688688)
Backed out changeset 8a0f5c24ed9a (bug 1688688)
2021-02-25 16:07:39 +02:00
2349ac9ca8
Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe
...
Depends on D106037
Differential Revision: https://phabricator.services.mozilla.com/D106405
2021-02-25 12:58:16 +00:00
13d48a2ee6
Bug 1694140 - [devtools] Rename TargetFactory to TabTargetFactory and update filename r=ochameau
...
Depends on D106032
Differential Revision: https://phabricator.services.mozilla.com/D106037
2021-02-25 12:58:16 +00:00
f5981acf25
Bug 1693846 - [devtools] Fix Storage actor listStores so it can handles multiple concurrent calls. r=ladybenko.
...
If there was multiple concurrent calls to listStores, only the last one made would
resolve, the other one would be stuck indefinitely.
This was caused by the call to indexedDb actor `preListStores` method, in which
the `hostVsStores` is reset to an empty Map. So if there was still a previous
pending call, one of the promise who was relying on an entry being in `hostVsStores`
would never resolve.
To prevent this, we cache the pending promise when calling `preListStores` so any
concurrent calls would wait for the same promise.
A test is added to make sure we don't regress in the future.
Differential Revision: https://phabricator.services.mozilla.com/D105943
2021-02-24 13:20:18 +00:00
1956957ae8
Bug 1692874 - [devtools] Use descriptors instead of targets in TargetList/Toolbox r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D105200
2021-02-18 18:36:47 +00:00
62a1abcd3c
Bug 1551577 - New inactive CSS rule to show warning when scroll-padding-* is used on non-scrollable elements. r=nchevobbe,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D101099
2021-02-15 18:32:26 +00:00
2ffc4487a8
Bug 1551571 - New inactive CSS rule to show warning when table-layout is used on non-table elements. r=fluent-reviewers,flod,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101224
2021-01-28 13:32:49 +00:00
23fbcf2d92
Bug 1671457 - Fixed incorrect inactive CSS warning for text-overflow r=jdescottes
...
Corrected the warning about when text-overflow has no effect including different settings for overflow-x and overflow-y depending on the writing mode.
Depends on D102814
Differential Revision: https://phabricator.services.mozilla.com/D102815
2021-01-25 23:20:29 +00:00
dc813a31cc
Backed out changeset 870a4ac0af45 (bug 1583901) for devtools failures at browser_rules_preview-tooltips-sizes.js.
2021-01-24 01:22:23 +02:00
f6362f9f72
Bug 1583901 - New inactive CSS rule to show warning when fill-* or stroke-* is used on non-SVG-basic-shape and non-SVG-text elements. r=fluent-reviewers,flod,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D101295
2021-01-23 21:38:22 +00:00
1b5b46ec79
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
2abb23a415
Backed out 4 changesets (bug 1680637, bug 1682395) for causing mochitest failures in browser_javascriptDialog*.js
...
CLOSED TREE
Backed out changeset f5c4603fc02d (bug 1680637)
Backed out changeset 2f89ad4b915e (bug 1682395)
Backed out changeset 2b7e1df00a1c (bug 1680637)
Backed out changeset c35335c49551 (bug 1680637)
2021-01-14 01:51:52 +02:00
7ba40f5b60
Bug 1579017 - Corrected inactive CSS rule for order property, making it valid for grid items. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D101267
2021-01-13 19:28:17 +00:00
298219ee45
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-13 13:27:08 +00:00
7742c03714
Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
...
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
06e7942185
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
a9d7e2e52e
Bug 1681893 -[devtools] Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101258
2021-01-11 07:49:25 +00:00
bf1098943a
Bug 1551569 - New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=nchevobbe,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D101091
2021-01-11 07:30:02 +00:00
cf1c89970f
Bug 1439963 - [devtools] Handle evaluation result in a new task, after the evaluation is done. r=ochameau.
...
This way we ensure that any microtask created by the evaluated expression are
run, which can impact what we send to the client (e.g. `Promise.resolve().then(() => 246)`
will show a resolved promise instead of a pending one).
Some stubs and node tests are added to ensure this does fix the issue.
Differential Revision: https://phabricator.services.mozilla.com/D100979
2021-01-08 13:47:00 +00:00
6fbec57619
Bug 1682780 - [devtools] Adapt tests and doc now that ThreadActor.attach no longer pause the thread. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D100022
2021-01-07 13:33:40 +00:00
8440986b83
Bug 1682780 - [devtools] Remove unused callback arguments from xpshell debugger test helpers. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D99918
2021-01-07 13:08:13 +00:00
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
Daisuke Akatsuka
Nicolas Chevobbe
Butkovits Atila
Alexandre Poirot
Nazım Can Altınova
Cosmin Sabou
Julian Descottes
Narcis Beleuzu
Sebastian Zartner
Dorel Luca
smolnar
Jens Stutte
Brindusan Cristian
Micah Tigley
Mihai Alexandru Michis
pedrofonsecadev
Kartik Gautam