EXIT_FAILURE is 'implementation defined' but can be defined to be 1.
In our case, pingsender exits with EXIT_FAILURE but nsIProcess wasn't
reporting it as failure because it thought failures were always negative.
Differential Revision: https://phabricator.services.mozilla.com/D45038
--HG--
extra : moz-landing-system : lando
This matches the requirement imposed by the Container concept that its iterator type
should be convertible to its const_iterator type.
Differential Revision: https://phabricator.services.mozilla.com/D44673
--HG--
extra : moz-landing-system : lando
This condition is intermittently failing, but it's hard to tell from the
failure which part of the condition is failing. Split the condition
apart so ideally we'll get some better error messages. While we're
doing that, use a more explicit `EXPECT_LT` for the first half of the
condition for even better error messages.
Differential Revision: https://phabricator.services.mozilla.com/D40051
--HG--
extra : moz-landing-system : lando
Gtest jobs on the osx1014 try hardware are taking longer than anticipated to finish up, and ThreadPool.ShutdownWithTimeout tests need to wait an extra 50ms to let all threads finish on time. On the long term, when the underlying issue is fixed thread timeouts will need to be readjusted back to 300ms.
Differential Revision: https://phabricator.services.mozilla.com/D38452
--HG--
extra : moz-landing-system : lando
Giving each logical test its own counter variable will help tests to not
interfere with each other. We also make one infinite looping thread
exit so we're not chewing CPU after these tests finish.
Differential Revision: https://phabricator.services.mozilla.com/D36522
--HG--
extra : moz-landing-system : lando
Increased slack boundaries to account for issues with timer bounds in macos 1014. Lower bound slack = 60ms and upper bound slack = 1200ms. The intent is to get gtests working in the short term while timer delays are fixed, then roll the slack boundary back to 30ms.
Differential Revision: https://phabricator.services.mozilla.com/D36419
--HG--
extra : moz-landing-system : lando
The first test does not really need to check that we spend less than
200ms, and we can give more time to the scheduler in the second
test, as long as we check that is less than the recursive dispatched
event
Differential Revision: https://phabricator.services.mozilla.com/D34988
--HG--
extra : moz-landing-system : lando
XPIDL has the requirement that [scriptable] interfaces with [notxpcom]
methods or attributes are [builtinclass]. Currently, if you don't
explicitly mark something builtinclass when it should be, then the
XPIDL compiler will just silently treat it like builtinclass. This
means that you can cause the JS implementation of an XPCOM to start
failing without any warning by marking a method notxpcom.
This patch instead makes it an error. A prior patch fixed the existing
instances in the tree that relied on the implicit behavior.
I also added a test that we reject such classes missing builtinclass
at compile time, as well as classes that inherit from builtinclass
interfaces without themselves being builtinclass. I left behind a part
of the runtime test for this behavior, but now this test just ensures
that you can't implement a [builtinclass] interface in JS.
Differential Revision: https://phabricator.services.mozilla.com/D30984
--HG--
extra : moz-landing-system : lando
With changes from bug 1548555, some of the gtests previously disabled on Android
can be re-enabled.
Differential Revision: https://phabricator.services.mozilla.com/D30080
--HG--
extra : moz-landing-system : lando
Changes:
- added comments for tests being disabled
- disabled two additional tests in order to green the run
Differential Revision: https://phabricator.services.mozilla.com/D28085
--HG--
extra : moz-landing-system : lando
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.
Complex cases:
dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.
js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.
Intentionally not changed:
editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.
testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.
Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js
Depends on D27802
Differential Revision: https://phabricator.services.mozilla.com/D27803
--HG--
extra : moz-landing-system : lando
I missed this intermittent when enabling Android gtests in bug 1318091. Disable
the failing test on Android only, to green up Android gtest.
Differential Revision: https://phabricator.services.mozilla.com/D27535
--HG--
extra : moz-landing-system : lando
Disable gtests observed to fail on Android. Some of these are simple build
failures and failures due to file permissions or paths, while other failures
are more obscure.
Once Android gtests are running on mozilla-central, I will file follow-up
bugs inviting teams to investigate the failures and re-enable Android gtests
that are important to them.
Differential Revision: https://phabricator.services.mozilla.com/D26606
--HG--
extra : moz-landing-system : lando
Tom Ritter
Razvan Maries
Tom Ritter
Simon Giesecke
Coroiu Cristina
Sylvestre Ledru
Hiroyuki Ikezoe
Nathan Froyd
Boris Zbarsky
Ciure Andrei
Kristen Wright
Barret Rennie
Victor Porof
Tarek Ziadé
Andrea Marchesini
Dave Townsend
Nicklas Boman
Andrew McCreight
Olli Pettay
Jean-Yves Avenard
Geoff Brown
Edwin Gao
Rob Wu
Ian Moody
Henri Sivonen
Csoregi Natalia
Narcis Beleuzu
Honza Bambas
Philip Chimento
Mark Banner
Chris Peterson