It is unexpected (see bug) that a -moz-box is affected by baseline alignment.
Make -moz-box be block-outside, and -moz-inline-box be inline-outside, instead
of the bespoke thing we have now.
This is more similar to everything else, and fixes the bug.
Differential Revision: https://phabricator.services.mozilla.com/D58726
--HG--
extra : moz-landing-system : lando
Nowadays, ColumnSetFrame is an inner frame under ColumnSetWrapperFrame.
It always has "block-size: auto", so `aReflowInput.ComputedBSize()`
always equals to NS_UNCONSTRAINEDSIZE.
Also, -moz-column-content no longer has "max-block-size: 100%", so
NS_FRAME_CONTAINS_RELATIVE_BSIZE can never be set on ColumnSetFrame when
constructing ReflowInputs for ColumnSetFrame's children in
`ReflowInput::InitResizeFlags`. Removing the bit is not needed, either.
Differential Revision: https://phabricator.services.mozilla.com/D58732
--HG--
extra : moz-landing-system : lando
Simply remove "max-block-size: 100%" for -moz-column-set and
-moz-column-content breaks abspos-breaking-dynamic-{001,002,003}.html.
We need to reflow ColumnSetWrapper's children whenever
ColumnSetWrapper's block-size or max-block-size is changed because both
size affect the available block-size for ColumnSetWrapper's children.
We set `NS_FRAME_CONTAINS_RELATIVE_BSIZE` for ColumnSetWrapperFrame so
that it will set itself dirty in `selfDirty` in
`nsBlockFrame::ReflowDirtyLines`, and mark its lines dirty if
`aState.mReflowInput.IsBResize()` is true.
Differential Revision: https://phabricator.services.mozilla.com/D58731
--HG--
extra : moz-landing-system : lando
It is unexpected (see bug) that a -moz-box is affected by baseline alignment.
Make -moz-box be block-outside, and -moz-inline-box be inline-outside, instead
of the bespoke thing we have now.
This is more similar to everything else, and fixes the bug.
Differential Revision: https://phabricator.services.mozilla.com/D58726
--HG--
extra : moz-landing-system : lando
Add some SCHEDULES rules so that, when a push only modifies files known to be associated
with a particular test suite, only that test suite is run.
Differential Revision: https://phabricator.services.mozilla.com/D58448
--HG--
extra : moz-landing-system : lando
The information in it is always derivable from the values of mRepeatAutoStart
and mRepeatAutoEnd. Additionally, its value is used in some cases where it has
not yet been set properly (such as CalculateRepeatFillCount).
This works out currently because the default value is zero we only accept
repeat(auto-fill, ...) and repeat(auto-fit, ...) CSS values that have a single
element in the repeat. In that case, zero is the correct value for
RepeatEndDelta.
Differential Revision: https://phabricator.services.mozilla.com/D58871
--HG--
extra : moz-landing-system : lando
Changes:
`gtkWidget&&webrender` has a slightly different pixel difference count (1496 vs 1498), so a second condition is added to cover this case.
The annotation is permissive but will be tightened once reftest is run with ubuntu1804.
Differential Revision: https://phabricator.services.mozilla.com/D58862
--HG--
extra : moz-landing-system : lando
Changes:
Remove the fail-if annotation for gtkWidget since the test passes in ubuntu1804.
This patch will need to land with D58816.
Differential Revision: https://phabricator.services.mozilla.com/D54851
--HG--
extra : moz-landing-system : lando
Changes:
This test is failing again permanently for ubuntu1804, not sure what changed. I won't change the annotation after this patch unless the author or someone from the team chimes in.
Differential Revision: https://phabricator.services.mozilla.com/D58839
--HG--
extra : moz-landing-system : lando
This cleans up and also allows us to keep the distinction between content: none
and content: normal, which allows us to fix the computed style we return from
getComputedStyle().
Do this last bit from the resolved value instead of StyleAdjuster, because
otherwise we need to tweak every initial struct for ::before / ::after.
Differential Revision: https://phabricator.services.mozilla.com/D58276
--HG--
extra : moz-landing-system : lando
In particular, the ones where we transcode unconditionally atm (property names
and such).
There are others like cssText getters and setters which are a bit harder,
because I either need to rewrite all our serialization code to work with UTF8
(which is fine, but a lot of work), or teach webidl to have a setter that takes
UTF8String as input but returns DOMString as output (which is at best hacky).
Differential Revision: https://phabricator.services.mozilla.com/D58631
--HG--
extra : moz-landing-system : lando
This patch adds the following functionality to the CSSStyleSheet WebIDL API
under the feature flag layout.css.constructable-stylesheets.enabled:
- constructor()
- replace()
- replaceSync()
constructor(), replace() and replaceSync() are currently stubs that lack full
functionality.
Differential Revision: https://phabricator.services.mozilla.com/D58326
--HG--
extra : source : 6e675d6399cee28f204b3501de3475ea3febd12c
This commit changes IsBidiLeaf to mark ruby boxes not a bidi leaf, since
conceptually they are not. I auditted all uses of it, and I believe it
makes more sense this way.
Differential Revision: https://phabricator.services.mozilla.com/D58290
--HG--
extra : moz-landing-system : lando
Move the content of bug1503420.html to
test_frame_reconstruction_for_column_span.html because we don't need to
flip the pref and load the test in an iframe.
The modification to devtools's properties-db.js is generated via
`./mach devtools-css-db`.
Differential Revision: https://phabricator.services.mozilla.com/D58402
--HG--
extra : moz-landing-system : lando
For BeginBuildingColumns, returning nsBlockFrame, i.e. the original
NS_NewColumnSetWrapperFrame's return type, should be sufficient since no
other caller in frame constructor needs to call ColumnSetWrapper's
methods.
Differential Revision: https://phabricator.services.mozilla.com/D58398
--HG--
extra : moz-landing-system : lando
This patch adds the following functionality to the CSSStyleSheet WebIDL API
under the feature flag layout.css.constructable-stylesheets.enabled:
- constructor()
- replace()
- replaceSync()
constructor(), replace() and replaceSync() are currently stubs that lack full
functionality.
Differential Revision: https://phabricator.services.mozilla.com/D58326
--HG--
extra : moz-landing-system : lando
This is an optimization to avoid getting the preference value for each http load when COOP is enabled, because that needs to check secure context state for all loads.
Depends on D57579
Differential Revision: https://phabricator.services.mozilla.com/D57580
--HG--
extra : moz-landing-system : lando
Changes:
Mark with permissive fuzzy-if annotation, to permit both ubuntu1604 and ubuntu1804 to pass for the time being.
Test will have annotation tightened up once migration is complete.
Differential Revision: https://phabricator.services.mozilla.com/D58405
--HG--
extra : moz-landing-system : lando
test_bug159346.xhtml modifies UA stylesheet to show scrollbar button.
However, on Ubuntu 18.04, its width is 0. Therefore, the following
script fails to test click on the button.
This patch specifies its `min-width` and `min-height` to make it
clickable on any platforms.
Differential Revision: https://phabricator.services.mozilla.com/D58189
--HG--
extra : moz-landing-system : lando
Bogdan Tara
Emilio Cobos Álvarez
Ting-Yu Lin
Geoff Brown
Xidorn Quan
Edwin Takahashi
nordzilla
Emily McDonough
Arthur Iakab
Mihai Alexandru Michis
sotaro
Kirk Steuber
Connor Brewster
Daniel Varga
Hiroyuki Ikezoe
Tetsuharu OHZEKI
Jonathan Kingston
Coroiu Cristina
Junior Hsu
Masayuki Nakano