Stop filtering search results when browser.urlbar.suggest.searches is false,
that pref is intended to filter search suggestions coming from the network, and
we should completely avoid hitting the network when it's set, rather than
filtering entries (that may instead cover real bugs).
Differential Revision: https://phabricator.services.mozilla.com/D49172
--HG--
extra : moz-landing-system : lando
content blocking event should be checked bitwisely to see if targeted bits are all matched.
Differential Revision: https://phabricator.services.mozilla.com/D48170
--HG--
extra : moz-landing-system : lando
- Converted the ObjectClient into an protocoljs Front
- Converted the SymbolIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the PropertyIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the EnvironmentClient into a protocoljs Front and moved it to devtools/shared/fronts
- Modified calls to `DebuggerClient.release()` so that it tries to call the ObjectFront's release method first, and falls back on `DebuggerClient.release()` if there's no object front
- Changed reps so that it instantiates only one ObjectClient per grip
- Changed tests so that they expect what the Front's request method resolves to where applicable (i.e. ObjectFront.allocationStack resolves to allocationStack, not a packet object with an allocationStack property)
- Changed callbacks provided to ObjectClient methods to be chained to the ObjectFront methods (e.g. ObjectClient.getScope(callback) changed to ObjectFront.getScope().callback())
- Changed tests to use async/await (test_framebindings-x.js, test_functiongrips-x.js, test_objectgrips-x.js)
- Changed tests to expect protocoljs to throw an error string instead of an error object (test_objectgrips-fn-apply-03.js, test_threadlifetime-02.js, test_pauselifetime-03.js)
Differential Revision: https://phabricator.services.mozilla.com/D48182
--HG--
rename : devtools/shared/client/environment-client.js => devtools/shared/fronts/environment.js
rename : devtools/shared/client/property-iterator-client.js => devtools/shared/fronts/property-iterator.js
rename : devtools/shared/client/symbol-iterator-client.js => devtools/shared/fronts/symbol-iterator.js
extra : moz-landing-system : lando
The XPInstall content handlers currently make all sorts of assumptions about
the process they're being run in and the docShell their request is tied to.
These assumptions don't hold under Fission, either now, when they may be
called just after a process switch, or in the future, when they'll be called
in the parent process.
This patch updates them to operate on the BrowsingContext of the request, and
to do their messaging via the process message manager, rather than via frame
message managers. As a bonus, it also removes the existing hacks they had in
place to handle the cases where frame message managers didn't work.
Differential Revision: https://phabricator.services.mozilla.com/D48224
--HG--
extra : moz-landing-system : lando
This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.
Differential Revision: https://phabricator.services.mozilla.com/D49559
--HG--
extra : moz-landing-system : lando
1. Previously, the label and tooltip for all recommendations was just "Recommendation", even though the icon was different for extension and feature recommendations.
Because users might not be able to see the icon and/or determine its meaning, it is important that this is communicated in the tooltip and a11y label.
2. Screen reader users won't know this has appeared, even though this attracts some attention visually.
Therefore, provide a specific announcement for screen reader users when the recommendation appears.
Differential Revision: https://phabricator.services.mozilla.com/D47718
--HG--
extra : moz-landing-system : lando
Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.
Differential Revision: https://phabricator.services.mozilla.com/D49172
--HG--
extra : moz-landing-system : lando
This avoids a JS error when the tab has been removed before this function
has a chance to run.
Differential Revision: https://phabricator.services.mozilla.com/D48993
--HG--
extra : moz-landing-system : lando
We extract tags from the result title only when `info.style.includes("bookmark")`, but that only captures one of the two cases where we include tags in the title: the "bookmark" style. We also include tags for the "tag" style. So the bug reports in this bug are hitting that "tag" case. It doesn't have anything to do with non-Latin tags afaict (see the bug summary).
I took the opportunity to streamline `UnifiedComplete._addFilteredQueryMatch`, which was a little hard to follow. I had to look at it to make sure I captured all the cases where tags are included in the title. I think I've made it easier to follow.
Differential Revision: https://phabricator.services.mozilla.com/D49223
--HG--
extra : moz-landing-system : lando
This changes the either-or semantics to one-after between the local and remote fluent files for ASRouter.
Differential Revision: https://phabricator.services.mozilla.com/D49068
--HG--
extra : moz-landing-system : lando
Note - This change is only visible in the light variation of the default theme.
Differential Revision: https://phabricator.services.mozilla.com/D49179
--HG--
extra : moz-landing-system : lando
Note - I did not edit the refernces to `--in-content-box-border-color` across the following refernces:
login-list:
:host (Also contained references to backround color: `--in-content-box-background`)
.meta (Also contained references to backround color: `--in-content-box-background`)
.create-login-button-container (Shadow color property)
menu-button:
.menu (Also contained references to backround color: `--in-content-box-background`)
Differential Revision: https://phabricator.services.mozilla.com/D49188
--HG--
extra : moz-landing-system : lando
Ed Lee
Mark Banner
Tim Nguyen
Marco Bonardo
Oana Pop Rus
Harry Twyford
Liang-Heng Chen
Razvan Maries
Nihanth Subramanya
jaril
Kris Maglione
Alexander Surkov
Scott
Erica Wright
Coroiu Cristina
Mike de Boer
Bogdan Tara
James Teh
Dão Gottwald
Mihai Alexandru Michis
Jared Wein
Cosmin Sabou
Brad Werth
Marcos Cáceres
Drew Willcoxon
Nan Jiang
mcrawford@mozilla.com
Edouard Oger