<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1388652
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: f6aa17add96a49e7ee6746b24bc8f250380ea51e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 78461360f93ffa7aa963551a54dff18280fd20c3
According to the spec, the computed value of transform is as specified, but
with relative lengths converted into absolute lengths, so in Gecko, we do
nothing while computing the value of rotate3d(), and do normalization in
ProcessRotate3D(). If the direction cannot be normalized, we treat it as
an identity matrix.
However, in Servo, we do normalization in to_computed_value(), and looks
like we are trying to normalize any kind of direction vectors, so according
to the spec, let's move the normalization into Fragment::transform_matrix(),
and return an identity matrix if we cannot normalize its direction vector.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1388216](https://bugzilla.mozilla.org/show_bug.cgi?id=1388216).
- [X] These changes do not require tests because the added test is on Gecko side.
Source-Repo: https://github.com/servo/servo
Source-Revision: 89971910cf8ef5e24ae1542c93699b9ee7c4132c
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0edf045ff54cceabb2ccca3a06445dbe6fbac6df
Various refactorings of the code for traversing flow trees, including:
* Add a generic inorder traversal method
* Remove unused `traverse_postorder_absolute_flows` method
* Combine `compute_absolute_position` and `build_display_list` into a single traversal
* Move all generic traversal code into the `layout::traversal` module
And some changes to add documentation and more-accurate names:
* Fix spelling of `bottom_up_flow`
* Rename `compute_absolute_position` to `compute_stacking_relative_position`
* Change the mis-named `traverse_flow_tree_preorder` to `reflow`
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are refactoring only
Source-Repo: https://github.com/servo/servo
Source-Revision: ed3c2b95573c355c11c99eb43320d604fc95a5e9
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cc9af787c396dbdbf6b20eca349a55130d58f6d1
<!-- Please describe your changes on the following line: -->
The tests in the issue worked for me locally.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] These changes fix#18001 (github issue number if applicable).
<!-- Either: -->
- [X] These changes do not require tests because they are just refactoring
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 955b62506042a330b7602a48d1d8899b0b6ae4af
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 770982d859cef03d90bf397293474bb8c2241c09
This will allow my work in bug 1362338 to not break stylo.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3c644ea616ba3f614a00834327e3b0196daaf406
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 55ebf29c9d390a7140547cf6c06e9d3db77cf51d
These are the last instances I can find of us hashing the atoms hash.
Source-Repo: https://github.com/servo/servo
Source-Revision: dec4ba8ea6adb2477e4d3ba4916c886ac8b1dc0e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 95f90abdf465762dd270efb1e700800425b49a1b
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
From https://bugzilla.mozilla.org/show_bug.cgi?id=1379577
Source-Repo: https://github.com/servo/servo
Source-Revision: 3ba4f784f84742a9e40c83b0c89d75bf87e9a828
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e608c345f49c3e333de52e0ed4ea83e69a1a4bfe
We added this because a year ago we had no reliable Gecko CI. This meant that Gecko-only properties needed to be tested *somehow*, and we solved that by making it so that for unit tests we compile all properties, not just the servo ones.
This was useful back then, but I don't think we need this anymore. We have reliable Gecko CI, and all the gecko-only stuff we tested is adequately handled by the properties-database parsing mochitests. It's a bit of annoying cruft that just complicates things; we probably should remove it.
r? @emilio or @SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 32f835260cd3ea03a881f7a344a01f401c4db621
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2b280c0e8d9940b424b893e18a46cdad65fa40ca
The check isn't doing what the comment is saying.
XBL subtrees for video controls all have the
NODE_IS_IN_NATIVE_ANONYMOUS_SUBTREE flag, but not all of them are NAC
themselves, so we may incorrectly miss blockification.
Bug: 1366163
Reviewed-by: heycam
MozReview-Commit-ID: Oq3W258Lz2
Source-Repo: https://github.com/servo/servo
Source-Revision: 5ecedb562c66c1f436850704b6dc467a04f5a283
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4ac2d18a9f0b660d8bc869a436d6e2e210d07302
This showed up in a few profiles, and was an easy improvement.
Source-Repo: https://github.com/servo/servo
Source-Revision: 69f02f4f7f102a3fe3f82d5f000533a9277d233e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d71674e9235874fd965574ec5dd145efba19928f
Interpolated result of FontWeight is wrong because clamping code is incorrect.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1387948](https://bugzilla.mozilla.org/show_bug.cgi?id=1387948).
- [X] These changes do not require tests because Gecko has tests
Source-Repo: https://github.com/servo/servo
Source-Revision: 48b7e6d27c6fbeea9b03acface18d163cb7eedbc
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b634dad43aa799dee556deb2d319ab88f6afe3fc
Unless the element is in a display:none subtree.
After bug 1356141, the setup of animation-only dirty bit should have matched
to normal dirty bit's one (Though they don't match in post traversal due to
throttled animation flush). An unset_animation_only_dirty_descendants call
removed in this patch cleared dirty bits which are needed for post traversal if
there is a second animation-only traversal and if there is no need to restyle
for the second animation-only traversal.
The reftest in this patch fails without either this fix or the fix for bug
1367975.
See [Gecko bug 1384435 comment 12](https://bugzilla.mozilla.org/show_bug.cgi?id=1384435#c12)
for more detail what's going on at that time.
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1384435
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: 689dadc75174eff892e1da9d072ee9f109ede925
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d753d57193dc192e0eda506dce7925b9ce4816eb
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Either: -->
- [X] There are tests for these changes. The test is patch 3 in https://bugzilla.mozilla.org/show_bug.cgi?id=1382137
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 10c3e2f3ac781905b43b3529253ba1bc9926d9e8
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e7402194c82e4973541feec2da3f793e8f9d7171
stylo_test's build script is split between Python and Rust. style's
build script already has to perform complicated dances to determine an
appropriate binary to execute, depending on the platform. To avoid
copying and pasting that code, it seems reasonable to simply port the
Python code into Rust, thus making the relationship between generated
files and the cargo dependency output clearer. The new Rust is somewhat
more verbose, but not terribly so.
Doing this makes running `stylo_test` on Windows somewhat easier, as
we don't have to care about the particulars of Python executables. And
more Rust is more better.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
Source-Repo: https://github.com/servo/servo
Source-Revision: c9d9ed8e96b88bf738c8753106424bbb28a4b02e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bff7f830a92dfcf5a562cd772ad823d1b5b1fb66
<!-- Please describe your changes on the following line: -->
The size of a paint worklet should be based on the background-size CSS property.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#17676.
- [X] These changes do not require tests because the existing css-paint-api tests catch this.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: a624496cc485e4eebe82860ca241cb651d91f54a
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3fe8818e813fb80e9d6115846ac5719e3b8444bf
(And tidy a bit a misindented function while at it).
Source-Repo: https://github.com/servo/servo
Source-Revision: 82de4c49f378aed7c9497ba6995020fa79dbf942
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 74dc73100221a360a89ae5f9d589b1b9b0310db3
<!-- Please describe your changes on the following line: -->
Implement `getProperties` for `StylePropertyMapReadOnly`.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#17579.
- [X] These changes do not require tests because the existing css-paint-api tests catch this (rather annoyingly, they all fail for different reasons, sigh)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: b07f06ce9263177f01cde692d3ea5830a7dfdeeb
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fccd2072f1aaf4a55809ecb0f58b299d5dc40058
Some properties only accept non-negative values, or values greater than or equal to one. It is possible to produce an negative interpolated values while using negative timing functions, so we have to apply a restriction to these values to avoid getting invalid values.
For example, line-height must be non-negative, but the output progress of some timing functions (e,g. cubic-bezier(0.25, -2, 0.75, 1)) may be a negative value, so the interpolated result of line-height is also negative.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix Bug 1374233.
- [X] These changes do not require tests because we have tests in Gecko side already.
Source-Repo: https://github.com/servo/servo
Source-Revision: 016ea11cbaf7586db144be122581c5b110649aee
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3562be334610046cb0edaad2fc231dd169a4aa0d
This was needed long time ago for Servo's layout. But I don't think there's any
reason for doing this now.
Source-Repo: https://github.com/servo/servo
Source-Revision: f8abce8b72bf3fb09d39d6c7d708a79d1b89c9db
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7974c18af7dc3873105bbe2b89ff98ca3deb3b49
… which is now required to build Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1383311
Source-Repo: https://github.com/servo/servo
Source-Revision: 573087cf82cb4a6d27330a60dabcfdc6c6825a68
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fb0db532ecd6eed2dd5f15376ebdf5029937c23f
This shaves a fair amount of time of stylist rebuild.
Most of the extra remaining overhead are memory allocations...
I'll try to get those sorted out next, though fixing that may overlap quite a
bit with the work Cameron is doing in bug 1382925.
Source-Repo: https://github.com/servo/servo
Source-Revision: b11b65837930fff7ec793e935af46d7edbeccda5
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5c506863db85090b1edb2dcd4350a6913cf4cf21
This is on top of #17990, and it's intended to help with bug 1386045.
Source-Repo: https://github.com/servo/servo
Source-Revision: 806540cabdbca1799dd14bb1c67bd0c86b21f6a7
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 618224ec519ee0cb985d6e345c0ea1dedad3f5e8
<!-- Please describe your changes on the following line: -->
This will make it easier to avoid rebuilding all cascade levels when only a style sheet at a particular level changes.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: cc1aab35ea11415d8c5fb3e33c745434b8a5ec2d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : abc4bde3d17e73a101c2d17824384f752fbc3392
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1382168](https://bugzilla.mozilla.org/show_bug.cgi?id=1382168)
Source-Repo: https://github.com/servo/servo
Source-Revision: 74c2117b0a3c787298676b086106acda00a026c8
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cfdbc99a46e9acd5d27bcfbd86e502b4ff7cc909
Left this in accidentally in #17981.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f34d54b0fa74cfa17f522be836eb259cfc0a905
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cf2551eaeaa04f2f1d922a076c00c8b56e0eecfa
Avoid adding id selectors that are in the rule hash keyed by that ID to the list
of revalidation selectors.
This partially fixes bug 1369611 (we could look at the rule hash itself to avoid
inserting some more into the list of revalidation selectors).
Source-Repo: https://github.com/servo/servo
Source-Revision: 16704bbaaa9ec324972788f1a455639d4bbef0fd
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ed163c86dfd3c94d0cc11f564432d05c9fafadd9
`stylo_tests` currently requires a separate version of the `style` crate, compiled with the `testing` feature, so a function testing the size of specified values can be accessed. With a few tweaks, we can make the information needed for the test available to the `stylo_tests` crate directly, eliminating the need for a separately-compiled `style` crate.
This doesn't matter much for Servo itself (it might make CI times slightly faster?), but Gecko automation/development would like to run `stylo_tests`, and not having to compile two versions of the `style` crate (or have a dead, test-only function hanging around in the `style` crate) would be a win.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
Source-Repo: https://github.com/servo/servo
Source-Revision: a6369149dc5344b2b80a12fca1c43cf99c94fdc9
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f23cc39c69a996f3d1023f4c00f8d564d4a3e97f
Reviewed by Emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1379865.
Source-Repo: https://github.com/servo/servo
Source-Revision: 586f84f5fea9a15c90dc5bc5415e2c5f5caa3ddb
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2bc4a44859b0b32200c2816c0a4ffbfeb2eebcde
Reviewed by Emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1384398.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6cb790f8eb5024dba1d82ad5f7fb4bb912aeda46
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b09e6dc743ee10df53d9b25acc9a4a1125f2ccc7
This reverts commit 4f525f6fa04195cdb93fc4394fbc0c78f2626bd7.
I accidentally included some unrelated changes in #17972, so backing out here.
Source-Repo: https://github.com/servo/servo
Source-Revision: 40315a6bf701dc8ade850f7521acf023966d1a09
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 96056d1c77c1afd7638026bab0a3a43346bdb131
In order to properly handle CSS clipping, we need to keep track of what
the different kinds of clips that we have. On one hand, clipping due to
overflow rules should respect the containing block hierarchy, while CSS
clipping should respect the flow tree hierarchy. In order to represent
the complexity of items that are scrolled via one clip/scroll frame and
clipped by another we keep track of that status with a
ClipAndScrollInfo.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 49615284d0f45646da917f7dda22a1103d12974d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b950eddcbaa45507365bf0e94255f9ae86258bd4
These address some small inefficiencies that showed up while profiling the myspace talos test.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: aef95cf195d8d74595b7b266472bc34634c49120
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e4430604b572fe5a92b660e05768067e6afb18e5
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Either: -->
- [ ] There are tests for these changes. The test code is patch 3 in https://bugzilla.mozilla.org/show_bug.cgi?id=1386963
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 50c9797ddd7b206c96f9436c634d915efe4acc17
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 596da466caf6c5be55db82c0734ee90398f933ec
This "fixes" bug 1381821 by disabling the optimization in the cases we can't
prove this is correct. Bug 1387116 tracks fixing the optimization to apply more
broadly.
Bug: 1381821
Reviewed-by: bz
MozReview-Commit-ID: COKdmHHokGx
Source-Repo: https://github.com/servo/servo
Source-Revision: a59a8f835531b38cfe6e4cf25d6a36d1e8b741b3
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d237685ba182c1723d58f4d91908f7012fd79b49
The traversal currently expects every flow to have a scroll root id
assigned, even if it doesn't produce any display items. This change
fixes the error that arises from this situation.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they do not change behavior, just fix a runtime warning.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 46f6e68bad7aafc380976bfddd9e76bfaa86229e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : de75e85a605eaa517b1a88afed60a541df8bba3f
This is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1381851
Source-Repo: https://github.com/servo/servo
Source-Revision: c18cac1f342ecf7f5986ea3fec857fdaca649d9f
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d6120073c92edf3ae9827dc6d1699b25854fa50f
Unfortunately this means that we lose the NS_STYLE_INHERIT_BIT optimization to
avoid posting changes if we had not requested the struct. In practice, I'm not
sure this optimization matters much, though, and we already compare all the
structs anyway.
We _could_ keep a weak parent pointer from the text style if needed, given we're
going to keep alive the text style at least until the parent style context goes
away, so should be safe, but I don't think the extra churn is worth it, to be
honest. Happy to do so as part of bug 1368290 if you think it's worth it.
Bug: 1385896
Reviewed-by: heycam
MozReview-Commit-ID: ka6tNwf4Ke
Source-Repo: https://github.com/servo/servo
Source-Revision: 452268eca9862e0e150ce3bf828a157263d33341
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a93a31b263625092d832960c003f6e6163dace6e
This is the Servo side change of [bug 1386871](https://bugzilla.mozilla.org/show_bug.cgi?id=1386871).
Source-Repo: https://github.com/servo/servo
Source-Revision: 24b2cd89c124457e837bcde7cc9101747b96e9d4
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1da9d6a8cc2c89b29a4a04c6567fb792a24973bb
This is all the ones I could find in style/ and selectors/.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1374848
Source-Repo: https://github.com/servo/servo
Source-Revision: 27d1fbe7eae70603a4f477156360068c11515e88
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b97ec1ec1c36a766beb211aa305441a42b8d673f
…xed style
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
https://bugzilla.mozilla.org/show_bug.cgi?id=1380259
Source-Repo: https://github.com/servo/servo
Source-Revision: 13df7e4c84e5cfafbb39e2e0096f6a0722bb15dc
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b2b30792f9b4767ce7437d447c62b8b6ec783771
Hiroyuki Ikezoe
Boris Chiou
Glenn Watson
Matt Brubeck
DarkDrek
Emilio Cobos Álvarez
Fernando Jiménez Moreno
Manish Goregaokar
Daisuke Akatsuka
Nathan Froyd
Alan Jeffrey
Simon Sapin
Cameron McCormack
Nazım Can Altınova
Bobby Holley
Martin Robinson
Xidorn Quan
Josh Matthews
Ting-Yu Lin