CLOSED TREE
Backed out changeset d3d67293f115 (bug 1623413)
Backed out changeset 75ed1b8a5c67 (bug 1623413)
Backed out changeset 0eef32d6a454 (bug 1623413)
The browserId is stable across navigations, but the browsing context
itself might not be if we are not preserving the BC across navigations.
It might seem like this change would mean that we'd start getting notified
about events for subframes, but the old code was passing in the BC of the
top level frame anyways, so that's not a change in behavior.
Differential Revision: https://phabricator.services.mozilla.com/D89179
The manifest file hasn't actually done anything since XPT definitions were
moved to the libxul binary, and now just generates warnings in local builes.
Differential Revision: https://phabricator.services.mozilla.com/D89197
Pipenv is heavy weight and overkill for the purposes it is being used. We'd like to remove it from the tree and |mach python-test| was one of the last remanining use cases.
Remove the `--python` command-line argument as a result. Users who wish to run unit tests with Python 2 can do `MACH_PY2=1 ./mach python-test ...` or `python2 ./mach python-test ...`.
Also update a few unit tests that would break otherwise in the presence of this change.
There were a couple lines in the `setup.py` for `mozlog` that were problematic for tests and was resulting in errors due to the `mozlog` plugin being loaded by `pytest` more than once. We just delete those lines and bump up the major version number of the package to fix it.
Differential Revision: https://phabricator.services.mozilla.com/D88296
Automatic update from web-platform-tests
COOP: add reporting to redirects
This CL allows reporting browsing context group switches triggered by
redirects and updates the reports sent in this case to the latest
version of the spec PR (https://github.com/whatwg/html/pull/5518). Since
the status of COOP was becoming hard to track, I moved it to its own
class for better encapsulation.
Bug: 1059303
Change-Id: Ifafb23073301bd05cd9ce83fdb0b748c28e8a51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352880
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799863}
--
wpt-commits: 677c57c0e8816b0892cc3ae1c2772189b1bdcf65
wpt-pr: 25072
Automatic update from web-platform-tests
[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."
This reverts commit 3bc91ccc927f8eb887a84a1e59f34c88518ce2ab.
Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329
Original change's description:
> [Perfect Negotiation] Surface session descriptions at the right time.
>
> This fixes another timing related issue that blocks Perfect Negotiation.
>
> Before this CL, current/pending local/remote description attributes do
> blocking-invokes on the webrtc thread, fetching the most up-to-date
> states. This can prematurely expose the result of "in-parallel"
> operations that have not surfaced yet, such as:
> - setLocalDescription
> - setRemoteDescription
> - addIceCandidate
>
> This CL fixes that by copying the SDP states when any of these
> operations complete on the WebRTC thread and carry them over in the
> PostTask to the main thread. Here, we store these snapshots in
> "internal slots" (variables living on the main thread). With this CL,
> reading SDP attributes from RTCPeerConnection is non-blocking and
> spec-compliant.
>
> WPT test coverage added for the exact timing of SLD/SRD and other test
> expectations are updated. addIceCandidate updating the SDP is already
> covered by old WPTs.
>
> Bug: chromium:1110347
> Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801798}
TBR=hta@chromium.org,hbos@chromium.org
Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1110347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715
Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#801822}
--
wpt-commits: dc1106492705bb07a14a066eab757981159cb7b9
wpt-pr: 25248
Automatic update from web-platform-tests
Fix test flake in animation-state-changes-positive-playback-rate.html
The flake is caused by limited precision of timeline times. When
comparing times with >=, the boundary time needs to factor in error
tolerance.
The virtual/threaded-no-composited-antialiasing variant of this test
had a recent flake score of 954.
Bug: 623434
Change-Id: I44b41da1326849da4b3dec30cea76be6673e0b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368500
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801013}
--
wpt-commits: ec11bcffbb38f6b10c500f13edeaa5844339f66b
wpt-pr: 25182
Automatic update from web-platform-tests
[Perfect Negotiation] Surface session descriptions at the right time.
This fixes another timing related issue that blocks Perfect Negotiation.
Before this CL, current/pending local/remote description attributes do
blocking-invokes on the webrtc thread, fetching the most up-to-date
states. This can prematurely expose the result of "in-parallel"
operations that have not surfaced yet, such as:
- setLocalDescription
- setRemoteDescription
- addIceCandidate
This CL fixes that by copying the SDP states when any of these
operations complete on the WebRTC thread and carry them over in the
PostTask to the main thread. Here, we store these snapshots in
"internal slots" (variables living on the main thread). With this CL,
reading SDP attributes from RTCPeerConnection is non-blocking and
spec-compliant.
WPT test coverage added for the exact timing of SLD/SRD and other test
expectations are updated. addIceCandidate updating the SDP is already
covered by old WPTs.
Bug: chromium:1110347
Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801798}
--
wpt-commits: 0d794eb31a9920dd63065a1c4de2d14132b986f5
wpt-pr: 24800
Automatic update from web-platform-tests
[html] Test sequence of navigation failure checks
This test is in support of this patch to HTML: https://github.com/whatwg/html/pull/5859
--
wpt-commits: 63c8be26e528d19e77819bbb6c9ad7aab5ea5abe
wpt-pr: 25215
Automatic update from web-platform-tests
Never re-use the layout result from the fieldset contents wrapper.
On the layout object side, all children of a fieldset are wrapped inside
an anonymous fieldset contents block. We'll detect during layout which
of the legend children (if any) will become the rendered legend. Unlike
all other in-flow children of a fieldset element, whose containing block
is the wrapper, the containing block of the rendered legend is the
fieldset layout object itself (not the wrapper child), so if we change /
remove the rendered legend, the wrapper won't be marked for layout.
Bug: 1119400
Change-Id: I5b898af8c7b7e3687def6a2333d43a8ba6af09b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374526
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801772}
--
wpt-commits: 6b6a74e478f36b8039d448d8f44f86033dabefa3
wpt-pr: 25227
Automatic update from web-platform-tests
Fixed test/reference mismatch for border.
Test added a border of 20px to a width of 80px and expected 100px, but
border is added to both sides. Reduced border to 10px.
Bug: 1121917
Change-Id: I98fd76c9eb9581f842e2d8ea90e2e8b32fba01f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377487
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801714}
--
wpt-commits: 9ad6ebf9fff00dcd46d6c5438ebbd0f7e71c15f8
wpt-pr: 25243
We still reframe for additions / removals of the attribute because that
makes us create the placeholder <div>. We could avoid it if we created
it independently of the presence of the attribute but that seems like it
could regress perf for the case where there's no placeholder attribute,
which is probably common enough.
Differential Revision: https://phabricator.services.mozilla.com/D88724
We set pending visual scroll updates even for RSFs that are on subdocuments,
so we should ensure they get acknowledged and cleared on paints. Otherwise
the pending visual scroll update can get "stuck" and it affects things that
depend on it, such as the drag-selection code.
Differential Revision: https://phabricator.services.mozilla.com/D88893
Kagami Sascha Rosylight
Mihai Alexandru Michis
Hiroyuki Ikezoe
Ting-Yu Lin
Karl Tomlinson
Geoff Brown
Andrew McCreight
James Willcox
Kris Maglione
Chris H-C
Ricky Stewart
Mark Banner
Gregory Mierzwinski
James Graham
moz-wptsync-bot
Camille Lamy
Amr Aboelkher
Kevin Ellis
Henrik Boström
jugglinmike
Morten Stenshorne
Gérard Talbot
Rune Lillesveen
youennf
Emilio Cobos Álvarez
Kartikaya Gupta
Henrik Skupin
Michael Froman
Butkovits Atila
Cristina Coroiu