Nicholas Nethercote
cd426e3ad2
Bug 1569526 - Remove return values from `Add*VarCache()`. r=KrisWright
...
They're infallible in practice and always `NS_OK`. (This stems from
`AddVarCacheNoAssignment()` always returning `NS_OK`.)
As a result, the commit removes lots of unnecessary checks.
Differential Revision: https://phabricator.services.mozilla.com/D39804
--HG--
extra : moz-landing-system : lando
2019-07-30 06:19:46 +00:00
Byron Campen [:bwc]
13d7ab645a
Bug 1566445: Rename a couple of macros to avoid conflicts. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D38226
--HG--
extra : moz-landing-system : lando
2019-07-20 15:56:31 +00:00
Narcis Beleuzu
59c3fccd33
Merge inbound to mozilla-central. a=merge
2019-07-09 06:45:48 +03:00
Jonathan Kingston
31441f82ea
Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D35504
--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Sylvestre Ledru
131d0c6a02
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35622
--HG--
extra : moz-landing-system : lando
2019-07-06 08:18:28 +00:00
Gurzau Raul
93233f439a
Merge mozilla-central to inbound. a=merge CLOSED TREE
2019-07-07 01:44:47 +03:00
Jan Varga
b240a41330
Bug 1562942 - Followup patch, fix a failing test; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D36934
2019-07-04 18:26:29 +02:00
Victor Porof
0a8ff0ad85
Bug 1561435 - Format dom/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35951
--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Jan Varga
82fad8077a
Bug 1542572 - Add more temporary logging to LocalStorageShutdownTimeout crash annotation; r=asuth dr=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D34295
2019-06-09 21:46:34 +02:00
Jan Varga
73bc7c8dc2
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D34814
2019-06-13 04:17:52 +02:00
Razvan Maries
94dd792600
Backed out changeset 6baa1883dc72 (bug 1559029) for ES Lint failure.
2019-06-13 07:33:58 +03:00
Jan Varga
a7f81b45b5
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D34814
2019-06-13 04:17:52 +02:00
Jan Varga
5346f3347e
Bug 1558112 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically detach the shadow database on an error; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D34311
2019-06-10 08:41:13 +02:00
Jan Varga
e3f0977fd5
Bug 1540401 - Backout Part 1: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541972 hasn't been fixed yet; r=asuth
2019-06-07 15:11:56 +02:00
Eden Chuang
6ae5d6c65c
Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D33617
2019-06-07 08:18:37 +02:00
Jan Varga
d3f2beee0e
Bug 1540401 - Backout Part 4: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541771
hasn't been fixed yet; r=asuth
2019-06-05 20:07:50 +02:00
Mihai Alexandru Michis
153172de0c
Merge inbound to mozilla-central. a=merge
2019-06-05 12:51:25 +03:00
Jan Varga
fe813f031d
Bug 1534431 - Part 2: Disallow LS requests with undefined client id; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D33595
2019-06-03 15:32:59 +02:00
Jan Varga
e84d1ebb62
Bug 1534431 - Part 1: Verify LS request parameters as part of LS request state machine; r=asuth
...
LS Request parameters are now verified as part of the state machine so an actor
is always created. Before this patch, we were doing verification prior to actor
creation. If the verification failed, we didn't create an actor and content
was endlessly waiting for a reply.
2019-06-03 15:32:50 +02:00
Narcis Beleuzu
3c50127358
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-06-05 00:51:07 +03:00
Nihanth Subramanya
203396c6e0
Bug 1555562 - Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal. r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D33559
--HG--
extra : moz-landing-system : lando
2019-06-04 21:13:40 +00:00
Jan Varga
67c1136dd9
Bug 1556217 - LSNG: Add a test for large items; r=asuth, smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D33417
2019-06-02 08:00:25 +02:00
Jan Varga
c6f87cb635
Bug 1540401 - Backout Part 3: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541772 hasn't been fixed yet; r=asuth
2019-06-04 09:59:11 +02:00
Jan Varga
65f92e054f
Bug 1552428 - LSNG: Datastore::PrivateBrowsingClear uses wrong delta for usage updating; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31605
2019-05-17 10:30:19 +02:00
Razvan Maries
7afbe4a8bf
Backed out changeset 01dd2842bbaa (bug 1552428) for ES Lint failure. CLOSED TREE
2019-05-31 18:07:15 +03:00
Jan Varga
673d464ca1
Bug 1552428 - LSNG: Datastore::PrivateBrowsingClear uses wrong delta for usage updating; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31605
2019-05-17 10:30:19 +02:00
Jan Varga
197c57d894
Bug 1546723 - Followup fix: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541775
hasn't been fixed yet; r=asuth
2019-05-30 21:34:11 +02:00
Jan Varga
cce54f42f2
Bug 1546723 - Part 7: Fix ordering of items in special cases; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31202
2019-05-15 06:11:11 +02:00
Jan Varga
f122f3cf74
Bug 1546723 - Part 6: Mark snapshot as dirty if the hasOtherProcessObservers flag changes; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31201
2019-05-15 06:11:11 +02:00
Jan Varga
55c0e5ec44
Bug 1546723 - Part 5: Generalize code for getting datastores; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31200
2019-05-15 06:11:11 +02:00
Jan Varga
b5acd8a9aa
Bug 1546723 - Part 4: Use a write optimizer in LSSnapshot; r=asuth
...
This patch adds a write optimizer to LSSnapshot. The optimizer is only used when
there are no observers for other content processes.
Differential Revision: https://phabricator.services.mozilla.com/D31199
2019-05-15 06:11:11 +02:00
Jan Varga
46fee7012e
Bug 1546723 - Part 3: Change GetSnapshotInitInfo to deal with load info only; r=asuth
...
This patch renames GetSnapshotInitInfo to GetSnapshotLoadInfo and removes some arguments that are not directly related to load info.
Differential Revision: https://phabricator.services.mozilla.com/D31198
2019-05-15 06:11:10 +02:00
Jan Varga
70f70b482a
Bug 1546723 - Part 2: Make it more clear that checkpointing also notifies observers; r=asuth
...
This patch renames the Checkpoint IPC message to CheckpointAndNotify. Other structures used by checkpointing are renamed too. Datastore methods SetItem/RemoveItem/Clear no longer call NotifyObservers, it's now up to RecvCheckpointAndNotify to call it.
Differential Revision: https://phabricator.services.mozilla.com/D31197
2019-05-15 06:11:10 +02:00
Jan Varga
a74b30fb4c
Bug 1546723 - Part 1: Convert WriterOptimizer to a generic reusable class; r=asuth
...
This patch creates a new generic class LSWriteOptimizer which can be used with any value type for specific write optimizations either on the parent side or the child side.
Differential Revision: https://phabricator.services.mozilla.com/D31196
2019-05-15 06:11:10 +02:00
Ehsan Akhgari
98960a9c41
Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D32556
--HG--
extra : moz-landing-system : lando
2019-05-27 14:06:49 +00:00
Jan Varga
c673cb342d
Bug 1540401 - Backout Part 2: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541775
hasn't been fixed yet; r=asuth
2019-05-23 10:26:20 +02:00
Dorel Luca
60706fc799
Merge mozilla-inbound to mozilla-central. a=merge
2019-05-18 13:25:28 +03:00
Gurzau Raul
bc953c3503
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-05-18 00:46:18 +03:00
Tom Tung
a3f0aa60d4
Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D27502
--HG--
extra : moz-landing-system : lando
2019-04-29 10:49:58 +00:00
Jan Varga
869d5c854a
Bug 1548847 - Invalidate LSDatabase xpcom-shutdown observer after removing it from the observer service; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D31293
2019-05-15 19:35:22 +02:00
Jan Varga
8c9f766a02
Bug 1540401 - Part 4: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541771
has been fixed; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D27494
2019-04-15 13:55:42 +02:00
Jan Varga
e8e655e076
Bug 1540401 - Part 3: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541772 has been fixed; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D27493
2019-04-15 13:52:08 +02:00
Andrea Marchesini
99cbfe545e
Bug 1551055 - StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D30947
--HG--
extra : moz-landing-system : lando
2019-05-14 05:49:58 +00:00
Andrea Marchesini
dc7545548e
Bug 1551055 - StoragePrincipal should be supported by localStorage - part 1, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D30801
--HG--
extra : moz-landing-system : lando
2019-05-14 05:49:46 +00:00
Ciure Andrei
f1dd75ca22
Backed out 3 changesets (bug 1551055) for causing xpcshell localStorage perma failures CLOSED TREE
...
Backed out changeset 21e44ad9c6df (bug 1551055)
Backed out changeset 8727e61ab69b (bug 1551055)
Backed out changeset d99a6769beb4 (bug 1551055)
--HG--
extra : rebase_source : 56f7fe5c54cd7e4109acce5074be1aba12e91086
2019-05-13 22:40:22 +03:00
Andrea Marchesini
1b54d6f1cd
Bug 1551055 - StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D30947
--HG--
extra : moz-landing-system : lando
2019-05-13 18:45:12 +00:00
Andrea Marchesini
e1b74991fb
Bug 1551055 - StoragePrincipal should be supported by localStorage - part 1, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D30801
--HG--
extra : moz-landing-system : lando
2019-05-13 18:42:36 +00:00
Jan Varga
eef773ad6c
Bug 1549654 - LSNG: Compress specific values during migration; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D30181
2019-05-07 12:54:02 +02:00
Jan Varga
e25844ad71
Bug 1548788 - LSNG: Datastore preparation doesn't have to create new origin directories if they don't exist; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D29822
2019-05-03 15:03:54 +02:00
Jan Varga
ea67826b85
Bug 1547688 - LSNG: Preloading can use gUsages hash table to quickly finish if there's nothing to preload; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D29194
2019-04-29 14:23:55 +02:00