Automatic update from web-platform-tests
[LargestContentfulPaint] Fix flaky test observe-image.html
The timestamp captured at onload does not seem to always be smaller than
the render timestamp. This CL changes the lower bound so the test is no
longer flaky.
Bug: 978587
Change-Id: I48c058ac0abb684cb4406617500356d0aae019e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678836
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672691}
--
wpt-commits: 0a02aa2599f1914a56b8557f29ec579ca5e6e701
wpt-pr: 17528
Automatic update from web-platform-tests
Query WebMediaPlayer when checking for presence of video frame.
ReadyState has never been suficient to test whether a video frame is
actually present. Instead we need to know when the frame has actually
been delivered to the compositor.
This patch updates HTMLVideoElement to query a new WebMediaPlayer method
which exposes the compositor's knowledge of the video frame.
Note: This patch also fixes some spurious logs and HTMLVideoElement tests
that were silently doing nothing.
BUG=974012,974190
TEST=new unittest.
TBR=eae
Change-Id: I1df54491c1fd7c2246ce0f60bc6e794b8b84476a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659490
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672682}
--
wpt-commits: b6b0d9b33bd45d468f7835cb79b7de318123aead
wpt-pr: 17348
Automatic update from web-platform-tests
Web MIDI: reflect spec's [SecureContext] to relevant .idl files
This is a follow up to disallow Web MIDI uses on insecure origins.
After this change, the Web MIDI related interfaces won't appear
on insecure origins.
https://github.com/WebAudio/web-midi-api/issues/183https://github.com/WebAudio/web-midi-api/issues/199
Bug: 924471
Change-Id: I61d55d5ba192a6cbcea9e29f97c4bfe11ac4b983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673491
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672474}
--
wpt-commits: 12b6e03e14f991cc20a6b80dc7c4dc09d78ba9bf
wpt-pr: 17520
--HG--
rename : testing/web-platform/tests/feature-policy/reporting/midi-report-only.html => testing/web-platform/tests/feature-policy/reporting/midi-report-only.https.html
rename : testing/web-platform/tests/feature-policy/reporting/midi-report-only.html.headers => testing/web-platform/tests/feature-policy/reporting/midi-report-only.https.html.headers
rename : testing/web-platform/tests/feature-policy/reporting/midi-reporting.html => testing/web-platform/tests/feature-policy/reporting/midi-reporting.https.html
rename : testing/web-platform/tests/feature-policy/reporting/midi-reporting.html.headers => testing/web-platform/tests/feature-policy/reporting/midi-reporting.https.html.headers
Automatic update from web-platform-tests
[LayoutNG] Don't run the OOFLayoutPart if we have any adjoining floats.
If we have adjoining floats we'll revisit the node to correctly place
floats. During the first pass we may not have floats present within
lineboxes, causing NGContainerFragmentBuilder::GetChildOffset to fail.
This makes sure we don't run the OOFLayoutPart for this condition.
There is a followup cleanup patch I'll send out for review later which
speculatively places floats avoiding this condition also:
https://chromium-review.googlesource.com/c/chromium/src/+/1619047
Bug: 976397
Change-Id: I10db8207357572521fc9103134cb6fbf885c4a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676727
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672423}
--
wpt-commits: 5a42c001e74045dd9347ce9870fb7a8f17e6286a
wpt-pr: 17504
Automatic update from web-platform-tests
[WebUSB] Fix usage of WTF::Vector as a bit vector
When using WTF::Vector as a replacement for WTF::BitVector the bits
should be set using assignment rather than with insert() and EraseAt().
The latter changes the length of the bit vector as it is used.
Bug: 977638
Change-Id: I59390412013c97c7c06aa7239cab75a2557e8f07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673131
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672358}
--
wpt-commits: a18f55bcc133a4638fd77c67d0bc41e48c70d15d
wpt-pr: 17468
Automatic update from web-platform-tests
Set default font size for OffscreenCanvas to 10px
There's no hard standard on this, so we are matching the behavior
of detached canvas.
Bug: 977876
Change-Id: I84f8e32000f290d6826722863bb6fb16116e2f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675911
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672198}
--
wpt-commits: 79f12a79675c0b084737d43b1af2cb85f97bbff9
wpt-pr: 17496
Automatic update from web-platform-tests
Indexed DB: store/index keyPath property should return same instance
On IDBObjectStore and IDBIndex instances, the keyPath property says is
defined in the spec with: "if this attribute returns an object
(specifically an Array), it returns the same object instance every
time it is inspected". Web platform tests for this were missing.
Since the property is 'any' in Web IDL (since it could be a string or
Array) it can't use the [SameObject] extended attribute. And in the
Blink IDL, it can't use the [SaveSameObject] hint since that requires
[SameObject]. Instead, use the [CachedAttribute] hint and never dirty
the cache.
Bug: 977048
Change-Id: Ic4ede31a3a01e7a8a90c4f54eb8a989a673fcf22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674495
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672137}
--
wpt-commits: 1fd5380edd2390b2584c2c51754749d68916a525
wpt-pr: 17480
Automatic update from web-platform-tests
Individual WPT tests for each backdrop-filter
This CL adds a specific, individual WPT test for each type of
backdrop-filter effect.
If you find yourself here, looking for the test for blur() or
a multi-filter (combined) test, see crbug.com/978481.
Bug: 831485
Change-Id: I065fd94dbfe5ef0813ffe90f07878247147d3261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674708
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672131}
--
wpt-commits: d4a8ad3cb52de06a90b991dd0107f5ffbe206125
wpt-pr: 17501
Automatic update from web-platform-tests
Fetch: Origin outside of CORS
Ensure we have more coverage for how to set the Origin header outside of
CORS. And also how its value is impacted by Referrer Policy.
Fetch change: https://github.com/whatwg/fetch/pull/908.
Co-authored-by: Junior Hsu <cuveehsu@gmail.com>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
--
wpt-commits: ef44bff0adaa07f2e420a0cbc1bc493cd5786656
wpt-pr: 14260
Automatic update from web-platform-tests
math-script-level-004: Fix expectation for the font-size values. (#17534)
When the MATH table has scriptScriptPercentScaleDown the spec says 0.5041 = 0.71^2 should be used as the default value.
The scale80-0-scaleup test incorrectly uses a hardcoded value of 0.71 instead.
This patch fixes this issue and introduces new variables for the fallback values of scriptPercentScaleDown and scriptScriptPercentScaleDown
to clarify the expectation.
--
wpt-commits: 677e4ac410c6538a76c72d704768dc9c0e8bc0c5
wpt-pr: 17534
Automatic update from web-platform-tests
KV Storage: add timeout=long and reenable disabled test
Like several IndexedDB tests, KV Storage can cause timeouts unless given more time.
BUG=936615
Change-Id: I8069d77088625b32867a5ebcc9ce69c4810a18ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670621
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671576}
--
wpt-commits: 88bac6b712530867081709212b365a6a01feee04
wpt-pr: 17421
Automatic update from web-platform-tests
KV Storage: update to match IDL
Along with https://chromium-review.googlesource.com/c/chromium/src/+/1670572, this aligns the KV Storage implementation with https://github.com/WICG/kv-storage/pull/68, which uses Web IDL to define the API. The observable changes are to:
* Enumerability of methods
* Adding @@toStringTag (affecting Object.prototype.toString.call)
This includes web platform tests that abuse the current idlharness.js infrastructure, plus some ad-hoc hand-written tests that we expect to be generated by future versions of idlharness.js once the relevant Web IDL pull requests are merged. It removes the existing API surface tests and helpers in favor of idlharness.js.
Bug: 931263
Change-Id: I9205d1a8b3040617cbb6200f825ba9ad250e61c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672137
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671975}
--
wpt-commits: 72da3e36e3657a358c4e74b495e582262b40a016
wpt-pr: 17443
Automatic update from web-platform-tests
Fix font size expectation (#17524)
The local variable should match the actual font-size.
--
wpt-commits: 5fd60735ebebf21db46f272587052c360ebd7615
wpt-pr: 17524
Automatic update from web-platform-tests
[docs] Simplify recommendation for advanced usage
The steps listed in the "Tips & Tricks" section largely summarize the
instructions in the preceeding sections with two exeptions:
1. the recommendation to rebase (which lacks a definition)
2. the warning against modifying the branch following submission (which
conflicts with a prior section)
Remove the steps and expand the recommendation of Pro Git.
--
wpt-commits: 4b93a2e9c9f904265ae755291ca253045adb3f66
wpt-pr: 17369
Automatic update from web-platform-tests
Merge pull request #17292 from gsnedders/ahem-part2b
Add ahem.css to many more tests
--
wpt-commits: daf75e3bc7829fc4de06bff7136009210aafe3e5
wpt-pr: 17292
Automatic update from web-platform-tests
[Navigation Timing] secureConnectionStart should be non-zero
The value of secureConnectionStart should be non-zero for secure
context navigations. It wasn't. This CL makes sure that it is!
Bug: 977519
Change-Id: Ia12e2842bc061e687512f1ed94d02c07f4dd42ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672068
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671799}
--
wpt-commits: 87e1dabfa2ef2cf1d1946f428d19973b9bb35ddc
wpt-pr: 17438
Automatic update from web-platform-tests
Add more tests for fraction gaps. (#17486)
These tests check the gap parameters from https://mathml-refresh.github.io/mathml-core/#fractions-mfrac
The existing frac-parameters-1 and frac-parameters-2 tests use mspace elements as numerator/denominator so the box returned by getBoundingClientRect() perfectly encloses the visual rendering of these elements.
These versions rely on reftests to check when mtext elements are used as numerator/denominator with a font typo ascent/descent different from the actual glyph's bounding box ascent/descent. In each case, three glyphs are tested (centered, above or below the baseline).
These tests pass on gecko/webkit but currently fail with the chromium-mathml build for glyphs that are not centered on the baseline.
--
wpt-commits: ecc43f56d11b2485f17bf57c0db2031778d3eca9
wpt-pr: 17486
Automatic update from web-platform-tests
Bring XRRay.matrix and XRRay constructors up to spec
Minor update to XRRay.matrix algorithm to recompute internal matrix
if it was detached.
Modification to XRRay's constructors to throw InvalidStateError in
case direction normalization cannot be performed.
Update WPT tests to account for the change.
Bug: 957763
Change-Id: I7e65b660de013badbc2cff249d5a75a5fa75ab96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671871
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671779}
--
wpt-commits: 766f40ade665477bdc44b5070a5d7cf533748552
wpt-pr: 17462
Automatic update from web-platform-tests
[wpt PR 16992] - Revert "Frame freezing on load.", a=testonly
Automatic update from web-platform-tests
Revert "Frame freezing on load."
This reverts commit 0daefdcf34ba9a8c21ab907b2159c5652169a45b.
Reason for revert:
DCHECK(!GetDocument()->LoadEventStillNeeded());
in local_frame.cc is failing at
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29
Original change's description:
> Frame freezing on load.
>
> Move load event checks to renderer side so it is consistent with the
> page lifecycle spec. Add additional resource that is slow to load
> to ensure the load event is waited for correctly before freezing.
>
> BUG=907125
>
> Change-Id: I8f45ddffcf3ce88f6244307833325a54e1c2d395
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625464
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662340}
TBR=avi@chromium.org,haraken@chromium.org,dtapuska@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 907125
Change-Id: I4e27e30519359e2a3ef0d2c92a0fc9d88ac78aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628499
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663009}
--
wp5At-commits: 138d2e938d493a5c8435025162759c2e34b3b1d1
wpt-pr: 16992
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554083
gecko-commit: 6b5ce266625e08bf06a40e6fd2b9b419a9f7f3ed
gecko-integration-branch: central
gecko-reviewers: testonly
--
wpt-commits: 87c8ca1b6f9debb046752ca92d6cea7af6e9f17c
wpt-pr: 17463
Automatic update from web-platform-tests
[wpt PR 17233] - Active Processing for ConvolverNode, a=testonly
Automatic update from web-platform-tests
Active Processing for ConvolverNode
The ConvolverNode should output a single channel of silence when it is not
actively processing. Active processing is already supported and just needed
to have the convolver output a single channel of silence when it is
constructed, before anything is connected to it.
Bug: 971389
Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668149}
--
wp5At-commits: 6531eab802391a24dabca973cc4329abbeadd896
wpt-pr: 17233
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1558611
gecko-commit: 3b9b543d1c8db5573155dc6ff44e65f871ae6ec9
gecko-integration-branch: central
gecko-reviewers: testonly
--
wpt-commits: 9e43b67f4fec9e0a1ffe2d91a5b4fd0c9b5ad705
wpt-pr: 17461
Automatic update from web-platform-tests
Revert "Insert a generated item after preserved spaces following a forced break"
This reverts commit 6b0ca8ce33e71d570fce11ae6fb5f898ddf053e4.
Reason for revert:
Broke external/wpt/css/css-text/word-break/word-break-break-all-004.html on many Mac bots:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/44291https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/39449https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/24278https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/14909https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/16025
Original change's description:
> Insert a generated item after preserved spaces following a forced break
>
> We already had to implement a special logic to deal with leading
> preserved white spaces due some optimizations we have in the line
> breaking code to give always breaking opportunities before spaces.
>
> However, the presence of forced breaks may cause some of the following
> spaces becoming leading preserved spaces in the next line.
>
> This patch applies the same logic we had for such leading spaces at
> the text's first line. It also needs to define additional cases in the
> function that evaluates the need of adding these generated breaking
> opportunity items.
>
> Bug: 976195
> Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671656}
TBR=jfernandez@igalia.com,kojii@chromium.org
Change-Id: I418bb0d30fce7f9ac5724f76c0a854bcb070aa5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 976195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674249
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671703}
--
wpt-commits: 3d97450f2c48758db3f76f3360ff7c3e4069c320
wpt-pr: 17465
Automatic update from web-platform-tests
Add test checking SharedArrayBuffers are transferred over MessageChannels
SharedArrayBuffers in Chrome don't end up getting passed correctly when
it crosses a document boundary. This is because of the simplistic
Cluster Agent Key implementation. SharedArrayBuffers are currently
passed correctly provided the MessageChannel is all inside the same
document. (a document and itself, or a document and an associated worker).
BUG=798572
Change-Id: I012b2fbdae52ebee7d26034caa996f2e0cf929ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672777
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671672}
--
wpt-commits: b3418ad6bf7b49e59025e5278e1291587c6fc10e
wpt-pr: 17454
Automatic update from web-platform-tests
Insert a generated item after preserved spaces following a forced break
We already had to implement a special logic to deal with leading
preserved white spaces due some optimizations we have in the line
breaking code to give always breaking opportunities before spaces.
However, the presence of forced breaks may cause some of the following
spaces becoming leading preserved spaces in the next line.
This patch applies the same logic we had for such leading spaces at
the text's first line. It also needs to define additional cases in the
function that evaluates the need of adding these generated breaking
opportunity items.
Bug: 976195
Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671656}
--
wpt-commits: 9348328991a301000225e6da1010755eceaf1389
wpt-pr: 17393
Automatic update from web-platform-tests
[docs] Add detail on writing Python handlers (#17386)
Extend the documentation on writing Python handlers to more completely
describe the feature. Introduce a short example to concretely
demonstrate its usage. Apply similar changes to the corresponding
documentation in the `wptserve` directory for parity.
--
wpt-commits: acbefd606a1b9284b96d21a4a332d0202e36d531
wpt-pr: 17386
Automatic update from web-platform-tests
[Azure Pipelines] put parenthesis pack in step names
This reverts drive-by changes for consistency in commit
e75855649360298870a40ed78874bd4ab1470c20, which actually left the step
names inconsistent.
--
wpt-commits: 42ea2f906ab2367dc4403fb5cf8f7d476f9e0e5c
wpt-pr: 17409
Automatic update from web-platform-tests
Improve failing condition of a test (#17452)
So it doesn't time out.
--
wpt-commits: 1f512077ca0998e0af60ff727eea8c8ba5d78491
wpt-pr: 17452
Automatic update from web-platform-tests
Revert "[serve] Make pywebsocket honor log_level config"
This reverts commit 7edf9eabfae3550a4dd2a48625e68b02a734de15.
--
Fix pywebsocket logging properly
The previous attempt (#17124) called pywebsocket._configure_logging,
which had the unwanted side effect of resetting lots of logging setup in
the pywebsocket subprocess (e.g. mozlog configured by wptrunner -- the
log messages produced by pywebsocket lost its structure and became a
simple STDERR text captured by mozlog.capture).
Instead of calling pywebsocket._configure_logging, the original issue
(log level in config.json not honoured by pywebsocket) should be fixed
by setting the log level on the root logger instead, which will set up
all loggers (including those in third-party libraries) correctly. This
is done only on the entry point of `wpt serve` and won't affect
wptrunner which has its own logging setup.
--
wpt-commits: b693b1b954a8828dc5a0c69319e234b9e3b2d76d, 6e7ac6df08e23d9c8e7aa3223f387f71beb39b9c
wpt-pr: 17433
Automatic update from web-platform-tests
Handle null ::first-letter text layout object.
Ideally, UpdateFirstLetterPseudoElement() will remove the ::first-letter
pseudo element from the DOM when there is no text which can contain the
first letter. Hence, we should not end up in a situation where we try to
AttachLayoutTree for the FirstLetterPseudoElement with a null
first_letter_text.
However, the layout tree is different in AttachLayoutTree() than in
UpdateFirstLetterPseudoElement() in the case where there already was a
::first-letter pseudo element, since we detached it right before
AttachLayoutTree. This means we may have different results for
FirstLetterTextLayoutObject() at those two points if the method has
bugs.
Such a bug was found here where a list item marker inside an anonymous
block had an out-of-flow sibling, but we were not able to traverse out
of the anonymous block to find the first letter text.
Add a DCHECK to let us trigger cases where FirstLetterTextLayoutObject()
is buggy, but also add if-tests to make sure we don't crash.
Bug: 977044
Change-Id: Id80f8aad5c04678d64927e7a7ca4d60cdb6a4b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672845
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671629}
--
wpt-commits: 53ebe42e282c9cd4c49d8e615b30eee06c2211a0
wpt-pr: 17447
Automatic update from web-platform-tests
[shapedetection] Add some shapedetection tests
Cover following two checkpoints:
- If the ImageBitmapSource is an HTMLVideoElement object whose readyState attribute
is either HAVE_NOTHING or HAVE_METADATA then reject the Promise with a new
DOMException whose name is InvalidStateError.
- If the ImageBitmapSource argument is an HTMLCanvasElement whose bitmap’s origin-clean
flag is false, then reject the Promise with a new DOMException whose name is SecurityError.
spec: https://wicg.github.io/shape-detection-api/#image-sources-for-detection
Change-Id: I0522d0340d3cb0291df6be65dfc1ab99037b30f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666766
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#671578}
--
wpt-commits: ec977dea05df9ce55c03a842ffe05a1bf6ee399a
wpt-pr: 17392
Automatic update from web-platform-tests
[Native File System] Create FileSystemFileWriterImpl to mirror the renderer side
This is the initial cl of the refactor of NativeFileSystemFileHandleImpl to
mirror the split on the renderer side with the handle and the writer as
two separate entities.
It is the initial implementation for FileSystemFileWriterImpl. It includes
only one no-op method for now: close().
This sets the stage for atomic writes as close() will be the explicit
termination of a write, which allows us to do the atomic operation.
Bug: 968550
Change-Id: I0af81efa46789f18c4a8b0bca3ab89c5703b798c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662709
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671539}
--
wpt-commits: 3cb5a99e5521936fb8819de8aaba806050b84184
wpt-pr: 17364
Automatic update from web-platform-tests
Add mandatory capabilities parameter in the body for the webdriver new session command (#17212)
--
wpt-commits: 693543f7296ef79cc4ec534422c5a0bb433992dd
wpt-pr: 17212
Automatic update from web-platform-tests
[css-flexbox] Clamp the cross-size by the min/max size
...when computing the main-axis size of a flex item.
As per this change:
https://drafts.csswg.org/css-flexbox/#change-2018-used-cross-sizeR=dgrogan@chromium.org, eae@chromium.org
Bug: 972576
Change-Id: I11a1ac14e2e0e44e39fcd45d4568874da2dcfce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672014
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671485}
--
wpt-commits: cc0f6ffd9998bdc180d3c70354656f438d99f701
wpt-pr: 17434
Automatic update from web-platform-tests
Don't skip fragment clip if there are other clips for composited layers
Composited layer under multicol is still not fully correctly
supported. Currently we don't allow fragmentation of composited layers,
and skip fragment clip for them. However, if there are other clips below
the fragment clip, we should not skip fragment clip to ensure the other
clips are correctly applied. This is still not fully correct (see the
comment in the code for details), but the result is less broken in many
cases. Hopefully we'll fully fix the issue in
CompositeAfterPaint+LayoutNG-box-fragments.
Bug: 976187
Change-Id: Ica9acc71f0d1204d6380f1bcac3e2159631d63e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670413
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671480}
--
wpt-commits: 1c33536fe6e7d2a6a0323bdb849a5a80c33513a6
wpt-pr: 17429
Automatic update from web-platform-tests
[LayoutNG] Fix |ComputeMinMaxSize| not to clear |NeedsLayout|
This patch fixes |ComputeMinMaxSize| not to clear |NeedsLayout|
when all of following conditions are met:
1. Needs |MinMaxSize|
2. Is an orthogonal flow root.
3. Is legacy layout.
4. Change is applied that dirties the layout.
In this case, |NGBlockNode::ComputeMinMaxSize()| calls
|Layout()|, which goes to |RunLegacyLayout()|, which calls
|LayoutObject::LayoutIfNeeded()|. However, its constraint
space is intermediate that it does not update
|CachedLayoutResult|.
Then when laying it out, because |NeedsLayout()| is cleared,
existing out-of-date |CachedLayoutResult| is used.
This patch fixes:
1. Not to pre-layout orthogonal roots if it has
|CachedLayoutResult|.
2. Set |NeedsLayout()| if |RunLegacyLayout()| clears it, but
|CachedLayoutResult| was not updated.
Bug: 976859
Change-Id: Ic2d979a3c4f9479040bfd0e54cf4283b60ed52b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670146
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671460}
--
wpt-commits: 47b08c15495e05fa73e243736742851109198af1
wpt-pr: 17428
Automatic update from web-platform-tests
Remove unused BroadcastChannel in portal-activate-data.html.
It was probably left behind during recent WPT refactoring.
Change-Id: Ia993654248303c56559cb8cf755d11944213048a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671947
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671414}
--
wpt-commits: 674c9f5b6c076746d8823ee215181b9b471cd1a4
wpt-pr: 17431
Automatic update from web-platform-tests
[docs] Deprecate some requirement flags (#15964)
Reference: https://github.com/web-platform-tests/wpt/issues/5293
Also update the example to use non-deprecated flags.
--
wpt-commits: a56df4a639b5e1c278037d53ce461f66e06c902a
wpt-pr: 15964
Automatic update from web-platform-tests
[docs] Reorganize information on Ahem
WPT maintains a document dedicated to configuring systems to run the
tests. Relocate the instructions on installing Ahem to this document,
and reference them from their original location (an explanation of how
to use the font to author tests).
--
wpt-commits: 49e92561e87e4e1dd7a798dc74f69378b4526878
wpt-pr: 16339
Automatic update from web-platform-tests
[docs] Enable Sphinx's "nit-picky" mode
The `-n` flag to Sphinx is documented as "warn about all missing
references." Enable that flag and correct the missing references which
were previously tolerated.
--
[docs] Incorporate wptserve documentation
While Sphinx is capable of including the contents of files which exist
outside of the documentation root (via the `include` directive), it
interprets such text in the context of the including file. That makes
the mechanism inappropriate for including documentation that references
still other files using relative paths.
To address this, create a symbolic link to the `wptserve` source
directory. Fix or ignore infractions in the newly-incorporated files.
--
wpt-commits: 929bb86fff798cac3b94af7a2549480fac40a84e, a54dccec285341423d3e956bcbdbaac5b0e45ab8
wpt-pr: 17418
Automatic update from web-platform-tests
Worker: Deflake worker-interception.https.html
This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/1657855/10#message-de50523b6c1fc520cf1a7c2edf3033d4e2139103
worker-interception.https.html is flaky on Firefox. It looks like service worker
unregistration is unexpectedly canceled. Each test case doesn't explicitly
terminate (shared) workers, so they may prolong the lifetime of the registration
being unregistered, and the next test case may unexpectedly reuse it. This
results in failures in setup_service_worker().
To fix it, this CL separates service worker scope per test. Note that explicit
worker termination should not work in this case because shared workers are
out-of-process workers and it's not possible to terminate them
deterministically.
Bug: n/a
Change-Id: I16c32d6477c8b1a4d1a246b33a8e21747b4fec66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663459
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670831}
--
wpt-commits: 8ad6f6a2ebb5b861f17c1b8084b264c71e6b965b
wpt-pr: 17395
Automatic update from web-platform-tests
Optimize cubic bezier solver.
Newton's method requires an accurate guess to get good convergence.
This patch introduces a linear interpolation of a crude spline as a
starting point for the iterative solver. Previously the starting point
t = x was used. The patch also introduces a tighter tolerance for
Newton's method than the fallback, and is justified by Newton's method
having quadratic convergence characteristics. Speed testing indicates
that the solver is roughly 50% faster, since the number of iterations
is typically less even at the higher accuracy requirement.
Bug: 827560
Change-Id: I89e3cc9061823269aabb16697e2d167751aa52b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643973
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670995}
--
wpt-commits: dbe15f82985f2e2a978255665f388c7dcdd425b1
wpt-pr: 17349
Automatic update from web-platform-tests
Expect actionsWithKeyPressed.html to fail on Mac
Related to issue #17296. This PR does not fix the underlying issue, but
only unblocks the infrastructure tests on macOS.
--
Expect elementPosition.html to timeout
For Chrome on macOS
--
wpt-commits: 2e5b9fb08c42966831690bd01b9b6410efc479fa, fe2232a673785d77c1b23509c5ae52c325378918
wpt-pr: 17415
Automatic update from web-platform-tests
[Navigation Timing] Replace TAO restrictions with same-origin ones
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.
Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.
This CL aligns the implementation with the new language.
Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147
[1] https://github.com/w3c/navigation-timing/pull/108
Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}
--
wpt-commits: 94f51553f1413cf2118b9bf89762bfad16d8a18a
wpt-pr: 17412
Automatic update from web-platform-tests
Service worker: self.serviceWorker (#17285)
* Tests for self.serviceWorker
* Don't need `self`
* Add read only test
* Adding comments & test the object doesn't change
* Swap order
--
wpt-commits: 3725067ef0328c998be2ba93dbaeb0579586fccd
wpt-pr: 17285
Automatic update from web-platform-tests
[webnfc] Remove incorrect tests (#17425)
Per spec https://heycam.github.io/webidl/#es-DOMString,
non string value will be converted to string via `toString()`
method, therefore there's no `TypeError` to be thrown.
--
wpt-commits: 3a00a57af5f449a72f0e1b89dae6f1bd15ad8fcd
wpt-pr: 17425
Automatic update from web-platform-tests
Worker: Remove duplicate service worker interception tests for shared workers
worker-interception.https.html has more test coverage, and is well-formatted.
Bug: n/a
Change-Id: I29640ffa781c1b90b1faa56eab4f771c1a3c0a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669137
Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671183}
--
wpt-commits: 982f12dc86098e5b32ffec455520a5eb114c27af
wpt-pr: 17414
Automatic update from web-platform-tests
[docs] Increase strictness of build process (#17401)
Use the `-W` flag to interpret Sphinx warnings as errors, causing the
build to fail in the presence of either. This makes various authoring
mistakes more visible. Perhaps most importantly: it highlights instances
of "orphaned" content.
Fix all details which were previously reported as warnings and thus
permitted.
--
wpt-commits: 9c6304b71c5ee090ebc1eef02ab32b70444d9704
wpt-pr: 17401
Automatic update from web-platform-tests
Allow var() references in -internal-visited-* properties.
Previously, -internal-visited-* properties didn't get any parsing behavior,
because they were assumed to be used during style application only. In
other words, it was assumed that the parsing would happen _before_ e.g.
color would expand to -internal-visited-color.
This is (of course) not true if the value has a var() reference, since
the actual parsing then happens computed-value time.
To fix this, this CL gives all -internal-visited-* properties parsing
behavior.
The "pending substitution value" adds complexity here, since the value
itself contains the shorthand it came from. This means that if e.g. the
border shorthand is parsed with a value that contains a var() reference,
the corresponding -internal-border-*-color property will point to the
same pending substitution value, that contains the "border" shorthand.
When resolving that pending substitution value computed-value time,
we expand the shorthand into its longhands, which of course are unaware
of the -internal-visited-* context. To fix this, this CL adds a way to
get the unvisited counterpart from a visited property, and uses the
unvisited CSSPropertyID as they key for the pending substitution cache.
Bug: 974665, 976913
Change-Id: I1a168bfe188eaccad7feac6c065f8e447ee56dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669290
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670896}
--
wpt-commits: be93a1b93e08be1bd161208aaa6ab662c1c2d1c1
wpt-pr: 17411
Automatic update from web-platform-tests
WebSocket: stop removing an iframe in onerror from crashing
There was an issue that if the iframe owning a WebSocket was
synchronously removed in the onerror handler then it would crash the
render process. This was caused by unconditionally calling Close()
without checking the current state.
Fix it.
Also add a web platform test.
Bug: 974667
Change-Id: Iaeb8f96cf600a2c052f06b5b59f4444b02615e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663681
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670061}
--
Set a long timeout
--
wpt-commits: 433e1f06259a79c6cb8bf695bc03ffdfdfe4e7e7, 28ad65497bccb301707e341a9d36f9d144e2793e
wpt-pr: 17380
Automatic update from web-platform-tests
Implement basic LargestContentfulPaint API
This CL adds a basic implementation of the LargestContentfulPaint API.
The implementation is done behind a flag, and is missing attribution
information and special handling for images.
Explainer: https://github.com/WICG/LargestContentfulPaint
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WVqgYtyaGJk
Bug: 965505
Change-Id: Ic29604349dc60de2808bdef3df4684e81e1845d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646634
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670911}
--
wpt-commits: 93ba864d402d941a2670681d535e33723e5296c0
wpt-pr: 17214
Automatic update from web-platform-tests
Enable PauseExecutionContextOnBackgroundFreeze
Thie change enables (experimentally) pausing the execution context
when a document is frozen.
The WPT tests written required that promise resolution continued after
the page was frozen. This isn't the case when
PauseExecutionContextOnBackgroundFreeze is enabled so rewrite the tests
to poll for the correct state.
BUG=957589
Change-Id: If104235fd7281d88b5d86a3f0b89337828e7f4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662633
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670883}
--
wpt-commits: 81c649c98aa73ac14416491271ed001ffe9e4bbe
wpt-pr: 17363
Automatic update from web-platform-tests
[Azure] Fix logging params
This makes the logging behaviour consistent across all jobs on Azure:
info level tbpl logging to stdout, which is also consistent with
Taskcluster setup.
Notably, the previous configuration for "all tests: Edge" accidentally
specified --log-tbpl twice, causing duplicate log outputs, which is
fixed in this commit.
--
Disable version check of EdgeDriver
--
wpt-commits: 7dd31d2b2f9ebca522b50af958c18208d08683ae, 5303a4e841969e0b5991c45c276027a671e3ba20
wpt-pr: 17404
Automatic update from web-platform-tests
Refactor SRI script tests to prepare for Preload + SRI
This CL refactors the SRI script tests and what script resources they
consume to remove duplication, and factor out + generalize some of the
helpers, such as the script URL prefixes.
Before this CL, there were multiple script files whose contents were
irrelevant to the tests. The scripts would be served differently due
to `.headers` files. This CL consolidates all of the script resources
into a single `script.js` that the test runner can use while demanding
specific headers for tests. This file and factored-out URL prefixes in
`sri-test-helpers.sub.js` will be used by Preload + SRI tests, so this
CL makes writing those tests cleaner.
Bug: 677022
Change-Id: Ie6cc312f9d81de4d5f75925810b7ce88a61910a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667326
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670809}
--
wpt-commits: 1dd0bc9ffd9b1433cb2aa1e20f972fd477c65ad4
wpt-pr: 17394
Automatic update from web-platform-tests
location.hash = '' should always result in an empty fragment, not no-fragment
So far in |setHash|, old fragment identifier and new fragment identifier are
compared ignoring nullity.
When fragment has never been set, |old_fragment_identifier| is null.
In this situation, |location.hash = ''| is called,
|new_fragment_identifier| is not null empty value.
|EqualIgnoringNullity| treats these as the same, |setHash| does nothing.
So, this patch compare old and new fragment by == operator
not |EqualIgnoringNullity|.
Bug: 615300
Change-Id: Id509bc5066eeee83236ecb4ee816ecb90540a260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647298
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670795}
--
wpt-commits: a3e67aed3509dc5255a029f913c5785be4e67aed
wpt-pr: 17293
Automatic update from web-platform-tests
[LayoutNG] Fix inserting exclusion crash.
When placing a new area into the closed area list there is almost
always an area at LayoutUnit::Min().
However if there was a float placed at LayoutUnit::Min() it is possible
to get into a state where this isn't the case.
Bug: 972904
Change-Id: I1c787ea8e4f5d87ae97023efd9cdb994c2b065ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664930
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670726}
--
wpt-commits: 9a183439c7fd1a22298c49a86be1e293d460ea75
wpt-pr: 17391
Automatic update from web-platform-tests
SMS API: Clean up SMS API mojom interface
This CL cleans up the SMS API mojom interface based on the suggestions
on the following issue link. No behavioral changes for the SMS API
mojom interface.
Bug: 968584
Change-Id: Iba707dd9a94f75cb28b7409f930e75b0f6f2f792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654272
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670694}
--
wpt-commits: 43ef8451989ca9be29d55ca88cb80a1ab90030a1
wpt-pr: 17304
Automatic update from web-platform-tests
[LayoutNG] Fix DCHECK(NeedsLayout) for inline oof fixed container.
NGOutOfFlowLayoutDescendant.inline_container was not being set
correctly for an Element if:
- There is an OOF containing block between Element and
its Container(). This can only happens if Element is
position:fixed.
This caused Element not to be laid out after it got dirty (but
its containing block did not).
The fix is to set inline_container when Element's
NGOutOfFlowDesecendantCandidate gets propagated up the OOF
containing block chain.
For a while, I was afraid that this fundamentally broke
the concept of inline_container. I could not come up
with a counterexample that broke this fix.
Bug: 974760
Change-Id: Id16a0057f0aefe183c30c53244dd5c46108f093c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666809
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670634}
--
wpt-commits: b6343fc17a3035a0c2170f44fb63df2356aa2cb9
wpt-pr: 17390
Automatic update from web-platform-tests
[css-flexbox] Also skip non-flexbox items with percentages
The same percentage issue happens with regular blocks. See the
linked bug and associated testcase.
R=dgrogan@chromium.org, eae@chromium.org
Bug: 973924
Change-Id: I588353f0dcce4a446c08a8aa0f186c9ec2ee8949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667684
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670606}
--
wpt-commits: 6515e798b30a5d3053bec1faae2f8c366fdbcba9
wpt-pr: 17396
Automatic update from web-platform-tests
[css-ui] Test serialization: `-webkit-appearance` (#17221)
* [css-ui] Test serialization: `-webkit-appearance`
* fixup! [css-ui] Test serialization: `-webkit-appearance`
Change API used to set style in order to actually test the internals
referenced by the test title.
* fixup! [css-ui] Test serialization: `-webkit-appearance`
Introduce tests for property reference
* fixup! [css-ui] Test serialization: `-webkit-appearance`
Remove duplicate assertion
* fixup! [css-ui] Test serialization: `-webkit-appearance`
Comprehensive tests for property references have been added since these
tests were written. Remove the excess assertions in order to improve the
focus of these tests.
* fixup! [css-ui] Test serialization: `-webkit-appearance`
Add equivalent tests for unprefixed `appearance` property
* fixup! [css-ui] Test serialization: `-webkit-appearance`
--
wpt-commits: 79787d6d6eff255fbe6efdbe386e92363d2b6303
wpt-pr: 17221
Automatic update from web-platform-tests
Adding a test for backdrop filter plus mask
This tests a backdrop filter element that also contains a (non-border
rect) mask or clip. It currently fails.
Bug: 974857
Change-Id: Ied65cc96deb2d02634b62d8743bff02588c94411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662499
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670587}
--
wpt-commits: 1ace0eaddd369c7063e0a34ac91a2f361020b5bf
wpt-pr: 17366
Automatic update from web-platform-tests
Return show promise instead of the resolved value of show promise (#17389)
--
wpt-commits: e0cfe65d6e5338f501dfe0494e6ce2cc666ee978
wpt-pr: 17389
Automatic update from web-platform-tests
Worker: Add service worker interception tests for shared workers
One test case for shared workers is failing because it's not allowed to create a
dedicated worker on a shared worker.
Bug: n/a
Change-Id: I4f7139adacdccb0f16d7afedd7eaab065c4bea2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657855
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669615}
--
wpt-commits: 3671eb9b321c60898a79c76d20a97807925ebe1e
wpt-pr: 17333
Automatic update from web-platform-tests
Initial implementation of std-toast
Intent to Implement: https://groups.google.com/a/chromium.org/forum/?utm_source=digest&utm_medium=email#!topic/blink-dev/Gl7FIKM5IFw
BUG=972945
Follow-ups will align with std-switch in elements and de-duplicate the .eslintrc.js files between toast and kv-storage.
Change-Id: Ib5837ccf8c9ea03fd2f1f2bd581e443a2936f693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635867
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670383}
--
wpt-commits: 17de974a80b0d9a6ff48dc24796441057afad5a0
wpt-pr: 17146
Automatic update from web-platform-tests
Removing initial Element Timing implicit registration heuristic.
The Element Timing specification originally included a provision for reporting
timings of elements that were automatically detected as 'important'. This would
allow useful information from the Element Timing API to be reported through the
Performance Timeline even if site authors neglected to mark their important
elements with the 'elementtiming' attribute.
The automatic detection of 'important' elements is, necessarily, a heuristic
and, until consensus for the correct heuristic had been reached, we were
treating any image that occupied greater than %15 of the viewport as
'automatically important'. As the Element Timing specification is still being
refined, the exact threshold and heuristic is still being investigated. Until
agreement on an appropriate heuristic is reached, implicit registration will be
disabled.
This CL removes our %15 threshold and disables implicit registration. There was
also WPT coverage to test that all browsers would respect the %15 threshold so
that test is being removed too.
Change-Id: I14847533402f5a68bb3de63a8f9acbd004c5a8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643379
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670319}
--
wpt-commits: f76b2e5e2b1dd5d73cf2351c57a303d4a67eb729
wpt-pr: 17176
Automatic update from web-platform-tests
[html] Add test for history traversal (#16478)
* [html] Add test for history traversal
* fixup! [html] Add test for history traversal
* fixup! [html] Add test for history traversal
--
wpt-commits: 7d8eefc2e4793df438d1f120737078c0bb67979e
wpt-pr: 16478
Automatic update from web-platform-tests
[IndexedDB] Promote test isolation (#16436)
* [IndexedDB] Promote test isolation
Use distinct database names for each test so that failure to clean up
from one test does not influence the result of another.
* fixup! [IndexedDB] Promote test isolation
--
wpt-commits: 23776c16a2db7b8df7374ec7c1e97a0cec003280
wpt-pr: 16436
Automatic update from web-platform-tests
[cookie-store] Promote stability in test results (#16415)
* [cookie-store] Promote stability in test results
Allow service worker activation to proceed in the absence of the API
under test. This prevents the workers in failing implementations from
entering the "redundant" state, which can interfere with the harness's
ability to detect all tests.
* fixup! [cookie-store] Promote stability in test results
* fixup! [cookie-store] Promote stability in test results
--
wpt-commits: 199b5fa5c003e348490000bc8147e0f2bb3fbaf0
wpt-pr: 16415
Automatic update from web-platform-tests
[csp] Wait for all tests to be defined (#15631)
Configure the test harness to delay completion until all
asynchronously-defined tests are available.
--
wpt-commits: 159c7c2f98576d2288c12aee86264356cbaa1be1
wpt-pr: 15631
Automatic update from web-platform-tests
Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects.
Currently various Sec-CH- and Sec-Fetch- request headers are added through the codebase and correctly check if the request target url is trustworthy. If the destination is not trustworthy then the headers are not added. However in the event a request redirects from a trustworthy to non-trustworthy destination, such as https => http, there may be pre-existing headers present. Since these headers would not have been added to the non-trustworthy request we need to remove these extra headers from the request.
This change adds a helper call to the UrlLoader class in the network service to remove any request headers prefixed with "sec-ch-" or "sec-fetch-" when a downgrade redirect is detected. In addition to this unit test cases for the helper and end to end WPT cases have been added to validate the scenario and prevent future regressions.
Bug: 964053
Change-Id: I109c3ec1b3a05f6341c3c4adbd1a8da1274fd0d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647354
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667415}
--
wpt-commits: 376e2a8250c3824b794ec518ab320d8a82cedf95
wpt-pr: 17200
Automatic update from web-platform-tests
[LayoutNG] Skip "replaced % resolution" quirk on ortho-roots.
This is about an undocumented quirk. I raised
https://github.com/whatwg/quirks/issues/46 for it.
LayoutNG currently cannot handle this situation, because we don't store
the inline-size to use in replaced percentage resolution (only the
block-size). However, I find it hard to believe that there'd be any
specific expectations to how this is supposed to work if a table cell
has a definite block-size, and a descendant establishes an orthogonal
writing-mode root. So just ignore it and use regular percentage size
resolution in these cases.
Bug: 967069
Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670126}
--
wpt-commits: 361912dbe4ef692ea256b6f5bc0d74c0668ccdf5
wpt-pr: 17381
Automatic update from web-platform-tests
Integrating ScrollTimeline with main thread WebAnimations.
Changes made:
- ScrollTimeline interface is enabled under its own ScrollTimeline flag.
- Animation class now has member variable timeline_ of type AnimationTimeline instead of
DocumentTimeline.
- Document and scroll linked animations are now attached to their document global document
timeline. TODO: reconsider this approach.
Bug: 916117
Change-Id: I5f0c3d22fdb0c9b9763f5a2400c2e3d5af32e896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597286
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670086}
--
wpt-commits: 31373e2726073d95b05e09ed112efac950b562b5
wpt-pr: 16755
Automatic update from web-platform-tests
CSP handling of 'self' inside sandbox iframe was incorrect.
The correct handling of 'self' depended on the timing of when the
ExecutionContext's sandbox flags were applied. If a CSP policy for 'self'
was applied after the origin was derived to be opaque it would fail.
BUG=973991
Change-Id: Ie6f384b02aa3dea3ce48c3052f06b7bd8fb2d3ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658764
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670074}
--
wpt-commits: b50766de4c9059ed41559315e0f12d602c8c9d59
wpt-pr: 17326
Automatic update from web-platform-tests
[Azure Pipelines] Use more verbose TBPL logging for full runs (#17379)
This is to help diagnose problems if they occur, such as this failure
to run all of the tests:
https://github.com/web-platform-tests/wpt/pull/17219#issuecomment-501272482
--
wpt-commits: 3857b199e7ee7867550b268df05664e2ef055600
wpt-pr: 17379
Automatic update from web-platform-tests
Add CEReactions and CustomElementCallbacks to toggleAttribute
Previously the IDL definition for toggleAttribute doesn't have
those modifiers, so they behave differently than setAttribute when
called on custom elements (it won't fire attributeChangedCallback, etc)
Bug: 976177
Change-Id: I7d8107db8d07a2e2ec856305c56a178339c5e05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663881
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670060}
--
wpt-commits: f6881fbb28940a254944e62b994b282b176bb030
wpt-pr: 17377
Automatic update from web-platform-tests
[LayoutNG] Fix NeedsLayout failure when CR/FF is dirty
This patch fixes |ClearNeedsLayout| for CR (U+000D) and FF
(U+000C). These were overlooked when |ClearNeedsLayout| was
moved from |NGInlineItemsBuilder| to |NGLineBreaker| and
|NGInlineLayoutAlgorithm|.
Bug: 971811
Change-Id: Ie3d9d3d11e35a7ed3458bb8b96d2fa68bf9c37a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663478
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670010}
--
wpt-commits: 95372aa3ca35565b56fc6d9d5e0653a4fff8a6e8
wpt-pr: 17373
Automatic update from web-platform-tests
[LayoutNG] Fix DCHECK failure for table cell width quirk
This patch fixes a DCHECK failure when table cell width
calculation quirk logic[1] found an out-of-flow image.
The logic was in |BreakLine| because it may need to change
|can_break_after| of the last item. By calling
|HandleAtomicInline| in trailing item phase, the logic can
be moved to |HandleAtomicInline|.
With this change, |HandleAtomicInline| may choose to break
before the item, similar to |HandleText|.
[1] https://quirks.spec.whatwg.org/#the-table-cell-width-calculation-quirk
Bug: 968317
Change-Id: Ib4a71ca62107d2601449ba589bb2771b378ab38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660296
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669968}
--
wpt-commits: 2b29767a9f53e3a7a142b6c4cf72407dfe88506d
wpt-pr: 17357
Automatic update from web-platform-tests
[LayoutNG] Fix "body fills html" quirks.
We had a few issues related to quirky body elements. We were
stretching the body when it was OOF-positioned, float, or an atomic
inline when we weren't supposed to.
Bug: 967215
Change-Id: I640b1a2f6c2ab30d071e04c245a34dd1e30b19fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662839
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669954}
--
wpt-commits: 90c18764adad351a28069adbfade18d6dd4949e7
wpt-pr: 17367
Automatic update from web-platform-tests
[docs] Build (but do not deploy) for pull requests
Although the documentation website should not be rebuilt in response to
pull requests, refusing to simply build the site may potentially hide
errors during the review process.
Update the documentation generation script to build the site as part of
the pull request, provided a relevant file has been modified. With this
applied, if the patch under review regresses the script, the contributor
and reviewers are immediately notified.
--
wpt-commits: 4be1e7e7b78712303076819ef8a6b3f055ebbb3c
wpt-pr: 17365
Automatic update from web-platform-tests
Link to testdriver docs from the main docs site (#17362)
* Link to testdriver docs from the main docs site
`testdriver.md` and `testdriver-tutorial.md` aren't correctly indexed anywhere
because of https://github.com/bocoup/wpt-docs/issues/1 .
This PR manually adds them to the ToC in "Writing Tests" as per user requests.
* fixup! sorted
--
wpt-commits: da3b6e4dfafe250800c490cee949b2b405364ecd
wpt-pr: 17362
Automatic update from web-platform-tests
[sms] Move SMS Receiver API to Navigator
This change moves the SMSReceiver API under navigator.
Details on its usage can be found here[1]. Implementation
of the AbortController will come in a following CL.
[1] https://github.com/samuelgoto/sms-receiver#sms-receiver-api-1
Bug: 960546
Change-Id: Iba9882db05e0d153d6f37e1481d6237738542949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626018
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669779}
--
wpt-commits: 94bff4ec536738245d29502e40516a6509db5c74
wpt-pr: 17049
Automatic update from web-platform-tests
[ElementTiming] Add intersectionRect for text entries
This CL adds support for intersectionRect for PerformanceElementTiming
entries referring to text elements. The rect is different from the one
used by Largest Contentful Paint because it does not get projected to
the top-level frame, as that is not acceptable from security/privacy
perspective. However the rect is only computed when needed.
Bug: 942033, 969174
Change-Id: I1f09288b17a73c84daf8cc55996b78e44739a042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658630
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669777}
--
wpt-commits: ca62107b234fb0aa8d6044e47c915be3fe42981f
wpt-pr: 17328
Automatic update from web-platform-tests
[LayoutNG] Fix negative margins on inline boxes
This patch fixes computing size of inline boxes that have
negative inline margins.
It looks like we didn't have enough test coverage when
`NGFragmentGeometry` was introduced.
Bug: 971622
Change-Id: Icd0f5300ef76a873ec25b8d96756884da954d184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662249
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669699}
--
wpt-commits: c81dc02d6b1b4a5a5925d6cb27f16af7b897cb59
wpt-pr: 17356
Automatic update from web-platform-tests
[LayoutNG] Fixed crash issue list-style-type change
The crash reason is that the NGInlineItem is obsolete after change
list-style-type. This patch added ListStyleTypeChanged to make sure
marker is fully updated and re_CollectInlines for marker.
Bug: 966750
Change-Id: I8c51bc90d31344fb36627fe29608b2b576d85228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660399
Commit-Queue: cathie chen <cathiechen@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669613}
--
wpt-commits: dbaf4c77b6bf7ffc8d030a40f98045e8832ba4de
wpt-pr: 17352
Automatic update from web-platform-tests
Revert "Ignore lint failures until we import a rev with them fixed" (#17289)
This reverts https://github.com/web-platform-tests/wpt/pull/13396.
These exact lines are also in the "Duplicate filename where there's no
actual merging" section of the file.
The change came from https://hg.mozilla.org/mozilla-central/rev/f23487d9ab99d486fe3ab7f261e4d4e0bf1172ae
where those lines were present, although they were present in WPT when
that change was upstreamed.
--
wpt-commits: 4a075835b37e1cdd90094e4766d4c9842fe64480
wpt-pr: 17289
Automatic update from web-platform-tests
Reland tests from "Change ICE connection state on transceiver changes"
This reverts the rest of commit 2229f484784131f7c655c650b389cfd78fe3e739.
Reason for revert: Fixed the reason the test was flaky.
Original change's description:
> Revert "Change ICE connection state on transceiver changes"
>
> This reverts commit 0882bebe06b38aa5d4e155a5cebc11e7af08abd2.
>
> Reason for revert: Causing flaky failures of
> external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
> on Linux Tests and WebKit Linux Trusty Leak
>
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892
>
> Original change's description:
> > Change ICE connection state on transceiver changes
> >
> > This ensures that if the PC iceConnectionState should change
> > because unused transports are discarded, the state is updated.
> >
> > Bug: chromium:966798
> >
> > Change-Id: I09d945f5e70eec813f33c3131fbe889825613652
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#664206}
>
> TBR=hta@chromium.org,hbos@chromium.org
>
> Change-Id: I2cbae9f1327e7aacb7022d2a823ce1e954c91b62
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:966798
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635208
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664388}
Bug: chromium:966798
Change-Id: I2e9887bc62942393a2d39042da9bfc85bbd98c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636049
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668750}
--
wpt-commits: 8a474834dc86e8713b1f7e966d6d5aa8fd69c9a6
wpt-pr: 17082
Automatic update from web-platform-tests
Add tests for movablelimits (#17354)
Tests taken from Webkit.
--
wpt-commits: 79cf5fb8d18ef01ba174de2ebf841f782f342095
wpt-pr: 17354
Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)
Because the setup function is allowed to fail, this makes the setup a
bit simpler.
This is to make it easier to add 'hr-time' as a dependency for
https://github.com/web-platform-tests/wpt/pull/17305.
--
wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344
Automatic update from web-platform-tests
Don't round hit test location in HitTestLocation::RectForPoint
HitTestLocation rounds the hit test location to the closest 1x1 rect
for no good reason, causing some confusing hit test results. Hence,
this patch removes such rounding.
Bug: 974314
Change-Id: I48266a7ec8bffbeb746085c5d8835d3f300dd4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661297
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669579}
--
wpt-commits: 5689f6b102fa8055740ff66dfe6b8c3b9a808c08
wpt-pr: 17351
Automatic update from web-platform-tests
[webnfc] Introduce IDLs for NFCErrorEvent and NFCErrorEventInit.
This CL introduces IDLs for NFCErrorEvent and NFCErrorEventInit
interfaces, and updates the baseline of relevant wpt tests.
http://w3c.github.io/web-nfc/#dom-nfcerrorevent
The corresponding spec changes were introduced in
https://github.com/w3c/web-nfc/pull/184
BUG=520391
Change-Id: Ia8af8b49f53be7161b7e7b0f4e45f617c4991473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652968
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669482}
--
wpt-commits: 4100d1d51b885185c50902397f7d203d89efc24c
wpt-pr: 17263
Automatic update from web-platform-tests
[Azure Pipelines] avoid parenthesis in job names
The Azure Pipelines integration with GitHub Checks produces checks on
the form "$pipelineName ($jobName)", leading to check names like
"Azure Pipelines (tools/wptrunner/ unittests (macOS))". Use colons as
separator instead, like the existing "wpt.fyi hook" jobs.
Also change some step names for consistency.
--
wpt-commits: e75855649360298870a40ed78874bd4ab1470c20
wpt-pr: 17265
Automatic update from web-platform-tests
Add more direction tests (#17345)
* Add more direction tests
Put these in a new directory.
* Make direction.html use testharness.js
--
wpt-commits: fdf8ff01960e031fe0381133f5a39e1b8e372454
wpt-pr: 17345
Automatic update from web-platform-tests
[trusted types] Check text node insertions into <script> elements.
insertAdjacentText into <script> elements can be used to bypass
Trusted Types checks. This change fixed that hole by adding TT checks
to related Node API methods, and changing insertAdjacentText to use
the public methods.
See additional discussion on the root issue in
https://github.com/WICG/trusted-types/issues/133
Bug: 739170
Change-Id: Ie26b2aca2d60c7e14a0118c6fd957f32928afabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547746
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669210}
--
wpt-commits: 90a794e8e93a5e22e7cb3b2f8c79d751989fa7b0
wpt-pr: 17230
Automatic update from web-platform-tests
MSE: Let external/wpt/.../mediasource-play have longer timeout
This test normally takes only 1-2 seconds to execute on Chromium Mac
release builders, but can timeout at low frequency (3 times in > 100
builds). Per WPT documentation [1], this change marks the test timeout
as "long". In Blink, this change also removes the flaky timeout test
expectation for this test.
[1]
https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
BUG=971252
TEST=confirmed locally with Blink's web test runner and injected test
delays that this change allows the test to run over 6 seconds without
failing with timeout.
Change-Id: Icf60260640f201f3fc3c072c6bef9097bff928df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659132
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669043}
--
wpt-commits: 11147d0843d3282784dfc93a5bdc0882311f52f2
wpt-pr: 17322
Automatic update from web-platform-tests
Fix the case where an element contains both filter and backdrop-filter
Previous to this CL, if an element was styled with both filter and
backdrop-filter, the filter effect was not properly applied to the
filtered backdrop contents, because a separate filter property node
gets created for the filter, and the backdrop-filter effect node
does not contain the filters. With this CL, paint_layer appends
the filters to the backdrop-filters list, so that Viz has access
to those.
Bug: 973907
Change-Id: I255b73433d75e0551d817134fa50d5e0e35b87df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658654
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669006}
--
wpt-commits: 9bb8217b7e6e5a2174522159bebc42fe4e401107
wpt-pr: 17316
Automatic update from web-platform-tests
Disallow symlinks (#17315)
* Lint to ensure there are no symlinks in the tree.
Would be good to disallow whitelisting this one somehow, but that's a
larger change.
* Remove symlink
* Update tools/lint/lint.py
Co-Authored-By: Robert Ma <bob1211@gmail.com>
* Update tools/lint/tests/test_path_lints.py
--
wpt-commits: 8d6992deac82fe032594b6a8cfa2e33723c8812a
wpt-pr: 17315
Automatic update from web-platform-tests
Remove expansion of backdrop-filter input for pixel-moving filters
See [1] for the PR for the spec change. Essentially, with this CL,
the input to the filter will be the bounding box of the element
with backdrop-filter. The bounds will not be expanded for pixel-
moving filters, and will not include extra border for children.
Note that the rebaselined layout tests are all for very small
single-pixel errors, except for backdrop_filter_blur_outsets.png
and backdrop-filter-boundary-expected.png, which change because
of this new behavior.
This needs a (small) spec change, but it will be beneficial in
these four ways:
- It agrees more closely with existing Safari behavior.
- It improves performance, by filtering fewer pixels in the
case of pixel-moving filters.
- Developers have been disappointed with the existing behavior
of bringing in pixels from outside the bounds of the
element, and have requested a way to turn this behavior off.
See the discussion starting at [2].
- It eliminates the problem of crbug.com/972173, where content
outside the renderer viewport can get dragged into the filter.
[1] https://github.com/w3c/fxtf-drafts/pull/342
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=497522#c196
Bug: 972173,497522
Change-Id: I18cc6d08cf9fde263b9e166b5e96ea57a1c41973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650418
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668894}
--
wpt-commits: b90e70c4557b94ca735e6c8b20958c77ef02306e
wpt-pr: 17310
Automatic update from web-platform-tests
Remove relations/css-styling/lengths-2 (#17309)
This tests namedspaces, which were removed from the Core spec:
https://github.com/mathml-refresh/mathml/issues/75
--
wpt-commits: 8b26ee28f1e20c1cfbd9b95ddf040f725f747b52
wpt-pr: 17309
Automatic update from web-platform-tests
[LayoutNG] the real youtube button fix
Previous fix worked by eliminating cacheing of OOF Legacy
positioned elements. It was not the right fix.
https://chromium-review.googlesource.com/c/chromium/src/+/1649086
This fix backs out the original fix, and implements the correct fix:
OOF objects positioned by RunLegacyLayout could end up
with a cached layout result that had an old constraint space.
Fix is to force re-cache with new constraint space.
Bug: 970171
Change-Id: Ia9a7faea929083566f406db371ddcef058f2e4ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652653
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668709}
--
wpt-commits: b8eea2d704ec32a88a3b8b46a2d01e96b3a470b5
wpt-pr: 17303
Automatic update from web-platform-tests
Prevent the error from triggering a page error in Worker-nested-importScripts-error
Fixes#23511
--
wpt-commits: 51f5cebccd000d8a021d6d3810e2fa1a8e2e212d
wpt-pr: 17272
Automatic update from web-platform-tests
[LayoutNG] Fix float + nbsp to create a break opportunity
Floats should create break opportunities, and
|NGLineBreaker::Rewind()| assumes this. However, |nbsp|
after floats suppressed the break opportunity, which caused
NGLineBreaker to loop infinitely under certain conditions.
This patch fixes floats to allow break after them.
Note the new behavior is the same as Gecko.
Bug: 972421
Change-Id: Ie8c1d7927c5c282078a20f90941398149ea702a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653171
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668681}
--
wpt-commits: 0b4f8505547ddc457e89df8b898ad445281fb204
wpt-pr: 17281
Automatic update from web-platform-tests
Prevent fooling PerformanceObserver.supportedEntryTypes (#17242)
* Prevent fooling PerformanceObserver.supportedEntryTypes
* Split between any and window
* Long task is only on Window
* CRLF -> LF
--
wpt-commits: 2d2b6ee35d5f4c82c2f698fdb50c49583e8c7f70
wpt-pr: 17242
Automatic update from web-platform-tests
Allow browsers to block mixed content requests from cross-origin tests. (#17300)
Gecko and Blink by default block mixed content requests.
As a result, header-referrer-strict-origin-when-cross-origin.https.html, header-referrer-strict-origin.https.html,
and beacon/headers/header-referrer-unsafe-url.https.html fail in those two browser engines.
Allow the mixed content beacon requests to be blocked in these tests as allowed by the specification:
https://www.w3.org/TR/mixed-content/#should-block-fetchhttps://www.w3.org/TR/mixed-content/#requirements-user-controls
Also fixed a bug in header-referrer-strict-origin-when-cross-origin.https.html that it was not testing cross-origin.
--
wpt-commits: eb12be23e4b86154ea3822fa8d048f4cce43ab55
wpt-pr: 17300
This mechanical transform lays the foundation for generalizing the
underlying test runner.
Differential Revision: https://phabricator.services.mozilla.com/D37132
--HG--
extra : moz-landing-system : lando
This is the equivalent of .pth in virtualenv declarations. It sets up
a .egg file with a `sys.path` addition, as far as I can tell.
Differential Revision: https://phabricator.services.mozilla.com/D37131
--HG--
extra : moz-landing-system : lando
This mechanical transform lays the foundation for generalizing the
underlying test runner.
Differential Revision: https://phabricator.services.mozilla.com/D37132
--HG--
extra : moz-landing-system : lando
This is the equivalent of .pth in virtualenv declarations. It sets up
a .egg file with a `sys.path` addition, as far as I can tell.
Differential Revision: https://phabricator.services.mozilla.com/D37131
--HG--
extra : moz-landing-system : lando
Bug 1547135 added functionality to configure specific Android devices
for performance tests. That code landed as part of device setup in
`testing/raptor/raptor.py` but there is nothing Raptor-specific
(indeed, nothing harness-specific) about this configuration.
Rather than lift it to `mozdevice`, this commit moves it into a
`performance_tuning` module. That's enough to slim down `raptor.py`.
Differential Revision: https://phabricator.services.mozilla.com/D37128
--HG--
extra : moz-landing-system : lando
Browsers who already have text-decoration-skip-ink implemented will currently
fail [or spuriously pass] these tests because the feature is on by default and
the Ahem font is "ink-heavy", causing underlines and overlines to not show up
at all. The added text-decoration-skip-ink: none; line will ensure that an
underline or overline will be rendered whether or not skip-ink has been
implemented.
Differential Revision: https://phabricator.services.mozilla.com/D38949
--HG--
extra : moz-landing-system : lando
Add the `--no-install` option to reduce the time it takes to run
mochitests again on Android when the app does not need to be
re-installed.
Differential Revision: https://phabricator.services.mozilla.com/D38409
--HG--
extra : moz-landing-system : lando
This pref defaults to true, but geckoview builds set it to false. Several tests assume
this pref is set; some android xpcshell tests currently fail when run against the geckoview apk
for this reason. Setting the pref in the test profile means that geckoview tests will run
with a different pref value than geckoview would normally use, but aligns the geckoview
test environment with firefox. (An alternative would be to skip geckoview tests that rely
on the pref.)
Differential Revision: https://phabricator.services.mozilla.com/D38585
--HG--
extra : moz-landing-system : lando
Handle the exception ADBProcessError raised by
thermal_zone0 = self.device.shell_output('cat sys/class/thermal/thermal_zone0/temp')
on the emulator
Differential Revision: https://phabricator.services.mozilla.com/D38859
--HG--
extra : moz-landing-system : lando
This patch fixes a couple of picture caching issues that could
cause more invalidations than required. Specifically:
* Ensure the viewport rect is included in child surfaces, so
that redundant clips are filtered out correctly.
* Use epsilon comparisons where appropriate for tile descriptor
comparisons, to avoid invalidations due to float inaccuracies.
Differential Revision: https://phabricator.services.mozilla.com/D38455
--HG--
extra : moz-landing-system : lando
Added the crash method for RaptorLogger class,
which will call structuredlog.py crash method.
Differential Revision: https://phabricator.services.mozilla.com/D38055
--HG--
extra : moz-landing-system : lando
This makes the underscore sort after letters, which works around tacit
assumption that such custom headers don't sort to the beginning of the
string.
Differential Revision: https://phabricator.services.mozilla.com/D31786
--HG--
extra : moz-landing-system : lando
In order not to miss the second cue, we extend the duration of both the second and third cue to 1 second. And adjust the third cue's start time to keep them non-overlapping.
Differential Revision: https://phabricator.services.mozilla.com/D38529
--HG--
extra : moz-landing-system : lando
This patch adds an additional data output to android power tests. This data is the power usage of the test calculated as a percentage increase relative to the OS baseline. test_power.py needed to be changed to accommodate these changes as well.
Differential Revision: https://phabricator.services.mozilla.com/D37462
--HG--
extra : moz-landing-system : lando
print_exc() gives us information about the location of the failure and also
ensures that the exception name is logged, which android-em task retries rely on.
This also makes cppunit exception handling more consistent with other harnesses
(mochitest, gtest, ...).
Differential Revision: https://phabricator.services.mozilla.com/D38666
--HG--
extra : moz-landing-system : lando
Delete `return false` at the end of the if-statement block that handling
the multicol subtree reframing, and let it fall though the bottom of
WipeContainingBlock() where there is a complete logic for ib-split
reframing.
Differential Revision: https://phabricator.services.mozilla.com/D38548
--HG--
extra : moz-landing-system : lando
Adds a new pageload test that captures the "pagerendered" event from
PDF.js.
Differential Revision: https://phabricator.services.mozilla.com/D37935
--HG--
extra : moz-landing-system : lando
Changes:
- change how the modules are imported with the `absolute_import` changes
- satisfy python2 linter
Differential Revision: https://phabricator.services.mozilla.com/D37525
--HG--
extra : moz-landing-system : lando
https://drafts.csswg.org/css-values-4/#calc-serialize:
> Sort the terms in the following order:
> The number, if present
> The percentage, if present
> The dimensions, ordered by their units ASCII case-insensitive alphabetically
> Comparison, trigonometric and exponential functions, in the order they appeared in the original expression.
So em goes before px. I filed https://github.com/w3c/csswg-drafts/issues/4129 on
the second part of that algorithm not matching any browser.
These are tests that are marked as only failing in Firefox because we're the
only following the spec. #funtimes
Differential Revision: https://phabricator.services.mozilla.com/D38593
--HG--
extra : moz-landing-system : lando
Currently, the `expected` field in the test metadata accepts only one status. This patch adds
the ability to include known intermittent statuses in this metadata.
The existing metadata format is:
```
[test]
[subtest]
expected: PASS
```
This new format, if there is a known intermittent status to record, will be:
```
[test]
[subtest]
expected: [PASS, FAIL]
```
The first status will always be the "expected" status. The following statuses in the list are
"known intermittent" statuses. The statuses are ordered based on `tree.result_values` counts
during `build_tree()`.
Tests have been added to test_update.py to account for the following circumstances:
- an existing metadata file with only one expecte status needs updating with a known intermittent
- a file with an existing known intermittent needs to be updated with an additional status
- an intermittent status is now the expected status, and the expected status is now intermittent
- a new metadata file needs to be created with a known intermittent status
testrunner.py has been updated to exclude tests with a `known_intermittent` status from the
`unexpected_count`.
A test has been added to test_expectedtree.py to ensure the `tree.result_values` is counting
correctly.
Differential Revision: https://phabricator.services.mozilla.com/D37729
--HG--
extra : moz-landing-system : lando
We have some tests which the top level document would
navigate to navigate_back.html, use history.back()
to navigate back to the top level document, and wait for
the iframes to fire a postMessage. This behavior requires
BFCache to be disabled to work correctly, otherwise BFCache
could block the code.
Differential Revision: https://phabricator.services.mozilla.com/D38520
--HG--
extra : moz-landing-system : lando
For esr versions, the category switches from "esr" to "stability" when the next esr branch is started. This breaks
the logic for determining which repository a release was made from. Since we also have code for determining the
type of release from the version number, we can just use that directly instead.
(Note that the logic will not work for Fennec as all releases have transitioned to mozilla-esr68, but Fennec does not
use update-verify.
Differential Revision: https://phabricator.services.mozilla.com/D38437
--HG--
extra : moz-landing-system : lando
Preferences::GetBool is not thread-safe, StaticPrefs are.
Also StaticPrefs are nicer anyway.
There's a lot of Preferences:: usage in dom/media which looks suspicious, though
I don't know if all that runs on the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D38097
--HG--
extra : moz-landing-system : lando
We have some tests which the top level document would
navigate to navigate_back.html, use history.back()
to navigate back to the top level document, and wait for
the iframes to fire a postMessage. This behavior requires
BFCache to be disabled to work correctly, otherwise BFCache
could block the code.
Differential Revision: https://phabricator.services.mozilla.com/D38520
--HG--
extra : moz-landing-system : lando
A possible explanation for the infrequent observation of an incomplete log is that
the log is still being written when the harness detects that the process has completed.
Waiting for one extra polling interval may avoid this.
Differential Revision: https://phabricator.services.mozilla.com/D38577
--HG--
extra : moz-landing-system : lando
Changed the required yml, ini, json, js and html files to migrate ARES6 benchmark test to Raptor.
Differential Revision: https://phabricator.services.mozilla.com/D34178
--HG--
extra : moz-landing-system : lando
This patch updates tests and adds a new test. This new test will
ensuring the identity icon will load a correct image with different
circumstances. For example, it should load a secure lock image if it is
a https page, an insecure lock image for http page and a brand image for
chrome page.
Differential Revision: https://phabricator.services.mozilla.com/D37792
--HG--
extra : moz-landing-system : lando
Nicolás Peña Moreno
Dale Curtis
Mustaq Ahmed
Alice Boxhall
Eric Willigers
moz-wptsync-bot
Takashi Toyoshima
Ian Kilpatrick
Reilly Grant
Fernando Serboncini
Joshua Bell
Mason Freed
Anne van Kesteren
Frédéric Wang
autofoolip
L. David Baron
Gérard Talbot
Domenic Denicola
Makoto Shimazu
Rob Buis
Andreea Pavel
Mike Pennisi
Luke Bjerring
Sam Sneddon
pyup-bot
Yoav Weiss
Jack Steinberg
Piotr Bialecki
Emil A Eklund
Mugdha Lakhani
Yuki Shiino
Raymond Toy
Dan Beam
Dave Tapuska
Javier Fernandez
Kagami Sascha Rosylight
Philip Jägenstedt
Emilio Cobos Álvarez
Rune Lillesveen
Wanming Lin
Olivier Yiptong
George Roman
Christian Biesinger
Xianzhu Wang
Koji Ishii
Jeremy Roman
Aleksey Shvayka
Hiroki Nakagawa
Kevin Ellis
Robert Ma
Jake Archibald
Anders Hartvoll Ruud
Adam Rice
Dominic Farolino
Jihwan Marc Kim
Ella Ge
Jun Cai
Aleks Totic
Lan Wei
Danyao Wang
Daniel Vogelheim
Tom McKee
Brandon Maslen
Morten Stenshorne
Olga Gerchikov
Rakina Zata Amni
Kouhei Ueno
Ayu Ishii
Cathie Chen
Harald Alvestrand
Xiaocheng Hu
kaixinjxq
Leon Han
Matt Wolenetz
Becca Hughes
Ali Juma
youennf
Bastien Orivel
Philippe Le Hegaret
Ryosuke Niwa
Narcis Beleuzu
Boris Zbarsky
Jan-Ivar Bruaroey
Nick Alexander
Charlie Marlow
Ehsan Akhgari
Rob Wu
Geoff Brown
Tom Schuster
Marian Raiciof
Glenn Watson
Sebastian Streich
Daniel Varga
Henri Sivonen
Johann Hofmann
alwu
Cameron McCormack
Nick Thomas
Aki Sasaki
Eric Rahm
Razvan Maries
Mihai Alexandru Michis
Coroiu Cristina
Csoregi Natalia
longsonr
Bogdan Tara
Gregory Mierzwinski
Gurzau Raul
Ting-Yu Lin
Brendan Dahl
Gijs Kruitbosch
Andrew McCreight
Edwin Gao
Brindusan Cristian
Jonathan Kew
Nikki Sharpley
Florin Strugariu
Sean Feng
Noemi Erli
Tom Prince
Kershaw Chang
Nupur Baghel
Karl Tomlinson
Dão Gottwald
alexandru.ionescu
Lee Salzman
Tim Huang