When compiled with -std=c++17, u8"" string literals have type `const char[]`. When compiled with -std=c++20, u8"" string literals have type `const char8_t[]`. This patch adds the minimum char8_t overloads needed to compile Firefox with -std=c++20. If we want to use char8_t in more code or replace `Utf8Unit` with char8_t, that will require an extensive redesign of MFBT's and xpcom's string classes after we update from -std=c++17 to c++20.
Differential Revision: https://phabricator.services.mozilla.com/D201672
This revision implements the mapping for the ARIA 1.2 emphasis role, which was
unsupported in Firefox until now. This change addresses a web platform test
failure. To accomplish this, the revision adds the WAI-defined role, adds a role
enum value, adds platform mappings, and adds a markup role mapping. The change
requires a new static atom for the word "emphasis," also added in this revision.
Finally, this change removes the expected wpt failure and updates other tests.
Differential Revision: https://phabricator.services.mozilla.com/D200130
This revision implements the mapping for the ARIA 1.2 emphasis role, which was
unsupported in Firefox until now. This change addresses a web platform test
failure. To accomplish this, the revision adds the WAI-defined role, adds a role
enum value, adds platform mappings, and adds a markup role mapping. The change
requires a new static atom for the word "emphasis," also added in this revision.
Finally, this change removes the expected wpt failure and updates other tests.
Differential Revision: https://phabricator.services.mozilla.com/D200130
The built-in version is better as it also allows annotating particular
parameters (it not only applies to method declarations).
Differential Revision: https://phabricator.services.mozilla.com/D200432
Looking at bug 1877605 made me realize we should define better when (startup) prefs
are set exactly.
This patch adds assertions to check startup prefs can only be set before `JS_Init` and
also fixes the embeddings to follow this new rule. This makes the JS shell and browser
behavior more consistent, and makes it possible to rely on pref values during startup.
Differential Revision: https://phabricator.services.mozilla.com/D200148
The built-in version is better as it also allows annotating particular
parameters (it not only applies to method declarations).
Differential Revision: https://phabricator.services.mozilla.com/D200432
This revision aims to add support for the 'term' and 'definition' ARIA roles.
These roles already exist in Gecko, but aren't fully mapped where they should
be. To address the problem, this revision adds a static atom for "definition,"
implements the ARIA map for definition, adds a markup map entry for the dfn
element (which has the DEFINITION role), and puts the term and definition atoms
in the role map. As a consequence of these changes, this revision also removes
the expected web platform test failures and updates other existing tests.
Differential Revision: https://phabricator.services.mozilla.com/D200219
No functional change. This class is only meant to be instantiated as a
temporary object, and this annotation helps enforce that.
Differential Revision: https://phabricator.services.mozilla.com/D199561
Reasons:
- The copy-constructor is never actually used.
- We already explicitly delete the reassignment operator for this class, which
suggests this class is not really designed to be copied.
- There's not really any good reason for us to make copies of instances of this
class, since this class is just meant to be a lightweight temporary wrapper
to be used only-when-needed, and only at API boundaries to external or legacy
functions.
- When the copy-constructor was used, it triggered a clang
`-Wdeprecated-copy` build warning, for using the default copy constructor
when the reassignment operator was non-default (explicitly deleted).
Differential Revision: https://phabricator.services.mozilla.com/D199383
It has never shipped after being implemented years ago,
and was removed from spec in September 2022:
https://github.com/w3c/webappsec-csp/pull/564
Now skipping navigate-to WPT tests. Filed issue upstream for their future removal:
https://github.com/w3c/webappsec-csp/issues/608
Consensus seems to agree to remove, will do in follow up bug once landed.
Also removed our own tests.
Added a hack in StartDocumentLoad as just removing the navigate-to check call
breaks some inhertiance, see comment for more info.
Differential Revision: https://phabricator.services.mozilla.com/D181630
It looks like this was an oversight in bug 1155059, that in one place an
already_AddRefed does not get converted to a RefPtr.
Differential Revision: https://phabricator.services.mozilla.com/D197374
Florian Quèze
Jeremie Courreges-Anglas
Kelsey Gilbert
Chris Peterson
James Teh
alwu
Narcis Beleuzu
Nathan LaPre
Iulian Moraru
Cathie Chen
Emilio Cobos Álvarez
Cristian Tuns
Jan de Mooij
pstanciu
Cosmin Sabou
Sergey Galich
Paul Bone
Stephen A Pohl
Jens Stutte
Daniel Holbert
Norisz Fay
Kagami Sascha Rosylight
Gabriele Svelto
Olli Pettay
Mike Hommey
Steve Fink
Stanca Serban
Tomislav Jovanovic
Oliver Medhurst
Lee Salzman