dom/system/PathUtils.cpp(77,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
ipc/chromium/src/chrome/common/ipc_channel_win.cc(479,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return true;
^~~~
mozglue/misc/PreXULSkeletonUI.cpp(1263,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
mozglue/tests/TestPEExportSection.cpp(348,12): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
security/manager/ssl/OSReauthenticator.cpp(428,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return NS_OK;
^~~~~
toolkit/components/maintenanceservice/maintenanceservice.cpp(214,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
widget/windows/WindowsUIUtils.cpp(383,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144661
The Firefox in flatpak has no access to the wireless networks to determine
accurate geolocation. We have to use the location portal instead which
provides the current location based on the nearby wireless accesspoints
or other methods.
Differential Revision: https://phabricator.services.mozilla.com/D142329
The Firefox in flatpak has no access to the wireless networks to determine
accurate geolocation. We have to use the location portal instead which
provides the current location based on the nearby wireless accesspoints
or other methods.
Differential Revision: https://phabricator.services.mozilla.com/D142329
PathUtils.getTempDir() was failing in xpcshell tests for two reasons:
1. It was requesting NS_APP_CONTENT_PROCESS_TEMP_DIR, which resolves to
`ContentTmpD`, which the directory provider did not have an entry for.
2. By default, XPC shell tests do not have a profile set up, so when we request
the temporary directory and eagerly fetch the profile directory, we would fail.
We now only fetch the entry for the single directory that is requested to work
around these edge cases in tests. xpcshell has been modified so that requests
for the `ContentTmpD` are forwarded to requests for the regular OS temporary
directory.
Differential Revision: https://phabricator.services.mozilla.com/D134877
PathUtils.getTempDir() was failing in xpcshell tests for two reasons:
1. It was requesting NS_APP_CONTENT_PROCESS_TEMP_DIR, which resolves to
`ContentTmpD`, which the directory provider did not have an entry for.
2. By default, XPC shell tests do not have a profile set up, so when we request
the temporary directory and eagerly fetch the profile directory, we would fail.
We now only fetch the entry for the single directory that is requested to work
around these edge cases in tests. xpcshell has been modified so that requests
for the `ContentTmpD` are forwarded to requests for the regular OS temporary
directory.
Differential Revision: https://phabricator.services.mozilla.com/D134877
PathUtils::CreateUniquePath was doing main thread IO, so we're moving it to
IOUtils to use its event loop to do the IO.
Additionally, we're adding IOUtils::CreateUniqueDirectory which is the same as
::CreateUniqueFile, but for directories.
Differential Revision: https://phabricator.services.mozilla.com/D133841
PathUtils::CreateUniquePath was doing main thread IO, so we're moving it to
IOUtils to use its event loop to do the IO.
Additionally, we're adding IOUtils::CreateUniqueDirectory which is the same as
::CreateUniqueFile, but for directories.
Differential Revision: https://phabricator.services.mozilla.com/D133841
PathUtils::CreateUniquePath was doing main thread IO, so we're moving it to
IOUtils to use its event loop to do the IO.
Additionally, we're adding IOUtils::CreateUniqueDirectory which is the same as
::CreateUniqueFile, but for directories.
Differential Revision: https://phabricator.services.mozilla.com/D133841
Peter Van der Beken
Tooru Fujisawa
Marian-Vasile Laza
Mike Hommey
Jan Horak
Molnar Sandor
Jan Rio Krause
Barret Rennie
Cristian Tuns
Csoregi Natalia
criss
Butkovits Atila
Alexandru Michis
Mathew Hodson
Mark Banner