This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.
The patch also does some associated clean-up.
- Replaces some uses of nsIMemoryReporterCallback with the preferred
nsIHandleReportCallback typedef.
- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
parameter names, for consistency.
- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.
- Uses the MOZ_COLLECT_REPORT macro in all suitable places.
Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.
--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
The patch also changes RemoteOpenFileChild::OpenNSPRFileDesc() so that it
cannot succeed with a null fd, so that checking just the return value is
sufficient.
--HG--
extra : rebase_source : cc40bbcf2a9991edc9d3da3fb624d27db50b4996
Considering its popular use, the decision to support this format was agreed upon.
MozReview-Commit-ID: Dcwr547dbW
--HG--
extra : rebase_source : f7ea5e825d2912cbdbb3d75f91180094063aaeba
Returing TS_E_NOLAYOUT while ATOK shows suggest window causes moving suggest window to odd position. This causes flicking the window. Therefore, we shouldn't return TS_E_NOLAYOUT in this case. In this case, ATOK queries whole rect of composition string. So, we can return TS_E_NOLAYOUT for other cases.
MozReview-Commit-ID: LBZQPFjqQgx
--HG--
extra : rebase_source : 27fda6739562dfaf89efd1d2cd9cac03610846ba
This makes a lot of code more compact, and also avoids some redundant nsresult
checks.
The patch also removes a handful of redundant checks on infallible setters.
--HG--
extra : rebase_source : f82426e7584d0d5cddf7c2524356f0f318fbea7d
- The Cardboard VR support has hardcoded values and uses low-performance
orientation APIs and rendering paths.
- There is little benefit to this Cardboard VR implementation over using
polyfills.
- A future implementation would be based on Google VR support in Android N
and/or Samsung Gear VR Oculus Mobile APIs.
MozReview-Commit-ID: 7e9Th8ZTmj8
- Oculus 0.5 runtime was the last to support OSX, but is no longer supported
on the latest (El Capitan) OSX version and does not support current
shipping Oculus hardware.
- Oculus 1.x runtime will continue to be supported for Oculus on Windows.
MozReview-Commit-ID: 2c7qViLoyr0
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
Mason Chang
kearwood
Ryan VanderMeulen
Jon Coppeard
Kartikaya Gupta
Nicholas Nethercote
Julian Seward
Andrea Marchesini
Christoph Kerschbaumer
Fred Lin
Jean-Yves Avenard
Alexander Surkov
Lee Salzman
Masayuki Nakano
Wes Kocher
Jeff Gilbert
Munro Mengjue Chiang
Randall Barker
Jessica Jong
Sebastian Hengst
David Anderson
Kearwood (Kip) Gilbert
Shih-Chiang Chien