Граф коммитов

67583 Коммитов

Автор SHA1 Сообщение Дата
Calixte Denizet 298788c5e7 Bug 1684928 - Enable mochitest for pdf.js JS sandbox r=bdahl
Differential Revision: https://phabricator.services.mozilla.com/D105832
2021-02-22 17:13:24 +00:00
Nihanth Subramanya b88988a027 Bug 1460314 - TRR: add telemetry probe for used HTTP version. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D100519
2021-02-22 14:43:15 +00:00
Valentin Gosu a9cce9ac08 Bug 1646452 - Key TRR telemetry by domain of DoH server r=nhnt11,necko-reviewers,dragana
This allows us to separate general TRR performance issues from "this user's
custom DoH server is slow or malfunctioning".
Any DoH servers domains that are not shipped by Firefox are reported as (other).

Differential Revision: https://phabricator.services.mozilla.com/D105602
2021-02-22 13:51:44 +00:00
Stephen A Pohl ca8b4e2c68 Bug 1693950: Ensure that chrome tests continue to use the native theme to not lose test coverage since we do not intend to enable the non-native theme in chrome at this time. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D105856
2021-02-22 13:12:17 +00:00
Tim Nguyen b7714f3775 Bug 1693979 - Reduce the size of notification bars. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D105865
2021-02-22 12:47:30 +00:00
Simon Giesecke c5f7800f35 Bug 1691913 - Rename nsClassHashtable::LookupOrAdd to GetOrInsertNew. r=xpcom-reviewers,nika
It should be called "Get" rather than "Lookup" because it returns
UserDataType. "Add" is called "Insert" in the other methods.

Differential Revision: https://phabricator.services.mozilla.com/D105470
2021-02-22 12:07:47 +00:00
Simon Giesecke d2caea36fa Bug 1691894 - Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=xpcom-reviewers,necko-reviewers,jgilbert,nika
Differential Revision: https://phabricator.services.mozilla.com/D104676
2021-02-22 12:07:46 +00:00
Gijs Kruitbosch 0598e83a2b Bug 1693276 - update button styles for proton r=desktop-theme-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D105481
2021-02-22 10:53:34 +00:00
Henri Sivonen 9d6d02b341 Bug 1663931 - Avoid moving focus when changing iframe remoteness. r=nika,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D99215
2021-02-22 10:51:51 +00:00
Butkovits Atila 7bb1cc6abf Bug 1676659 - disable browser_preview_switch_print_selected.js for frequent failures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D105413
2021-02-20 15:33:00 +00:00
Kate Hudson 5ed61e3b12 Bug 1692230 - Move nimbus code to its own directory r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D105567
2021-02-20 02:51:12 +00:00
Kirk Steuber 72ce961859 Bug 1690062 - r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D105382
2021-02-20 00:49:02 +00:00
Michael Cooper 1aaf619aea Bug 1693402 - Add telemetry to determine source of unenrollFailed events r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105541
2021-02-19 21:48:21 +00:00
MuraliAchanti 6c503d3275 Bug 1442053 - Change the following global variables from the C string to the C++ ones:pendingDirectory,crashReporterPath,memoryReportPath,libraryPath and eventsDirectory. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D105222
2021-02-19 20:50:23 +00:00
Dragana Damjanovic 66692fa536 Bug 1693738 - Extend HTTP3_CONNECTION_CLOSE_CODE telemetry and add more detail codes for the internal errors r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105725
2021-02-19 20:37:24 +00:00
Neil Deakin 2c12c67037 Bug 1676943, add telemetry for how often tab or subframe crash ui is presented to the user. In addition, add telemetry to indicate that the user is shown the unsubmitted crashes notification bar, r=mconley
The telemetry is triggered either when the user is shown the tab crashed page, or when the subframe notification is displayed and the crash occurs in an active tab, or when the user switches to a tab that has a subframe crash notification displayed. The telemetry only applies the first time the tab is switched to. The unsubmitted crashes notification bar appears after 10 minutes or so and is shown in the top-most browser window, if one exists, and telemetry applies once when this occurs.

Differential Revision: https://phabricator.services.mozilla.com/D100349
2021-02-19 19:24:17 +00:00
Emilio Cobos Álvarez 1663bc278f Bug 1693690 - Enable the native theme in toolkit/themes/osx. r=spohl
These tests rely on implementation details of nsNativeThemeCocoa.mm

Differential Revision: https://phabricator.services.mozilla.com/D105808
2021-02-19 18:16:55 +00:00
Brendan Dahl 587acac680 Bug 1693855 - Update pdf.js to version 2.8.117 r=calixte
Differential Revision: https://phabricator.services.mozilla.com/D105804
2021-02-19 18:07:48 +00:00
Calixte Denizet 582df65115 Bug 1667973 - Add a sandbox to evaluate js embedded in PDF r=bdahl,dveditz,robwu
PDF files can embed some js code in order to validate, format, ... the data entered by a user in a PDF form.
So in order to safely execute this js code, we create a Cu.Sandbox with only what we need/want to expose to the scripts.

Differential Revision: https://phabricator.services.mozilla.com/D91746
2021-02-19 16:14:38 +00:00
Ed Lee f348f8d342 Bug 1686343 - Ask user to pin Firefox during windows about:welcome onboarding r=pdahiya
Support pin special action and add a new action property to wait for default browser that changes styles and content.

Differential Revision: https://phabricator.services.mozilla.com/D105653
2021-02-19 10:25:54 +00:00
Butkovits Atila 7c91bb869c Backed out changeset 8c8e776cbd29 (bug 1667973) for causing failures on browser_all_files_referenced.js. CLOSED TREE 2021-02-19 12:24:56 +02:00
Calixte Denizet 28de5d33f4 Bug 1667973 - Add a sandbox to evaluate js embedded in PDF r=bdahl,dveditz,robwu
PDF files can embed some js code in order to validate, format, ... the data entered by a user in a PDF form.
So in order to safely execute this js code, we create a Cu.Sandbox with only what we need/want to expose to the scripts.

Differential Revision: https://phabricator.services.mozilla.com/D91746
2021-02-19 09:24:31 +00:00
Itiel 127183db97 Bug 1693663 - Add dark mode support for about:serviceworkers r=ntim,asuth
Differential Revision: https://phabricator.services.mozilla.com/D105689
2021-02-19 09:08:29 +00:00
Swapnik Katkoori b2263951cf Bug 1679174 - Filter out videos with NaN duration. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D103845
2021-02-19 01:51:25 +00:00
Magnus Melin d1e5dba9f7 Bug 1474397 - followup to really not try to import normandy modules in about:support / Troubleshoot.jsm, if normandy is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105658
2021-02-19 00:06:19 +00:00
Ping Chen b2fa673570 Bug 902346 - Support socks proxy in TCPSocket. r=mixedpuppy,necko-reviewers
- Use nsIProtocolProxyService to look up proxy
- Pass the found proxy to CreateTransport

Differential Revision: https://phabricator.services.mozilla.com/D104357
2021-02-18 23:47:44 +00:00
Narcis Beleuzu 641e8b352b Backed out 2 changesets (bug 1571419) for bc failure on browser_headless_screenshot.js
Backed out changeset f96850b1cb38 (bug 1571419)
Backed out changeset 0c018b593000 (bug 1571419)
2021-02-19 01:03:13 +02:00
Mike Hommey 5e19605601 Bug 1692939 - Add sorted() as an allowed builtin in python configure. r=firefox-build-system-reviewers,mhentges
It has no side effects and is safe to use in the configure sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D105262
2021-02-18 22:44:39 +00:00
Itiel 05d88b715b Bug 1692301 - Add dark mode support for about:buildconfig r=mconley,glandium
Also make it so it'd match the style of other about: pages.

Differential Revision: https://phabricator.services.mozilla.com/D104877
2021-02-18 22:05:09 +00:00
Itiel 1fc32fef7f Bug 1693642 - Vertically align the radio buttons' text on about:addons details panel r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D105677
2021-02-18 22:01:12 +00:00
Brendan Dahl 183f77768a Bug 1571419 - Make --screenshot fission compatible. r=kmag
Move capturing the window into the parent process to use the new
drawSnapshot API.

Differential Revision: https://phabricator.services.mozilla.com/D104734
2021-02-18 21:51:11 +00:00
Mark Banner d5b805a6e4 Bug 1692623 - When loading a search engine icon, if it is not an image/ content type then ignore it. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105483
2021-02-18 18:38:28 +00:00
Doug Thayer 32df9dca47 Bug 1689258 - Remove expiration for tab spinner probes r=mconley
I don't see us *not* wanting this information for the foreseeable future. They
are not the most actively tracked probes, but any time we change anything with
tab switching I expect them to be relevant.

Differential Revision: https://phabricator.services.mozilla.com/D104838
2021-02-18 18:33:29 +00:00
Dorel Luca 7c23ebad3e Backed out changeset 4a3f1073b7b5 (bug 1693176) for Browser-chrome failures in extensions/test/browser/browser_ext_browserAction_contextMenu.js. CLOSED TREE 2021-02-18 20:43:58 +02:00
Andrei Oprea d4bf0aebf2 Bug 1692227 - Add ExperimentFeature to newnewtab/settings panel r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D104987
2021-02-18 17:05:15 +00:00
Emilio Cobos Álvarez 1ab6cf4876 Bug 1693176 - Destroy frames of contents inside panels. r=Gijs
Panels don't rely so much on the popup manager code to deal with
menuitems etc, so this is trivial and fixes the issue as reported.

I think it's pretty unlikely to have animated stuff in menulists /
menupopups, so this should get us most of the way.

Differential Revision: https://phabricator.services.mozilla.com/D105550
2021-02-18 16:44:12 +00:00
Gijs Kruitbosch 21285db89d Bug 1693406 - fix select dropdown styling in proton when the page customizes it, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D105642
2021-02-18 16:33:20 +00:00
Doug Thayer a794acaa37 Bug 1689257 - Update expiration for startup cache / script preloader probes r=mconley
These I could see us wanting to rip out at some point, so I am just going to
kick the can down the road.

Depends on D104838

Differential Revision: https://phabricator.services.mozilla.com/D104839
2021-02-18 16:32:19 +00:00
Emma Malysz b8fb1100c5 Bug 1669732, add error message for invalid number of copies r=mstriemer,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D103385
2021-02-18 16:23:54 +00:00
William Durand 77c9e5340c Bug 1588801 - Add test coverage for JS files loaded from XPIs. r=mixedpuppy,robwu
JS files in packed webextensions (XPIs) are loaded via `nsJARChannel`,
which checks the content type of a file based on the extension by
calling `nsIMIMEService::GetTypeFromExtension()`.

We might not be able to guarantee the exact set of JS file extensions
because this method also asks the OS but it should still be reliable.
We allow `.js`, `.jsm` and `.mjs` (defined in `defaultMimeEntries` and
`extraMimeEntries`).

Differential Revision: https://phabricator.services.mozilla.com/D104450
2021-02-18 15:35:46 +00:00
Steven Englehardt 2478333276 Bug 1689271 - Extend COOKIE_PURGING_* probes indefinitely; r=timhuang, data-review=tdsmith
Differential Revision: https://phabricator.services.mozilla.com/D105062
2021-02-18 15:05:15 +00:00
Andrei Oprea 613f319b79 Bug 1693437 - Fix Intermittent toolkit/components/messaging-system/test/browser/browser_remotesettingsexperimentloader_init.js r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D105603
2021-02-18 14:13:57 +00:00
Alexis Beingessner 07f2f659c6 Bug 1686616 - make StringBundle use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105531
2021-02-18 13:26:32 +00:00
Alexis Beingessner 3f1a425606 Bug 1686616 - make IO use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105530
2021-02-18 13:26:32 +00:00
Alexis Beingessner ddff243f3c Bug 1686616 - make Directory use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105529
2021-02-18 13:26:32 +00:00
Alexis Beingessner 8fea71cdd5 Bug 1686616 - make PermissionManager use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105528
2021-02-18 13:26:31 +00:00
Alexis Beingessner 07ad6bc655 Bug 1686616 - make UUIDGenerator use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105526
2021-02-18 13:26:30 +00:00
Alexis Beingessner 442e2d6fa1 Bug 1686616 - make History use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105524
2021-02-18 13:26:30 +00:00
Alexis Beingessner bd14ca539e Bug 1686616 - make ThirdPartyUtil use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105523
2021-02-18 13:26:29 +00:00
Alexis Beingessner 92afde7986 Bug 1686616 - register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin
These services had their name added to components.conf:

* GfxInfo
* ThirdPartyUtil
* History
* HttpActivityDistributor
* UUIDGenerator
* ServiceWorkerManager
* PermissionManager

These services were added to componenets.conf under a different name:

* DirectoryService => Directory
* IOService => IO
* StringBundleService => StringBundle
* CacheStorageService => CacheStorage
* StreamTransportService => StreamTransport
* SocketTransportService => SocketTransport

These services weren't migrated to components.conf because only Rust
code uses them:

* RemoteAgent
* XULRuntime
* PrefService

These services weren't migrated to components.conf because they're unused:

* ToolkitChromeRegistry (used as ChromeRegistry)
* XULChromeRegistry (used as ChromeRegistry)
* Bits (completely unused)

These services were already available in components.conf but are still
used by rust code:

* URIFixup

These services weren't migrated because they will be handled in
subsequent patchsets:

* ObserverService

For the record, the following Services are being used by Rust code
and must remain until a Rust version of Components.h is written:

* RemoteAgent
* XULRuntime
* PrefService
* URIFixup
* ObserverService
* DirectoryService
* ThirdPartyUtil

Also the cocoa GfxInfo service was changed to use components.conf instead
of registering it at runtime, as all the other widgets were already doing
it this way.

Differential Revision: https://phabricator.services.mozilla.com/D105521
2021-02-18 13:26:28 +00:00
Kershaw Chang 3d66c37e76 Bug 1689987 - P5: Add probes to collect DNS lookup time when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105215
2021-02-18 12:50:04 +00:00
Kershaw Chang 36d1df148d Bug 1689987 - P4: Add a telemetry probe to collect channel success rate when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105214
2021-02-18 12:50:03 +00:00
Kershaw Chang 782c896152 Bug 1689987 - P2: Add DNS_ODOH_LOOKUP_TIME and ODOH_SKIP_REASON_ODOH_FIRST probes r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104800
2021-02-18 12:50:02 +00:00
smolnar 75b24e8485 Backed out changeset e9fe3f02c06a (bug 1588801) for causing xpc failures in test_ext_script_filenames. CLOSED TREE 2021-02-18 12:54:37 +02:00
William Durand e0091f942e Bug 1588801 - Add test coverage for JS files loaded from XPIs. r=mixedpuppy,robwu
JS files in packed webextensions (XPIs) are loaded via `nsJARChannel`,
which checks the content type of a file based on the extension by
calling `nsIMIMEService::GetTypeFromExtension()`.

We might not be able to guarantee the exact set of JS file extensions
because this method also asks the OS but it should still be reliable.
We allow `.js`, `.jsm` and `.mjs` (defined in `defaultMimeEntries` and
`extraMimeEntries`).

Differential Revision: https://phabricator.services.mozilla.com/D104450
2021-02-18 10:02:43 +00:00
Magnus Melin fbae73195d Bug 1474397 - Only try to import normandy modules in about:support / Troubleshoot.jsm, if normandy is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105594
2021-02-18 09:18:37 +00:00
Butkovits Atila 06bd6484d8 Bug 1683848 - disable browser_localip_frame.js for frequent failures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D105135
2021-02-18 04:20:49 +00:00
Erik Nordin d718e71945 Bug 1692316 - Part 2: Update Print UI Duplex Terminology r=dholbert,fluent-reviewers,sfoster
Updates the print UI to use the new "long edge" and "short edge"
duplex print terminology that is now used in the print platform.

Differential Revision: https://phabricator.services.mozilla.com/D105500
2021-02-17 23:57:27 +00:00
Erik Nordin 8f06e5bc6a Bug 1692316 - Part 1: Update Platform Duplex Print Terminology r=dholbert
This patch updates the terminology used by the print platform from
the formerly used terms of "side edge" and "top edge" to now using
terms of "long edge" and "short edge".

These terms more accurately describe our existing implementation
behavior, and they are congruent with many existing APIs that also
use "long edge" and "short edge" terminology.

Differential Revision: https://phabricator.services.mozilla.com/D105499
2021-02-17 23:57:26 +00:00
Molly Howell bb4c298e54 Bug 1692237 - Fix colors and backgrounds for in-content XUL menus and system-themed widgets. r=desktop-theme-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D104930
2021-02-17 23:40:52 +00:00
Paul Bone db676a95a2 Bug 1692851 - Use exec to launch firefox when switching profiles r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105410
2021-02-17 23:38:56 +00:00
Kershaw Chang 5b4663a115 Bug 1693146 - Report telemetry when a JAR channel is failed or en empty file is loaded, r=zbraniecki,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105359
2021-02-17 23:12:43 +00:00
Sean Feng 93ae22d5b9 Bug 1692350 - Implement a telemetry probe to collect page load data for documents that use lazyload r=emilio,chutten
Differential Revision: https://phabricator.services.mozilla.com/D104912
2021-02-17 22:25:02 +00:00
Mike Hommey 7eb38cd807 Bug 1670538 - Use an allow-list in RUSTC_BOOTSTRAP for rustc >= 1.50.0. r=firefox-build-system-reviewers,andi,sheehan,mhentges
While we could change qcms, encoding_rs and packed_simd to not emit
RUSTC_BOOTSTRAP on newer versions of rust, like we do for gkrust-shared,
it's not worth the effort (especially for those that are vendored).

Differential Revision: https://phabricator.services.mozilla.com/D105423
2021-02-17 21:47:28 +00:00
Andrei Oprea 3da89fe758 Bug 1692545 - Don't throw on enrollment if a duplicate feature id exists r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D105226
2021-02-17 21:39:58 +00:00
Greg Tatum c9e1c0d512 Bug 1691751 - Fix Fluent linting whitespace issues; r=dminor,flod
Differential Revision: https://phabricator.services.mozilla.com/D105370
2021-02-17 21:02:49 +00:00
Matthew Gregan 00a601715e Bug 1693270 - Switch audioipc-2 to vendored code. r=cubeb-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D105453
2021-02-17 20:23:46 +00:00
Rob Wu ba9eb692c9 Bug 1689274 - Update expiration of blocklist probes r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D105049
2021-02-17 20:12:09 +00:00
Matthew Gregan 6b6ffce060 Bug 1689517 - Update cubeb-rs to 0.9.0 along with cubeb-pulse-rs and cubeb-coreaudio-rs. r=cubeb-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D105443
2021-02-17 20:06:43 +00:00
Mihai Alexandru Michis 8d0efc214f Backed out changeset 6a0dcd8f4e3e (bug 1692350) for causing crashes in WindowContext.
CLOSED TREE
2021-02-17 21:02:59 +02:00
Michael Cooper a1fa813296 Bug 1474397 - Show Normandy information in about:support r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104910
2021-02-17 18:01:58 +00:00
Sean Feng 7917a71b50 Bug 1692350 - Implement a telemetry probe to collect page load data for documents that use lazyload r=emilio,chutten
Differential Revision: https://phabricator.services.mozilla.com/D104912
2021-02-17 17:17:52 +00:00
Kate Hudson f26a2e1e06 Bug 1692228 - Send exposure for New Tab Feature r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D105005
2021-02-17 13:44:38 +00:00
Csoregi Natalia 3e2dc7ffec Backed out 2 changesets (bug 1665942, bug 1683713) for failures on browser_cookies_legacy.js. CLOSED TREE
Backed out changeset d2f4a6c7e9ca (bug 1665942)
Backed out changeset b04fe74185a0 (bug 1683713)
2021-02-17 13:28:09 +02:00
Emilio Cobos Álvarez 1936b103f8 Bug 1678487 - Allow a crash reporter test to pass if something else in Gecko startup adds crash reporter notes. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D105372
2021-02-17 10:37:53 +00:00
Valentin Gosu 6c0279a5c0 Bug 1691408 - Add trrConfirmation event telemetry r=nhnt11,dragana
Differential Revision: https://phabricator.services.mozilla.com/D104509
2021-02-17 10:26:40 +00:00
Csoregi Natalia e77fb8ce75 Bug 1683253 - Disabled test_ext_webRequest_cancelWithReason.js on Android 7.0 x86-64. r=intermittent-reviewers,mixedpuppy,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D105138
2021-02-17 09:20:15 +00:00
Tom Tung 9b0647633f Bug 1665942 - Collect userContextId from tab in _collectBaseTabData and stop collecting it in the session history collection; r=nika,geckoview-reviewers,agi
### Story

When a COOP+COEP page is opened, we change the remoteness of the tab. After
changing the remoteness, the tab is then restored by its TabState. However,
we haven't collected userContextId through the current mechanism.

To fix that, this patch changes the way to collect userContextId.

### Test Plan

Test: D98296

Depends on D98296

Differential Revision: https://phabricator.services.mozilla.com/D98468
2021-02-17 07:45:13 +00:00
Andreea Pavel 64289058b6 Backed out 5 changesets (bug 1690167) for failing xpcshell at bootstrapSvc.js on a CLOSED TREE
Backed out changeset d28c0f11743f (bug 1690167)
Backed out changeset 3b2bebed9128 (bug 1690167)
Backed out changeset 7e925e90a251 (bug 1690167)
Backed out changeset f85934a2b7ad (bug 1690167)
Backed out changeset 6d83474e81bb (bug 1690167)
2021-02-17 07:10:58 +02:00
alwu 6f21141c39 Bug 1690372 - part2 : add Telemetry probe for WMF usage. r=bryce
Depends on D103836

Differential Revision: https://phabricator.services.mozilla.com/D103837
2021-02-16 23:53:45 +00:00
Markus Stange 355baf5b39 Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
This patch was generated automatically, using the following commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
Markus Stange 9bc888af4a Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
This patch was generated automatically, using the following commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange 56051da2d0 Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
This patch was generated with the commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Markus Stange 5257db6695 Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
This patch was generated automatically with the commands below:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Dale Harvey d928b9d17c Bug 1689263 - Extend REGION_LOCATION_SERVICES_DIFFERENCE expiration until v92 r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D104544
2021-02-16 22:19:23 +00:00
Toshihito Kikuchi 5caeb6676b Bug 1691684 - Increase kMaximumPendingQueries to wait for expected loading events longer. r=mhowell
This is a test-only change.

The "UntrustedModulesFixture.Serialize" test fails on ASan build of mozilla-beta
and mozilla-release because the current value of waiting cycles 200 is not enough
to collect all expected loading events, while it's enough on the normal build or
mozilla-central.

This patch is simply to increase the number of cycles to 500.  Test logs show
ASan build of mozilla-betal or mozilla-release needs about 250 cycles to collect
all expected loading events, so 500 should be enough.

Differential Revision: https://phabricator.services.mozilla.com/D105363
2021-02-16 21:50:57 +00:00
Mike Hommey 622b111f9e Bug 1690167 - Change VsprintfLiteral/SprintfLiteral to rely on PrintfTarget. r=nika,Gankra,firefox-build-system-reviewers,mhentges
Instead of snprintf.

Because some standalone code uses those functions directly or indirectly,
and PrintfTarget lives in mozglue, they now need to depend on mozglue
instead of mfbt. Except logalloc/replay, which cherry-picks what it
uses.

Differential Revision: https://phabricator.services.mozilla.com/D103730
2021-02-16 21:20:04 +00:00
Paul Zuehlcke 0379f315c7 Bug 1693000 - Updated CookiePartitionedForeign console message to refer to State Partitioning. r=timhuang,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105343
2021-02-16 19:50:18 +00:00
Emilio Cobos Álvarez cd3fa8e953 Bug 1693129 - Linux arrowpanels should be transparent. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D105357
2021-02-16 19:16:01 +00:00
Andrei Cristian Petcu 99c5b52ccc Bug 1692481 Fix Import Error error modal after importing with multiple column headers r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D105099
2021-02-16 18:36:57 +00:00
Andrei Oprea 6400cd7518 Bug 1691516 - Experiment Store Sync cache should store each feature pref separately r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D104688
2021-02-16 17:01:29 +00:00
Dorel Luca 3aa6613f1e Backed out 2 changesets (bug 1680104) for XPCshell failures in search/tests/xpcshell/test_addEngineWithDetails.js. CLOSED TREE
Backed out changeset 5a0f9dd0f65a (bug 1680104)
Backed out changeset a5907cd12e19 (bug 1680104)
2021-02-16 18:44:46 +02:00
Simon Giesecke 661e25bf09 Bug 1692880 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-16 15:53:33 +00:00
Mark Banner 5f6b4fcb7d Bug 1680104 - Automatically remove search engines where the associated add-on is disabled/not installed. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105051
2021-02-16 15:45:11 +00:00
Mark Banner b0a9c94944 Bug 1680104 - Rewrite test_webextensions_valid.js to make it simpler to extend. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105050
2021-02-16 15:45:11 +00:00
Kagami Sascha Rosylight 3e3b0dc948 Bug 1691755 - Move view-source context menu items to nsContextMenu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104956
2021-02-16 15:42:48 +00:00
Jan-Erik Rediger b1238e2814 Bug 1692870 - Glob-list obsolete pings. r=chutten DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D105193
2021-02-16 15:00:17 +00:00
R. Martinho Fernandes 7854ab1ac8 Bug 1689269 - Update probes expiring in Firefox 88: WEBAUTHN_* r=dveditz
Differential Revision: https://phabricator.services.mozilla.com/D104841
2021-02-16 14:15:25 +00:00
Emilio Cobos Álvarez bdf8e636ad Bug 1691428 - Fix styling of unthemed menupopups and menuitems in Linux. r=dao
The background change matches Windows / Mac, and common sense too.

The customoptionstyling change is because that comment is just false,
although custom select is not enabled on Linux (though maybe it could
after this patch, will look into it separately).

Finally, give some padding to unthemed menuitems. GTK overrides this
padding with the theme one, but this allows having a sane default.

This is the padding I get with Adwaita, which is the default GTK theme.

Differential Revision: https://phabricator.services.mozilla.com/D104874
2021-02-16 13:18:14 +00:00
Narcis Beleuzu 9a0c3c6009 Backed out changeset b472dea7eb0c (bug 1691755) for bc failures on browser_viewsourceprefs.js . CLOSED TREE 2021-02-16 13:53:17 +02:00
Kagami Sascha Rosylight 104874c6e2 Bug 1691755 - Move view-source context menu items to nsContextMenu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104956
2021-02-16 09:49:32 +00:00
Gabriele Svelto 5d9d0b4383 Bug 1692531 - Reinstate the out-of-tree Breakpad patch fixing bug 1371390 r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D105098
2021-02-16 06:41:00 +00:00
Cosmin Sabou 5120ec6857 Backed out changeset 6f247372f7ab (bug 1691516) for causing a spike in failure rate for Bug 1276456 and Bug 1630974. 2021-02-16 07:04:50 +02:00
Gerald Squelart 2416d881e2 Bug 1691589 - Reduce reliance on GeckoProfiler.h when only labels (and maybe markers) are needed - r=necko-reviewers,geckoview-reviewers,sg,agi,florian
There are no code changes, only #include changes.
It was a fairly mechanical process: Search for all "AUTO_PROFILER_LABEL", and in each file, if only labels are used, convert "GeckoProfiler.h" into "ProfilerLabels.h" (or just add that last one where needed).
In some files, there were also some marker calls but no other profiler-related calls, in these cases "GeckoProfiler.h" was replaced with both "ProfilerLabels.h" and "ProfilerMarkers.h", which still helps in reducing the use of the all-encompassing "GeckoProfiler.h".

Differential Revision: https://phabricator.services.mozilla.com/D104588
2021-02-16 04:44:19 +00:00
Bogdan Tara f1451cbda6 Backed out 2 changesets (bug 1680104) for browser_newTabDrop.js mochitest failures CLOSED TREE
Backed out changeset 45f6157a879e (bug 1680104)
Backed out changeset f430e91157eb (bug 1680104)
2021-02-16 00:28:40 +02:00
Mark Striemer 2e3562988a Bug 1692232 - Part 2: Remove tab-modal UI experiment r=preferences-reviewers,jaws,fluent-reviewers,flod
Depends on D104844

Differential Revision: https://phabricator.services.mozilla.com/D104864
2021-02-15 20:34:19 +00:00
Mark Striemer 080813ab45 Bug 1692232 - Enable tab-modal print UI on all channels r=sfoster,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D104844
2021-02-15 20:34:18 +00:00
Andrei Oprea 716b516708 Bug 1691516 - Experiment Store Sync cache should store each feature pref separately r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D104688
2021-02-15 19:22:37 +00:00
Robert Mader 3ff9370f02 Bug 1689207 - Some fixes for EGL in glxtest, r=aosmond
- Do not require GLES >= 3.0 any more to succeed, fixing this bug.
- Use GL instead of GLES, matching GLX behavior. This way we can avoid
  most regressions related to the EGL switch. One scenario here is older
  intel hardware supporting GL 1.4 and GLES 2.0 - we want to continue
  blocking this hardware altogether, as e.g. WebGL does not support a
  fallback to GLES in this case, resulting in crashes.
- Add more error messages and early returs, making future debugging
  easier.
- Downgrade `record_error` to `record_warning` in some more places where
  we don't want to fail hard (bug 1689707).
- Remove `eglCreatePbufferSurface` - it always failed anyway, unnoticed!
- Do not try to fall back to X11 on Wayland - we would fail in other
  parts of the stack anyway, thus lets keep the code simple.

After this patch we should always match GLX behavior when setting
different combinations of `MESA_GL_VERSION_OVERRIDE` and `MESA_GLES_VERSION_OVERRIDE`

Differential Revision: https://phabricator.services.mozilla.com/D105107
2021-02-15 18:52:18 +00:00
Mark Banner 12ac5ab9ff Bug 1680104 - Automatically remove search engines where the associated add-on is disabled/not installed. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105051
2021-02-15 18:14:55 +00:00
Mark Banner 6d56540e76 Bug 1680104 - Rewrite test_webextensions_valid.js to make it simpler to extend. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105050
2021-02-15 18:14:55 +00:00
Simon Giesecke ca94ec101e Bug 1691894 - Simplify uses of GetOrInsert where non-default-constructed entries are eventually inserted. r=xpcom-reviewers,necko-reviewers,nika,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104674
2021-02-15 16:37:52 +00:00
Marco Bonardo d139c0fff7 Bug 1647406 - Avoid a possible thread data race in PlacesShutdown. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D104847
2021-02-15 15:34:46 +00:00
Simon Giesecke 780a1636a9 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 15:12:17 +00:00
smolnar 1afbbe67e1 Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
Simon Giesecke 3c29a68440 Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-15 10:04:46 +00:00
Simon Giesecke 8973094ec1 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 10:04:45 +00:00
Daisuke Akatsuka b6ad7a47ed Bug 1678618: Avoid firing extra events in NewTabUtils. r=mak
Depends on D101118

Differential Revision: https://phabricator.services.mozilla.com/D101119
2021-02-15 08:04:16 +00:00
Daisuke Akatsuka 105aaaa9fa Bug 1678618: Remove onDeleteURI and onDeleteVisits from nsINavHistoryObserver. r=mak
Depends on D101115

Differential Revision: https://phabricator.services.mozilla.com/D101118
2021-02-15 08:04:15 +00:00
Daisuke Akatsuka f4358ad192 Bug 1678618: Apply page-removed event. r=mak
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 08:04:15 +00:00
Daisuke Akatsuka 8a1a30387f Bug 1678618: Imlement a mechanism to fire page-removed event. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D101114
2021-02-15 08:04:14 +00:00
Makoto Kato c0bbdf3d86 Bug 1644737 - Remove NativeCrypto in mozglue. r=mhoye,geckoview-reviewers,agi
NativeCrypto code was used by Firefox sync in Fennec. But since Fennec code
is gone, no one seems to use this.

Differential Revision: https://phabricator.services.mozilla.com/D101458
2021-02-15 05:59:14 +00:00
Csoregi Natalia b32d4ca055 Backed out 4 changesets (bug 1678618) for node failures. CLOSED TREE
Backed out changeset e714440f6c0d (bug 1678618)
Backed out changeset ae83fda183dd (bug 1678618)
Backed out changeset bef0ea72ded8 (bug 1678618)
Backed out changeset ec96259a3f81 (bug 1678618)
2021-02-15 05:49:54 +02:00
Daisuke Akatsuka 8a680848fe Bug 1678618: Avoid firing extra events in NewTabUtils. r=mak
Depends on D101118

Differential Revision: https://phabricator.services.mozilla.com/D101119
2021-02-15 02:47:39 +00:00
Daisuke Akatsuka d41c3d5379 Bug 1678618: Remove onDeleteURI and onDeleteVisits from nsINavHistoryObserver. r=mak
Depends on D101115

Differential Revision: https://phabricator.services.mozilla.com/D101118
2021-02-15 02:47:39 +00:00
Daisuke Akatsuka 687e052ffb Bug 1678618: Apply page-removed event. r=mak
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 02:47:38 +00:00
Daisuke Akatsuka a0b93f756d Bug 1678618: Imlement a mechanism to fire page-removed event. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D101114
2021-02-15 02:47:37 +00:00
Zibi Braniecki 067730d042 Bug 1692064 - Add Histogram Telemetry on main UI localization times. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D104783
2021-02-13 20:10:35 +00:00
Markus Stange f10c2349be Bug 1692540 - Use -[NSString UTF8String] in GetObjCExceptionInfo to skip two conversions. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D105048
2021-02-13 17:08:51 +00:00
Bogdan Tara dfc38e80e0 Backed out changeset 11c143ff4c3f (bug 1692064) for test_telemetry.html failures CLOSED TREE
DONTBUILD
2021-02-13 15:13:24 +02:00
Zibi Braniecki 058b563c00 Bug 1692064 - Add Histogram Telemetry on main UI localization times. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D104783
2021-02-13 12:36:51 +00:00
Bogdan Tara 5a8a0d9f6b Backed out changeset 6ed0ffc2329d (bug 1692064) for test_telemetry.html failures CLOSED TREE 2021-02-13 14:04:59 +02:00
Jonathan Kew 0e5bbc3675 Bug 1689270 - Extend data collection for font-selection telemetry probes. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D104762
2021-02-13 11:23:15 +00:00
Zibi Braniecki 639e9734da Bug 1692064 - Add Histogram Telemetry on main UI localization times. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D104783
2021-02-13 11:06:31 +00:00
Gabriele Svelto 899bbd9e5a Bug 1681842 - Reduce the size of the bufer used for parsing /proc/meminfo and handle error conditions more gracefully r=KrisWright
When the main process crashes /proc/meminfo is being read from within an
exception handler with an alternate signal stack of only 16KiB. The buffer we
used was 10KB which might cause overflows on certain devices. When it happened
a new exception would be triggered causing a deadlock in the exception handler
which does not support recursive exception handling.

Differential Revision: https://phabricator.services.mozilla.com/D104980
2021-02-13 07:13:29 +00:00
Gijs Kruitbosch 23c1d25676 Bug 1685313 - fix tests to pass with either the new or old window modal dialogs, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104703
2021-02-12 22:41:54 +00:00
Gijs Kruitbosch b0c70ac17d Bug 1685313 - allow window modal dialogs to display inside windows, r=jaws,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D103388
2021-02-12 22:41:53 +00:00
Sebastian Hengst 47c58c274b Bug 1692595 - assign resistfingerprinting directories to Bugzilla component "Core :: Privacy: Anti-Tracking". r=timhuang DONTBUILD.
New intermittent bugs get filed into the bugzilla component defined in the
moz.build file.

Differential Revision: https://phabricator.services.mozilla.com/D105070
2021-02-12 21:53:18 +00:00
Mihai Alexandru Michis 9154148880 Backed out 4 changesets (bug 1690167) for causing cppunit failures in TestIntegerPrintfMacros.
CLOSED TREE

Backed out changeset 27dee66eba83 (bug 1690167)
Backed out changeset cfffb092a39f (bug 1690167)
Backed out changeset 87b2a2a66fd9 (bug 1690167)
Backed out changeset cac4879f50b4 (bug 1690167)
2021-02-13 00:07:00 +02:00
Mike Hommey 47675f5460 Bug 1690167 - Change VsprintfLiteral/SprintfLiteral to rely on PrintfTarget. r=nika,Gankra,firefox-build-system-reviewers,mhentges
Instead of snprintf.

Because some standalone code uses those functions directly or indirectly,
and PrintfTarget lives in mozglue, they now need to depend on mozglue
instead of mfbt. Except logalloc/replay, which cherry-picks what it
uses.

Differential Revision: https://phabricator.services.mozilla.com/D103730
2021-02-12 20:21:50 +00:00
Mihai Alexandru Michis 0a98aa9782 Backed out changeset d8095eaef5dc (bug 1691755) for causing bc failures in browser_viewsourceprefs.js
CLOSED TREE
2021-02-12 21:19:56 +02:00
Kagami Sascha Rosylight b97e032178 Bug 1691755 - Move view-source context menu items to nsContextMenu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104956
2021-02-12 18:31:47 +00:00
Butkovits Atila 90f209f9d1 Bug 1654971 - disable browser_toggleMode_2.js on mac os for frequent failures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104911
2021-02-12 18:21:19 +00:00
Julien Cristau b23132a814 Bug 1688966 - Backed out 1 changesets (bug 1669282) for breaking external scheme handlers on flatpak. r=Gijs
We landed this backout on mozilla-release for Firefox 85.0.1, but the
problem is still there in 86/87, so let's get this on trunk since the
regression is worse than the initial issue, and doesn't have a
workaround.

Backed out changeset c37b45058138 (bug 1669282)

Differential Revision: https://phabricator.services.mozilla.com/D104986
2021-02-12 17:09:32 +00:00
Itiel 5590053549 Bug 1689480 - Changes to the print UI checkboxes and radiobuttons to accomodate for the added margin-block r=mstriemer
This also gets rid of the non clickable area between the checkbox/radiobutton and its label.

Differential Revision: https://phabricator.services.mozilla.com/D103397
2021-02-12 17:05:28 +00:00
Itiel beca07c798 Bug 1689480 - Changes to the appchooser/permission dialog checkboxes to accomodate for the added margin-block r=pbz
This also gets rid of the non clickable area between the checkbox and its label.

Differential Revision: https://phabricator.services.mozilla.com/D103400
2021-02-12 17:05:28 +00:00
Itiel 139ae97eac Bug 1689480 - Add vertical clicktarget for in-content checkboxes and radiobuttons r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D103390
2021-02-12 17:05:27 +00:00
Itiel 53756fde5b Bug 1689480 - Changes to about:telemetry checkbox and radiobuttons to accomodate for the added margin-block r=ntim
This also gets rid of the non clickable area between the checkbox/radiobuttons and their label.

Differential Revision: https://phabricator.services.mozilla.com/D103399
2021-02-12 17:05:27 +00:00
Itiel 22f701962b Bug 1689480 - Changes to about:url-classifier checkboxes to accomodate for the added margin-block r=dimi
This also makes the labels themselves clickable, and not just the checkboxes.

Differential Revision: https://phabricator.services.mozilla.com/D103401
2021-02-12 17:05:25 +00:00
Itiel 5cc0ada0fb Bug 1689480 - Changes to about:networking checkbox to accomodate for the added margin-block r=ntim
This also gets rid of the non clickable area between the checkbox and its label.

Differential Revision: https://phabricator.services.mozilla.com/D103398
2021-02-12 17:05:25 +00:00