7bf2f630e4
Bug 1126808: Mark xpcom/build as FAIL_ON_WARNINGS. r=froydnj
2015-01-29 00:38:15 -08:00
4d7c72cbf7
Bug 1126546 - Make PLDHashTable::keyHash private. r=froydnj.
...
As well as renaming and privatizing |keyHash|, this patch also:
- renames GetKeyHash() to ComputeKeyHash(), which better indicates it's not
some kind of getter function; and
- makes PLDHashEntryStub inherit from PLDHashEntryHdr, for consistency with
everywhere else.
2015-01-28 21:33:38 -08:00
72ede6c1ec
Bug 1126923: #undef HAVE_STDINT_H (provided by mozilla-config.h) before including vpx headers, since they redefine it. r=froydnj
2015-01-28 19:01:46 -08:00
2ebbf80a47
Bug 1126985 Fix xpcom/base build with --enable-warnings-on-errors. r=froydnj
2015-01-28 15:11:18 -05:00
7707190851
Bug 1126790: Move MainThreadIOLoggerImpl into anonymous namespace (joining a type used in one of its fields), to fix gcc warning. r=froydnj
2015-01-28 09:40:28 -08:00
7f17f40494
Bug 1124973 (part 7) - Remove PL_DHashTableLookup. r=froydnj.
...
This patch:
- Removes PL_DHashTableLookup().
- Removes PL_DHASH_ENTRY_IS_BUSY(). It's barely used and
PL_DHASH_ENTRY_IS_FREE() suffices.
- Removes a non-useful, non-sequitur comment ("However, use...").
--HG--
extra : rebase_source : 8ee03b52f78e726515902d59af633f9ad015affa
2015-01-26 16:02:05 -08:00
3163cfc2c1
Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
...
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.
For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.
I'll do the trickier ones in subsequent patches.
--HG--
extra : rebase_source : ab37a7a30be563861ded8631771181aacf054fd4
2015-01-22 21:06:55 -08:00
097aa5a98e
Bug 1124973 (part 1) - Always use inheritance rather than composition for PLDHashTable entries. r=froydnj.
...
Because (a) this is how it's usually done, (b) it allows static_cast<> instead
of reinterpret_cast<>, and (c) it will make subsequent patches easier.
--HG--
extra : rebase_source : 76e67d4b6ec0e5dc898a8214b6a6b562f9e08380
2015-01-22 21:05:52 -08:00
c6aaaa4c77
Bug 1124029 - Fix 64bit shift warning in nsVoidArray. r=froydnj
...
--HG--
extra : source : dba319233ef2df517d3ba37b4406357fb007dec7
extra : histedit_source : 4ad36db364b75ceb3566ef2f48507ad314d2e238
2015-01-28 08:55:44 +11:00
e08ad38a33
Bug 1126301 - Move TestUTF.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestUTF.cpp => xpcom/tests/gtest/TestUTF.cpp
rename : xpcom/tests/UTFStrings.h => xpcom/tests/gtest/UTFStrings.h
extra : rebase_source : 6c08b56d9cdb2af10a436792de7bee03d8c41070
2015-01-27 12:38:44 -05:00
a4a005ae1b
Backed out changeset 186127d71076 (bug 1126295) because of test bustage on Windows on a CLOSED TREE
...
--HG--
rename : xpcom/tests/gtest/TestAtoms.cpp => xpcom/tests/TestAtoms.cpp
rename : xpcom/tests/gtest/UTFStrings.h => xpcom/tests/UTFStrings.h
2015-01-27 13:47:44 -05:00
39a6fe9c60
Backed out 2 changesets (bug 1126301) on a CLOSED TREE because the test was apparently busted on some platforms
...
Backed out changeset 4aecd46afeb1 (bug 1126301)
Backed out changeset c61a87a20888 (bug 1126301)
--HG--
rename : xpcom/tests/gtest/TestUTF.cpp => xpcom/tests/TestUTF.cpp
2015-01-27 13:44:15 -05:00
18a949c894
Bug 1126301 follow-up: Fix a signed/unsigned comparison fatal warning, landed on a CLOSED TREE
2015-01-27 12:56:15 -05:00
98fd7110d5
Bug 1125632 followup: Mark remaining CollectReports impls in nsMemoryReporterManager.cpp and SystemMemoryReporter.cpp as MOZ_OVERRIDE.
2015-01-27 09:48:54 -08:00
313bd50abd
Bug 1126301 - Move TestUTF.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestUTF.cpp => xpcom/tests/gtest/TestUTF.cpp
extra : rebase_source : db5e0418f89bb1cf71a0543a48a6a063f61e4033
2015-01-27 12:38:44 -05:00
6fd135f8ae
Bug 1126295 - Move TestAtoms.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestAtoms.cpp => xpcom/tests/gtest/TestAtoms.cpp
rename : xpcom/tests/UTFStrings.h => xpcom/tests/gtest/UTFStrings.h
extra : rebase_source : 16340d826f39339dd38e77810cd08e59b324c380
2015-01-27 09:28:45 -05:00
48710afc66
Bug 1124920 - Remove PLDHashTable::Operate(). r=froydnj.
...
--HG--
extra : rebase_source : f029d3ca8835232b3c1d4188aa63a0004c1aad4b
2015-01-22 15:43:18 -08:00
1ac680d086
Bug 1125138 - Move TestTimeStamp.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestTimeStamp.cpp => xpcom/tests/gtest/TestTimeStamp.cpp
extra : rebase_source : d6f92fb8be26504164a1b54bd40811f6f1c3cc3a
extra : source : 67496f44f4617eda8f650d5c801fd9b327e5ac96
2015-01-26 17:08:24 -05:00
2da1f21a45
Bug 1125665 - Fix -Wunused-private-field warning in PLDHashTable and mark xpcom/glue as FAIL_ON_WARNINGS. r=froydnj
2015-01-25 00:25:13 -08:00
7251d442c0
Bug 1125693 - Fix -Wformat warning in xpcom/base/nsStackWalk.cpp and mark as FAIL_ON_WARNINGS. r=njn
2015-01-25 13:49:06 -08:00
1ff610e6bd
Bug 1125559 - Move TestThreadPool.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestThreadPool.cpp => xpcom/tests/gtest/TestThreadPool.cpp
extra : amend_source : 9d779a219338a8cbf854af28070ddc5559d28d2b
extra : histedit_source : 59dd08d1722b1fe621f3d5070b64d791012fa026%2C5231f875b1e958f393079ac9258a2d3812a1feb1
2015-01-26 20:49:22 -05:00
878e2e5f26
Backed out changeset 67496f44f461 (bug 1125138) for checktest failures
...
--HG--
rename : xpcom/tests/gtest/TestTimeStamp.cpp => xpcom/tests/TestTimeStamp.cpp
2015-01-26 16:14:06 -08:00
1f45146bdb
Backed out changeset 8ae4f78d7e25 (bug 1125559) for checktest orange
...
--HG--
rename : xpcom/tests/gtest/TestThreadPool.cpp => xpcom/tests/TestThreadPool.cpp
2015-01-26 15:18:50 -08:00
87ec49dc6f
Bug 1125559 - Move TestThreadPool.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestThreadPool.cpp => xpcom/tests/gtest/TestThreadPool.cpp
extra : amend_source : 08b95083290e67062ebaecff820ff627f87b35a2
2015-01-26 17:10:09 -05:00
e6a83f6014
Bug 1125138 - Move TestTimeStamp.cpp to gtest and enable it; r=froydnj
...
--HG--
rename : xpcom/tests/TestTimeStamp.cpp => xpcom/tests/gtest/TestTimeStamp.cpp
2015-01-26 17:08:24 -05:00
cdc6637443
Bug 1124029 - Suppress different __unaligned qualifiers warnings. r=froydnj
...
--HG--
extra : source : e854844083bcb065d649eea337c558f05291a647
extra : histedit_source : 9563e1ccb80018ade7b7f21f563bdf6954f13e35
2015-01-27 08:37:38 +11:00
8ccda8f49a
Bug 1125632: Annotate ResidentUniqueReporter::CollectReports as MOZ_OVERRIDE. r=njn
2015-01-25 15:14:00 -08:00
6cc5dabbee
Bug 1111290 - Part 3: Remove TypedEnum.h and fold TypedEnumInternal.h into TypedEnumBits.h. r=waldo
2015-01-26 07:22:11 +09:00
86502e6537
Bug 1111290 - Part 2: Non-mechanical changes. r=waldo
2015-01-26 07:22:08 +09:00
516bfc595a
Bug 1092525 - Enable e10s for Windows systems that activate accessibility through UIA. r=trev
2015-01-23 15:41:55 -06:00
66ad9a2e49
Bug 1125356 - Use JS_NewPlainObject in the browser. r=bz
2015-01-24 16:38:08 +01:00
f4b09875cf
Bug 1125179 - Mark some functions generated by CC macros as override; r=mccr8
2015-01-23 14:27:18 -05:00
9cfc822740
Remove TestTArray from the list of disabled XPCOM tests, because it's not disabled, no bug, DONTBUILD
2015-01-23 09:38:42 -05:00
fbdef879d2
merge mozilla-inbound to mozilla-central a=merge
2015-01-22 14:30:51 +01:00
e77e679f44
Bug 675372 - Allow resource protocol mappings in chrome.manifest files of bootstrapped add-ons; r=Unfocused
2015-01-22 20:00:13 +13:00
c9abc4481d
Bug 1124048 - Move TestStorageStream.cpp to gtest and enable it; r=froydnj
2015-01-21 11:29:20 -05:00
5fc1133195
Bug 1124047 - Move TestPriorityQueue.cpp to gtest and enable it; r=froydnj
2015-01-21 11:25:34 -05:00
acfa245a0a
Bug 1124041 - Move TestPipes.cpp to gtest and enable it; r=froydnj
2015-01-21 11:21:10 -05:00
9656ec51c3
Bug 895582 - Get rid of MOZ_ENUM_TYPE. r=waldo
2015-01-21 22:35:19 +09:00
60cb268efa
Bug 1121970 - Debug output from printf_stderr gets clipped on Windows. r=nfroyd
2015-01-20 08:18:26 -06:00
de6c8e779d
Bug 1123007 - Mark ReadSegmentsClosure as stack class, and its mRealInputStream member as nsCOMPtr; r=froydnj
2015-01-21 22:42:39 -05:00
3b12706421
Bug 1123014 - Mark the nsWriteSegmentThunk as stack class, and its mStream member as nsCOMPtr; r=froydnj
2015-01-21 22:42:39 -05:00
6c67942f1f
Bug 1123004 - Mark ReadSegmentsState as stack class, and its mThisStream member as nsCOMPtr; r=froydnj
2015-01-21 22:42:38 -05:00
1159fbcef9
Bug 1124058 - Move TestSynchronization.cpp to gtest and enable it; r=froydnj
2015-01-21 22:42:38 -05:00
c9ef92b837
Bug 1120495 - Don't assert if FinishAnyCurrentCollection reenters during CleanupPhase. r=smaug
2015-01-21 14:35:54 -08:00
af2a8de28a
Bug 1123533 - Clarify thread handling in NS_StackWalk() on Windows. r=ehsan.
...
- The way NS_StackWalk() sets up |targetThread| and |data.walkCallingThread| is
hard to read.
- The name |shouldBeThreadSafe| is unclear -- for a long time I thought it
meant "we are thread-safe, so we can print" and I thought it was named
incorrectly. But now I see it actually means the opposite, i.e. "we need to
be thread-safe, so we can't print". So |needToBeThreadSafe| would be
clearer...
- ...but |shouldBeThreadSafe| shouldn't be used anyway, because
|data.walkCallingThread| is better -- it correctly handles the case where
|aThread| is the current thread -- and it's what WalkStackMain64() uses.
This patch fixes these problems.
--HG--
extra : rebase_source : f1310f72db1e10c25e77af54a1d6df4114e59314
2015-01-19 19:19:55 -08:00
2116ab605f
Bug 1123151 (part 3) - Make PLDHashTable::ops private. r=froydnj.
...
This required adding a getter and a setter, but they're used sparingly.
--HG--
extra : rebase_source : 2a40e459de2a7a9e2bb6d65b046e4a920b212326
2015-01-19 16:34:44 -08:00
8bd1f6f072
Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
...
This encapsulates most of the uses of PLDHashTable::ops.
--HG--
extra : rebase_source : 7760ce8e46a37e87dcfe590e809a21df01fe510f
2015-01-19 16:11:34 -08:00
bd573c9b9c
Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
...
Currently the setting of PLDHashTable::ops is very haphazard.
- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
null it themselves.
- In the fallible PLDHashTable::Init() function, if the entry storage
allocation fails we'll be left with a table that has |ops| set -- indicating
it's been initialized -- but has null entry storage. I'm not certain this can
cause problems but it feels unsafe, and some (but not all) callers of Init()
null it on failure.
- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
do this themselves.
This patch makes things simpler.
- It adds a constructor that zeroes |ops|.
- It modifies Init() so that it only sets |ops| once success is ensured.
- It zeroes |ops| in Finish().
- Finally, it removes all the now-unnecessary |ops| nulling done by the users
of PLDHashTable.
--HG--
extra : rebase_source : bb34979c218d152562a2f9c7e5215256c111cc5b
2015-01-19 16:01:24 -08:00
6c486b0407
bug 1122100 - more MOZ_OVERRIDE in xpcomish stuff r=froydnj
2015-01-19 17:41:12 -05:00
Daniel Holbert
Nicholas Nethercote
Ben Kelly
Xidorn Quan
Ehsan Akhgari
Chris Peterson
Wes Kocher
Masatoshi Kimura
Jim Mathies
Tom Schuster
Carsten "Tomcat" Book
Geoff Lankow
Andrew McCreight
Trevor Saunders