Automatic update from web-platform-tests
Don't serialize closed shadow roots with getInnerHTML()
This CL corrects the behavior of getInnerHTML() so that closed
shadow roots are not serialized. It also adds a test of the
getInnerHTML() function.
Bug: 1042130
Change-Id: Iac214b16799cee45bcd90be8f618cc5560eb1db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166383
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763236}
--
wpt-commits: c88ed219c1a65af9f83844181b84111e9462f8b6
wpt-pr: 23243
Automatic update from web-platform-tests
[css-speech] rename Integer.html to voice-family-integer.html (#23060)
Renamed because it's one of few tests with capitalized filenames.
--
wpt-commits: b5e6c40a2bd4c4ae8bd64dad3f3732c023f150b4
wpt-pr: 23060
Automatic update from web-platform-tests
[FragmentItem] Prevent dangling LayoutObject ptrs in block fragmentation.
NGInlineCursor doesn't work with block fragmentation, so we'd end up
with NGFragmentItem objects with dangling pointers to LayoutObject. To
fix this, perform a full walk through all fragment items in all
fragments, if it's likely that we're in block fragmentation.
CL:2152824 caused two tests to crash because of this, and it therefore
got reverted. Add another test now, which would also crash without the
aforementioned CL.
Bug: 1075517
Change-Id: I97e2fae63d89031ea258ba146898e7fcfe56bd45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165800
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763233}
--
wpt-commits: e9ed833d0c9483012493d839434137de7e7ba00d
wpt-pr: 23279
Automatic update from web-platform-tests
Treat floorOrigin as mojoFromFloor
Per the webxr-test-api all origins are based on the "local" space when
the "session" started; which means that all of our origins passed in are
inherently "mojoFromFoo." The standingTransform (in need of renaming)
is, in blink and by devices, floorFromMojo. Since the tests were
directly setting floorOrigin to the standingTransform, the tests were
incorrectly treating floor origin as floorFromMojo. This change inverts
the floorOrigin before assigning it to the standingTransform, so that
Chrome begins treating the floorOrigin as mojoFromFloor. Given that
Chrome was the only ones running these particular tests, the output
values were *also* written as if the passed in floorOrigins were
floorFromMojo. In order to stick with the expectations, this inverts
the input transforms as well.
In fixing this, a bug was discovered in XRMathHelper.inverse wherein the
comatrix was not created properly. This change also addresses that bug.
Fixed:1071630
Change-Id: I1626d80099169c4ceba0df68ad84bbf181f76647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165881
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763104}
--
wpt-commits: 6a2f0e6a0110fd0830fc3196680f671bb83c2747
wpt-pr: 23272
Automatic update from web-platform-tests
Adds slotchange event for Imperative Slot API.
Prior to this CL slotchange event is not fired when calling the
Imperative Slot API.
This CL adds the ability to fire slotchange event for Imperative Slot
API. It does so by detecting candidates nodes changed during the
call and fires slotchange event if changed. This CL only implements the
assign() function's portion of the slotchange event. In the next CL,
I will implement slotchange event for removing nodes and slots.
Bug: 869308
Change-Id: I13851d1788fc6cf8b0ea109fb136a2f029e61e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161369
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763111}
--
wpt-commits: ff47fb409e6e7ef72893ec6123f6abde845372db
wpt-pr: 23181
Automatic update from web-platform-tests
[wpt] enhanceents to check-layout-th.js (#23184)
There are 3 enhancements that I've found useful.
1. Warn if there are any unexpected data-* attributes
A common error is to have a typo in data-* attribute name.
When this happens, test will pass, because attribute is never read.
This enhancement prints a warning if unexpected attribute is found.
Running this over the entire test suite, I've found several errors:
css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001.html
css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-001.html
css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html
css/css-grid/grid-items/grid-items-relative-offsets-001.html
css/css-grid/grid-items/grid-items-relative-offsets-002.html
have data-expected-x, data-expected-y
Tried replacing some of these with data-offset-x, and tests fail.
css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002
has data-offset-top
2. highlight error on failure flag. Defaults to false.
If set, this flag will draw an outline around failed Element.
Useful when debugging pages with many elements.
3. toggle printing dom on error.
Sometimes, it is useful not to print dom on error for clarity.
Change-Id: I8424aa2dc002f63fde18d0fc54bdfe77666ce951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161379
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763069}
Co-authored-by: Aleks Totic <atotic@chromium.org>
--
wpt-commits: a5a3b7353c884ebcca0230818632a42ad2fbd9b2
wpt-pr: 23184
Automatic update from web-platform-tests
Effective Touch Action when <body> is the viewport defining element
When <body> is deemed to be the viewport defining element <body>'s
overflow needs to be set to visible. Because of this, during effective
touch action calculation we consider <body> to be a scroller when it is
not.
The fix attempts to detect when <body> is deemed the viewport defining
element and correct the effective touch action calculation.
Bug: 1031745
Change-Id: Ie9a3c966af78fdbe0dc3e57f3f192aca9110fd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152950
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763147}
--
wpt-commits: 1650a7c1569ad9e3e10bc1da400f9a44230a5a78
wpt-pr: 23216
Automatic update from web-platform-tests
Improve web engine detection in webxr_util.js (#23200)
The check (window.XRTest === undefined) is not valid to discriminate between Chromium and other browsers. Improve engine detection so that we don't end up accessing entities that do not exist in other engines (like navigator.xr.test.Debug).
--
wpt-commits: d9312410d445b129727af4fbd4aa8733e99b0e64
wpt-pr: 23200
Automatic update from web-platform-tests
*.any.js: explicitly list defaults, part 1 (#23117)
* *.any.js: explicitly list defaults, part 1
Helps with #23111.
* add a couple more
--
wpt-commits: e1e713c842e54ea0a9410ddc988b63d0e1d31973
wpt-pr: 23117
Automatic update from web-platform-tests
[wptserve] Fix an exception handler in stash
internal_key is a tuple whose items are guaranteed to be strings.
It should be used as the key directly.
--
wpt-commits: d2025b24b0b1f4d2e69e83cf83e60c021d9f7b42
wpt-pr: 23257
Automatic update from web-platform-tests
UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers
This CL adds upgrade-insecure-request wpts to test static-import from
dedicated workers and shared workers.
The test scheme is implemented in the previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2102036.
This CL only removes 'worker-import' and 'sharedworker-import' from
the excluded subresource list in spec.src.json and auto-generates tests.
Bug: 989399
Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#753164}
--
wpt-commits: 19a0095b86b988a1afa5833c691a102ccde8cd68
wpt-pr: 22420
Automatic update from web-platform-tests
Fix report-to CSP directive to only allow one endpoint
According to https://w3c.github.io/webappsec-csp/#directive-report-to,
the Content-Security-Policy directive "report-to" should only accept one
token (endpint). However, our previous implementation allowed several
endpoints to be specified.
Bug: 916265
Change-Id: Ie11ee736f577d015921a5291824dcedcbc790177
Fixed: 916265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162826
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762813}
--
wpt-commits: fa3d5b0da213daee43f5de9621a26984ef70d149
wpt-pr: 23230
Automatic update from web-platform-tests
FindKeyframesRules should use originating element.
It's only using the TreeScope to find @keyframes in which case using the
originating element for pseudo elements should work. Even better when
the originating element is a shadow host, so that we look up :host rules
from the shadow tree for :host::before { animation-name: anim }.
Bug: 961941
Change-Id: I38edec156eaaa7cfb3680762b135323deae00a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162988
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762791}
--
wpt-commits: 245ed57a5e400fff2dc4adbf8e452d64397399cd
wpt-pr: 23222
Automatic update from web-platform-tests
Forward CSP, even for the initial empty document.
Bug 1064676 has been fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/2111170
And tested by:
https://chromium-review.googlesource.com/c/chromium/src/+/2144012
The bug was fixed for every CSP checked in the renderer process. However
there are still an issue for the one checked in the browser process. It
turns out the CSP in the initial empty document weren't properly
propagated to the browser process.
This patch:
1) Fix the bug by sending the CSP of the initial empty document.
2) Add a regression test (WPT).
This patch can potentially also fix:
- https://crbug.com/1072719
- https://crbug.com/955350
(I haven't checked. I will do it later after landing this patch)
Bug: 1064676, 1072719, 955350
Change-Id: Ie5325035c74d9e2476d6c80af3e5d5c9068ea928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159242
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762769}
--
wpt-commits: 7179786e28b8266789355518b65b8df65aa962c2
wpt-pr: 23144
Automatic update from web-platform-tests
Migrate pointerevents/mouse-on-object.html to wpt
The expected behavior on this test seems to be a
hack as it implicitly captures mouse to the object
and still sends the mouseup/pointerup to the object
when down happened on the object even though up is
happening outside of the object. This seems to
resolving compat issues on embedded flash objects.
Change-Id: Ibd888a989dbcf5e6ff08b35569903967edc957e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160142
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762476}
--
wpt-commits: 55367a4c706fa32301980773cb2c09cbcd291635
wpt-pr: 23174
Automatic update from web-platform-tests
for larger tables on mobile, you have to wrap in a div
and set overflow to auto so that they'll scroll the div instead of the window
--
wpt-commits: 5e7cbed423a3040dc8ca50359dd033a46dba5cf4
wpt-pr: 23254
Automatic update from web-platform-tests
[device-orientation] Simplifies tests by using EventWatcher
This CL simplifies wpt/orientation-event tests by using
testharness.js' `EventWatcher` to replace existing customized
`waitForEvent` method and improving event comparison methods.
Uses `setGetSensorShouldFail` to simulate UA can not provide
sensor information for orientation/deviceorientationabsoluteevent.https.html,
and merges which into orientation/basic-operation-absolute.https.html.
Bug: 816462
Change-Id: Ia7bf83cb9401265722e472ccdd01adc114eff660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154389
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#762675}
--
wpt-commits: 44915d53e1747700990f4f03442040e59cd2da19
wpt-pr: 23100
Automatic update from web-platform-tests
Implement and ship 'ruby-position' CSS property
This CL implements 'ruby-position' CSS property, which is a property
independent from the existing '-webkit-ruby-position', but these
properties share a single ComputedStyle field.
We apply neither legacy name alias [1] nor legacy shorthands [2] because
- Acceptable keyword sets are different in ruby-position and
-webkit-ruby-position.
- Avoid behavior changes with |element.style.webkitRubyPosition =
'after'|.
* core/css/css_computed_style_declaration.cc
Add 'ruby-position' to getComputedStyle() enumeration.
* core/css/parser/css_parser_fast_paths.cc
Add setting for fast-path parsing
* core/css/properties/longhands/longhands_custom.cc
Add CSSValueFromComputedStyleInternal() to translate a ComputedStyle::
GetRubyPosition() value to 'over' or 'under'.
* core/css/resolver/style_builder_converter.{h,cc}
Add a function to convert a parsed CSS keyword to a
blink::RubyPosition value.
* web_tests/external/wpt/css/css-ruby/ruby-position.html
New test to check ruby annotation position.
* web_tests/fast/ruby/ruby-position-om.html
New test to check relationship between ruby-position and
-webkit-ruby-position.
Approved intent: https://t.co/nmCPv0Onhk
[1] https://drafts.csswg.org/css-cascade/#legacy-name-alias
[2] https://drafts.csswg.org/css-cascade/#legacy-shorthand
Bug: 196690
Change-Id: I2f00099f90a2222b7ddba8b58c3a532f3b997744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152569
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762664}
--
wpt-commits: ae457cd8b39790508e841f581e2066871859db1a
wpt-pr: 23221
Automatic update from web-platform-tests
Update two SVG tests to be consistent between browsers (#23240)
svg/import/pservers-grad-08-b-manual.svg:
This test renders some text using a font that doesn't contain the space glyph.
However, the content contains the space character, and doesn't specify a fallback
font. This means that different browsers on the same OS will pick different
fallback fonts, causing different renderings. Instead, the test should be updated
to specify a fallback font, which makes browsers render it consistently.
imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual.svg:
Similarly, this test renders text with a font that doesn't support those characters.
(It does it using <altGlyph>, but support for <altGlyph> has been removed in SVG 2.0
and neither Safari nor Firefox support it.) A fallback font should be supplied to the
test to get consistent renderings across browsers.
Co-authored-by: Myles C. Maxfield <mmaxfield@apple.com>
--
wpt-commits: 51151cf5bfc32adb8d96fca51a30c126d1e0200d
wpt-pr: 23240
Automatic update from web-platform-tests
bluetooth: Split bluetooth-helpers.js
This change splits the bluetooth-helpers.js files in two. The new
bluetooth-test.js file contains methods for setting up the web tests and
for asserting conditions. The bluetooth-helpers.js file now contains
helper methods that set up fake Bluetooth devices for use in the Web
Bluetooth tests.
I added JsDoc style comments to the helper methods to make it clear
what kinds of objects are expected as parameters and what the methods
will return. I also reordered the bluetooth-helpers.js methods so that
they are defined before they are used.
Bug: 1070816
Change-Id: Ib5215555be2b24b11f8dea9098d83ad69719a284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149909
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: James Hollyer <jameshollyer@google.com>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762594}
--
wpt-commits: 6f8f0b30a4af91762427b4ff528ed344d5636c6d
wpt-pr: 23157
moz-wptsync-bot
Yi Xu
Mason Freed
Philip Jägenstedt
Morten Stenshorne
Alexander Cooper
Yu Han
Blink WPT Bot
Makoto Shimazu
Arnaud Mandy
Liviu Tinta
Navid Zolghadr
Sergio
autofoolip
Anne van Kesteren
Rimas Misevičius
Robert Ma
Eriko Kurimoto
Antonio Sartori
Ingvar Stepanyan
Stephen McGruer
Rune Lillesveen
arthursonzogni
Anthony Frehner
Wanming Lin
Kent Tamura
Myles C. Maxfield
Ovidio Henriquez