Julian Descottes
f7b11c4769
Bug 1790473 - [remote] Remove remote/.eslintrc.js r=webdriver-reviewers,whimboo
...
Depends on D158298
Differential Revision: https://phabricator.services.mozilla.com/D158299
2022-09-30 11:08:09 +00:00
Julian Descottes
5db63c4432
Bug 1790473 - [cdp] Convert /remote/cdp JSM modules to ESM r=webdriver-reviewers,whimboo
...
Depends on D158297
Differential Revision: https://phabricator.services.mozilla.com/D158298
2022-09-30 11:08:09 +00:00
Julian Descottes
3635b10bad
Bug 1790472 - [bidi] Convert /remote/webdriver-bidi JSM modules to ESM r=webdriver-reviewers,whimboo
...
Depends on D158296
Differential Revision: https://phabricator.services.mozilla.com/D158297
2022-09-30 11:08:08 +00:00
Julian Descottes
4a1ddfd485
Bug 1790471 - [marionette] Convert /remote/marionette JSM modules to ESM r=webdriver-reviewers,whimboo
...
Depends on D158295
Differential Revision: https://phabricator.services.mozilla.com/D158296
2022-09-30 11:08:08 +00:00
Julian Descottes
bf82c5039a
Bug 1790468 - [remote] Convert /remote/server JSM modules to ESM r=webdriver-reviewers,whimboo
...
Depends on D158294
Differential Revision: https://phabricator.services.mozilla.com/D158295
2022-09-30 11:08:07 +00:00
Julian Descottes
b24d46c99d
Bug 1790468 - [remote] Convert /remote/components JSM modules to ESM r=webdriver-reviewers,whimboo
...
Depends on D158293
Differential Revision: https://phabricator.services.mozilla.com/D158294
2022-09-30 11:08:07 +00:00
Julian Descottes
d1f7dbe55e
Bug 1790468 - [remote] Convert /remote/shared JSM modules to ESM r=webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D158293
2022-09-30 11:08:06 +00:00
Butkovits Atila
539f87fe4f
Backed out changeset 3e220bf19d7b (bug 1141335) for causing failures at awsy/test_memory_usage.py. CLOSED TREE
2022-09-30 02:12:58 +03:00
Henrik Skupin
932d46b87f
Bug 1141335 - [marionette] Use in_app by default for quit() and restart(). r=webdriver-reviewers,jdescottes
...
Hereby the "in_app" argument is required to be specified in case some
other argument eg. "clean" requires a termination of the application.
Differential Revision: https://phabricator.services.mozilla.com/D157219
2022-09-29 18:34:25 +00:00
Mark Banner
8d1ebcb9d6
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Henrik Skupin
d5c7f69016
Bug 1789659 - [remote] Make TabManager.removeTab asynchronous. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D158252
2022-09-28 15:39:23 +00:00
Julian Descottes
895acde24b
Bug 1780005 - [remote] Add more trace logs to ProgressListener r=webdriver-reviewers,whimboo
...
Depends on D158142
Tried to cover all branches so that we know exactly why a progress listener stops or hangs.
Added a #trace private helper for readability.
Differential Revision: https://phabricator.services.mozilla.com/D158143
2022-09-27 13:24:53 +00:00
Julian Descottes
c62ef2f36b
Bug 1763109 - [remote] ProgressListener should not resolve early if waitForExplicitStart is true r=webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D158142
2022-09-27 13:24:52 +00:00
Alexandra Borovova
f32dba0420
Bug 1770754 - [bidi] Support serialization of complex objects with container value fields. r=webdriver-reviewers,jdescottes,whimboo
...
Depends on D157813
Differential Revision: https://phabricator.services.mozilla.com/D157635
2022-09-27 11:31:27 +00:00
Alexandra Borovova
f3094bccfc
Bug 1770754 - [bidi] Add internal ids to the duplicated objects for a given serialization. r=webdriver-reviewers,jdescottes,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D157634
2022-09-27 11:31:26 +00:00
Julian Descottes
f52f1c98c3
Bug 1788861 - [bidi] Deserialization of remote references should not create new objects r=Sasha,webdriver-reviewers,whimboo
...
Depends on D156691
Differential Revision: https://phabricator.services.mozilla.com/D156717
2022-09-20 13:29:50 +00:00
Alexandra Borovova
6ca2b6a083
Bug 1778976 - [bidi] Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels. r=webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D157091
2022-09-20 09:12:51 +00:00
Alexandra Borovova
9f3df6a72a
Bug 1779231
- [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown" r=webdriver-reviewers,jdescottes,whimboo
...
Depends on D156051
Differential Revision: https://phabricator.services.mozilla.com/D156690
2022-09-20 09:12:49 +00:00
Dana Keeler
bdb75eecd3
Bug 1790451 - remove now-unnecessary QueryInterface(Ci.nsITransportSecurityInfo) calls r=jschanck,webdriver-reviewers,necko-reviewers,application-update-reviewers,nalexander,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D157166
2022-09-20 03:58:50 +00:00
Henrik Skupin
1b97aa447f
Bug 1790950 - [remote] Improve logging for Remote Agent protocol messages. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D157431
2022-09-19 19:19:23 +00:00
Henrik Skupin
119e894f82
Bug 1790950 - [marionette] Improve logger output for protocol messages. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D157430
2022-09-19 19:19:22 +00:00
Henrik Skupin
f27030b222
Bug 1790950 - [remote] Remove deprecated Marionette preferences from documentation. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D157428
2022-09-19 19:19:22 +00:00
James Graham
265bbc2061
Bug 1781066 - Disallow missing pointerMove / wheel scroll coordinates, r=webdriver-reviewers,whimboo
...
The spec claims that undefined is allowed for these values, but later
treats them as if they're always integers. I suspect the original
intent was to default to 0, but since there seems to be interop around
rasing an exception, make geckodriver and marionette explicitly check
for valid integers and disallow missing/undefined values.
Differential Revision: https://phabricator.services.mozilla.com/D152645
2022-09-19 16:25:12 +00:00
Butkovits Atila
0a4c1b25bc
Backed out changeset 95bc55ad64d7 (bug 1781066) for causing linting failures. CLOSED TREE
2022-09-14 21:07:02 +03:00
James Graham
90ca0c23d3
Bug 1781066 - Disallow missing pointerMove / wheel scroll coordinates, r=webdriver-reviewers,whimboo
...
The spec claims that undefined is allowed for these values, but later
treats them as if they're always integers. I suspect the original
intent was to default to 0, but since there seems to be interop around
rasing an exception, make geckodriver and marionette explicitly check
for valid integers and disallow missing/undefined values.
Differential Revision: https://phabricator.services.mozilla.com/D152645
2022-09-14 17:48:17 +00:00
Alexandra Borovova
87706fdb4e
Bug 1766240 - [bidi] Implement "script.getRealms" command. r=webdriver-reviewers,jdescottes,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D156049
2022-09-12 12:35:19 +00:00
Henrik Skupin
fd1f1425ea
Bug 1506782 - [remote] Add support for opening and closing tabs on Android. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D156746
2022-09-09 11:58:45 +00:00
Henrik Skupin
16d96ac3fd
Bug 1789357 - [remote] Make AppInfo a shared class for remote protocols. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D156745
2022-09-09 11:58:44 +00:00
Marian-Vasile Laza
27fd1e9739
Backed out 2 changesets (bug 1789357, bug 1506782) for causing xpcshell failures on test_Capabilities.js. CLOSED TREE
...
Backed out changeset 144d4be497c6 (bug 1506782)
Backed out changeset 0884729fca31 (bug 1789357)
2022-09-09 12:34:02 +03:00
Henrik Skupin
f747c73194
Bug 1506782 - [remote] Add support for opening and closing tabs on Android. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D156746
2022-09-09 08:55:33 +00:00
Henrik Skupin
3246749215
Bug 1789357 - [remote] Make AppInfo a shared class for remote protocols. r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D156745
2022-09-09 08:55:33 +00:00
James Graham
0f8a84132a
Bug 1746601 - Implement wheel input support in marionette, r=webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D139123
2022-09-08 13:45:22 +00:00
Alexandra Borovova
c9433699f7
Bug 1756619 - [bidi] Implement "browsingContext.load" event. r=webdriver-reviewers,jdescottes,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D155820
2022-09-06 08:11:54 +00:00
Julian Descottes
584c2ea03d
Bug 1770740 - [bidi] Implement "script.disown" command r=webdriver-reviewers,Sasha,whimboo
...
Depends on D155522
Differential Revision: https://phabricator.services.mozilla.com/D155634
2022-09-05 08:53:15 +00:00
Julian Descottes
84dec7594d
Bug 1763137 - [messagehandler] Filter events based on context descriptor used to subscribe to them r=webdriver-reviewers,whimboo
...
Depends on D155070
Differential Revision: https://phabricator.services.mozilla.com/D155243
2022-09-02 12:04:15 +00:00
Julian Descottes
5bb89bff06
Bug 1762334 - [messagehandler] Use EventsDispatcher in session module r=webdriver-reviewers,whimboo
...
Depends on D155062
Some additional corrections had to be made on the EventsDispatcher module at the same time.
Differential Revision: https://phabricator.services.mozilla.com/D155070
2022-09-02 12:04:14 +00:00
Julian Descottes
a06ffb598a
Bug 1762334 - [messagehandler] Remove _subscribe/_unsubscribeEvent commands in favor of SessionData r=webdriver-reviewers,whimboo
...
Depends on D155061
All events now only react to SessionData and the session module can directly add/remove session data instead of using internal commands.
In the next patch, it will start relying on EventsDispatcher directly.
Differential Revision: https://phabricator.services.mozilla.com/D155062
2022-09-02 12:04:14 +00:00
Julian Descottes
fb6fa92fdf
Bug 1788124 - [bidi] Deserialize remote values with handle field r=webdriver-reviewers,whimboo
...
Depends on D155446
With this you can retrieve a remote value with a handle from script.execute and then use it in your next call to script.callFunction
Differential Revision: https://phabricator.services.mozilla.com/D155522
2022-08-31 22:59:31 +00:00
Julian Descottes
d3b9951dbf
Bug 1783820 - [bidi] Add resultOwnership support for script.evaluate and script.callFunction r=webdriver-reviewers,Sasha,whimboo
...
Depends on D156121
Differential Revision: https://phabricator.services.mozilla.com/D155446
2022-08-31 22:59:31 +00:00
Julian Descottes
af63f4ed2c
Bug 1783820 - [bidi] Add a RemoteValue class to hold data for serialized values r=webdriver-reviewers,whimboo
...
Depends on D155862
Differential Revision: https://phabricator.services.mozilla.com/D156121
2022-08-31 22:59:30 +00:00
Julian Descottes
8a7d5bbaaf
Bug 1783820 - [bidi] Create handle in RemoteValue.serialize if ownershipType is root r=webdriver-reviewers,whimboo
...
Depends on D155632
Differential Revision: https://phabricator.services.mozilla.com/D155862
2022-08-31 22:59:30 +00:00
Julian Descottes
9a69a3180a
Bug 1783820 - [bidi] Fix errors lazy imports in RemoteValue r=webdriver-reviewers,whimboo
...
Depends on D155445
The test was only passing because the error thrown was "InvalidArgumentError is not a constructor"
Differential Revision: https://phabricator.services.mozilla.com/D155632
2022-08-31 22:59:29 +00:00
Julian Descottes
a13c398666
Bug 1770736 - [bidi] Add an object reference map to the Realm class r=webdriver-reviewers,Sasha,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D155445
2022-08-31 22:59:29 +00:00
Julian Descottes
6f2ab5a719
Bug 1786255 - [messagehandler] Use session data to subscribe to browsingContext.contextCreated r=webdriver-reviewers,whimboo
...
Depends on D155060
The _subscribe/_unsubscribeEvent can be removed in the next patch
Differential Revision: https://phabricator.services.mozilla.com/D155061
2022-08-30 11:53:47 +00:00
Julian Descottes
d4bc15c1be
Bug 1786255 - [messagehandler] Apply session data to Root layer modules r=webdriver-reviewers,whimboo
...
Depends on D155059
In order for all events to really use similar codepaths, they should not use different subscription mechanism.
Setting an event in SessionData should be the entry point for all modules to decide to update their listeners or not.
Therefore we will also call _applySessionData on root modules which support this.
Next patch will start using this for the browsingContext.contextCreated event.
Differential Revision: https://phabricator.services.mozilla.com/D155060
2022-08-30 11:53:47 +00:00
Julian Descottes
c2b9c6fa6a
Bug 1786255 - [messagehandler] RootMessageHandler _applySessionData should return the session data update r=webdriver-reviewers,whimboo
...
The current version returns the return value of the command (which can be a broadcast, depending on the provided descriptor).
This makes it impossible to know what to consistently expect as a return value.
It seems it was only used for a test assertion, so rewrite the test and cleanup the return value
Differential Revision: https://phabricator.services.mozilla.com/D155059
2022-08-30 11:53:47 +00:00
Geoff Lankow
f8a55c3c79
Bug 1787081 - Remove Thunderbird special case from remote TabManager. r=whimboo,webdriver-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D155529
2022-08-28 22:47:39 +00:00
Julian Descottes
7d8eb136be
Bug 1783177 - [messagehandler] Merge internal and protocol events r=webdriver-reviewers,whimboo
...
We no longer distinguish between internal and protocol events within the framework.
All events now have the same behavior:
- emitted both under their own name and under the name message-handler-event
- bubble up to the root message handler
- the session which owns the RootMessageHandler does not listen for those events
The emitProtocolEvent has been moved to the RootMessageHandler only and can be used to emit events under a specific name "message-handler-protocol-event".
Only those events will be sent over to the actual client.
Internally the session module now keeps track of which events have already been subscribed to, to avoid forwarding duplicated events.
In a followup this will be centralized over in the EventsDispatcher, which can now play a bigger role.
Note that in the same way as for commands, there is still an implicit notion of "internal event", as in "an event which can not be subscribed to by consumers".
For commands this is done by having a "_" before the command name.
For events this is done by listing or not the event in the "supportedEvents" static array of the Module.
Differential Revision: https://phabricator.services.mozilla.com/D155025
2022-08-26 14:21:28 +00:00
Mark Banner
1a1669c8c4
Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for remote. r=whimboo,webdriver-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D155173
2022-08-26 13:39:37 +00:00
Alexandra Borovova
d42cab3b3c
Bug 1756680 - Update links in Vendoring Puppeteer docs r=webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D155073
2022-08-23 09:07:43 +00:00