Automatic update from web-platform-tests
Set the right fragmentation type in OOF fragmentainer relayout.
When re-laying out a fragmentainer for out-of-flow positioned
descendants, don't assume that it's a column. It might be a page.
The only known problem this caused was named pages, which we simply
ignored (inside OOFs) because we thought we were inside multicol even if
we in fact were paginated.
Also only SetIsInColumnBfc() if we're dealing with columns, for good
measure. This omission probably didn't cause any problems, though, since
NGLayoutInputNode::IsColumnSpanAll() checks
LayoutBox::IsColumnSpanAll(), and that one will only return true if
we're actually inside multicol.
Bug: 1428011
Change-Id: Ic725c2e4a5fdcdc19fae4d91cc7a9b2e3ca58d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369465
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122350}
--
wpt-commits: dae18f9f518a2d07284c8f0ef2107cb934c4ef4b
wpt-pr: 39184
Automatic update from web-platform-tests
Fix formatting of getKeyframes response.
* Show specified offsets in getKeyframes
* Report unreachable keyframes (computed offset may be null)
* Handle mix of computed and timeline offsets
* Sort as follows:
* CSS: percent in ascending order before timeline offsets in
specified order
* Programmatic: preserve specified order.
Bug: 1424543
Change-Id: I9d243d15cb37243aa3e7c1b50000c378bea51ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4341670
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122433}
--
wpt-commits: 3a01cf5b4ea054075a720aaf7ecadff7725c2db9
wpt-pr: 39119
Automatic update from web-platform-tests
Content Security Policy: Apply strict-dynamic for ScriptSpeculationRules
ContentSecurityPolicy::InlineType::kScriptSpeculationRules was
introduced to differentiate speculationrules from other scripts.
But, strict-dynamic supporting code doesn't recognize the type
correctly.
The spec change was discussed here.
https://github.com/WICG/nav-speculation/pull/245
CSP spec diffs for the speculationrules is published here.
https://wicg.github.io/nav-speculation/speculation-rules.html#content-security-policy
Bug: 1427005
Change-Id: I24830c34fd191f2e2d2aae901a07b0a1322afa60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368394
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122391}
--
wpt-commits: 1153ae17d16b3ff5757943045b70418c8007da82
wpt-pr: 39213
Automatic update from web-platform-tests
Revert "Deflake permission observation WPT by ignoring the event target"
This reverts commit 90d9a1b12b4fafec7c3c843b231fd4ed24afe88a.
Reason for revert: flakiness dashboard indicates this test is still flaky even with this change, so this CL was not successful.
Original change's description:
> Deflake permission observation WPT by ignoring the event target
>
> This just hides the underlying problem, that the event is being fired
> at the wrong target sometimes (if my hypothesis is correct, anyway).
> But it will fix the flake, so we don't have to disable this test or
> ignore its status.
>
> Bug: 1427214
> Change-Id: Ic97acb53d95077264e34253adc25a125b3ce1685
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368364
> Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
> Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
> Reviewed-by: Johann Hofmann <johannhof@chromium.org>
> Commit-Queue: Johann Hofmann <johannhof@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1121755}
Bug: 1427214
Change-Id: Ia45f4ebf5c12c539303f816004f9a265ecb0b4d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374078
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1122390}
--
wpt-commits: afd629a8bdb2212d1d8018e062fb6c1759d48658
wpt-pr: 39214
Automatic update from web-platform-tests
[FLEDGE] Add "use strict" to FLEDGE WPT tests' JS scripts.
The tests are already written in a strict manner, so this just requires
adding the "use strict" directive.
This does not add the directive to bidding or scoring scripts, just to
renderer scripts. Since bidding and scoring scripts use generated JS,
unclear if it's worth using the directive on them, though all generated
scripts currently don't actually declare any variables, so should be
fine with it.
Bug: 1425952
Change-Id: Ie4e0cf3930ed2e95936ef64c96cc6626c258a992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368335
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122386}
--
wpt-commits: a99d6a9854b7cf16903e860df49db93520de4e4e
wpt-pr: 39215
Automatic update from web-platform-tests
HTML: interactions between indexed and named access on the Window object
--
wpt-commits: a10581823a5de55d896b60ddc60249e7f0e86ff4
wpt-pr: 39211
Automatic update from web-platform-tests
LoAF flaky test: account for occasional UI event
Instead of checking that the first ui event is 0, test that it's
not equal to the img load event timestamp.
Bug: 1424506
Change-Id: Ia766b4864fa98b3ea7182c2e6a4aa6d3057d5931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370491
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122250}
--
wpt-commits: 6a8cbe724884a096974803e1235fb3e737c38578
wpt-pr: 39208
Automatic update from web-platform-tests
Fix attr-associated element reflection for disconnected nodes
Nothing in the spec [1] says that attr-associated elements should
not be functional when disconnected from the document. The prior
code would always return null for these references, however. This
fixes the code and adds a test.
[1] https://html.spec.whatwg.org/#attr-associated-element
Fixed: 1427374
Change-Id: I9897cd33310bd13e7acb4a1a122b3614e99edba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4371122
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122020}
--
wpt-commits: 2703c75d5e889bb7c6a918de44841bf9de8d63a7
wpt-pr: 39198
Automatic update from web-platform-tests
Improve interaction of pointer-events with scroll gesture hit testing, scrollability decisions, and overlay scrollbars
* First, this change stops considering pointer-events when deciding
whether a paint layer is scrollable. This avoids pointer-events
having strange effects on decisions about whether to show overlay
scrollbars. These strange effects include the backdrop of a <dialog>
causing the things behind it to become inert (and thus have
pointer-events: none) and cause overlay scrollbars to spontaneously
appear.
This is done by changing a test of
ComputedStyle::VisibleToHitTesting() to test only
ComputedStyle::Visibility(), which is one of the two parts of
VisibleToHitTesting(). This test dates back to
9de09a320e%5E%21/
and I don't think the pointer-events part of the test makes sense.
(I'm somewhat suspicious of the visibility part of the test as well,
although the authors of the tests at
web_tests/fast/scrolling/scrollable-area-{frame{,-scrolling-no}-visibility-hidden-child,overflow-auto-visibility-hidden{,-in-parent}}.html
believed in that part at least enough to write 4 tests for it.) It
doesn't seem to me that pointer-events (or, really, visibility) should
affect the result of ScrollsOverflow since it doesn't affect whether
something can be scrolled programmatically (or, for pointer-events,
via the keyboard).
Additionally, this CL then undoes the effect that the above change
would have on decisions about implicit promotion to the root scroller.
On Mac (but not Linux), the two added tests show the bug without this
change, when run in virtual/overlay-scrollbar/, but are fixed by this
change.
* Second, in order to both fix regressions from the above change and
fix existing bugs that exist prior to it, this change changes how
gesture scrolls are targeted when some but not all elements have
pointer-events: none, so that gesture scrolls are reliably hit tested
based on the pointer-events values of the elements involved. In
particular, it forces a scrollable region that is not visible to hit
testing to use the main thread hit testing codepath (since it may have
arbitrary descendants, scrollable or not, that are visible to hit
testing). It also adjusts the hit testing of scrollbars themselves to
match.
This is needed to avoid regressing
external/wpt/pointerevents/pointerevent_hit_test_scroll.html on Mac
only, and to avoid
pointerevent_hit_test_scroll_visible_descendant.html starting to fail
again (after being fixed by the first part) on Linux and Windows. (I
don't fully understand why the regression in
pointerevent_hit_test_scroll.html is Mac-only, but I know that on
Linux, UpdateNonFastScrollableRegion fails to bail out early in some
cases where on Mac it does bail out early because layer.element_id()
== scroll_element_id; in these cases, on Linux, layer.element_id() is
0 while scroll_element_id is not zero.)
* Third, this change also makes virtual/overlay-scrollbar/ and
virtual/non-overlay-scrollbar/ never expire, because they test
something that varies based on OS and settings rather than a feature
being rolled out (e.g., virtual/overlay-scrollbar/ matches the default
behavior on a Mac, whereas running outside that virtual suite does
not), and renames the README.txt to README.md to satisfy
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py;l=345-348;drc=fdd1781f121a555a8f4b771b970147e1a7ec4876
Fixed: 1414142
Change-Id: Ic26cfb933948bca55e4042ed360ed07692d14a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237636
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121965}
--
wpt-commits: 0b8c8ceda78d3134ada3da1fc3d203988b962ee8
wpt-pr: 38989
Automatic update from web-platform-tests
Attempt to deflake test by forcing an explicit done.
The test expectation is flaky because the error isn't be reported always.
Ensure that the unhandledrejection actually runs before the test
completes.
Bug: 1427571
Change-Id: Ie11a3d2347cdd755cd9fd620a02f5479c0ec6312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369500
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121904}
--
wpt-commits: 52138ad6a21cc6be6d111c1a3258320d548ec832
wpt-pr: 39191
Automatic update from web-platform-tests
Fix selectmenu's button for writing-mode
Before this patch, the selectmenu's button would not rotate when
writing-mode is asking it to, but based on the mockups from this issue
we should be rotating the button:
https://github.com/openui/open-ui/issues/600
Fixed: 1426702
Bug: 1427573
Change-Id: Ib2b4884efa518d2a445638f99d87be66e87138f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4359392
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121829}
--
wpt-commits: c5c18c817d0f8e816b81b731f41efcc218a4ff8a
wpt-pr: 39135
Automatic update from web-platform-tests
WebRTC WPT: Test that the answer negotiates a subset of RTP header extensions
as defined in JSEP
https://www.rfc-editor.org/rfc/rfc8829.html#section-5.3.1:
For each supported RTP header extension that is present in the offer,
[add] an "a=extmap" line
BUG=None
Change-Id: Ic9e2195a8a6aa011c8938f8a5ef0d74055d36cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369845
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1121783}
--
wpt-commits: 10c4049e41aec3e9945381e64aa8ab638eb00a6f
wpt-pr: 39181
Automatic update from web-platform-tests
Deflake permission observation WPT by ignoring the event target
This just hides the underlying problem, that the event is being fired
at the wrong target sometimes (if my hypothesis is correct, anyway).
But it will fix the flake, so we don't have to disable this test or
ignore its status.
Bug: 1427214
Change-Id: Ic97acb53d95077264e34253adc25a125b3ce1685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368364
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Johann Hofmann <johannhof@chromium.org>
Commit-Queue: Johann Hofmann <johannhof@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121755}
--
wpt-commits: 9a351c2a10bebd22e29dd5c47544c91fe02b0ecb
wpt-pr: 39190
Automatic update from web-platform-tests
[scroll-animations] Make initial value of animation-range-* normal
Fixed: 1406981
Change-Id: I69d91f9858e2f9c96a8391617ff397060a2190f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4364080
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121678}
--
wpt-commits: 926fe4179fb2cce537f554eb44f5cfcdf0453069
wpt-pr: 39180
Automatic update from web-platform-tests
Set longer timeouts for scrollend promises
The flakiness in these tests might be due to not having a long enough
timeout waiting for scrollend.
We can set a longer timeout and enable the disabled test to see if it
addresses the flakiness
Bug: 1419058, 1401318
Change-Id: Ic6e0562628fde07d6cc95ba3ef1563bb0774ca25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370339
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121670}
--
wpt-commits: 12ccfd78a755789ab84cdc556b5381a687c74442
wpt-pr: 39178
Automatic update from web-platform-tests
Minor update of site vs origin comments/names
Change-Id: I698941c621ca70c923589daf8e543672161fe6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4365207
Auto-Submit: Matt Reichhoff <mreichhoff@chromium.org>
Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org>
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121648}
--
wpt-commits: a544f9a82958c0db5ffcd4a8e476f137a3fda119
wpt-pr: 39171
Automatic update from web-platform-tests
[scroll-animations] Make <length-percentage> optional in animation-range
This CL makes the <length-percentage> part of animation-range-*
properties optional, i.e. the following is now allowed:
animation-range-start: cover; // cover 0%
animation-range-end: cover; // cover 100%
Additionally, the shorthand gains a new form in which the end
part can be inferred from the start part:
animation-range: cover 42%; // cover 42% cover 100%
The old special form of the shorthand (only a single range name)
is still valid, since <length-percentage> is now optional in general:
animation-range: cover; // cover 0% cover 100%
This CL adjusts existing tests as needed, but also adds new tests.
In particular, we were missing tests for "auto auto" contraction,
as well as tests for the computed value of the animation-range
shorthand.
Fixed: 1426501
Change-Id: I6a5e6a8818ab29a5a3653454c6d97c7bf47bb583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4363018
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121635}
--
wpt-commits: 508476a64944697ad6dc75bc98988e002a8a76e4
wpt-pr: 39159
Automatic update from web-platform-tests
[mathml] Improve parsing of negative dimensions for mspace/mpadded
A CSSPrimitiveValue::ValueRange parameter is added to the
ParseMathLength/AddMathLengthToComputedStyle functions and is used to
prevent negative values for some attributes of the mspace/mpadded at
parsing time. This fixes some assertion failures during layout.
Bug: 1421195
Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362438
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1121571}
--
wpt-commits: 83b3c1a529564cbd6ebc63bd219c95e7ea1742f8
wpt-pr: 39161
Automatic update from web-platform-tests
Add rendering tests for the <search> element
See https://github.com/whatwg/html/pull/7320
--
wpt-commits: c49cf0a72fd7278b6f6da0fd19ed37a3d9262bec
wpt-pr: 39163
Automatic update from web-platform-tests
Add CSSMathExpressionNumericLiteral canonical units eager simplification
Spec def:
"If root is a dimension that is not expressed in its canonical unit, and
there is enough information available to convert it to the canonical
unit, do so, and return the value."
https://w3c.github.io/csswg-drafts/css-values/#calc-simplification
However, Numbers should not be eagerly simplified at this time since
that would result in converting Integers to Doubles (kNumber, canonical
unit for Numbers).
R=xiaochengh
Bug: 1050968
Change-Id: I79adfbd516be640be51b86e1b33a2693c3b51ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4367363
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121473}
--
wpt-commits: 1a3bfb1f60e9ec2d237d09c386e27fd124c66236
wpt-pr: 39172
Automatic update from web-platform-tests
CSSTransitionDiscrete: Fix CounterRulesEqual
Instead of returning the value of base::ranges::equal, the initial
implementation I merged of CounterRulesEqual was throwing away the
return value and unconditionally returning true.
Bug: 1399631, 1413556
Change-Id: I2df45579ddf02056ff48763772d55be7885460fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4363281
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121451}
--
wpt-commits: 94fb2031f52efaccd25e5d63ae14874ca7a48798
wpt-pr: 39154
moz-wptsync-bot
Morten Stenshorne
Kevin Ellis
Takashi Toyoshima
Chris Fredrickson
Matt Menke
Delan Azabani
Anders Hartvoll Ruud
Noam Rosenthal
BruceDai
Chris Dumez
Yoav Weiss
dependabot[bot]
Joey Arhar
Mason Freed
L. David Baron
Dave Tapuska
Philipp Hancke
Antoine Quint
Romain Menke
David Awogbemila
Matt Reichhoff
Anne van Kesteren
Thiago Perrotta
Frédéric Wang
zcorpan
Traian Captan