On a new machine the instructions didn't fully work for me. I suspect that `libpulse-dev:i686` -> `i386` might have been a typo, and I also needed `libx11-xcb-dev:i386`.
Differential Revision: https://phabricator.services.mozilla.com/D81560
Some of the testing info is from the Oxidation wiki, and the logging info is
largely from a dev-platform email by Valentin. The other parts I wrote from
scratch.
The commit also makes some small improvements to the Rust build docs.
Differential Revision: https://phabricator.services.mozilla.com/D81017
The default configuration recommended here[1], while being a good
generic default, it doesn't quite work for mozilla-central as that peeks
the closest ancestor directory with a `Cargo.toml`.
For example, when editing under `servo/components/style`, it'd try to
use that directory as a project root and fail like:
```
0: Failed to run `cargo metadata --manifest-path /home/emilio/src/moz/gecko/servo/components/style/Cargo.toml`
1: Error during execution of `cargo metadata`: Updating crates.io index
error: failed to get `servo_atoms` as a dependency of package `style v0.0.1 (/home/emilio/src/moz/gecko/servo/components/style)`
Caused by:
failed to load source for dependency `servo_atoms`
```
Instead, we want to override it using the `'project_directory'` setting
so that we hit this path[2] and it works out of the box.
[1]: https://rust-analyzer.github.io/manual.html#youcompleteme
[2]: 63db7ea379/ycmd/completers/language_server/language_server_completer.py (L1914-L1916)
Differential Revision: https://phabricator.services.mozilla.com/D79938
Note that I cannot do unit test because of it doesn't support regex payload
''Failed: could not resolve a lint function from''
Differential Revision: https://phabricator.services.mozilla.com/D78158
Instead of linking to a page in MDN which links back to firefox-source-doc, this change links it directly to "Building Firefox On Windows"
Differential Revision: https://phabricator.services.mozilla.com/D79302
We don't require immediately setting an asignee for high
severity bugs. Rewriting this line because it was contradictory
to policy.
Differential Revision: https://phabricator.services.mozilla.com/D78612
Update definition to:
The new definition of Triaged will be Firefox-related bugs of type
defect where the component is not
UNTRIAGED, and a non-default value not equal to -- or N/A.
Bugs of type Task or Enhancement may have a severity of N/A,
but defects must have a severity that is neither -- or
N/A.
This means edits to the references to setting release
status flags (which are now not required.)
Also switching to using :ref:`link text <target>` for
internal links because of some errors when compiling
.rst to HTML.
Fix linter error in rst
Differential Revision: https://phabricator.services.mozilla.com/D74515
This changeset covers the new, severity-based triage process
Fix linting errors
Fix links and language
Fix headings and broken link
Add missing newline to labels.rst
Differential Revision: https://phabricator.services.mozilla.com/D73999
Code should be using `throw Components.Exception("", Cr.ERROR);` instead,
since `new Error()` just converts the int value of the Cr.ERROR into a string,
whereas `Exception` constructs an Exception object with the result property set
to the Cr.ERROR value, so other code can identify it.
Differential Revision: https://phabricator.services.mozilla.com/D28074
This rule is based on the ESLint built-in no-throw-literal. Cr.ERRORs are also
literals since they are just integers and so have all the same disadvantages of
no stack info.
TestInterfaceJS.js is explicitly testing handling of throwing raw Cr.ERRORs and
thus needs to stay.
Differential Revision: https://phabricator.services.mozilla.com/D28072
Sylvestre Ledru
David Major
Paul Adenot
Nicholas Nethercote
Sonia Singla
Dennis Schubert
Emilio Cobos Álvarez
Kris Taeleman
Kenrick
Markus Stange
Emma Humphries
championshuttler
Tarek Ziadé
mhoye
Tilden Windsor
Benoit Chauvet
Ian Moody
