Automatic update from web-platform-tests
[css-display] Computed value for display property (#17878)
The display computed value is as specified, unless the position
or float properties have particular values.
https://www.w3.org/TR/CSS2/visuren.html#dis-pos-flo
--
wpt-commits: 68ea548ac507c5f027e0910c319b94358a48c1f3
wpt-pr: 17878
Automatic update from web-platform-tests
Add historical test for SpeechRecognitionEvent's interpretation and emma attributes (#17870)
Follows https://github.com/w3c/speech-api/pull/55.
--
wpt-commits: 9a4d479ed1347eb9184abc70d628a6da2297657a
wpt-pr: 17870
Automatic update from web-platform-tests
Use correct w value in xrFrame_getPose
Values other than 1 are supposed to throw
--
wpt-commits: f32c779b7f4e21a006afe4b8f106c27688c695fd
wpt-pr: 17871
Automatic update from web-platform-tests
[ElementTiming] Track images by LayoutObject and ImageResourceContent
Previously, normal images were tracked just by LayoutObject whereas
background images would be tracked by LayoutObject and
ImageResourceContent. This CL changes all images to be tracked by both,
which besides simplifying the code also causes src changes to trigger
a new PerformanceElementTiming entry, which is desirable and consistent
with LargestContentfulPaint. Tests are added to prove this.
Bug: 879270
Change-Id: I59be4537b83ec229cf7f48efbe86bed7fd95b6a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703100
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678069}
--
wpt-commits: b0aa2c412899cfa43326cb555301951b54c5a536
wpt-pr: 17862
Automatic update from web-platform-tests
Set toast default styling
Updated the styling to reflect the changes to the
explainer in PR
https://github.com/jackbsteinberg/std-toast/pull/44
BUG=972945
Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678032}
--
wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7
wpt-pr: 17840
Automatic update from web-platform-tests
Port tests that use input to external/wpt/webxr
This change ports all tests that were previously internal to external
tests due to the new availability of the new input methods on the test
api. There are also a few minor cleanups:
* consolidate xr-test-asserts and webxr_test_asserts.js
* Make Epsilon params in asserts optional and dependent on constants
* Remove a few places that specified only epsilon
- Some future cleanup could consider flipping the order of the params
getInputPose_ray seemed to be mostly a duplicated/trimmed down version
of getInputPose_hand with the addition of also using XRRay. In order
to reduce dependency on XRRay, getInputPose_ray was deleted, and
getInputPose_hand was renamed to getInputPose_pointer to more accurately
reflect what it tests.
All other changes should be direct 1:1 renames + mostly mechanical
updates which reflect the different test harnesses and expectations.
Bug: 979318,976980
Change-Id: Ifee8f6686f3706f73ecfee72e8c28ad5b81cc320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702587
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677979}
--
wpt-commits: abb8fa72fc93ec01476a69447275944a16227850
wpt-pr: 17839
Automatic update from web-platform-tests
Update MockXRInputSource with gamepad support and port tests
Updates the MockXRInputSource to match the newly added gamepad support
and also ports related gamepad tests to external wpts.
Bug: 984154
Change-Id: I29ce501bcbea0f7bcfef6de60f17a6961fa165c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704387
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677986}
--
wpt-commits: 8ced0c87588fe6b17dcbfe04a01d53e702d71af9
wpt-pr: 17861
Automatic update from web-platform-tests
MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType
In preparation for Chrome's relaxation of addSourceBuffer and
changeType codec specificity within the mime type parameter, this
change adds new new tests. It also updates the Blink test expectations
for these new tests to be failures. Later changes will add Chrome's
implementation of the relaxed strictness, and will also remove the
failure expectations.
external/wpt/media-source/mediasource-changetype-play-without-codecs-parameter:
Tests successful addSourceBuffer, changeType, and codec switching
without using any codecs parameter in types passed to addSourceBuffer
and changeType for pairs of test media that are of same media class
(audio or video) and are single track. This test is very similar to
mediasource-changetype-play.html, just with less specific parameters
to addSourceBuffer and changeType. This file is kept separate from
mediasource-changetype-play.html to help identify implementations
(like Chrome at the time of this change) that require more specific
parameters to those methods.
external/wpt/media-source/mediasource-changetype-play-implicit.html:
Tests successful codec switching without using changeType for test
media of the same bytestream format, separately for audio-only and
video-only pairs of media. Also includes a set of the same tests where
the initial addSourceBuffer uses only the (relaxed) mime type/subtype
without any codecs parameters, for any pairs that included codecs
parameters in their full types.
Note: In Chrome, only 1 pair of actually different media files is
supported across the test media: webm vp8 and vp9. We can add more
test media later if greater coverage is desired.
external/wpt/media-source/mediasource-changetype-play-negative.html:
Tests of various explicit, implicit, strict and relaxed scenarios
which should fail.
Main MSE spec issue for this:
https://github.com/w3c/media-source/issues/161
Related codec-switching MSE spec issue:
https://github.com/w3c/media-source/issues/155
These new tests exercise related scenarios to the new non-normative
guidance in the codec-switching incubation spec branch in WICG
(https://github.com/WICG/media-source/tree/codec-switching),
clarifying that implementations can be relaxed in addSourceBuffer
and changeType codec-specificity, but not isTypeSupported; apps
should still provide as much type specifics as they can to achieve
earlier confidence in support or lack thereof, and to avoid issues
with implementations (like Chrome at the time of this change) that
require more specific parameters to those methods.
BUG=535738
Change-Id: I20fd477b2429ef94ee70bf57ed8c18543774da93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663349
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672316}
--
Fix async tests in media-source
mediasource-util.js redefines test.done() to add a final assertion
before actually calling done(). However, the assertion was not wrapped
in test.step(), which would lead to uncaught errors.
--
wpt-commits: b42e788c6937bce1317411e61e9d18ba06835d82, 012de5bb12d78ad7135c26b15fc24f366b1c5845
wpt-pr: 17416
Automatic update from web-platform-tests
CSS: parse-content accepts <baseline-position>
When parse-content is a <baseline-position> value like
last baseline, align-content is the <baseline-position>
and justify-content is start.
https://drafts.csswg.org/css-align-3/#place-content
We add WPTs for serialization of all the place-*
shorthands.
Bug: 983753
Change-Id: I332c75b631efd29e398ba42985529b664c828b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698173
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677928}
--
wpt-commits: 00d52d80773a8d81dbda7535b01fae31233fa19d
wpt-pr: 17818
Automatic update from web-platform-tests
wake lock: Make wakelock-abortsignal.https.any.js use only system locks
According to the spec, screen locks are not supported in workers, which
causes some of the tests in wakelock-abortsignal.https.any.js to fail with
errors unrelated to AbortSignal.
Switch to system locks, which are not rejected too early (but early enough
that whether the UA allows them or not is irrelevant).
Bug: 967667
Change-Id: I6fe43d288c736d59306ee400c0da3af848bf5ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702377
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677906}
--
wpt-commits: cf7641c83a6494296ead0c8878a6605ad0be1a03
wpt-pr: 17853
Automatic update from web-platform-tests
Cross-scheme initiator should result in `Sec-Fetch-Site: cross-site`.
Before this CL, IsSameSite helper function in
services/network/sec_header_helpers.cc would only compare |initiator|'s
and |target_origin|'s hosts, which meant that a request with:
- initiator = http://foo.example.com
- target = https://foo.example.com
would be sent with:
Sec-Fetch-Site: same-site
After this CL, IsSameSite also compares schemes (but not ports) to match
Site Isolation's notion of a site and so the request above will use:
Sec-Fetch-Site: cross-site
Bug: 979257
Change-Id: I9b27a1118cdda8cfc02bf07ac697fc8d591d6b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680096
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676649}
--
wpt-commits: c8838b7f6d19a2d3cbfeece29df2702b11a7674a
wpt-pr: 17569
Automatic update from web-platform-tests
[Navigation timing] Add secure connection start reuse test
During the review of https://github.com/w3c/navigation-timing/pull/106
it was noted that secureConnectionStart's behavior with regards to
connection reuse and navigation timing is not well-tested.
This CL adds such a test.
Change-Id: I91d7cbfe4f1ee58a72b4a647a38bd58d4ffca693
Bug: 977519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702022
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677521}
--
wpt-commits: 391c8f12e270cf0cadb26dc06b5d9984afe34a4c
wpt-pr: 17832
Automatic update from web-platform-tests
KV Storage: tweak secure context restriction and expand tests
Recent discussions on the KV Storage spec (https://github.com/WICG/kv-storage/pull/53, https://github.com/WICG/kv-storage/pull/68) have decided on a slightly different model for restricting modules to secure contexts, that is based on preventing them from entering the module map, instead of throwing an error at module evaluation time.
This is mostly observably the same, with a few small differences:
* The error type changes from DOMException "SecurityError" to TypeError. This CL updates the implementation's runtime check, and all associated tests, to match the new error type.
* Not being present in the module map means module graph initialization fails earlier, preventing any side effects from earlier modules in the graph from being evaluated. This is tested in the new WPT kv-storage/secure-context/side-effects.html, which we fail for now.
* Not being present in the module map means that import map failover works. This is is tested in the new WPT kv-storage/secure-context/import-maps.html, which we fail for now.
https://crbug.com/977470 tracks the infrastructure work necessary to move from a runtime check to selectively filling the module map, which will allow us to pass the two newly-added tests.
BUG=977470
Change-Id: I9371400e9beed5be4ed5fbb0c94747a7bc0b3e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670572
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677454}
--
wpt-commits: b3a9dd55d31874e8f2d197b4b958c0dac96ea844
wpt-pr: 17424
Automatic update from web-platform-tests
Have containValues check array lengths
If the number of distinct elements in the input array does not match
the number of elements in the expected set, an error was thrown trying
to read a property from undefined.
Instead, check that the lengths match and if they don't fail the test
with an appropriate message.
Also remove the-convolvernode-interface/active-processing.https.html
that should have been removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1653924 but
wasn't.
Bug: 974022, 978372
Test: audit-failures.html
Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659492
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677080}
--
wpt-commits: ab0e632de5d4284b5078665ffdd2bee7bb0871d3
wpt-pr: 17327
Automatic update from web-platform-tests
Rename render timestamp in ElementTiming and LargestContentfulPaint
Currently, the rendering timestamp is exposed in startTime. This may not
be ideal because analytics providers may be using certain default
filters which could sort by startTime, but the timestamp is 0 for cross
origin images. Also, 'renderTime' is more indicative of the timestamp
being exposed.
Bug: 879270, 942033, 965505
Change-Id: Iee283426173facd1e67343fd376e344517540423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703480
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677814}
--
wpt-commits: 47df9efd6ad1b9bf18345b3ace6790a5d41f6334
wpt-pr: 17852
Automatic update from web-platform-tests
Portals: Allow adopted portal to be activated without insertion
This CL allows us to activate an adopted predecessor inside the
onportalactivtate event handler without inserting it into the DOM.
Bug: 971709
Change-Id: Idbbbaf89080d19d19e9782376c4e51558c07e81b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690387
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677580}
--
wpt-commits: 787e5a9ad59f8c04ee3ac0a2a7241dd2152ca601
wpt-pr: 17744
Automatic update from web-platform-tests
Remove ExtendedTextMetrics flag to launch canvas TextMetrics
This change removes the flag ExtendedTextMetrics and the code that references
it in order to ship attributes in TextMetrics: ActualBondingBoxAscent,
ActualBondingBoxDescent, ActualBondingBoxLeft and ActualBondingBoxRight.
Currently chrome (edge and firefox) is only returning the width of
the measured text.
https://html.spec.whatwg.org/multipage/canvas.html#textmetrics
Intend-to-ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dTL2nW5mhGc
Bug: 277215
Change-Id: I02a253c0936456ca4036718a2f6cfe506d58e61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700118
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677532}
--
wpt-commits: 2e04ab03aba12b7942367972b2dd197c43c2507b
wpt-pr: 17834
Automatic update from web-platform-tests
CSS: Test transform-box computed value
transform-box computed value is as specified.
https://drafts.csswg.org/css-transforms/#transform-box
Bug: 924472
Change-Id: I753369208209ad9b430d7b4b3f52ba6b711e0f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701746
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677465}
--
wpt-commits: 183ea3920d07b77dc6a7ddabf2d3704d814d1382
wpt-pr: 17828
Automatic update from web-platform-tests
CSS: WPT for 'order' computed value
'order' computed value is the specified integer.
https://drafts.csswg.org/css-flexbox/#propdef-order
Change-Id: I641242d47d85d6d6158ad907f9690272d04f2c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701921
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677464}
--
wpt-commits: 02c1c4cfecece80a0749fc4fd03c744fb1548ba6
wpt-pr: 17830
Automatic update from web-platform-tests
[LayoutNG] Make Block and inline-block have the same baseline when `overflow: hidden`
CSS2 defines[1] the baseline of an 'inline-block' is the
bottom margin edge if its `overflow` property is other than
`visible`.
Legacy, Gecko, and WebKit apply this rule to `block` too.
This patch matches to these engines.
Edge fails these tests, but MSN serves different page for
Edge (no gear icon) and that this problem does not appear.
[1] https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align
Bug: 983822
Change-Id: I2c6c9ea7cb629a61720c9aeec9979341ce86360e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701618
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677461}
--
wpt-commits: b91110463d121e6b4ba6749df1fe5f54e9540d92
wpt-pr: 17841
Automatic update from web-platform-tests
Rename "support" files
This is in preparation for a subsequent commit which will remove support
for the `-support.` filename flag.
--
[tools] Remove support for `support` filename flag
In terms of file interpretation by the WPT infrastructure, naming a file
with the `-support` flag is equivalent to placing it in a directory
named `support`, `resources`, or `tools`. The ability to express the
same intention with different mechanisms allows for variation that adds
no value and needless increases the complexity of the infrastructure and
its documentation. Further, the character sequence of `-support` is
prone to accidental opt-in: a number of tests in this suite currently
include that sequence and are thus not executed in automation.
Remove support for the flag.
--
wpt-commits: 856aa0b0678a07162bbd14b8dda4ffcc7a7aca2f, abfb2bcc1fb01ec5d9c930ff96fe9a8cedae0546
wpt-pr: 17645
--HG--
rename : testing/web-platform/tests/WebIDL/ecmascript-binding/constructors-support.html => testing/web-platform/tests/WebIDL/ecmascript-binding/support/constructors-support.html
rename : testing/web-platform/tests/dom/traversal/traversal-support.js => testing/web-platform/tests/dom/traversal/support/assert-node.js
rename : testing/web-platform/tests/eventsource/eventsource-onmessage-realm-support.htm => testing/web-platform/tests/eventsource/resources/eventsource-onmessage-realm.htm
rename : testing/web-platform/tests/html/semantics/forms/resetting-a-form/reset-form-event-realm-support.html => testing/web-platform/tests/html/semantics/forms/resetting-a-form/support/reset-form-event-realm.html
rename : testing/web-platform/tests/html/syntax/parsing/DOMContentLoaded-defer-support.js => testing/web-platform/tests/html/syntax/parsing/support/DOMContentLoaded-defer.js
rename : testing/web-platform/tests/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-support.htm => testing/web-platform/tests/html/the-xhtml-syntax/parsing-xhtml-documents/support/xhtml-mathml-dtd-entity.htm
rename : testing/web-platform/tests/touch-events/touch-support.js => testing/web-platform/tests/touch-events/support/touch.js
Automatic update from web-platform-tests
Reland: [shapedetection] Add some shapedetection tests
The original CL has been reverted because the test
external/wpt/shape-detection/detection-HTMLVideoElement-invalid-state.html
is flaky.
In the previous CL, the way to create a HTMLVideoElement with 'HAVE_METADATA'
state is wrong, because simply loading a video file its readyState should
be >= HAVE_METADATA during loadedmetadata event. Which is the reason of the flaky.
This reland CL leverages MediaSource API to precisely trigger a transition
to HAVE_METADATA state by invoking `appendBuffer()` with an initialization segment.
See relevant spec: https://w3c.github.io/media-source/#sourcebuffer-init-segment-received
Original change's description:
> [shapedetection] Add some shapedetection tests
>
> Cover following two checkpoints:
> - If the ImageBitmapSource is an HTMLVideoElement object whose readyState attribute
> is either HAVE_NOTHING or HAVE_METADATA then reject the Promise with a new
> DOMException whose name is InvalidStateError.
> - If the ImageBitmapSource argument is an HTMLCanvasElement whose bitmap’s origin-clean
> flag is false, then reject the Promise with a new DOMException whose name is SecurityError.
>
> spec: https://wicg.github.io/shape-detection-api/#image-sources-for-detection
> Change-Id: I0522d0340d3cb0291df6be65dfc1ab99037b30f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666766
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Wanming Lin <wanming.lin@intel.com>
> Cr-Commit-Position: refs/heads/master@{#671578}
Bug: 979170
Change-Id: I963c3b6bce86791f5bedde7849c2e439b28c5481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688460
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#675956}
--
wpt-commits: cba61ec81f44eab31fa68d2ae9f87aef1144c190
wpt-pr: 17636
Automatic update from web-platform-tests
Add an xslt test folder (#17607)
* Add xslt test transformToFragment test
* Add IDL + test
--
wpt-commits: ab9626fa6be42c01576385327da84a6f7e9144b8
wpt-pr: 17607
Automatic update from web-platform-tests
webdriver: remove change event from assert_events_equal in test_contenteditable (#17813)
The change event does not fire on contenteditable.
--
wpt-commits: 09f63964a79d604c244aa2ab492b6a3d43ba17fa
wpt-pr: 17813
Automatic update from web-platform-tests
webdriver: remove ES6 from WebDriver execute [async] script property tests (#17824)
To preserve compatibility with older user agents whose JavaScript
engines do not implement ES6 constructs, in particular array
destructuring, this PR refactors those constructs to be compatible
with the older language syntax.
--
wpt-commits: 4eb1792c2491165535b235f4eba1d5e1b723b958
wpt-pr: 17824
Automatic update from web-platform-tests
Change bindings generation to make Exposed annotation aware of members/partial interfaces
--
wpt-commits: b10ea3bed2ee66a3becbb7c52765b0e1ae953eb2
wpt-pr: 17812
Automatic update from web-platform-tests
[LayoutNG] Fix when adding a hyphen causes the line to overflow
When adding a hyphen causes the line to overflow, this patch
retries another break opportunity with the reeuced available
width instead of the line to overflow.
Bug: 982729
Change-Id: I8e7e56fe68cdfb101ebfedd3a43c062c97a56e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699942
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677216}
--
wpt-commits: 719721f655102bcd24d45eba91339eb2d7dbc591
wpt-pr: 17803
Automatic update from web-platform-tests
[LayoutNG] Honor table cell descendants' min heights
LayoutNG ignored them for row height sizing (Measure phase) when the
descendant had a % height and overflow auto/scroll.
The fix turned out to be simple but getting there was not.
I think our existing NG behavior was correct according to the spec, but
if my interpretation is correct, the spec is missing this case.
https://drafts.csswg.org/css-tables-3/#row-layout :
For the purpose of calculating this height, descendants of table cells
whose height depends on percentages of their parent cell' height (see
section below) are considered to have an auto height if they have
overflow set to visible or hidden or if they are replaced elements, and
a 0px height if they have not.
In these test cases the descendants of table cells' heights do depend on
their parent cell' height and have overflow set to neither visible nor
hidden, so should get 0. (They depend on their parent's height because
the descendant height is max(resolved min-height, resolved height) where
resolving height needs the cell height.)
But sizing the row such that the descendants don't fit doesn't make
sense (and isn't what engines do today). This was happening in NG when
the min-height of the descendant was larger than the height of the row,
after calculating the height of the row by indiscriminately using 0px as
the height contribution from % height scroller descendants.
The fix is to use % height scroller descendants' min heights as their
contribution to the row height instead of 0px.
We still get a related case wrong in legacy and NG
(percentage-sizing-of-table-cell-children-005.html) -- when a scroller
descendant has % height but the cell height is indefinite, we should
treat the descendant's % height as auto, per css2, even for row sizing
purposes. Instead, we currently treat it as a % height such that it
contributes 0px to the height instead of its post-layout height.
I also discovered some suspected dead code that used to have some of
this relayout-depending-on-scrolling logic.
Bug: 982323, 982312
Change-Id: Iff5210f6bf53c8f7e4b29ca32f8401d0eb738317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700782
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677211}
--
wpt-commits: 75bb16c1492979caee7818fd4d940cd36fe826d8
wpt-pr: 17819
Automatic update from web-platform-tests
Update webxr-test-api method names to floorOrigin
Per feedback on the spec and updates to the comments about what an
origin actually is, the API method names and dictionary values were
updated from localToFloorTransform to the more accurate floorOrigin. The
current usage of these items actually matches the new name and therefore
were previously improperly named.
Bug: 979316
Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677129}
--
wpt-commits: 897fc65c3ea0a67aa1d91781dba0d2377cdd6026
wpt-pr: 17814
Automatic update from web-platform-tests
[LayoutNG] Consider nodes with only floats/OOFs as block-level.
Legacy/WebKit have a "interesting" behaviour for empty-inlines in that
they determine the static position of any (inline-level) OOF-positioned
nodes as if they were in the block-level context.
Other browsers do the following (testcase):
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7055
FF - all inline-level
Safari/Legacy - all block-level
Edge - block-level for default/block-level
NG (prior to this change) - inline-level for default/inline-level.
This change makes the "default" e.g. a node with just floats/OOFs as
block-level to pick up this static position behaviour.
This matches the EdgeHTML behaviour.
Bug: 980908
Change-Id: Ifb92bf7e34ada669fa16a1ee5f9e9edaf4546768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696345
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677105}
--
wpt-commits: 7d2e6ae20d62092517732c76fd8588975b95744e
wpt-pr: 17808
Automatic update from web-platform-tests
Make ChannelMerger active processing test less flaky
Replace the offline audio context with a realtime context and an AudioWorklet.
Previously, when the source stopped, the channel count change would sometimes
get delayed until rendering is done, which is too late for the test. I believe
this is because the main thread was previously too busy to process the messages
to disable outputs and change the channel count.
Using a realtime context makes the main thread less busy because the messages
aren't posted as fast as possible, allowing time for them to be handled. I think
this is still flaky, but much less so than before.
Bug: 974258
Test: the-channelmergernode-interface/active-processing.https.html
Change-Id: Id584ebfa5f54ad6870819f5242aafed5f4fc80d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663186
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677078}
--
wpt-commits: 0f26df61e2589897b7afbbae975b931027b3e8d3
wpt-pr: 17383
Automatic update from web-platform-tests
Implement Input portions of webxr-test-api
This change implements the input related portions of the webxr-test-api
and updates internal tests to use those methods/constants/inits.
Most of the logic is ported from xr-internal-device-mocking.js and just
converted from attributes to a pair of set/clear properties. No tests
were actually using the getters, so those were just deleted. Because
the webxr-test-api does not yet support gamepads, all of that logic was
left in the internal mock.
It also forces/fixes a potential bug where a device with no inputs may
opt to set the "InputStates" value of the mojom to null rather than an
empty array. (The device code typically sets this to an empty array)
Rather than risk losing/confusing the diff to the updated tests, future
work will move these tests to the external WPTs
Bug: 979318
Change-Id: I846831a561217abd66ab841326a5e5472f38afeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699505
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677061}
--
wpt-commits: 6b406c741ea44867d369c30eab1d910c5ededeab
wpt-pr: 17810
Automatic update from web-platform-tests
Store |initiator_origin| in FrameNavigationEntry.
Changes in this CL
==================
This CL:
1. Updates FrameNavigationEntry::UpdateEntry and
FrameNavigationEntry's constructor so that they both take
|const base::Optional<url::Origin>& initiator_origin| which
gets stored in a new FrameNavigationEntry::initiator_origin_ field.
2. Updates callers of FNE::UpdateEntry and FNE's constructor to
provide/propagate the initiator as needed. This includes
adding an |initiator_origin| parameter to
- NavigationEntryImpl's constructor
- NavigationEntryImpl::AddOrUpdateFrameEntry
- NavigationController::CreateNavigationEntry
(the list above is not necessarily exhaustive/complete)
3. Uses the new |FrameNavigationEntry::initiator_origin()| from
NavigationEntryImpl::ConstructCommonNavigationParams (which
used to always provide |base::nullopt| initiator for history
navigations - always treating them as browser-initiated, rather
than replaying the original initiator).
The changes above makes sure that the right Sec-Fetch-Site http request header is
"replayed" during history navigations. The CL adds browser tests and
WPT tests to cover the new, desired behavior.
Follow-up changes
=================
This CL does not:
- Use |FrameNavigationEntry::initiator_origin()| in GetOriginForURLLoaderFactory
in render_frame_host_impl.cc (this will be done in a follow-up CL at
https://crrev.com/c/1672176)
- Handle persisting |FrameNavigationEntry::initiator_origin()| for
session restore (this is tracked in a separate https://crbug.com/976055).
Bug: 946503
Change-Id: I4f92614873a5ec8d4b52d3ae22031c7089d87ed5
Tbr: skuhne@chromium.org for //components/sessions
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662738
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677046}
--
wpt-commits: 457bec5a53e806f684ffc03f6b96c0739f6a7f7b
wpt-pr: 17497
Automatic update from web-platform-tests
Use testdriver Action API in WPT pointerevent tests - Part 10
In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs. Here we are
changing some pointerevent input test which taps on the elements inside
an inner frame.
This is the tenth CL that changes part of the pointerevent input
tests.
Bug: 606367
Change-Id: Ib90c92e8267f17fed74a86d70ca6d739b5ccedb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638914
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675891}
--
wpt-commits: e6fff725295afce26b2000ab7644a69d29f78c08
wpt-pr: 17789
Automatic update from web-platform-tests
webdriver: allow trailing slashes for navigate_to WPT test (#17805)
The handling of file:// URLs is implementation defined.
--
wpt-commits: 43a2ddb71497ee04157fe6fc8ce29d7e4ef2b6ec
wpt-pr: 17805
Automatic update from web-platform-tests
LazyLoad: Add external web platform tests for the "loading" attribute.
This CL includes tests for:
- Testing that images and iframes with the attribute loading="lazy" are
deferred until they come into view
- Testing that images and iframes with the attribute loading="eager" are
loaded immediately
Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}
--
wpt-commits: 9919d0f04266001686c09d47ff6e25c98b48d91f
wpt-pr: 14914
Automatic update from web-platform-tests
[cssom] getComputedStyle not getComputedValue (#17799)
Fix typo in test titles.
--
wpt-commits: 9daa6ffd6eb28afb0940b7ac304b08e8383fc527
wpt-pr: 17799
Automatic update from web-platform-tests
CSS property 'tab-size' should take 'number' instead of 'integer'.
According to https://drafts.csswg.org/css-text-3/#tab-size-property,
let 'tab-size' take css 'number' value, not css 'integer' value.
Bug: 974090
Change-Id: Idb235eacde59f5bae1ab7fb814425fae4b93a227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689165
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676741}
--
wpt-commits: 01669b3a69c55c077a6f5212c295528c89388d6c
wpt-pr: 17779
Automatic update from web-platform-tests
[compositing] Computed value tests (#15319)
background-blend-mode, isolation, mix-blend-mode computed values are as specified.
https://drafts.fxtf.org/compositing-1/#property-index
All tests pass with Firefox.
Three background-blend-mode tests fail with Blink/Edge/Safari:
expected "normal, luminosity" but got "normal"
expected "screen, overlay" but got "screen"
expected "color, saturation" but got "color"
--
wpt-commits: d0a227ec363d652a133d53bdda7ab2ef976e6008
wpt-pr: 15319
Automatic update from web-platform-tests
[docs] Normalize spelling of "test suite"
The documentation uses the terms "testsuite" and "test suite"
interchangeably. Normalize on "test suite."
--
wpt-commits: 03fcaec457809e26a282727951c155b82660e159
wpt-pr: 17797
Automatic update from web-platform-tests
[docs] Expand landing page
Currently, the documentation website's landing page contains only a
table of contents. The introductory material is accessible through the
first link in that index.
Because the landing page is itself an introduction, it ought to offer
some explanation of the project's purpose and structure.
Re-use the introductory text found in the project's README.md file since
this is slightly more complete than the corresponding text in the
"introduction" page. Move other high-level information to the landing
page and rename the "introduction" to "testsuite design" in order to
better describe its more narrow focus.
--
[docs] Correct typos
--
wpt-commits: f3cdfbcb428ca2f711d0b5128264d3f7cfcfd187, 6d60c3d31206401a3e22db74c68429a302443d9f
wpt-pr: 17634
Automatic update from web-platform-tests
Fix WPT manifest updates when within a git tree
This has been broken since bug 1545629 landed, when we started using
git to (quickly) get hashes of unchanged files. Unfortunately, the
logic for finding changed files only worked when the test root was the
root of the git repository.
Differential Revision: https://phabricator.services.mozilla.com/D34702
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1558363
gecko-commit: b975b4c1dfaebedabc4a09296b90303c7d5381e3
gecko-integration-branch: central
gecko-reviewers: jgraham
--
wpt-commits: 3fb0150bb0a53b5a6630e8eda7f43bf75d8a6bbe
wpt-pr: 17785
Automatic update from web-platform-tests
Move movementX/Y calculation for aura pointer-locked state to Blink. (#17295)
This change moves movementX/Y calculation for aura pointer-locked
state to Blink.
On aura, pointer lock use "move to center" to make cursor stays in
the window. With the calculation done in blink side, the move to
center event is marked as synthesize move, so that we can update
the blink side states and do not dispatch the event.
The change is under content feature flag kConsolidatedMovementXY
Bug: 802067
Change-Id: I05360dadd18a2f41481a0de9ef78a05199493857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618306
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674237}
--
wpt-commits: 293143370ddaa9ceaee4294c78a17d97e7bdd5c6
wpt-pr: 17295
Automatic update from web-platform-tests
[UserTimingL3] Fix crash: create mark in worker
Currently, the renderer crashes when creating mark entry in worker.
The crash is because PerformanceMark::Create() return nullptr without
setting exception_state. The caller of the function assumes that
no exception indicates the PerformanceMark entry exists. Thus, when the
entry is visited, the crash occurs.
There is another bug hidden in this issue. Currently, when
window-performance is not found, Create() returns nullptr directly. It
should instead also check whether worker-performance exist.
This CL fix these issues.
To verify the change, the CL also changes the related web tests from
*.html to *.any.js, which enables these tests in worker's context.
Bug: 981982
Change-Id: Ia20ce1c194e4db2810ff3f1c52070e5970951600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696085
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676484}
--
wpt-commits: 133323811602dd4ceced46f11aabb645a3582983
wpt-pr: 17773
Automatic update from web-platform-tests
Create toast action setter
Additionally, this CL adds support for passing Elements
as action in showToast, using the action setter.
This change is the latest in a series of changes implementing
new behavior added to the toast explainer in PR #43https://github.com/jackbsteinberg/std-toast/pull/43.
Bug: 972945
Change-Id: I46004883cb3b794981029aa02369918dd0077391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686786
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676482}
--
wpt-commits: 11051ca7a0270ae8fe07939d35cd923e5b542748
wpt-pr: 17780
Automatic update from web-platform-tests
Partially fix calc() length unit handling in media queries
When a calc() length is passed to media queries, the current code
assumes that there's always a DoubleValue(), and the unit type matches
TypeWithCalcResolved(), which is incorrect.
This patch partially fixes the issue when the calc expression can be
resolved without type conversion. Handling type conversion is more
complicated and hence left broken by this patch (as it's already broken).
Bug: 982542
Change-Id: I258b3d1aeec69fb65fbadd86981e97974239289b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696191
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676452}
--
wpt-commits: 14acac099af003b048229966651d558f508e2b9a
wpt-pr: 17775
Automatic update from web-platform-tests
custom-elements: Fix 'capture' attribute existence check in reactions/HTMLInputElement.html
Do not call 'capture' property getter.
--
wpt-commits: 40ef441b2f6ff803248bf71f03334b1326371c2b
wpt-pr: 17781
Automatic update from web-platform-tests
[css-transforms] Avoid using assert_own_property on style property. (#17778)
These `assert_own_property` tests cause these CSS tests to fail on Firefox
only, and I think these properties are not supposted to be own properties,
so use a similar way as https://github.com/web-platform-tests/wpt/pull/16892,
to test the existence of these properties.
--
wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0
wpt-pr: 17778
Automatic update from web-platform-tests
webdriver: make height and width of tests larger than min for chrome (#17772)
--
wpt-commits: 36acf7a01cb8ffbbafbd578229c5ad3fde2e47cc
wpt-pr: 17772
Automatic update from web-platform-tests
[UserTimingL3] Throw TypeError on negative time stamp
According to the spec (https://w3c.github.io/user-timing/):
1. "If markOptions's startTime is negative, throw a TypeError.",
2. "If mark is negative, throw a TypeError." when "Convert a mark to a timestamp"
The CL is to add these two checks accordingly.
Bug: 953865
Change-Id: I8475870cc883dc8c3d3d4f3e65a9d5a0a2189a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691871
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676266}
--
wpt-commits: a819c8a4b2760a1547e63d57e39e3f34dbc5da41
wpt-pr: 17736
Automatic update from web-platform-tests
[LayoutNG] Consider inline-level OOF-positioned nodes as "adjoining".
"adjoining" objects are used to indicate that a particular node might
need relayout once its BFC block-offset is resolved. Previously we
thought that we just needed to know about "adjoining-floats".
However inline-level OOF-positioned nodes also needs to know its BFC
block-offset as the static-position of these nodes depend on where
floats are.
Previously as we didn't know that we needed to relayout these nodes
we'd get the incorrect static-position. Now these nodes get the
correct static-position.
Bug: 982403, 980908
Change-Id: I89f18298fd7379358a681b98514891d8d35bc38e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692627
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676263}
--
wpt-commits: 4f954c15e1dc8cf94f7a2231f648fb640509d9d4
wpt-pr: 17782
Automatic update from web-platform-tests
Add FakeXRDevice.disconnect method and test
Also simplifies events_deviceconnect, though because that tests behavior
that doesn't appear to be specced, that test is left internal.
Bug: 979316
Change-Id: I55cdb925aac9c2317d0a2b9f44f8eb368048aa5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693775
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676258}
--
wpt-commits: c58628cd58109b1caa9cfd72e794929a65ee849b
wpt-pr: 17750
Automatic update from web-platform-tests
CSS: font-family initial value unspecified
https://drafts.csswg.org/css-fonts-4/#font-family-prop
Initial: depends on user agent
We can't simply have "times new roman"
in our test expectations, as Mac 10.10 .. 10.12 have
Times instead.
Bug: 966249
Change-Id: I091924585e05b2b085ab420ac553233f7346e79d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695581
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676242}
--
wpt-commits: 037a9292ea1ffbcd4a26612e3a615a45dcbb263f
wpt-pr: 17755
Automatic update from web-platform-tests
CSS: Parsing tests for align-* and justify-* properties
Check that CSS Alignment properties accept only the values permitted
by the spec
https://drafts.csswg.org/css-align-3/#property-index
Change-Id: I93b00ac2280ca4991c24b3ee35a17047e165b8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694928
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676203}
--
wpt-commits: 9234a033ce9a341afec6574ddc0f2ec13c9dd35f
wpt-pr: 17756
Automatic update from web-platform-tests
Add action option string to be passed to toast showToast()
This partially implements the action option for showToast(),
as outlined in the explainer at
32237007b0/README.md (showtoastmessage-options).
For now it only handles the string or undefined cases;
the Element case will be handled in a follow-up CL once the action setter is implemented.
BUG=972945
Change-Id: I82556801a6586c89cd506669f935488e049c47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676168}
--
wpt-commits: 996e93b6478d485eb5867e3a5570ad88f63f878e
wpt-pr: 17774
Automatic update from web-platform-tests
[FractionalScroll] Fix web tests
This CL fixes Blink web tests so that they pass when the Fractional
Scroll Offsets flag is enabled. This flag enables fractional offsets on
the Blink main thread which breaks some tests because they assume that
offsets will be floored.
I've modernized two tests:
fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
fast/events/scale-and-scroll-div.html
The first appears to have been an issue with js-test modifying the page
while the second was passing but the PASS string in the -exected.txt
had changed to include the factional. Both tests now pass with and
without the feature enabled.
I removed fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html
since it was testing the same thing as scale-and-scroll-div.html.
The rest of the tests required changing the layout such that it doesn't
cause us to land on fractional offsets (and thus the behavior will be
unchanged with and without the flag). Where this was difficult I just
allowed for approximate equality.
Bug: 414283
Change-Id: Ie03fa06b100fb9946675e921357c1eaebfe6a37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690293
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676118}
--
wpt-commits: e93818b7c65d3bb3152ed5f7bf1f06019bd295bb
wpt-pr: 17671
Automatic update from web-platform-tests
[css-tables] Ignore abspos tables when checking cell descendants
If a table is added dynamically as a child of a table cell, the cell
might call innerTable->HasSections() before the inner table has
calculated its sections. The cell was checking HasSections() because
cells change sizing behavior when they have a table with sections as an
immediate descendant.
This only happened in a very narrow scenario -- when an abspos table
with a %height that does not resolve as auto is dynamically added.
Bug: 977507
Change-Id: I7856291dc6508624a81e9b65af909fa8a0d8e749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696003
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676116}
--
wpt-commits: e5601b1ba9993f618a1838dbd4b80a9d46013e66
wpt-pr: 17771
Automatic update from web-platform-tests
Update FakeXRDeviceInterface to match webxr-test-api
This updates the FakeXRDeviceInterface to support newly added methods in
the webxr-test-api:
* simulateVisibilityChange
* setBoundsGeometry
* setLocalToFloorLevelTransform
* clearLocalToFloorLevelTransform
and supports the setting of boundsCoordinates and
localToFloorLevelTransform in FakeXRDeviceInit.
The Bounds and LocalToFloorLevelTransform functions already existed on
internal tests, and as such a few of the tests that were ready were
ported to external wpts.
Note that simulateInputSourceConnection and disconnect will be
implemented by future work.
Bug: 979316
Change-Id: Idfb8bb631bfc1f1cb13b571a90b1a41b4a6fe518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692038
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676087}
--
wpt-commits: a24d86919d18a817e8449357dfa6db78fe3afe93
wpt-pr: 17740
Automatic update from web-platform-tests
Fetch: Delay buffering Response data.
When a service worker executes code like `evt.respondWith(fetch(r))` we
should be able to directly pass the fetch's resulting mojo::DataPipe
through without any data copying. This previously did not work,
however, since the BufferingBytesConsumer would immediately start
buffering the Response body data.
This CL fixes this issue by delaying the start of the buffering by a
short amount of time. This gives the service worker time to drain the
pipe.
The delay is currently disabled by default behind the
"BufferingBytesConsumerDelay" feature.
Based on yhirano's draft CL at crrev.com/c/1383755.
Bug: 911036
Change-Id: I65675ce62a7ce593c8994b3e1258634840ba6c2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679669
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676053}
--
wpt-commits: c8de5e13ed52cdf9fdee9f508e90d0ee9a09cc6a
wpt-pr: 17745
Automatic update from web-platform-tests
Add support for overscroll-behavior logical longhands
Flow relative longhands have been added to overscroll-behavior
specification [1]. This CL implements the relevant css parsing
and matching tests.
minor change: collapse all overscrollBehavior related case
statements in parser fast path.
intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ
[1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical
TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/*
Bug: 833953
Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676042}
--
wpt-commits: 56df7802935322e54c1ba7853963d7eb16ca0fc2
wpt-pr: 16890
Automatic update from web-platform-tests
part 2. Fix parsing of margin attributes on <body> match the spec.
The various margin attributes on <body> are "pixel length attributes" in the
spec, which should get parsed as non-negative integers. That said, Chrome and
Safari implement marginwidth, marginheight, marginleft, and margintop as
"dimension attributes" instead, and don't implement marginright and marginbottom
at all.
Differential Revision: https://phabricator.services.mozilla.com/D36372
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562257
gecko-commit: 399e8e089eda6d6cba06bb37c3aadacc607fe6b6
gecko-integration-branch: central
gecko-reviewers: mccr8
--
part 3. Change the dimension attribute reflection test to handle the attribute name and CSS property name not matching.
We're going to need that for hspace/vspace
Differential Revision: https://phabricator.services.mozilla.com/D36373
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562257
gecko-commit: 651433227fdbeb4fd53d90c15fac3dad3b1245a6
gecko-integration-branch: central
gecko-reviewers: mccr8
--
part 4. Fix style mapping of hspace and vspace attributes to match the spec.
Per spec, "hspace" and "vspace" are parsed as dimension attributes and are
supported on the following elements: embed, iframe, img, object,
<input type="image">, marquee. Except no one implements this for iframe.
https://github.com/whatwg/html/issues/4742 tracks the spec changing accordingly.
As far as hspace/vpace on <table> go, Safari supports them in both quirks and
standards mode, while Chrome doesn't support them in either mode. The HTML spec
doesn't have them supported at all, and neither does the quirks mode spec, so
I'm removing the quirks-only support we had to align with the specs and Chrome.
Differential Revision: https://phabricator.services.mozilla.com/D36375
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562257
gecko-commit: bd2a2e91e9eefc6f27621620e11b93ffd8eca2e6
gecko-integration-branch: central
gecko-reviewers: mccr8
--
part 5. Fix style mapping of border attribues to more closely match the spec.
Per spec, "border" is parsed as a non-negative integer, only mapped if nonzero
(though this is not observably different from mapping even if 0, except if user
or UA stylesheets style the border), and supported on img, object,
<input type="image">, but NOT embed, iframe, or marquee.
This matches the Chrome and Safari behavior, as far as I can tell. The
substantive change here is that we are removing mapping for the <embed border>
case.
Differential Revision: https://phabricator.services.mozilla.com/D36376
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562257
gecko-commit: b8938b6afa9c4b498ec016d1b3d50be0e50684c0
gecko-integration-branch: central
gecko-reviewers: mccr8
--
wpt-commits: 16d86b2b8c5e8cda1bb529b053af153c3b3d6887, c3dec041a318c9af716aac3b2d95ff42aa5325f9, 008153ffff00b8201548b7f420c155f23b549ee4, e0a9e5eec6d3aeb770e65ab30ee6d19824928256
wpt-pr: 17758
Automatic update from web-platform-tests
HTML: remove nonsense JSON resources
Pretty sure we don't have a use for these.
--
remove more JSON
--
wpt-commits: 84ee83638741a79a2b6cf7e67bca1f9c9dc92695, 0f05ba74bb119f32981027aa72d2e3d67e03a4c4
wpt-pr: 17574
Automatic update from web-platform-tests
webdriver: allow trailing slash in test_get_current_url_file_protocol (#17679)
Fetcing file:// protocol is not standardised which means the test
has to be more forgiving of the URL returned.
--
wpt-commits: 59ea78a393b5c69fb01d67b7267444d334082299
wpt-pr: 17679
Automatic update from web-platform-tests
HTML: cleanup [[CanBlock]] tests
(These do not require COOP/COEP treatment as they test SharedArrayBuffer on a single thread, but still seems nice to reduce clutter.)
--
wpt-commits: e4b8a06127ec937a5a57f6f96470aabb6f8d4629
wpt-pr: 17688
Automatic update from web-platform-tests
Add structured clone tests for errors
This is tests for spec changes.
- https://github.com/whatwg/html/pull/4665
- https://github.com/heycam/webidl/pull/732
--
Add tests for cloning from another realm
--
Test some stuff before cloning
--
wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d
wpt-pr: 17095
Automatic update from web-platform-tests
Fix regression in webdriver tests
A large number of tests in webdriver directory are currently failing,
due to a change in the parameters of Find.css method by PR #17260,
which broke any tests that still supply the old parameters.
This commit changes the parameter order and uses default parameter value
to make the parameter list compatible with the old one.
--
wpt-commits: d528abff035d6596f68f21a9510ee1c5b58a1e48
wpt-pr: 17754
Automatic update from web-platform-tests
[docs] Correct typo in example of user styles
`userstyle` and `nouserstyle` are referenced as CSS class names in this
document, so they should be declared as such.
--
wpt-commits: 0e95bf3183c7358f3bb428f6f1cc3db5e86b1e79
wpt-pr: 17748
Automatic update from web-platform-tests
[docs] Remove unused files
These files have not been used since the documentation site was
re-implemented to use Sphinx. They may be removed without affecting the
published website.
--
wpt-commits: 699d35e4e53a7f4595a43b43bcc96c21e29a80e9
wpt-pr: 17739
Automatic update from web-platform-tests
Orientation/Portals: make SharedArrayBuffer non-optional (#17720)
The plan is that SharedArrayBuffer is always available.
--
wpt-commits: bb674f5baec1f1b25d8da1a6fe3d941c3b106e9a
wpt-pr: 17720
Automatic update from web-platform-tests
[UserTimingL3] {}, null, undefined passed to start treated as 0
According to the spec (https://w3c.github.io/user-timing/#measure-method),
UserTimingL3 API has the second argument being:
optional (DOMString or PerformanceMeasureOptions) startOrMeasureOptions
This indicates that the arg cannot distinguish between:
1. null
2. {}
3. undefined
4. { invalidDictProperty }
According to the spec:
3.1.3 measure() method...
3. Compute start time as follows..
4. Otherwise, let start time be 0.
When these indistinguishable values are passed, they should be
interpreted as start time being 0.
Bug: 953840
Change-Id: I052a7823d9ae8b27056f53f04a26fcc93421db75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691862
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675873}
--
wpt-commits: 1f346b050d87656a040fa4fdf9f99567164e2a2b
wpt-pr: 17735
Automatic update from web-platform-tests
Handle non-negativeness of blur radius properly
Spec on blur radius says [1]:
"... Specifies the blur radius. Negative values are not allowed."
Current implementation performs parse time range check, which is
incorrect as calc() doesn't always have a double value. And spec
requires clamping instead of parse time check for calc() [2]:
"Parse-time range-checking of values is not performed within math
functions, and therefore out-of-range values do not cause the
declaration to become invalid. However, the value resulting from
an expression must be clamped to the range allowed in the target
context."
This patch changes it to pass |kValueRangeNonNegative| to
|ConsumeLength| as it handles non-negative calc() more properly.
This is also preparation for adding DCHECK into GetDoubleValue() to
avoid calling it on calc() without a double value.
[1] https://drafts.csswg.org/css-backgrounds-3/#shadow-blur-radius
[2] https://drafts.csswg.org/css-values-4/#calc-range
Bug: 979895
Change-Id: Ia8c36641f4ec4111ecf5a94a6ffc6eaacf22049c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691747
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675815}
--
wpt-commits: 65d3f17c56ea812d121669e6268a0cec4a4ea4a6
wpt-pr: 17741
Automatic update from web-platform-tests
Serialization of consecutive tokens. (#17746)
* Serialization of consecutive tokens.
Per <https://drafts.csswg.org/css-syntax/#serialization>, many token pairs, if they find themselves consecutive in a value, must be serialized with a comment between them, because otherwise upon serialization+reparse they'll produce a different token stream.
--
wpt-commits: dacb51937397fd06727727614e255f223e7cb9f3
wpt-pr: 17746
Automatic update from web-platform-tests
Add new tests for Core-AAM: (#17742)
* aria-expanded on: application, checkbox, switch
* aria-required on: checkbox
* aria-posinset and aria-setsize on: row
* inclusion of children of math role
* group as valid child of listbox
* menucheckbox as valid child of group in menu
* subscript and superscript roles
* meter role
* time role
* insertion and deletion roles
--
wpt-commits: f56d498d4dde12aacf8d6bbe591d35488af06a2b
wpt-pr: 17742
Automatic update from web-platform-tests
Fix feature policy origin comparison for sandbox.
When 'self' was specified in a feature policy header for a sandboxed
page, the resulting policy would not actually allow the feature in that
page, even when it would otherwise have been allowed. This corrects that
by assigning the correct origin to the policy and accepting that origin
in allowlists.
Bug: 973880, 690520
Change-Id: I93325bf24119068f8138f6e38507598cc30cbb06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689958
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675737}
--
wpt-commits: 6493155a3b1c0a0236aa4059a1ef768961578f98
wpt-pr: 17729
Automatic update from web-platform-tests
[LayoutNG] Ensure self-collapsing block relayout when ancestor resolves.
This bug was a combination of older code before we had "forced" BFC
block-offsets.
We didn't correctly detect when we had a self-collapsing block (which
had floats within it) that needed relayout if the initial estimate
was wrong.
This makes sure we give ourselves enough information to detect these
cases.
Bug: 980803
Change-Id: Id1ea5e10d819cb4509fd7664564b75b876f0f7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690720
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675729}
--
wpt-commits: 137960cfe6ce5b4dfb7a6d0bad126d517e03e009
wpt-pr: 17733
Automatic update from web-platform-tests
Fix decision of whether to drop y value for 2d translate
Spec requires dropping y value for 2d translate if it's zero (*). The
current implementation contains bug that:
1. It rounds the value before checking, which results in incorrect
dropping of '0.1px'
2. It calls DoubleValue() on calc() without type checking, while
DoubleValue() on calc() is meaningless when the calc() doesn't
resolve to a simple numeric value (e.g., 1px - 1%). This results in
incorrect dropping of some calc().
Both are fixed by this patch.
This is also a preparation for adding DCHECK in DoubleValue() to ensure
that it's called only when calc() can be resolved into a simple numeric
value.
Bug: 979895
Change-Id: Ie8b846729b91e55006485a25fab0b65533983eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692202
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675708}
--
wpt-commits: d947446c473a627ee68835eab7dcb928d85488bd
wpt-pr: 17684
Automatic update from web-platform-tests
[docs] Fix the code blocks in pipes.py (#17738)
* [docs] Fix the code blocks in pipes.py
Some code blocks were previously not correctly indented or surrounded
with empty lines.
* Apply suggestions from code review
--
wpt-commits: 9d23e22e542d2722bdae1ca5a0b780349a12be79
wpt-pr: 17738
Automatic update from web-platform-tests
Include initial frame replication state on portal adoption.
This is needed so that checks that occur as part of navigation
don't get confused by the replication state (notably the origin)
of the portal guest contents being missing from the remote frame
in the host contents' renderer.
Since this state is pushed down into the blink::RemoteFrame,
we need InitializeCoreFrame to be called before we can set the
replication state. As a result WebRemoteFrame::CreateForAdoptedPortal
is created, which performs this initialization with the provided
HTMLPortalElement.
Included web test crashes before this CL.
Bug: 980937
Change-Id: I843192e5f5aa8e4e022a88d318fa4a5e1d46a3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677163
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675702}
--
wpt-commits: 7ab751c5295223c124723888edd1b9378d123b92
wpt-pr: 17624
Automatic update from web-platform-tests
[LayoutNG] Do not use out-of-flow cache if in inline container
This patch changes |NGOutOfFlowLayoutPart::LayoutCandidate()|
not to use a cached result if it has an inline container.
|NGLayoutResult::OutOfFlowPositionedOffset()| has an offset
relative to the inline formatting context block. When an out-
of-flow object has inline contianer, this offset may change
without setting |NeedsLayout()| to the out-of-flow object.
Bug: 981686
Change-Id: Ib8376f791af0b95f6c2b6e5c2361b6a887c74e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692107
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675686}
--
wpt-commits: e2d6701e64fbf664b53a4db86c53bffadd9fb9cf
wpt-pr: 17685
Automatic update from web-platform-tests
[docs] Remove legacy substitution escape sequences
The `{% raw %}` and `{% endraw %}` markers were required to correctly
render some content when the documentation website was generated by
Jekyll. They have no meaning in the context of the recently-introduced
Sphinx-powered build system, and they are pass through to the rendered
output directly.
Remove the markers.
--
wpt-commits: 5267fe13c8a23fe05f952ffd7e790e4d9fe2dcd9
wpt-pr: 17737
Automatic update from web-platform-tests
[ci] Split Edge Canary into a separate job
Do not run Edge Canary and Edge Dev in the same job to prevent them from
overwriting each other. This also makes Edge setup the same as Safari
(two jobs for Safari & STP) on Azure Pipelines.
--
wpt-commits: 5a6c83e5332ea8c072cd088bb4aa3320bf8605a7
wpt-pr: 17731
Automatic update from web-platform-tests
[web-animations] Make handling of keyframes more spec compliant
WebAnimations spec has two keyframe concepts:
A) keyframes [1]
B) computed keyframes [2]
A key difference is that in A property values remain unresolved while in
B these properties are resolved (e.g., shorthands expand to long hands
etc.)
KeyframeEffect.getKeyframes() is expected to return (A) but our current
implementation only keeps around (B).
This CL introduces the following changes to bring us closer to the
specified behavior:
1. Introduce a new map <property, value> in StringKeyframe
representing (A)
2. CSS property pairs are added to this map as long as they parse
correctly [3]
3. Use the new map to produce the result of getKeyframes()
There is some additional special handling required for shorthand
properties because Blink CSS parser does not really produce any
shorthand values. As a shortcut this patch introduces a new type
of css value (`CSSKeyframeShorthandValue`) which represents a
shorthand by encapsulating all its relevant longhand property/value
pairs.
Note that we continue our old behavior for SVG and Presentation attrs
which will be switch over in follow up patch.
[1] https://drafts.csswg.org/web-animations/#keyframes-section
[2] https://drafts.csswg.org/web-animations/#calculating-computed-keyframes
[3] https://drafts.csswg.org/web-animations/#process-a-keyframes-argument step 8
TEST:
- web-animations/interfaces/{Animatable, Keyframes} => PASS previously failing tests
- Added two new test cases in above covering animated custom props
- external/wpt/web-animations/interfaces/KeyframeEffect/getKeyframes.html => New test to cover serialization
Bug: 816956
Change-Id: Icc8e0bc4a0ee3019ad7d2c566aacb9d3aee0ffe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634393
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675665}
--
wpt-commits: 631824bf82ea23e59604b443ab62c9b123eb25d5
wpt-pr: 17083
Automatic update from web-platform-tests
[wpt PR 17288] - Revert "Active Processing for ConvolverNode", a=testonly
Automatic update from web-platform-tests
Revert "Active Processing for ConvolverNode"
This reverts commit 499976c54a2b086bbde54ae137d0ac4adb3cd427.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 668149 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDk5OTc2YzU0YTJiMDg2YmJkZTU0YWUxMzdkMGFjNGFkYjNjZDQyNww
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/15474
Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6
Sample Flaky Test: external/wpt/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https.html
Original change's description:
> Active Processing for ConvolverNode
>
> The ConvolverNode should output a single channel of silence when it is not
> actively processing. Active processing is already supported and just needed
> to have the convolver output a single channel of silence when it is
> constructed, before anything is connected to it.
>
> Bug: 971389
> Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668149}
Change-Id: Ie7fedee332ca167c3dfd4fd99142de89234ff03a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 971389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653924
Cr-Commit-Position: refs/heads/master@{#668243}
--
wp5At-commits: 2477f79f3c0757225d06762aeb1d3b1eea6eb52a
wpt-pr: 17288
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1558779
gecko-commit: 9f3894cee297f22e93ac8b76176ec52474ce5a00
gecko-integration-branch: central
gecko-reviewers: testonly
--
wpt-commits: 0968cc9522f12cf46972ede6423d3ab0742ebc24
wpt-pr: 17722
Automatic update from web-platform-tests
[docs] Consolidate instructions on server features (#17482)
* [docs] Consolidate instructions on server features
The file `server-side.md` duplicates much of the information available
in the `docs/` directory. Remove `server-side.md`, preserving its unique
content in the relevant files within the `docs/` directory.
--
wpt-commits: 8119bc10583682676a3db9806c82ed4044e88e13
wpt-pr: 17482
Automatic update from web-platform-tests
Deal with the virtualenv .Python link being broken
This happens relatively frequently on macOS when using Homebrew, as
Homebrew installs into versioned paths, so following an upgrade and
a cleanup of the old install, the old path no longer exists.
--
wpt-commits: 5ef31c71071b18b3164eb9eca0e991aab4313c54
wpt-pr: 17522
Automatic update from web-platform-tests
Ensure that the mozlog lock is released when starting test runner processes.
--
wpt-commits: af7f76ee8f480e3dc5c8b3c39edebc7a50ae6abf
wpt-pr: 17564
Automatic update from web-platform-tests
Add missing help for text-transform math test. (#17686)
--
wpt-commits: 7ed3166ac0fb3cd33c63db4846f522a0d30f8b3e
wpt-pr: 17686
Automatic update from web-platform-tests
Defer laying out atomic inline while traversing inline children
This patch reverts [1] so that, when in full layout mode, it
prevents |LayoutInlineChildren()| from doing any layout in
its |InlineWalker| loop.
The crash occurs because |DirtyLineBoxesForObject()| can
destroy |InlineTextBox| without unlinking them from the list,
assuming the tree was already destroyed. We could either:
a. Change |DirtyLineBoxesForObject()| to unlink |InlineBox|es
it destroys.
b. Prevent laying out any children in this loop.
This patch chooses the optoin b.
Laying out atomic inline in the descendant traversal loop of
|LayoutInlineChildren()| was delayed after the loop in [2],
then it was changed to use a temporary list in [3].
The temporary list was removed in [1] because the original
test (fast/block/inline-children-root-linebox-crash.html) no
longer crashes. But laying out in the descendant traversal
loop should still be avoided.
[1] r390765 https://codereview.chromium.org/1933633002
[2] https://trac.webkit.org/changeset/118248/webkit
[3] https://trac.webkit.org/changeset/125810/webkit
Bug: 981602
Change-Id: Ie37a611aa7f6dc9b015d449ac75570c356ce654e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690379
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675479}
--
wpt-commits: 7b1ce62b0f9796d78a30d2765189e42a1d0616e6
wpt-pr: 17669
Automatic update from web-platform-tests
[UserTimingL3] Always serialize detail
UserTimingL3 specs that the detail property of the measure method and
the performance mark constructor both need to serialize the detail
property:
In https://w3c.github.io/user-timing/#measure-method:
"Set entry's detail attribute as follows:
If startOrMeasureOptions is present and is a
PerformanceMeasureOptions object, set it to the result of calling
the StructuredSerialize algorithm on startOrMeasureOptions's detail.
Otherwise, set it as null."
In https://w3c.github.io/user-timing/#the-performancemark-constructor:
"Set entry's detail attribute to the result of calling the
StructuredSerialize algorithm on markOptions's detail."
In the current implementation of the performancemark constructor, it
serializes the detail only when the world of constructor and
the world of accessing the detail are different. To correct this, we
should serialize in both situations.
In the current implementation of the measure method, it does serialize
in both cases, but it swallows the exception. We should not swallow the
exception so as to "fail early, fail loudly"
Bug: 953857, 963926
Change-Id: I471c4d207d9c05bc9b9b8b65315c49b0aa73a672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620748
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675461}
--
wpt-commits: 09cbd6bc9ecc7349e9e38e6b2dd7e1d53dfb79ef
wpt-pr: 16937
Automatic update from web-platform-tests
Update MsEdgeDriver download to get driver binary based on channel info (#17540)
--
wpt-commits: 97a1a7874a9d0e97c340701b7b5e5f526fbfecfe
wpt-pr: 17540
Automatic update from web-platform-tests
Reland "[WPT] Reland Upload a test for sending mouse events with key pressed"
This reverts commit d91140eca4d13c992fe1803664adaf9605199610.
(i.e. relands c4dc34414b232ed5575d6a61837e2cfb32def045)
Original change's description:
> Revert "[WPT] Reland Upload a test for sending mouse events with key pressed"
>
> This reverts commit c4dc34414b232ed5575d6a61837e2cfb32def045.
>
> Reason for revert: actionsWithKeyPressed.html fails on MacOS
>
> Original change's description:
> > [WPT] Reland Upload a test for sending mouse events with key pressed
> >
> > When we have keyboard events and mouse events send together, we should
> > set key modifies in mouse events. This test first presses some keys
> > then send some mouse events. This test only works on Chrome.
> >
> > Bug: 606367
> >
> > TBR=nzolghadr@chromium.org
> >
> > Change-Id: Idad0bcca2c03f961f6c6af211d7f843f06e14fc1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544170
> > Reviewed-by: Lan Wei <lanwei@chromium.org>
> > Commit-Queue: Lan Wei <lanwei@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#653672}
>
> TBR=lanwei@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 606367
> Change-Id: I1569088b67060cf8fa749ec0dc725fe551a990c5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689030
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#674840}
TBR=lanwei@chromium.org
Bug: 606367
Change-Id: I06139386a7eb4d0b2323d48688a7b2cffbe0a583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690568
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675379}
--
wpt-commits: d73c675597c48e53b6fe1955a866d820518c2ee9
wpt-pr: 17678
Automatic update from web-platform-tests
bluetooth: Standalone Tests for characteristic/
This change refactors the Web Bluetooth WPT tests in the characteristic/
directory to be standalone window tests, as well as use the async/await
pattern. This makes the tests easier to format and easier to read.
The generated tests are not updated in this patch because they will
require updating the Python script that generates them.
Bug: 509038
Change-Id: I74d2158bbff3ef3b30d5286129cc3fc855e9a9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682840
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675371}
--
wpt-commits: 175bb1c4268b76f5023708a11c9b48c694e7eae7
wpt-pr: 17578
Automatic update from web-platform-tests
WPT: Fix contain-style-counters-004.html with correct expectations.
contain-style-counters-004.html has spans as non-siblings of the
div that prints the number.
This patch adjusts the expectations to print 0, instead of 20. Note
that contain-style-counters-003.html already tests for siblings
relationship.
R=tabatkins@chromium.org, chrishtr@chromium.org
Change-Id: I0ca60bed403ba31844688b7f97db8c50628fcaf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689072
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675309}
--
wpt-commits: a09e43f71b85ea8dff2f77d58489ce95852e84f8
wpt-pr: 17652
Automatic update from web-platform-tests
Do not expose element, event, and layout-shift entries via getEntries
Currently, Performance's getEntriesByType, getEntriesByName, and
getEntries methods include buffered entries of types 'element', 'event',
and 'layout-shift'. We do not want to expose these to the performance
timeline now that the buffered flag is shipped. This CL removes them
from those methods and fixes/adds web_tests that check those methods.
Bug: 581518, 823744, 883483, 972830
Change-Id: I0d74794bcc205cded6684472cc56836e253856cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689073
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675032}
--
wpt-commits: c13852e02350b4e86a8c348885933f9e9b83e807
wpt-pr: 17676
Automatic update from web-platform-tests
Null-check the CSS Transition's effect when doing updates
If you use the (still experimental) getAnimations() API to modify a
running CSS Transition to have a null effect, and then immediately start
a new transition without letting the old one finish, we would try to
unconditionally access and use the |effect| member. Add some null checks
to avoid this.
Bug: 964113
Change-Id: I26de63234b5249689e82596173ac354ff1ca6eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690924
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675305}
--
wpt-commits: 9e1ff30db5610b44c74aae2394e4af095536a75c
wpt-pr: 17673
Automatic update from web-platform-tests
Worker: Simplify worker-interception.https.html
This CL removes unnecessary iframe creation, and adds test helper functions to
simplify the tests. This is just refactoring, and should work just like before.
Bug: 731604, 906991
Change-Id: I775567c64df0a7ed4b1931caf285c06f60b0b14b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683916
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673963}
--
wpt-commits: 1bac9e9d1715ca642d09ceb2a089db2b82c8714c
wpt-pr: 17593
Automatic update from web-platform-tests
Update entryType names to follow conventions
Currently, we have entryTypes 'firstInput', 'layoutShift', and
'largestContentfulPaint' in experimental code (disabled by default, at
most under Origin Trial). This CL updates the naming to follow the
conventions specified at
https://w3ctag.github.io/design-principles/#casing-rules, so they become
'first-input', 'layout-shift', and 'largest-contentful-paint'.
Bug: 823744, 965505, 581518
Change-Id: I989a59fb62b886ab305b0e0fb4be8f3556c1ca82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685975
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674490}
--
wpt-commits: f1a492a84b4cd1e4146f8f9d84ec34f902bebb4a
wpt-pr: 17644
Automatic update from web-platform-tests
Automate tap action on an element in an iframe (#17260)
--
wpt-commits: a9d6d1b058f9d37cabaf735ea60f9b87acc8a02b
wpt-pr: 17260
Automatic update from web-platform-tests
[tools] Remove use of deprecated API
The "message" parameter of Pytests's `raises` method has been deprecated
[1]. This causes a test failure in the current configuration. Since the
parameter was not previously serving the intended purpose (that is, it
was *not* verifying the message of the raised exception), it may be
removed without degrading coverage.
[1] https://docs.pytest.org/en/4.6-maintenance/deprecations.html#message-parameter-of-pytest-raises
--
wpt-commits: 8b642c10f67f0728f17d3284367d93c7480d290e
wpt-pr: 17648
Automatic update from web-platform-tests
Restore webidl2.js.headers.
It was added in #6685 and removed accidentally in #16864.
--
wpt-commits: 3387cf524436af6e29ad89b1b04ec94b8a76d4f9
wpt-pr: 17586
Automatic update from web-platform-tests
LayoutNG: Fix sizing and position of abspos tables
LayoutBox::ContainingBlockLogicalHeightForPercentageResolution was
adding padding but only for tables. NG already supplies padding so don't
do this table exception if the containing block is NG.
ng_absolute_utils relied on specified table width/height being the final
say, but tables use those as another min size. This patch makes
ng_absolute_utils treat table height/width as Auto for main sizing and
uses it as another min-height/width.
ResolveInlineLengthInternal assumes that anything with inline size Auto
will expand to fill the available space, but tables do not.
The 4-argument version of ComputeMinAndMaxContentContribution makes a
similar assumption to ng_absolute_utils -- if a node has a width set,
that's the final width. The 3-argument version of
ComputeMinAndMaxContentContribution is aware of this so bypasses the
4-argument version for tables and instead uses legacy preferred width
calculations, so I made ComputeMinAndMaxContentSizeForOutOfFlow do the
same.
The tests all at least partially failed in NG before this patch. After
this patch, NG matches legacy everywhere, except for the first 2 cases
of -002.html, which were broken in legacy and NG before this patch. It
is now correct in NG.
We partially fail 003 and 005, but identically to legacy layout.
I added more checks to fast/table/absolute-table-percent-lengths.html
and moved it to the wpt repository as
css/css-tables/absolute-tables-001.html .
Bug: 973390
Change-Id: I8cea275b2ca19492a501b84cd86456ed6745a4b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671851
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675142}
--
wpt-commits: 8e3db7f3a765d1783f7e8c068c8bf90de61b1f66
wpt-pr: 17432
Automatic update from web-platform-tests
CSS Animations: WPTs for responsive animations
column-rule-color animations respond to changes in currentColor
and inherited column-rule-color that occur while the animation
is in progress.
column-width animations repond to changes in font-size
and inherited column-width that occur while the animation
is in progress.
Note this test fails in
Edge 18
Firefox 67 (partially)
Safari 12.1
Bug: 812908
Change-Id: Ic28819a7f4aa3c8c30b11d58ea2600563a182c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689612
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675042}
--
wpt-commits: 3c5c83759bb5062de405b1c29257f89e884759fb
wpt-pr: 17658
Automatic update from web-platform-tests
Iframe can't be scrolled after scrolling='no' is modified to 'yes' by script.
When a LocalFrameView object corresponding to an iframe with scrolling attr
initial value 'no' is created, it will set CanHaveScrollbars to false. When
script modifies scrolling attr to 'yes', CanHaveScrollbars status should be
changed.
For example:
<iframe id='iframe_node' src='...' scrolling='no'></iframe>
<script>
var iframe = document.getElementById('iframe_node');
iframe.onload = function () {
iframe.scrolling = 'yes';
};
</script>
Bug: 979085
Change-Id: I07465df4d9cf38c37a61fa2606e17f2bc34777ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679750
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675037}
--
wpt-commits: 1ae7eb52c8153973f16d6ebf3a8ba363199e8895
wpt-pr: 17619
Automatic update from web-platform-tests
Add Preload + SRI image destination tests
This CL adds all of the Preload + SRI tests for the as=image
destination. Chrome is not implementing Preload + SRI on non-{script,
style} destinations immediately, but it is good to add the tests for
these destinations so that the future implementation's success can
easily be tracked and measured.
R=kouhei@chromium.org, yhirano@chromium.org
Bug: 981419
Change-Id: I7e04c4ff9df400942782ab224ea5148f9874969f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689511
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674980}
--
wpt-commits: 550b9db5975f88173a5c9ceb1d576376288f18d7
wpt-pr: 17655
Automatic update from web-platform-tests
Add more combinations for scrollIntoView (#17647)
This patch added more combinations of writing-mode and css direction for scrollIntoView.
Now we have tested: horizontal-tb, horizontal-tb with rtl, vertical-lr, vertical-lr with rtl and vertical-rl.
The scroll bar position of vertical-rl with rtl is not consistency in browsers, and the specification doesn't indicate the position. And scroll bar position will affect the scroll coordinate. So this test is pending.
--
wpt-commits: c9cb3807e0031f551aa4c188923640f6cebe793a
wpt-pr: 17647
Automatic update from web-platform-tests
Document::CheckComplete should be nop when called from RequestResource
Otherwise,
1 when the request is served from the memory cache, it conflicts with
a ScriptForbiddenScope (already covered).
2 when the request is a synchronous XHR call,
ResourceLoadObserver::DidFinishLoading is called synchronously,
which means Document.readyState change would be observable
synchronously (A NEW PROBLEM).
The ResponseSource parameter in ResourceLoadObserver::DidFinishLoading
was introduced to fix 1, but with this change it's not needed. Remove
it.
Bug: 977486
Change-Id: I103032600c66837475850c87d8a3823a85e5b27f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687014
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674947}
--
wpt-commits: 1d7610e955878a6fccd01cd545639c5629c237ee
wpt-pr: 17620
Automatic update from web-platform-tests
[Native File System] Remove remove and removeRecursively operations
These operations are no longer part of the spec. This CL removes their
implementation.
Bug: 968553
Change-Id: If2600a55bd724bf2fee537b36a3bece8fd5c1313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680173
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674922}
--
wpt-commits: 8327a0378e5cbd6f31db6511bd2f4707ca2b1c20
wpt-pr: 17654
Automatic update from web-platform-tests
[Native File System] Implement removeEntry operation
The removeEntry operation is to substitute the remove and
removeRecursively operations according to the spec.
Bug: 968553
Change-Id: I3f99f51e643fe0d7c50859d6b971faf8446c3b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680172
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#674911}
--
wpt-commits: 6974bcc39ed029ab62c719378d8dbc66ad7495d5
wpt-pr: 17545
Automatic update from web-platform-tests
Re-enable RTCRtpSender-getStats.https.html tests.
This was temporarily disabled to unblock a roll.
A helper function used by the test is updated to reflect the fact that
audioLevel is not always present.
Bug: 736403
Change-Id: Ia2d7b51d58f23023bf5894fbf2707ba155d9ac9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688954
Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674856}
--
wpt-commits: 7de7666607b4e4ea60a04c601a4c91b3cb7d673a
wpt-pr: 17643
Automatic update from web-platform-tests
Revert "[WPT] Reland Upload a test for sending mouse events with key pressed"
This reverts commit c4dc34414b232ed5575d6a61837e2cfb32def045.
Reason for revert: actionsWithKeyPressed.html fails on MacOS
Original change's description:
> [WPT] Reland Upload a test for sending mouse events with key pressed
>
> When we have keyboard events and mouse events send together, we should
> set key modifies in mouse events. This test first presses some keys
> then send some mouse events. This test only works on Chrome.
>
> Bug: 606367
>
> TBR=nzolghadr@chromium.org
>
> Change-Id: Idad0bcca2c03f961f6c6af211d7f843f06e14fc1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544170
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#653672}
TBR=lanwei@chromium.org
Bug: 606367
Change-Id: I1569088b67060cf8fa749ec0dc725fe551a990c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689030
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674840}
--
wpt-commits: 59d845bb6f7c9fb271e91262f659e7a8a3e70d9f
wpt-pr: 17641
Automatic update from web-platform-tests
Enable LayoutInstabilityMoveDistance by default.
This CL will be followed by a CL to remove the conditional logic
for move distance in LayoutShiftTracker.
Change-Id: I9ecb10a33d4c79830e240e96913da4bec652e96b
Bug: 981338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686713
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674819}
--
wpt-commits: 218bb5da6f686abf472c91c4dcfe1c3133487f9d
wpt-pr: 17640
Automatic update from web-platform-tests
Adding multipart/byteranges to the never sniffed list. (#17557)
Multipart range requests would allow bypassing CORB since the response
will have type multipart/byteranges instead of the resource's
original MIME type.
Blocking multipart responses is compatible with the web because the
renderer can only see into the result of a fetch for a multipart file
when the request is made with CORS. Media tags only make single-range
requests which will not have the multipart type.
Bug: 802836
Change-Id: Ib4ff928fdf9c604055f0d5ec52fcb5bee578099f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678394
Commit-Queue: Kristina Nelson <krstnmnlsn@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673851}
--
wpt-commits: c085fba4ff2ad1341e308b453f2c7207d4b27e4e
wpt-pr: 17557
Automatic update from web-platform-tests
[webnfc] Introduce AbortSignal in NFCPushOptions.
This CL added the AbortSignal member in NFCPushOptions and use it
to cancel unhappened push operation. Tests have also been adjuested
accordingly.
Original change in the Spec:
https://github.com/w3c/web-nfc/pull/165
Bug: 520391
Change-Id: Ic69fde2bc343c65ed5c337dcfdbdeca97b456ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680418
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674723}
--
wpt-commits: 845988417926b440697dc5d66ba5fa8891cbea52
wpt-pr: 17550
Automatic update from web-platform-tests
Reland "Fix first line style caching issues"
This is a reland of 228ee33446fc20cef8fcc94503a91c16bbcfc6fb
Compared to the original CL, this relanded (again) CL has the
following changes:
- Remove the lazy update of first line image observers which was not
needed and didn't work (causing reentrancy of
UpdateFirstLineImageObservers),
- In LayoutObject::UpdateFirstLineImageObservers(), hold the first
line style's reference locally because UpdateImageObservers may
call LayoutBlockFlow::ImageChanged() which invalidates the cached
first line style.
Original change's description:
> Fix first line style caching issues
>
> 1. Cache conflict issue:
>
> Previously calls to Element:: Element::CachedStyleForPseudoElement()
> with different second parameters caused cache conflict. The second
> call to it might get unwanted result that was cached with a different
> second parameter.
>
> Now remove the second parameter, and the function gets and caches the
> pseudo style only based on its own computed style. If a caller wants
> a pseudo style based on another style, the caller should call
> Element::UncachedStyleForPseudoElement() and manage cache by itself.
>
> 2. Under-invalidation on change
>
> Cached first line style needs invalidation in two cases:
> a) when the ::first-line style changes, we should invalidate all
> cached first line styles affected.
> b) when style of an inline element (which inherits ::first-line
> style) changes, as the inline element's style has higher priority
> than the inherited ::first-line style, even if the style doesn't
> change, we need to invalidate the cached
> kPseudoIdFirstLineInherited style if the new style is different
> from the inherited ::first-line style.
>
> Bug: 979054
>
> Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673574}
Bug: 979054
Change-Id: If7211c585df77964789140277839a8f1c3822a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685672
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#674509}
--
wpt-commits: bc0eab5e5ed10c689f6f08028a2060daddb3e32a
wpt-pr: 17610
Automatic update from web-platform-tests
[PW] Make PW canvas transform account for device scale factor
Right now when the zoom-for-dsf feature is not enabled (currently on
Mac only), the recording canvas has its own logic to handle device
scale factor. Given an example, when we run chrome on Linux with
--force-device-scale-factor = 2, the transformation matrix for the
recording canvas has a scale of (2, 2). But when this is on Mac, the
transformation matrix has a scale of (1, 1). This causes a big problem
when call setTransform() canvas API because it changes the
transformation matrix in an unexpected way without accounting for the
device scale factor.
In this CL, we give the PaintRenderingContext2D a new member which
is specifically the device scale factor on a platform where the
zoom-for-dsf is not enabled. Then whenever a setTransform is called,
we need to account for the device scale factor.
Bug: 970783, 716231
Change-Id: Idaca018a9afab656f868079dd8dd9324327da4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682659
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674488}
--
wpt-commits: 6e93013acee5454f1a7313f42af409cf8bd46e65
wpt-pr: 17603
Automatic update from web-platform-tests
Fix pen pointer capture in iframe
When set/release/check pointercapture, we checked whether it's touch
type pointer. This is because touch like events will route to local frame
root's PME, while mouse like events will route event to hit tested frame.
However, it didn't check whether pen type events are send like touch.
This CL makes set/release/has pointercapture always check whether pointer
is active in the capture element's frame, if not, then check the local frame
root. So we can avoid checking the pointer type.
1.For touch-like events, pointer active state is not available in inner frame and
we will always fall into checking local frame root.
2.For mouse-like events:
* When trying to set capture to a frame that has pointer active,
|IsPointerIdActiveOnFrame| will return true and pointer capture is allowed.
* When pointer is active in the outer frame, and trying to set to an element in
inner frame; or pointer is active in the inner frame, and trying to set to an
element in outer frame. The element's frame's |IsPointerIdActiveOnFrame| will
failed and also |RootFramePointerActiveInCurrentFrame| will check locat root
frame's |element_under_pointer_| and forbid the request because target frame
dismatch.
This will fail the case that mouse down at local frame root and move to a inner
frame. Because we are moving inside and no "leave" event send to outer frame.
Outer frame still has info of pointer is active, and did not update the
|element_under_pointer_|. But this case is failed without this change as well.
We are not going to address this with this change.
The test has an expected file for the second test failing on 'pen'. It's
PEM.GetMouseCaptureTarget returns the target for kMouseId, but for layout
test, pen events is send as mouse-like but has different id.
It's unnecessary to fix this now as we have direct manipulation enabled
on all platform, we're not likely to have mouse-like pen event for capturing.
It'll be fixed once we have pen event on test driver work as current pen
flow. Our Q3 plan that having pointerevent states per page should also fix
this.
Bug: 970595
Change-Id: I7f9f390d1526eefee4657f7b859edf5ad4d163ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649519
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674487}
--
wpt-commits: fbf38bd7d9dbc2f074d9110112d563ab47efd015
wpt-pr: 17358
Automatic update from web-platform-tests
[css-text] Hang sequence of white spaces that may otherwise overflow
When a item overflows, we try to find a safe position that breaks the
item to avoid it. However, we should consider that sequence of white
space characters might have to be hanged, honoring the white-space
property.
We manage that case correctly the overflowing text is part of a
previously broken (kSuccess result from BreakText) item. However, if
there is an item that starts with a white space sequence and it
overflows, we always try to break it instead of hanging.
This patch address the issue by detecting such overflowing item,
verifying that it has a white space sequence and the white-space
property's value allows hanging it. In that case, we should rewind
the iterator, so that the further item_results are removed and skip
the rest of the overflowing handling logic.
Bug: 973358
Change-Id: I0e2ad5c5740f4ce592dd83b8ff3d224dbb45117e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662451
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#674430}
--
wpt-commits: 6dd8159628d492944540af129cf90e4bd692420c
wpt-pr: 17376
Automatic update from web-platform-tests
Reland: Cleaning up ElementTiming and EventTiming observer buffer behavior.. (#17608)
Original land in crrev.com/c/1654876
Reverted in crrev.com/c/1680091
1) Remove methods that handle the buffers separately
2) Remove only buffering until onload
3) Fixing up wpt tests associated with both
Bug: 969123
Change-Id: Ie63b37d9ff118007462c635c745a4eacaa4be16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684677
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674080}
--
wpt-commits: 83a739f36b26abff6d2f0ecf27038701072bac6f
wpt-pr: 17608
Automatic update from web-platform-tests
Update WebXR TestAPI and tests to match new spec (#17630)
Now that WebXR is more mature, the test API is being revisited with
input from other UAs. This change updates existing methods and tests
to match the new API, which largely involves:
* FakeXRDeviceInit now requires views
* FakeXRDeviceInit *CAN* support an initial viewerOrigin
* setXRPresentationFrameData is now setViews and set/clearViewerOrigin
* XRTest is now navigator.xr.test [1]
As part of this, webxr_test_constants were cleaned up and expanded to
help minimize boilerplate code in the tests. Where possible tests that
were previously calling setXRPresentationFrameData to ensure that the
fake device was "tracking" were updated to instead use a constant that
sets these values. Future work (after the API update is complete) will
identify if there are any cases where an initial requestAnimationFrame
could be removed.
Most changes (especially to vr/ tests) should be fairly mechanical, but
now that the eye offsets expected/set by the test are actually being
plumbed through, both xr/xrReferenceSpace_originOffset tests had to have
their expected matrices updated. Two tests had to be updated due to the
discovery of 981003.
Other changes to update to the Test API after this change should be
mostly additive and should actually already exist in the internal tests.
[1] XRTest currently still exists as a workaround until 944987 is merged
Also due to the fact that accessing xr blocks VR, the WebVR tests had to
be updated to set a special flag to tell the test API to not set the
object on XR. It's unlikely that this behavior will be able to be
removed after 944987, but to allow XRTest to be removed these tests have
had it migrated to navigator.vr.test
Bug:979312
Change-Id: I19ccffd921728ec3799252693d945b7b3f99d757
--
wpt-commits: 3f8ee365a7cacc091dc1dd1d0b5f21a89241c894
wpt-pr: 17630
Automatic update from web-platform-tests
Split out the manual parts of webauthn idlharness test (#17417)
* Remove manual parts of webauthn idlharness test
* Remove duplicated object
* Remove WebAuthentication interface
* Reinstate deleted challengeBytes
* Remove unneeded conditional
--
wpt-commits: cd18d4954c5184ecfb7a210aa939081c5e2552e8
wpt-pr: 17417
Automatic update from web-platform-tests
Add test of direction:rtl for ScrollIntoView (#17622)
* Add test of direction:rtl for ScrollIntoView
Test the behavior of ScrollIntoViewOptions in direction:rtl page.
* Fixed code review issues
Fixed code review issues.
--
wpt-commits: b7e9c990780705608441f5ae14ffb67e1aba7799
wpt-pr: 17622
Automatic update from web-platform-tests
Fix expectation for css/cssom-view/scrollIntoView-vertical-rl-writing-mode.html (#17621)
- Improve the code to make it more readable
- Better handle browser inconsistencies
--
wpt-commits: 5b224fe81f10d807bd47711d5a92f6754beb3b8a
wpt-pr: 17621
Automatic update from web-platform-tests
[webnfc] Adjust returned error for NFC HW not supported case.
According to the Spec, this CL adjusted some error types for NFC
hardware not supported and permission not allowed cases. Original
changes in Spec are listed as follows.
aa50e6e193https://github.com/w3c/web-nfc/pull/236
Bug: 520391
Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#674390}
--
wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d
wpt-pr: 17519
Automatic update from web-platform-tests
Add tests for new math values of CSS text-transform (#16922)
* Modify mathvariant-transforms.py to generate CSS tests for "text-transform: math-*" (other than math-auto).
* Modify mathvariant-transforms.py to generate tests for single-char <mi> and text-transform: math-auto.
* Add a test to verify 'text-transform: math-auto' on text nodes of different lengths.
* Move text-transform-math tests into their own subdirectory.
* Update meta help to point to mathml core spec.
--
wpt-commits: 1af7e47d15ec171bb181fc5e3309bcfb52dd8f01
wpt-pr: 16922
Automatic update from web-platform-tests
mojo: Move meta API methods for receivers to $
Moves bindHandle(), createProxy(), and close() to the "$" member of the
generated receiver classes.
Bug: 968369
Change-Id: I0549bd23221343afda5a2733d601f6c56bdc1b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639036
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674309}
--
wpt-commits: f83c9a52301a18819bd317b137b6c15553a1f2f2
wpt-pr: 17584
Automatic update from web-platform-tests
Reland "Insert a generated item after preserved spaces following a forced break"
This is a reland of 6b0ca8ce33e71d570fce11ae6fb5f898ddf053e4
The root cause of the regression that motivated the revert was that in the
original commit I removed a Failure entry by mistake from the TestExpectations
file.
The removed entry was added precisely for the word-break-break-all-004.html
test only for Mac platforms. This was the test that regressed, since the
original path didn't provide any behavior change affecting the mentioned
test.
So this CL tries to reland the original patch, but restoring the Failure entry
for the word-break-break-all-004.html test in Mac platforms.
Original change's description:
> Insert a generated item after preserved spaces following a forced break
>
> We already had to implement a special logic to deal with leading
> preserved white spaces due some optimizations we have in the line
> breaking code to give always breaking opportunities before spaces.
>
> However, the presence of forced breaks may cause some of the following
> spaces becoming leading preserved spaces in the next line.
>
> This patch applies the same logic we had for such leading spaces at
> the text's first line. It also needs to define additional cases in the
> function that evaluates the need of adding these generated breaking
> opportunity items.
>
> Bug: 976195
> Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671656}
TBR=kojii@chromium.org
Bug: 976195
Change-Id: Id55acef369248ec30f5cfa68cbb59051bf7af8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683234
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#674305}
--
wpt-commits: 93483b4118a0af7fbb6ac3f1c4dc67fa9fbdf916
wpt-pr: 17618
Automatic update from web-platform-tests
Ensure that WebXR mojom types are properly assigned in JS
In JS the types aren't created via a standard "Constructor" like method
but instead by a map with the corresponding fields set. This updates a
few types that were being incorrectly constructed.
Bug: 980759
Change-Id: I1a6e8f033b89f08ffb92e6c1abf8a84631bf4649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686603
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674304}
--
wpt-commits: 9bbeb647445cd6858de91ee45ab4a05cb165e504
wpt-pr: 17617
Automatic update from web-platform-tests
[ElementTiming] Check opacity of image before exposing
Before CompositeAfterPaint, we would just rely on painting being skipped
when an image has opacity:0. Now, we need to explicitly check because
paint is no longer being skipped.
Bug: 959949, 879270
Change-Id: I57590798e7f76c4c63a6062f145f95fa1eec6c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680867
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674252}
--
wpt-commits: 1e05bb271ae12717e383a6e3da625127cb88dcd0
wpt-pr: 17562
Automatic update from web-platform-tests
Move a pointercapture pointer test to non-wpt pointerevent tests.
This test initially added to wpt but the behavior is not clearly defined
in spec. So move to non-wpt pointerevents test.
See discussion in https://github.com/w3c/pointerevents/issues/291TBR=nzolghadr@chromium.org
Change-Id: Ic871c57526681d790d6e68081f5a4bf8316e8494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684464
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674191}
--
wpt-commits: 060265cb71f8cbe6e9a042e245232a0fabb07048
wpt-pr: 17614
Automatic update from web-platform-tests
[LayoutNG] Include negative margin beyond the right edge
This patch changes the line breaking behavior so that a
negative inline margin beyond the right edge can be included
in the line. Before this change, negative margins could move
the position back only when it's within the available width.
Legacy and WebKit don't do this, while Edge and Gecko do.
However, LayoutNG cannot render a page legacy and WebKit
render the same as other browser due to a bug in min-content.
Instead of copying the min-content bug in LayoutNG, this
patch fixes the page by matching to Edge and Gecko.
Bug: 979894
Change-Id: I07eedbb75f5c3b43e48b826bef18d95f1af872c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684243
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674177}
--
wpt-commits: 9aacd72c9f396544fc93a1419fa8c9bfe02c015a
wpt-pr: 17612
Automatic update from web-platform-tests
Add manual test for print()
For https://github.com/whatwg/html/pull/4690.
--
wpt-commits: 8e53d2a89fe610b2ce480877c60bca88c949cf60
wpt-pr: 17439
Automatic update from web-platform-tests
[LayoutNG] Fix Google Docs font picker menu.
LayoutNG lacks a mechanism that's present in the legacy engine, that
handles situations where a descendant adds a scrollbar, which affects
the inline-size of an ancestor (fit-content sizing).
This CL only fixes the issue when this happens to an out-of-flow
positioned ancestor, which is enough to fix the Google Docs issue.
Bug: 978979
Change-Id: Ib60bbe244d8ee2cd80f3209b3322a097738841d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685388
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674123}
--
wpt-commits: 4a9bf4d17af6f7527af4558369bcb4b709ee280c
wpt-pr: 17611
Automatic update from web-platform-tests
Don't consider fieldsets as replaced content.
They should be treated as regular block containers, as far as sizing is
concerned. The LayoutNG out-of-flow positioning machinery treated
fieldsets as replaced (since it was told to), and ended up with an
incorrect inline-size.
A "side-effect" of this fix is that now that fieldsets are no longer
treated as replaced content, they can can also fragment inside multicol
containers or paged media - just like any other block-level container.
This is good. There should be no reason to prohibit fragmentainer
breaks inside fieldsets. Added a test for it, to assert the new
behavior.
Bug: 979523
Change-Id: I2fd73f8324d3207c5d12c500b5632f631468ab34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685096
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674096}
--
wpt-commits: 727763fa27f9d8d36c1c337dc2ac52ac092c61f0
wpt-pr: 17602
Automatic update from web-platform-tests
[LargestContentfulPaint] Add attributes and checks
This CL adds checks so that we do not expose rendering timestamp of
images which do not pass the Timing Allow Origin check. It also adds
attributes found in:
https://wicg.github.io/largest-contentful-paint/#sec-performance-largest-contentful-paint-candidate
The ImagePaintTimingDetector did not plumb the ImageResourceContent to
the ImageRecord, so this is fixed to allow LCP Calculator to make use of
it.
Bug: 965505
Change-Id: I019658dc6d130c8cea336f1ca70de6a32beebbb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674588
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674085}
--
wpt-commits: f7dbdc0bb7a3566b1b28e1cb49178ba9d71b1bc6
wpt-pr: 17500
Automatic update from web-platform-tests
Revert "Reland "Fix first line style caching issues""
This reverts commit 3bce815a57b12cd5be22ecd0ba838c417f6179fd.
Reason for revert: crbug.com/980421
Original change's description:
> Reland "Fix first line style caching issues"
>
> This is a reland of 228ee33446fc20cef8fcc94503a91c16bbcfc6fb
>
> Compared to the original CL, this relanded CL removes the lazy update
> of first line image observers which was not needed and didn't work
> (causing reentrancy of UpdateFirstLineImageObservers).
>
> Original change's description:
> > Fix first line style caching issues
> >
> > 1. Cache conflict issue:
> >
> > Previously calls to Element:: Element::CachedStyleForPseudoElement()
> > with different second parameters caused cache conflict. The second
> > call to it might get unwanted result that was cached with a different
> > second parameter.
> >
> > Now remove the second parameter, and the function gets and caches the
> > pseudo style only based on its own computed style. If a caller wants
> > a pseudo style based on another style, the caller should call
> > Element::UncachedStyleForPseudoElement() and manage cache by itself.
> >
> > 2. Under-invalidation on change
> >
> > Cached first line style needs invalidation in two cases:
> > a) when the ::first-line style changes, we should invalidate all
> > cached first line styles affected.
> > b) when style of an inline element (which inherits ::first-line
> > style) changes, as the inline element's style has higher priority
> > than the inherited ::first-line style, even if the style doesn't
> > change, we need to invalidate the cached
> > kPseudoIdFirstLineInherited style if the new style is different
> > from the inherited ::first-line style.
> >
> > Bug: 979054
> >
> > Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#673574}
>
> Bug: 979054
> Change-Id: Ic0c05a4a3d36401f7ae18c41cad81e7613bb3cbc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682283
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#673756}
TBR=wangxianzhu@chromium.org,fs@opera.com,futhark@chromium.org
Change-Id: I59fe9947deba7267e69f5b76c9ff6b3c0251b8c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685415
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674074}
--
wpt-commits: fef95ecd2b3d59504eb4b5405db5c2995ab32710
wpt-pr: 17609
Automatic update from web-platform-tests
[Trusted Types] Support Trusted Types on eval.
Modify V8's eval callback to take both CSP and Trusted Types into
account. This should not modify Blink's behaviour in case TT is not present.
Bug: 940927, 980127
Change-Id: Ic11956cd455d352f2ba9d3fd9e4a00bb12e8d852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591274
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674038}
--
wpt-commits: 4ed0465b108be61f184a896b7cb9e2c9356fd1d9
wpt-pr: 17525
Automatic update from web-platform-tests
[LayoutNG] Keep trucated fragments for `text-overflow: ellipsis`
This patch keeps truncated fragments for `text-overflow:
ellipsis` as "hidden for paint", but still uses them for
when querying layout information such as `offsetWidth` or
editing.
Bug: 947593, 978392
Change-Id: Ic9d6888728339dc3ea37672b1ba004cddd295216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678915
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673777}
--
wpt-commits: 424e3bce2245105a515ba8f5d97e6852bb69e973
wpt-pr: 17588
Automatic update from web-platform-tests
Reland "Fix first line style caching issues"
This is a reland of 228ee33446fc20cef8fcc94503a91c16bbcfc6fb
Compared to the original CL, this relanded CL removes the lazy update
of first line image observers which was not needed and didn't work
(causing reentrancy of UpdateFirstLineImageObservers).
Original change's description:
> Fix first line style caching issues
>
> 1. Cache conflict issue:
>
> Previously calls to Element:: Element::CachedStyleForPseudoElement()
> with different second parameters caused cache conflict. The second
> call to it might get unwanted result that was cached with a different
> second parameter.
>
> Now remove the second parameter, and the function gets and caches the
> pseudo style only based on its own computed style. If a caller wants
> a pseudo style based on another style, the caller should call
> Element::UncachedStyleForPseudoElement() and manage cache by itself.
>
> 2. Under-invalidation on change
>
> Cached first line style needs invalidation in two cases:
> a) when the ::first-line style changes, we should invalidate all
> cached first line styles affected.
> b) when style of an inline element (which inherits ::first-line
> style) changes, as the inline element's style has higher priority
> than the inherited ::first-line style, even if the style doesn't
> change, we need to invalidate the cached
> kPseudoIdFirstLineInherited style if the new style is different
> from the inherited ::first-line style.
>
> Bug: 979054
>
> Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673574}
Bug: 979054
Change-Id: Ic0c05a4a3d36401f7ae18c41cad81e7613bb3cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682283
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#673756}
--
wpt-commits: f05fad8e3fee427059ab8040badee942c2ac8555
wpt-pr: 17582
Eric Willigers
Philip Jägenstedt
autofoolip
Mike West
Manish Goregaokar
Nicolás Peña Moreno
moz-wptsync-bot
Jack Steinberg
Alex Cooper
Mattias Buelens
Matt Wolenetz
Eric Willigers
Julie Jeongeun Kim
Raphael Kubo da Costa
Lukasz Anforowicz
Yoav Weiss
Domenic Denicola
Marijn Kruisselbrink
Raymond Toy
Changwan Ryu
Adithya Srinivasan
Yi Xu
Koji Ishii
Mike Pennisi
Wanming Lin
Luke Bjerring
julianrkung
jimevans
sreeise
David Grogan
Ian Kilpatrick
Lan Wei
rajendrant
Joonghun Park
L. David Baron
Blink WPT Bot
Liquan(Max) Gu
Xiaocheng Hu
Kent Tamura
Boris
Eldar Rello
Darwin Huang
David Bokan
Ben Kelly
Majid Valipour
Boris Zbarsky
fergald
Anne van Kesteren
Yutaka Hirano
John Chen
Tab Atkins Jr
joanmarie
Jean-Francois Paradis
Domenic Denicola
Ian Clelland
Robert Ma
Jeremy Roman
Findit
Sam Sneddon
Josh Matthews
Frédéric Wang
Mustapha Jaber
Ovidio Henriquez
Vladimir Levin
Stephen McGruer
Hiroki Nakagawa
Lan Wei
Tsuyoshi Horo
Ms2ger
Kagami Sascha Rosylight
George Steel
Jinfeng Ma
Dominic Farolino
cathiechen
Eero Häkkinen
Henrik Boström
Bryan McQuade
Donna Wu
Xianzhu Wang
Xida Chen
Ella Ge
Javier Fernandez
Gérard Talbot
Giovanni Ortuño Urquidi
Chris Harrelson
Emily Hanley
Timothy Gu
Morten Stenshorne
Daniel Vogelheim
Suman Nelson Kancherla
Alice Boxhall