This patch shouldn't change behavior. It just gets us a bit more consistency
between these two stylesheets, and it makes these rules more explicit about the
fact that they're intending to style the root.
Depends on D143395
Differential Revision: https://phabricator.services.mozilla.com/D143429
For both files, we've been keeping around an extra copy in
toolkit/themes/shared/media/ with 1-2 CSS rules related to presentation.
This was probably to allow XUL-style extensions and themes to override the
presentation, back when we supported that form of extension. But there's not a
good reason to have this separation anymore, so let's simplify and combine the
files of the same name.
This patch also removes one no-longer-esepcially-useful "N.B." comment (which
refers to a file that's now alongside the styles in question). This patch also
adds an explanatory comment to explain why we bother to set `color` for images
(which was initially not clear to me).
Differential Revision: https://phabricator.services.mozilla.com/D143395
This doesn't change behavior; it just makes the existing CSS a bit more concise.
('inset' is a shorthand that sets top, right, bottom, and left all at once.)
Depends on D143099
Differential Revision: https://phabricator.services.mozilla.com/D143109
As indicated in the new code-comment, we do need the html element to be the
full height of the viewport. But:
- we don't need to set width to 100%. The default, 'auto', has the same effect.
- we don't need to set margin/padding to 0; they default to 0 on 'html'.
- we don't need to set anything on the body, since it doesn't render or have
any children in the box tree. (The video descendant is abspos and hence uses
the viewport as its containing block, not the body.)
As an extra check that this is reasonable, note that the similar
TopLevelImageDocument.css stylesheet doesn't have any CSS rules that target the
html or body elements.
Differential Revision: https://phabricator.services.mozilla.com/D143099
Instead of re-dispatch an untrusted event, simply make sure the keyboard event is handled
by the video controls.
MozReview-Commit-ID: 9Kj7E3UP77w
--HG--
extra : rebase_source : 8bbc787c7e5dd3d4351270b17f521f49b0f1a21c
Daniel Holbert
Henri Sivonen
Emilio Cobos Álvarez
Timothy Guan-tin Chien
Morris Tseng
Gervase Markham
Jared Wein