Граф коммитов

579 Коммитов

Автор SHA1 Сообщение Дата
Tristan Bourvon c7f4d8ad1c Bug 1412641 - Initialize some uninitialized fields in accessibility/. r=surkov 2017-10-31 11:20:23 +01:00
Nicholas Nethercote 8ad99dd7fa Bug 1411893 - Introduce nsStaticAtom. r=emilio,froydnj.
It's a sub-class of nsAtom, useful for cases where you know you are dealing
exclusively with static atoms. The nice thing about it is that you can use
raw nsStaticAtom pointers instead of RefPtr<>. (In fact, the AddRef/Release
implementations ensure that we'll crash if we use RefPtr<nsStaticAtom>.)

MozReview-Commit-ID: 4Q6QHX5h44V

--HG--
extra : rebase_source : e4237f85b4821b684db0ef84d1f9c5e17cdee428
2017-10-27 10:31:13 +11:00
Emilio Cobos Álvarez dd634e3981 Bug 1411612: Kill nsINode::eCONTENT. r=bz
MozReview-Commit-ID: ESlOqlwhcHI

--HG--
extra : rebase_source : fe6a02469dca1e50c24ba166e15e39160ab4551b
2017-10-25 17:19:11 +02:00
Kris Maglione 4a767c7e6e Bug 1404198: Part 2j - Switch to NS_NewTimer* everywhere else. r=njn
MozReview-Commit-ID: LmGIgfmNSmk

--HG--
extra : rebase_source : bf34e852beb0c8f6eafd09184c2e0cda95f95f83
2017-09-24 19:57:48 -07:00
Kyle Machulis 1cc8b01353 Bug 1406224 - Remove nsIDOMHTMLImageElement; r=bz
MozReview-Commit-ID: GCATWRt6qMo

--HG--
extra : rebase_source : 29854f1374c6ad318da0b5b68be23507667c3be4
2017-10-06 13:27:23 -07:00
Samuel Thibault 980959a1a0 Bug 1170242 - On accessibility SetSelectionRange, scroll the selection into view. r=surkov 2017-10-11 10:43:53 +02:00
Sebastian Hengst aa78440a09 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: EE6DcCgHufi
2017-10-09 11:19:20 +02:00
Nicholas Nethercote 8a68e6fb83 Bug 1403868 (part 4) - Reduce tools/profiler/public/*.h to almost nothing in non-MOZ_GECKO_PROFILER builds. r=mstange.
Currently the Gecko Profiler defines a moderate amount of stuff when
MOZ_GECKO_PROFILER is undefined. It also #includes various headers, including
JS ones. This is making it difficult to separate Gecko's media stack for
inclusion in Servo.

This patch greatly simplifies how things are exposed. The starting point is:

- GeckoProfiler.h can be #included unconditionally;

- everything else from the profiler must be guarded by MOZ_GECKO_PROFILER.

In practice this introduces way too many #ifdefs, so the patch loosens it by
adding no-op macros for a number of the most common operations.

The net result is that #ifdefs and macros are used a bit more, but almost
nothing is exposed in non-MOZ_GECKO_PROFILER builds (including
ProfilerMarkerPayload.h and GeckoProfiler.h), and understanding what is exposed
is much simpler than before.

Note also that in BHR, ThreadStackHelper is now entirely absent in
non-MOZ_GECKO_PROFILER builds.
2017-10-04 09:11:18 +11:00
Nicholas Nethercote d225f7151b Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP

--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
2017-10-03 09:05:19 +11:00
Alexander Surkov 848867821c Bug 1402951 - no show events for content on document load complete, r=aklotz, yzen 2017-10-03 10:58:27 -04:00
Catalin Badea f8162c4bfd Bug 651120 - Remove index argument from content removed/appended/inserted notifications. r=peterv 2017-10-03 11:09:08 +01:00
Aaron Klotz c0a1a84af9 Bug 1399557: Add diagnostic asserts to interceptor creation code; r=jimm
MozReview-Commit-ID: 9fJxHbxCmgh
2017-09-18 10:49:15 -06:00
Eitan Isaacson 177dd95e18 Bug 1400628 - Check if dependent content is null before checking if it is accepteptable. r=surkov 2017-09-18 08:28:00 -04:00
Eitan Isaacson 8366eee827 Bug 1369185 - Don't allow <select> to aria-own, or <option> to be owned. r=surkov
--HG--
extra : rebase_source : 817ea7b85fcec715e4ba43652319e46fd65fac11
2017-09-13 14:04:00 -04:00
Federico Padua f10243dec2 Bug 1301385 - input type='search' subrole on OS X is wrong, r=surkov 2017-09-12 15:10:29 -04:00
Daniel Holbert fb2c2ce4a5 Bug 1398379 part 1: Make callers of GetRootScrollFrameAsScrollableExternal() use its equivalent non-"External" version instead. r=mats
This is a simplification. GetRootScrollFrameAsScrollableExternal() is just a
wrapper around its non-"External" version, GetRootScrollFrameAsScrollable(), so
we might as well just directly call *that* version.  All of the callers here
are inside of libxul, so they don't need the special "External" version.

MozReview-Commit-ID: GGMMDAlJ9xu

--HG--
extra : rebase_source : a3bd19a6300d0ce66f38fb8433db20b4ec03abfb
2017-09-08 16:36:32 -07:00
Aaron Klotz 066806b179 Bug 1383501: Assert that com proxy is non-null before calling SendPDocAccessibleConstructor; r=yzen
MozReview-Commit-ID: CuIXyoe4jsj
2017-09-06 10:40:55 -06:00
Marco Zehe 3e9bbd265b Bug 1396626 - Expose aria-haspopup tokens dialog, listbox, menu and tree as object attributes. r=surkov
MozReview-Commit-ID: 7iuo89tuGOu

--HG--
extra : rebase_source : 044da8a2ce31a6e894bb205bae6b86d6fce9976a
2017-09-05 15:15:09 +02:00
Jim Mathies 23742b9ac3 Bug 1394927 - Use profiler_add_marker vs. profiler_tracing for accessibility profile events tags. r=aklotz
MozReview-Commit-ID: 9oJcPtdodrU

--HG--
extra : rebase_source : c56fb92d0521f5d3769ba8952a31d8b2c80cf498
2017-08-30 16:55:28 -05:00
Marco Zehe 9998f9ab0d Bug 1316285 - Expose role and landmark role for HTML header and footer only if they are direct descendants of the body tag, section otherwise. r=eeejay
MozReview-Commit-ID: LbelxxgHlJ6

--HG--
extra : rebase_source : 6f4bbb7672cf70f15ae00abeaa41b3edc02a03f5
2017-08-28 14:30:17 +02:00
Andrew McCreight 78807d8776 Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.

MozReview-Commit-ID: 5agRGFyUry1

--HG--
extra : rebase_source : 5388c56b2f6905c6ef969150f0c5b77bf247624d
2017-08-29 16:02:48 -07:00
Marco Zehe c00da5bfe0 Bug 1392926 - Only expose the Region landmark role if a section element has been explicitly named by the author, r=surkov
MozReview-Commit-ID: 6B0TSy8lqck

--HG--
extra : rebase_source : e79e1927eadb88ba107269effbdb3072427fc9ae
2017-08-28 10:48:09 +02:00
Eitan Isaacson ae84061a81 Bug 1387918 - Retrieve current array for owner in aria owns hash table. r=surkov 2017-08-28 09:32:26 -04:00
Sebastian Hengst 4acdd37bd2 Backed out changeset c216b1ee565e (bug 1392926) for failing a11y's accessible/tests/mochitest/attributes/test_xml-roles.html and accessible/tests/mochitest/jsat/test_traversal_helper.html. r=backout 2017-08-25 17:04:47 +02:00
Marco Zehe 34e218781d Bug 1392926 - Only expose the Region landmark role if a section element has been explicitly named by the author, r=surkov
MozReview-Commit-ID: 2HIVAuQBfQx

--HG--
extra : rebase_source : e309a9d82a2ce61b399cc0da5d547740d8bdb5a9
2017-08-25 14:28:39 +02:00
Nick Fox 27ff4d1faf Bug 1289157 - remove eSurvivingInUpdate flag from Accessible class, r=surkov 2017-08-24 10:22:55 -04:00
Nicholas Nethercote f582d96b98 Bug 1390428 (part 9) - Remove nsXPIDLCString. r=erahm.
This is straightforward, with only two notable things.

- `#include "nsXPIDLString.h" is replaced with `#include "nsString.h"`
  throughout, because all nsXPIDLString.h did was include nsString.h. The
  exception is for files which already include nsString.h, in which case the
  patch just removes the nsXPIDLString.h inclusion.

- The patch removes the |xpidl_string| gtest, but improves the |voided| test to
  cover some of its ground, e.g. testing Adopt(nullptr).

--HG--
extra : rebase_source : 452cc4a08046a1adb1a8099a7e85a1917de5add8
2017-08-17 15:29:03 +10:00
Masayuki Nakano bd1efdbf56 Bug 1388006 - a11y module should use TextEditor and HTMLEditor instead of nsIEditor r=surkov
Accessibility module uses nsIEditor (and nsIPlaintextEditor).  However, now, it can use TextEditor and HTMLEditor.  So, it should use them.

Note that this patch makes HTMLTextFieldAccessible::GetEditor() use nsITextControlElement::GetTextEditor() instead of nsIDOMNSEditableElement::GetEditor() but this won't change actual behavior since both implementation of HTMLInputElement and HTMLTextareaElement are just call shared internal methods.

MozReview-Commit-ID: HxHMGVSvWFv

--HG--
extra : rebase_source : a4ae19f06fb9612eacd4ae2e57fd92d36783ef32
2017-08-07 17:42:50 +09:00
Masayuki Nakano b11e66f8da Bug 1388004 - part1: Make nsContentUtils::GetHTMLEditor() return HTMLEditor* rather than nsIEditor* r=smaug
nsContentUtils::GetHTMLEditor() currently returns nsIEditor* since editor of doc shell may be any type of editors such as TextEditor or editor object which is implemented by JS.  However, nsIEditor is now a builtin class.  So, it can return HTMLEditor.

MozReview-Commit-ID: 3YoFOplZa7W

--HG--
extra : rebase_source : 46f42d23babd64bf0a5003e66e8fe3b9e0bd7166
2017-08-07 16:33:59 +09:00
Eitan Isaacson b6d69628bd Bug 1385372 - Allow same id in aria-owns. r=surkov 2017-08-09 12:33:44 -04:00
Aaron Klotz 19b37af0ff Bug 1386798: Add profiler markers for a11y events; r=surkov
MozReview-Commit-ID: EGvmB9qbKKx
2017-08-02 15:31:08 -06:00
Nicholas Nethercote f941156987 Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.

--HG--
extra : rebase_source : ac40bc31c2a4997f2db0bd5069cc008757a2df6d
2017-08-04 14:40:52 +10:00
Eitan Isaacson 4879996ea6 Bug 1363723 - Prevent aria-owned nodes from getting into bad state. r=surkov 2017-08-04 13:15:54 -07:00
Eitan Isaacson 3e9099fc0e Bug 1371781 - Allow <select> accessible children to be put back in list accessible. r=surkov 2017-08-01 10:05:00 -04:00
Wes Kocher 4e70ff1332 Backed out 2 changesets (bug 1371781) for failures in browser_test_aria_owns_select.js a=backout
Backed out changeset 0d3bdb80960d (bug 1371781)
Backed out changeset 2142989aace8 (bug 1371781)

MozReview-Commit-ID: 3NevhAhgtf6
2017-07-31 17:22:48 -07:00
Eitan Isaacson 1911897aee Bug 1371781 - Allow <select> accessible children to be put back in list accessible. r=surkov 2017-07-31 13:00:00 -04:00
Eitan Isaacson ea615f1729 Bug 1376825 - Set eIsNotInDocument to accessible's state when unbinding from doc. r=surkov 2017-07-20 12:57:00 -04:00
Eitan Isaacson c92100c21c Bug 1378257 - Don't move/reclaim aria-owned children to their current position. r=surkov, r=yzen 2017-07-25 16:31:00 -04:00
Nicholas Nethercote c86dc10505 Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk.
Most of the names passed to nsIStringBundle::{Get,Format}StringFromUTF8Name
have one of the two following forms:

- a 16-bit C string literal, which is then converted to an 8-bit string in
  order for the lookup to occur;

- an 8-bit C string literal converted to a 16-bit string, which is then
  converted back to an 8-bit string in order for the lookup to occur.

This patch introduces and uses alternative methods that can take an 8-bit C
string literal, which requires changing some signatures in other methods and
functions. It replaces all C++ uses of the old methods.

The patch also changes the existing {Get,Format}StringFromName() methods so
they take an AUTF8String argument for the name instead of a wstring, because
that's nicer for JS code.

Even though there is a method for C++ code and a different one for JS code,
|binaryname| is used so that the existing method names can be used for the
common case in both languages.

The change reduces the number of NS_ConvertUTF8toUTF16 and
NS_ConvertUTF16toUTF8 conversions while running Speedometer v2 from ~270,000 to
~160,000. (Most of these conversions involved the string
"deprecatedReferrerDirective" in nsCSPParser.cpp.)

--HG--
extra : rebase_source : 3bee57a501035f76a81230d95186f8c3f460ff8e
2017-07-12 15:13:37 +10:00
Carsten "Tomcat" Book dc83b98670 Merge mozilla-central to mozilla-inbound 2017-07-12 11:17:55 +02:00
Joanmarie Diggs 99540643ac Bug 1379098 - ARIA combobox should map to AXComboBox. r=marcoz
Create a new internal role EDITCOMBOBOX so that we can distinguish
comboboxes with a text input (which is the case for the ARIA role)
from those which consist of only a popup button and associated list
(which is the case for the select element with a size of 1). Also
change the type of ARIA combobox from kGenericAccType to eCombobox
so that IsCombobox() will return true for both EDITCOMBOBOX and
COMBOBOX. Lastly, call IsCombobox() rather than role() when assigning
internal roles to descendants of comboboxes and emitting accessibility
events.

--HG--
extra : rebase_source : 3e31f2e2423d6cc7697b03c9afb3b1f8c136675a
2017-07-11 11:16:00 +02:00
Masayuki Nakano 33d778a999 Bug 1377989 - part12: Rename local variables, |endParent| which is set to start container of nsRange to |endContainer| r=smaug
This does NOT change variable names like |endNode| because it's not odd and somebody use it for nsINode and endContent for nsIContent.  So, changing them needs more work.

MozReview-Commit-ID: 22imUltlu5R

--HG--
extra : rebase_source : 6c93069d0586b37c5084eaa71861085c01da7a7d
2017-07-12 00:08:37 +09:00
Masayuki Nakano 3fd54e5d5f Bug 1377989 - part11: Rename local variables, |startParent| which is set to start container of nsRange to |startContainer| r=smaug
This does NOT change variable names like |startNode| because it's not odd and somebody use it for nsINode and startContent for nsIContent.  So, changing them needs more work.

MozReview-Commit-ID: H19pTDprRuT

--HG--
extra : rebase_source : 7a7454ac14da48a597ff19a50c863d04dcaddd6e
2017-07-12 00:02:14 +09:00
Masayuki Nakano 4ee17d1b8c Bug 1377989 - part2: Rename nsRange::GetEndParent() to nsRange::GetEndContainer() r=smaug
MozReview-Commit-ID: K4qPjtZ62yO

--HG--
extra : rebase_source : 8653db98b9bd70c77a6aac8d906f401f0222c58a
2017-07-11 21:11:37 +09:00
Masayuki Nakano 2f2ce53be5 Bug 1377989 - part1: Rename nsRange::GetStartParent() to nsRange::GetStartContainer() r=smaug
Web standards use "Container" instead of "Parent".  So, nsRange shouldn't use "Parent" for its members and methods.

MozReview-Commit-ID: Ho6N0diuWtE

--HG--
extra : rebase_source : ee4eb7068a68b118c7fe98e9e9e7fa9c9e7f13e2
2017-07-11 20:53:04 +09:00
Sylvestre Ledru 4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Joanmarie Diggs 6b905b817a Bug 1358462 - Elements with role="region" and no accessible name should be mapped according to host language. r=MarcoZ
Perform a sanity check in Accessible::ARIATransformRole() for the
internal REGION role: If there is no accessible name, transform
the ARIA role into the native host language role. Also perform
a sanity check when getting the AXSubrole in macOS: If the roleAtom
is nsGkAtoms::region, only return AXLandmarkRegion if the internal
role is REGION.
2017-07-04 18:24:00 -04:00
Joanmarie Diggs b66b7af7bc Bug 1355921 - Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE. r=marcoz
Create states::CURRENT and add it to the list of "universal" (global)
ARIA states. Map states::CURRENT to ATK_STATE_ACTIVE and emit accessible
state-change notifications when the value of aria-current is modified.
2017-07-03 17:02:00 +02:00
Alexander Surkov bf02d77384 Bug 1372985 - ARIA owned children ordering may be incorrect. r=eeejay 2017-06-29 14:30:58 -04:00
Joanmarie Diggs 35af6f703f Bug 1355954 - Focusable separators should implement the accessible value interface. r=MarcoZ
Add eHasValueMinMaxIfFocusable to the ARIA role map so that we can
take the accessible element's interactive state into account when
determining if the value interface should be supported.
2017-06-28 07:11:00 -04:00
Alexander Surkov acb19ed934 Bug 1369836 - ARIA owns relocated flag of accessible object may get out of sync with ARIA owns hash. r=eeejay 2017-06-26 20:20:40 -04:00
Bill McCloskey f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Sebastian Hengst adabab920b Backed out changeset ed18b5a361f9 (bug 1379098) for timing out in a11y's accessible/tests/mochitest/events/test_valuechange.html and browser-chrome's accessible/tests/browser/e10s/browser_caching_value.js. r=backout 2017-07-10 16:02:38 +02:00
Joanmarie Diggs 55edd4314f Bug 1379098 - ARIA combobox should map to AXComboBox. r=marcoz
Create a new internal role EDITCOMBOBOX so that we can distinguish
comboboxes with a text input (which is the case for the ARIA role)
from those which consist of only a popup button and associated list
(which is the case for the select element with a size of 1). Also
change the type of ARIA combobox from kGenericAccType to eCombobox
so that IsCombobox() will return true for both EDITCOMBOBOX and
COMBOBOX. Lastly, call IsCombobox() rather than role() when assigning
internal roles to descendants of comboboxes.
2017-07-10 04:26:00 +02:00
Joanmarie Diggs 1115881728 Bug 1375460 - "haspopup" AtkObject attribute missing if multiprocess enabled. r=surkov
Move the object attribute exposure of states::HASPOPUP from the ATK wrapper
code to the shared accessibility code. Call UniversalStatesFor() rather than
State() for performance.

--HG--
extra : rebase_source : e31c2d00da302538a7f6962d8f4dfd148a7d877e
2017-06-22 07:25:00 -04:00
Carsten "Tomcat" Book 8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey 6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey 4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Eitan Isaacson b5e156f5c2 Bug 1368103 - Use DOM doc visibilityState to determine if a tab is hidden. r=surkov 2017-06-03 20:15:01 -07:00
Aaron Klotz 570cbae5c4 Bug 1364544: Ensure that proxied CARET_MOVED and FOCUS events update the Win32 system caret before firing their WinEvents; r=eeejay
MozReview-Commit-ID: LVML7EZaSYD

In non-e10s AccessibleWrap::HandleAccEvent, we special case our handling of
CARET_MOVED and FOCUS events with a call to UpdateSystemCaretFor. In e10s mode
we were not doing the same thing for proxied events sent from content. This
threw JAWS for a loop and presumably messes up other ATs as well.

This patch modifies the IPDL messages for these two events so that we may
send the caret rect along with the event, thus allowing us to update the
system caret for proxied events as well.

--HG--
extra : rebase_source : e1502c12b038739520afd5c7078d011e25ea669e
2017-05-15 14:11:46 -06:00
Alexander Surkov 5abc773740 Bug 1363027 - keep removing accessible alive during event coalescence, r=davidb 2017-05-12 14:02:15 -04:00
Alexander Surkov 6737b53749 Bug 1363027 - diagnostic asserts for Accessible::RemoveChild, r=davidb 2017-05-09 15:56:41 -04:00
Alexander Surkov 28500c691a Bug 1362063 - replace delayed ValidateARIAOwned on straightforward DOM tree traversal, r=davidb 2017-05-04 13:21:17 -04:00
Alexander Surkov 1eef9e9b1e Bug 1355488 - fix aria-owns on a document, r=davidb 2017-05-03 10:50:33 -04:00
Wes Kocher 5b73758a65 Merge m-c to inbound, a=merge
MozReview-Commit-ID: ILz91Vj4gT5
2017-05-02 17:39:58 -07:00
Trevor Saunders dcced28484 bug 1348148 - try and avoid firing load events on unloaded documents r=davidb
It is awkward to need to have a DocAccessibleChild to send events with before
DocAccessible::DoInitialUpdate() is called because we might not have a
TabParent for the document until then.  However we could try to fire reload
events on documents before DoInitialUpdate() was called which would require
having a DocAccessibleChild there to send the load event to the parent process.

However before DocAccessible::DoInitialUpdate() is called the document already
has a pending load event.  If a document hasn't yet been the subject of a load
event it doesn't make a lot of sense to fire a reload event for that document,
      and then the initial load event.  So it should be safe to skip firing
      reload events for documents where mLoadEvent specifies a load event to
      fire in the future.
2017-05-02 13:34:40 -04:00
David Parks 1810e88c32 Bug 1359129 - Use the most recent RootDocAccessible when delaying DocAccessibleChild messages. r=aklotz
We sometimes briefly have more than one root DocAccessible associated with a TabChild, for example, while navigating links in a page.  This patch makes sure that we use the correct accessible when delaying messages that we forward to the parent process.
2017-05-01 14:04:55 -07:00
Emilio Cobos Álvarez e44543aad4 Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
MozReview-Commit-ID: 5Nzhyta5Hle

--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Carsten "Tomcat" Book 2a74ba4261 Merge mozilla-central to autoland 2017-05-02 11:23:38 +02:00
Emilio Cobos Álvarez 23bce99ae1 Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
This avoids conflicts with mozilla::dom::FrameType.

MozReview-Commit-ID: 7aEMbHRaTFk

--HG--
extra : rebase_source : 2d01321f5ce0ec8c0e3f70984674f82678034b3c
2017-05-01 19:32:52 +02:00
Alexander Surkov 54cc70d50a Bug 1353094 - simplify the logic of accessible subtrees removal, r=davidb 2017-04-25 14:02:41 -04:00
Alexander Surkov c528975ed0 Bug 1349160 - Dismissing Print dialogue crashes Firefox, r=yzen 2017-04-03 15:21:05 -04:00
Alexander Surkov 696f8370cf Bug 1351414 - shutdown a moving accessible if it has no insertion point, r=yzen 2017-03-30 15:56:22 -04:00
Alexander Surkov 19acce02d8 Bug 1347075 - validate insertion index for a child move, r=yzen 2017-03-29 12:08:10 -04:00
David Parks 55dc6b7f68 Bug 1332690 - Assign Managers to DocAccessibleChilds. r=tbsaunde
The Manager is set by IPDL for remotely constructed objects but our DocAccessibleChilds are created on the child process side, so we need to assign a manager in the constructor so that we can find it when needed.

--HG--
extra : rebase_source : 8bf76534860ed73fbdc71df494130f6028400fa3
2017-03-27 10:03:43 -07:00
Alexander Surkov f276097163 Bug 1346518 - extend Accessible::RemoveChild debugging assertions, r=yzen 2017-03-21 10:13:32 -04:00
Alexander Surkov c9ee99780d Bug 1347667 - unlink accessible's parent before accessible's shutdown when document shutdowns, r=yzen 2017-03-20 09:42:39 -04:00
Alexander Surkov bc2c7e65ad Bug 1321384 - add debuggin assert for Accessible::RemoveChild, r=yzen 2017-03-09 14:55:54 -05:00
Mats Palmgren d13aaf9ce0 Bug 1340771 part 1 - Rename nsWeakFrame to AutoWeakFrame (automated change). r=tn
MozReview-Commit-ID: 8pl4nyeGEkr
2017-03-01 18:03:14 +01:00
Alexander Surkov 8e74a46ec6 Bug 1321384 - add diagnostics to Accessible::Move, r=eeejay 2017-02-22 13:45:21 -05:00
Trevor Saunders d73d9c56df bug 1338755 - send a tab's parent proxy when it may have changed r=yzen 2017-02-17 09:06:26 -05:00
Trevor Saunders d1713296dd bug 1338755 - make RemoteChildDoc() return a DocAccessibleParent* r=yzen 2017-02-17 09:06:26 -05:00
Alexander Surkov 0b5d08769a Bug 1321384 - attempt to fix a wrong index issue on accessible child removal, r=eeejay 2017-02-11 13:19:36 -05:00
Alexander Surkov f7075f375a Bug 1334972 - crash when aria-owned child takes children from its parent, r=yzen 2017-02-03 13:51:52 -05:00
Alexander Surkov c5f506fd9b Bug 1331269 - Assertion failure: aChild->Parent() == mParent, r=eitan 2017-01-20 11:59:52 -05:00
Trevor Saunders 4fca25988e bug 1240893 - ensure accessibles are shutdown before their document r=davidb, smaug 2017-01-19 17:18:39 -05:00
Trevor Saunders bd2c1d2fdb bug 1325834 - fixup windows bustage landed on a CLOSED TREE 2017-01-17 15:48:51 -05:00
Trevor Saunders 6798a4c8ce bug 1325834 - create the DocAccessibleChild in DocAccessible::DoInitialUpdate() r=davidb
It seems likely that some documents are created in content processes without
  a DocAccessibleChild actor because there is no docshell or tabchild
  associated with the document.  However DocAccessible::DoInitialUpdate()
  already calls functions that assume the document is associated with a
  docshell.  So hopefully trying to create the child actor there will mean it
  is more successful.
2017-01-17 15:20:32 -05:00
Trevor Saunders e4892518b5 bug 1270916 - switch to use the new mutation event queue system r=davidb
This puts events in the queue instead of the event tree, and then fires them
based on the queue.  Some tests need to be adjusted to make sure they check
constraints on event order correctly.
2016-11-16 23:47:02 -05:00
Trevor Saunders 44c897cc27 bug 1270916 - call CreateSubtree() before firing a show event for the tree root
r=davidb

This ensures that if creating the sub tree creates events to fire they will go
before the show event for the root of the tree.  It is fine to fire show events
for the subtree before the root because they will just get coalesced away
anyway.  However it is important that any hide events come before the hidden
subtree appears in the new tree.
2016-11-16 23:46:59 -05:00
Trevor Saunders fd3123c05c bug 1270916 - remove EventTree::{Shown,Hidden}() r=davidb
They are pretty useless wrappers, and in the future it will be useful to have
  access to the event object independent of the EventTree.
2016-11-16 23:46:54 -05:00
Trevor Saunders 98329c788d bug 1270916 - allow tracking in an accessible if it has a pending show / hide / reorder event r=davidb 2016-11-16 23:46:48 -05:00
Wes Kocher d8a0141e5f Backed out 12 changesets (bug 1270916) for a11y crashes a=backout CLOSED TREE
Backed out changeset 916cbaf21a63 (bug 1270916)
Backed out changeset 8ee47068d1fb (bug 1270916)
Backed out changeset 60189bf08272 (bug 1270916)
Backed out changeset 5ca49b5d1c51 (bug 1270916)
Backed out changeset b8ead1b86059 (bug 1270916)
Backed out changeset 034efc9a4408 (bug 1270916)
Backed out changeset a9d6410f068e (bug 1270916)
Backed out changeset eefa622b467a (bug 1270916)
Backed out changeset 91a8f65a69fe (bug 1270916)
Backed out changeset cd68b5fd88a6 (bug 1270916)
Backed out changeset 4c58195d6bcf (bug 1270916)
Backed out changeset 8e5f19f19b7f (bug 1270916)
2016-11-16 16:16:13 -08:00
Trevor Saunders 446c2b1395 bug 1270916 - switch to use the new mutation event queue system r=davidb
This puts events in the queue instead of the event tree, and then fires them
based on the queue.  Some tests need to be adjusted to make sure they check
constraints on event order correctly.
2016-11-16 18:15:23 -05:00
Trevor Saunders 74f239078f bug 1270916 - call CreateSubtree() before firing a show event for the tree root
r=davidb

This ensures that if creating the sub tree creates events to fire they will go
before the show event for the root of the tree.  It is fine to fire show events
for the subtree before the root because they will just get coalesced away
anyway.  However it is important that any hide events come before the hidden
subtree appears in the new tree.
2016-11-16 18:15:23 -05:00
Trevor Saunders 670130a0f0 bug 1270916 - remove EventTree::{Shown,Hidden}() r=davidb
They are pretty useless wrappers, and in the future it will be useful to have
  access to the event object independent of the EventTree.
2016-11-16 18:15:22 -05:00
Trevor Saunders 9b4d4eb7ea bug 1270916 - allow tracking in an accessible if it has a pending show / hide / reorder event r=davidb 2016-11-16 18:15:20 -05:00
Iris Hsiao 957410f8c7 Backed out changeset 35ebbb5e0d02 (bug 1270916)
CLOSED TREE
2016-11-16 14:42:36 +08:00
Trevor Saunders 3fa4f2d492 bug 1270916 - allow tracking in an accessible if it has a pending show / hide / reorder event r=davidb 2016-11-16 01:17:38 -05:00
Trevor Saunders 85af4870f3 bug 1316789 - UncacheChildren should not go between documents r=davidb 2016-11-15 16:22:20 -05:00
Alexander Surkov 4657cb7a0f Bug 1310794 - implement aria-details and aria-errormessage, r=davidb 2016-10-25 13:51:27 -04:00
Boris Zbarsky 588a38e713 Bug 1222516 part 2. Add a window API for opening a window passing through a boolean indicating that no opener should be set on the result. r=mconley 2016-10-20 16:52:38 -04:00
Boris Zbarsky c2d8d70720 Bug 1222516 part 1. Add a window API for opening a window with navigation and a given docshell loadinfo to use for the navigation. r=mconley
This will be used to pass through information like the triggering principal and
whatnot, as well as the boolean for not sending a referrer, for rel=noreferrer
links.
2016-10-20 16:52:38 -04:00
Alexander Surkov e124c53ded Bug 1294853 part1 - hide should preceed its related show on a move, r=yzen 2016-09-29 15:44:18 -04:00
Alexander Surkov a71905c1f2 Bug 1303526 - Crash in mozilla::a11y::DocAccessible::ProcessInvalidationList, r=yzen 2016-09-23 16:57:16 -04:00
Michael Li 36120acc04 Bug 1296420 - Don't add node to DocAccessible's invalidation list if it's a target of aria-owns. r=surkov
MozReview-Commit-ID: tOCjCud8b0

--HG--
extra : transplant_source : %2Ac%B3%25%EE%26%92%13%A7%92%27%D1%0E%B6%DFF%CA%28v%90
2016-08-24 16:54:54 -04:00
Ravi Shankar b41dc19d66 Bug 1297982 - Replace NS_STYLE_BOX_ORIENT_* with enum class; r=xidorn
MozReview-Commit-ID: GC0VRyHUM4V

--HG--
extra : rebase_source : eb43a793816101798d0d3bb9a56864519eb7a14a
2016-08-26 12:48:41 +05:30
Alexander Surkov 0f37181efe Bug 1287721 - Keep strong pointers for nodes in the invalidation list of a document accessible. r=smaug
--HG--
extra : rebase_source : e93e5b29ebe4fa4674c8af02f7b4ddd59224abf2
2016-08-24 22:16:45 -04:00
Kan-Ru Chen b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Bobby Holley 412f98cac5 Bug 1296509 - Optimize GetFlattenedTreeParent. r=smaug
We need to call it on some hot paths in stylo, and this allows us to do
quick inline check before delegating to the slow path.
2016-08-19 14:43:53 -07:00
Aaron Klotz 1ee837c40c Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Alexander Surkov b31c083715 Bug 1296113 - accessible element insertion following inaccessible element insertions results in a wrong tree, r=yzen 2016-08-19 12:10:58 -04:00
Alexander Surkov 9b8e4e076e Bug 1294500 - MOZ_ASSERT_UNREACHABLE() in DocAccessible.cpp introduced in bug 1246447 triggers in Thunderbird, r=yzen 2016-08-19 11:29:33 -04:00
Ryan VanderMeulen 01c4e8cc1b Merge inbound to m-c. a=merge 2016-08-19 09:52:53 -04:00
Cameron McCormack 6b7cc9d914 Bug 1295852 - Part 3: Check for generated content containers correctly when generating DOM ranges from a11y selections. r=masayuki
MozReview-Commit-ID: 9yTyi2MB0SQ

--HG--
extra : rebase_source : 336751029363a9a4ac50fa394df1e1482a0b7e47
2016-08-19 11:17:00 +08:00
Sebastian Hengst 87b8b23d92 Backed out changeset a2b189275d7a (bug 1268544) for asserting in Windows M(oth) jobs. r=backout on a CLOSED TREE
--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
2016-08-19 10:04:23 +02:00
Nicholas Nethercote 67af4817e9 Bug 1293596 (part 2) - Rework nsIWidget bounds getters. r=mstange.
This patch makes GetBounds(), GetScreenBounds() and GetClientBounds() more
obviously infallible, like existing functions such as GetNaturalBounds() and
GetClientSize(). This results in clearer behaviour in nsCocoaWindow.mm if
Objective C exceptions occur. Along the way, the patch removes some useless
failure checks for these functions.

The patch also removes the NS_IMETHOD from GetRestoredBounds and makes that
function MOZ_MUST_USE.
2016-08-19 09:03:04 +10:00
Aaron Klotz 1d9ba42f65 Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Phil Ringnalda 0d69896d44 Backed out 6 changesets (bug 1288841, bug 1268544) for causing Win7 e10s Marionette to fail in test_import_script.py TestImportScriptContent.test_imports_apply_globally
Backed out changeset c9f49a119255 (bug 1288841)
Backed out changeset a9d43e83e070 (bug 1268544)
Backed out changeset d898178a0809 (bug 1268544)
Backed out changeset 4887b4164dd9 (bug 1268544)
Backed out changeset 7c3a5a770cae (bug 1268544)
Backed out changeset 12aa15cf5879 (bug 1268544)

--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
rename : accessible/ipc/win/ProxyAccessible.cpp => accessible/ipc/ProxyAccessible.cpp
rename : accessible/ipc/win/ProxyAccessible.h => accessible/ipc/ProxyAccessible.h
2016-08-18 00:30:21 -07:00
Aaron Klotz 50740cfde5 Bug 1288843: Modify OuterDocAccessible so that ChildCount() and ChildAt(0) resolve RemoteChildDoc(); r=tbsaunde
MozReview-Commit-ID: EsayZhH2nY8

--HG--
extra : rebase_source : decda5eeeebab0ee899cd67d51b0490b54f8ca5f
2016-07-22 13:40:05 -06:00
Aaron Klotz c3a25c1ddc Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Wes Kocher 021a12c86f Backed out changesets e4a39e456f89 (bug 1268544) for mass build bustage a=backout CLOSED TREE
***
Backed out changeset 119a4b187938 (bug 1268544)
***
Backed out changeset d83cba382cfe (bug 1268544)
***
Backed out changeset a0085eb5ffe7 (bug 1268544)
***
Backed out changeset eefa457c3680 (bug 1288843)
***
Backed out changeset 17dc46beb1a5 (bug 1288841)
***
Backed out changeset e76f58f328d4 (bug 1268544)
***
Backed out changeset ffc8ee715fdb (bug 1268544)
***
Backed out changeset 99f0ea19b8f5 (bug 1268544)
***
Backed out changeset 2bdfb9514317 (bug 1268544)
***
Backed out changeset e4b3a5e1756d (bug 1268544)

--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
rename : accessible/ipc/win/ProxyAccessible.cpp => accessible/ipc/ProxyAccessible.cpp
rename : accessible/ipc/win/ProxyAccessible.h => accessible/ipc/ProxyAccessible.h
extra : amend_source : dc73ec117c7279539cab36af821637bb1b0236bd
extra : histedit_source : 438ce81f07a53af61b1cabf7620f30b090e7d5e2%2Ccb6472913fe0d7d2ec66bf0cedc18f2e4d00678e
2016-08-15 15:58:45 -07:00
Aaron Klotz e6e0b5db60 Bug 1288843: Modify OuterDocAccessible so that ChildCount() and ChildAt(0) resolve RemoteChildDoc(); r=tbsaunde
MozReview-Commit-ID: 38qOXftPFid

--HG--
extra : amend_source : a3521e6549d8fbe28b88330a2f90351f24f003c0
2016-07-22 13:40:05 -06:00
Aaron Klotz 55b28e20c7 Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 14:24:04 -06:00
Alexander Surkov 0a78fab1e3 Bug 1294086 - remove debugging printf 2016-08-12 10:20:45 -04:00
Alexander Surkov 30c2b9aee8 Bug 1294086 - implement ARIA feed role, r=yzen 2016-08-10 14:07:29 -04:00
Michael Li cc740d9cf4 Bug 1289223: Make EventTree process all accessibility show events. r=surkov
MozReview-Commit-ID: 1wRLGHR9Vfc

--HG--
extra : transplant_source : VO%FD%80%0C.%15%9D%C4%82%3A%18%E2%C3WU%A1%8Fv%CF
2016-08-09 15:07:04 -04:00
Alexander Surkov 72a5e88c04 Bug 1274381 - scope accessible elements search to inserted nodes, r=yzen, f=marcoz 2016-08-05 10:20:58 -04:00
Alexander Surkov f002f15624 Bug 1246447 - crash in mozilla::a11y::DocAccessible::ARIAAttributeChanged, r=yzen 2016-08-04 10:49:21 -04:00
Carsten "Tomcat" Book 336105a0de merge mozilla-inbound to mozilla-central a=merge 2016-07-22 11:58:02 +02:00
Tom Tromey 5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Alexander Surkov 499efe0f10 Bug 1286598 - make sure an accessible tree is updated on DOM tree removals, r=yzen 2016-07-20 09:40:55 -04:00
Michael Li 0a864a1988 Bug 1285272 - Change Accessible's role map entry variable from a raw pointer to an index. r=yzen
MozReview-Commit-ID: 2diXMOohyk

--HG--
extra : rebase_source : 410d8eaa7f2909d93ff44ec4fc0a80e9619c9a90
2016-07-18 12:40:53 -04:00
Michael Li 7c54c53ae4 Bug 1285272 - Replace direct use of mRoleMapEntry with calls to ARIARoleMap(). r=yzen
MozReview-Commit-ID: JEuMlNLxD8R

--HG--
extra : rebase_source : 9f93d35a94ea24eddcb869f9dd14da0dd4fa8c73
2016-07-12 15:34:13 -04:00
Alexander Surkov c85742dc94 Bug 1278915 - make sure to not add a non document accessilbe children under outerdoc, r=yzen 2016-07-18 19:40:53 -04:00
Alexander Surkov ee6e42b6de Bug 1276857 - Shutdown an accessible if cannot be inserted into the tree, r=yzen 2016-07-12 23:15:22 -04:00
Michael Li cebbecb62d Bug 1283268 - Change nsAutoPtr to UniquePtr in EventTree and Accessible classes. r=nfroyd 2016-06-29 12:57:00 +02:00
Carsten "Tomcat" Book 1a906a731f Backed out changeset af41c2ddcb5a (bug 1278929) for bustage on a CLOSED TREE 2016-06-28 17:00:35 +02:00
Trevor Saunders 82a629182d bug 1278929 - use std::unique_ptr in DocAccessible::AttrRelProviderArray r=froydnj 2016-06-28 10:23:22 -04:00
Carsten "Tomcat" Book 7c1fa57b1d Backed out changeset b3acfc1fa613 (bug 1274381) for causing regression (bug 1281828) and on request from marcoz 2016-06-24 10:53:11 +02:00
Alexander Surkov d219d06d6d Bug 1274381 - scope accessible elements search to inserted nodes, r=yzen, f=marcoz 2016-06-21 10:53:06 -04:00
Alexander Surkov f33c2d2c00 Bug 1278294 - move accessible tree logging into separate method, part=6, r=yzen 2016-06-20 11:35:38 -04:00
Trevor Saunders ea8a901a13 bug 1272712 - send a RoleChanged message when an accessible document's role changes r=davidb 2016-06-14 12:46:21 -04:00
Masayuki Nakano a1636168ba Bug 1278014 part.6 Rename SelectionType::SELECTION_SPELLCHECK to SelectionType::eSpellCheck r=smaug
MozReview-Commit-ID: 4n2jEVax37O

--HG--
extra : rebase_source : eb8c0dbedfeac83de330ccef874525dea355b52c
2016-06-09 18:37:36 +09:00
Masayuki Nakano d960ef26d5 Bug 1278014 part.5 Rename SelectionType::SELECTION_NORMAL to SelectionType::eNormal r=smaug
MozReview-Commit-ID: AAdxTTKEvrk

--HG--
extra : rebase_source : 82e10db6b8b17d4f571625e34bb3c8f1905ef58a
2016-06-09 18:35:22 +09:00
Masayuki Nakano 00591135a4 Bug 1278014 part.2 Define mozilla::SelectionType as an enum class and use it instead of RawSelectionType as far as possible r=smaug
This patch defines mozilla::SelectionType as an enum class.  This is safer than nsISelectionController::SELECTION_* since setting illegal value to its variable is checked at build time.  So, as far as possible, this should be used everywhere (but of course, this isn't available in scriptable interfaces).

And also this implements some useful methods for managing SelectionType and RawSelectionType which are implemented in layout/nsSelection.cpp because nsISelectionController is implemented by both PresShell and nsTextEditorState.  Therefore, implementing one of them may make hard to find them.  On the other hand, nsSelection.cpp is a better file name to look for them.

Note that this patch creates mozilla::Selection::RawType() for binding.  Native code should keep using Selection::Type() but the binding code needs to use RawType() due to impossible to convert from SelectionType to RawSelectionType without explicit cast.

MozReview-Commit-ID: 81vX7A0hHQN

--HG--
extra : rebase_source : d9f88e217c713c60d1c2578ce6421c73ccba8650
2016-06-11 11:06:37 +09:00
Jonathan Watt b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Lorien Hu c86a00d637 Bug 1274194 - HyperTextAccessible InsertChildAt and RemoveChild now call AccessibleWrap for superclass method r=tbsaunde 2016-06-09 14:33:48 -07:00
Alexander Surkov cfb8c639d1 Bug 1278294 - add tree logging for single content insertion, part5, r=yzen 2016-06-08 13:51:47 -04:00
Alexander Surkov a79ccd2084 Bug 1278294 - UpdateTreeOnRemoval should use logging::TreeInfo, part2, r=yzen 2016-06-08 07:33:06 -04:00
Wes Kocher 511408a877 Backed out changeset 452617569aeb (bug 1278294) for build bustage CLOSED TREE 2016-06-07 14:48:22 -07:00
Alexander Surkov 7a5475e4a8 Bug 1278294 - UpdateTreeOnRemoval should use logging::TreeInfo, part2, r=yzen 2016-06-07 17:21:59 -04:00
Eric Skoglund ebe3c8320b Bug 1031184 - Introduce a NativeDescription method to more easily customize accessible descriptions for various classes, r=MarcoZ
Implemented a NativeDescription method

--HG--
extra : rebase_source : f0129eaea0f183ab3f67963dfbb61141af670f64
2016-05-23 00:12:54 +02:00
Alexander Surkov 59bfc9cc59 Bug 1271946 - no alert, menupopup_start events from created subtree, partial backout of bug 1262420, r=marcoz 2016-05-18 08:58:26 -04:00
Trevor Saunders 256fff4fc9 bug 1271436 - add nsIDocShell::GetCommandManager() r=smaug 2016-05-17 18:16:07 -04:00
Alexander Surkov db0f2224b6 Bug 1273020 - add more assertions, r=njn 2016-05-17 14:11:42 -04:00
Nicholas Nethercote c63787f910 Bug 1273020 - Add missing null checks in ApplicationAccessible. r=surkov.
--HG--
extra : rebase_source : f28ed60b77797d975290f2b45c242526df984364
2016-05-16 12:36:25 +10:00
Chris Peterson 353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Alexander Surkov a24bc2972b Bug 1270218 - keep indexes in parent updated in-the-middle of insertions and removals, r=yzen 2016-05-05 10:42:00 -04:00
Kyle Huey c73656947b Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Trevor Saunders 471e46a43a bug 1266518 - add a new event message for AccSelChangeEvents r=davidb
For these events atk needs to know about the widget not the event target, and
the easiest way to support that is by adding a new event message that sends the
widget id.
2016-04-25 13:38:06 -04:00
Alexander Surkov 446c271cb6 Bug 1262420 - split updateTreeInternal for removals and insertions, part 2, r=yzen 2016-04-25 09:10:41 -04:00
Alexander Surkov e3f1739729 Bug 1262420 - split updateTreeInternal for removals and insertions, removals part, r=yzen 2016-04-25 09:07:48 -04:00
Trevor Saunders 907963ea24 bug 1262563 - add IsFromUserInput to show / hide event messages r=davidb 2016-04-21 13:41:09 -04:00
L. David Baron 376413eeb5 Bug 1053986 - Rename nsIFrame::IsBoxFrame to IsXULBoxFrame. r=dholbert
Written purely with sed, over .h and .cpp files in layout/.

But with additional manual changes in accessible/.

MozReview-Commit-ID: W0wUPoQsVH
2016-04-20 21:28:30 -07:00
Masayuki Nakano cbe8f5268a Bug 1259656 part.1 Rename WidgetEvent::refPoint to WidgetEvent::mRefPoint r=smaug
MozReview-Commit-ID: ESWM5ZyBpSR

--HG--
extra : rebase_source : c5e1e3f60bcdde2a7f6c399e72430b29a3e552cd
2016-04-18 23:09:02 +09:00
Alexander Surkov 83f637d163 Bug 1262417 - bind a value change event with reorder event firing, r=yzen 2016-04-19 11:51:51 -04:00
Nathan Froyd dc00d2ec98 Bug 1264784 - part 1 - call nsIFrame::{GetScreenRect,GetView} instead of their *External counterparts; r=dholbert
The latter functions just call through to the former functions, and
we're going to remove the latter functions in a separate, subsequent
patch.
2016-04-15 19:37:35 -04:00
Alexander Surkov 79325fd1a2 Bug 1264473 - do not schedule child document rebuinding during main document shutdown, r=yzen 2016-04-14 11:15:16 -04:00
Alexander Surkov 1499275e07 Bug 1262415 - make Accessible to keep weak pointers to parent and children, r=yzen 2016-04-12 11:20:56 -04:00
Jonathan Watt de4c3d11fe Bug 1263787 - Kill off the deprecated nsINode::GetCrossShadowCurrentDoc. r=baku 2016-03-31 13:20:14 +01:00
Jonathan Watt 9480920b04 Bug 1263785 - Kill off the deprecated nsINode::GetCurrentDoc. r=baku 2016-03-31 12:46:32 +01:00
Jonathan Watt fb7bb15e68 Bug 1263782 - Kill off the deprecated nsINode::IsInDoc(). r=baku 2016-03-31 11:58:25 +01:00
Cameron McCormack 672aaef5a4 Bug 1261754 - Part 11: Move opacity from nsStyleDisplay to nsStyleEffects. r=dholbert 2016-04-12 15:52:43 +10:00
Trevor Saunders 9d406fe177 bug 1261144 - rename AccCollector.{h,cpp} to EmbeddedObjCollector.{h,cpp} r=lsocks 2016-04-11 21:41:09 -04:00
Alexander Surkov f34bc138b9 Bug 1261439 - replace nsAccUtils::IsEmbeddedObject on a bit flag check, r=marcoz 2016-04-08 08:35:11 -04:00
Alexander Surkov 51947ead2c Bug 1261425 - coalesce mutation events by a tree structure, r=yzen 2016-04-07 09:30:22 -04:00
Sebastian Hengst c77c3ae876 Backed out changeset 071d44d633ea (bug 1234121) 2016-04-07 14:15:41 +02:00
Lorien Hu edd5ded287 Bug 1234121 - FocusManager focused proxy cleared on hide event (Part 2) r=tbsaunde 2016-04-07 04:18:15 -07:00
Alexander Surkov 41a839ff6b Bug 1261408 - detect ARIA owned children early to avoid tree moving, r=yzen 2016-04-06 07:58:58 -04:00
Alexander Surkov ead73ecd57 Bug 1261177 - split GetOrCreateAccessible method into two (Get and Create versions), r=yzen 2016-04-06 07:23:41 -04:00
Alexander Surkov 62081fdb80 Bug 1261170 - add a single node ProcessContentInserted method version, r=yzen 2016-04-05 20:48:30 -04:00
Alexander Surkov c2cdfb8b81 Bug 1261167 - remove Accessible::TestChildCache, r=marcoz 2016-04-05 17:35:31 -04:00
Alexander Surkov 167cbebba2 Bug 1261165 - remove Accessible::ChildrenFlags, r=yzen 2016-04-05 17:34:00 -04:00
alexander ddd1904862 Bug 1260862 - "remove Cache/EnsureChildren". r=mzehe 2016-03-30 12:53:00 +02:00
alexander 5ce933a8d2 Bug 1261377 - "With current child caching reorganization, NVDA is no longer able to render some content". r=mzehe 2016-04-01 09:39:00 +02:00
Alexander Surkov c9b15d3087 Bug 1260860 - stop illicit accessible stealing, r=yzen 2016-04-01 11:07:57 -04:00
Alexander Surkov a85d9d1c0c Bug 1260496 - get rid of CacheChildren for application accessible, r=marcoz 2016-04-01 10:57:06 -04:00
Alexander Surkov 89c58301b4 Bug 1260494 - rebuild child indexes by AutoTreeMutation guard, r=yzen 2016-04-01 10:53:52 -04:00
Alexander Surkov 35ac8eea5d Bug 1260277 - remove empty CacheChildren's, r=marcoz 2016-03-31 21:40:56 -04:00
Alexander Surkov 5165ca54aa Bug 1258228 - create special child accessibles in owner's constructor, part1, r=marcoz 2016-03-31 21:22:34 -04:00
Alexander Surkov e66c565efd Bug 1256461 - merge MoveChild and SeizeChild methods, r=yzen 2016-03-31 21:22:13 -04:00
Alexander Surkov 7e614aef9d Bug 1260237 - remove InvalidateChildren, r=yzen 2016-03-31 20:46:58 -04:00
Alexander Surkov 35d213f532 Bug 1260187 - remove recaching version of DocAccessible::UpdateTreeOnInsertion, r=yzen 2016-03-31 20:46:45 -04:00
Alexander Surkov 7fcc93f841 Bug 1255617 - make PutChildrenBack to insert accessibles instead the recaching, r=yzen 2016-03-30 10:47:36 -04:00
Alexander Surkov f04d43e6a0 Bug 1255614 - make ProcessInvalidationList to insert accessibles instead the recaching, r=yzen 2016-03-29 09:20:43 -04:00
Alexander Surkov d3f1ea74cd Bug 1255009 - insert children into the tree on content insertion instead the recaching, r=yzen 2016-03-28 13:40:21 -04:00
Alexander Surkov e437e00f04 Bug 1252857 - value change events for HTML:select have wrong target, r=marcoz 2016-03-18 16:22:17 -04:00
Trevor Saunders 2c05850952 bug 1257287 - add nsIDocShell::GetEdItingSession() 2016-03-18 15:54:07 -04:00
Mike Hommey 7f131dbc35 Bug 1256988 - Replace tests on MOZ_ENABLE_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk. r=chmanchester 2016-03-17 06:49:44 +09:00
Nicholas Nethercote 7cb4896c8f Bug 1255655 - Const-ify sWAIRoleMaps. r=tbsaunde.
--HG--
extra : rebase_source : 1274cdb26bbc41456e91b67849733bfb5bc89401
2016-03-11 13:13:01 +11:00
Ryan VanderMeulen e93eed0ec2 Backed out changeset 4916251eb389 (bug 1255009) for breaking AWSY.
--HG--
extra : rebase_source : 3c018d36597e8e4becc06b744bead086796d2e63
extra : histedit_source : 2c99af1f289f0d0ddd8df6c207492c547315ce7d
2016-03-15 12:40:07 -04:00
Ryan VanderMeulen 706d97900d Backed out changeset 14092b3cacbe (bug 1255614) because it blocks bug 1255009 from being backed out.
--HG--
extra : rebase_source : 0b1027cd8a156536f561c56662696ef1c35e3e8a
extra : histedit_source : 4d18d24cbd36cde0c7b5187b7e797a13d4dbf60a
2016-03-15 12:39:43 -04:00
Alexander Surkov f5fca44245 Bug 1255614 - make ProcessInvalidationList to insert accessibles instead the recaching, r=yzen 2016-03-14 17:28:08 -04:00
Alexander Surkov 900d88c035 Bug 1255009 - insert children into the tree on content insertion instead the recaching, r=yzen 2016-03-11 11:35:35 -05:00
Alexander Surkov 8efa10b16c Bug 1249253 - content removal processing can wrongly remove ARIA owned children, r=yzen 2016-03-10 15:46:44 -05:00
Alexander Surkov 3ed80742a7 Bug 1249730 - make TreeWalker bi-directional, r=yzen 2016-03-07 16:43:27 -05:00
Alexander Surkov 1c0239e18b Bug 1251871 - text removal from a hypertext may result in empty text nodes, r=davidb 2016-03-05 12:26:18 -05:00
Alexander Surkov 5f66eadca0 Bug 1251944 - get rid of nsCoreUtils::GetRoleContent, r=davidb 2016-03-04 10:36:18 -05:00
Alexander Surkov 4a93a11cd7 Bug 1251941 - aria::GetRoleMap should take element, r=davidb 2016-03-03 07:45:47 -05:00
Alexander Surkov 2bf7aa7227 Bug 1251897 - DocAccessible constructor doesn't have to take root element as an argument, r=davidb 2016-03-02 09:39:06 -05:00
Alexander Surkov e03035ce3f Bug 1251743 - ARIA owns reallocation may insert a child at wrong index, r=yzen 2016-03-01 14:35:01 -05:00
Alexander Surkov 88b0765ee7 Bug 1252260 - get rid of HTML table CacheChildren, r=marcoz 2016-03-01 10:54:49 -05:00
Alexander Surkov bd8b96d1c0 Bug 1251712 - propagate a context flag for alerts, r=davdib 2016-02-29 10:08:40 -05:00
Alexander Surkov 84d2440496 Bug 1251680 - get container accessible computation should take into account the HTML select, r=marcoz 2016-02-29 10:05:29 -05:00
Alexander Surkov 81c03ec4e8 Backout changeset 16516bf9614b, because of wrong bug reference 2016-02-29 10:04:49 -05:00
Alexander Surkov 9feeb71568 Bug 1250878 - add acceptable child check for HTML select, r=marcoz 2016-02-27 07:55:30 -05:00
Alexander Surkov 26f40b9ba5 Bug 1251218 - add special TreeWalker constructor for children creation, r=marcoz 2016-02-26 13:29:27 -05:00
Alexander Surkov 8d10d8bfb6 Backout bug 1251218 2016-02-26 11:04:05 -05:00
Alexander Surkov 0eb122a31e Bug 1251218 - add special TreeWalker constructor for children creation, r=marcoz 2016-02-26 10:53:21 -05:00
Alexander Surkov 54fb8b2c7c Bug 1250715 - no acceptable children for leafs, r=marcoz 2016-02-25 10:42:52 -05:00
Alexander Surkov d26328b368 Bug 1250333 - do not create accessibles for trailing BRs, r=davidb, roc 2016-02-25 07:09:59 -05:00
Alexander Surkov 3ac6460f92 Bug 1250506 - check if node is acceptable as a child before creating an accessible for it, r=davidb 2016-02-24 08:01:21 -05:00
Alexander Surkov 58922d0029 Bug 1249927 - devirtualize CanHavaAnonymousChildren, r=davdib 2016-02-22 12:32:03 -05:00
Alexander Surkov 0b5d5b3e24 Bug 1248838 - ARIA owns change may fail, r=yzen 2016-02-19 13:11:33 -05:00
Alexander Surkov aee776059c Bug 1248840 - rename TreeWalker::NextChild, r=yzen 2016-02-18 17:57:17 -05:00
Gijs Kruitbosch af8ae4ede1 Bug 1216478 - prefer tooltiptext on a XUL element over title attribute on a containing toolbaritem when determining accessible name, r=surkov
MozReview-Commit-ID: Cv0Kl5U02jy

--HG--
extra : rebase_source : 40ff881eabb42579a25e22c6c290ce3c5d0e7634
2016-01-20 13:47:42 +00:00
Kyle Huey 91efc5a86c Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
Ting-Yu Lin 1889f6bc41 Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
--HG--
extra : commitid : 5qtaK1nS8RC
extra : rebase_source : dcc98f423b2446269beb6fa6a9d092ae8213f38e
2016-01-29 22:42:14 +08:00
Trevor Saunders 0f654643cf bug 1241453 - factor dispatching nsIAccessibleEvents out of HandleAccEvent() r=davidb 2016-01-26 07:49:25 -05:00
Alexander Surkov 356a8b6d75 Bug 1233118 - implement IAccessible2_3::selectionRanges, r=yzen 2016-01-20 12:53:03 -05:00
Eitan Isaacson 7f81b68d25 Bug 1239051 - Labels should expose labeled controllers action. r=tbsaunde 2016-01-14 12:37:15 -08:00
Nicholas Nethercote 3ba02d7a9b Bug 1232852 (part 3) - Remove unused parameters from some accessibility code. r=tbsaunde.
--HG--
extra : rebase_source : 7cdef8244e2b44b89e8061f66d45d40cbf245041
2015-12-15 21:24:06 -08:00
Alexander Surkov 37b5a7125a Bug 1231919 - crash in mozilla::a11y::DocAccessible::ValidateARIAOwned, r=davidb 2015-12-14 12:02:23 -05:00
Bogdan Postelnicu cb90360057 Bug 1230118 - added asserts on aOwner and aOwner->Elm() r=surkov
--HG--
extra : commitid : 5Hi6E55At3
extra : source : a9ce85f77af9188fcb7500b3e156df1ad17a49e5
2015-12-03 14:07:43 -08:00
Wes Kocher 286a265f77 Backed out 2 changesets (bug 1230118, bug 1230110) for windows debug assertions in browser_perf-categories-js-calltree.js
Backed out changeset a9ce85f77af9 (bug 1230118)
Backed out changeset b9d8d05aa4ee (bug 1230110)

--HG--
extra : commitid : 9wnrd9NnBlp
2015-12-03 15:38:04 -08:00
Bogdan Postelnicu 10821cd308 Bug 1230118 - added asserts on aOwner and aOwner->Elm() r=surkov
--HG--
extra : commitid : DZ2Gxt3duam
extra : rebase_source : f35ddfd3a3eea486b0f1d23896bd158663132b2e
2015-12-03 14:07:43 -08:00
Robert O'Callahan 3568d59638 Bug 1221043. Revert to including trailing whitespace for accessibility APIs. r=marcoz,mats
--HG--
extra : commitid : DBGsn68FsG4
extra : rebase_source : 7b8f6211c2719dd017fef7e47d4dcdb3aeadfde4
2015-12-01 02:21:25 +13:00
Alexander Surkov 9df31a4c50 Bug 1213281 - crash in mozilla::a11y::DocAccessible::UpdateTreeOnInsertion, r=davidb 2015-11-26 20:46:12 -05:00
Nicholas Nethercote a62e6ee5b7 Bug 1224403 (part 8) - Use LayoutDeviceIntMargin more in HyperTextAccessible. r=kats.
--HG--
extra : rebase_source : 0e3cf7566f640f3165d677f67c005b43e290ac94
2015-11-12 05:34:27 -08:00
Nicholas Nethercote 7922110bde Bug 1224403 (part 2) - Split GetClientOffset() into typed and untyped versions. r=kats.
--HG--
extra : rebase_source : 5197f42325d36313ad8c6178baaabcf6f7df532c
2015-11-11 19:56:06 -08:00
Nicholas Nethercote ad0dd8414a Bug 1223310 (part 2) - Use LayoutDeviceIntRect for bounds-related functions in nsIWidget. r=kats.
The patch renames the existing functions (GetBounds(), GetClientBounds(), etc)
by adding an |Untyped| suffix. It then adds typed equivalents, and uses those
typed equivalents in all the call sites where it's easy to do so. The trickier
remaining call sites are converted to use the Untyped-suffix version.

--HG--
extra : rebase_source : 6bfb15bfc4698e2eba7d4db55497299d3dffcd51
2015-11-09 21:37:32 -08:00
Trevor Saunders 3dd3759899 bug 1213402 - separate value change events into text value changes and numeric value changes r=davidb
Arguably these are different things, and it will be easier to proxy events for
atk this way because atk only wants the numeric value changes.
2015-11-10 15:55:08 -05:00
Alexander Surkov d5d70c968a Bug 1221542, bug 1221543 - crash in mozilla::a11y::DocAccessible::SeizeChild/PutChildrenBack, r=davidb 2015-11-09 14:47:38 -05:00
Alexander Surkov 6606e57d29 Bug 582024 - ARIA active-descendant should work for ARIA owned elements, r=yzen 2015-11-03 11:03:34 -05:00
Alexander Surkov 08b94a69ed Bug 1219744 - no child_of/parent_of relations for aria-owns, r=yzen 2015-11-02 12:42:27 -05:00
Robert O'Callahan 2d8cd33dc4 Bug 264412. Refactor nsIFrame::GetRenderedText API to be more sane. r=mats,marcoz
The test changes here are to adjust for the fact that
nsTextFrame::GetRenderedText can now trim whitespace from the end of lines
that end in a hard line break.

--HG--
extra : commitid : 42YjYQUaiwY
extra : rebase_source : 69d3a9c5086c116365a0488d1b4fc52fc6524196
2015-10-30 19:23:10 +13:00
Alexander Surkov 54171e1ece Bug 1219299 - rework aria-owns implementation, r=yzen 2015-10-29 18:08:48 -04:00