Граф коммитов

7111 Коммитов

Автор SHA1 Сообщение Дата
Kershaw Chang 87cd113e41 Bug 1584104 - Add some information needed by parent process to nsITransportSecurityInfo r=keeler
When socket process is enabled, parent process needs some information in `CommonSocketControl`, but `CommonSocketControl` is only accessible in socket process.
This patch moves some data members from `CommonSocketControl` to `nsTransportSecurityInfo` and make it possible for parent process to get the needed data.

Differential Revision: https://phabricator.services.mozilla.com/D64084

--HG--
extra : moz-landing-system : lando
2020-03-02 20:28:15 +00:00
ffxbld 2690d1d20f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D64941

--HG--
extra : moz-landing-system : lando
2020-03-02 13:42:22 +00:00
Moritz Birghan e037cf93e5 Bug 1618710 - Refactoring nsClientAuthRememberService to work as a service r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D62585

--HG--
extra : moz-landing-system : lando
2020-02-28 01:32:38 +00:00
shindli 090056def5 Backed out changeset a538b0497336 (bug 634697) for causing android build bustages in /builds/worker/workspace/build/src/security/manager/ssl/nsNSSComponent.cpp CLOSED TREE 2020-02-28 01:05:11 +02:00
Moritz Birghan d3291a0a11 Bug 634697 - Refactoring nsClientAuthRememberService to work as a service r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D62585

--HG--
extra : moz-landing-system : lando
2020-02-27 21:28:34 +00:00
ffxbld 3da50ef6ba No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D64580

--HG--
extra : moz-landing-system : lando
2020-02-27 18:48:55 +00:00
manas 3558de5641 Bug 1613255 - Remove redundant return statement. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D64354

--HG--
extra : moz-landing-system : lando
2020-02-27 18:25:56 +00:00
Kershaw Chang a1b1d6ff88 Bug 1616549 - Set resumption token again after handshake reset r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D63319

--HG--
extra : moz-landing-system : lando
2020-02-27 12:44:10 +00:00
J.C. Jones 5f3cbafe43 Bug 1616675 - Add an IPv4 secure service to mochitests' ssltunnel r=keeler
WebAuthn needs to write a test to confirm it's prohibited when accessed via
an IP address. This adds the capability to get a SecureContext for an IP host.
It uses 127.0.0.2 so as to bypass restrictions on 127.0.0.1, and the use of .1
as a special-market in ssltunnel.

Differential Revision: https://phabricator.services.mozilla.com/D63570

--HG--
extra : moz-landing-system : lando
2020-02-26 23:15:02 +00:00
Simon Giesecke aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Sylvestre Ledru ca6530131a Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,kvark
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D63787

--HG--
extra : moz-landing-system : lando
2020-02-24 15:33:38 +00:00
ffxbld 1a2afa385b No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D63847

--HG--
extra : moz-landing-system : lando
2020-02-24 13:53:33 +00:00
Mike Shal c8abdd68c2 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-21 00:05:17 +00:00
Csoregi Natalia 6360b24e80 Backed out 2 changesets (bug 1616630) for Android bustage. CLOSED TREE
Backed out changeset 15016546c954 (bug 1616630)
Backed out changeset dcb7dc51633b (bug 1616630)
2020-02-20 21:24:11 +02:00
Mike Shal 39492660f4 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Depends on D63437

Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-20 16:21:55 +00:00
ffxbld 60706288cf No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D63465

--HG--
extra : moz-landing-system : lando
2020-02-20 13:40:32 +00:00
Dana Keeler 6d31f32301 bug 1616330 - handle reinitializing osclientcerts on macOS r=kjacobs
On macOS, dynamic libraries with thread-local-storage don't get unloaded. So,
if the osclientcerts library gets "unloaded", it doesn't actually go away. We
stop its background thread, so this isn't a problem, but if the osclientcerts
library gets re-enabled, all of its state comes back the same as before. So,
when NSS calls C_Initialize again, things like the manager proxy will already
be initialized. Before this patch, this situation would be an error. This patch
handles this case by dropping the old manager proxy and creating a new one.

Differential Revision: https://phabricator.services.mozilla.com/D63264

--HG--
extra : moz-landing-system : lando
2020-02-19 21:07:26 +00:00
Dana Keeler 6d38e846af bug 1610644 - search for new client certificates/keys in osclientcerts no more than once every 3 seconds r=kjacobs
Before this, every time NSS wanted to open a new session (C_OpenSession),
osclientcerts would look for new client certificates/keys in the OS store. It
turns out, NSS wants to open new sessions often, so this was slow. This patch
adds a timestamp to the manager and ensures that it searches for new objects no
more than once every 3 seconds.

Additionally, this patch adds the optimization that if NSS tries to search for
PKCS#11 objects with attributes that osclientcerts doesn't support,
osclientcerts returns an empty search early, rather than enumerating every
object and finding no matches.

In the future we may need to be smarter about how we match objects during
searches. Rather than iterating through every object, we could build lookup
tables that would be much more time efficient.

Differential Revision: https://phabricator.services.mozilla.com/D62982

--HG--
extra : moz-landing-system : lando
2020-02-19 17:44:04 +00:00
Kershaw Chang 583ae04d36 Bug 1607445 - Clear tokens cache at places where SSL_ClearSessionCache() is called r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D62021

--HG--
extra : moz-landing-system : lando
2020-02-18 19:04:28 +00:00
Mike Shal d8e4653d19 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-14 13:22:46 +00:00
ffxbld c8bab6f1bf No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D63065

--HG--
extra : moz-landing-system : lando
2020-02-17 14:03:43 +00:00
Cosmin Sabou ff39f9206d Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout
Backed out changeset 77e54e76848a (bug 1611326)
Backed out changeset 36ba18ac3a68 (bug 1613263)
2020-02-14 15:02:21 +02:00
Dana Keeler 63fee6e2b1 bug 1615068 - enable test_osclientcerts_module.js on macOS r=kjacobs
Differential Revision: https://phabricator.services.mozilla.com/D62824

--HG--
extra : moz-landing-system : lando
2020-02-14 00:24:46 +00:00
Mike Shal ad0c283ab2 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 23:07:04 +00:00
Brindusan Cristian e2fb6b8344 Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE 2020-02-13 23:33:34 +02:00
Dana Keeler 2e9c5af592 bug 1613422 - test fixups to avoid skipping regenerating some expired certificates r=jcj
See bug 1613275 and bug 1607845. In bug 1607845, the aim was to regenerate all
test certificates that would be expiring. Unfortunately, a few were missed:

 * build/pgo/certs/ certificate DBs and mochitest.client are regenerated in a
   different way than the rest of the certificates in bug 1607845. These would
   probably best be addressed by formally documenting the process of
   re-generating all of the certificates.

 * security/manager/ssl/tests/unit/test_certDB_import/ certificates were
   missed by mistake. It's unclear how this happened.

 * security/manager/ssl/tests/unit/test_intermediate_preloads/ were missed
   because there was no test_intermediate_preloads entry in the TEST_DIRS
   section of security/manager/ssl/tests/unit/moz.build, which means that the
   build system never knew to re-generate those certificates, even after
   un-commenting-out the contents of
   security/manager/ssl/tests/unit/test_intermediate_preloads/moz.build

 * security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der
   was DER, not PEM, and we don't have a way to automatically re-generate DER
   certificates in the same way. However, it didn't even need to be DER.

Differential Revision: https://phabricator.services.mozilla.com/D61712

--HG--
extra : moz-landing-system : lando
2020-02-13 21:20:59 +00:00
Mike Shal e6464dd404 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 20:31:50 +00:00
ffxbld 1564b1756c No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D62744

--HG--
extra : moz-landing-system : lando
2020-02-13 18:39:13 +00:00
Julian c23b87e26d Bug 1608215 - port pippki DTD to fluent r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D59635

--HG--
extra : moz-landing-system : lando
2020-02-13 15:27:17 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Dana Keeler 2e7b630474 bug 1586915 - build osclientcerts in-tree for macOS r=jcj,mstange
This patch implements osclientcerts for macOS.
Because the SDK we build with isn't recent enough, some of the functions we
need aren't guaranteed to be available. To handle this, we load the Security
framework at runtime and attempt to locate the symbols we need. If this
succeeds, then operation proceeds as normal. Otherwise, the module will report
that there are no certificates/keys available.

Differential Revision: https://phabricator.services.mozilla.com/D59957

--HG--
extra : moz-landing-system : lando
2020-02-12 17:08:48 +00:00
Daniel Varga 8450e6f6d2 Backed out changeset 53f51116fad1 (bug 1608215) for causing browser chrome failure at security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js
CLOSED TREE
2020-02-12 14:56:35 +02:00
Julian 0eca4a9694 Bug 1608215 - port pippki DTD to fluent r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D59635

--HG--
extra : moz-landing-system : lando
2020-02-12 11:03:10 +00:00
Cosmin Sabou 247ef75f7e Backed out changeset 28a30a7e2666 (bug 1586915) for causing Windows MinGW bustages. 2020-02-12 00:50:38 +02:00
Dana Keeler 877ec9a17a bug 1586915 - build osclientcerts in-tree for macOS r=jcj,mstange
This patch implements osclientcerts for macOS.
Because the SDK we build with isn't recent enough, some of the functions we
need aren't guaranteed to be available. To handle this, we load the Security
framework at runtime and attempt to locate the symbols we need. If this
succeeds, then operation proceeds as normal. Otherwise, the module will report
that there are no certificates/keys available.

Differential Revision: https://phabricator.services.mozilla.com/D59957

--HG--
extra : moz-landing-system : lando
2020-02-07 21:25:03 +00:00
Dana Keeler 7e92a667e3 bug 1613729 - join the osclientcerts manager thread r=jcj
Differential Revision: https://phabricator.services.mozilla.com/D62330

--HG--
extra : moz-landing-system : lando
2020-02-10 21:27:56 +00:00
Kershaw Chang ce95c08868 Bug 1607194 - P1: NSS initialization without nsNSSComponent for the socket process r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D58774

--HG--
extra : moz-landing-system : lando
2020-02-10 17:07:26 +00:00
ffxbld 064dc02d0e No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D62251

--HG--
extra : moz-landing-system : lando
2020-02-10 13:33:58 +00:00
Bogdan Tara 0a7e661a03 Backed out changeset 9a86b638ad8a (bug 1613422) for test_missing_intermediate.js failures CLOSED TREE 2020-02-06 21:53:21 +02:00
Dana Keeler 984f708e43 bug 1613422 - test fixups to avoid skipping regenerating some expired certificates r=jcj
See bug 1613275 and bug 1607845. In bug 1607845, the aim was to regenerate all
test certificates that would be expiring. Unfortunately, a few were missed:

 * build/pgo/certs/ certificate DBs and mochitest.client are regenerated in a
   different way than the rest of the certificates in bug 1607845. These would
   probably best be addressed by formally documenting the process of
   re-generating all of the certificates.

 * security/manager/ssl/tests/unit/test_certDB_import/ certificates were
   missed by mistake. It's unclear how this happened.

 * security/manager/ssl/tests/unit/test_intermediate_preloads/ were missed
   because there was no test_intermediate_preloads entry in the TEST_DIRS
   section of security/manager/ssl/tests/unit/moz.build, which means that the
   build system never knew to re-generate those certificates, even after
   un-commenting-out the contents of
   security/manager/ssl/tests/unit/test_intermediate_preloads/moz.build

 * security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der
   was DER, not PEM, and we don't have a way to automatically re-generate DER
   certificates in the same way. However, it didn't even need to be DER.

Differential Revision: https://phabricator.services.mozilla.com/D61712

--HG--
extra : moz-landing-system : lando
2020-02-06 18:34:06 +00:00
ffxbld b0457ded54 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D61817

--HG--
extra : moz-landing-system : lando
2020-02-06 13:38:28 +00:00
Kershaw Chang 3874b4bd01 Bug 1612362 - Convert SECOidTag to EVStatus eariler in SSLServerCertVerificationJob::Run r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D61377

--HG--
extra : moz-landing-system : lando
2020-02-05 18:34:23 +00:00
Kershaw Chang c433ee07ac Bug 1612362 - Using arrays of array bytes to replace BuiltCertChain r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D61374

--HG--
extra : moz-landing-system : lando
2020-02-05 18:33:58 +00:00
Kershaw Chang 4c01ed0b57 Bug 1612362 - Refactor SSLServerCertVerificationJob for reusing the code r=keeler
In order to reuse  SSLServerCertVerificationJob, this patch exposes SSLServerCertVerificationJob and adds ServerCertVerificationResultCallback for delivering the verification result.

Differential Revision: https://phabricator.services.mozilla.com/D58604

--HG--
extra : moz-landing-system : lando
2020-02-05 18:31:25 +00:00
Kershaw Chang 599e6f65d0 Bug 1612362 - Using arrays of array bytes to replace UniqueCERTCertList r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D58608

--HG--
extra : moz-landing-system : lando
2020-01-31 15:09:03 +00:00
Kershaw Chang eda74595de Bug 1612362 - Add a helper function to convert CertificateTransparencyInfo to CertificateTransparencyStatus r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D50833

--HG--
extra : moz-landing-system : lando
2020-01-30 15:11:14 +00:00
J.C. Jones 3a0a8e2762 Bug 1613275 - Regenerate expired certs not handled by Bug 1607845 a=RyanVM CLOSED TREE
commands:

openssl x509 -in security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.pem -outform der -out security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der

mach python ./build/pgo/genpgocert.py

./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_certDB_import/emailEE.pem.certspec >security/manager/ssl/tests/unit/test_certDB_import/emailEE.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_certDB_import/importedCA.pem.certspec >security/manager/ssl/tests/unit/test_certDB_import/importedCA.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/ee.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/ee.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/ee2.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/ee2.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/int.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/int.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/int2.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/int2.pem


Differential Revision: https://phabricator.services.mozilla.com/D61653

--HG--
extra : amend_source : ba63f416c91785a479695f342cf8db70ccd49cba
2020-02-04 20:17:49 -07:00
Christian Holler 35986ca9d6 Bug 1612713 - Avoid unloading several libraries in TSan builds. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D61569

--HG--
extra : moz-landing-system : lando
2020-02-04 14:38:49 +00:00