cb71a3c4fe
Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
2017-11-30 12:55:54 +02:00
403ad27bae
Bug 1420802 - Remove NetworkLinkService from offline check. r=tcsc
...
Summary: Remove NetworkLinkService from offline check.
Reviewers: tcsc
Reviewed By: tcsc
Bug #: 1420802
Differential Revision: https://phabricator.services.mozilla.com/D300
2017-11-29 15:15:28 -05:00
0dd353e7d5
Bug 1421850 - ensure Sync is fully initialized before syncing. r=tcsc
...
MozReview-Commit-ID: 7hS3fttgqqr
--HG--
extra : rebase_source : b9a342c1a977699c3c4c42e9bca86ee087a51260
2017-11-30 14:03:57 +11:00
788c2ca211
Bug 1421817 - Send a sync ping on shutdown if we have events but no syncs. r=markh
...
MozReview-Commit-ID: ExxN6UXs2Ip
--HG--
extra : rebase_source : 356d2f7bbfc856859e7b6246939b785f0984fa82
2017-11-29 17:41:59 -05:00
302308a0a1
Bug 1336257 - Use HTTPS for mozqa url in TPS. r=markh
...
MozReview-Commit-ID: Admw1iKeW24
--HG--
extra : rebase_source : 836f3efb3aea6eb2a089c5aecd0f7a10a0bd6787
2017-11-29 18:35:28 -05:00
4b66d38dd6
Bug 1420810 - record why we are syncing for most syncs initiated by the scheduler. r=eoger
...
MozReview-Commit-ID: 1ntqG5yQi7q
--HG--
extra : rebase_source : 73b479ac7e602f5f491f63939a4425af17d6ce25
2017-11-27 17:32:05 +11:00
39bf8149a6
Bug 1416788 - limit number of visits we pass to PlacesUtils.history.insertMany to prevent shutdown hangs. r=kitcambridge
...
MozReview-Commit-ID: AU9AMUAD1Rw
--HG--
extra : rebase_source : 205ec0f17f94bd399f4663e552bd75e7b63f7da5
2017-11-23 16:18:55 +11:00
dc2fe37c66
Bug 1421452 - Fix deprecation warning in test_bookmark_engine by passing an osfile path instead of nsifile. r=markh
...
MozReview-Commit-ID: 4XrzA0kUXzE
--HG--
extra : rebase_source : bed7a594b854969dd1932449f43ade4dc068ffeb
2017-11-28 17:35:51 -05:00
a004052a6e
Bug 1421044 - Make TPS await sync initialization before trying to run r=markh
...
MozReview-Commit-ID: JSBXKHRXjc0
--HG--
extra : rebase_source : f18047d5a71d92acb9712244266909fc9e09dd0f
2017-11-28 13:56:48 -05:00
6e7fbdc912
Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup. r=eoger
...
MozReview-Commit-ID: 3bOnRH5jR9e
--HG--
extra : rebase_source : 63eb169666e6b5694e7324f5eb01349189a895ec
2017-11-28 11:48:10 -05:00
efaca11893
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/. r=markh
...
MozReview-Commit-ID: LQiMr3ppDuG
--HG--
extra : rebase_source : f509b5360e92db58f14b0f6a41c06e10fe7dd170
2017-11-24 14:46:33 +00:00
9f071e2083
Bug 1409534 - Replace Resource impl by fetch. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 5mmVeHeMQKf
--HG--
extra : rebase_source : 84c20e3b90b5bed43e511158270761e2e1da6b15
2017-11-06 16:24:40 -05:00
438ca97ce7
Bug 1419990 - Only sync the tabs collection on sleep if there are changes. r=markh
...
MozReview-Commit-ID: GC0KMmQPqqD
--HG--
extra : rebase_source : 2039c7f644b3510dda07839c1e561786ad8c0ba1
2017-11-23 11:24:41 -05:00
0154c0f443
Bug 1416320 - Do a quick sync before going to sleep. r=markh
...
MozReview-Commit-ID: I36uvEFlEz5
--HG--
extra : rebase_source : 93812879d3ea19042356e51672f7f464e30e9ee5
2017-11-10 14:09:44 -05:00
959009f1a8
Backed out changeset 23fbfd83e957 (bug 1416320) for ESlint failure at gecko/services/sync/modules/policies.js:558:71 on a CLOSED TREE
2017-11-21 07:26:51 +02:00
ab35b46c98
Bug 1416320 - Do a quick sync before going to sleep. r=markh
...
MozReview-Commit-ID: I36uvEFlEz5
--HG--
extra : rebase_source : 1910ac25084f6a8c37a6d21accf17da974d56493
2017-11-10 14:09:44 -05:00
b2e847755c
Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
...
MozReview-Commit-ID: GrlcOI9K2hJ
--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00
afa6330a25
Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep. r=markh
...
MozReview-Commit-ID: 2vzmj3UkvtD
--HG--
extra : rebase_source : a152684365627cf1ea68efe10f5e27ad15577135
2017-11-16 13:12:31 -05:00
0648f86b7f
Bug 1304898 - Include why in sync ping. r=tcsc
...
MozReview-Commit-ID: G9WnHhuWD7Z
--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
2017-11-15 17:10:45 -05:00
fbd7ca1890
Bug 1416807 - Don't schedule syncs while we're behind to a captive portal. r=markh
...
MozReview-Commit-ID: 2CrO3CfKgC3
--HG--
extra : rebase_source : 460fb20172e325a154a4848e6a5ed0bacefd4b77
2017-11-15 16:01:48 -05:00
d6c28d0200
Bug 1417590 - Check for client duplicates in the Sync collection validator. r=tcsc
...
MozReview-Commit-ID: LcPnTEDhbis
--HG--
extra : rebase_source : 5070eebbb1495ac14cc140862dd78d46e638615f
2017-11-10 22:27:30 -08:00
43771ba19d
Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
...
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.
MozReview-Commit-ID: 5TUueknq3ng
--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
2017-11-07 12:01:53 -08:00
9e62cc5726
Bug 1416313 - Drop old or low priority commands rather than failing to sync the clients engine if too many commands are sent. r=eoger,markh
...
MozReview-Commit-ID: 6BJGmUL28hp
--HG--
extra : rebase_source : 894cafb34f193b802c90052142174ea3187b8396
2017-11-10 15:57:33 -05:00
892f157456
Bug 1416902 - Fix missing await in test_service_sync_updateEnabledEngines and test_interval_triggers r=kitcambridge
...
MozReview-Commit-ID: 6rFOWPsxxxj
--HG--
extra : rebase_source : 62e37062876d4dd38cc43f532df622c09b94cf1b
2017-11-13 16:53:15 -05:00
8a3dc70885
Bug 1416321 - Do a sync after we successfully connect to a captive portal. r=markh
...
MozReview-Commit-ID: HuXyJ8IrNwA
--HG--
extra : rebase_source : b1171a1235011d5393dcd90a950b55320302c254
2017-11-10 14:55:19 -05:00
93a711ae04
Bug 1416374 - Handle getting an abortincoming error in sync telemetry r=markh
...
MozReview-Commit-ID: LFmbkGa4ypu
--HG--
extra : rebase_source : 93e7e9fcfbdf141c86cede055b58d82985fea370
2017-11-10 18:02:58 -05:00
177a5a8bdc
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
...
--HG--
extra : histedit_source : 46923056fd09298724464a4df4466357821a361f
2017-11-12 21:22:25 -05:00
31aa407113
Bug 1383623 - Remove synchronous Places API usage from the Sync unit tests. r=tcsc
...
MozReview-Commit-ID: Cip7LSSi2fE
--HG--
extra : rebase_source : deaff010d15d7ae9812d1d38f3b39c1100c62cf3
2017-11-09 15:46:27 -08:00
b16410f51c
Merge inbound to m-c. a=merge
2017-11-10 16:13:15 -05:00
cbb956e0c3
Bug 1407679 - Merge nsIIOService and nsIIOService2; r=nwgh
2017-11-10 07:03:36 -07:00
96b3be2c0d
Bug 1415957 - Remove MozMill from TPS: Fix merge conflict. r=conflict-fix a=conflict-fix on a CLOSED TREE
...
--HG--
extra : amend_source : fd6fe1681aa192ed44675bd52cd46e954ffad9b8
2017-11-10 13:45:48 +02:00
7e070192d7
Merge inbound to mozilla-central r=merge a=merge
2017-11-10 11:55:43 +02:00
f4dd5e2636
Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
...
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
2017-11-10 09:07:48 +11:00
207b8d909e
Bug 1347515 - Get rid of nsIJSON.decodeFromStream, r=qdot
2017-11-10 00:27:22 +01:00
1873a289f7
Bug 1415957 - Remove MozMill from TPS. r=tcsc
...
MozReview-Commit-ID: HyBXrNqhzIf
--HG--
extra : rebase_source : da197fa045f70621d5549e961876cfc6ce15264b
2017-11-09 15:34:06 -05:00
be730a069d
Bug 1414438 - Use `getBatched` instead of `get` to backfill records r=kitcambridge
...
MozReview-Commit-ID: LLTg0ae5BbW
***
Bug 1414438 - Use `getBatched` instead of `get` in sync
--HG--
extra : rebase_source : b9b057160470ec5bc5544a1a4d5d429bee460452
2017-11-08 09:05:11 +01:00
21b6b18b0b
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
2017-11-10 13:47:59 +02:00
d93840902b
Bug 1382937 - Rewrite Sync's master password functions to use the `nsILoginManagerCrypto` wrappers. r=MattN
...
Using `nsISecretDecoderRing` directly bypasses
`nsILoginManagerCrypto.uiBusy` and the observer notifications, so other
consumers might not be aware we're already showing the dialog. We also
bail early if the UI is busy, to avoid showing multiple dialogs.
MozReview-Commit-ID: I7xzUWZkyPH
--HG--
extra : rebase_source : 91cef140cc54d1c81fe5c1986ffd2b8983ddd575
2017-10-23 10:40:56 -07:00
edeaf1bc14
Bug 1415012 - Don't trigger a resync if the previous sync wasn't completely successful r=kitcambridge
...
MozReview-Commit-ID: DcNsFUxXR1O
--HG--
extra : rebase_source : 2632aa8d6db8e9e101e949c237b559015444f808
2017-11-06 20:56:57 -05:00
af670f4147
merge mozilla-central to mozilla-inbound. r=merge a=merge
2017-11-07 02:47:30 +02:00
53383c5b3f
Bug 1408108 - Rename "Sync ID" to "record ID" in the bookmarks engine and `PlacesSyncUtils`. r=kitcambridge
...
--HG--
extra : rebase_source : da3acfc4f7393a615c44f238c624bb826ff5b766
2017-11-06 12:17:07 -08:00
935734388d
Bug 1412351 - Make sync behave better during shutdown r=kitcambridge
...
MozReview-Commit-ID: 4zWNph8Zdld
--HG--
extra : rebase_source : 12e9f82222a4bcfe2161ad02669619b57f0442fe
2017-10-27 13:37:49 -04:00
d61954557d
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: Ai6Y5GGfkfT
2017-11-04 10:58:24 +01:00
b9c6a1d730
Bug 1413413 (part 2) - Remove support for extensions having their own prefs file. r=glandium,kmag.
...
It's no longer needed, now that legacy extensions aren't supported.
Pieces removed include the following.
- The "load-extension-default" observer notification.
- The code for reading defaults/preferences/*.js from extensions.
- The unit test for this stuff.
- A crash reporter annotation relating to very long prefs set by add-ons.
- All references to "ExtPrefDL".
MozReview-Commit-ID: KMBoYn3uZ3x
--HG--
extra : rebase_source : 4dc8ffd425c6cdf06806409090c4f9d04a64930b
2017-10-31 16:34:57 +11:00
e4007fdbe7
Bug 1375223 - Remove Async.querySpinningly. r=kitcambridge
...
MozReview-Commit-ID: bMo1jyIY5g
--HG--
extra : rebase_source : ac69fde2cb8216300bdb9e7d19528c15cdceb7c8
2017-10-31 18:50:31 -04:00
604673b3d3
Bug 1366067 - Use `JSONFile.jsm` to persist the backlog and previously failed IDs. r=tcsc
...
MozReview-Commit-ID: DAwMrtWI8eh
--HG--
extra : rebase_source : f6713745b09de2e6b0993539cce9ed4e8226dbbf
2017-11-01 11:10:47 -07:00
4a77d5a93f
Bug 1388224 - Remove SyncStorageRequest HTTP wrapper class, which is no longer used r=kitcambridge
...
MozReview-Commit-ID: EgExfizNll5
--HG--
extra : rebase_source : 85a6098a5b985990bd3a8483936bf6cf768f1f0b
2017-11-01 17:17:46 -04:00
064ed56076
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : f382f0a883c5aa1f6a4466fefe22ad1a88ab6d20
2017-11-01 11:09:57 -07:00
96593594d3
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 719ee2d9e46102195251b410f093da3247095c22
2017-10-27 17:54:48 -07:00
432850c0aa
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
3e7662202d
Bug 1413685 - Unify AsyncResource and Resource. r=tcsc
...
MozReview-Commit-ID: 1yEeAwpbGxJ
--HG--
extra : rebase_source : 8c87b0d16138acf2b55be70767fe0547f4ac1d42
2017-11-02 14:30:59 -04:00
1b5408583f
Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE
...
Backed out changeset 1b868efa368f (bug 1368209)
Backed out changeset b88c681ccdc1 (bug 1368209)
Backed out changeset 4b8e56844ae9 (bug 1368209)
2017-11-03 11:40:06 +02:00
4105f1cb3a
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : 13605dd3a43569a6d83dc2eb15a578a7bbd5c1ca
2017-11-01 11:09:57 -07:00
481bdb6dd6
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 5742474889845b934c3d2e8b479d26d719cd03c0
2017-10-27 17:54:48 -07:00
8f60eeed17
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
4ee948935f
Bug 1408176 - Use trace logs when logging PII in sync passwords engine r=kitcambridge
...
MozReview-Commit-ID: KueHgdTH02Z
--HG--
extra : rebase_source : a8f5814c5d9baf8e6c370c65da8472f9c7c6213e
2017-10-27 11:32:22 -04:00
4de6bf22b1
Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
...
MozReview-Commit-ID: H5YVp3rnzGo
--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
3b78d2f449
Bug 1412139 - Prepare existing bookmark engine tests for new buffered engine. r=kitcambridge
...
MozReview-Commit-ID: 2HIkdPOuWOy
--HG--
extra : rebase_source : 6c8108f707f59e8d795dfd489453c614f00fd096
2017-09-11 14:17:24 -07:00
1225809c1d
Bug 1411690 - Floor the repair advance and most recent repair timestamps. r=tcsc
...
The timestamps are automatically truncated when they're stored in
prefs, which is fine because we don't need millisecond precision.
However, the truncation raises a warning, so we need to explicitly
floor the values.
MozReview-Commit-ID: BRflL6s0b1
--HG--
extra : rebase_source : 6724a1ad05cb8aee4ab8c666545784960c23a0f3
2017-10-25 13:54:44 -07:00
1ead0a96a9
Backed out changeset dab1c5badddb (bug 1407679) for failing server startup in mochitests on Android. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 3dc4cb2bbaf55f3f6329687ce64d4e862fc3800b
2017-10-24 21:18:26 +02:00
9dd47ebf50
Bug 1407679 - Merge nsIIOService and nsIIOService2 r=nwgh
...
Removes deprecated nsIIOService2.newChannelFromURIWithProxyFlags
MozReview-Commit-ID: Gr3nA25kcre
--HG--
extra : rebase_source : 3407b5ed0f8f7067523abee28c137db3cac86b14
2017-10-20 16:41:07 +02:00
c31dc99e96
Bug 890217 - Add a test for syncing bookmarks with IMAP URLs. r=tcsc
...
MozReview-Commit-ID: KBVInzYk1Rr
--HG--
extra : rebase_source : 9ba1b55c154a9a19f24dcf8b859189123abcad1c
2017-10-20 08:55:52 -07:00
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
2c51427c6d
Bug 1408180 - Ensure LoginRec.toString doesn't contain the password. r=kitcambridge
...
MozReview-Commit-ID: 5mV0g9LH4vE
--HG--
extra : rebase_source : 33a9c246053448450e6107c3b244d0bf86f7decb
2017-10-12 18:15:48 -04:00
87cd48824a
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
2017-10-13 00:53:56 +02:00
f7efb5fc2c
Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
2017-10-12 12:03:15 +02:00
d8c3cc3c0b
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : d8d35bdb08edbad9412d6953a671c3e38e75711c
2017-10-03 14:45:11 -04:00
87b8d9ecb9
Bug 1406488 - Use a set instead of array to store current visits in `_recordToPlaceInfo` r=kitcambridge
...
MozReview-Commit-ID: LW6Gg7i5lun
2017-10-11 19:06:10 -04:00
30ccd917b0
Backed out changeset 8d5cc47b248f (bug 1401700) for failing xpcshell services/sync/tests/unit/test_bookmark_repair.js on OS X 10.10 opt. r=backout
2017-10-11 23:44:26 +02:00
51d18ff941
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : e98e4ee0a3e376840ce89f0908d7210b167154fa
2017-10-03 14:45:11 -04:00
4397201c90
Bug 1407726 - Add reason field to push messages sent with /notify. r=tcsc
...
MozReview-Commit-ID: 3sRpheND9Wa
--HG--
extra : rebase_source : 23f7dffb920f9f9f14ccdd16f171c489f36745cc
2017-10-11 14:58:21 -04:00
7555b605f1
Bug 1407082 - Handle more kinds of errors in SyncTelemetry.transformError. r=kitcambridge
...
MozReview-Commit-ID: CjwY7w7vUqs
--HG--
extra : rebase_source : 4030ab88c3eccd755272499ff0527e9e316998b1
2017-10-10 12:31:42 -04:00
da5797466a
Bug 1403276 - Dedupe sync devices with the same fxaDeviceId by picking the one with the newer last modified date r=eoger
...
MozReview-Commit-ID: 3Lq7vuPpF6
--HG--
extra : rebase_source : f16c5fe0d29551ab829ba8f0c8c92e78109ace07
2017-10-10 13:41:32 -04:00
0c48a189bc
Bug 1405833 - Ensure SyncEngine uses CommonUtils.namedTimer properly. r=kitcambridge
...
MozReview-Commit-ID: 6YnhcSjKW9U
--HG--
extra : rebase_source : 3e0e520516f06efa50aa8e3fccb77214daca419a
2017-10-04 17:26:20 -04:00
e9d579fe2a
Bug 1405566 - Clamp future and far past synced history visit dates. r=markh
...
MozReview-Commit-ID: Gs0DpTTu1Ab
--HG--
extra : rebase_source : b836f4ae366eaf127935dee593dc51d2222e3aca
2017-10-04 14:16:29 -07:00
c42f57923a
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : e20ec54eabb5ecb2cc0b85efb687dbed06f1d16a
2017-10-02 18:41:20 -07:00
e6050e53aa
Bug 1401990 - Use max_request_bytes instead of max_post_bytes if sync server provides both r=markh
...
MozReview-Commit-ID: GJadUIuSGKt
--HG--
extra : rebase_source : be8da0b14c0e1522bc1dc025871fc34830d9ae58
2017-10-02 16:42:22 -04:00
bd61777c6b
Backed out changeset fe9b8761d51f (bug 1348981)
2017-10-04 15:43:46 +02:00
8d488926ef
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 9ad775a652affc0d8d6c7ce4153dddc8a13c4ca4
2017-10-02 18:41:20 -07:00
d8e232c88a
Backed out changeset 8dda8bbcf385 (bug 1348981)
2017-10-04 01:00:09 +02:00
c8714b1c7d
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 058e6011c8ce953059e674eea032ba79c19f8eb8
2017-10-02 18:41:20 -07:00
d39e820403
Bug 1403052 - Limit tab sync max_record_payload_size to 512k. r=markh
...
Also fixes an issue where we wouldn't encode to utf8 when comparing the actual
size to the limit after the first time.
MozReview-Commit-ID: Cf3byjI1FTZ
--HG--
extra : rebase_source : 272ec3b3ad85f8b44c4d69950be83419054abdab
2017-10-02 19:27:54 -04:00
9f708fd861
Bug 1400467 - Ensure services/common/logmanager.js awaits it's cleanup function r=markh
...
MozReview-Commit-ID: thQph1UUA0
--HG--
extra : rebase_source : 705cdd9d07a1a26b568554e07638c0415789b404
2017-09-22 11:57:13 -04:00
76a3991796
Bug 1400467 - Make WeaveCrypto use promises instead of spinning event loops r=eoger,markh
...
MozReview-Commit-ID: 64dewKKaAOJ
--HG--
extra : rebase_source : e8d48e05ad8dac214358b0a9979b011a65ed07a8
2017-09-15 19:21:31 -07:00
1df9d06245
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 303c40b6fc5a41a7b2f2e9edc9f275228ccbbe47
2017-09-22 15:19:44 -04:00
60aea23a2c
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 5289322dea430f364790026470ff844f754dd570
2017-09-22 15:08:48 -04:00
6cbbf769ee
Backed out changeset d7876bfd8bfc (bug 1395427)
2017-09-27 17:10:21 +02:00
e08e4f2f41
Backed out changeset d86f2704b27a (bug 1395427)
2017-09-27 17:10:15 +02:00
7d0ecfa428
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 19f4c4c21c35d9d604e17d3e1df862bc700773bd
2017-09-22 15:19:44 -04:00
8dcfa9de4f
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 39f9cc5553f44f149abc0ed9715268c538fc27ba
2017-09-22 15:08:48 -04:00
216b709c48
Backed out 4 changesets (bug 1348981) for Linux debug timeouts in test_system_update.js
...
Backed out changeset b1fe39ea6d5c (bug 1348981)
Backed out changeset 47866f942752 (bug 1348981)
Backed out changeset 5e93d8760487 (bug 1348981)
Backed out changeset 58431e2c37d7 (bug 1348981)
MozReview-Commit-ID: 2WjZKztxyVs
2017-09-23 06:20:56 -07:00
70071e128b
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 8a98ba4a36f2717c1b733b661e9d8621a9bbfec0
2017-09-14 00:36:04 -07:00
ddbf9d22ec
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
...
MozReview-Commit-ID: Equ8FrTJpTj
2017-09-21 16:42:31 +02:00
b627373bca
Bug 1401686 - Handle cases where max_post_bytes is less than max_record_payload_bytes. r=kitcambridge
...
MozReview-Commit-ID: AAiF2rD075A
--HG--
extra : rebase_source : 657bf67186ebeb2e962c2b515d1fea47a95a677e
2017-09-20 16:18:20 -04:00
c278109711
Bug 1401382 - Make it safe to await inside async TPS handlers r=markh
...
This patch also makes all the remaining synchronouns TPS handlers async, since
it seems likely that this issue could happen again.
MozReview-Commit-ID: DSlrX3pgeJI
--HG--
extra : rebase_source : b55a54e51787398dc55d4359dd749be2c5900d6c
2017-09-19 18:40:19 -04:00
6348cd2190
Bug 1393659 - Fix inconsistent handling of max_post_bytes and max_request_bytes r=markh
...
MozReview-Commit-ID: 4jwpAYNuoQj
--HG--
extra : rebase_source : f32ecbd9740f7d8647fdf37ad6bbb53e332320ac
2017-09-13 18:02:41 -07:00
daf87f8b3b
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : cbeb2b30a425020e2379d3f5d21affabe610a20b
2017-08-21 17:06:06 -04:00
e6c038d6ee
Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js
...
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)
MozReview-Commit-ID: 88xbdeVJtK2
2017-09-16 10:40:00 -07:00
11875727be
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : f071fe7d8b67d84a0b2836b7dae3883e8c85c46a
2017-08-21 17:06:06 -04:00
95856672f4
Bug 1400394 - Remove `TestingUtils.deepCopy`. r=markh
...
MozReview-Commit-ID: 3ZZpA3inWSF
--HG--
extra : rebase_source : 506d1bb5bba484e65bcd5abed196c3ecc751fb1b
2017-09-15 13:46:21 -07:00
3a3834f7a8
Bug 1400075 - Cleanup async handling for tab engine in TPS. r=markh
...
MozReview-Commit-ID: BQ0aJodErWy
--HG--
extra : rebase_source : 4f74acd21f64559b9a7215638672f6952283a4fe
2017-09-14 16:59:11 -07:00
be553422dd
merge mozilla-central to autoland. r=merge a=merge
2017-09-13 11:30:55 +02:00
80aa14098f
Bug 1399191 - Use an arrow function to avoid an undefined this value when calling namedTimer. r=markh
...
MozReview-Commit-ID: 2VwzGtAIYz7
--HG--
extra : rebase_source : 8ac4f5b5aba9891a82f2f6777d8c1fc55d26d41e
2017-09-12 10:12:37 -07:00
f829523282
Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop
...
MozReview-Commit-ID: 4ewrbY0FS09
--HG--
extra : rebase_source : 390256a9eb0d303d8582c24d69fff189b0e0ab4d
2017-09-08 18:16:50 -07:00
d6cced9ca1
Bug 1394525 - Reset tracker scores before syncing. r=markh
...
MozReview-Commit-ID: 1wHdOeiZOyl
--HG--
extra : rebase_source : 765094feecdbe79cfa30f5c5a2886f8113890077
2017-08-28 11:24:26 -07:00
0d29ca233e
Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak
...
MozReview-Commit-ID: EbGybRbhWKJ
--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
614d92ab8f
Bug 1186409 - Fix code that tries to get the global by using |this|. r=kmag
...
MozReview-Commit-ID: C5ixngtvzWU
--HG--
extra : rebase_source : 65507b2d1f58a8f1f1e36e2153ed1d490f4a86dc
2017-05-25 14:12:12 -07:00
5317324bec
Bug 1397537 - check FxA has a session token and enter a needs-reauth state even when the user is unverified. r=eoger
...
MozReview-Commit-ID: KuldXySDvt4
--HG--
extra : rebase_source : 9b33265b341e7fcd5be9dc6e3b01d218ce1aabca
2017-09-07 11:13:53 +10:00
3136ed3935
Bug 1396967 - Fix undeclared assignments in MozMill. r=tcsc
...
MozReview-Commit-ID: 7C5zFAHmRQQ
--HG--
extra : rebase_source : f6b0d5e1cac37ec1031176f291a13953f5af4e83
2017-09-05 12:32:36 -07:00
27afdd11e1
Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman
...
MozReview-Commit-ID: AM0G43vFyty
--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
2017-09-05 12:40:53 +10:00
1e1c59dfa4
Bug 1396740 - declare waitForEvents object in TPS's mozmill extension. r=tcsc
...
MozReview-Commit-ID: AFWuHR7JgCp
--HG--
extra : rebase_source : dd886f33d5e427e046c2004bd5e993748bfc3caa
2017-09-05 17:57:47 +10:00
5f4d03ee95
Bug 1391488 - catch and ignore errors fetching the hostname from the DNS service. r=kitcambridge
...
MozReview-Commit-ID: 5hTDNmzTXdQ
--HG--
extra : rebase_source : 4565d13941fd167d81420e639e7ebc37f94a3a8f
2017-09-01 16:48:24 +10:00
2dad858a21
Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc
...
MozReview-Commit-ID: BW8ixM3wmxJ
--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
2017-07-27 11:59:24 +10:00
e16b402acf
Bug 1395148 - Run some services/sync xpcshell tests sequentially; r=markh
...
These tests normally pass when run sequentially but often timeout when run
in parallel, especially on debug builds.
2017-08-31 07:50:25 -06:00
8b415f700f
Bug 1394556: Part 1 - Fix strict mode errors in JSM scripts. r=Mossop
...
MozReview-Commit-ID: 4LmJQql7Y2c
--HG--
extra : rebase_source : f18b5547a5a57db4e8b990bfc34f06690ac9da7a
extra : histedit_source : 7281bafbde4bf231752d9d868ec8ca1d2f55a2f9
2017-08-30 01:50:27 -07:00
a8e6d0bd2c
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: 7XpmaFg1k8N
2017-08-29 16:17:13 -07:00
e200863a26
Bug 1298930 - Remove the eRestarti386 and eRestartx86_64 constants. r=spohl
...
--HG--
extra : amend_source : 303c9a9df47398ad87d86ba6522cbdddbfe647a7
2017-08-29 05:50:00 -04:00
51f7139dc5
Bug 1390644 - Change the mid-sync state of "Syncing…" to "Syncing Tabs…". r=eoger
...
MozReview-Commit-ID: Ef1aWhWEnZh
--HG--
extra : rebase_source : 458685d94d16acfb21d080287484869c93d7a091
2017-08-28 21:38:49 -04:00
5a0bb50ea8
Bug 1392148 - Remove aliases to CommonUtils in util.js r=markh
...
MozReview-Commit-ID: 1fv6AN0TMNW
--HG--
extra : rebase_source : 083c73e50bfdb2dd121aa483e5aa53ae0e35768d
2017-08-24 22:41:44 -07:00
c204098ad4
Bug 1392409 - set engine.lastModified to avoid intermittent orange. r=tcsc
...
MozReview-Commit-ID: 4kPzk9nSWxw
--HG--
extra : rebase_source : 6f4ef917001e2565dd00eefa12876fc897705ca1
2017-08-23 13:59:16 +10:00
a53020d022
Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
...
MozReview-Commit-ID: 35MaseieNUk
--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
34e7a1eb17
Bug 1355766 - don't treat a 412 response as a sync error. r=kitcambridge
...
MozReview-Commit-ID: 4IL6RJcP9PC
--HG--
extra : rebase_source : 2e0c3143da1f01eaeb5a30efab2becd367ded36c
2017-08-08 12:02:28 +10:00
fa4625acc7
Bug 1368951 - add x-if-unmodified-since support to the sync test server. r=tcsc
...
MozReview-Commit-ID: FF7smwdeQ0k
--HG--
extra : rebase_source : 82f8706d6a27f1bf93b95b93572a2fa37b268b3d
2017-05-31 18:42:45 +10:00
b242392e7d
Bug 1353217 - importing bookmarks from html doesn't need to reset the bookmarks engine. r=markh
...
MozReview-Commit-ID: 4F7KF5ZkNuX
--HG--
extra : rebase_source : 521510fe074fa0f84f28212fa8a230a74dfd2ce8
2017-08-11 00:19:01 +00:00
95c51b495b
Bug 1383622 (part 2) - update TPS to use the async bookmark API. r=tcsc
...
MozReview-Commit-ID: CnTx1stPyCY
--HG--
extra : rebase_source : 3123392bd8089c32d228f224baa7aca286f0d75d
2017-08-15 12:44:50 +10:00
c2aeb7a464
Bug 1383622 (part 1) - convert most of TPS to async/await. r=tcsc
...
MozReview-Commit-ID: F6kBw1vPBPh
--HG--
extra : rebase_source : 1bd302f66e35a7f078b5dfdc7d9b075e6bfe89f5
2017-08-12 14:09:48 +10:00
0ce9a00f9a
Backed out 2 changesets (bug 1383622) for eslint failures a=backout
...
Backed out changeset 60005e2d9ea5 (bug 1383622)
Backed out changeset d229587489da (bug 1383622)
MozReview-Commit-ID: J7N7iCBLsGZ
2017-08-16 16:25:30 -07:00
7f2a621327
Bug 1383622 (part 2) - update TPS to use the async bookmark API. r=tcsc
...
MozReview-Commit-ID: CnTx1stPyCY
--HG--
extra : rebase_source : 31cc8b3952d1d5e52ea84afa72d0b4aaa69c8d4c
2017-08-15 12:44:50 +10:00
4b462aadc9
Bug 1383622 (part 1) - convert most of TPS to async/await. r=tcsc
...
MozReview-Commit-ID: F6kBw1vPBPh
--HG--
extra : rebase_source : 1bd302f66e35a7f078b5dfdc7d9b075e6bfe89f5
2017-08-12 14:09:48 +10:00
a13adeddc4
Bug 1377944 - Converts the history engine to use 'PlacesUtils.history.insertMany'. r=kitcambridge
...
MozReview-Commit-ID: 61IoSuLE5cr
--HG--
extra : source : 26831e829c5a5d5e3026bb97518066f1764482c5
2017-07-31 00:53:50 -03:00
5b94d1f0b3
Bug 1389717 - Ensure `HistoryStore#changeItemID` waits for `fetchURLInfoForGuid`. r=markh,tcsc
...
MozReview-Commit-ID: CAVdgurQxPj
--HG--
extra : rebase_source : 45c3812ffd1782781a0e6ea8ab72b3fb0a32fcd6
2017-08-11 19:08:04 -07:00
2b29093c50
Bug 684121 - Don't access Services.appinfo at import time r=kitcambridge
...
As stated by Philipp, the prefs engine (PREFS_GUID) accesses Services.appinfo at import time.
Changed code to use a lazy getter on the global object instead.
changed services/sync/modules/engines/prefs.js
MozReview-Commit-ID: 1MAGKM9r1OM
--HG--
extra : rebase_source : 37f3112383f8073d1afa220ff7e8ac4d7fc38ec5
2017-08-13 05:08:48 +03:00
472098beec
Bug 1386171 - log urls for synced tabs at trace level. r=eoger
...
MozReview-Commit-ID: 2veccAv2Bpn
--HG--
extra : rebase_source : 3487ad6937913c663bb81d7f6c99f1deca7d5af7
2017-08-11 14:26:29 +10:00
3e1366bdf6
Bug 1388149 - Make PlacesUtils.history.insertMany respect provided GUIDs r=markh
...
MozReview-Commit-ID: 7g6uABtHKg2
--HG--
extra : rebase_source : 0b43e026ad3de514d2ffbc56568bf3f4e3e17126
2017-08-07 16:01:10 -04:00
635b24e121
Merge mozilla-central to autoland
2017-08-08 13:25:29 +02:00
0f16d437cc
merge mozilla-inbound to mozilla-central a=merge
2017-08-08 13:18:14 +02:00
a51f7dc64c
Backed out changeset 26831e829c5a (bug 1377944) at markh's request
...
MozReview-Commit-ID: 526HN6OCn1A
2017-08-07 20:42:50 -07:00
d4398e95f2
Bug 1385820 - Enable the ESLint no-new-wrappers rule across mozilla-central; r=markh,standard8
...
MozReview-Commit-ID: FvJO3ibeiwg
--HG--
extra : rebase_source : 5fc5c6760924da81a6d0708ff0d5586fc62c8c5e
2017-08-07 23:57:51 +05:30
8b713b2b0f
Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
...
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
4f08809c1f
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
...
MozReview-Commit-ID: 4bmu45qUmFA
2017-08-04 15:00:51 +10:00
5df77c43f9
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: IJRYyJu1sWm
2017-08-02 17:42:10 -07:00
017a9b6e9a
Merge autoland to central, a=merge
...
MozReview-Commit-ID: 38bhUR3fKcF
2017-08-02 15:47:58 -07:00
2b42c50319
Bug 1385440 - Serialize client commands additions. r=markh
...
MozReview-Commit-ID: 3qGcHVhOCeL
--HG--
extra : rebase_source : 3d71a5af631d2dd9be59ce0b1495959552f8c640
2017-08-02 11:33:24 -04:00
f0e4ae5f8c
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2017-08-02 09:12:05 +01:00
f143125cc2
Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu
...
MozReview-Commit-ID: DqJdTGopR9G
--HG--
extra : rebase_source : e8c9eb03468c075b79013b6e0bd8b367229c24cd
2017-07-29 20:50:21 +09:00
48e6bc2124
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
6b5f784403
Bug 1384818 - flush sync log files on sync reset. r=eoger
...
MozReview-Commit-ID: H6CkvHGxAmx
--HG--
extra : rebase_source : 53bede19ec7766c91c30324668dcca8d11f64197
2017-07-27 14:57:47 +10:00
5f4393ac11
Bug 1371746 - Remove unused variables in constants.js. r=kitcambridge
...
MozReview-Commit-ID: GUQjlWVHPC0
--HG--
extra : rebase_source : 13b127ecf84d8ef5b9a3f99c78960de15eb2a47b
2017-08-01 01:53:56 -03:00
5368b04624
Bug 1374722 - Expand the set of ids requested during the initial repair process r=markh
...
MozReview-Commit-ID: 92SGMd9fJgX
--HG--
extra : rebase_source : 0b6ca2379a03adc4488bf3f679a3f81b18de83b1
2017-06-20 13:40:17 -04:00
4f228db6e2
Bug 1387834 - Remove @deprecated nsIDOMWindowUtils.WHEEL_EVENT_CAUSED_BY_PIXEL_ONLY_DEVICE. r=masayuki
...
MozReview-Commit-ID: 4onWMSGPa4U
--HG--
extra : rebase_source : a5908d04a15fb0e9eb35b7e3c31a050bceafb2e7
2017-08-06 23:44:53 +09:00
b3c6e06245
Bug 1377944 - Converts the history engine to use 'PlacesUtils.history.insertMany'. r=kitcambridge
...
MozReview-Commit-ID: 61IoSuLE5cr
--HG--
extra : rebase_source : e3a84dc40e99b27e1beaa9dd9ceec4c2e41487e8
2017-07-31 00:53:50 -03:00
804a36e668
Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout
2017-07-31 14:44:34 +02:00
22dfa54ef4
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
7a9b4d8b79
Bug 1336518 - Move Sync history queries into PlacesSyncUtils. r=kitcambridge
...
MozReview-Commit-ID: Lood8ivLeJf
--HG--
extra : rebase_source : dcb8207378afc6ce2995acfe4f235f3ed728a188
2017-07-30 17:46:56 -03:00
5c9899d993
Bug 1383621 - Use the async bookmarks API to insert the mobile query. r=markh
...
MozReview-Commit-ID: KaeXwFHEg7K
--HG--
extra : rebase_source : b67f8662e221614041aad391d71bdf381ce4e8b0
2017-07-24 16:45:17 -07:00
8d2320d13f
Bug 1385191 - Prefer email address from the FxA profile over that from the account. r=eoger
...
MozReview-Commit-ID: 78U2RZQ5xfB
--HG--
extra : rebase_source : b79b18ea8c545003998692cd97c7ad5d6606c7f7
2017-07-28 16:35:40 +10:00
892bedca2e
merge mozilla-inbound to mozilla-central a=merge
2017-07-28 15:24:39 +02:00
99daef93ea
Backed out changeset face8d3f9fb9 (bug 1384818) for frequently failing xpcshell's services/sync/tests/unit/test_errorhandler_2.js on Linux. r=backout
2017-07-28 10:48:07 +02:00
c8885211ce
Bug 1385127 - Enable bookmark validation on early Beta. r=markh
...
MozReview-Commit-ID: h1ps0YebkW
--HG--
extra : rebase_source : 76f35b04fd37fbed82f483e526194e8a1a7623ea
2017-07-27 16:07:14 -07:00
4f86008efc
Bug 1384818 - flush sync log files on sync reset. r=eoger
...
MozReview-Commit-ID: H6CkvHGxAmx
--HG--
extra : rebase_source : 4fd55ac857c225e0a7de35f0049e873cc362b2db
2017-07-27 14:57:47 +10:00
3ad4c3d247
Bug 1384936 - Remove weave_version definition and directly replace the constant in modules/constants.js in the gecko migration script, to avoid the need for the preprocessor in modules/constants.js. r=rnewman,rail
...
--HG--
extra : rebase_source : b6f4ed4929ab6405fa726fbc25ea6748f871c07b
2017-07-27 16:22:53 +02:00
250eef68d6
Bug 1375212 - Wrap thrown strings in Error objects r=eoger,markh
...
MozReview-Commit-ID: KquBcbNhBEN
--HG--
extra : rebase_source : 172bcad2eb178092bc7d49940db61e8cb5ad6572
2017-07-22 18:55:43 -07:00
932f724512
Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh
...
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.
I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.
MozReview-Commit-ID: Gq16sNm7K2e
--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
2017-07-25 11:53:45 -07:00
65bbd0525a
Merge inbound to central, a=merge
...
MozReview-Commit-ID: E4oXfAM1mtd
2017-07-25 19:04:37 -07:00
061209972d
Bug 1368568 - Remove legacy SyncKeyBundle. r=eoger
...
MozReview-Commit-ID: JYiTeQnduto
2017-07-25 11:40:14 -04:00
92f8a06bee
Bug 1383773 - Fix race between browser and TPS initialization. r=markh
...
MozReview-Commit-ID: 7Ie1IzRzEbI
--HG--
extra : rebase_source : 0f113c56ea473273f889ebd0e2f6fc148cd2fe91
2017-07-24 11:10:32 -04:00
89e20571b9
Bug 1383835 - Increase the amount of time TPS waits after a tab sync before continuing r=markh
...
MozReview-Commit-ID: 1cvmtpkjSbX
--HG--
extra : rebase_source : 7b9c022082498c5c901534177ed3441669e05990
2017-07-24 14:01:03 -04:00
1e3bdd598f
Bug 1382913 - throw an error when a non existing observer is removed from observers.js. r=kitcambridge
...
MozReview-Commit-ID: AR2IPDH0Rpw
--HG--
extra : rebase_source : c533d5a5e086fc43c9c847297c3fba97ed9e25d7
2017-07-25 13:59:44 +10:00
23b85ab316
Bug 1337978 - Unify the multiple notions of 'weak upload' in sync. r=kitcambridge,markh
...
MozReview-Commit-ID: 5vTCAhUfMzm
--HG--
extra : rebase_source : fea6783352868e15481a751923aac2a166ad5506
2017-07-18 14:18:04 -04:00
9a475a45bf
Bug 1382044 - Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js. r=markh
...
MozReview-Commit-ID: 112UJWjF7R4
--HG--
extra : rebase_source : d398e93deb2d5bd7cc43d96eb37580552b8e2d72
2017-07-18 19:56:50 -04:00
8893010bae
Bug 1380835 - Don't check queries with `excludeQueries` for cycles in the bookmark validator. r=tcsc
...
MozReview-Commit-ID: DsPzrCxWWMG
--HG--
extra : rebase_source : 25281ab8f8d53901d960a738212361831b12fc55
2017-07-13 19:52:57 -07:00
8fc0f2d795
Bug 1377183 - Manually follow folder queries when validating bookmarks. r=tcsc
...
MozReview-Commit-ID: K3nl5GcilMz
--HG--
extra : rebase_source : 3704f00919170e12652e4d977c50604d6f94ce49
2017-07-05 17:00:50 -07:00
35f3666937
Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
...
MozReview-Commit-ID: EnhSBHMjurr
--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
764f64b2d5
Bug 1380094 - services/sync changes to support formautofill r=markh
...
MozReview-Commit-ID: BdsrrFOU5ec
--HG--
extra : rebase_source : b7bc64fd510c9db60c6788cda94a07b1a53d0594
2017-07-11 15:15:37 -04:00
314ef330a0
Bug 1210296 part 2 - Update tests. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 41dnyvdlNJv
--HG--
extra : rebase_source : 4c6e3cc63d4861d176ba053a1cff872c04f0f3b3
2017-06-05 18:49:43 -04:00
0943c36687
Bug 1210296 part 1 - Remove most event loop spinning from Sync. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 9RpgSgXykWt
--HG--
extra : rebase_source : 834df5b9b38a8332885a6c488f64215b550cad33
2017-06-05 18:50:07 -04:00
f4f4832d9e
Bug 1369539 - Sync UI startup performance improvements. r=florian,markh
...
MozReview-Commit-ID: 7ibJokJttLh
--HG--
extra : rebase_source : 7eac08de35da72744ce4b101d4f52229fe0e0688
2017-07-04 14:23:33 -04:00
f3484aa1b2
Backed out changeset dec7cb09336e (bug 1369539) for test_uistate.js failures a=backout
...
MozReview-Commit-ID: 4SBjyEI1v6q
2017-07-10 16:51:15 -07:00
98e6346e07
Bug 1369539 - Sync UI startup performance improvements. r=florian,markh
...
MozReview-Commit-ID: 7ibJokJttLh
--HG--
extra : rebase_source : 3b6790b0daa7b2e8eb96e4a4371a56ea964cc2e1
2017-07-04 14:23:33 -04:00
881bce09ea
Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
...
MozReview-Commit-ID: RT5QTipaOW
--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
2017-07-04 21:30:18 +05:30
0c16f513c9
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`. r=markh
...
MozReview-Commit-ID: FcysoHJtG60
--HG--
extra : rebase_source : 902460b486ef230c939608ee9bede93374069776
2017-07-05 13:49:48 -07:00
a4f06209c9
Bug 1378545 - Ensure `test_misreconciled_root` waits for the test server to start. r=markh
...
MozReview-Commit-ID: AyjdR5hfSOf
--HG--
extra : rebase_source : 9483f7f2d0c0437da1a3e97d9477ea8eae243843
2017-07-05 15:19:17 -07:00
03c81660b0
Bug 1377200 - Ensure Sync can recover after a profile refresh. r=markh
...
MozReview-Commit-ID: FeId4ANTNX9
--HG--
extra : rebase_source : 5c3f69ee524584617635375d9bc416fc57e9a67e
2017-07-04 15:03:43 -04:00
31ccf3dc94
Bug 1360872 - Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
2017-06-06 14:37:22 -07:00
663a825756
Bug 1366658 - Tweak engine registration process to better facilitate external engines. r=tcsc
...
MozReview-Commit-ID: GRKQEwkpbWc
--HG--
extra : rebase_source : b274e37f446f6c78ea3d07a97eeec0354d2dd257
2017-05-19 16:53:54 +10:00
da3259e8e2
Bug 1377578 - Fix TPS to keep it's addons and tabs tests passing r=markh.
...
MozReview-Commit-ID: LkFyMrD12Hk
--HG--
extra : rebase_source : f57309da133119955156bc1a8020a7674150e244
2017-06-30 15:15:24 -07:00
acb0601c26
Backed out changeset d7e7ced3622f (bug 1360872) for failing xpcshell's test_async_transactions.js | test_creating_and_removing_a_separator, at least on OS X. r=backout
2017-06-30 19:29:17 +02:00
c1537b7958
Bug 1360872 - Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 8b09ca049f0891cfc3a909f7b7d2807511586b48
2017-06-06 14:37:22 -07:00
2cfb02f19d
Backed out changeset c0fd6c0590be (bug 1360872) for unused parentId at toolkit/components/places/Bookmarks.jsm:461. r=backout
2017-06-30 00:16:35 +02:00
e80441db92
Bug 1360872 - Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : bea2d2589b2a09ba70a5c8e2b50ceee21acf3f0b
2017-06-06 14:37:22 -07:00
ca6826260e
Bug 1119282 - Fix the sync bookmark validator cycle detection to correctly get folder contents. r=kitcambridge
...
MozReview-Commit-ID: BjRD5wKbAoy
--HG--
extra : rebase_source : 9eb28f31351d4e5256e4aa6e3a87af6a9c934568
2017-06-29 10:49:10 -07:00
53c93f8449
Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
...
MozReview-Commit-ID: FD5npJlB24W
--HG--
extra : rebase_source : d30bac5044ecb8d86253e8bca3e8d47371fb9d1f
extra : source : 4f0ee0f75a307095e4a04afe4413e5bb6ea8e502
2017-06-21 15:26:10 -04:00
7e61aa8e97
Bug 1373093 - Add operating system information to the desktop Sync ping. r=tcsc
...
MozReview-Commit-ID: 9ypnosSawxu
--HG--
extra : rebase_source : 8a0192c70917c952431693c6864f96f7fd9b278e
2017-06-21 12:28:25 +10:00
728bae404f
Bug 1348727 - Write validation summary information to the sync logs r=tcsc
...
MozReview-Commit-ID: GRf0DeDhFqP
--HG--
extra : rebase_source : de2b49d55f4cbb4926475851deae298a16423ec9
2017-06-24 02:08:43 +09:00
c636da88e0
Backed out changeset 4f0ee0f75a30 (bug 1367813) for Windows opt permaorange in test_worker_basic.html
...
MozReview-Commit-ID: 2k693yFa28r
2017-06-22 20:43:11 -07:00
5cf8c34a94
Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
...
MozReview-Commit-ID: FD5npJlB24W
--HG--
extra : rebase_source : 049275836880f0aa4d19a9af2de9ec4101432b44
2017-06-21 15:26:10 -04:00
66f6d259bc
Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop.
2017-06-22 12:51:42 +02:00
3e60ae3dd8
Bug 1375133 - Remove unnecessary imports of btoa and atob in services/ code. r=markh
...
There are a few places in services/ tests that import btoa and atob,
but this is not necessary, because those are both defined on the
XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds
like it didn't work at some point on B2G (see bug 937114) but that
isn't relevant any more. I want to fix this because the way these
properties are imported will break with shared JSM globals.
MozReview-Commit-ID: HoxqIS98p7B
--HG--
extra : rebase_source : 7800baee8ebc5e3ab3f52a62e30e5cde8d19876b
2017-06-21 09:56:57 -07:00
ac0fd2038c
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: 3LXFVwSoMvs
2017-06-21 17:58:17 -07:00
b28fcc5c4b
Bug 1372670 - part 5 - add nsIThreadManager::spinEventLoopUntilEmpty; r=erahm,florian
...
A number of places in JS need to drain the current thread's event queue,
which cannot be done with nsIThreadManager::spinEventLoopUntil, since we
need to not wait for an incoming event when attempting to process one.
2017-06-21 12:59:28 -04:00
27c58cf89f
Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian
2017-06-21 12:59:28 -04:00
a1b09f054d
Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges. r=standard8
...
MozReview-Commit-ID: Ihun5yu3hit
--HG--
extra : rebase_source : 9448411e072d144456e7672b92699cdf288a13fc
2017-06-21 14:53:07 +10:00
c0e1236f1a
Merge autoland to m-c a=merge
...
MozReview-Commit-ID: LFtpTAueYrF
2017-06-20 18:24:29 -07:00
10ee6a5c4e
Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
...
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.
MozReview-Commit-ID: 1buqgX1EP4P
--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
a208081e56
Bug 1357798 - Ensure URLs don't end up in sync error telemetry. r=markh
...
MozReview-Commit-ID: AxFzysv0ks3
--HG--
extra : rebase_source : 6b2aa9354ed9540c5cdb8f537eaca7080c97a4eb
2017-06-12 13:38:39 -04:00
c3972efec6
Bug 1368393 - Handle already synced commands in clients collection duplicate checking r=eoger,markh
...
MozReview-Commit-ID: Hs0Jh8mMlOp
--HG--
extra : rebase_source : 8a8bae7330210547d128c322abed773cb73895e5
2017-06-09 12:07:43 -04:00
b599411285
Bug 1369119 - Refresh known stale devices list on FxA device disconnect. r=markh
...
MozReview-Commit-ID: A2iqas0kP20
--HG--
extra : rebase_source : 15db886e4751885e173a55c561df7ea1a3b2871b
2017-06-06 14:28:00 -04:00
d030707609
Bug 1095426 - Convert JSON backups code to the new async Bookmarks.jsm API. r=mak
...
MozReview-Commit-ID: FNZZGwWVSI2
--HG--
extra : rebase_source : dacb3c5ddb439d074c66e0baaa7e73044c5dcd46
2017-05-12 08:04:51 +01:00
3231cb3535
Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
...
MozReview-Commit-ID: GliLHLsUWjt
--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
2017-06-17 19:30:09 +09:00
a1f2f47f82
Bug 1363412 - Notify other clients when uploading the local clients record for the first time. r=markh
...
MozReview-Commit-ID: Ldc3Jrj8RhV
--HG--
extra : rebase_source : 44bdeaa962ddbcb748f9e5a01871fd2ff7d6a676
2017-06-12 14:51:17 -04:00
1826fefb4c
Bug 1370985 - Change getBatched() to return records directly instead of using a callback. r=markh,tcsc
...
MozReview-Commit-ID: HfwPe8jSH66
--HG--
extra : rebase_source : 12c8800f1fcc090589c2a94a0fc1608b36c54181
2017-05-30 13:23:57 -04:00
120e57745f
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2017-06-12 13:48:15 +01:00
adde19d4f4
Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
...
MozReview-Commit-ID: FPB4HebP3g7
--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
96faa14e58
Bug 1370736 - reset the sync login status after an FxA login event. r=eoger
...
MozReview-Commit-ID: 6BLj6q8z79i
--HG--
extra : rebase_source : 350bc8d6c6e5581082c9b1a50b3517b93d70db52
2017-06-07 16:41:18 +10:00
1fdf6c19a7
Bug 1356281 - Remove bookmark contents from sync debug logs. r=tcsc
...
MozReview-Commit-ID: HsMH5mpCK8C
--HG--
extra : rebase_source : 26853fa867257a6c0a914ed903f9d8e253c86e8f
2017-05-19 04:40:15 -03:00
19362d0bfa
Bug 1354016 - Forms validator ignore clientMissing. r=tcsc
...
MozReview-Commit-ID: C2FD58C9HzS
--HG--
extra : rebase_source : f5b627342e7fa4915914cbfd3e54003fe6d94c1e
2017-06-01 22:32:23 -03:00
dc01c77702
Bug 1369285 - update how we build the default sync device name. r=tcsc
...
MozReview-Commit-ID: 6eY8IzKg9kd
--HG--
extra : rebase_source : ae321d48de0144c29fa4f40fd16a02c44539d795
2017-06-01 16:57:02 +10:00
9d1dc7c4a7
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 00f77b7a24a509d5e9fabb8ee7793a59b38f639f
2017-05-29 13:24:01 -04:00
2c61cf7eb4
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
0c6026b415
Bug 1369092 - Listen to onverified events in UIState. r=markh
...
MozReview-Commit-ID: 8nfmpaz9obF
--HG--
extra : rebase_source : 736673d0c1245b81ea9f419f08b943c3ce26a8e6
2017-05-31 12:02:28 -04:00
9768267be1
Backed out changeset bf392a1d0c5a (bug 1368560) for failing xpcshell's test_ext_storage_sync.js and test_ext_storage_sync_crypto.js on Linux. r=backout on a CLOSED TREE
2017-05-31 22:53:16 +02:00
a9f8675d96
Backed out changeset c2d00a8b897b (bug 1368560)
2017-05-31 22:52:14 +02:00
275b48a53e
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 29833856a9cca178a2b508b6401cdb6bd8ca1bb9
2017-05-29 13:24:01 -04:00
198e8ab1d1
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
71a24b858a
Bug 1366994 - prevent appDisabled addons from hanging sync. r=tcsc
...
MozReview-Commit-ID: 4RRCPlwUZrG
--HG--
extra : rebase_source : 8ab03af402dc15432252b74a120da286b810302f
2017-05-26 12:42:10 +10:00
7386600327
Bug 1366081 - Excise 'mobileGUIDFetchBatchSize' and other mobile sync-related constants. r=kitcambridge
...
MozReview-Commit-ID: 6JTtpWFFyvD
--HG--
extra : rebase_source : f6ca75e91ca38d0d1ba18ff79a0872d96a878954
2017-05-24 03:28:22 -03:00
fc8d285e3d
Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak
...
This includes 2 things:
1. Replacing the parts which test the logs for the presence of prefixes by testing
the returned map for `suceeded`.
2. We don't need to wait to observe the topic anymore, we can simply await methods
from `PlacesDBUtils` to know when they are done.
MozReview-Commit-ID: Ct9l9pzUW5x
--HG--
extra : rebase_source : 657e4ac53f8b3785740a5b732d483fad9600f73d
2017-05-24 11:00:47 +05:30
85291791fd
Bug 1367585 - Add the 'load' event listener before adding the new tab in sync's TPS tests r=markh
...
MozReview-Commit-ID: HUUHYnLf4m8
--HG--
extra : rebase_source : f0ac2cadf4f5345f854e8ad8ca3e7be37485a0cf
2017-05-24 17:58:55 -04:00
1e07d66113
Bug 1367543 - Make sync's TPS tests handle cases where resyncs are triggered r=kitcambridge
...
MozReview-Commit-ID: 4owlGyLw5jU
--HG--
extra : rebase_source : bdfca8806ed76c2398c845880f4b7c65bd3dffd3
2017-05-24 16:16:23 -04:00
99947c9c38
Bug 1353307 - Add main process start time to sync ping. r=gfritzsche,markh
...
MozReview-Commit-ID: DbSZUmO0tuf
--HG--
extra : rebase_source : e13afbd5829b86b7bee5c82a7a1ff09263e9dc3f
2017-05-16 17:43:49 -04:00
df2d03a198
Bug 973166 - Only track passwords with changes to synced fields. r=eoger
...
MozReview-Commit-ID: 8ZOyVCaZIi8
--HG--
extra : rebase_source : 8252c5a9ad718594872d5bda38e04528cd227f44
2017-05-22 17:21:20 -07:00
d2833635e1
Bug 1352233 - Try to preserve synced folder child order in case of conflicts. r=tcsc
...
For folders, we resolve conflicts by taking the chronologically newer
list, then appending any missing items from the older list. This
preserves the order of those missing items relative to each other, but
not relative to those appearing in the newer list.
MozReview-Commit-ID: 6rimXpV7vLg
--HG--
extra : rebase_source : 10cda7f529cec3f71d9d45d253285d35788cb0b5
2017-04-28 14:08:11 -07:00
7d0f361ba0
Bug 1356282 - Change Sync's Utils.arraySub to be O(n) using Set. r=tcsc
...
Sync's Utils.arrayUnion and Utils.arraySub are O(n^2) because Utils.arraySub uses indexOf inside a loop. This patch makes Utils.arraySub use a Set, and by doing so, Utils.arrayUnion and Utils.arraySub become O(n).
MozReview-Commit-ID: DDqjRWalfP9
--HG--
extra : rebase_source : ec90092244e16d3651f0d69ea8db1944301c13fb
2017-05-05 03:16:30 -03:00
274ba1a154
Merge inbound to central, a=merge
...
MozReview-Commit-ID: AFMOzsYBEjc
2017-05-15 16:22:21 -07:00
fab6e7f663
Bug 1362510 - Remove errors.properties and references. r=eoger
...
MozReview-Commit-ID: 27kIRQdEHsE
2017-05-15 12:03:55 -04:00
45fdbb5730
Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger
...
MozReview-Commit-ID: AciCTECtXJc
--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
2017-05-12 20:54:54 -03:00
3d2e65ee7e
Bug 1364571 - Delay Weave startup. r=kitcambridge
...
MozReview-Commit-ID: 4bm1LXLD7lV
--HG--
extra : rebase_source : c1b14b70e4d952870800387f16c7fecab9667b49
2017-05-12 17:01:25 -04:00
d6d727a69e
backout of f9abb9c83452 (bug 1319111) for crashes, r=bz
2017-05-13 13:55:11 +02:00
0a1e1fe23b
Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
...
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
70f62bdec1
backout of f9abb9c83452 (bug 1319111) for crashes, r=bz
2017-05-12 22:13:49 +02:00
4e937e42a2
Bug 1353542 - Cleanup the script output and fix tests, r=Mossop.
2017-05-12 14:54:05 +02:00
65e959c068
Bug 1357814 - Changes to sync's TPS tests to allow running from automation r=markh
...
1. Ensure we wait for browser-delayed-startup-finished
2. Parse the profile we're cleaning up from the cleanup phase name instead of
using the selectedProfile.
3. Ensure that bookmark repair doesn't run randomly (this isn't necessary, but
the repair code can make the actual reason for failure much more difficult to
debug, and could probably cause a test to pass when it should not).
4. Add multiprocessCompatible flags so that TPS can still start in nightly (and
because it is).
MozReview-Commit-ID: 98UvRoFOdzv
--HG--
extra : rebase_source : ff1f199eafdcc569cfdf9cb373ee4d059b37ec35
2017-05-05 14:54:03 -04:00
103b72ff2f
Bug 1335891 - Ensure and test that Sync changes don't bump the score. r=markh
...
MozReview-Commit-ID: 4dP5oZS3pm
--HG--
extra : rebase_source : ebada671d4aa5feba290f118e370fd7def093c4a
2017-05-09 13:04:50 -07:00
2401fa0477
Bug 1335891 - Trigger another sync if tracked items have changed during the last sync. r=markh
...
MozReview-Commit-ID: 7EcIX7QrsN4
--HG--
extra : rebase_source : 41f0886f5e40b9b8aaaebc5ebaa40a247bba13ef
2017-05-10 19:21:16 -07:00
cd1cbcef0f
Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
...
MozReview-Commit-ID: 4nYlX4sSdbF
--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
fdc689ba16
merge mozilla-inbound to mozilla-central a=merge
2017-05-05 15:17:26 +02:00
a1b64b4694
Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz
2017-01-27 19:10:01 +01:00
b3b3ff9cc5
Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
...
MozReview-Commit-ID: K790Ag8WZgv
--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
1df337c9ce
Bug 1361572 - Remove Task.jsm/Promise.jsm from services/. r=kitcambridge
...
MozReview-Commit-ID: BBIkpIkWIYc
--HG--
extra : rebase_source : a0f10b07bad20789e2d1c2c2bca133b32bf671aa
2017-05-02 19:29:33 -04:00
18253e3fa2
Backed out changeset 0a0138825fb5 (bug 1353571)
...
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
c11e66021d
Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
...
MozReview-Commit-ID: K790Ag8WZgv
--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
b80261a3ec
Bug 1358648 part 3 - Remove Async, Services and XPCOMUtils from util.js. r=markh
...
MozReview-Commit-ID: 8na204K9cXp
--HG--
extra : rebase_source : 96e7738aa6612cf67543d50053f50c2bccf1ab7e
2017-05-02 16:57:37 -04:00
abba8c5b31
Bug 1358648 part 2 - Remove util.js Svc.{DefaultPrefs,Session,Idle, FormHistory} and Str. r=markh
...
MozReview-Commit-ID: Jc1th8Snvhv
--HG--
extra : rebase_source : dd950a5d7bb0f2cb2ea4f32c7b61eb2a15ae327d
2017-05-02 18:30:23 -04:00
712abbc07a
Bug 1358648 part 1 - Clean-up some Weave imports. r=markh
...
MozReview-Commit-ID: 2NK4Mew65UT
--HG--
extra : rebase_source : f515a4c26f2ac515c67d37f4cf01f79427b38221
2017-05-02 18:27:49 -04:00
f2a6a685fe
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 8e4c319c7fb8b727ac0193e5dd78411e1ec2785c
2017-04-27 17:24:18 +01:00
8cb9279791
Backed out changeset e6177d883f37 (bug 1359540) for eslint failures
2017-05-02 09:25:45 +02:00
0c2aa823c9
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 3d8d878810c60dc339e196eaac0215f9f72cc829
2017-04-27 17:24:18 +01:00
dcce7ae769
Bug 1348699 - Add test to ensure we don't track left pane queries. r=mak,markh
...
MozReview-Commit-ID: LFoCpvz2rAn
--HG--
extra : rebase_source : c2e927100899b5856d0fc2350efdf0e1ffb52e77
2017-03-20 19:22:15 -07:00
5b32e800fa
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc
...
MozReview-Commit-ID: 3D1xwv9k76m
--HG--
extra : rebase_source : a27836cea6100fd90e15ed95b08c9f02e6c79605
2017-03-30 18:01:19 -07:00
20f27ffe75
Bug 1361818 - Make sure TPS is aware sync's collection.get method is asynchronous now r=markh
...
Ideally we'd convert this to promises, but this function is already full of
promiseSpinningly's and removing them all is too much work for this bug.
MozReview-Commit-ID: 144JFRwejTb
--HG--
extra : rebase_source : 40371c6cfeee9fddffe4b737cbb98fecb424b719
2017-05-03 15:12:30 -04:00
4b1556a5f2
Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws.
2017-04-27 00:25:45 +02:00
29c680ad80
Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic). r=markh
...
This fixes various errors raised in services for the rules: key-spacing, quotes, no-else-return, no-extra-semi, comma-spacing, object-shorthand.
MozReview-Commit-ID: IClwG5rfXfW
--HG--
extra : rebase_source : 81c059dacfc39b5cf8bc85b9b746dcdd494a3629
2017-04-24 18:52:57 +01:00
00431016d0
Bug 1355677 - Make all Sync network requests promise based. r=kitcambridge,rnewman,tcsc
...
MozReview-Commit-ID: JSwAS4Xd1uy
--HG--
extra : rebase_source : 95724c3b59576d40cafd2f380ff42acb4fc3d553
2017-04-11 23:40:53 +10:00
8b9281c90a
Bug 1350135 - Fix failing TPS test_history_collision.js test r=markh
...
There were three issues here: The first is that the TPS's history module didn't
wait for PlacesUtils.history.remove's promise to resolve.
The second is that the SYNC_WIPE_REMOTE in the previous client would cause a
write to the clients collection, which would cause the next client to get a
"sync:collection_changed" push. This caused a sync of *only* the clients
collection upon reciept, which would prevent TPS from explicitly syncing all
engines.
The third is that TPS wasn't correctly handling the cases where logIn would
trigger a sync, which would cause a failure during the first sync of a session.
This would cause failures on other TPS tests as well.
MozReview-Commit-ID: LpqZ7Kt9fyy
--HG--
extra : rebase_source : f1d3c40e2ef4e09cce4d2ce8ae25f2c86ddfee45
2017-04-19 14:38:00 -04:00
0bb64306d4
Bug 1346175 - Record AsyncResource.serverTime in sync telemetry events. r=bsmedberg,markh
...
MozReview-Commit-ID: DG43B9zEHaO
--HG--
extra : rebase_source : 9b16fe1dff50574036fb2e10224d8056fe415ecd
2017-04-04 13:51:16 -04:00
12dcd10d01
Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
...
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.
This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.
MozReview-Commit-ID: 3MTKhGj3ehj
--HG--
extra : rebase_source : 55120252e7ea8abb91f21ca2486deddc43795142
2017-04-14 20:34:27 +02:00
16969b40e2
Backed out changeset eb94759f0fcf (bug 1356567) for test failures in own test
2017-04-18 12:58:09 +02:00
5238755b71
Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
...
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.
This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.
MozReview-Commit-ID: 3MTKhGj3ehj
--HG--
extra : rebase_source : e36ba1ab41649927f92fee053c10bf43474a0bcf
2017-04-14 20:34:27 +02:00
c05723ef0c
Bug 986501 - Avoid unnecessary compartments on Sync startup r=markh
...
MozReview-Commit-ID: 8Rr3JD4dfVy
--HG--
extra : rebase_source : b18f24229bbd1caf80d9f175a79c1fdb0aeccd0d
2017-04-13 20:36:08 -03:00
c8bcf1e705
Bug 1351915 - Fire onItemChanged when deduping sync bookmarks. r=kitcambridge
...
MozReview-Commit-ID: JHaCz42aRwx
--HG--
extra : rebase_source : 38361447a7900c55dc56cc5b528be5045181fee2
2017-04-08 19:57:39 -04:00
4c6a68d1c9
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
159215e6f4
Backed out changeset 18d45aa984d6 (bug 1355161)
2017-04-14 23:39:23 +02:00
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
a363fb8c8b
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
daf505ef20
Bug 595314 - Add TPS test ensuring that new changes to existing bookmarks are respected by sync r=markh
...
MozReview-Commit-ID: B2A60B3ufYb
--HG--
extra : rebase_source : bc30afdc09497f9bcdda85493f02faa8fe8afb17
2017-04-05 12:39:00 -04:00
3c9fc16ebc
Bug 1345744 - Ensure an error log is written when sync (newly) fails to apply records. r=markh
...
MozReview-Commit-ID: 586faUBtX6n
--HG--
extra : rebase_source : 7e1d0eab656838f3718260a11ef8cd2d9b501d17
2017-04-04 14:18:09 -04:00
ea83c7b70d
Bug 1351906 - Moved log.trace before return statement to fix unreachable code issue in history.js. r=Standard8
2017-04-05 11:03:01 +05:30
557fa7b36a
Bug 1350665 - Disable sync repair tests on beta and release. r=kitcambridge
...
MozReview-Commit-ID: 6anD2FJ2aQ2
--HG--
extra : rebase_source : 708b1c52d0ecbad5407d3d27db0c5d14c8bfa73e
2017-03-29 15:27:25 -04:00
f189ba9211
Bug 1349703 - (part 3) Delete a test from TPS that was testing that we made the wrong decision during reconciliation r=kitcambridge
...
MozReview-Commit-ID: KVRcVNJAKfg
--HG--
extra : rebase_source : c37b394f0a97488f783db0b751ea2f5f9c454f8d
2017-03-23 17:18:32 -04:00
250adc135f
Bug 1349703 - (part 2) Fix intermittent TPS failures caused by failing cleanup by waiting longer before starting r=kitcambridge
...
MozReview-Commit-ID: D07eRgqHVOu
--HG--
extra : rebase_source : e08a57c3340cfd22bde9009c8cc960859b719eed
2017-03-23 16:34:04 -04:00
908a695b92
Bug 1349703 - (part 1) Fix issue where sync would fail misreconcile special folders in fresh syncs r=kitcambridge
...
MozReview-Commit-ID: Izy9JgMYpom
--HG--
extra : rebase_source : b740e81aafbabae2947fd26888c677065742db96
2017-03-23 16:32:40 -04:00
2f0a83abc1
Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
...
MozReview-Commit-ID: 9Wxq2wfUnkb
--HG--
extra : rebase_source : 133133eb765a403a77ca3bbd0d8302c0a0be49a0
2017-03-24 11:12:48 -04:00
7ebbcc1624
Backed out changeset 16d562074791 (bug 1339340) for failing xpcshell test services/sync/tests/unit/test_doctor.js. r=backout
2017-03-24 00:52:29 +01:00
125d3015c3
Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
...
MozReview-Commit-ID: 9Wxq2wfUnkb
--HG--
extra : rebase_source : 8dfe36e5c2d75291e07d61341648dec95b5dd213
2017-03-14 18:02:20 -04:00
55c8025ae4
Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc
...
This was a regression from bug 1317223. This commit also adds a
password engine sync test to catch future regressions.
MozReview-Commit-ID: 9dq8K39jLwB
--HG--
extra : rebase_source : 346c4abaf639f7781426f4e06e988c76cf552422
2017-03-22 19:21:08 -07:00
d20541b101
Bug 692700 part 2 - Set X-If-Unmodified-Since when uploading crypto/keys. r=markh
...
MozReview-Commit-ID: 9qrr8vuvy1I
--HG--
extra : rebase_source : 9c20bdec7a33d0cde2e31c3109bf3cb9665352ba
2017-03-14 15:56:08 -04:00
1ee65dc313
Bug 692700 part 1 - Set X-If-Unmodified-Since when uploading meta/global. r=markh
...
MozReview-Commit-ID: IoiThiDlvCj
--HG--
extra : rebase_source : f78434e661810f9b42da6d58422713fd20687e28
2017-03-14 14:42:24 -04:00
3d91da8726
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
0a04f3b9e2
Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout
2017-03-22 18:20:26 +01:00
c2cd68a689
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
c4565c993a
Bug 1343093 - Add integration test for bookmark repair. r=markh
...
This test replaces the clients engine to simulate two different
clients, and uses `SOURCE_SYNC` to bypass change tracking.
MozReview-Commit-ID: IF3b3WZtain
--HG--
extra : rebase_source : deff5eb74dcbc29d7e7556b4ce6e15590ee4d4a0
2017-03-21 11:54:06 -07:00
bd625e4e9f
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
...
MozReview-Commit-ID: LH0CQOPfoe6
--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
f38275a306
Bug 1339163 - Make TPS tests attempt to automatically verify fxa emails when using a restmail account r=markh
...
MozReview-Commit-ID: LwBrVSXFqyc
--HG--
extra : rebase_source : c09b6afe7ea3827760618d7fa6421bf36bc601bf
2017-03-17 16:41:58 -04:00
130ff3a299
Bug 1345754 - Skip sync bookmark repair and validation if we have pending changes r=markh
...
MozReview-Commit-ID: ClQRXGZGV9p
--HG--
extra : rebase_source : 4ae8ead7a9121dc383fcfc5ebf757f44e46f5679
2017-03-14 14:26:20 -04:00
6fd1303c2a
merge mozilla-inbound to mozilla-central a=merge
2017-03-21 12:04:43 +01:00
Margareta Eliza Balazs
Edouard Oger
Mark Hammond
Thom Chiovoloni
Mark Banner
Cosmin Sabou
Dan Banner
Kit Cambridge
Doug Thayer
Ryan VanderMeulen
Geoff Brown
Sebastian Hengst
Nicholas Nethercote
Andrea Marchesini
tfe
Manish Kumar
Luciano I
NARCIS BELEUZU
Valentin Gosu
Kevin Pellet (Ilphrin)
Robert Helmer
Phil Ringnalda
ffxbld
Kris Maglione
Andrew McCreight
Wes Kocher
Josh Aas
Steve Armand
Nicolas Ouellet-Payeur
Luciano Italiani
Leni Kadali
Carsten "Tomcat" Book
dagasatvik
Masatoshi Kimura
Rajesh Kathiriya
tiago
Marco Castelluccio
Rob Cutmore
Benjamin Smedberg
Jeongkyu Kim
Florian Quèze
Nathan Froyd
Paolo Amadini
milindl
jomer14
Honza Bambas
Frederik Braun
Marco Bonardo
hrishikesh
Zibi Braniecki