40a16fc16b
Fix miscellaneous editor leaks. r=jfrancis@netscape.com
2000-03-23 01:14:49 +00:00
dc59bf9530
Fix leak by giving base class a virtual destructor (and counting the constructor). r=jfrancis@netscape.com
2000-03-23 01:13:38 +00:00
880a4f2081
r=jfrancis. small change to stop the editor from scrolling window when it DOESNT handle a key event
2000-03-22 01:30:16 +00:00
901944bd23
Finished implementation of menu-driven table selection. Implemented detection of row or column selection. r=mjudge
2000-03-21 06:05:24 +00:00
4038b1da98
30311: add a plain-vs-html flag to InsertAsCitedQuotation. r=rhp
2000-03-20 23:13:25 +00:00
55efbe2103
Remove a printf
2000-03-18 02:05:22 +00:00
912ca59eba
Warning fix -- remove unused variable
2000-03-17 02:10:55 +00:00
118b8c5669
Table row, column, all-cells selection now working. Menu items enabled. r=mjudge
2000-03-17 01:46:17 +00:00
235ce19d67
Removed tableselection listener -- all selection now done in layout. Also added more table selection support for row, col from menu. r=mjudge
2000-03-16 23:45:41 +00:00
8f13e2f0b2
25645, fix delete line and kill to end
2000-03-14 02:58:14 +00:00
739e5055f3
Fix paste as quotation
2000-03-14 02:57:38 +00:00
6ea7fbcc1c
fix crashing bug 30120. check in for tajima@eng.sun.com since the crash is
...
verified and test on my machine. r=ftang, a=bobj. Will check into the beta
branch also.
2000-03-13 02:33:19 +00:00
fb3041279a
replaced calls to deprecated string methods
2000-03-12 20:39:41 +00:00
194f10b94d
landing phase 2 to remove deprecated string calls
2000-03-12 11:10:07 +00:00
ffe78e83e5
removed calls to deprecated string methods
2000-03-12 09:14:14 +00:00
3ecba57c7d
Fix for 17419. a=bobj@netscape.com, r=ftang@netscape.com
2000-03-10 01:30:07 +00:00
a6d97b2321
fix spelling of hander to handler. bug #29407 . r=sspitzer
2000-02-27 20:51:11 +00:00
7cb570ad1b
fix for #28911 , r=alecf, a=jar. avoid loading in unnecessary dlls at startup.
2000-02-26 03:52:06 +00:00
e6db193491
fixe for 23558: windows ime bug - typing escape in ime can cause selection to move to top of document
r=mjudge, ftang; a=rickg
2000-02-25 23:50:17 +00:00
1018c411e5
28279: Joe checked in most of the changes to fix quoting, and this
...
is the rest to remove some extra blank lines. r=jfrancis, a=rickg.
2000-02-25 23:26:46 +00:00
6d57ee0984
fixes for the following bugs:
27914, 27305, 28690, 14608, 27306, 28757
These fixes reviewed by cmanske, apprvd rickg;
also fix for 28724 (caret positioning problems)
reviewed by mjudge, apprvd by jar.
2000-02-25 04:39:30 +00:00
df86826711
a=jar r=sfrasier,jfrancis,akkana bug for editor find not working
2000-02-23 05:07:42 +00:00
4a62deb1e7
27908: Fix multiple keyboard pastes by disabling ProcessShortCutKeys (finally!) r=brade, a=jar
2000-02-18 21:32:26 +00:00
d966e1ef2c
fix for:
26624 - lists and inline style dont get along
r=sfraser; a=rickg
2000-02-18 01:10:21 +00:00
8f20e69369
fixes for:
27959 - delete broken in editor
24694 - cant get out of link insertion
r=sfraser; a=phil
2000-02-17 19:40:18 +00:00
56fb0c4bb2
clean up -help output. fix bug #26959 , make it so when you start
...
a browser window, the right page (home, blank or last page visted) gets
loaded. clean up tasksOverlay.js, navigator.js and Ensure1Window()
use the browser's command line handler (remove duplicate code).
remove uri dispatching ui and js. r=mscott
2000-02-16 06:22:03 +00:00
b50f24a71b
move the nsICmdLineHandler responsibilties from nsHTMLEditorLog to nsEditorService. r=sfraser
2000-02-16 03:14:20 +00:00
7a79937c2f
Fix build bustage -- case sensitivity error, apparently
2000-02-16 02:36:27 +00:00
901a6ea5f1
not part of the build, yet.
2000-02-16 02:21:30 +00:00
447ae26d32
24694: Create the bogus node after newly inserted non-text nodes. r=sfraser.
2000-02-16 02:11:39 +00:00
57de6e6cd7
Give the controller an Init method, and implement a bunch of commands the New Way. for bug 18395. r=pinkerton
2000-02-16 01:37:12 +00:00
096edb7034
Expose the transaction manager to outside, for bug 18395. r=akkana
2000-02-16 01:36:30 +00:00
6d1f8c6acb
First Checked In.
2000-02-16 01:33:03 +00:00
7a0f4cf2e1
fix for 27699: ime text insert screwed up for single line edit fields
2000-02-16 00:53:31 +00:00
770a137b12
Added Page Properties (26889) and Page Colors dialogs (14344), removed debug menu only in release (27237), link dialog fixes (27308), lots of dialog rewrite to use titledbox instead of fieldset, rewrote insert table dialog to use boxes. Changed font size to use CSS strings, not <font size> for ui, but other bugs prevented inserting spans for size. Other small bug fixes. r=brade.
2000-02-15 15:54:05 +00:00
189ce7fb0c
fix for 17994: indent skips down a line
2000-02-13 13:06:21 +00:00
6939f0a6dd
fix for 27188: crash when making text bold
2000-02-13 12:52:15 +00:00
db4cd55837
27144: make sure the editor bogus node starts with _moz, and strip it out in html output. r=smfr
2000-02-12 01:58:40 +00:00
afecaab477
Table editing work (bug 20973). Fixed background colorpicker (bug 21410), disable unimplemented menu items (25137), make property bundle strings more localizable (26050). r=mjudge
2000-02-10 05:14:52 +00:00
b32999a1de
big checkin. fixing problems blocking Cmanske (also a reviewer). Checking in preliminary for gen content.(nothing damaged yet) lots of bug numbers not going to look them up, the tree just opened.
2000-02-10 04:35:51 +00:00
cd6f5d237b
Prevent synchronous paints during reflows bug 20150; r=rods@netscape.com
...
Call SetTextAlign within SetupDC instead of in each DrawString on WIN32. bug 26973; r=rods@netscape.com
2000-02-09 15:48:01 +00:00
c9505c0fa5
implementing font increase/decrease size for html editor (bug 18774) r=floppy moose
2000-02-08 12:53:34 +00:00
72e8a9e317
make it so -chrome <chrome url> does the right thing.
...
r=mscott
2000-02-08 03:12:39 +00:00
9431eb3736
more changes to get everyone using my arbitrary command line handling.
...
removing "calendar" from the appearance pref panel, there is no calendar in
5.0.
r=mscott
2000-02-08 01:11:13 +00:00
28fd752530
fix for 24051: modifying password field corrupts pw text; checked in on behalf of buster; r=jfrancis
2000-02-07 02:48:36 +00:00
ebc0651bbf
fix for 25452 (plain text widgets break IME escape key). checked in on behalf of katakai@japan.sun.com; r=jfrancis
Thanks Katakai!
2000-02-07 01:42:14 +00:00
784eafea80
22505 workaround: force plaintext editors to use font-family: monospace to make wrapping work. r=jfrancis
2000-02-04 23:39:31 +00:00
5816b366ff
fixing warning; r=akkana
2000-02-03 23:29:09 +00:00
ac019d7deb
fix for 26299 - editor now uses reflow batching. Long live refow batching!
r=kin
2000-02-03 23:17:08 +00:00
3ba836df7b
25251: use white-space: -moz-pre-wrap instead of pre wrap, suggested by pierre, r=buster
2000-02-03 23:17:00 +00:00
894a83b297
More table editing work (bug 20973) and Page Properies dialog work (bug 14344). Added missing 'tbody' to nsIAtoms list. r=mjudge
2000-02-03 02:06:10 +00:00
395f325b0c
more inline style feedback fixes (24574). r=sfraser
2000-02-02 22:47:43 +00:00
276c400561
Fix for bug #26100 (Spellchecker goes into infinite loop.)
...
- Modified DeleteNode() to increment nodeIndex to prevent
an infinite while loop.
- nsIContentIterator::Next() and Prev() now return NS_OK
if you iterate past the end of the list. Modified all
calls to Next() and Prev() so we can catch any errors.
r=jfrancis@netscape.com
2000-02-02 14:14:32 +00:00
ff5704575e
native clipboard/d&d impls now handle text/plain internally, always providing text/unicode to a client. fixes bugs 8427 and 24010. r=scc.
2000-02-01 22:26:21 +00:00
48e640ed4f
Conversion to NS_GET_IID(). Bug #20232 , r=scc@netscape.com
2000-02-01 14:26:27 +00:00
a3ce5e7f22
fixed bug 25767
...
r=beard
2000-02-01 05:12:25 +00:00
f91098d0f6
make selection sticky across undo/redo (24573);
get bold/italic/underline toolbar feedback working (24574);
fix for 24856: unable to unbold text;
fix for 24572: cant get selection between split lists
2000-01-31 10:30:12 +00:00
5e2f88b7f8
22662: Completely redesign the editor output formatting system.
...
Now, instead of inserting text nodes containing whitespace and newlines
into the content tree, the editor adds a fake attribute "_moz_dirty"
to every node it creates, and relies upon the output system to format
any node with that attribute (and, of course, not output the attribute).
r=jfrancis
2000-01-28 01:17:23 +00:00
0044578da8
Insert/update META charset tag for charset menu operation, bug 17797, r=akkana.
2000-01-27 03:35:44 +00:00
267857ff5c
Fix for bug #6544 : Cannot search on XML page
...
Modified all body methods to deal with the body node for HTML documents,
and the document root node for all other types of documents. Renamed
all body methods.
r=sfraser@netscape.com
2000-01-26 21:55:51 +00:00
4104f66aa7
Fixing build bustage, added missing .get() in a nsCOMPtr comparison. r=vidur@netscape.com
2000-01-26 16:01:49 +00:00
1a85d5b775
Table editing (bug 20973): added support for rowspan/colspan=0, Rewrote Spelling Dictionary dialog (bug 24264), removed beep from forceInteger filter, r=akkana
2000-01-26 14:57:43 +00:00
bb4e29cc50
Turn off debug printf and enable formatting. Still r=jfrancis
2000-01-26 02:31:30 +00:00
a3dbe39403
22662, 16720: greatly improve formatting of html source for inserted html tags. r=jfrancis
2000-01-26 00:57:37 +00:00
7b5b06b014
Utilities for use by editor and edit rules. r=jfrancis
2000-01-26 00:36:18 +00:00
ee76e82f41
Forgot to remove bogus NS_NOTREACHED line in IsMozEditorBogusNode().
2000-01-18 23:52:23 +00:00
9ef6758595
Fix for bug #24253 : [REGRESSION] Redo adds newlines instead of redoing.
...
mozilla/editor/base/nsEditor.cpp
mozilla/editor/base/nsEditor.h
- Added IsMozEditorBogusNode() method.
mozilla/editor/base/nsTextEditRules.cpp
- Modified CreateBogusNodeIfNeeded() to check if bodyChild is a
MozEditorBogusNode so that it doesn't create more than one.
- Modified DidUndo() and DidRedo() to use IsMozEditorBogusNode().
r=sfraser@netscape.com
2000-01-18 23:45:35 +00:00
a37b31dc09
WIP for 18395, various editor command handling and updating changes. r=akkana
2000-01-18 21:50:15 +00:00
d0f1bda271
removed hard-coded white background now that background colors work for lazily-instantiated
...
text controls.
completes the fix for bug 9074
r=rods
2000-01-18 01:51:36 +00:00
c8e28aa7ac
fix for 21412 - backspace wouldn't remove list items in html editor.
In addition some improvements were made to the adjustment of selection after an edit action (example: backspacing through a list item now pops you up to the previous item)
2000-01-17 12:41:34 +00:00
462fd8aa29
fixed 24114 - password fields showing the real text
2000-01-17 10:24:25 +00:00
634a777322
* fixed 19596;
* fixed 23597;
* fixed deletion bug that could cause to breaks to be deleted instead of one, when backspacing once. (no #)
* partial fix for current paragraph style not being properly reported in the composer toolbar. (no #)
2000-01-15 14:29:29 +00:00
035bf4f17e
small fix for bug23833 r= jfrancis
2000-01-13 23:56:34 +00:00
3f215a5e83
We now cut the correct number of characters from the styleValue string.
...
Fixed bug that prevented us from removing properties starting at the
zeroth position in the string.
r=sfraser@netscape.com
2000-01-13 23:50:28 +00:00
e70eaf046f
Table editing work and fixed bug 21389, r=buster. Added detecting table, row, or cell for setting background color, bug 7992, r=kin. Renamed overloaded GetDocumentTitle to GetDocumentTitleString and set new URL of saved page in webshell, bug 23726, r=mjudge
2000-01-13 23:33:00 +00:00
a5fc421d20
fixed bug 20613 & 21121: both invloved newlines in preformatted text. Layout gives no frames for blanklines caused by newlines, so you cant click or arrow to them. I replace such newlines with breaks now.
fixed 21196: select all no longer selects the special break we use in empty documents (this would cause an invisible selection).
fixed 21430: choosing a new alignment in an empty doc used to do nothing. Now it works but I've exposed a selection bug inthe process...
fixed 22225: a little unintended re-entrancy caused multiple breaks to be inserted in empty table cells when doc read in.
2000-01-13 10:17:35 +00:00
bd90662588
removed the hard-coded font for text editor controls
...
b 17303 r=buster
2000-01-12 15:37:39 +00:00
e171985f93
fix for 23551: plaintext mail quoting broken. editor rules code was unaware that we were utting html elements into plaintext (namely pre, used to contain the quote). fixed.
2000-01-12 02:58:57 +00:00
54bd51b737
fix for bug 23595: lines permuted by forward delete of a break. one line fix - some misordered parameters.
2000-01-12 02:20:24 +00:00
cf64a5c902
23335: Don't return error codes from the editor controller; the resulting JS messages just confuse the user. r=mjudge
2000-01-11 23:42:15 +00:00
698852a4f4
Converting usage of ::GetIID() to NS_GET_IID().
...
Bug #20232 , r=scc@netscape.com
2000-01-11 20:49:15 +00:00
1f37b81420
fixing VC5 build (missing return value)
2000-01-11 01:25:00 +00:00
7f37ccf2d2
not all compilers created equal
2000-01-10 10:44:18 +00:00
81a137561c
fix for 11994, an IME bug. (accidentally left out of prior checkin)
2000-01-10 10:20:51 +00:00
e72a2924a8
added in some rules code for mail quoting. This
fixes bug: 19979 (extra blank line showing up in
mail that has quotes)
partial progress on block transformation work:
unlisting a list now works mostly correctly again,
instead of merging all the former list items into
one run of text (no bug number).
Moz-br's are now added in one more circumstance:
when you have a br at the end of some inline
content that is followed by a new block (like a
list, table, etc.). This is needed for the same
reason that the other moz-br's are: to generate a
blank line that the user expects after hitting
return. (no bug number)
DTD-related work to enable the editor to check if
you should be able to type given the current
selection.
fixed bug 22944: inserting an <A> in a table
splits the table.
Made some progress on text paste performance, but
it's still too slow. That's 19273, which I'm
leaving open
fixed bug 15258: selection capable of getting out
of the body element.
fixed a bug where code that merged adjacent text
nodes would merge the non-editable "formatting"
textnodes, (no bug number). Added code to prevent
selection from ending up inside a non-editable
text node.
fix for 11994, an IME bug.
2000-01-10 10:13:58 +00:00
8c236a7d13
23169: Fix uninitialized variables, including one which was disallowing splitting lines by hitting return. r=jfrancis
2000-01-06 22:35:04 +00:00
b99928a9c0
fixing warnings
2000-01-06 00:16:18 +00:00
6229129616
continuing the war on the Case Of The Happy Caret
2000-01-05 12:24:10 +00:00
0b23aa43ac
22655: add API to allow specifying charset when inserting/quoting html. r=rhp
...
16015: Add API and implementation for delete-to-beginning (^U). r=slamm,rhp
490: Insert formatting newlines when inserting new nodes. r=rhp
2000-01-04 20:38:12 +00:00
af019e592d
Fixing unix bustage.
2000-01-04 04:28:39 +00:00
c207257f01
adding construct-time value for an editor member bool.
2000-01-04 04:24:04 +00:00
d6e95890c8
Fix for bug 21346.
This is actually a major reworking of how the low level editor txns perturb selection. There is a mode now for telling the txns not to disturb the selection. There is also a fix for unlisting lists (sometimes list items got merged unintentionally when unlisting).
2000-01-04 03:09:41 +00:00
efb687dcad
Changing a char array to a PRUnichar array, to fix a build
...
warning. r=sspitzer.
1999-12-29 03:45:26 +00:00
03ce06ed8d
fixed bug 21032 ([regression] can paste multiple lines of text into a single-line text control)
...
when we were using <BR>'s in plaintext, this wasn't an issue.
when we switched to using \n, we needed to put in an extra check to transform CRLF to space.
partial fix bug 20387 (scroll bars appearing in single line text control)
part of the problem is we were leaving an empty text node lying around after inserting the bogus <br>
this induced layout to add a line after the <BR>, making the document in an empty text control too tall
Kin still has the task of hiding the scroll bar in certain situations, but this was the right thing to do
anyway.
r=kin
1999-12-24 15:48:48 +00:00
dc92b5dab3
fixed bug 22228
...
r=dcone
For this part of the fix, removed a precondition check for a null input param. It's legal (and necessary) here.
1999-12-23 21:02:45 +00:00
a45b5daae1
backing out change and reopening bugs 17303, 19426, the default case where input isn't specified
...
causes a lot of problems becuase of the style it needs.
r=self
1999-12-23 20:13:46 +00:00
9192125ad9
Fixed bug 22072, loading style sheet in editor. a=jar, r=brade
1999-12-22 23:57:04 +00:00
6bd2f7ab0c
Changed write string for "paragraphFormat" to "SetParagraphFormat()"
...
to get log playback working again.
r=buster@netscape.com ,cmanske@netscape.com a=don@netscape.com
1999-12-22 19:44:00 +00:00
f06bddeda0
removed the hard coded font-family in the PlaintextInitalStyle for the set flags
...
r=buster bugs 17303,19426
1999-12-22 19:41:11 +00:00
982fa55c82
partial fix for bug 15533 (size part). 1. change the return value from nsPiont to nsRect. Change widget code to reflect the change. In Gtk, change XIM FontSet based on the rect height. r=cata a=chofmann
1999-12-22 07:56:40 +00:00
d8c1142ecd
don't prompt to save changes to an empty/new window (bug #13933 ) fix by sfraser r=brade
1999-12-21 15:27:54 +00:00
e328b78703
Fix for bug #21683 : [dogfood] Can't set focus to end of reply message to type
...
Added beginRulesSniffing local variable.
r=jfrancis@netscape.com a=chofmann@netscape.com
1999-12-16 00:59:08 +00:00
a622c90955
Fix for PDT+ bugs 21602 and 21648. r=joki
1999-12-15 22:04:43 +00:00
c8e34eada6
adding in nsEditorController to makesystem. adding in registration to allow someone to get an editorcontroller from the outside. also change editor shell to register a controller to handle keyboard navigation.
1999-12-15 03:46:27 +00:00
b8c817d186
dont need that line good catch sfrasier.
1999-12-15 03:39:09 +00:00
74e5502586
adding new files first stage of massive checkin for key bindings
1999-12-15 03:26:29 +00:00
2f7ffefaf4
21534 (part of 18033 and 18046): handle delete word and to-end functionality
...
outside of any selection batching (didn't work when inside a batch).
r=jfrancis; part of Mike's 18046 fixes which are a=chofmann.
1999-12-14 23:07:12 +00:00
0cd5eba60e
fixes for bug 21030. again. really.
21030: html mail reply won't quote original message
r=kin; a=brendan
1999-12-10 23:16:02 +00:00
121c8cdc07
bug 21378
...
r=rods
a=chofmann
changed CanUndo and CanRedo to return the right value. They were returning the opposite of what they ought to have returned.
1999-12-10 21:43:52 +00:00
c3b2fbc5fd
fix bug 19358 r=jfrancis add IME force commit for Undo,SelectAll and Paste
1999-12-09 22:37:36 +00:00
4d99b4999b
fix bug 19358. r=jfrancis . Forece commit when we Undo, SelectAll or Paste
1999-12-09 22:35:17 +00:00
f5410887be
fixes for bug 21158 and 21030.
21158: aplying text style deletes text
21030: html mail reply won't quote original message
r=kin; a=chofmann
1999-12-09 21:12:16 +00:00
c5a3d00653
fix bug 12090 19358. Implement ForceCompositionEnd and add it in the beginning of AddInlineProperty/RemoveInlineProperty/InsertElement/InsertHTML
1999-12-08 03:39:36 +00:00
167f9c0b74
fix for 20457: deletion in editor pretty darn screwy. Lots of changes to improve this. Document modifying entry points in editor now go thru a standard sandwich, which allows tracking of what changed in the doc, which allows proper post-processing of what changed. Also, all deletions now go thru the rules code, if applicable. Also some bugs in tracking the changed document portion have been fixed. Finally selection setting after a delete is improved.
1999-12-07 08:30:19 +00:00
5d9824b4bd
add query composition event which get current curosor position. add timer base IME x y location query for gtk. r=erik. fix bug 17916 20550
1999-12-07 01:29:00 +00:00
f30ee6edc8
Finished basic table editing (bug 6256) r=mjudge. Fixed XUL so debug-only plain text editor works. r=akkana
1999-12-07 01:12:10 +00:00
c7b0e3bedd
fix for bug 19130 - hitting escape during ime entry can leave editor without a caret. r=kin
1999-12-05 00:29:34 +00:00
6e3e75173d
Finished fix for 13695 (r=danm), basic table editing (bug 6256): cpp r=mjudge, related UI work r=brade
1999-12-04 01:46:23 +00:00
1cf2db67a5
For bug 17325. Changed signature of css loader methods. R=nisheeth.
1999-12-04 01:29:18 +00:00
520e982ed0
18033: Editor changes to use the new nsISelectionController interface.
...
Triggered from key events. Untested since the nsISelectionController
implementation isn't in yet (bug 18046), but key events do call
the stub routines. r=mjudge
1999-12-02 21:47:30 +00:00
177ceca5a4
Fixed bugs 18529, 20289; lots of progress on table editing (bug 6256). Other UI fixes: New color picker UI, added more missing menu items such as align, increase/decrease indent; moved 'Choose File' button to overlay to share by Image, Link, etc. dialogs. r=sfraser,akkana
1999-12-01 22:20:50 +00:00
8a9d883cea
warning cleanup, plus found an uninitialized int variable that I initialized to 0.
1999-12-01 15:29:52 +00:00
3aed7992fd
* fix for PDT+ 16481: need rules for deleting in tables
* fix for 19395: protect against zero length text inserts
r = floppy moose
1999-12-01 14:32:55 +00:00
55be244e29
change debug code.
1999-12-01 00:35:31 +00:00
f5c7841eae
fix for bug 20205: selection was getting jerked around by whitespace conversion code.
1999-11-30 21:58:37 +00:00
680a88820a
20348: Make alt the modifier for Unix, and generally clean up code. r=brade
1999-11-30 21:58:00 +00:00
8257b5e853
fixing iid of nsIAbsorbingTransaction
1999-11-30 14:31:47 +00:00
2db26922a6
Landing no_neckoutil2_branch. Bug #11159 . Removes neckoutil_s.lib from build which helps beos and openvms.
1999-11-30 04:50:42 +00:00
3e67aed56d
removing obsolete d&d code and changing from CID's to progID's in d&d code. r=akkana.
1999-11-30 00:10:55 +00:00
ad4a38b0d2
eat drag gesture events for now. r=saari
1999-11-29 22:35:35 +00:00
24d00a0b59
18714: make InsertAsQuotation methods leave the insert point after, and outside, the node that was inserted. r=rhp
1999-11-29 21:15:57 +00:00
d4edc684b8
* ported the html editor work for the "caret doesn't move when i hit return" bug (16715) back to the plaintext editor.
* fixed a paste/rules interaction problem (19367)
* introduced an init time pass over html documents to populate empty list items and table cells with special breaks so that the user can click in them and actually get a caret
* fixed some warnings
r = floppy moose
1999-11-29 08:28:46 +00:00
757b1fce03
18033: Add editor API for delete methods, and hook up an initial
...
set of emacs key bindings for Unix. r=jfrancis
1999-11-25 04:11:51 +00:00
65fcafbd6e
cool! i cant believe it's not butter! (how did the mac ever compile this?)
fixing bizarre cut/paste error.
1999-11-25 01:34:42 +00:00
faa87d9226
fixing bad comptr usage (also not caught by mac compiler)
1999-11-25 00:39:55 +00:00
c21e8c7d35
fixing bad const in interface (not caught by mac compiler)
1999-11-25 00:36:34 +00:00
7e43f8caf0
implemented a system to track what portion of a document is affect by an editor action. Used that system to help solve extensive whitespace handling problems, ans also problems with caret placement in response to returns (this lattter fix for html editors only - plaintext coming later). Fixed numerous list bugs involving outdenting, unlisting, and splitting lists.
Checkin addressees these bugzilla bugs:
2073 & 12337 - whitespace trouble when typing (you can end up with all nbsp's instead of spaces)
1999-11-25 00:19:45 +00:00
73aafabe8e
implemented a system to track what portion of a document is affect by an editor action. Used that system to help solve extensive whitespace handling problems, ans also problems with caret placement in response to returns (this lattter fix for html editors only - plaintext coming later). Fixed numerous list bugs involving outdenting, unlisting, and splitting lists.
Checkin addressees these bugzilla bugs:
2073 & 12337 - whitespace trouble when typing (you can end up with all nbsp's instead of spaces)
16715 - caret gone or wrong after hitting return
16988 - aim foiled by our mozDIVs
17908 - enter at end of document does nothing
16085 - 4.x mail replied foiled by mozDIVs
19368 - inline style lost after typing return
17059 - "normal" made a paragraph, but typing made a div. Now they both just use direct text in the body (or wherever)
18717 - exiting list gives UBER caret (note: this will only be fixed most of the time, not all)
17778 - cant type beside an image (it ends up above or below it) - this was a rather strange ramification of the old mozDIV
rules which are now gone.
1999-11-25 00:16:56 +00:00
e8544d1c6c
19610: Change InsertAsQuotation API to return inserted node r=rhp
1999-11-24 20:48:59 +00:00
bc95e3bdf7
- Converting to nsGenericModule
...
- Removed exported NS_New*()
- Using NS_IMPL_ISUPPORTS[0-9]
r=akkanna@netscape.com
1999-11-22 21:03:04 +00:00
76ebca28db
Fix for bug 17937. nsHTMLEditor::DeleteSelectionAndCreateNode() wasn't addref'ing an out parameter. r=sfraser.
1999-11-22 00:01:18 +00:00
e727552d0d
during CloneAttributes, delete all the nodes attached (not half of them); discovered when fixing bug #14750 ; r=kin@netscape.com
1999-11-18 20:34:15 +00:00
19b36f49a8
Improve the problem of excessive whitespace around <pre> quotes in
...
plaintext mail (r=mcafee).
Also, 19237: an initial fix for html quoting (html source being
inserted outside the blockquote).
1999-11-18 19:43:14 +00:00
e7d9c4d3be
Use Recycle to free nsStrings; and fix a warning
1999-11-18 19:40:30 +00:00
c1577ee83e
fix for blocker bug #19083 , compose html message causes a crash.
...
r=sfraser.
1999-11-17 22:34:41 +00:00
3513eb0058
some fixes for deletion and also selection movement, contributed by Steve Clark. fixes bug 18537 (backspace can delete entire line); r = buster
1999-11-17 11:30:39 +00:00
ab64f11257
improved fix for bug 15696 (leaking an atom). r=floppy moose
1999-11-17 11:26:41 +00:00
54f5ef35c3
rewrote GetFirstEditableNode() / GetLastEditableNode(). This fixes bugs: 18922, 18938, 18723; r=floppy moose
1999-11-17 11:03:25 +00:00
2d4081b417
fix bug 14624 (don't handle tab key twice). r=kin@netscape.com.
1999-11-16 14:41:03 +00:00
a5b6b4dd48
fix bug 18892 (r=kin@netscape.com); change constant to PRUnichar
1999-11-16 14:40:11 +00:00
65a3476676
pork jockey paint fixes. bug=18140, r=kmcclusk,pavlov
1999-11-14 02:51:25 +00:00
cade4ed318
Partial fix for 14344(Page Properties) and 18774(Increase/Decrease Font Size). Fixed 18234 (move Advanced Edit button), 18485 (don't prompt for title with Save As), 16714 (undefined value for para. property combobox) and 18494 (add filename to window caption). Improved Image Properties dialog and CSS style for toolbars. Added new Composer icons. r=sfraser
1999-11-13 16:37:58 +00:00
1a67e1996b
18576: Enclose plaintext replies in a <pre> so they don't get wrapped,
...
and add appropriate edit rules to split pre tags when editing plaintext.
r=sfraser
1999-11-13 00:26:45 +00:00
3593052cd6
Oops, citer classes weren't initializing refcount, causing an assert on Windows. One-line change, r=rhp
1999-11-12 00:57:55 +00:00
ef66dcd123
TransactionManager fix for bug #11590 : eliminate NS_COMFALSE
...
Modified all nsITransactionListener::Will* methods and implementations
to use an aInterrupt argument.
mozilla/editor/base/nsEditorTxnLog.cpp
mozilla/editor/base/nsEditorTxnLog.h
mozilla/editor/txmgr/public/nsITransactionListener.h
mozilla/editor/txmgr/src/nsTransactionItem.cpp
mozilla/editor/txmgr/src/nsTransactionManager.cpp
mozilla/editor/txmgr/src/nsTransactionManager.h
r=brade@netscape.com
1999-11-11 19:35:40 +00:00
86f919a325
partial fix for bug 14599. We no longer crash. The frameset loads in the editor window,
...
but no editor is actually attached, so no editing is possible. Next step is
to detect the error case and stop the document load altogether.
1999-11-11 19:22:30 +00:00
6c385061f6
16803, 17341: Enable unicode paste. Code from nhotta, r=me. Also re-enable plaintext paste
1999-11-10 23:42:11 +00:00
142ac52eaf
updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org
1999-11-06 03:43:54 +00:00
f535f208dc
Switching to use NS_WITH_SERVICE macro as specified in (5403); removing spurious clipboard service instance in nsEditorEventListeners.cpp. r=akkana, a=chofmann.
1999-11-05 01:29:49 +00:00
0b73e32c85
bug 17744; a=choffman; r=floppy moose
1999-11-05 00:46:06 +00:00
c1a800f31c
Fix key event bustage: treat DOM_VK_RETURN and DOM_VK_ENTER equivalently. r=ftang,joki a=chofmann,leaf
1999-11-03 22:05:45 +00:00
1675be15e0
Changes to DOM events to accomodate the new breakdown of events into mouse and key events. This fixes a couple of bug, though the main one is 13406. Involves changes to multiple DOM generated file as well as fixing up usage of DOM event api usage in editor, rdf, and xul. r:vidur
1999-11-03 07:11:45 +00:00
1e84beb217
fix for 17673;r=sfraser
1999-11-03 00:07:37 +00:00
bee74e223b
Removed unused NECKO ifdefs.
...
a=leaf
1999-11-02 23:34:03 +00:00
b92307002b
changed bogus node type to br to get rid of annoying space in empty editors; r=kin
1999-11-02 21:35:21 +00:00
f847d9f9a4
fixed bug 17689 r=jfrancis
1999-11-02 05:16:41 +00:00
e04693d65a
Changed NS_NOTREACHED to be NS_WARN_IF_FALSE() so as to not crash everyone. r=sfraser.
1999-11-02 05:12:05 +00:00
09503b80da
Changed NS_ENSURE_NOT to NS_ENSURE_FALSE to reflect API change. r=hyatt
1999-11-01 21:27:09 +00:00
39466c4797
Changed NS_ENSURE_NOT to NS_ENSURE_FALSE to reflect API change.
1999-11-01 21:25:52 +00:00
f5c0eec556
fixes for bugs: 16361,12253,15696,15734; r=sfraser
1999-11-01 15:15:35 +00:00
ea13be0a26
Move all nsIEnumerator usage over to NS_ENUMERATOR_FALSE from NS_COMFALSE in anticipation of nixing NS_COMFALSE in the near future.
...
r=scc
1999-10-28 03:16:48 +00:00
5996f2a7f1
fix for 17056: making a list in empty doc didnt work; also making a new list item didn't work. r=floppy moose
1999-10-27 23:44:33 +00:00
c4deb92eb0
add debugging code. fix remove last uncomited IMEText. r=jfrancis
1999-10-27 22:56:36 +00:00
341c8b0054
Ooops.. tree closed, better back these out for now. Sorry.
1999-10-27 21:01:37 +00:00
55276cc3c4
Move all nsIEnumerator usage over to NS_ENUMERATOR_FALSE from NS_COMFALSE
...
in anticipation of nixing NS_COMFALSE in the near future.
r=scc (please contact him should there be any build issues)
1999-10-27 20:24:21 +00:00
243238b9c0
implement input method highlight. r=tague
1999-10-27 00:10:03 +00:00
618ed72e8d
Fixed bugs 6278, 9758, 17014, 17071, 17160. r=sfraser,mjudge
1999-10-26 23:13:00 +00:00
1486d36542
fix IME assertion problem . r=jfrancis
1999-10-26 20:04:47 +00:00
c89d94b9e9
reworking editor IME supoprt; r=kin; bugs: 13576, 11878, 11994, 13494, 16432
1999-10-26 18:54:47 +00:00
2d47aab79e
16706: Call the rules code to delete the bogus node before inserting html, to fix the new mail reply code. r=jfrancis
1999-10-21 21:51:47 +00:00
f53c9c41ba
Removal of calls to PR_MumbleMonitor, which were way too heavy-handed for the job. Replaced with PR_AtomicInc/Decrement. part of module sweep, r=morse, pavlov
1999-10-21 05:36:21 +00:00
b00215d892
do not do TypedText if the character code is 0. r=brade. Fix bug 16570 and 16811
1999-10-20 21:01:20 +00:00
56f9652bab
16844: modifier key presses shouldn't insert anything into the editor. r=brade
1999-10-20 20:02:44 +00:00
e7457117e4
Fixed bugs 12515, 16493,16494,16495,16692,16794,most of 9758. Replaced old 'target' icon with interim 'anchor' icon. r=sfraser
1999-10-20 14:15:25 +00:00
38b35cdb7d
some extremely minor cleanup of bugs found by ftang. Thanks, frank.
1999-10-18 21:59:19 +00:00
6df0b49bc8
1. add asserting code to check null ptr
2. add if code and return NS_ERROR_NULL_POINTER if the ptr is null
3. add code to check return value
r=myself
1999-10-18 14:48:41 +00:00
d9fd3b16e8
fix bug 10434, memory leak detection, r=sfraser
1999-10-16 19:34:10 +00:00
2029fcbfca
use the proper function calls to get the status for alt, shift and meta keys. bug #16486 . reviewed valeski@netscape.com
1999-10-15 21:20:57 +00:00
b1a69f1bd1
don't allow other modifiers when cut/copy/pasting (bug #15693 ); this missed the keyEvent branch. r=kin@netscape.com
1999-10-15 14:52:45 +00:00
850606d07a
landing keyEvent_19991004_BRANCH
...
bugs # see the log of the check in into branch
author/reviewer:
mozilla/layout/base/src/nsRangeList.cpp brade/mjudge
mozilla/layout/html/forms/src/nsGfxTextControlFrame.cpp brade/ftang
mozilla/layout/events/src/nsDOMEvent.cpp brade/joki
mozilla/layout/events/src/nsEventStateManager.cpp brade/joki
mozilla/widget/public/nsGUIEvent.h akkana/ftang
mozilla/widget/src/windows/nsWindow.cpp ftang/mjudge
mozilla/widget/src/windows/nsWindow.h ftang/mjudge
mozilla/widget/src/mac/nsTextAreaWidget.cpp brade/ftang
mozilla/widget/src/mac/nsMacEventHandler.cpp brade/simon
mozilla/widget/src/xpwidgets/nsKeyBindMgr.cpp brade/ftang
mozilla/widget/src/gtk/nsGtkEventHandler.cpp akkana/?
mozilla/widget/src/gtk/nsWidget.cpp erik/ftang
mozilla/layout/xul/base/src/nsTreeCellFrame.cpp brade/ftang
mozilla/editor/base/nsEditorEventListeners.cpp brade/akkana
mozilla/editor/base/nsHTMLEditor.cpp brade/akkana
mozilla/rdf/content/src/nsXULKeyListener.cpp ftang/saari
fix the master bug- 15693
fix at least, but not limited to, the following bugs
10158,11956,6053,9333,10901,14348,6449,11845,13016,14410,15657,15307,15842,13856
1999-10-14 18:27:01 +00:00
b735dfc765
fix bug 10434, memory leak detection, r=kin
1999-10-14 13:50:36 +00:00
711c0f72c9
Fixed bugs 16204, 16118, 15831,15448,14342(partial) r=mjudge
1999-10-14 00:13:27 +00:00
bdfcaec321
Bug 16105. (Bugsplat 366256.) Ensure that nsISupports::Release() calls dtor only once by 'stabilizing' refcnt to a non-zero value before invoking the dtor. See also news://news.mozilla.org/37FD0F3C.3078AE5C%40netscape.com. r=scc,fur
1999-10-12 03:05:10 +00:00
65f6ba5343
Cleanup moz-decl-counter usage and fix NS_LOG_ADDREF usage
1999-10-08 20:41:19 +00:00
1a165ddf9b
fixed my part of bug 15814 (Cleanup build warnings)
...
so trivial, no reviewer needed
fixed my part of bug 5403 (Services improperly released: Use NS_WITH_SERVICE)
a handful of subtle error handling bugs were fixed as a side effect
r=Akkana
1999-10-08 14:39:20 +00:00
7ac62b03ca
Whoops, backed out last check - wasn't supposed to land it
1999-10-07 20:46:50 +00:00
94df0dc557
r=kin; Added in ctor/dtor counts
1999-10-07 20:45:56 +00:00
7a638a9c93
fixed some space leaks reported by kipp. no bug #, r=tague
...
added some assertions and error checking to nsEditor::Do, no bug #, r=kin
fixed bug 14898 (implemented type-in state for any context), r=jfrancis
1999-10-06 20:27:41 +00:00
c412022f4a
revised rules system api to include "handled" parameter and ceased to overload the meaning of the "cancel" parameter; added TypedText() method to editor, editorshell, and logging, so that logging will work properly with typing; coallesce deletions for undo purposes r=buster@netscape.com
1999-10-06 19:34:09 +00:00
db0e490c2c
Bug fix 15017, reviewed by akkana. Override SetDocumentCharacterSet for HTMLEditor to update META charset tag if exists.
1999-10-04 23:50:27 +00:00
dbaron%fas.harvard.edu
mjudge%netscape.com
cmanske%netscape.com
akkana%netscape.com
ftang%netscape.com
rickg%netscape.com
tajima%eng.sun.com
blizzard%redhat.com
sspitzer%netscape.com
jfrancis%netscape.com
sfraser%netscape.com
kmcclusk%netscape.com
kin%netscape.com
pinkerton%netscape.com
pp%ludusdesign.com
buster%netscape.com
nhotta%netscape.com
jst%citec.fi
rods%netscape.com
mcafee%netscape.com
bryner%uiuc.edu
brade%netscape.com
saari%netscape.com
vidur%netscape.com
warren%netscape.com
dp%netscape.com
nisheeth%netscape.com
beard%netscape.com
dmose%mozilla.org
joki%netscape.com
cls%seawood.org
tbogard%aol.net
braddr%puremagic.com
morse%netscape.com
waterson%netscape.com
kipp%netscape.com