With multiple windows, a browsing context being active doesn't guarantee
being in the active window, so we explicitly check for that. We need to
introduce an special case for the initial document because the initial
document in the active window requesting focus breaks focusing the
urlbar on a new window.
Differential Revision: https://phabricator.services.mozilla.com/D104326
ProfileBufferCollector::SamplePositionInBuffer() and BufferRangeStart() need to provide indices in the same main buffer, because they will be used to discard old data (at some previous `SamplePositionInBuffer`) once the `BufferRangeStart` indicates that it is not referenced by the profiler anymore.
Because the periodic sampler uses a local buffer (to avoid allocations and locks), we need to record the special location from the main profiler buffer in ProfileBufferCollector.
Differential Revision: https://phabricator.services.mozilla.com/D104497
When binding delegates blur() to BrowsingContext::Blur, the remote side skips
the check given that there is no js on the stack, but we should not skip the
check. This only affects design-mode which allows the focus moving to the root
element.
Differential Revision: https://phabricator.services.mozilla.com/D104008
Automatic update from web-platform-tests
[selectors] Move :focus-visible on <select> test to internal test
Browsers don't agree on when :focus-visible should match or not
when a <select> element is clicked, and the spec leaves it open
to each browser to decide what to do (see
https://github.com/w3c/csswg-drafts/issues/5822).
So this patch removes the <select> element from
external/wpt/css/selectors/focus-visible-002.html
and puts it on an internal test:
wpt_internal/css/selectors/focus-visible-select-001.html
BUG=1148007
Change-Id: I6649ce6355aafc79b2fa3d258b2b69fa5a259ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644906
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#851627}
--
wpt-commits: 73750495de8e763f668f51c10c096dbf10f65d5f
wpt-pr: 27288
Automatic update from web-platform-tests
Don't send SameSite=Lax cookies on cross-site, non-top-level requests
This fixes a bug which was sending SameSite=Lax cookies on cross-site,
*non*-top-level requests when the site-for-cookies was same-site with
the request URL. If the request is not strictly same-site, we should
only be sending Lax cookies when the site-for-cookies is same-site with
the request URL, *and* the request is a top-level navigation. Similarly
for accepting cookies set on responses.
This implements the fix behind a flag (default enabled) to allow
reverting to the old behavior if there is too much site breakage as a
result of the fix.
Bug: 1166211
Change-Id: I2cebf8011010903cd016d7d7c1a32bf84aa325ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2653663
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851323}
--
wpt-commits: 4cd02119fd232ecc2a57d462d509c7ca299a3591
wpt-pr: 27469
Automatic update from web-platform-tests
Rewrite and add to wpt/cookies/http-state/ordering-tests.html
Here's a mapping from the legacy http-state/ordering-tests.html to its
new location which will have a cookie with some variation of test=N in
it:
ordering0001 => test=1
There's also a couple of few new tests added here.
This CL also removes the remaining unused http-state resource files and
moves the domain tests up a directory.
Bug: 1171495
Change-Id: Ifc567ab42fbd13858975019a7f0e4b0e2571df76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676913
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851320}
--
wpt-commits: d85c529125aea58eee34416b4ecc7566991658dc
wpt-pr: 27511
Automatic update from web-platform-tests
Prevent focused element from moving documents
Without this patch, it would be possible for Document::FocusedElement to
return an element which isn't in the same document, which is very
problematic.
Fixed: 1172828
Change-Id: I1a9492b27e16067cda70e0a0c9cf94bb241a4c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2674404
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851294}
--
wpt-commits: 201e3d154bea8cadab315859edda09ef77e03dc6
wpt-pr: 27496
Automatic update from web-platform-tests
Move NEL tests to new reporting endpoint
Change-Id: I1cf3b0a8bea265b394894e8ea6272a63651290d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675646
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851255}
--
wpt-commits: a42cfd7d541989e7d6cc20ec1699baf1ef59e5cb
wpt-pr: 27514
Automatic update from web-platform-tests
Extend supported range of 'cjk-heavenly-stem' and 'cjk-earthly-branch'
The two counter styles are officially specified as 'fixed', supporting
only a fixed range. However, the legacy implementation has been
supporting them as alphabetic counter styles. So this patch extends
their ranges to match the existing behavior.
This patch also enables WPT tests in css/css-counter-styles as a
verification. The ref files are added using the same method as
crrev.com/c/2674491
Bug: 687225
Change-Id: Ifc4a6b5240c0f718ef4746bfe9501258adb85112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676426
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851233}
--
wpt-commits: 2f9d75ef9570f1b55842aa15820f855468c69d77
wpt-pr: 27495
Automatic update from web-platform-tests
Add ref files to WPT tests in css/css-counter-styles (p3)
This patch adds ref files mechaninally using the same method as
crrev.com/c/2674491.
Note: for these counter styles, our supported ranges are larger than
the officially specified ranges. Therefore, there are some expected
failures, which are added to NeverFixTests.
Bug: 687225
Change-Id: I194a28ae9d72a0498a815ad1b0c141a52b3cc7bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676832
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851230}
--
wpt-commits: 75beb1c65bc397272288d2f7ace1efcf9e361b04
wpt-pr: 27494
Automatic update from web-platform-tests
Fix encoding of the suffix of CJK counter styles in UA style sheet
Many CJK counter styles use "、" (U+3001) as the suffix. This patch
properly escapes it in the UA style sheet to make the encoding correct.
As verification, this patch also adds ref files to the related WPT
tests. The new ref files are mechanically generated using the same
method as crrev.com/c/2674491
Bug: 687225
Change-Id: I4f29f17c290e21906601d8366a6a7db7d67b02a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676274
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851227}
--
wpt-commits: bd0b89fda830c89ffcce3313e384d7f282e2ae9b
wpt-pr: 27493
Automatic update from web-platform-tests
[Permissions Policy] Add WPT test on opaque origin matching
This CL adds a WPT test to verify permissions policy behaviour on
sandboxed iframes.
Bug: 834302
Change-Id: I92807250f51141f44f2029119a1a0ae8e7cd9a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676325
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#851117}
--
wpt-commits: edbbd20f6ece3cc0a6fb3b9526896927cbe91b73
wpt-pr: 27491
Automatic update from web-platform-tests
[python3] Remove most uses of six in tools/manifest/
The exception is a single usage of ensure_text, which is not trivially
replaceable.
--
[python3] Remove usage of six from tools/webdriver/
--
[python3] Cleanup a few misc uses of six in tools/
--
wpt-commits: 57b63e53344e52ed44dbad5e315af93d66391c44, 57d726a4f79d592688c7c54216dc82fbca739ba3, c16a8c87cbb0d7cd82607bf21bcc532add3c8c08
wpt-pr: 27479
Automatic update from web-platform-tests
[css-contain] rename files in vendor-imports that also exist in the main suite
A number of filenames are used in both css/css-contain/ and
css/vendor-imports/mozilla/mozilla-central-reftests/contain/ but aren't
the same tests, having different authors and structure.
In order to make a merge of the directories easier, first rename as few
files as possible in vendor-imports to avoid all name clashes.
Part of https://github.com/web-platform-tests/wpt/issues/8615.
--
wpt-commits: b6d3b75f7d681a623aeb46213590d30a170460db
wpt-pr: 27487
Automatic update from web-platform-tests
[css-contain] Fix broken spec URLs in vendor-imports
These were 404. The new URLs (including the anchors) all exist.
--
wpt-commits: 9a4dd43c5219234455502bed628bc43acba59ab8
wpt-pr: 27488
Automatic update from web-platform-tests
Remove all reftest.list files in css/vendor-imports/
These files are apparently not needed, and updating/removing them
individually when moving tests out of vendor-imports is a nuisance.
--
wpt-commits: 438efcc6f379ccd8c78ea67f78393ba0776d8227
wpt-pr: 27485
Automatic update from web-platform-tests
Define blink::mojom::KeepAliveHandleFactory
We've used blink::mojom::LocalFrameHost to issue KeepAliveHandles for
requests with keepalive set. That doesn't work for keepalive requests
initiated in unload handlers in nested frames, because the
RenderFrameHost object is destructed without waiting for the end of
unload handlers.
This CL defines a separate interface, KeepAliveHandleFactory. The
renderer side gets a mojo::Remote for KeepAliveHandleFactory long before
the frame is destructed, in order to avoid the above problem.
Bug: 1161196
Change-Id: I92ef0073548d8755e42bc69f957e518a73d9e52a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675428
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850990}
--
wpt-commits: 8b7b27c5024e94bbde3cf980f60df94e5b10887c
wpt-pr: 27483
Automatic update from web-platform-tests
Update `SlotAssignmentMode` to `name` from `auto` to match the latest proposal (#27256)
[By the latest proposal](https://github.com/whatwg/dom/pull/860),
`SlotAssignmentMode` value is changed to `name` from `auto`.
This change follows it.
--
wpt-commits: 875f4c73ec1122cd0ea05580f6b56fda0ef71cc7
wpt-pr: 27256
Automatic update from web-platform-tests
Resolve Service Worker redirects based on the response
We currently resolve Service-Worker-forwarded location headers using the
request. While this matches Firefox, this does not match the spec or
Safari's behavior. Instead, the spec says to resolve the location header
based on the response's URL.
This comes up if the FetchEvent was for /, but the Service Worker
responded with ev.respondWith(fetch("/foo/", {redirect: "manual"})). In
that case, a Location: bar.html header would result in /bar.html by our
version and /foo/bar.html by the spec's version.
Align with the spec. This makes the redirect go where it would have gone
under {redirect: "follow"}. This has two platform-visible behavior
changes:
- First, cases like the above will result in a different URL.
- Second, script-constructed Response objects do not have a URL list. If
the URLs are absolute, this works fine. If they are relative, those
fetches will now result in a network error. Note Response.redirect()
internally constructs absolute URLs, so those continue to work. This
only affects ev.respondWith(new Response(... location: "bar.html"}})).
Both of these changes match Safari.
Note that, as of writing, the Fetch spec describes this behavior in
terms of a location URL property on the response object. This would
require computing the location URL earlier and preserving it across many
layers, including persisting in CacheStorage. See
https://chromium-review.googlesource.com/c/chromium/src/+/2648648.
Instead, this CL uses the equivalent formulation in
https://github.com/whatwg/fetch/pull/1149. See also discussion in
https://github.com/whatwg/fetch/issues/1146.
Bug: 1170379
Change-Id: Ibb6b12566244fd259029e67787dd7f08edeece9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2665871
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850874}
--
wpt-commits: 020c59f0ae3ce0a5649c8e811faca2101d947d63
wpt-pr: 27444
Automatic update from web-platform-tests
[FSA] Allow seeking past the end of a file
Currently, we reject all attempts to write past the end of a file. This
change makes the API more consistent with the behavior of POSIX.
If writing at an offset past the end of a file, the null bytes between
the old end of the file and the offset will count towards the file's
quota.
Adds Quota tests to the SandboxFSW.
Bug: 1153385
Change-Id: Iec54acbccecb728f9375931825525ba2fbafd1ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593810
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850838}
--
wpt-commits: 9376be061ac2dabc2f60d54a525d2ca81a60589a
wpt-pr: 27146
Automatic update from web-platform-tests
[GridNG] Change IsLayoutGrid to IsLayoutGridIncludingNG
As above. This fixes a bunch of small issues. Some of the branches
are relatively difficult to reach due to layout ng being so prevalent,
but commented on the ones which clearly have associated tests.
Added a bunch of TODOs for behaviour which needs to be implemented.
Specifically:
- devtools information.
- computed-style grid-template-*, etc.
- abspos invalidation.
Bug: 1045599
Change-Id: I0c4a7aae3381e49bf2e7e3bc80247c8c8dccc73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2674359
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850751}
--
wpt-commits: 9378cebe0d791f016d1b0ecca105e10941d7a34f
wpt-pr: 27470
Automatic update from web-platform-tests
Add external/wpt/layout-instability/expand-above-viewport.html
This is the common case for why we report layout shift for
viewport-crossing shift.
Change-Id: I17c3158ef18b6f997022d8f758b6aca409e76999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2672467
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850735}
--
wpt-commits: ca30c532c22829609b81ba2068eaf4dd8d04e309
wpt-pr: 27465
Tom Schuster
Emilio Cobos Álvarez
Andreea Pavel
M. Sirringhaus
Gerald Squelart
Edgar Chen
moz-wptsync-bot
Manuel Rego Casasnovas
Hiroshige Hayashizaki
Lily Chen
Mike Taylor
Joey Arhar
Ian Clelland
Xiaocheng Hu
Philip Jägenstedt
Luca Casonato
Stefano Sanfilippo
Charlie Hu
Stephen McGruer
Yutaka Hirano
Tetsuharu Ohzeki
David Benjamin
Austin Sullivan
Ian Kilpatrick
Xianzhu Wang
Aaron Krajeski