Back when libaom was added, VPX_ASFLAGS was more or less the only
variable that had the right set of flags for NEON support, which
justified its use. However, it's not set when building against system
libvpx.
Bug 1791482 improved things, though, and VPX_ASFLAGS, as far as NEON is
concerned, is now only re-exporting NEON_FLAGS, with the same caveat that
VPX_ASFLAGS is empty when building against system libvpx.
So we should use NEON_FLAGS instead of VPX_ASFLAGS.
Differential Revision: https://phabricator.services.mozilla.com/D183310
nasm doesn't like compiling x86_abi_support.asm
(https://bugzilla.nasm.us/show_bug.cgi?id=3392738), which is actually an
include file, rather than a source file, so it shouldn't have been in
the list of sources in the first place (libvpx has a similar file that
is excluded already, for instance).
I was considering updating the vendoring script, but it turns out it
doesn't produce the current contents in-tree (which even breaks the
build), and aom is set to be removed (bug 1635296)...
Differential Revision: https://phabricator.services.mozilla.com/D105430
Back when it was added, it was added to libvpx, and the clang base
version was older. Either newer version of clang fixed the issues or
the libvpx source fixed it, but we don't need the flag anymore for
libvpx.
The flag for libaom was cargo culted from libvpx, but may not have been
necessary in the first place. Or maybe it was, but things fixed
themselves in a similar manner. Either way, the flag is not necessary.
Differential Revision: https://phabricator.services.mozilla.com/D102262
Changes:
- update sections of `generate_sources_mozbuild.py` and `cmakeparser.py` to be python3 compatible
- change import of `urlparse` to be python3 compatible
Depends on D51414
Differential Revision: https://phabricator.services.mozilla.com/D51692
--HG--
extra : moz-landing-system : lando
Consequently, this removes:
- MOZ_LIBPRIO, which is now always enabled.
- non_msvc_compiler, which is now always true.
- The cl.py wrapper, since it's not used anymore.
- CL_INCLUDES_PREFIX, which was only used for the cl.py wrapper.
- NONASCII, which was only there to ensure CL_INCLUDES_PREFIX still
worked in non-ASCII cases.
This however keeps a large part of detecting and configuring for MSVC,
because we still do need it for at least headers, libraries, and midl.
Depends on D19614
Differential Revision: https://phabricator.services.mozilla.com/D19615
--HG--
extra : moz-landing-system : lando
There aren't any, and the code to actually convert them from .asm to gas
that is expected by the moz.build is not even there, so if there were
assembly sources, it would fail to build.
Depends on D14946
Differential Revision: https://phabricator.services.mozilla.com/D14947
--HG--
extra : moz-landing-system : lando
Includes changes to support nasm's stricter include paths.
Supports falling back to yasm if nasm is missing.
Differential Revision: https://phabricator.services.mozilla.com/D9972
--HG--
extra : moz-landing-system : lando
Summary: I didn't have time to get this upstreamed prior to this update.
Reviewers: TD-Linux
Tags: #secure-revision
Bug #: 1476408
Differential Revision: https://phabricator.services.mozilla.com/D2359
--HG--
extra : rebase_source : ec43830e191d7c0d899d93f08d912c64a4eba002
Summary:
Upstream can now code generate the rtcd interface files directly from the
aom_config.h header, so we no longer have to generate an intermediate file by
running lint_config.sh. This also means we can remove the code for creating a
temporary directory.
Reviewers: TD-Linux
Tags: #secure-revision
Bug #: 1476408
Differential Revision: https://phabricator.services.mozilla.com/D2357
--HG--
extra : rebase_source : 8effc0fc61403db473fc90bc3989912b46133c3e
This changes generate_sources_mozbuild.sh to call generate_sources_mozbuild.py
to generate sources.mozbuild and config files and removes the parts of the
script that are no longer necessary.
MozReview-Commit-ID: HgXIEw93z41
--HG--
extra : rebase_source : b54d23197e741c8e037ffc4b977c8d01c34197ef
This uses the cmakeparser to generate sources.mozbuild and the
config files for each platform.
MozReview-Commit-ID: CU6oIPJXtTw
--HG--
extra : rebase_source : b9f6707ed3f4ef6336a4fa2d75c46a5c26570528
This revision of libaom has some conflicts with our vendor script
and build system. A number of new .asm files have the same basename
as .c files, which our build system cannot handle.
To work around this, I ran `./mach vendor aom` with the check for
duplicate filenames disabled, then manually renamed the conflicting
files in the filesystem and sources.mozbuild.
Also add av1_convolve_scale_sse4.c to sources.mozbuild manually.
This is needed by the build but for some reason isn't picked up
by generate_sources_mozbuild.sh.
MozReview-Commit-ID: 2iBo4kSBz1G
--HG--
rename : third_party/aom/aom_dsp/arm/idct16x16_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct16x16_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct16x16_add_neon.asm => third_party/aom/aom_dsp/arm/idct16x16_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct32x32_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct32x32_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct32x32_add_neon.asm => third_party/aom/aom_dsp/arm/idct32x32_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct4x4_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct4x4_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct4x4_add_neon.asm => third_party/aom/aom_dsp/arm/idct4x4_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct8x8_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct8x8_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct8x8_add_neon.asm => third_party/aom/aom_dsp/arm/idct8x8_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_16_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_16_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_4_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_4_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_8_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_8_neon_asm.asm
rename : third_party/aom/aom_dsp/x86/highbd_intrapred_sse2.asm => third_party/aom/aom_dsp/x86/highbd_intrapred_sse2_asm.asm
rename : third_party/aom/aom_dsp/x86/intrapred_sse2.asm => third_party/aom/aom_dsp/x86/intrapred_sse2_asm.asm
rename : third_party/aom/aom_dsp/x86/intrapred_ssse3.asm => third_party/aom/aom_dsp/x86/intrapred_ssse3_asm.asm
extra : rebase_source : 7bf598ac1a925e16e42301839376a963836ae182
Update to upstream commit id e87fb2378f01103d5d6e477a4ef6892dc714e614
from a couple of weeks ago to pick up changes.
MozReview-Commit-ID: H7H69A7qFXD
--HG--
extra : rebase_source : dee676da15b65e4eea612d20529c4fb312bbddfb
Check for filenames which differ only by .asm vs .c filename
extensions when importing a new version of the libaom reference
implementation of the av1 video codec.
These confuse our build system as well. Also remove the obsolete
vp8 and vp9 search directories, which generate warnings from 'find'.
MozReview-Commit-ID: DRZL7GUrsYh
--HG--
extra : rebase_source : 4bc8708dd3b2e386c19bd6b952ca2587a2284a19
We've been recording the commit id from the last vendor in
README_MOZILLA inside the various media directories. Since
we now support a --repo switch to pull from forks, record
this info as well, to make it easier to find contiguous
upstream source.
MozReview-Commit-ID: 1RanpkWfAeC
--HG--
extra : rebase_source : b6bd16b56626a871802822385be6f3a24db6cd50
Recent changes made this a public header, so it needs to be
available to callers like AOMDecoder.
MozReview-Commit-ID: KKXcv8bdVYj
--HG--
extra : rebase_source : 87d509a40f3b305e414067af5ed433eef8489fbc
Vendor upstream commit id f5bdeac22930ff4c6b219be49c843db35970b918
to pick up changes since the last import.
--HG--
extra : rebase_source : 6c03c7fcbffbdcf07b2b2819aee6dade2f0e2a0f
As far as I can tell, nothing uses the DISABLE_AVX define
when generating the rtcd headers.
MozReview-Commit-ID: Cc5tufOKP63
--HG--
extra : rebase_source : 6e74569759844e2682e3d16c59bfdefc095f8531
aom_dsp_rtcd_defs.pl checks only whether this key is present
in the config, not whether it is set to true or not. Our script
sets CONFIG_FOO=no for disabled options, while the upstream
build system omits them, resulting in extra symbol declarations
the build will never define.
Work around this by stripping the offending disabled config key
if it is disabled.
MozReview-Commit-ID: IyVDO2G3s3L
--HG--
extra : rebase_source : a1bb8b285f798464b8d8026c0dd4cd85595ae93d
Mike Hommey
Matthew Finkel
Tom Ritter
Edwin Takahashi
Christian Holler
Thomas Daede
Thomas Daede
Dan Minor
Nathan Froyd
David Major
Sylvestre Ledru
Ralph Giles
Chris Manchester
Ted Mielczarek